Re: [RFC v4 PATCH 41/49] multi-process/mig: Enable VMSD save in the Proxy object

2019-11-13 Thread Jag Raman
On 11/13/2019 10:50 AM, Daniel P. Berrangé wrote: On Thu, Oct 24, 2019 at 05:09:22AM -0400, Jagannathan Raman wrote: Collect the VMSD from remote process on the source and save it to the channel leading to the destination Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-

Re: [RFC v4 PATCH 09/49] multi-process: setup PCI host bridge for remote device

2019-11-18 Thread Jag Raman
On 11/13/2019 11:07 AM, Stefan Hajnoczi wrote: On Thu, Oct 24, 2019 at 05:08:50AM -0400, Jagannathan Raman wrote: +static void remote_host_realize(DeviceState *dev, Error **errp) +{ +PCIHostState *pci = PCI_HOST_BRIDGE(dev); +RemPCIHost *s = REMOTE_HOST_DEVICE(dev); + +/* + *

Re: [RFC v4 PATCH 07/49] multi-process: define mpqemu-link object

2019-11-18 Thread Jag Raman
On 11/13/2019 10:53 AM, Stefan Hajnoczi wrote: On Thu, Oct 24, 2019 at 05:08:48AM -0400, Jagannathan Raman wrote: +#ifndef MPQEMU_LINK_H +#define MPQEMU_LINK_H + +#include "qemu/osdep.h" +#include "qemu-common.h" + +#include +#include These are already included by "qemu/osdep.h". +#incl

Re: [RFC v4 PATCH 10/49] multi-process: setup a machine object for remote device process

2019-11-18 Thread Jag Raman
On 11/13/2019 11:22 AM, Stefan Hajnoczi wrote: On Thu, Oct 24, 2019 at 05:08:51AM -0400, Jagannathan Raman wrote: +static NotifierList machine_init_done_notifiers = +NOTIFIER_LIST_INITIALIZER(machine_init_done_notifiers); + +bool machine_init_done; + +void qemu_add_machine_init_done_notif

Re: [RFC v4 PATCH 41/49] multi-process/mig: Enable VMSD save in the Proxy object

2019-11-18 Thread Jag Raman
On 11/13/2019 12:11 PM, Daniel P. Berrangé wrote: On Wed, Nov 13, 2019 at 11:32:09AM -0500, Jag Raman wrote: On 11/13/2019 10:50 AM, Daniel P. Berrangé wrote: On Thu, Oct 24, 2019 at 05:09:22AM -0400, Jagannathan Raman wrote: Collect the VMSD from remote process on the source and save it

Re: [PATCH RESEND v6 00/36] Initial support for multi-process qemu

2020-05-11 Thread Jag Raman
> On May 11, 2020, at 10:40 AM, Stefan Hajnoczi wrote: > > Hi, > Have you decided whether to drop the remote device program in favor of > using a softmmu make target? > > Is there anything in this series you'd like me to review before you send > the next revision? Hi Stefan, We are planning

Re: [PATCH RESEND v6 01/36] memory: alloc RAM from file at offset

2020-05-12 Thread Jag Raman
> On May 12, 2020, at 4:48 AM, Daniel P. Berrangé wrote: > > On Wed, Apr 22, 2020 at 09:13:36PM -0700, elena.ufimts...@oracle.com wrote: >> From: Jagannathan Raman >> >> Allow RAM MemoryRegion to be created from an offset in a file, instead >> of allocating at offset of 0 by default. This is

Re: [PATCH RESEND v6 11/36] multi-process: define mpqemu-link object

2020-05-12 Thread Jag Raman
> On May 12, 2020, at 4:56 AM, Stefan Hajnoczi wrote: > > On Wed, Apr 22, 2020 at 09:13:46PM -0700, elena.ufimts...@oracle.com wrote: >> From: Jagannathan Raman >> >> Defines mpqemu-link object which forms the communication link between >> QEMU & emulation program. >> Adds functions to confi

Re: [PATCH RESEND v6 14/36] multi-process: setup a machine object for remote device process

2020-05-12 Thread Jag Raman
> On May 12, 2020, at 6:43 AM, Stefan Hajnoczi wrote: > > On Wed, Apr 22, 2020 at 09:13:49PM -0700, elena.ufimts...@oracle.com wrote: >> From: Jagannathan Raman >> >> remote-machine object sets up various subsystems of the remote device >> process. Instantiate PCI host bridge object and init

Re: [PATCH RESEND v6 12/36] multi-process: add functions to synchronize proxy and remote endpoints

2020-05-12 Thread Jag Raman
> On May 12, 2020, at 6:21 AM, Stefan Hajnoczi wrote: > > On Wed, Apr 22, 2020 at 09:13:47PM -0700, elena.ufimts...@oracle.com wrote: >> From: Jagannathan Raman >> >> In some cases, for example MMIO read, QEMU has to wait for the remote to >> complete a command before proceeding. An eventfd

Re: [PATCH RESEND v6 17/36] multi-process: introduce proxy object

2020-05-12 Thread Jag Raman
> On May 12, 2020, at 8:23 AM, Stefan Hajnoczi wrote: > > On Wed, Apr 22, 2020 at 09:13:52PM -0700, elena.ufimts...@oracle.com wrote: >> From: Elena Ufimtseva >> >> Defines a PCI Device proxy object as a parent of TYPE_PCI_DEVICE. > > s/parent/child/ > >> >> PCI Proxy Object registers as

Re: [PATCH RESEND v6 00/36] Initial support for multi-process qemu

2020-05-12 Thread Jag Raman
> On May 12, 2020, at 12:13 PM, Stefan Hajnoczi wrote: > > On Mon, May 11, 2020 at 03:30:50PM -0400, Jag Raman wrote: >>> On May 11, 2020, at 10:40 AM, Stefan Hajnoczi wrote: >>> >>> Hi, >>> Have you decided whether to drop the remote device

Re: [PATCH RESEND v6 01/36] memory: alloc RAM from file at offset

2020-05-13 Thread Jag Raman
> On May 13, 2020, at 11:25 AM, Igor Mammedov wrote: > > On Wed, 13 May 2020 09:40:42 +0100 > Stefan Hajnoczi wrote: > >> On Tue, May 12, 2020 at 07:56:33AM -0400, Jag Raman wrote: >>> >>> >>>> On May 12, 2020, at 4:48 AM, Daniel P. Ber

Re: [RFC v4 PATCH 00/49] Initial support of multi-process qemu - status update

2019-12-19 Thread Jag Raman
On 12/19/2019 7:33 AM, Felipe Franciosi wrote: Hello, (I've added Jim and Ben from the SPDK team to the thread.) On Dec 19, 2019, at 11:55 AM, Stefan Hajnoczi wrote: On Tue, Dec 17, 2019 at 10:57:17PM +, Felipe Franciosi wrote: On Dec 17, 2019, at 5:33 PM, Stefan Hajnoczi wrote: On

Re: tests/acceptance/multiprocess.py test failure

2021-07-15 Thread Jag Raman
> On Jul 15, 2021, at 9:16 AM, Cleber Rosa wrote: > > > David Hildenbrand writes: > >> >> Hi, >> >> maybe >> >> https://lkml.kernel.org/r/20210709052800.63588-1-yang.zh...@intel.com >> >> resolves your issue. If not, pleas let me know and I'll try >> reproducing (will have to install avoc

Re: [PATCH RFC server 01/11] vfio-user: build library

2021-07-20 Thread Jag Raman
> On Jul 19, 2021, at 4:24 PM, John Levon wrote: > > On Mon, Jul 19, 2021 at 04:00:03PM -0400, Jagannathan Raman wrote: > >> add the libvfio-user library as a submodule. build it as part of QEMU >> >> diff --git a/meson.build b/meson.build >> index 6e4d2d8..f2f9f86 100644 >> --- a/meson.build

Re: tests/acceptance/multiprocess.py test failure

2021-07-20 Thread Jag Raman
> On Jul 20, 2021, at 2:39 PM, Cleber Rosa wrote: > > > Jag Raman writes: > >> >> Hi Cleber, >> >> We presently don’t have permissions to send a PR to >> upstream (Peter Maydell). >> >> Presently, we are requesting someone else who

Re: [PATCH 04/16] multi-process: Fix pci_proxy_dev_realize() error handling

2021-07-20 Thread Jag Raman
> On Jul 20, 2021, at 8:53 AM, Markus Armbruster wrote: > > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error,

Re: [PATCH RFC server 04/11] vfio-user: find and init PCI device

2021-07-28 Thread Jag Raman
> On Jul 26, 2021, at 11:05 AM, John Levon wrote: > > On Mon, Jul 19, 2021 at 04:00:06PM -0400, Jagannathan Raman wrote: > >> +vfu_pci_set_id(o->vfu_ctx, >> + pci_get_word(o->pci_dev->config + PCI_VENDOR_ID), >> + pci_get_word(o->pci_dev->config + PCI_DE

Re: [PATCH RFC server v2 01/11] vfio-user: build library

2021-08-27 Thread Jag Raman
> On Aug 27, 2021, at 1:53 PM, Jag Raman wrote: > > add the libvfio-user library as a submodule. build it as a cmake > subproject. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- >

Re: [PATCH RFC server 05/11] vfio-user: run vfio-user context

2021-08-13 Thread Jag Raman
> On Jul 20, 2021, at 10:17 AM, Thanos Makatos > wrote: > >> -Original Message- >> From: Jagannathan Raman >> Sent: 19 July 2021 21:00 >> To: qemu-devel@nongnu.org >> Cc: stefa...@redhat.com; alex.william...@redhat.com; >> elena.ufimts...@oracle.com; John Levon ; >> john.g.john...@ora

Re: [PATCH RFC server 05/11] vfio-user: run vfio-user context

2021-08-16 Thread Jag Raman
> On Aug 16, 2021, at 8:52 AM, John Levon wrote: > > On Fri, Aug 13, 2021 at 02:51:53PM +0000, Jag Raman wrote: > >> Thanks for the information about the Blocking and Non-Blocking mode. >> >> I’d like to explain why we are using a separate thread presently

Help adding package to gitlab runners

2021-09-12 Thread Jag Raman
Hi, I'm wondering about the best way to install a dependency package on GitLab runners. I'm adding libvfio-user [1] as a submodule to QEMU. libvfio-user depends on the availability of the "json-c" package. As such, we need to install this package to build the library as part of QEMU. I saw that

Re: Help adding package to gitlab runners

2021-09-13 Thread Jag Raman
> On Sep 13, 2021, at 1:38 AM, Thomas Huth wrote: > > On 13/09/2021 03.14, Jag Raman wrote: >> Hi, >> I'm wondering about the best way to install a dependency package on >> GitLab runners. >> >> I'm adding libvfio-user [1] as a submodule to

Re: [PATCH RFC server v2 00/11] vfio-user server in QEMU

2021-09-08 Thread Jag Raman
> On Sep 8, 2021, at 6:08 AM, Stefan Hajnoczi wrote: > > On Fri, Aug 27, 2021 at 01:53:19PM -0400, Jagannathan Raman wrote: >> Hi, >> >> This series depends on the following series from >> Elena Ufimtseva : >> [PATCH RFC v2 00/16] vfio-user implementation > > Please send future revisions as

Re: [PATCH RFC server v2 00/11] vfio-user server in QEMU

2021-09-10 Thread Jag Raman
> On Sep 9, 2021, at 4:17 AM, Stefan Hajnoczi wrote: > > Hi Jag, > I have finished reviewing these patches and left comments. I didn't take > a look at the libvfio-user's implementation. Thank you for you comments, Stefan - we’ll get cracking on them. :) -- Jag > > Stefan

Re: [PATCH RFC server v2 02/11] vfio-user: define vfio-user object

2021-09-10 Thread Jag Raman
> On Sep 8, 2021, at 8:37 AM, Stefan Hajnoczi wrote: > > On Fri, Aug 27, 2021 at 01:53:21PM -0400, Jagannathan Raman wrote: >> Define vfio-user object which is remote process server for QEMU. Setup >> object initialization functions and properties necessary to instantiate >> the object >> >> S

Re: [PATCH RFC server v2 03/11] vfio-user: instantiate vfio-user context

2021-09-10 Thread Jag Raman
> On Sep 8, 2021, at 8:40 AM, Stefan Hajnoczi wrote: > > On Fri, Aug 27, 2021 at 01:53:22PM -0400, Jagannathan Raman wrote: >> create a context with the vfio-user library to run a PCI device >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan R

Re: [PATCH RFC server v2 04/11] vfio-user: find and init PCI device

2021-09-10 Thread Jag Raman
> On Sep 8, 2021, at 8:43 AM, Stefan Hajnoczi wrote: > > On Fri, Aug 27, 2021 at 01:53:23PM -0400, Jagannathan Raman wrote: >> @@ -96,6 +102,28 @@ static void vfu_object_machine_done(Notifier *notifier, >> void *data) >>strerror(errno)); >> return; >> } >> + >>

Re: [PATCH RFC server v2 06/11] vfio-user: handle PCI config space accesses

2021-09-10 Thread Jag Raman
> On Sep 9, 2021, at 3:27 AM, Stefan Hajnoczi wrote: > > On Fri, Aug 27, 2021 at 01:53:25PM -0400, Jagannathan Raman wrote: >> +static ssize_t vfu_object_cfg_access(vfu_ctx_t *vfu_ctx, char * const buf, >> + size_t count, loff_t offset, >> +

Re: [PATCH RFC server v2 08/11] vfio-user: handle PCI BAR accesses

2021-09-10 Thread Jag Raman
> On Sep 9, 2021, at 3:37 AM, Stefan Hajnoczi wrote: > > On Fri, Aug 27, 2021 at 01:53:27PM -0400, Jagannathan Raman wrote: >> +/** >> + * VFU_OBJECT_BAR_HANDLER - macro for defining handlers for PCI BARs. >> + * >> + * To create handler for BAR number 2, VFU_OBJECT_BAR_HANDLER(2) would >> + *

Re: [PATCH RFC server v2 01/11] vfio-user: build library

2021-09-10 Thread Jag Raman
> On Sep 10, 2021, at 11:20 AM, Philippe Mathieu-Daudé > wrote: > > On 8/27/21 7:53 PM, Jagannathan Raman wrote: >> add the libvfio-user library as a submodule. build it as a cmake >> subproject. >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jaganna

Re: [PATCH] multi-process: Acceptance test for multiprocess QEMU

2021-01-07 Thread Jag Raman
> On Jan 6, 2021, at 8:51 AM, Marc-André Lureau > wrote: > > Hi > > On Tue, Dec 29, 2020 at 8:19 PM Jag Raman wrote: > > > > On Dec 23, 2020, at 1:49 PM, Elena Ufimtseva > > wrote: > > > > On Wed, Dec 23, 2020 at 03:01:24PM +0400, Ma

Re: [PATCH v16 00/20] Initial support for multi-process Qemu

2021-01-11 Thread Jag Raman
> On Jan 11, 2021, at 12:20 AM, 罗勇刚(Yonggang Luo) wrote: > > I have a question, does this support/test on Windows? Hi Yonggang, we have not tested this on Windows. The project only builds on Linux for now. Thank you! — Jag > > On Mon, Jan 11, 2021 at 1:08 PM Jagannathan Raman > wrote: >

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-04-23 Thread Jag Raman
On 3/26/2019 6:20 PM, Philippe Mathieu-Daudé wrote: Please share the SELinux policy files, containerization scripts, etc. There is probably a home for them in qemu.git, libvirt.git, or elsewhere upstream. We need to find a way to make the sandboxing improvements available to users besides yo

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-03-26 Thread Jag Raman
On 3/26/2019 4:08 AM, Stefan Hajnoczi wrote: On Fri, Mar 08, 2019 at 09:50:36AM +, Stefan Hajnoczi wrote: On Thu, Mar 07, 2019 at 03:29:41PM -0800, John G Johnson wrote: On Mar 7, 2019, at 11:27 AM, Stefan Hajnoczi wrote: On Thu, Mar 07, 2019 at 02:51:20PM +, Daniel P. Berrangé wrot

Re: [PATCH v9 00/20] Initial support for multi-process Qemu

2020-09-24 Thread Jag Raman
> On Sep 24, 2020, at 4:38 AM, Stefan Hajnoczi wrote: > > On Thu, Aug 27, 2020 at 11:12:11AM -0700, elena.ufimts...@oracle.com wrote: >> The v9 has the following changes: >> - Communication channel. Qemu side uses blocking call to send >> and receive the message from the remote and cannot pro

Re: [PATCH v9 11/20] multi-process: introduce proxy object

2020-09-24 Thread Jag Raman
> On Sep 23, 2020, at 11:10 AM, Michael S. Tsirkin wrote: > > On Thu, Aug 27, 2020 at 11:12:22AM -0700, elena.ufimts...@oracle.com wrote: >> From: Elena Ufimtseva >> >> Defines a PCI Device proxy object as a child of TYPE_PCI_DEVICE. >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: J

Re: [PATCH] remote: Remove unused remote_iohub_finalize

2024-09-19 Thread Jag Raman
> On Sep 19, 2024, at 12:59 PM, d...@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > remote_iohub_finalize has never been used. > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Jagannathan Raman Thanks, Dave! > --- > hw/remote/iohub.c | 13

Re: of remote_iohub_finalize

2024-09-19 Thread Jag Raman
Hi Dave, Thanks for checking! remote_iohub_finalize() is a relic from when remote iohub was a separate type. We aren't calling it anywhere; we can remove it. Cheers, Jag > On Sep 18, 2024, at 1:00 PM, Dr. David Alan Gilbert wrote: > > Hi Jag, > One of my scripts noticed that 'remote_iohub_f

Re: [PATCH 50/71] hw/remote: Constify all Property

2024-12-14 Thread Jag Raman
> On Dec 13, 2024, at 2:14 PM, Richard Henderson > wrote: > > Signed-off-by: Richard Henderson Reviewed-by: Jagannathan Raman > --- > hw/remote/proxy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/remote/proxy.c b/hw/remote/proxy.c > index 302a0a4d4d..6f84fdd

Re: [PATCH v8 00/28] vfio-user client

2025-02-28 Thread Jag Raman
I appreciate you posting the patches. I didn't author the patches, actually; John Johnson did it. You could use your name as the author since you should be familiar with it now, and I can review the patches. Please add the following to each patch so it recognizes Oracle's contribution: Co-autho

Re: [PATCH v8 00/28] vfio-user client

2025-03-03 Thread Jag Raman
> On Mar 3, 2025, at 6:19 AM, John Levon wrote: > > On Fri, Feb 28, 2025 at 05:09:00PM +0000, Jag Raman wrote: > >> I appreciate you posting the patches. I didn't author the patches, actually; >> John Johnson did it. > > I'll adjust the Author field

<    1   2   3