le missing pthread_cond_signal(3) calls when waiting threads
are returned by ETIMEDOUT
- fix an uninitialized variable
The problem is analyzed by and fix is provided by Noriyuki Soda.
Signed-off-by: Izumi Tsutsui
---
util/qemu-thread-posix.c | 17 +
1 file changed, 9 insertions(+), 8
Laszlo Ersek wrote:
> On 06/29/13 12:22, Izumi Tsutsui wrote:
> > Fix following bugs in "fallback implementation of counting semaphores
> > with mutex+condvar" added in c166cb72f1676855816340666c3b618beef4b976:
> > - waiting threads are not restarted properly if m
check a return value of in pthread_cond_wait() in qemu_sem_wait()
Signed-off-by: Izumi Tsutsui
Reviewed-by: Laszlo Ersek
---
v2:
- make QemuSemaphore.count unsigned (it won't be negative)
- also eliminate checks for negative count values
- check a return value of in pthread_cond_wai
Laszlo Ersek wrote:
> On 07/02/13 18:54, Izumi Tsutsui wrote:
:
> > @@ -249,16 +250,19 @@ int qemu_sem_timedwait(QemuSemaphore *sem, int ms)
> >
> > void qemu_sem_wait(QemuSemaphore *sem)
> > {
> > +int rc;
> > +
> >
check a return value of in pthread_cond_wait() in qemu_sem_wait()
Signed-off-by: Izumi Tsutsui
Reviewed-by: Laszlo Ersek
---
v3:
- fix a missed assignment and actually check a retval of pthread_cond_wait()
v2:
- make QemuSemaphore.count unsigned (it won't be negative)
- also eliminate
** Patch added: "patch by git format-patch --signoff"
http://launchpadlibrarian.net/49607393/qemu-git.patch
--
Can't read e1000 NIC EEPROM on NetBSD guest
https://bugs.launchpad.net/bugs/581737
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed
> Please email the patch to qemu-devel@nongnu.org via git-send-email.
Isn't the following post enough? What's incomplete on this?
http://lists.nongnu.org/archive/html/qemu-devel/2010-06/msg00449.html
(sorry I'm not familiar with git)
--
Can't read e1000 NIC EEPROM on NetBSD guest
https://bugs.lau
even in such case?
If so, is there any proper documents how to submit patches for QEMU?
---
Izumi Tsutsui
--
Can't read e1000 NIC EEPROM on NetBSD guest
https://bugs.launchpad.net/bugs/581737
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to
n
struct eecd_state individually rather than using memset() against
the whole structre. The old_eecd member stores the last SK and CS
signal levels and it should be preserved even after reset of internal
EEPROM state to detect next signal edges for proper EEPROM emulation.
Signed-off-by: Izumi Tsutsui
"qemu_socket.h" includes all necessary files and
including without
could cause errors on some systems.
Signed-off-by: Izumi Tsutsui
---
block/sheepdog.c | 10 --
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
ind
bswap_NN() variants are not always available in CONFIG_MACHINE_BSWAP_H case
and bswapNN() are public APIs in "bswap.h".
Signed-off-by: Izumi Tsutsui
---
ui/vnc-enc-tight.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-e
11 matches
Mail list logo
