Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 01/17] hvm: Modify interface to support multiple ioreq server

2012-08-23 Thread Ian Campbell
> diff --git a/xen/include/asm-x86/hvm/domain.h > b/xen/include/asm-x86/hvm/domain.h > index 27b3de5..49d1ca0 100644 > --- a/xen/include/asm-x86/hvm/domain.h > +++ b/xen/include/asm-x86/hvm/domain.h [...] > struct hvm_domain { > +/* Use for the IO handles by Xen */ > struct hvm_ioreq_pag

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 09/17] xc: Add the hypercall for multiple servers

2012-08-23 Thread Ian Campbell
On Wed, 2012-08-22 at 13:31 +0100, Julien Grall wrote: > This patch add 5 hypercalls to register server, io range and PCI. > > Signed-off-by: Julien Grall Looks correct to me at least so far as the use of the hypercall buffers goes, thanks. Acked-by: Ian Campbell

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 11/17] xc: modify save/restore to support multiple device models

2012-08-23 Thread Ian Campbell
On Wed, 2012-08-22 at 13:31 +0100, Julien Grall wrote: > - add save/restore new special pages and remove unused > - modify save file structure to allow multiple qemu states > > Signed-off-by: Julien Grall > --- > tools/libxc/xc_domain_restore.c | 150 > +

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 12/17] xl: Add interface to handle qemu disaggregation

2012-08-23 Thread Ian Campbell
On Wed, 2012-08-22 at 13:31 +0100, Julien Grall wrote: > This patch modifies libxl interface for qemu disaggregation. I'd rather see the interfaces changes in the same patch as the implementation of the new interfaces. > For the moment, due to some dependencies between devices, we > can't let the

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 14/17] xl-parsing: Parse new device_models option

2012-08-23 Thread Ian Campbell
On Wed, 2012-08-22 at 13:32 +0100, Julien Grall wrote: > Add new option "device_models". The user can specify the capability of the > QEMU (ui, vifs, ...). This option only works with QEMU upstream (qemu-xen). > > For instance: > device_models= [ 'name=all,vifs=nic1', 'name=qvga,ui', 'name=qide,id

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 15/17] xl: support spawn/destroy on multiple device model

2012-08-23 Thread Ian Campbell
On Wed, 2012-08-22 at 13:32 +0100, Julien Grall wrote: > Old configuration file is still working with qemu disaggregation. > Before to spawn any QEMU, the toolstack will fill correctly, if needed, > configuration structure. > > For the moment, the toolstack spawns device models one by one. > > Si

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 11/17] xc: modify save/restore to support multiple device models

2012-08-23 Thread Ian Campbell
On Thu, 2012-08-23 at 20:13 +0100, Julien Grall wrote: > On 08/23/2012 02:27 PM, Ian Campbell wrote: > > > >> @@ -103,6 +103,9 @@ static ssize_t rdexact(xc_interface *xch, struct > >> restore_ctx *ctx, > >> #else > >> #define RDEXACT read_exact &g

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 11/17] xc: modify save/restore to support multiple device models

2012-08-24 Thread Ian Campbell
On Fri, 2012-08-24 at 11:27 +0100, Julien Grall wrote: > On 08/23/2012 08:52 PM, Ian Campbell wrote: > > On Thu, 2012-08-23 at 20:13 +0100, Julien Grall wrote: > > > >> On 08/23/2012 02:27 PM, Ian Campbell wrote: > >> > >>> >

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 12/17] xl: Add interface to handle qemu disaggregation

2012-08-24 Thread Ian Campbell
On Fri, 2012-08-24 at 13:56 +0100, Julien Grall wrote: > On 08/23/2012 02:30 PM, Ian Campbell wrote: > > On Wed, 2012-08-22 at 13:31 +0100, Julien Grall wrote: > > > >> This patch modifies libxl interface for qemu disaggregation. > >> > > I'd r

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 15/17] xl: support spawn/destroy on multiple device model

2012-08-24 Thread Ian Campbell
On Fri, 2012-08-24 at 14:51 +0100, Julien Grall wrote: > >> @@ -1044,7 +1044,8 @@ int libxl__wait_for_device_model(libxl__gc *gc, > >>void *check_callback_userdata) > >> { > >> char *path; > >> -path = libxl__sprintf(gc, "/local/domain/0/device-model/

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 15/17] xl: support spawn/destroy on multiple device model

2012-08-24 Thread Ian Campbell
On Fri, 2012-08-24 at 15:37 +0100, Julien Grall wrote: > In case of Xen, it's hard to have a compatibility. We can > still spawn only one QEMU, but ioreq handling will not > send an io request if no device models registered it. > There is no more default QEMU. This means we've broken existing qemu

Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-12-07 Thread Ian Campbell
On Fri, 2012-12-07 at 16:14 +, Ian Jackson wrote: > +target_phys_addr_t offset = (target_phys_addr_t)req->size * i; > +if (req->df) addr -= offset; > +else addr -= offset; One of these -= should be a += I presume? [...] > +write_phys_req_item((target_phys_addr_t) r

Re: [Qemu-devel] [Xen-devel] [PATCH RFC 1/3] xen_disk: handle disk files on ramfs/tmpfs

2013-01-03 Thread Ian Campbell
On Mon, 2012-12-31 at 12:16 +, Roger Pau Monne wrote: > Files that reside on ramfs or tmpfs cannot be opened with O_DIRECT, > if first call to bdrv_open fails with errno = EINVAL, try a second > call without BDRV_O_NOCACHE. Doesn't that risk spuriously turning of NOCACHE on other sorts of devi

Re: [Qemu-devel] [Xen-devel] [PATCH v2] piix: define a TOM register to report the base of PCI

2013-02-25 Thread Ian Campbell
On Mon, 2013-02-25 at 06:53 +, Xudong Hao wrote: > v2: > * Use "piix: " in the subject rather than "qemu: " > * Define TOM register as one byte > * Define default TOM value instead of hardcode 0xe000 in more that one > place > * Use API pci_set_byte for pci config access > * Use dev->confi

Re: [Qemu-devel] [PATCH v2] piix: define a TOM register to report the base of PCI

2013-02-26 Thread Ian Campbell
> > -Original Message- > > > From: qemu-devel-bounces+xiantao.zhang=intel@nongnu.org > > > [mailto:qemu-devel-bounces+xiantao.zhang=intel@nongnu.org] On Behalf > > > Of Hao, Xudong > > > Sent: Tuesday, February 26, 2013 11:33 AM > > >

Re: [Qemu-devel] [PATCH v2] piix: define a TOM register to report the base of PCI

2013-02-27 Thread Ian Campbell
I'm not sure about qemu-devel but on xen-devel the policy is not to top post so please could you avoid doping so. On Wed, 2013-02-27 at 09:49 +, Zhang, Xiantao wrote: > > Given that Xen has at least two other mechanisms (xenstore and > > hvmparams) for passing this sort of information around I

Re: [Qemu-devel] [Xen-devel] [PATCH v2 3/5] xenfb: Add option to use a grant ref for shared page

2014-09-17 Thread Ian Campbell
On Wed, 2014-09-17 at 15:30 +0100, Owen smith wrote: > Adds "page-gref" to the frontend location to specify the grant xen.git/xen/include/public/io/fbif.h is a bit sparse in terms of docs right now, but could I encourage you to add the new keys which you are implementing in this series to it pleas

Re: [Qemu-devel] [Xen-devel] [PATCH 3/3] xenfb: Add "feature-no-abs-rescale" for Windows PV frontend

2014-09-29 Thread Ian Campbell
On Thu, 2014-09-11 at 02:23 +0100, Stefano Stabellini wrote: Stefano, In the context of this patch could you also take a look at Owen's xenfb documentation patches[0], I think you probably know the most about this particular protocol. Ian. [0] <1411376699-8175-1-git-send-email-owen.sm...@citrix

Re: [Qemu-devel] [Xen-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-01 Thread Ian Campbell
On Wed, 2014-10-01 at 10:20 +0100, Stefano Stabellini wrote: > I wonder if we could send both ioreqs at once from Xen and back from > QEMU. Or maybe append the registers to IOREQ_TYPE_VMWARE_PORT, changing > the size of ioreq_t only for this ioreq type. Random idea: Why new add a IOREQ_TYPE_FULL_S

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xenfb: Add comment documentation

2014-10-03 Thread Ian Campbell
On Fri, 2014-09-26 at 11:20 +0100, Owen Smith wrote: > > > + * page-gref > > > + * Values: > > > + * Only required if "page-ref" is NOT set. > > > + * > > > + * A grant reference to the memory page to be mapped for the shared > > ring > > > + * structures. Must be present if "page-ref" is

Re: [Qemu-devel] [PATCH] libxl: change default QEMU machine to pc-i440fx-1.6

2014-06-10 Thread Ian Campbell
On Fri, 2014-05-23 at 17:07 +0100, Stefano Stabellini wrote: > Choose pc-i440fx-1.6 instead of pc for HVM guests, so that we know for > sure what is the machine that we are emulating. Does 1.6 here refer to the qemu version? If so then I think we need to consciously decide that we are happy for Xe

Re: [Qemu-devel] [PATCH 2/3] console: rework text terminal cursor logic

2014-06-11 Thread Ian Campbell
On Tue, 2014-06-10 at 09:44 +0200, Gerd Hoffmann wrote: > On So, 2014-06-08 at 11:30 +0100, Ian Campbell wrote: > > On Thu, 2014-05-22 at 13:00 +0200, Gerd Hoffmann wrote: > > > Have a global timer. Update all visible terminal windows syncronously. > > > Right now thi

Re: [Qemu-devel] [PATCH] libxl: change default QEMU machine to pc-i440fx-1.6

2014-06-11 Thread Ian Campbell
On Wed, 2014-06-11 at 11:35 +0100, Stefano Stabellini wrote: > On Tue, 10 Jun 2014, Ian Campbell wrote: > > On Fri, 2014-05-23 at 17:07 +0100, Stefano Stabellini wrote: > I think that the dependency on QEMU >= 1.6 is OK. The Xen PV Device went > in v1.6.0 and we certainy cannot g

Re: [Qemu-devel] [RFC PATCH V2 1/2] xen: pass kernel initrd to qemu

2014-06-12 Thread Ian Campbell
On Wed, 2014-06-04 at 15:34 +0800, Chunyan Liu wrote: > xen side patch to support xen HVM direct kernel boot: > support 'kernel', 'ramdisk', 'root', 'extra' in HVM config file, > parse config file, pass -kernel, -initrd, -append parameters to qemu. > It's working with seabios and non-stubdom. Rombi

Re: [Qemu-devel] [Xen-devel] [RFC PATCH V2 1/2] xen: pass kernel initrd to qemu

2014-06-13 Thread Ian Campbell
On Thu, 2014-06-12 at 23:43 -0600, Chun Yan Liu wrote: > > > +static char *parse_cmdline(XLU_Config *config) > > > +{ > > > +char *cmdline = NULL; > > > +const char *root = NULL, *extra = ""; > > > + > > > +xlu_cfg_get_string (config, "root", &root, 0); > > > +xlu_cfg_get_stri

Re: [Qemu-devel] [Xen-devel] [RFC PATCH V2 1/2] xen: pass kernel initrd to qemu

2014-06-16 Thread Ian Campbell
On Mon, 2014-06-16 at 01:14 -0600, Chun Yan Liu wrote: > > > > > @@ -1007,9 +1030,16 @@ static void parse_config_data(const char > > > > *config_source, > > > > > > > > > > switch(b_info->type) { > > > > > case LIBXL_DOMAIN_TYPE_HVM: > > > > > -if (!xlu_cfg_get_string

Re: [Qemu-devel] [RFC PATCH V5 0/3] Support xen HVM direct kernel boot

2014-08-26 Thread Ian Campbell
On Mon, 2014-08-04 at 18:26 +0100, Stefano Stabellini wrote: > The patches are both in QEMU and qemu-upstream-unstable. > You can go ahead with the tools patches. Done. There was some fuzz on the first patch (no doubt due to the delay in apply, sorry) which I resolved, Chunyan please do check I di

Re: [Qemu-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-08 Thread Ian Campbell
0On Sun, 2014-05-04 at 17:25 +0800, arei.gong...@huawei.com wrote: > From: Gaowei > > In Xen platform, after using upstream qemu, the all of pci devices will show > hotplug in the windows guest. In this situation, the windows guest may occur > blue screen when VM' user click the icon of VGA card

Re: [Qemu-devel] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-08 Thread Ian Campbell
On Thu, 2014-05-08 at 07:29 +, Gonglei (Arei) wrote: > > +rmvc_pcrm = inl(PCI_RMV_BASE); > > > > > > > > > So .. what is at this special 0xae0c address? > > > > > > Is there some code in QEMU that needs this treatment as well? > > > > Yep, the 0xae0c is defined in upstream QEMU, which

Re: [Qemu-devel] [Xen-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-08 Thread Ian Campbell
On Thu, 2014-05-08 at 11:32 +0300, Michael S. Tsirkin wrote: > Also I wonder: would it be possible for you to load the acpi > tables from qemu instead of generating your own? There is stuff in the tables for which the definition is Xen and not Qemu. The interrupt routing table is the one which I c

Re: [Qemu-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 08:38 +, Gonglei (Arei) wrote: > > > This is done by runtime patching: > > > > Which appears to involve an awful lot of jumping through hoops... Please > > can you explain why it is necessary, as opposed to e.g. using a dynamic > > set of SSDTs? > > > Ok, we will delete

Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 09:45 +, Gonglei (Arei) wrote: > > And it also seem pretty pointless to send a v4 without addressing > > all comments you got on v3. > > > I don't think so. I have absorbed Ian's all suggestion on v3. And for other > questions have been answered too, in despite of is me

Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 10:15 +, Gonglei (Arei) wrote: > Hi, > > First, please forgive me for my bad English. > It's so sad. > > > -Original Message----- > > From: Ian Campbell [mailto:ian.campb...@citrix.com] > > Sent: Friday, May 09, 2014 5:57

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 09:25 -0400, Konrad Rzeszutek Wilk wrote: > On Fri, May 09, 2014 at 11:26:35AM +0100, Ian Campbell wrote: > > On Fri, 2014-05-09 at 10:15 +, Gonglei (Arei) wrote: > > > Hi, > > > > > > First, please forgive me f

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 10:38 -0400, Ross Philipson wrote: > >> Can it be used to patch the DSDT? Or were you (Ian) thinking that the bulk > >> of the ACPI PCI stuff can be moved there ? > > > > I think it can "shadow" or extend existing DSDT stuff, I don't think it > > can patch as sych. But here we

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 16:56 +0200, Fabio Fantoni wrote: > Il 09/05/2014 16:46, Ian Campbell ha scritto: > > On Fri, 2014-05-09 at 10:38 -0400, Ross Philipson wrote: > >>>> Can it be used to patch the DSDT? Or were you (Ian) thinking that the > >>>> bulk &g

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 12:00 -0400, Konrad Rzeszutek Wilk wrote: > So we could just then gat the _EJ0 functionality based on values that > are present (or not) in the SSDT ? AIUI the very presence of _EJ0 is what marks the device as being ejectable (e.g. in the Windows device manager). It would b

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-12 Thread Ian Campbell
On Fri, 2014-05-09 at 13:32 -0400, Ross Philipson wrote: > On 05/09/2014 12:34 PM, Paul Durrant wrote: > >> -Original Message- > >> From: Ian Campbell > >> Sent: 09 May 2014 17:12 > >> To: Konrad Rzeszutek Wilk > >> Cc: Ross Philipson;

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-12 Thread Ian Campbell
On Mon, 2014-05-12 at 10:14 +0100, Jan Beulich wrote: > >>> On 12.05.14 at 11:05, wrote: > > Given that there are 32 PCI slots we would be talking about a total of > > 4k of space in hvmloader to provide a precompiled SSDT for each slot, > > which can be inserted at runtime depending on each slots

Re: [Qemu-devel] [PATCH v4] libxl: add basic spice support for pv domUs

2014-05-13 Thread Ian Campbell
On Tue, 2014-05-13 at 12:51 +0200, Fabio Fantoni wrote: > Il 13/05/2014 11:50, Ian Campbell ha scritto: > > On Tue, 2014-05-13 at 10:00 +0200, Fabio Fantoni wrote: > >>> But: Does spice already require a VFB? In which case the existing > >>> handing of that will

Re: [Qemu-devel] [PATCH v5] libxl: add basic spice support for pv domUs

2014-05-16 Thread Ian Campbell
On Fri, 2014-05-16 at 15:41 +0200, Fabio Fantoni wrote: > Il 16/05/2014 14:47, Ian Campbell ha scritto: > > On Fri, 2014-05-16 at 14:37 +0200, Fabio Fantoni wrote: > >> This patch adds basic spice support for pv domUs. > >> The qemu parameters are the same as

Re: [Qemu-devel] [PATCH v5] libxl: add basic spice support for pv domUs

2014-05-16 Thread Ian Campbell
On Fri, 2014-05-16 at 16:20 +0200, Fabio Fantoni wrote: > Il 16/05/2014 15:56, Ian Campbell ha scritto: > > On Fri, 2014-05-16 at 15:41 +0200, Fabio Fantoni wrote: > >> Il 16/05/2014 14:47, Ian Campbell ha scritto: > >>> On Fri, 2014-05-16 at 14:37 +0200, Fabio Fa

Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore

2012-01-19 Thread Ian Campbell
On Thu, 2012-01-19 at 11:56 +, Stefano Stabellini wrote: > Write to xenstore any physmap changes so that the hypervisor can be > aware of them. What is the structure of the xenstore values? Looks like /physmap//start_addr ? Who defines the meaning of original-addr, in particular what

Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore

2012-01-19 Thread Ian Campbell
On Thu, 2012-01-19 at 13:08 +, Stefano Stabellini wrote: > On Thu, 19 Jan 2012, Ian Campbell wrote: > > On Thu, 2012-01-19 at 11:56 +, Stefano Stabellini wrote: > > > Write to xenstore any physmap changes so that the hypervisor can be > > > aware of them. > &

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 10/15] xc: Add argument to allocate more special pages

2012-03-23 Thread Ian Campbell
On Thu, 2012-03-22 at 15:59 +, Julien Grall wrote: > This patchs permits to allocate more special pages. Indeed, for multiple > ioreq server, we need to have 2 shared pages by server. > > xc_hvm_build will take an argument which will indicate the number of > special pages we want to allocate.

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 11/15] xc: Fix python build

2012-03-23 Thread Ian Campbell
On Thu, 2012-03-22 at 15:59 +, Julien Grall wrote: > Quickly fix for hvm_build in python. If an earlier patch breaks the build then this need to be part of that patch to allow bisection. > Signed-off-by: Julien Grall > --- > tools/python/xen/lowlevel/xc/xc.c |3 ++- > 1 files changed, 2

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 09/15] xc: Add the hypercall for multiple servers

2012-03-23 Thread Ian Campbell
On Thu, 2012-03-22 at 15:59 +, Julien Grall wrote: > This patch add 5 hypercalls to register server, io range and PCI. > > Signed-off-by: Julien Grall > --- > tools/libxc/xc_domain.c | 140 > +++ > tools/libxc/xenctrl.h | 13 > 2 files c

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 12/15] xl: Add interface to handle multiple device models

2012-03-23 Thread Ian Campbell
On Fri, 2012-03-23 at 13:06 +, Julien Grall wrote: > >> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > >> index 413a1a6..7e48817 100644 > >> --- a/tools/libxl/libxl_types.idl > >> +++ b/tools/libxl/libxl_types.idl > >> @@ -37,6 +37,7 @@ libxl_domain_type = Enumeration(

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 01/15] hvm: Modify interface to support multiple ioreq server

2012-03-23 Thread Ian Campbell
On Thu, 2012-03-22 at 15:59 +, Julien Grall wrote: > Add structure to handle ioreq server. It's server which can > handle a range of IO (MMIO and/or PIO) and emulate a PCI. > Each server as its own shared page to receive ioreq. So > we have introduced to HVM PARAM to set/get the first and > the

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 12/15] xl: Add interface to handle multiple device models

2012-03-23 Thread Ian Campbell
On Thu, 2012-03-22 at 15:59 +, Julien Grall wrote: > This patch add a structure with contain all informations about > a device model. > > Signed-off-by: Julien Grall > --- > tools/libxl/libxl.h |4 ++-- > tools/libxl/libxl_internal.h |1 + > tools/libxl/libxl_types.idl |

Re: [Qemu-devel] [SeaBIOS] [PATCH 1/4] Add basic linked list operations

2012-03-29 Thread Ian Campbell
On Wed, 2012-03-28 at 22:27 -0400, Kevin O'Connor wrote: > On Wed, Mar 28, 2012 at 04:39:07PM +0200, Gerd Hoffmann wrote: > > On 03/28/12 06:28, Alexey Korolev wrote: > > > This linked list implementation is partially based on kernel code. So it > > > should be quite stable > > > > How about just

Re: [Qemu-devel] [Xen-devel] [PATCH] xen: fix interrupt routing

2011-05-19 Thread Ian Campbell
On Wed, 2011-05-18 at 18:53 +0100, Stefano Stabellini wrote: > From: Stefano Stabellini > > Match the routing informations built by seabios: > > - remove i440fx_write_config_xen > we don't need to intercept pci config writes to i440FX; > > - introduce piix3_write_config_xen > we do need to inte

Re: [Qemu-devel] [PATCH v2 1/2] Generalize -machine command line option

2011-05-24 Thread Ian Campbell
gt;desc, > - m->is_default ? " (default)" : ""); > -} > -exit(*optarg != '?'); > -} > +machine = machine_parse(optarg); > break; >

Re: [Qemu-devel] [PATCH v2 1/2] Generalize -machine command line option

2011-05-25 Thread Ian Campbell
On Wed, 2011-05-25 at 10:23 +0200, Jan Kiszka wrote: > On 2011-05-25 10:13, Ian Campbell wrote: > > On Tue, 2011-05-24 at 18:18 +0200, Jan Kiszka wrote: > >> On 2011-05-24 18:06, Ian Campbell wrote: > >> Well, first of all I think this revealed a Xen bug because it crash

Re: [Qemu-devel] [PATCH v2 1/2] Generalize -machine command line option

2011-05-25 Thread Ian Campbell
On Tue, 2011-05-24 at 18:18 +0200, Jan Kiszka wrote: > On 2011-05-24 18:06, Ian Campbell wrote: > > On Sun, 2011-05-22 at 13:00 +0200, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> -machine somehow suggests that it selects the machine, but it doesn't.

Re: [Qemu-devel] [PATCH v3 1/2] Generalize -machine command line option

2011-05-25 Thread Ian Campbell
gt; per-machine options to the command line. That will change the internal > realization again, but we will be able to keep the user interface > stable. > > CC: Anthony PERARD > CC: Ian Campbell Thanks Jan, this one works for me. Tested-by: Ian Campbell > Signed-off-by: Jan

Re: [Qemu-devel] [PATCH v2 1/2] Generalize -machine command line option

2011-05-26 Thread Ian Campbell
On Wed, 2011-05-25 at 11:54 +0100, Anthony PERARD wrote: > On Wed, 25 May 2011, Ian Campbell wrote: > > > On Tue, 2011-05-24 at 18:18 +0200, Jan Kiszka wrote: > > > On 2011-05-24 18:06, Ian Campbell wrote: > > > > On Sun, 2011-05-22 at 13:00 +0200, Jan Kiszka

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] xen: fix interrupt routing

2011-06-14 Thread Ian Campbell
On Tue, 2011-06-14 at 10:25 +0100, Alexander Graf wrote: > On 31.05.2011, at 13:05, Stefano Stabellini wrote: > > > On Sat, 28 May 2011, Alexander Graf wrote: > >> > >> On 26.05.2011, at 17:48, Stefano Stabellini wrote: > >> > >>> xen: fix interrupt routing > >>> > >>> - remove i440FX-xen and i

Re: [Qemu-devel] [Xen-devel] [PATCH] xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER

2012-04-25 Thread Ian Campbell
On Wed, 2012-04-25 at 09:45 +0100, Christoph Hellwig wrote: > > -case BLKIF_OP_WRITE_BARRIER: > > +case BLKIF_OP_FLUSH_DISKCACHE: > > if (!ioreq->req.nr_segments) { > > ioreq->presync = 1; > > return 0; > > } > > -ioreq->presync = ioreq->p

Re: [Qemu-devel] [Xen-devel] [PATCH] xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER

2012-04-25 Thread Ian Campbell
On Wed, 2012-04-25 at 12:21 +0100, Stefano Stabellini wrote: > On Wed, 25 Apr 2012, Christoph Hellwig wrote: > > On Wed, Apr 25, 2012 at 10:02:45AM +0100, Ian Campbell wrote: > > > The blkif spec was recently much improved, you can find it at > > > http://xenbits.xen.

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] build: replace librt check function

2012-02-27 Thread Ian Campbell
On Thu, 2012-02-23 at 13:34 +, Roger Pau Monné wrote: > 2012/2/22 Anthony Liguori : > > On 02/20/2012 06:11 AM, Roger Pau Monne wrote: > >> > >> Replace clock_gettime with timer_gettime, since at least under > >> uclibc 0.9.33 the clock_getttime function can be used without linking > >> against

Re: [Qemu-devel] [Xen-devel] Qemu disaggregation in Xen environment

2012-03-05 Thread Ian Campbell
On Tue, 2012-02-28 at 06:46 -0500, Julien Grall wrote: > Hello, > > In the current model, only one instance of qemu is running for each running > HVM domain. > > We are looking at disaggregating qemu to have, for example, an instance to > emulate only > network controllers, another to emulate b

Re: [Qemu-devel] [PATCH] Support logging xen-guest console

2011-06-23 Thread Ian Campbell
On Mon, 2011-06-20 at 19:42 +0100, Stefano Stabellini wrote: > > @@ -198,6 +248,10 @@ static int con_init(struct XenDevice *xendev) > > else > > con->chr = serial_hds[con->xendev.dev]; > > > > +logenv = getenv("XENCONSOLED_TRACE"); > > +if (logenv != NULL && !strcmp(logenv,

Re: [Qemu-devel] [Xen-devel] Re: [PATCH v2] xen_console: support the new extended xenstore protocol

2011-06-28 Thread Ian Campbell
On Tue, 2011-06-28 at 16:02 +0100, Peter Maydell wrote: > On 28 June 2011 15:55, wrote: > > +xs = xs_daemon_open(); > > +if (xs == NULL) { > > +fprintf(stderr, "Could not contact XenStore\n"); > > +goto out; > > +} > > > +out: > > +free(path); > > +xs_daemon_c

Re: [Qemu-devel] [Xen-devel] Upstream QEMU and Xen unstable not working

2011-07-18 Thread Ian Campbell
Modelled after LIBXL_UUID_... (where I also add FMTLEN). > > signed-off-by: Ian Campbell > Committed-by: Ian Jackson > > QEMU cf973e469bd9d47c0460347764c1315a6180e13c > set ELF_HWCAP for SPARC and SPARC64 > > setting ELF_HWCAP fixes dynamic lib

Re: [Qemu-devel] [Xen-devel] Upstream QEMU and Xen unstable not working

2011-07-19 Thread Ian Campbell
On Tue, 2011-07-19 at 03:53 +0100, Wei Liu wrote: > On Mon, 2011-07-18 at 11:03 +0100, Ian Campbell wrote: > > On Mon, 2011-07-18 at 10:51 +0100, Wei Liu wrote: > > > Bug resend. > > > > > > This bug was reported about one month ago. QEMU fails to start with

Re: [Qemu-devel] [Xen-devel] Re: Upstream QEMU and Xen unstable not working

2011-07-19 Thread Ian Campbell
On Mon, 2011-07-18 at 17:17 +0100, Stefano Stabellini wrote: > On Mon, 18 Jul 2011, Wei Liu wrote: > > Stefano and Anthony, you once said that you were going to setup a > > public QEMU repository for Xen, how is it going now? > > We are getting there, but there are still too many xen patches float

Re: [Qemu-devel] [PATCH 3/3] piix4 acpi xen support

2011-10-31 Thread Ian Campbell
Please CC xen-devel on patches which impact the Xen support in qemu. On Fri, 2011-10-28 at 15:38 -0400, John Baboval wrote: > When in xen mode, handle the view of pm ioport appropriately. > > I'm not entirely comfortable with this patch, since it relies on values > that are hard coded into the DS

Re: [Qemu-devel] [Xen-devel] [PATCH V3 08/10] Introduce Xen PCI Passthrough, PCI config space helpers (2/3)

2011-11-11 Thread Ian Campbell
On Fri, 2011-11-11 at 17:40 +, Anthony PERARD wrote: > > > if ((index < 0) && (index < PCI_ROM_SLOT)) > > > > um, which looks wrong. Should it be 'index > 0' ? > > Every other form is a bit confusing to me. I'd like to write > 0 < index < ROM_SLOT, so I know that index is between 0 and ROM_SL

Re: [Qemu-devel] [Xen-devel] [PATCH 3/4] xen: introduce an event channel for buffered io event notifications

2011-11-15 Thread Ian Campbell
On Tue, 2011-11-15 at 14:51 +, stefano.stabell...@eu.citrix.com wrote: > From: Stefano Stabellini > > Use the newly introduced HVM_PARAM_BUFIOREQ_EVTCHN to receive > notifications for buffered io events. > After the first notification is received leave the event channel masked > and setup a t

Re: [Qemu-devel] [Xen-devel] [PATCH 3/4] xen: introduce an event channel for buffered io event notifications

2011-11-15 Thread Ian Campbell
On Tue, 2011-11-15 at 17:20 +, Stefano Stabellini wrote: > On Tue, 15 Nov 2011, Ian Campbell wrote: > > > +xc_get_hvm_param(xen_xc, xen_domid, HVM_PARAM_BUFIOREQ_EVTCHN, > > > +&bufioreq_evtchn); > > > +rc = xc_evtchn_bind_interd

Re: [Qemu-devel] [PATCH] Add -f option to qemu-nbd

2011-11-16 Thread Ian Campbell
On Wed, 2011-11-16 at 10:34 +, Stefan Hajnoczi wrote: > On Wed, Nov 16, 2011 at 6:57 AM, Chunyan Liu wrote: > > Currently qemu-nbd does not support finding free nbd device for users like > > "losetup -f" and issuing "qemu-nbd -c /dev/nbdX disk.img" won't report error > > message when /dev/nbd

Re: [Qemu-devel] [Xen-devel] Qemu 2.0 regression with xen: qemu crash on any domUs S.O. start

2014-04-02 Thread Ian Campbell
On Wed, 2014-04-02 at 17:03 +0100, Anthony PERARD wrote: > When you "xl create", you have about 10 second to start gdb on qemu, > otherwise, xl will fail to create a guest. I'd be quite happy with adding a backdoor to libxl for this case. i.e. looking for the existence LIBXL_DEBUG_QEMU in the envi

Re: [Qemu-devel] [Xen-devel] Qemu 2.0 regression with xen: qemu crash on any domUs S.O. start

2014-04-03 Thread Ian Campbell
On Thu, 2014-04-03 at 10:15 +0200, Fabio Fantoni wrote: > Seems that do segfault when I connect to vnc or spice, in the test of > this backtrace after connect to vnc, spice and other things of my > patches are disabled, so do not think it is a problem caused by my patches. The last spice patch o

Re: [Qemu-devel] [Xen-devel] [PATCH 0/5] xen: add Intel IGD passthrough support

2014-04-07 Thread Ian Campbell
On Fri, 2014-04-04 at 18:46 -0400, Kevin O'Connor wrote: > On Fri, Feb 21, 2014 at 02:44:08PM +0800, Yang Zhang wrote: > > From: Yang Zhang > > > > The following patches are ported from Xen Qemu-traditional branch which are > > adding Intel IGD passthrough supporting to Qemu upstream. > > > > To

Re: [Qemu-devel] [Xen-devel] [PATCH RFC 0/5] Xen: introduce Xen PV target

2014-01-24 Thread Ian Campbell
On Fri, 2014-01-24 at 14:56 +, Stefano Stabellini wrote: > Besides I don't know how to state this more clearly but there are no big > endian Xen guests. There have never been any big endian Xen guests. > There are no big endian Xen guests on the roadmap. That is perhaps a bit strong, but what

Re: [Qemu-devel] 128Kb bios size and older machines?

2014-02-06 Thread Ian Campbell
On Thu, 2014-02-06 at 17:08 +0400, Michael Tokarev wrote: > 06.02.2014 12:50, Gerd Hoffmann wrote: > > On Do, 2014-02-06 at 12:28 +0400, Michael Tokarev wrote: > >> Since the "small" (128Kb) seabios is now built without > >> support of xen, does that mean that xen will be unable > >> to use qemu wi

Re: [Qemu-devel] 128Kb bios size and older machines?

2014-02-06 Thread Ian Campbell
On Thu, 2014-02-06 at 17:30 +0400, Michael Tokarev wrote: > 06.02.2014 17:15, Ian Campbell wrote: > > On Thu, 2014-02-06 at 17:08 +0400, Michael Tokarev wrote: > >> 06.02.2014 12:50, Gerd Hoffmann wrote: > [] > >>> As far I know xen has its own seabios builds

Re: [Qemu-devel] 128Kb bios size and older machines?

2014-02-06 Thread Ian Campbell
On Thu, 2014-02-06 at 15:31 +0100, Gerd Hoffmann wrote: > Hi, > > > I'm not sure why the BIOS size is relevant to migration anyway, Xen > > doesn't load a new BIOS on the target host, the BIOS image is part of > > the migrated RAM. > > The memory layout is different with a larger bios as qemu m

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen: build on ARM

2013-12-18 Thread Ian Campbell
On Tue, 2013-12-17 at 17:31 +, Stefano Stabellini wrote: > Collection of fixes to build QEMU with Xen support on ARM: > - use xenstore_read_fe_uint64 to retrieve the page-ref (xenfb); > - use xen_pfn_t instead of unsigned long in xenfb; > - unsigned long/xenpfn_t in xen_remove_from_physmap; > -

Re: [Qemu-devel] [Xen-devel] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-04-28 Thread Ian Campbell
On Mon, 2014-04-28 at 12:14 +0200, Fabio Fantoni wrote: > Il 22/01/2014 15:32, Fabio Fantoni ha scritto: > > Il 28/10/2013 10:38, Jan Beulich ha scritto: > > On 24.10.13 at 14:17, "Gonglei (Arei)" > > wrote: > >>> Now I test the patch based on the codes of trunk, which works well. > >>> T

Re: [Qemu-devel] [Xen-devel] Discussion: xen hvm guest direct kernel boot

2014-04-28 Thread Ian Campbell
On Fri, 2014-04-25 at 01:08 -0600, Chun Yan Liu wrote: > Hi, > > I'm looking at xen hvm guest direct kernel boot and interested to do > it. I found there were some discussions about it and an early work > around by Daniel (based on xen qemu-dm). > [1]http://old-list-archives.xenproject.org/xen-de

Re: [Qemu-devel] [Xen-devel] Discussion: xen hvm guest direct kernel boot

2014-04-28 Thread Ian Campbell
On Mon, 2014-04-28 at 16:36 +0100, Ian Campbell wrote: > On Fri, 2014-04-25 at 01:08 -0600, Chun Yan Liu wrote: > > Hi, > > > > I'm looking at xen hvm guest direct kernel boot and interested to do > > it. I found there were some discussions about it and an early

Re: [Qemu-devel] [Xen-devel] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2013-10-16 Thread Ian Campbell
On Wed, 2013-10-16 at 06:30 +, Gonglei (Arei) wrote: > http://lists.xen.org/archives/html/xen-devel/2013-09/msg03113.html > As said above, In Xen platform, after using upstream qemu, all pci devices > can be unpluged in the windows guest. > In this situation, the windows guest may occur blue s

Re: [Qemu-devel] [Xen-devel] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2013-10-16 Thread Ian Campbell
On Wed, 2013-10-16 at 10:54 +0100, Jan Beulich wrote: > >>> On 16.10.13 at 08:30, "Gonglei (Arei)" wrote: > > --- hvmloader/acpi/Makefile 2013-10-16 11:51:53.0 +0800 > > +++ hvmloader_new//acpi/Makefile2013-10-16 11:51:58.0 +0800 > > @@ -36,18 +36,34 @@ > > > > dsdt_anycpu_q

Re: [Qemu-devel] [Xen-devel] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2013-10-16 Thread Ian Campbell
On Wed, 2013-10-16 at 12:49 +0200, Markus Armbruster wrote: > Ian Campbell writes: > > > On Wed, 2013-10-16 at 10:54 +0100, Jan Beulich wrote: > >> >>> On 16.10.13 at 08:30, "Gonglei (Arei)" wrote: > >> > --- hvmloader/ac

Re: [Qemu-devel] [PATCH V3] xl: HVM domain S3 bugfix

2013-10-31 Thread Ian Campbell
On Tue, 2013-10-22 at 06:03 +, Liu, Jinsong wrote: > Ian Campbell wrote: > > On Mon, 2013-09-09 at 03:29 +, Liu, Jinsong wrote: > >> From 18344216b432648605726b137b348f28ef64a4ef Mon Sep 17 00:00:00 > >> 2001 > >> From: Liu Jinsong > >> Date:

Re: [Qemu-devel] [Xen-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-18 Thread Ian Campbell
On Wed, 2015-02-11 at 10:45 +0800, Chen, Tiejun wrote: > On 2015/2/9 19:05, Ian Campbell wrote: > > On Mon, 2015-02-09 at 14:28 +0800, Chen, Tiejun wrote: > > > >> What about this? > > > > I've not read the code in detail,since I'm travelling but from

Re: [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-02 Thread Ian Campbell
On Mon, 2015-02-02 at 09:17 +0800, Tiejun Chen wrote: > When we're working to support IGD GFX passthrough with qemu > upstream, instead of "-gfx_passthru" we'd like to make that > a machine option, "-machine xxx,-igd-passthru=on". This need > to bring a change on tool side. >From which Qemu versio

Re: [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-03 Thread Ian Campbell
On Tue, 2015-02-03 at 09:04 +0800, Chen, Tiejun wrote: > > On 2015/2/2 20:54, Ian Jackson wrote: > > Wei Liu writes ("Re: [v2][PATCH] libxl: add one machine property to support > > IGD GFX passthrough"): > >> On Mon, Feb 02, 2015 at 09:17:23AM +0800, Tiejun Chen wrote: > >>> When we're working to

Re: [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-04 Thread Ian Campbell
On Wed, 2015-02-04 at 09:34 +0800, Chen, Tiejun wrote: > > > >> "-machine xxx,igd-passthru=on", to enable/disable that feature. > >> And we also remove that old option, "-gfx_passthru", just from > >> the case of LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN since actually > >> no any

Re: [Qemu-devel] [Xen-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-05 Thread Ian Campbell
On Thu, 2015-02-05 at 09:22 +0800, Chen, Tiejun wrote: > Indeed this is not something workaround, and I think in any type of VGA > devices, we'd like to diminish this sort of thing gradually, right? > > This mightn't come true in real world :) It's not really something we can control, the h/w gu

Re: [Qemu-devel] [Xen-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-09 Thread Ian Campbell
On Mon, 2015-02-09 at 14:28 +0800, Chen, Tiejun wrote: > What about this? I've not read the code in detail,since I'm travelling but from a quick glance it looks to be implementing the sort of thing I meant, thanks. A couple of higher level comments: I'd suggest to put the code for reading the v

Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-18 Thread Ian Campbell
On Wed, 2015-03-18 at 15:32 +0800, Chen, Tiejun wrote: > > I think the _libxl_ message needs to be just "Unable to detect graphics > > passthru kind". i.e. it can't/shouldn't reference anything to do with xl > > config options etc (which would make no sense if libvirt was being > > used). > > > > T

Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-19 Thread Ian Campbell
On Thu, 2015-03-19 at 10:07 +0800, Chen, Tiejun wrote: > > This duplicates the code from above. I think this would be best done as: > > > > static int libxl__detect_gfx_passthru_kind(libxl__gc *gc, guest_config) > > { > > if (b_info->u.hvm.gfx_passthru_kind != LIBXL_GFX_PASSTHRU_KIND_DEFAULT)

Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine

2015-03-19 Thread Ian Campbell
On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote: > @@ -151,6 +152,8 @@ device_hardware_setup(void) > esp_scsi_setup(); > megasas_setup(); > pvscsi_setup(); > +if (runningOnXen()) > +vtpm4hvm_setup(); Is there anything which is actually Xen specific about the driver in t

Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 09:04 +0800, Chen, Tiejun wrote: > Refactor again, > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > index 8599a6a..05c8916 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -409,6 +409,23 @@ static char *dm_spice_options(libxl__gc *gc

Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 18:08 +0800, Chen, Tiejun wrote: > +if (!xlu_cfg_get_string(config, "gfx_passthru_kind", &buf, 0)) { > +if (libxl_gfx_passthru_kind_from_string(buf, > + > &b_info->u.hvm.gfx_passthru_kind)) { > +fprintf(stderr, > +"E

Re: [Qemu-devel] One question to lowlevel/xl/xl.c and lowlevel/xc/xc.c

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 16:47 +0800, Chen, Tiejun wrote: > All guys, > > Sorry to bother you. > > I have a question to two files, tools/python/xen/lowlevel/xc/xc.c and > tools/python/xen/lowlevel/xl/xl.c. Who is a caller to those methods like > pyxc_methods[] and pyxl_methods[]? They are registe

Re: [Qemu-devel] One question to lowlevel/xl/xl.c and lowlevel/xc/xc.c

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 18:15 +0800, Chen, Tiejun wrote: > On 2015/3/24 17:51, Ian Campbell wrote: > > On Tue, 2015-03-24 at 16:47 +0800, Chen, Tiejun wrote: > >> All guys, > >> > > Thanks for your reply. > > >> Sorry to bother you. > >>

  1   2   3   >