Re: [PATCH v3 2/2] vhost-net: Fix the virtio features negotiation flaw

2022-11-14 Thread Hyman
在 2022/11/11 3:17, Michael S. Tsirkin 写道: On Sun, Oct 30, 2022 at 09:52:39PM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Save the acked_features once it be configured by guest virtio driver so it can't miss any features. Note that this patch also change the fea

Re: [PATCH v2 07/11] migration: Implement dirty-limit convergence algo

2022-11-30 Thread Hyman
在 2022/11/30 7:17, Peter Xu 写道: On Mon, Nov 21, 2022 at 11:26:39AM -0500, huang...@chinatelecom.cn wrote: diff --git a/migration/migration.c b/migration/migration.c index 86950a1..096b61a 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -240,6 +240,7 @@ void migration_cancel(

Re: [PATCH v2 08/11] migration: Export dirty-limit time info

2022-11-30 Thread Hyman
在 2022/11/30 8:09, Peter Xu 写道: On Mon, Nov 21, 2022 at 11:26:40AM -0500, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Export dirty limit throttle time and estimated ring full time, through which we can observe the process of dirty limit during live migration. Signed-off-by

Re: [PATCH v2 08/11] migration: Export dirty-limit time info

2022-12-03 Thread Hyman
在 2022/11/22 0:26, huang...@chinatelecom.cn 写道: From: Hyman Huang(黄勇) Export dirty limit throttle time and estimated ring full time, through which we can observe the process of dirty limit during live migration. Signed-off-by: Hyman Huang(黄勇) --- include/sysemu/dirtylimit.h | 2

Re: [PULL 06/30] softmmu/dirtylimit: Implement virtual CPU throttle

2022-07-29 Thread Hyman
在 2022/7/29 22:14, Richard Henderson 写道: On 7/29/22 06:31, Peter Maydell wrote: On Wed, 20 Jul 2022 at 12:30, Dr. David Alan Gilbert (git) wrote: From: Hyman Huang(黄勇) Setup a negative feedback system when vCPU thread handling KVM_EXIT_DIRTY_RING_FULL exit by introducing

Re: [PATCH 0/8] migration: introduce dirtylimit capability

2022-08-10 Thread Hyman
Ping. How about this series? hoping to get comments if anyone has played with it. Thanks ! Hyman 在 2022/7/23 15:49, huang...@chinatelecom.cn 写道: From: Hyman Huang(黄勇) Abstract This series added a new migration capability called "dirtylimit". It can be enabled when

[PATCH QEMU v9 0/9] migration: introduce dirtylimit capability

2023-07-20 Thread ~hyman
to forbid hmp/qmp commands set_vcpu_dirty_limit, cancel_vcpu_dirty_limit during dirty-limit live migration when implement dirty-limit convergence algo. 6. add capability check to ensure auto-converge and dirty-limit are mutually exclusive. 7. pre-check if kvm dirty ring size is config

[PATCH QEMU v9 2/9] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter

2023-07-20 Thread ~hyman
From: Hyman Huang(黄勇) Introduce "x-vcpu-dirty-limit-period" migration experimental parameter, which is in the range of 1 to 1000ms and used to make dirty page rate calculation period configurable. Currently with the "x-vcpu-dirty-limit-period" varies, the total time of li

[PATCH QEMU v9 6/9] migration: Put the detection logic before auto-converge checking

2023-07-20 Thread ~hyman
From: Hyman Huang(黄勇) This commit is prepared for the implementation of dirty-limit convergence algo. The detection logic of throttling condition can apply to both auto-converge and dirty-limit algo, putting it's position before the checking logic for auto-converge feature. Signed-o

[PATCH QEMU v9 1/9] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit"

2023-07-20 Thread ~hyman
From: Hyman Huang(黄勇) dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid if less than 0, so add parameter check for it. Note that this patch also delete the unsolicited help message and clean up the code. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Markus

[PATCH QEMU v9 3/9] qapi/migration: Introduce vcpu-dirty-limit parameters

2023-07-20 Thread ~hyman
From: Hyman Huang(黄勇) Introduce "vcpu-dirty-limit" migration parameter used to limit dirty page rate during live migration. "vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are two dirty-limit-related migration parameters, which can be set before and during liv

[PATCH QEMU v9 7/9] migration: Implement dirty-limit convergence algorithm

2023-07-20 Thread ~hyman
From: Hyman Huang(黄勇) Implement dirty-limit convergence algorithm for live migration, which is kind of like auto-converge algo but using dirty-limit instead of cpu throttle to make migration convergent. Enable dirty page limit if dirty_rate_high_cnt greater than 2 when dirty-limit capability

[PATCH QEMU v9 4/9] migration: Introduce dirty-limit capability

2023-07-20 Thread ~hyman
From: Hyman Huang(黄勇) Introduce migration dirty-limit capability, which can be turned on before live migration and limit dirty page rate durty live migration. Introduce migrate_dirty_limit function to help check if dirty-limit capability enabled during live migration. Meanwhile, refactor

[PATCH QEMU v9 8/9] migration: Extend query-migrate to provide dirty-limit info

2023-07-20 Thread ~hyman
From: Hyman Huang(黄勇) Extend query-migrate to provide throttle time and estimated ring full time with dirty-limit capability enabled, through which we can observe if dirty limit take effect during live migration. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Markus Armbruster Reviewed-by: Juan

[PATCH QEMU v9 5/9] migration: Refactor auto-converge capability logic

2023-07-20 Thread ~hyman
From: Hyman Huang(黄勇) Check if block migration is running before throttling guest down in auto-converge way. Note that this modification is kind of like code clean, because block migration does not depend on auto-converge capability, so the order of checks can be adjusted. Signed-off-by: Hyman

[PATCH QEMU v9 9/9] tests: Add migration dirty-limit capability test

2023-07-20 Thread ~hyman
From: Hyman Huang(黄勇) Add migration dirty-limit capability test if kernel support dirty ring. Migration dirty-limit capability introduce dirty limit capability, two parameters: x-vcpu-dirty-limit-period and vcpu-dirty-limit are introduced to implement the live migration with dirty limit. The

[PATCH QEMU v10 5/9] migration: Refactor auto-converge capability logic

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) Check if block migration is running before throttling guest down in auto-converge way. Note that this modification is kind of like code clean, because block migration does not depend on auto-converge capability, so the order of checks can be adjusted. Signed-off-by: Hyman

[PATCH QEMU v10 4/9] migration: Introduce dirty-limit capability

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) Introduce migration dirty-limit capability, which can be turned on before live migration and limit dirty page rate durty live migration. Introduce migrate_dirty_limit function to help check if dirty-limit capability enabled during live migration. Meanwhile, refactor

[PATCH QEMU v10 9/9] tests: Add migration dirty-limit capability test

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) Add migration dirty-limit capability test if kernel support dirty ring. Migration dirty-limit capability introduce dirty limit capability, two parameters: x-vcpu-dirty-limit-period and vcpu-dirty-limit are introduced to implement the live migration with dirty limit. The

[PATCH QEMU v10 8/9] migration: Extend query-migrate to provide dirty-limit info

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) Extend query-migrate to provide throttle time and estimated ring full time with dirty-limit capability enabled, through which we can observe if dirty limit take effect during live migration. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Markus Armbruster Reviewed-by: Juan

[PATCH QEMU v10 1/9] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit"

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid if less than 0, so add parameter check for it. Note that this patch also delete the unsolicited help message and clean up the code. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Markus

[PATCH QEMU v10 7/9] migration: Implement dirty-limit convergence algorithm

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) Implement dirty-limit convergence algorithm for live migration, which is kind of like auto-converge algo but using dirty-limit instead of cpu throttle to make migration convergent. Enable dirty page limit if dirty_rate_high_cnt greater than 2 when dirty-limit capability

[PATCH QEMU v10 3/9] qapi/migration: Introduce vcpu-dirty-limit parameters

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) Introduce "vcpu-dirty-limit" migration parameter used to limit dirty page rate during live migration. "vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are two dirty-limit-related migration parameters, which can be set before and during liv

[PATCH QEMU v10 2/9] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) Introduce "x-vcpu-dirty-limit-period" migration experimental parameter, which is in the range of 1 to 1000ms and used to make dirty page rate calculation period configurable. Currently, as the "x-vcpu-dirty-limit-period" varies, the total time of li

[PATCH QEMU v10 0/9] migration: introduce dirtylimit capability

2023-07-24 Thread ~hyman
capability check to ensure auto-converge and dirty-limit are mutually exclusive. 7. pre-check if kvm dirty ring size is configured before setting dirty-limit migrate parameter Hyman Huang(黄勇) (9): softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit" qapi/migr

[PATCH QEMU v10 6/9] migration: Put the detection logic before auto-converge checking

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) This commit is prepared for the implementation of dirty-limit convergence algo. The detection logic of throttling condition can apply to both auto-converge and dirty-limit algo, putting it's position before the checking logic for auto-converge feature. Signed-o

[PATCH QEMU 0/2] migration: craft the doc comments

2023-07-26 Thread ~hyman
Hi, Markus, This patchset aims to reformat migration doc comments as commit a937b6aa739. Meanwhile, add myself to the dirty-limit feature maintainer list. Please review, Thanks. Yong Hyman Huang(黄勇) (2): qapi: Reformat and craft the migration doc comments MAINTAINERS: Add Hyman Huang to

[PATCH QEMU 1/2] qapi: Reformat and craft the migration doc comments

2023-07-26 Thread ~hyman
From: Hyman Huang(黄勇) Reformat migration doc comments to conform to current conventions as commit a937b6aa739 (qapi: Reformat doc comments to conform to current conventions). Also, craft the dirty-limit capability comment. Signed-off-by: Hyman Huang(黄勇) --- qapi/migration.json | 66

[PATCH QEMU 2/2] MAINTAINERS: Add Hyman Huang to dirty-limit feature

2023-07-26 Thread ~hyman
From: Hyman Huang(黄勇) Signed-off-by: Hyman Huang(黄勇) --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 12e59b6b27..d72fd63a8e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3437,6 +3437,12 @@ F: hw/core/clock-vmstate.c F: hw/core/qdev

[PATCH QEMU 2/3] qapi: Craft the dirty-limit capability comment

2023-07-28 Thread ~hyman
From: Hyman Huang(黄勇) Signed-off-by: Markus Armbruster Signed-off-by: Hyman Huang(黄勇) --- qapi/migration.json | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index a74ade4d72..62ab151da2 100644 --- a/qapi

[PATCH QEMU 3/3] MAINTAINERS: Add Hyman Huang as maintainer

2023-07-28 Thread ~hyman
From: Hyman Huang(黄勇) I've built interests in dirty-limit and dirty page rate features and also have been working on projects related to this subsystem. Self-recommand myself as a maintainer for this subsystem so that I can help to improve the dirty-limit algorithm and review the patches

[PATCH QEMU 0/3] migration: craft the doc comments

2023-07-28 Thread ~hyman
Hi, Markus, Juan. Please review the version 2, thanks. v2: - split the first commit in v1 into 2 - add commit message of commit: MAINTAINERS: Add Hyman Huang as maintainer Yong Hyman Huang(黄勇) (3): qapi: Reformat the dirty-limit migration doc comments qapi: Craft the dirty-limit

[PATCH QEMU 1/3] qapi: Reformat the dirty-limit migration doc comments

2023-07-28 Thread ~hyman
From: Hyman Huang(黄勇) Reformat the dirty-limit migration doc comments to conform to current conventions as commit a937b6aa739 (qapi: Reformat doc comments to conform to current conventions). Signed-off-by: Markus Armbruster Signed-off-by: Hyman Huang(黄勇) --- qapi/migration.json | 69

[PATCH QEMU 3/3] tests/migration: Introduce dirty-limit into guestperf

2023-07-28 Thread ~hyman
From: Hyman Huang(黄勇) Currently, guestperf does not cover the dirty-limit migration, support this feature. Note that dirty-limit requires 'dirty-ring-size' set. To enable dirty-limit, setting x-vcpu-dirty-limit-period as 500ms and x-vcpu-dirty-limit as 10MB/s: $ ./tests/migration/gu

[PATCH QEMU 0/3] migration: enrich the dirty-limit test case

2023-07-28 Thread ~hyman
review, thanks. Yong. Hyman Huang(黄勇) (3): tests: Add migration dirty-limit capability test tests/migration: Introduce dirty-ring-size option into guestperf tests/migration: Introduce dirty-limit into guestperf tests/migration/guestperf/comparison.py | 23 tests/migration/guestperf

[PATCH QEMU 1/3] tests: Add migration dirty-limit capability test

2023-07-28 Thread ~hyman
From: Hyman Huang(黄勇) Add migration dirty-limit capability test if kernel support dirty ring. Migration dirty-limit capability introduce dirty limit capability, two parameters: x-vcpu-dirty-limit-period and vcpu-dirty-limit are introduced to implement the live migration with dirty limit. The

[PATCH QEMU 2/3] tests/migration: Introduce dirty-ring-size option into guestperf

2023-07-28 Thread ~hyman
From: Hyman Huang(黄勇) Dirty ring size configuration is not supported by guestperf tool. Introduce dirty-ring-size (ranges in [1024, 65536]) option so developers can play with dirty-ring and dirty-limit feature easier. To set dirty ring size with 4096 during migration test: $ ./tests/migration

[PATCH QEMU v3 2/3] qapi: Craft the dirty-limit capability comment

2023-07-30 Thread ~hyman
From: Hyman Huang(黄勇) Signed-off-by: Markus Armbruster Signed-off-by: Hyman Huang(黄勇) --- qapi/migration.json | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index a74ade4d72..62ab151da2 100644 --- a/qapi

[PATCH QEMU v3 0/3] migration: craft the doc comments

2023-07-30 Thread ~hyman
it message of commit: MAINTAINERS: Add Hyman Huang as maintainer Yong Hyman Huang(黄勇) (3): qapi: Reformat the dirty-limit migration doc comments qapi: Craft the dirty-limit capability comment MAINTAINERS: Add section "Migration dirty limit and dirty page rate" MAINTAIN

[PATCH QEMU v3 3/3] MAINTAINERS: Add section "Migration dirty limit and dirty page rate"

2023-07-30 Thread ~hyman
From: Hyman Huang(黄勇) I've built interests in dirty limit and dirty page rate features and also have been working on projects related to this subsystem. Add a section to the MAINTAINERS file for migration dirty limit and dirty page rate. Add myself as a maintainer for this subsystem so t

[PATCH QEMU v3 1/3] qapi: Reformat the dirty-limit migration doc comments

2023-07-30 Thread ~hyman
From: Hyman Huang(黄勇) Reformat the dirty-limit migration doc comments to conform to current conventions as commit a937b6aa739 (qapi: Reformat doc comments to conform to current conventions). Signed-off-by: Markus Armbruster Signed-off-by: Hyman Huang(黄勇) --- qapi/migration.json | 69

[PATCH QEMU v2 1/3] tests: Add migration dirty-limit capability test

2023-07-30 Thread ~hyman
From: Hyman Huang(黄勇) Add migration dirty-limit capability test if kernel support dirty ring. Migration dirty-limit capability introduce dirty limit capability, two parameters: x-vcpu-dirty-limit-period and vcpu-dirty-limit are introduced to implement the live migration with dirty limit. The

[PATCH QEMU v2 0/3] migration: enrich the dirty-limit test case

2023-07-30 Thread ~hyman
test case could be enriched to make sure the behavior and the performance of dirty-limit is exactly what we want. This series adds 2 test cases, the first commit aims for the functional test and the others aim for the performance test. Please review, thanks. Yong. Hyman Huang(黄勇) (3): tests: Add

[PATCH QEMU v2 2/3] tests/migration: Introduce dirty-ring-size option into guestperf

2023-07-30 Thread ~hyman
From: Hyman Huang(黄勇) Dirty ring size configuration is not supported by guestperf tool. Introduce dirty-ring-size (ranges in [1024, 65536]) option so developers can play with dirty-ring and dirty-limit feature easier. To set dirty ring size with 4096 during migration test: $ ./tests/migration

[PATCH QEMU v2 3/3] tests/migration: Introduce dirty-limit into guestperf

2023-07-30 Thread ~hyman
From: Hyman Huang(黄勇) Currently, guestperf does not cover the dirty-limit migration, support this feature. Note that dirty-limit requires 'dirty-ring-size' set. To enable dirty-limit, setting x-vcpu-dirty-limit-period as 500ms and x-vcpu-dirty-limit as 10MB/s: $ ./tests/migration/gu

[PATCH QEMU 3/3] vhost-user-blk-pci: introduce auto-num-queues property

2023-08-05 Thread ~hyman
From: Hyman Huang(黄勇) Commit "a4eef0711b vhost-user-blk-pci: default num_queues to -smp N" implment sizing the number of vhost-user-blk-pci request virtqueues to match the number of vCPUs automatically. Which improves IO preformance remarkably. To enable this feature for the existin

[PATCH QEMU 1/3] virtio-scsi-pci: introduce auto-num-queues property

2023-08-05 Thread ~hyman
From: Hyman Huang(黄勇) Commit "6a55882284 virtio-scsi-pci: default num_queues to -smp N" implment sizing the number of virtio-scsi-pci request virtqueues to match the number of vCPUs automatically. Which improves IO preformance remarkably. To enable this feature for the existing VMs,

[PATCH QEMU 0/3] provide a smooth upgrade solution for multi-queues disk

2023-08-05 Thread ~hyman
the QEMU side, which is what the patch set does. I'm hoping for comments about the series. Please review, thanks. Yong Hyman Huang(黄勇) (3): virtio-scsi-pci: introduce auto-num-queues property virtio-blk-pci: introduce auto-num-queues property vhost-user-blk-pci: introduce auto-num-queu

[PATCH QEMU 2/3] virtio-blk-pci: introduce auto-num-queues property

2023-08-05 Thread ~hyman
From: Hyman Huang(黄勇) Commit "9445e1e15 virtio-blk-pci: default num_queues to -smp N" implment sizing the number of virtio-blk-pci request virtqueues to match the number of vCPUs automatically. Which improves IO preformance remarkably. To enable this feature for the existing VMs,

Re: [PATCH v3 3/3] cpus-common: implement dirty limit on vCPU

2021-11-22 Thread Hyman
在 2021/11/22 19:26, Markus Armbruster 写道: Hyman Huang writes: 在 2021/11/22 17:10, Markus Armbruster 写道: Hyman Huang writes: =E5=9C=A8 2021/11/22 15:35, Markus Armbruster =E5=86=99=E9=81=93: huang...@chinatelecom.cn writes: From: Hyman Huang(=E9=BB=84=E5=8B=87) implement dirtyrate

Re: [PATCH v6 3/3] cpus-common: implement dirty page limit on vCPU

2021-11-26 Thread Hyman
在 2021/11/26 15:03, Markus Armbruster 写道: huang...@chinatelecom.cn writes: From: Hyman Huang(黄勇) Implement dirtyrate calculation periodically basing on dirty-ring and throttle vCPU until it reachs the quota dirty page rate given by user. Introduce qmp commands set-dirty-limit/cancel

Re: [PATCH v16 0/7] support dirty restraint on vCPU

2022-03-02 Thread Hyman
在 2022/3/3 0:53, Dr. David Alan Gilbert 写道: * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: * huang...@chinatelecom.cn (huang...@chinatelecom.cn) wrote: From: Hyman Huang(黄勇) Queued via my migration/hmp/etc tree Hi, Unfortunately I've had to unqueue this - it breaks th

Re: [PATCH V13 0/7] support dirty restraint on vCPU

2022-02-10 Thread Hyman
"Sent by accident, please ignore, I'll send v14 when ready." 在 2022/2/11 0:06, huang...@chinatelecom.cn 写道: From: Hyman Huang(黄勇) v13 - rebase on master - passing NULL to kvm_dirty_ring_reap in commit "refactor per-vcpu dirty ring reaping" to keep the logic unchan

Re: [PATCH 2/8] qapi/migration: Introduce vcpu-dirty-limit parameters

2022-08-18 Thread Hyman
在 2022/8/18 6:07, Peter Xu 写道: On Sat, Jul 23, 2022 at 03:49:14PM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Introduce "vcpu-dirty-limit" migration parameter used to limit dirty page rate during live migration. "vcpu-dirty-limit" and "x-vcpu-di

Re: [PATCH 1/8] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter

2022-08-18 Thread Hyman
在 2022/8/18 6:06, Peter Xu 写道: On Sat, Jul 23, 2022 at 03:49:13PM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Introduce "x-vcpu-dirty-limit-period" migration experimental parameter, which is used to make dirtyrate calculation period configurable. Signed-off

Re: [PATCH 4/8] migration: Implement dirty-limit convergence algo

2022-08-18 Thread Hyman
在 2022/8/18 6:09, Peter Xu 写道: On Sat, Jul 23, 2022 at 03:49:16PM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Implement dirty-limit convergence algo for live migration, which is kind of like auto-converge algo but using dirty-limit instead of cpu throttle to make migration

Re: [PATCH RFC 1/4] net: Introduce qmp cmd "query-netdev"

2022-11-02 Thread Hyman
在 2022/11/2 13:42, Jason Wang 写道: On Tue, Nov 1, 2022 at 12:19 AM wrote: From: Hyman Huang(黄勇) For netdev device that can offload virtio-net dataplane to slave, such as vhost-net, vhost-user and vhost-vdpa, exporting it's capability information and acked features would be more fri

Re: [PATCH RFC 1/4] net: Introduce qmp cmd "query-netdev"

2022-11-02 Thread Hyman
在 2022/11/2 14:41, Michael S. Tsirkin 写道: On Wed, Nov 02, 2022 at 01:42:39PM +0800, Jason Wang wrote: On Tue, Nov 1, 2022 at 12:19 AM wrote: From: Hyman Huang(黄勇) For netdev device that can offload virtio-net dataplane to slave, such as vhost-net, vhost-user and vhost-vdpa, exporting

Re: [PATCH RFC 1/4] net: Introduce qmp cmd "query-netdev"

2022-11-02 Thread Hyman
在 2022/11/2 15:10, Thomas Huth 写道: On 02/11/2022 06.42, Jason Wang wrote: On Tue, Nov 1, 2022 at 12:19 AM wrote: From: Hyman Huang(黄勇) For netdev device that can offload virtio-net dataplane to slave, such as vhost-net, vhost-user and vhost-vdpa, exporting it's capability inform

Re: [PATCH v3 2/2] vhost-net: Fix the virtio features negotiation flaw

2022-11-11 Thread Hyman
在 2022/11/11 3:00, Michael S. Tsirkin 写道: On Sun, Oct 30, 2022 at 09:52:39PM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Save the acked_features once it be configured by guest virtio driver so it can't miss any features. Note that this patch also change the fea

Re: [PATCH v3 2/2] vhost-net: Fix the virtio features negotiation flaw

2022-11-11 Thread Hyman
The previous reply email has an text format error, please ignore and 在 2022/11/11 3:00, Michael S. Tsirkin 写道: On Sun, Oct 30, 2022 at 09:52:39PM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Save the acked_features once it be configured by guest virtio driver so it can&#

Re: [PATCH RESEND v3 00/10] migration: introduce dirtylimit capability

2022-12-08 Thread Hyman
Ping ? 在 2022/12/4 1:09, huang...@chinatelecom.cn 写道: From: Hyman Huang(黄勇) v3(resend): - fix the syntax error of the topic. v3: This version make some modifications inspired by Peter and Markus as following: 1. Do the code clean up in [PATCH v2 02/11] suggested by Markus 2. Replace the

Re: [RFC PATCH 2/2] tests: Add dirty page rate limit test

2022-03-10 Thread Hyman
在 2022/3/10 16:29, Peter Xu 写道: On Wed, Mar 09, 2022 at 11:58:01PM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Add dirty page rate limit test if kernel support dirty ring, create a standalone file to implement the test case. Thanks for writting this test case. Signed

Re: [PATCH v21 8/9] migration-test: Export migration-test util funtions

2022-03-31 Thread Hyman
在 2022/3/30 2:54, Peter Xu 写道: On Wed, Mar 16, 2022 at 09:07:20PM +0800, huang...@chinatelecom.cn wrote: +void wait_for_serial(const char *tmpfs, const char *side) Passing over tmpfs over and over (even if it's mostly a constant) doesn't sound appealing to me.. I hope there's still a way t

Re: [PATCH v21 9/9] tests: Add dirty page rate limit test

2022-03-31 Thread Hyman
在 2022/3/30 3:54, Peter Xu 写道: On Wed, Mar 16, 2022 at 09:07:21PM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Add dirty page rate limit test if kernel support dirty ring, create a standalone file to implement the test case. The following qmp commands are covered by this

Re: [PATCH v1 0/8] migration: introduce dirtylimit capability

2022-09-07 Thread Hyman
在 2022/9/7 4:46, Peter Xu 写道: On Fri, Sep 02, 2022 at 01:22:28AM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) v1: - make parameter vcpu-dirty-limit experimental - switch dirty limit off when cancel migrate - add cancel logic in migration test Please review, thanks, Yong

Re: [PATCH v1 4/8] migration: Implement dirty-limit convergence algo

2022-09-08 Thread Hyman
在 2022/9/7 4:37, Peter Xu 写道: On Fri, Sep 02, 2022 at 01:22:32AM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Implement dirty-limit convergence algo for live migration, which is kind of like auto-converge algo but using dirty-limit instead of cpu throttle to make migration

Re: [PATCH v22 0/8] support dirty restraint on vCPU

2022-04-24 Thread Hyman
Ping. Hi, David and Peter, how do you think this patchset? Is it suitable for queueing ? or is there still something need to be done ? Yong 在 2022/4/1 1:49, huang...@chinatelecom.cn 写道: From: Hyman Huang(黄勇) This is v22 of dirtylimit series. The following is the history of the patchset

Re: [PATCH v9 3/3] cpus-common: implement dirty page limit on vCPU

2021-12-06 Thread Hyman
在 2021/12/6 16:28, Peter Xu 写道: On Sat, Dec 04, 2021 at 08:00:19PM +0800, Hyman Huang wrote: 在 2021/12/3 20:34, Markus Armbruster 写道: huang...@chinatelecom.cn writes: From: Hyman Huang(黄勇) Implement dirtyrate calculation periodically basing on dirty-ring and throttle vCPU until it

Re: [PATCH v9 3/3] cpus-common: implement dirty page limit on vCPU

2021-12-06 Thread Hyman
在 2021/12/6 16:36, Peter Xu 写道: On Fri, Dec 03, 2021 at 09:39:47AM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Implement dirtyrate calculation periodically basing on dirty-ring and throttle vCPU until it reachs the quota dirty page rate given by user. Introduce qmp

Re: [PATCH v9 3/3] cpus-common: implement dirty page limit on vCPU

2021-12-06 Thread Hyman
在 2021/12/6 16:39, Peter Xu 写道: On Fri, Dec 03, 2021 at 09:39:47AM +0800, huang...@chinatelecom.cn wrote: +void dirtylimit_setup(int max_cpus) +{ +if (!kvm_enabled() || !kvm_dirty_ring_enabled()) { +return; +} + +dirtylimit_calc_state_init(max_cpus); +dirtylimit_state_

Re: [PATCH v9 1/3] migration/dirtyrate: implement vCPU dirtyrate calculation periodically

2021-12-06 Thread Hyman
在 2021/12/6 18:18, Peter Xu 写道: On Fri, Dec 03, 2021 at 09:39:45AM +0800, huang...@chinatelecom.cn wrote: +static void dirtylimit_calc_func(void) +{ +CPUState *cpu; +DirtyPageRecord *dirty_pages; +int64_t start_time, end_time, calc_time; +DirtyRateVcpu rate; +int i = 0; +

Re: [PATCH v9 3/3] cpus-common: implement dirty page limit on vCPU

2021-12-06 Thread Hyman
在 2021/12/7 10:24, Peter Xu 写道: On Mon, Dec 06, 2021 at 10:56:00PM +0800, Hyman wrote: I found that it'll be challenging for any human being to identify "whether he/she has turned throttle off for all vcpus".. I think that could be useful when we finally decided to cancel cu

Re: [PATCH v9 3/3] cpus-common: implement dirty page limit on vCPU

2021-12-06 Thread Hyman
在 2021/12/7 10:57, Peter Xu 写道: On Mon, Dec 06, 2021 at 11:19:21PM +0800, Hyman wrote: +if (has_cpu_index) { +info = dirtylimit_query_vcpu(cpu_index); +QAPI_LIST_APPEND(tail, info); +} else { +CPUState *cpu; +CPU_FOREACH(cpu) { +if (!cpu

Re: [PATCH v9 2/3] cpu-throttle: implement vCPU throttle

2021-12-08 Thread Hyman
在 2021/12/6 18:10, Peter Xu 写道: On Fri, Dec 03, 2021 at 09:39:46AM +0800, huang...@chinatelecom.cn wrote: +static uint64_t dirtylimit_pct(unsigned int last_pct, + uint64_t quota, + uint64_t current) +{ +uint64_t limit_pct = 0; +

Re: [PATCH v9 2/3] cpu-throttle: implement vCPU throttle

2021-12-08 Thread Hyman
在 2021/12/8 23:36, Hyman 写道: 在 2021/12/6 18:10, Peter Xu 写道: On Fri, Dec 03, 2021 at 09:39:46AM +0800, huang...@chinatelecom.cn wrote: +static uint64_t dirtylimit_pct(unsigned int last_pct, +   uint64_t quota, +   uint64_t current

[PATCH QEMU v3 1/3] tests: Add migration dirty-limit capability test

2023-08-07 Thread ~hyman
From: Hyman Huang(黄勇) Add migration dirty-limit capability test if kernel support dirty ring. Migration dirty-limit capability introduce dirty limit capability, two parameters: x-vcpu-dirty-limit-period and vcpu-dirty-limit are introduced to implement the live migration with dirty limit. The

[PATCH QEMU v3 2/3] tests/migration: Introduce dirty-ring-size option into guestperf

2023-08-07 Thread ~hyman
From: Hyman Huang(黄勇) Dirty ring size configuration is not supported by guestperf tool. Introduce dirty-ring-size (ranges in [1024, 65536]) option so developers can play with dirty-ring and dirty-limit feature easier. To set dirty ring size with 4096 during migration test: $ ./tests/migration

[PATCH QEMU v3 0/3] migration: enrich the dirty-limit test case

2023-08-07 Thread ~hyman
aim for the performance test. Please review, thanks. Yong. Hyman Huang(黄勇) (3): tests: Add migration dirty-limit capability test tests/migration: Introduce dirty-ring-size option into guestperf tests/migration: Introduce dirty-limit into guestperf tests/migration/guestperf/comparison.py

[PATCH QEMU v3 3/3] tests/migration: Introduce dirty-limit into guestperf

2023-08-07 Thread ~hyman
From: Hyman Huang(黄勇) Currently, guestperf does not cover the dirty-limit migration, support this feature. Note that dirty-limit requires 'dirty-ring-size' set. To enable dirty-limit, setting x-vcpu-dirty-limit-period as 500ms and x-vcpu-dirty-limit as 10MB/s: $ ./tests/migration/gu

[PATCH QEMU] docs/migration: Add the dirty limit section

2023-08-09 Thread ~hyman
From: Hyman Huang(黄勇) The dirty limit feature has been introduced since the 8.1 QEMU release but has not reflected in the document, add a section for that. Signed-off-by: Hyman Huang(黄勇) --- docs/devel/migration.rst | 70 1 file changed, 70 insertions

[PATCH QEMU v2 2/3] virtio-blk-pci: introduce auto-num-queues property

2023-08-10 Thread ~hyman
From: Hyman Huang(黄勇) Commit "9445e1e15 virtio-blk-pci: default num_queues to -smp N" implment sizing the number of virtio-blk-pci request virtqueues to match the number of vCPUs automatically. Which improves IO preformance remarkably. To enable this feature for the existing VMs,

[PATCH QEMU v2 0/3] provide a smooth upgrade solution for multi-queues disk

2023-08-10 Thread ~hyman
68ce83 The smooth upgrade solution requires the introduction of the auto-num- queues property on the QEMU side, which is what the patch set does. I'm hoping for comments about the series. Please review, thanks. Yong Hyman Huang(黄勇) (3): virtio-scsi-pci: introduce auto-num-queues property

[PATCH QEMU v2 1/3] virtio-scsi-pci: introduce auto-num-queues property

2023-08-10 Thread ~hyman
From: Hyman Huang(黄勇) Commit "6a55882284 virtio-scsi-pci: default num_queues to -smp N" implment sizing the number of virtio-scsi-pci request virtqueues to match the number of vCPUs automatically. Which improves IO preformance remarkably. To enable this feature for the existing VMs,

[PATCH QEMU v2 3/3] vhost-user-blk-pci: introduce auto-num-queues property

2023-08-10 Thread ~hyman
From: Hyman Huang(黄勇) Commit "a4eef0711b vhost-user-blk-pci: default num_queues to -smp N" implment sizing the number of vhost-user-blk-pci request virtqueues to match the number of vCPUs automatically. Which improves IO preformance remarkably. To enable this feature for the existin

[PATCH QEMU v8 1/9] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit"

2023-07-06 Thread ~hyman
From: Hyman Huang(黄勇) dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid if less than 0, so add parameter check for it. Note that this patch also delete the unsolicited help message and clean up the code. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Markus

[PATCH QEMU v8 2/9] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter

2023-07-06 Thread ~hyman
From: Hyman Huang(黄勇) Introduce "x-vcpu-dirty-limit-period" migration experimental parameter, which is in the range of 1 to 1000ms and used to make dirtyrate calculation period configurable. Currently with the "x-vcpu-dirty-limit-period" varies, the total time of live mig

[PATCH QEMU v8 4/9] migration: Introduce dirty-limit capability

2023-07-06 Thread ~hyman
From: Hyman Huang(黄勇) Introduce migration dirty-limit capability, which can be turned on before live migration and limit dirty page rate durty live migration. Introduce migrate_dirty_limit function to help check if dirty-limit capability enabled during live migration. Meanwhile, refactor

[PATCH QEMU v8 5/9] migration: Refactor auto-converge capability logic

2023-07-06 Thread ~hyman
From: Hyman Huang(黄勇) Check if block migration is running before throttling guest down in auto-converge way. Note that this modification is kind of like code clean, because block migration does not depend on auto-converge capability, so the order of checks can be adjusted. Signed-off-by: Hyman

[PATCH QEMU v8 6/9] migration: Put the detection logic before auto-converge checking

2023-07-06 Thread ~hyman
From: Hyman Huang(黄勇) This commit is prepared for the implementation of dirty-limit convergence algo. The detection logic of throttling condition can apply to both auto-converge and dirty-limit algo, putting it's position before the checking logic for auto-converge feature. Signed-o

[PATCH QEMU v8 0/9] migration: introduce dirtylimit capability

2023-07-06 Thread ~hyman
mutually exclusive. 7. pre-check if kvm dirty ring size is configured before setting dirty-limit migrate parameter Hyman Huang(黄勇) (9): softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit" qapi/migration: Introduce x-vcpu-dirty-limit-period parameter qapi/migrat

[PATCH QEMU v8 3/9] qapi/migration: Introduce vcpu-dirty-limit parameters

2023-07-06 Thread ~hyman
From: Hyman Huang(黄勇) Introduce "vcpu-dirty-limit" migration parameter used to limit dirty page rate during live migration. "vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are two dirty-limit-related migration parameters, which can be set before and during liv

[PATCH QEMU v8 9/9] tests: Add migration dirty-limit capability test

2023-07-06 Thread ~hyman
From: Hyman Huang(黄勇) Add migration dirty-limit capability test if kernel support dirty ring. Migration dirty-limit capability introduce dirty limit capability, two parameters: x-vcpu-dirty-limit-period and vcpu-dirty-limit are introduced to implement the live migration with dirty limit. The

[PATCH QEMU v8 8/9] migration: Extend query-migrate to provide dirty page limit info

2023-07-06 Thread ~hyman
From: Hyman Huang(黄勇) Extend query-migrate to provide throttle time and estimated ring full time with dirty-limit capability enabled, through which we can observe if dirty limit take effect during live migration. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Markus Armbruster Reviewed-by: Juan

[PATCH QEMU v8 7/9] migration: Implement dirty-limit convergence algo

2023-07-06 Thread ~hyman
From: Hyman Huang(黄勇) Implement dirty-limit convergence algo for live migration, which is kind of like auto-converge algo but using dirty-limit instead of cpu throttle to make migration convergent. Enable dirty page limit if dirty_rate_high_cnt greater than 2 when dirty-limit capability enabled

[PATCH QEMU v7 2/9] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter

2023-07-04 Thread ~hyman
From: Hyman Huang(黄勇) Introduce "x-vcpu-dirty-limit-period" migration experimental parameter, which is in the range of 1 to 1000ms and used to make dirtyrate calculation period configurable. Currently with the "x-vcpu-dirty-limit-period" varies, the total time of live mig

[PATCH QEMU v7 6/9] migration: Put the detection logic before auto-converge checking

2023-07-04 Thread ~hyman
From: Hyman Huang(黄勇) This commit is prepared for the implementation of dirty-limit convergence algo. The detection logic of throttling condition can apply to both auto-converge and dirty-limit algo, putting it's position before the checking logic for auto-converge feature. Signed-o

[PATCH QEMU v7 8/9] migration: Extend query-migrate to provide dirty page limit info

2023-07-04 Thread ~hyman
From: Hyman Huang(黄勇) Extend query-migrate to provide throttle time and estimated ring full time with dirty-limit capability enabled, through which we can observe if dirty limit take effect during live migration. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Markus Armbruster Reviewed-by: Juan

[PATCH QEMU v7 5/9] migration: Refactor auto-converge capability logic

2023-07-04 Thread ~hyman
From: Hyman Huang(黄勇) Check if block migration is running before throttling guest down in auto-converge way. Note that this modification is kind of like code clean, because block migration does not depend on auto-converge capability, so the order of checks can be adjusted. Signed-off-by: Hyman

[PATCH QEMU v7 4/9] migration: Introduce dirty-limit capability

2023-07-04 Thread ~hyman
From: Hyman Huang(黄勇) Introduce migration dirty-limit capability, which can be turned on before live migration and limit dirty page rate durty live migration. Introduce migrate_dirty_limit function to help check if dirty-limit capability enabled during live migration. Meanwhile, refactor

  1   2   3   4   5   >