[Qemu-devel] [PATCH 6/6] virtfs: Fix documentation of -fsdev and -virtfs

2019-05-07 Thread Greg Kurz
dev local - add some missing periods Buglink: https://bugs.launchpad.net/qemu/+bug/1581976 Signed-off-by: Greg Kurz --- qemu-options.hx | 84 +++ 1 file changed, 60 insertions(+), 24 deletions(-) diff --git a/qemu-options.hx b/qemu-options.h

Re: [Qemu-devel] [PATCH v2 0/4] 9p: Fix file ID collisions

2019-05-07 Thread Greg Kurz
On Fri, 03 May 2019 18:20:39 +0200 Christian Schoenebeck wrote: > Hi! > > This is v2 of a proposed patch set for fixing file ID collisions with 9pfs. > > Patch 1 to 3 are identical to the previous version. New in this v2 is patch 4 > which introduces variable length suffixes for inode mapping i

Re: [Qemu-devel] [PATCH v2 1/4] 9p: mitigates most QID path collisions

2019-05-07 Thread Greg Kurz
On Fri, 03 May 2019 18:21:36 +0200 Christian Schoenebeck wrote: > This first patch here is an updated version of Antonios Motakis' > original 4-patch set, merged to one patch: > > https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg02283.html > > * Updated to latest git master, specificall

Re: [Qemu-devel] [PATCH v2 2/4] 9P: trivial cleanup of QID path collision mitigation

2019-05-07 Thread Greg Kurz
On Fri, 03 May 2019 18:22:12 +0200 Christian Schoenebeck wrote: > Addresses trivial changes regarding the previous patch as requested > on the mailing list a while ago. > Ah... so that explains why I couldn't find the changes in the other patch. > * Removed unneccessary parantheses: > https:

Re: [Qemu-devel] [PATCH v2 3/4] 9p: persistency of QID path beyond reboots / suspensions

2019-05-07 Thread Greg Kurz
On Fri, 03 May 2019 18:23:03 +0200 Christian Schoenebeck wrote: > This patch aims to keep QID path identical beyond the scope of reboots and > guest suspensions. With the 1st patch alone the QID path of the same files > might change after reboots / suspensions, since 9p would restart with > empty

Re: [Qemu-devel] [libvirt patch] qemu: adds support for virtfs 9p argument 'vii'

2019-05-07 Thread Greg Kurz
On Mon, 06 May 2019 19:58:28 +0200 Christian Schoenebeck wrote: > This is the counter part patch against latest libvirt git master head to Hmm... shouldn't this be Cc'd to libvir-l...@redhat.com as well then ? > support the 'vii' feature of patch 5, which introduces the XML config What is patc

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/5] pci: Make is_bridge a bool

2019-05-07 Thread Greg Kurz
On Tue, 7 May 2019 16:23:15 +1000 David Gibson wrote: > The is_bridge field in PCIDevice acts as a bool, but is declared as an int. > Declare it as a bool for clarity, and change everything that writes it to > use true/false instead of 0/1 to match. > Reviewed-by: Greg Kurz >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 5/5] pci: Fold pci_get_bus_devfn() into its sole caller

2019-05-07 Thread Greg Kurz
On Tue, 7 May 2019 16:23:16 +1000 David Gibson wrote: > The only remaining caller of pci_get_bus_devfn() is pci_nic_init_nofail(), > itself an old compatibility function. Fold the two together to avoid > re-using the stale interface. > > While we're there replace the explicit fprintf()s with e

Re: [Qemu-devel] [libvirt patch] qemu: adds support for virtfs 9p argument 'vii'

2019-05-07 Thread Greg Kurz
On Tue, 07 May 2019 14:23:11 +0200 Christian Schoenebeck wrote: > On Dienstag, 7. Mai 2019 11:55:56 CEST Greg Kurz wrote: > > > support the 'vii' feature of patch 5, which introduces the XML config > > > > What is patch 5 ?!? What is 'vii' ? I am a

Re: [Qemu-devel] [PATCH 5/6] vl: Deprecate -virtfs_synth

2019-05-08 Thread Greg Kurz
On Wed, 8 May 2019 10:26:53 +0200 Thomas Huth wrote: > On 07/05/2019 10.45, Greg Kurz wrote: > > The synth fsdriver never got used for anything else but the > > QTest testcase for VirtIO 9P. And even there, QTest directly > > uses -fsdev synth and -device virtio-9p-{pci|dev

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Fix typo on "info pic" monitor cmd output for xive

2019-05-09 Thread Greg Kurz
On Thu, 9 May 2019 13:37:50 +0530 sathn...@linux.vnet.ibm.com wrote: > From: Satheesh Rajendran > > Instead of LISN i.e "Logical Interrupt Source Number" as per > Xive PAPR document "info pic" prints as LSIN, let's fix it. > > Signed-off-by: Sathee

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] spapr/xive: EQ page should be naturally aligned

2019-05-09 Thread Greg Kurz
On Wed, 8 May 2019 19:19:44 +0200 Cédric Le Goater wrote: > When the OS configures the EQ page in which to receive event > notifications from the XIVE interrupt controller, the page should be > naturally aligned. Add this check. > > Signed-off-by: Cédric Le Goater > ---

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] spapr/xive: fix EQ page addresses above 64GB

2019-05-09 Thread Greg Kurz
not delivered. > > Introduce a helper xive_end_qaddr() to compute this value correctly in > all places where it is used. > > Signed-off-by: Cédric Le Goater > --- I guess this patch should have a Fixes: tag and Cc qemu-stable as well since QEMU 4.0 has the issue. Apart fro

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] spapr/xive: print out the EQ page address in the monitor

2019-05-09 Thread Greg Kurz
On Wed, 8 May 2019 19:19:46 +0200 Cédric Le Goater wrote: > This proved to be a useful information when debugging issues with OS > event queues allocated above 64GB. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > hw/intc/spapr_xive.c | 5 +++-- &g

Re: [Qemu-devel] [PATCH 6/6] virtfs: Fix documentation of -fsdev and -virtfs

2019-05-09 Thread Greg Kurz
On Wed, 8 May 2019 17:54:42 +0200 Thomas Huth wrote: > On 07/05/2019 10.45, Greg Kurz wrote: > > This fixes several things: > > - add "id" description to -virtfs documentation > > - split the description into several lines in both usage and documentation >

Re: [Qemu-devel] [PATCH 2/6] fsdev: Drop unused opaque field

2019-05-09 Thread Greg Kurz
On Tue, 7 May 2019 12:24:42 +0200 Thomas Huth wrote: > On 07/05/2019 10.44, Greg Kurz wrote: > > This was introduced along with -fsdev but it never got used. > > > > Signed-off-by: Greg Kurz > > --- > > fsdev/file-op-9p.h |1 - > > 1 file changed, 1

Re: [Qemu-devel] [PATCH 1/6] fsdev: Drop unused extern declaration

2019-05-09 Thread Greg Kurz
On Tue, 7 May 2019 12:15:16 +0200 Thomas Huth wrote: > On 07/05/2019 10.44, Greg Kurz wrote: > > This is a leftover of the handle backend, removed in QEMU 4.0. > > > > Signed-off-by: Greg Kurz > > --- > > fsdev/qemu-fsdev.h |1 - > > 1 file chang

Re: [Qemu-devel] [PATCH 3/6] fsdev: Move some types definition to qemu-fsdev.c

2019-05-09 Thread Greg Kurz
On Wed, 8 May 2019 10:28:03 +0200 Thomas Huth wrote: > On 07/05/2019 10.45, Greg Kurz wrote: > > It would make sense for these types to be defined in a header file if > > we had an API for fsdrivers to register themselves. In practice, we > > only have three of them and i

Re: [Qemu-devel] [PATCH 4/6] fsdev: Error out when unsupported option is passed

2019-05-09 Thread Greg Kurz
On Wed, 8 May 2019 11:23:46 -0500 Eric Blake wrote: > On 5/7/19 3:45 AM, Greg Kurz wrote: > > Each fsdriver only supports a subset of the options that can be passed > > to -fsdev. Unsupported options are simply ignored. This could cause the > > user to erroneously

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-05-10 Thread Greg Kurz
On Mon, 22 Apr 2019 12:32:58 +0530 Aravinda Prasad wrote: > This patch adds support in QEMU to handle "ibm,nmi-register" > and "ibm,nmi-interlock" RTAS calls. > > The machine check notification address is saved when the > OS issues "ibm,nmi-register" RTAS call. > > This patch also handles the c

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 2/6] Wrapper function to wait on condition for the main loop mutex

2019-05-10 Thread Greg Kurz
ired because > qemu_global_mutex is a static variable. > > Signed-off-by: Aravinda Prasad > --- Reviewed-by: Greg Kurz > cpus.c |5 + > include/qemu/main-loop.h |8 > 2 files changed, 13 insertions(+) > > diff --git a/cpus.c b/cpus.c

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-05-10 Thread Greg Kurz
On Fri, 10 May 2019 11:06:04 +0200 Greg Kurz wrote: > On Mon, 22 Apr 2019 12:32:58 +0530 > Aravinda Prasad wrote: > > > This patch adds support in QEMU to handle "ibm,nmi-register" > > and "ibm,nmi-interlock" RTAS calls. > > > > The machin

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 3/6] target/ppc: Handle NMI guest exit

2019-05-10 Thread Greg Kurz
On Mon, 22 Apr 2019 12:33:16 +0530 Aravinda Prasad wrote: > Memory error such as bit flips that cannot be corrected > by hardware are passed on to the kernel for handling. > If the memory address in error belongs to guest then > the guest kernel is responsible for taking suitable action. > Patch

Re: [Qemu-devel] [PATCH v4 5/5] pci: Fold pci_get_bus_devfn() into its sole caller

2019-05-13 Thread Greg Kurz
icit fprintf()s with error_report(). > > Signed-off-by: David Gibson > --- Reviewed-by: Greg Kurz > hw/pci/pci.c | 60 > 1 file changed, 28 insertions(+), 32 deletions(-) > > diff --git a/hw/pci/pci.c b/hw/pci/pci.c >

Re: [Qemu-devel] [PATCH 6/6] virtfs: Fix documentation of -fsdev and -virtfs

2019-05-13 Thread Greg Kurz
On Mon, 13 May 2019 10:39:17 +0200 Thomas Huth wrote: > On 09/05/2019 15.18, Greg Kurz wrote: > > On Wed, 8 May 2019 17:54:42 +0200 > > Thomas Huth wrote: > > > >> On 07/05/2019 10.45, Greg Kurz wrote: > >>> This fixes several things: > >&g

[Qemu-devel] [PATCH v2 1/2] vl: Deprecate -virtfs_synth

2019-05-13 Thread Greg Kurz
The synth fsdriver never got used for anything else but the QTest testcase for VirtIO 9P. And even there, QTest uses -fsdev synth and -device virtio-9p-... directly. Signed-off-by: Greg Kurz --- v2: - change "no replacement" to "use '-fsdev synth' instead" --

[Qemu-devel] [PATCH v2 0/2] fsdev/virtfs: Assorted cleanups and fixes

2019-05-13 Thread Greg Kurz
I've already applied patches from v1 with r-b tags to 9p-next. Please find updated versions of the -virtfs_synth deprecation and the documentation patches. -- Greg --- Greg Kurz (2): vl: Deprecate -virtfs_synth virtfs: Fix documentation of -fsdev and -virtfs qemu-deprecated

[Qemu-devel] [PATCH v2 2/2] virtfs: Fix documentation of -fsdev and -virtfs

2019-05-13 Thread Greg Kurz
dev local - add some missing periods - add proper reference to the virtfs-proxy-helper(1) manual page - document that the virtio device may be either virtio-9p-pci, virtio-9p-ccw or virtio-9p-device, depending on the machine type Buglink: https://bugs.launchpad.net/qemu/+bug/1581976 Signed-off-b

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 4/6] target/ppc: Build rtas error log upon an MCE

2019-05-13 Thread Greg Kurz
On Mon, 22 Apr 2019 12:33:26 +0530 Aravinda Prasad wrote: > Upon a machine check exception (MCE) in a guest address space, > KVM causes a guest exit to enable QEMU to build and pass the > error to the guest in the PAPR defined rtas error log format. > > This patch builds the rtas error log, copi

Re: [Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-05 Thread Greg Kurz
On Thu, 6 Jun 2019 13:06:14 +1000 David Gibson wrote: > On Wed, May 29, 2019 at 11:10:57AM +0530, Aravinda Prasad wrote: > > This patch includes migration support for machine check > > handling. Especially this patch blocks VM migration > > requests until the machine check error handling is > > c

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 04/10] hw/ppc: Replace global smp variables with machine smp properties

2019-06-06 Thread Greg Kurz
On Thu, 6 Jun 2019 13:07:32 +1000 David Gibson wrote: > On Wed, Jun 05, 2019 at 11:54:56PM -0300, Eduardo Habkost wrote: > > On Wed, Jun 05, 2019 at 11:52:41PM -0300, Eduardo Habkost wrote: > > > On Sun, May 19, 2019 at 04:54:22AM +0800, Like Xu wrote: > > > > The global smp variables in ppc

Re: [Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-06 Thread Greg Kurz
On Thu, 6 Jun 2019 16:45:30 +0530 Aravinda Prasad wrote: > On Thursday 06 June 2019 11:36 AM, Greg Kurz wrote: > > On Thu, 6 Jun 2019 13:06:14 +1000 > > David Gibson wrote: > > > >> On Wed, May 29, 2019 at 11:10:57AM +0530, Aravinda Prasad wrote: > >>

Re: [Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-06 Thread Greg Kurz
On Thu, 6 Jun 2019 16:55:18 +0530 Aravinda Prasad wrote: > On Thursday 06 June 2019 08:36 AM, David Gibson wrote: > > On Wed, May 29, 2019 at 11:10:57AM +0530, Aravinda Prasad wrote: > >> This patch includes migration support for machine check > >> handling. Especially this patch blocks VM migr

[Qemu-devel] [PATCH] spapr: Don't use the "dual" interrupt controller mode with an old hypervisor

2019-06-06 Thread Greg Kurz
a good choice with older KVMs. Internally force XICS when we detect this. Signed-off-by: Greg Kurz --- hw/ppc/spapr_irq.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/ppc/spapr_irq.c b/hw/ppc/spapr_irq.c index 3156daf09381..d788bd662a7a 100644 --- a/hw/ppc/spapr_irq.c

Re: [Qemu-devel] [PATCH] ppc/pnv: activate the "dumpdtb" option on the powernv machine

2019-06-06 Thread Greg Kurz
On Thu, 6 Jun 2019 19:47:32 +0200 Cédric Le Goater wrote: > This is a good way to debug the DT creation for current PowerNV > machines and new ones to come. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > hw/ppc/pnv.c | 2 ++ > 1 file changed, 2 in

Re: [Qemu-devel] [PATCH] spapr: Don't use the "dual" interrupt controller mode with an old hypervisor

2019-06-07 Thread Greg Kurz
On Fri, 7 Jun 2019 10:17:58 +0200 Cédric Le Goater wrote: > On 07/06/2019 02:19, David Gibson wrote: > > On Thu, Jun 06, 2019 at 07:08:59PM +0200, Greg Kurz wrote: > >> If KVM is too old to support XIVE native exploitation mode, we might end > >> up using the emula

Re: [Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-07 Thread Greg Kurz
On Fri, 7 Jun 2019 10:22:40 +1000 David Gibson wrote: > On Thu, Jun 06, 2019 at 02:10:48PM +0200, Greg Kurz wrote: > > On Thu, 6 Jun 2019 16:45:30 +0530 > > Aravinda Prasad wrote: > > > > > On Thursday 06 June 2019 11:36 AM, Greg Kurz wrote: > > &

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH] spapr_pci: Fix Null pointer dereferences in spapr_dt_pci_bus()

2019-06-13 Thread Greg Kurz
On Thu, 13 Jun 2019 09:56:27 +1000 David Gibson wrote: > On Thu, Jun 13, 2019 at 01:02:02AM +0200, Philippe Mathieu-Daudé wrote: > > Commit 14e714900f6 refactored the call to spapr_dt_drc(), > > but used an incorrect object owner as argument. > > > > This fixes: > > > > /hw/ppc/spapr_pci.c: 1

[Qemu-devel] [PATCH 3/3] xics/spapr: Detect old KVM XICS on POWER9 hosts

2019-06-13 Thread Greg Kurz
but unavailable: Error on KVM_CREATE_DEVICE for XICS: File exists If kernel irqchip is required, QEMU will thus exit when the guest is first rebooted. Failing QEMU this late may be a painful experience for the user. Detect that and exit at machine init instead. Signed-off-by: Greg Kurz --- docs/

[Qemu-devel] [PATCH 1/3] xics/spapr: Prevent RTAS/hypercalls emulation to be used by in-kernel XICS

2019-06-13 Thread Greg Kurz
The XICS-related RTAS calls and hypercalls in QEMU are supposed to be called only when the KVM in-kernel XICS is in use. Add some explicit checks to detect that, print an error message and report an hardware error to the guest. Signed-off-by: Greg Kurz --- hw/intc/xics_spapr.c | 46

[Qemu-devel] [PATCH 0/3] xics/kvm: Fix issues with older KVMs on POWER9 hosts

2019-06-13 Thread Greg Kurz
t/?id=5422e95103cf9663bc86cf1056a3ea44c2e2f09e --- Greg Kurz (3): xics/spapr: Prevent RTAS/hypercalls emulation to be used by in-kernel XICS xics/spapr: Register RTAS/hypercalls once at machine init xics/spapr: Detect old KVM XICS on POWER9 hosts docs/specs/ppc-spapr-xiv

[Qemu-devel] [PATCH 2/3] xics/spapr: Register RTAS/hypercalls once at machine init

2019-06-13 Thread Greg Kurz
ect when they are mistakenly called while KVM XICS is in use, it seems simpler to register them once and for all at machine init. This fixes the crash and allows to remove some now useless lines of code. Signed-off-by: Greg Kurz --- hw/intc/xics_kvm.c | 19 --- h

Re: [Qemu-devel] [PATCH 1/3] xics/spapr: Prevent RTAS/hypercalls emulation to be used by in-kernel XICS

2019-06-13 Thread Greg Kurz
On Fri, 14 Jun 2019 11:34:59 +1000 David Gibson wrote: > On Thu, Jun 13, 2019 at 06:44:54PM +0200, Greg Kurz wrote: > > The XICS-related RTAS calls and hypercalls in QEMU are supposed to be > > called only when the KVM in-kernel XICS is in use. > > I've applied this,

Re: [Qemu-devel] [PATCH] MAINTAINERS: Change maintership of Xen code under hw/9pfs

2019-06-14 Thread Greg Kurz
On Wed, 5 Jun 2019 10:12:05 + Paul Durrant wrote: > > -Original Message- > > From: Greg Kurz [mailto:gr...@kaod.org] > > Sent: 05 June 2019 11:11 > > To: Anthony Perard > > Cc: qemu-devel@nongnu.org; Stefano Stabellini ; > > Paul Durrant >

[Qemu-devel] [PATCH 7/7] target/ppc/machine: Add kvmppc_pvr_workaround_required() stub

2019-06-14 Thread Greg Kurz
This allows to drop the CONFIG_KVM guard from the code. Signed-off-by: Greg Kurz --- target/ppc/kvm_ppc.h |5 + target/ppc/machine.c |2 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/target/ppc/kvm_ppc.h b/target/ppc/kvm_ppc.h index e642aaaf9226..98bd7d5da6d6

[Qemu-devel] [PATCH 1/7] spapr_pci: Drop useless CONFIG_KVM ifdefery

2019-06-14 Thread Greg Kurz
kvm_enabled() expands to (0) when CONFIG_KVM is not defined. Signed-off-by: Greg Kurz --- hw/ppc/spapr_pci.c |2 -- 1 file changed, 2 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index fbeb1c90ee6c..00d9f2cfe464 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c

[Qemu-devel] [PATCH 5/7] hw/ppc: Drop useless CONFIG_KVM ifdefery

2019-06-14 Thread Greg Kurz
kvmppc_set_interrupt() has a stub that does nothing when CONFIG_KVM is not defined. Signed-off-by: Greg Kurz --- hw/ppc/ppc.c |2 -- 1 file changed, 2 deletions(-) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index 9d91e8481b32..288196dfa67a 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c

[Qemu-devel] [PATCH 4/7] hw/ppc/prep: Drop useless CONFIG_KVM ifdefery

2019-06-14 Thread Greg Kurz
kvm_enabled() expands to (0) when CONFIG_KVM is not defined. It is likely that the compiler will optimize the code out. And even if it doesn't, we have a stub for kvmppc_get_hypercall(). Signed-off-by: Greg Kurz --- hw/ppc/prep.c |2 -- 1 file changed, 2 deletions(-) diff --git a/h

[Qemu-devel] [PATCH 0/7] ppc: Get rid of some CONFIG_KVM guards

2019-06-14 Thread Greg Kurz
well. -- Greg --- Greg Kurz (7): spapr_pci: Drop useless CONFIG_KVM ifdefery hw/ppc/mac_oldworld: Drop useless CONFIG_KVM ifdefery hw/ppc/mac_newworld: Drop useless CONFIG_KVM ifdefery hw/ppc/prep: Drop useless CONFIG_KVM ifdefery hw/ppc: Drop useless CONFIG_KVM ifd

[Qemu-devel] [PATCH 6/7] ppc: Introduce kvmppc_set_reg_tb_offset() helper

2019-06-14 Thread Greg Kurz
Introduce a KVM helper and its stub instead of guarding the code with CONFIG_KVM. Signed-off-by: Greg Kurz --- hw/ppc/ppc.c |5 + target/ppc/kvm.c |9 + target/ppc/kvm_ppc.h |5 + 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/hw/ppc

[Qemu-devel] [PATCH 2/7] hw/ppc/mac_oldworld: Drop useless CONFIG_KVM ifdefery

2019-06-14 Thread Greg Kurz
kvm_enabled() expands to (0) when CONFIG_KVM is not defined. It is likely that the compiler will optimize the code out. And even if it doesn't, we have a stub for kvmppc_get_hypercall(). Signed-off-by: Greg Kurz --- hw/ppc/mac_oldworld.c |2 -- 1 file changed, 2 deletions(-) diff --

[Qemu-devel] [PATCH 3/7] hw/ppc/mac_newworld: Drop useless CONFIG_KVM ifdefery

2019-06-14 Thread Greg Kurz
kvm_enabled() expands to (0) when CONFIG_KVM is not defined. The first CONFIG_KVM guard is thus useless and it is likely that the compiler will optimize the code out in the case of the second guard. And even if it doesn't, we have a stub for kvmppc_get_hypercall(). Signed-off-by: Greg

Re: [Qemu-devel] [PATCH v3 1/5] virtio: add "use-started" property

2019-06-14 Thread Greg Kurz
true by default and > set to false when machine type <= 4.0.1. > > Suggested-by: Greg Kurz > Signed-off-by: Xie Yongji > --- > hw/block/vhost-user-blk.c | 4 ++-- > hw/core/machine.c | 8 ++-- This patch conflicts with latest upstream changes to hw_compat

[Qemu-devel] [PATCH] hw: Nuke hw_compat_4_0_1 and pc_compat_4_0_1

2019-06-14 Thread Greg Kurz
Move the compat props that were added to the 4.0.1 since c87759ce876a to 4.0. Even if only hw_compat_4_0_1 had an impact on other architectures, drop pc_compat_4_0_1 as well for consistency. Fixes: c87759ce876a "q35: Revert to kernel irqchip" Suggested-by: Dr. David Alan Gilbert Sign

Re: [Qemu-devel] [PATCH] MAINTAINERS: Change maintership of Xen code under hw/9pfs

2019-06-14 Thread Greg Kurz
On Fri, 14 Jun 2019 08:44:26 -0700 (PDT) Stefano Stabellini wrote: > On Fri, 14 Jun 2019, Paul Durrant wrote: > > > -Original Message- > > > From: Greg Kurz [mailto:gr...@kaod.org] > > > Sent: 14 June 2019 09:16 > > > To: Paul Durrant > >

Re: [Qemu-devel] [PATCH 1/2] spapr/xive: rework the mapping the KVM memory regions

2019-06-14 Thread Greg Kurz
Signed-off-by: Cédric Le Goater > --- Nice ! Reviewed-by: Greg Kurz > include/hw/ppc/spapr_xive.h | 2 +- > include/hw/ppc/xive.h | 1 + > hw/intc/spapr_xive.c| 38 ++--- > hw/intc/spapr_xive_kvm.c| 21 +++-

Re: [Qemu-devel] [PATCH 2/2] spapr/xive: simplify spapr_irq_init_device() to remove the emulated init

2019-06-14 Thread Greg Kurz
On Fri, 14 Jun 2019 18:59:20 +0200 Cédric Le Goater wrote: > The init_emu() handles are now empty. Remove them and rename > spapr_irq_init_device() to spapr_irq_init_kvm(). > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > include/hw/ppc/spapr_irq.

Re: [Qemu-devel] Several questions about " [PATCH v3 0/5] virtio-9p: hotplug and migration support"

2019-03-11 Thread Greg Kurz
ly on the target if migration succeeds or on the source if migration fails. Then we get to some more gory details: files open with O_EXCL and unlinked open files... > > On 2019/2/26 17:11, Greg Kurz wrote: > > On Tue, 26 Feb 2019 11:17:16 +0800 > > wangyan wrote: > > >

Re: [Qemu-devel] [PULL 30/50] spapr: Generate FDT fragment for LMBs at configure connector time

2019-03-11 Thread Greg Kurz
Hi, Just back from vacation. On Wed, 6 Mar 2019 14:16:23 +1100 David Gibson wrote: > On Tue, Mar 05, 2019 at 04:10:20PM +, Peter Maydell wrote: > > On Tue, 26 Feb 2019 at 04:53, David Gibson > > wrote: > > > > > > From: Greg Kurz > > > &

Re: [Qemu-devel] [PULL 04/60] Revert "spapr: support memory unplug for qtest"

2019-03-11 Thread Greg Kurz
On Sun, 10 Mar 2019 19:26:07 +1100 David Gibson wrote: > From: Greg Kurz > > Commit b8165118f52c broke CPU hotplug tests for old machine types: > > $ QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 ./tests/cpu-plug-test > -m=slow > /ppc64/cpu-plug/pseries-3.1/device-ad

Re: [Qemu-devel] [PATCH] scripts/qemugdb: re-license timers.py to GPLv2 or later

2019-03-12 Thread Greg Kurz
On Mon, 11 Mar 2019 16:55:38 + Alex Bennée wrote: > I'm the sole author (aside from a one line by Greg fixing encoding) > and I was asked nicely on IRC to bring it into line with the rest of > the files. > > Cc: Greg Kurz > Signed-off-by: Alex Bennée > -

Re: [Qemu-devel] [PATCH v2 03/13] spapr/xive: activate KVM support

2019-03-12 Thread Greg Kurz
On Mon, 11 Mar 2019 21:44:22 +0100 Cédric Le Goater wrote: > On 2/26/19 12:49 AM, David Gibson wrote: > > On Fri, Feb 22, 2019 at 02:13:12PM +0100, Cédric Le Goater wrote: > >> All is in place for KVM now. State synchronization and migration will > >> come next. > > > > As with the kernel si

Re: [Qemu-devel] [PULL 04/62] Revert "spapr: support memory unplug for qtest"

2019-03-12 Thread Greg Kurz
On Tue, 12 Mar 2019 19:54:04 +1100 David Gibson wrote: > From: Greg Kurz > > Commit b8165118f52c broke CPU hotplug tests for old machine types: > > $ QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 ./tests/cpu-plug-test > -m=slow > /ppc64/cpu-plug/pseries-3.1/device-ad

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 0/2] spapr-rtas: add ibm, get-vpd RTAS interface

2019-03-12 Thread Greg Kurz
On Mon, 11 Mar 2019 19:57:07 -0300 "Maxiwell S. Garcia" wrote: > Here are two patches to add a handler for ibm,get-vpd RTAS calls. > This RTAS exposes host information in case of set QEMU options > 'host-serial' and 'host-model' as 'passthrough'. > > The patch 1 creates helper functions to get v

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 2/2] spapr-rtas: add ibm, get-vpd RTAS interface

2019-03-12 Thread Greg Kurz
On Mon, 11 Mar 2019 19:57:09 -0300 "Maxiwell S. Garcia" wrote: > This adds a handler for ibm,get-vpd RTAS calls, allowing pseries guest > to collect host information. It is disabled by default to avoid unwanted > information leakage. To enable it, use: > > ‘-M pseries,host-serial={passthrough|st

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 1/2] spapr: helper functions to get valid host fields

2019-03-12 Thread Greg Kurz
On Mon, 11 Mar 2019 19:57:08 -0300 "Maxiwell S. Garcia" wrote: > The pseries options 'host-serial' and 'host-model' accepts > 'none', 'passthrough', or content. The helper > functions in this commit return a valid host field based on > user options. > > Signed-off-by: Maxiwell S. Garcia > ---

Re: [Qemu-devel] [PATCH v2 0/7] testing/next for softfreeze

2019-03-12 Thread Greg Kurz
to gcovr.patch > patch 0007/Makefile explicitly pass BUILD_DIR to gcovr.patch > > Alex Bennée (4): > .travis.yml: combine docs and tools build with out-of-tree > .travis.yml: reduce the module builds to major architectures > Makefile: explicitly pass $(SRC_PATH) to gcovr > Ma

Re: [Qemu-devel] [Qemu-ppc] [PATCH v6 0/6] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-03-12 Thread Greg Kurz
On Tue, 12 Mar 2019 15:32:51 +0530 Aravinda Prasad wrote: > This patch set adds support for FWNMI in PowerKVM guests. > > System errors such as SLB multihit and memory errors > that cannot be corrected by hardware is passed on to > the kernel for handling by raising machine check > exception (an

Re: [Qemu-devel] [PATCH] spapr: Correctly set LPCR[GTSE] in H_REGISTER_PROCESS_TABLE

2019-03-13 Thread Greg Kurz
ly on LPCR[GTSE] (i.e. basically all of them) to crash during early > boot when their first tlbie instruction causes an unexpected trap. > > Fixes: 176dccee target/ppc/spapr: Clear partition table entry when allocating > hash table > Signed-off-by: David Gibson > --- Reviewed-

Re: [Qemu-devel] [Qemu-ppc] [PATCH] MAINTAINERS: PPC: add a PowerNV machine entry

2019-03-13 Thread Greg Kurz
pc-bios/slof.bin > -F: pc-bios/skiboot.lid > F: docs/specs/ppc-spapr-hcalls.txt > F: docs/specs/ppc-spapr-hotplug.txt > F: tests/spapr* > @@ -1067,6 +1066,17 @@ F: tests/libqos/*spapr* > F: tests/rtas* > F: tests/libqos/rtas* > > +PowerNV ( Did you mean :-( ? ;

[Qemu-devel] [PATCH 2/2] ppc/pnv: Fix variable size in pnv_psi_power9_irq_set()

2019-03-13 Thread Greg Kurz
PSI registers are 64-bit. Spotted by Coverity: CID 1399704 Signed-off-by: Greg Kurz --- hw/ppc/pnv_psi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/pnv_psi.c b/hw/ppc/pnv_psi.c index 5a923e41518d..5345c8389e57 100644 --- a/hw/ppc/pnv_psi.c +++ b/hw/ppc

[Qemu-devel] [PATCH 1/2] ppc/pnv: Use local_err variable in pnv_chip_power9_intc_create()

2019-03-13 Thread Greg Kurz
Detected by Coverity: CID 1399702 Signed-off-by: Greg Kurz --- hw/ppc/pnv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 8be4d4cbf785..dfb4ea5742c1 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -755,7 +755,7 @@ static void

Re: [Qemu-devel] [PATCH] ppc/xics/spapr: Fix H_IPOLL implementation

2019-03-13 Thread Greg Kurz
Goater > --- Reviewed-by: Greg Kurz > hw/intc/xics_spapr.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/hw/intc/xics_spapr.c b/hw/intc/xics_spapr.c > index 607e1c167ba2..9d2b8adef7c5 100644 > --- a/hw/intc/xics_spapr.c > +++

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 1/2] spapr: helper functions to get valid host fields

2019-03-14 Thread Greg Kurz
On Wed, 13 Mar 2019 18:16:18 -0300 "Maxiwell S. Garcia" wrote: > On Tue, Mar 12, 2019 at 11:52:24AM +0100, Greg Kurz wrote: > > Hi Greg, > Hi Maxiwell, > > On Mon, 11 Mar 2019 19:57:08 -0300 > > "Maxiwell S. Garcia" wrote: > > >

Re: [Qemu-devel] [PATCH v6 1/2] spapr: helper functions to get valid host fields

2019-03-14 Thread Greg Kurz
d on > user options. > > Signed-off-by: Maxiwell S. Garcia > --- Reviewed-by: Greg Kurz > hw/ppc/spapr.c | 48 +++--- > include/hw/ppc/spapr.h | 4 > 2 files changed, 30 insertions(+), 22 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v6 2/2] spapr-rtas: add ibm, get-vpd RTAS interface

2019-03-14 Thread Greg Kurz
On Thu, 14 Mar 2019 13:29:49 -0300 "Maxiwell S. Garcia" wrote: > This adds a handler for ibm,get-vpd RTAS calls, allowing pseries guest > to collect host information. It is disabled by default to avoid unwanted > information leakage. To enable it, use: > > -M pseries,host-serial={passthrough|str

Re: [Qemu-devel] [PATCH v7 0/3] 9p: Fix file ID collisions

2019-10-15 Thread Greg Kurz
On Tue, 08 Oct 2019 14:05:28 +0200 Christian Schoenebeck wrote: > > I wonder though whether virtio-fs suffers from the same file ID collisions > problem when sharing multiple file systems. > I gave a try and it seems that virtio-fs might expose the inode numbers from different devices in the

Re: [PATCH v9 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-15 Thread Greg Kurz
On Tue, 15 Oct 2019 13:23:44 +0200 Sergio Lopez wrote: > Document the new microvm machine type. > > Signed-off-by: Sergio Lopez > Reviewed-by: Michael S. Tsirkin > --- > docs/microvm.rst | 98 > 1 file changed, 98 insertions(+) > create mode 1

Re: virtio-fs: Fix file ID collisions (was: 9p: Fix file ID collisions)

2019-10-16 Thread Greg Kurz
On Wed, 16 Oct 2019 11:42:52 +0200 Christian Schoenebeck wrote: > On Dienstag, 15. Oktober 2019 11:20:39 CEST Greg Kurz wrote: > > On Tue, 08 Oct 2019 14:05:28 +0200 > > > > Christian Schoenebeck wrote: > > > I wonder though whether virtio-fs suffers fr

Re: [PATCH v4 00/19] spapr: IRQ subsystem cleanup

2019-10-16 Thread Greg Kurz
> spapr, xics, xive: Move SpaprIrq::post_load hook to backends > spapr: Remove SpaprIrq::nr_msis > spapr: Move SpaprIrq::nr_xirqs to SpaprMachineClass > spapr: Remove last pieces of SpaprIrq > spapr: Handle irq backend changes with VFIO PCI devices > spapr: Work around

Re: [RFC 5/5] spapr: Work around spurious warnings from vfio INTx initialization

2019-10-17 Thread Greg Kurz
On Thu, 17 Oct 2019 10:43:11 +0200 Cédric Le Goater wrote: > On 17/10/2019 07:42, David Gibson wrote: > > Traditional PCI INTx for vfio devices can only perform well if using > > an in-kernel irqchip. Therefore, vfio_intx_update() issues a warning > > if an in kernel irqchip is not available. >

Re: [PATCH 1/2] spapr: Introduce a interrupt presenter reset handler

2019-10-18 Thread Greg Kurz
On Thu, 17 Oct 2019 16:42:40 +0200 Cédric Le Goater wrote: > The interrupt presenters are not reseted today. Extend the sPAPR IRQ > backend with a new cpu_intc_reset() handler which will be called by > the CPU reset handler. > > spapr_realize_vcpu() is modified to call the CPU reset only after t

Re: [PATCH 2/2] spapr/xive: Set the OS CAM line at reset

2019-10-18 Thread Greg Kurz
On Thu, 17 Oct 2019 16:42:41 +0200 Cédric Le Goater wrote: > When a Virtual Processor is scheduled to run on a HW thread, the > hypervisor pushes its identifier in the OS CAM line. When running in > TCG or kernel_irqchip=off, QEMU needs to emulate the same behavior. > This is only related to ke

Re: [PATCH 1/2] spapr: Introduce a interrupt presenter reset handler

2019-10-18 Thread Greg Kurz
On Fri, 18 Oct 2019 13:47:07 +1100 David Gibson wrote: > On Thu, Oct 17, 2019 at 04:42:40PM +0200, Cédric Le Goater wrote: > > The interrupt presenters are not reseted today. > > I don't think that's accurate. We register reset handlers for both > ICP and TCTX already. We might not be resettin

Re: [PATCH v2 1/2] spapr: Introduce a interrupt presenter reset handler

2019-10-18 Thread Greg Kurz
On Fri, 18 Oct 2019 19:22:18 +0200 Cédric Le Goater wrote: > The interrupt presenters are created by a machine handler at the core > level and are reseted independently. This is not consistent and it > raises some issues when it comes to handle hot-plugged CPUs. These are > reseted from the reali

Re: [PATCH v2 2/2] spapr/xive: Set the OS CAM line at reset

2019-10-18 Thread Greg Kurz
-2-3 to crash QEMU with the ones in xics_spapr_print_info() and spapr_xive_print_info(). I'll post fixes soon. > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > include/hw/ppc/spapr_xive.h | 1 - > hw/intc/spapr_xive.c| 18 +++--- > 2 files chan

Re: [PATCH v3 1/4] spapr: move CPU reset after presenter creation

2019-10-22 Thread Greg Kurz
On Tue, 22 Oct 2019 09:22:43 +0200 Cédric Le Goater wrote: > spapr_realize_vcpu() is modified to call the CPU reset only after the > the intc presenter has been created. > Maybe indicate why this change is needed ? Anyway, Reviewed-by: Greg Kurz > Signed-off-by: Cédr

Re: [PATCH v3 3/4] ppc: reset the interrupt presenter from the CPU reset handler

2019-10-22 Thread Greg Kurz
p. > > Extend the sPAPR IRQ backend and the PowerNV Chip class with a new > cpu_intc_reset() handler called by the CPU reset handler and remove > the XiveTCTX reset handler which is now redundant. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > inc

Re: [PATCH v3 4/4] spapr/xive: Set the OS CAM line at reset

2019-10-22 Thread Greg Kurz
e are some other users in XICS and XIVE that do cause QEMU to crash. I shall send fixes as soon as this series reaches ppc-for-4.2. > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > include/hw/ppc/spapr_xive.h | 1 - > hw/intc/spapr_xive.c| 48 +-

Re: [PATCH v4 3/7] ppc/pnv: Introduce a PnvCore reset handler

2019-10-22 Thread Greg Kurz
On Tue, 22 Oct 2019 15:46:28 +0200 Cédric Le Goater wrote: > in which individual CPUs are reset. It will ease the introduction of > future change reseting the interrupt presenter from the CPU reset > handler. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Gre

Re: [PATCH v4 4/7] ppc/pnv: Add a PnvChip pointer to PnvCore

2019-10-22 Thread Greg Kurz
On Tue, 22 Oct 2019 15:46:29 +0200 Cédric Le Goater wrote: > We will use it to reset the interrupt presenter from the CPU reset > handler. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > include/hw/ppc/pnv_core.h | 3 +++ > hw/ppc/pnv_core.c

Re: [PATCH v4 6/7] ppc/pnv: Fix naming of routines realizing the CPUs

2019-10-22 Thread Greg Kurz
On Tue, 22 Oct 2019 15:46:31 +0200 Cédric Le Goater wrote: > The 'vcpu' suffix is inherited from the sPAPR machine. Use better > names for PowerNV. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > hw/ppc/pnv_core.c | 8 > 1 f

Re: [PATCH v4 5/7] ppc: Reset the interrupt presenter from the CPU reset handler

2019-10-22 Thread Greg Kurz
gt; > Extend the sPAPR IRQ backend and the PowerNV Chip class with a new > cpu_intc_reset() handler called by the CPU reset handler and remove > the XiveTCTX reset handler which is now redundant. > > Reviewed-by: Greg Kurz > Signed-off-by: Cédric Le Goater > ---

Re: [PATCH v5 5/7] ppc: Reset the interrupt presenter from the CPU reset handler

2019-10-22 Thread Greg Kurz
gt; > Extend the sPAPR IRQ backend and the PowerNV Chip class with a new > cpu_intc_reset() handler called by the CPU reset handler and remove > the XiveTCTX reset handler which is now redundant. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > inc

[PATCH 0/6] ppc: Reparent the interrupt presenter

2019-10-23 Thread Greg Kurz
s: [v5,0/7] ppc: reset the interrupt presenter from the CPU reset handler https://patchwork.ozlabs.org/cover/1181522/ -- Greg --- Greg Kurz (6): ppc: Add intc_destroy() handlers to SpaprInterruptController/PnvChip xive, xics: Fix reference counting on CPU objects

[PATCH 1/6] ppc: Add intc_destroy() handlers to SpaprInterruptController/PnvChip

2019-10-23 Thread Greg Kurz
ded in the machine code. Fix this by adding an intc_destroy() method that undoes what was done in intc_create(). Signed-off-by: Greg Kurz --- hw/intc/spapr_xive.c |7 +++ hw/intc/xics.c |5 + hw/intc/xics_spapr.c |7 +++ hw/intc/xive.c

[PATCH 2/6] xive, xics: Fix reference counting on CPU objects

2019-10-23 Thread Greg Kurz
nown issue because the life cycle of the TCTX or ICP happens to be shorter than the one of the CPU or XICS fabric, but better safe than sorry. Signed-off-by: Greg Kurz --- hw/intc/xics.c |8 +++- hw/intc/xive.c |6 +- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/hw/int

[PATCH 5/6] spapr: Don't use CPU_FOREACH() in 'info pic'

2019-10-23 Thread Greg Kurz
Now that presenter objects are parented to the interrupt controller, stop relying on CPU_FOREACH() which can race with CPU hotplug and crash QEMU. Signed-off-by: Greg Kurz --- hw/intc/spapr_xive.c |8 +--- hw/intc/xics.c| 12 hw/intc/xics_spapr.c |8

[PATCH 3/6] ppc: Reparent presenter objects to the interrupt controller object

2019-10-23 Thread Greg Kurz
ter to ensure its pointer remains valid until unrealize time. This will allow to get rid of CPU_FOREACH() and ease further improvements to the XIVE model. This change doesn't impact section ids and is thus transparent to migration. Signed-off-by: Greg Kurz --- hw/intc/spapr_xive.c

[PATCH 4/6] qom: Add object_child_foreach_type() helper function

2019-10-23 Thread Greg Kurz
Calling a function for children of a certain type is a recurring pattern in the QEMU code base. In order to avoid the need to setup the same boiler plate again and again, introduce a variant of object_child_foreach() that only considers children of the given type. Signed-off-by: Greg Kurz

<    4   5   6   7   8   9   10   11   12   13   >