Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Greg Kurz
On Thu, 27 Aug 2015 15:30:55 +0300 "Michael S. Tsirkin" wrote: > On Thu, Aug 27, 2015 at 01:27:54PM +0100, Peter Maydell wrote: > > On 27 August 2015 at 13:25, Michael S. Tsirkin wrote: > > > On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote: > > >> On 27 August 2015 at 13:17, Michae

Re: [Qemu-devel] [PATCH V2 5/8] memory: don't try to adjust endianness for zero length eventfd

2015-09-02 Thread Greg Kurz
pc. > > Cc: Greg Kurz > Cc: Peter Maydell > Cc: Paolo Bonzini > Signed-off-by: Jason Wang > --- Indeed, this patch prevents the crash to occur on ppc64. Acked-by: Greg Kurz > memory.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH] virtio: right size for virtio_queue_get_avail_size

2015-09-02 Thread Greg Kurz
On Wed, 2 Sep 2015 17:50:55 +0200 Cornelia Huck wrote: > On Wed, 2 Sep 2015 17:23:49 +0200 > Pierre Morel wrote: > > > Being working on dataplane I notice something strange: > > > > virtio_queue_get_avail_size() used a 64bit size index > > for the calculation of the available ring size. > >

Re: [Qemu-devel] [PATCH 5/5] virtio-net: unbreak any layout

2015-07-13 Thread Greg Kurz
On Mon, 13 Jul 2015 11:22:09 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 13, 2015 at 10:24:59AM +0300, Michael S. Tsirkin wrote: > > On Mon, Jul 13, 2015 at 01:46:51PM +0800, Jason Wang wrote: > > > Commit 032a74a1c0fcdd5fd1c69e56126b4c857ee36611 > > > ("virtio-net: byteswap virtio-net header"

Re: [Qemu-devel] [PATCH v3 04/25] tcg-ppc64: Relax register restrictions in tcg_out_mem_long

2014-06-26 Thread Greg Kurz
On Fri, 20 Jun 2014 07:13:20 -0700 Richard Henderson wrote: > In order to be able to use tcg_out_ld/st sensibly with scratch > registers, assert only when we'd incorrectly clobber a scratch. > > Signed-off-by: Richard Henderson > --- Hi, While testing various guest/host combinations for virtio

Re: [Qemu-devel] [PATCH] tcg/ppc: Fix failure in tcg_out_mem_long

2014-06-27 Thread Greg Kurz
On Thu, 26 Jun 2014 21:26:00 -0700 Richard Henderson wrote: > With rt != r0 on loads, we use rt for scratch. If we need an index > register different from base, we can't use rt, but r0 is usable. > > Signed-off-by: Richard Henderson > --- > This ought to fix the problem that Greg reported. >

Re: [Qemu-devel] [PATCH] target-ppc: KVMPPC_H_CAS fix cpu-version endianess

2014-06-27 Thread Greg Kurz
> If needed, the value is now converted. > > Fixes: 6d9412ea8132 ("target-ppc: Implement "compat" CPU option") > Signed-off-by: Laurent Dufour > --- Reviewed-by: Greg Kurz > hw/ppc/spapr.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >

Re: [Qemu-devel] [PATCH v9 00/22] legacy virtio support for cross-endian targets

2014-06-29 Thread Greg Kurz
On Sun, 29 Jun 2014 18:13:53 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jun 24, 2014 at 07:06:58PM +0200, Greg Kurz wrote: > > The current legacy virtio devices have a fundamental flaw: they all share > > data between host and guest with guest endianness ordering. This

[Qemu-devel] [PATCH] virtio-scsi: virtio_scsi_push_event() lacks VirtIOSCSIReq parsing

2014-06-30 Thread Greg Kurz
ll to virtio_scsi_parse_req(). It also drops the in size sanity check since it is already done by virtio_scsi_parse_req(). This is enough to have hotplug working again. Signed-off-by: Greg Kurz --- I guess the following check could also be handled by virtio_scsi_parse_req() as it does not allow both in and o

[Qemu-devel] [PATCH] virtio-scsi: scsi events must be converted to target endianness

2014-06-30 Thread Greg Kurz
100 This issue got uncovered while testing disk hotplug with a PowerKVM ppc64le guest. I have checked that this issue also affects a x86_64 guest run on a ppc64 host. Signed-off-by: Cédric Le Goater [ Ported from PowerKVM, Greg Kurz ] Signed-off-by: Greg Kurz --- hw/scsi/virtio-scsi.c

[Qemu-devel] [PATCH v2] virtio-scsi: virtio_scsi_push_event() lacks VirtIOSCSIReq parsing

2014-06-30 Thread Greg Kurz
ll to virtio_scsi_parse_req(). It also drops some sanity checks that are already performed by virtio_scsi_parse_req(). Signed-off-by: Greg Kurz --- Changes in v2: - dropped now useless req->elem.out_num sanity check hw/scsi/virtio-scsi.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(

[Qemu-devel] [PATCH] spapr_iommu: fix erroneous sanity check in h_put_tce_indirect()

2015-06-15 Thread Greg Kurz
the other reserved bits should error out with H_PARAMETER. This patch simply drops the offending check. Signed-off-by: Greg Kurz --- hw/ppc/spapr_iommu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index 8cd9dba9

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr_iommu: fix erroneous sanity check in h_put_tce_indirect()

2015-06-16 Thread Greg Kurz
On Tue, 16 Jun 2015 18:53:51 +1000 Alexey Kardashevskiy wrote: > On 06/16/2015 03:28 AM, Greg Kurz wrote: > > According to PAPR+ 3.2.2.2, the TCE is implemented as follows: > > bits 0-51: real page number > > bits 52-61: reserved for future use > > bits 6

[Qemu-devel] [PATCH] spapr_iommu: drop erroneous check in h_put_tce_indirect() and useless enum

2015-06-16 Thread Greg Kurz
as well. This patch doesn't fix any bug, it is only code cleanup. Signed-off-by: Greg Kurz --- hw/ppc/spapr_iommu.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index 8cd9dba9ac4d..2ae8684ca5bc 100644 --- a/hw/ppc

Re: [Qemu-devel] [PATCH] spapr_iommu: drop erroneous check in h_put_tce_indirect() and useless enum

2015-06-16 Thread Greg Kurz
On Tue, 16 Jun 2015 12:09:33 +0200 Greg Kurz wrote: > The tce_list variable is not a TCE but the address to a TCE: we shouldn't > clear permission bits as we do now. And this is dead code anyway since we > check tce_list is 4K aligned a few lines above. > > While we'r

[Qemu-devel] [PATCH v2 0/2] spapr_iommu: TCE permission bits fixes

2015-06-16 Thread Greg Kurz
This series fixes some minor nits in the sPAPR IOMMU code. It supercedes my previous post: "spapr_iommu: drop erroneous check in h_put_tce_indirect() and useless enum" --- Greg Kurz (2): spapr_iommu: drop erroneous check in h_put_tce_indirect() spapr_iommu: translate sPAP

[Qemu-devel] [PATCH v2 2/2] spapr_iommu: translate sPAPRTCEAccess to IOMMUAccessFlags

2015-06-16 Thread Greg Kurz
The fact that these enums have matching values is pure coincidence. We actually need to translate from the PAPR definition to the QEMU one. This patch doesn't fix any bug, it is only code cleanup. Suggested-by: Alexey Kardashevskiy Signed-off-by: Greg Kurz --- hw/ppc/spapr_iommu.c |

[Qemu-devel] [PATCH v2 1/2] spapr_iommu: drop erroneous check in h_put_tce_indirect()

2015-06-16 Thread Greg Kurz
iy Signed-off-by: Greg Kurz --- hw/ppc/spapr_iommu.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index 8cd9dba9ac4d..ddd0ea5cd4dd 100644 --- a/hw/ppc/spapr_iommu.c +++ b/hw/ppc/spapr_iommu.c @@ -267,9 +267,7 @@ static ta

Re: [Qemu-devel] [PATCH v2 1/2] spapr_iommu: drop erroneous check in h_put_tce_indirect()

2015-06-16 Thread Greg Kurz
On Tue, 16 Jun 2015 18:26:47 +0200 Greg Kurz wrote: > The tce_list variable is not a TCE but the address to a TCE: we shouldn't > clear permission bits as we do now. And this is dead code anyway since we > check tce_list is 4K aligned a few lines above. > > This patch doesn&

[Qemu-devel] [PATCH 0/6] vhost: cross-endian support

2015-06-17 Thread Greg Kurz
el.org/pub/scm/linux/kernel/git/mst/vhost.git Please review. --- Cédric Le Goater (1): vhost_net: re-enable when cross endian Greg Kurz (5): linux-headers: sync vhost.h virtio: introduce virtio_legacy_is_cross_endian() vhost: set vring endianness for legacy virtio

[Qemu-devel] [PATCH 3/6] vhost: set vring endianness for legacy virtio

2015-06-17 Thread Greg Kurz
Legacy virtio is native endian: if the guest and host endianness differ, we have to tell vhost so it can swap bytes where appropriate. This is done through a vhost ring ioctl. Signed-off-by: Greg Kurz --- hw/virtio/vhost.c | 50 +- 1 file

[Qemu-devel] [PATCH 2/6] virtio: introduce virtio_legacy_is_cross_endian()

2015-06-17 Thread Greg Kurz
This helper will be used by vhost and tap to detect cross-endianness in the legacy virtio case. Signed-off-by: Greg Kurz --- include/hw/virtio/virtio-access.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio

[Qemu-devel] [PATCH 4/6] tap: add VNET_LE/VNET_BE operations

2015-06-17 Thread Greg Kurz
The linux tap and macvtap backends can be told to parse vnet headers according to little or big endian. This is done through the TUNSETVNETLE and TUNSETVNETBE ioctls. This patch brings all the plumbing for QEMU to use these APIs. Signed-off-by: Greg Kurz --- include/net/net.h |6

[Qemu-devel] [PATCH 5/6] vhost-net: tell tap backend about the vnet endianness

2015-06-17 Thread Greg Kurz
The default behaviour for TAP/MACVTAP is to consider vnet as native endian. This patch handles the cases when this is not true: - virtio 1.0: always little-endian - legacy cross-endian Signed-off-by: Greg Kurz --- hw/net/vhost_net.c | 33 - 1 file changed, 32

[Qemu-devel] [PATCH 6/6] vhost_net: re-enable when cross endian

2015-06-17 Thread Greg Kurz
From: Cédric Le Goater Cross-endianness is now checked by the core vhost code. revert 371df9f5e0f1 "vhost-net: disable when cross-endian" Signed-off-by: Cédric Le Goater [ added commit message, Greg Kurz ] Signed-off-by: Greg Kurz --- hw/net/vhost_net.c | 19 -

[Qemu-devel] [PATCH 1/6] linux-headers: sync vhost.h

2015-06-17 Thread Greg Kurz
This patch brings the cross-endian vhost API to QEMU. Signed-off-by: Greg Kurz --- linux-headers/linux/vhost.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/linux-headers/linux/vhost.h b/linux-headers/linux/vhost.h index c656f61cfc75..ead86db91a08 100644 --- a/linux

Re: [Qemu-devel] [PATCH] tap: fix non-linux build

2015-06-19 Thread Greg Kurz
t/tap-win32.c > index f6fc961..625d53c 100644 > --- a/net/tap-win32.c > +++ b/net/tap-win32.c > @@ -688,6 +688,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len) > { > } > > +int tap_fd_set_vnet_le(int fd, int is_le) > +{ > +return -EINVAL; > +} > + > +int tap_fd_set_vnet_be(int fd, int is_be) > +{ > +return -EINVAL; > +} > + > static void tap_using_vnet_hdr(NetClientState *nc, bool using_vnet_hdr) > { > } I couldn't setup a build environment on a non-linux platform (tried AIX but I miss to many packages), so I won't give a Tested-by... patch is trivial though so: Reviewed-by: Greg Kurz

Re: [Qemu-devel] [PATCH 5/6] vhost-net: tell tap backend about the vnet endianness

2015-06-19 Thread Greg Kurz
On Fri, 19 Jun 2015 11:16:35 +0200 Thomas Huth wrote: > > Hi, > > On Wed, 17 Jun 2015 15:23:49 +0200 > Greg Kurz wrote: > > > The default behaviour for TAP/MACVTAP is to consider vnet as native endian. > > > > This patch handles the cases when this i

[Qemu-devel] [PATCH] vhost_net: fix misuse of assert()

2015-06-19 Thread Greg Kurz
In case NDEBUG is defined, assert() expands to nothing and vhost_net_set_vnet_endian() doesn't get called... Suggested-by: Thomas Huth Signed-off-by: Greg Kurz --- hw/net/vhost_net.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Michael, Yet another fix for the cross-e

[Qemu-devel] [PATCH v2] vhost_net: fix misuse of assert()

2015-06-19 Thread Greg Kurz
meaning in assert(). This is a readability enhancement. The patch does not fix any bug. Suggested-by: Thomas Huth Signed-off-by: Greg Kurz --- hw/net/vhost_net.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) v2: rewrote commit log diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c

Re: [Qemu-devel] [PATCH] vhost_net: fix misuse of assert()

2015-06-19 Thread Greg Kurz
r wrote: > > >> "Michael S. Tsirkin" writes: > > >> > > >> > On Fri, Jun 19, 2015 at 11:13:40AM +0100, Peter Maydell wrote: > > >> >> On 19 June 2015 at 11:07, Michael S. Tsirkin wrote: > > >> >> >

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: fix sync of SPR_SDR1 with KVM

2016-03-03 Thread Greg Kurz
On Thu, 3 Mar 2016 15:35:07 +1100 David Gibson wrote: > On Wed, Mar 02, 2016 at 11:06:19AM +1100, David Gibson wrote: > > On Tue, Mar 01, 2016 at 07:03:10PM +0100, Greg Kurz wrote: > > > The gdbstub can't access guest memory with current master. This is what >

Re: [Qemu-devel] [PATCHv2 2/3] target-ppc: Add helpers for updating a CPU's SDR1 and external HPT

2016-03-07 Thread Greg Kurz
matters, but there are going to be in future. > > Signed-off-by: David Gibson > --- Reviewed-by: Greg Kurz > hw/ppc/spapr.c | 13 ++--- > target-ppc/kvm.c| 2 +- > target-ppc/kvm_ppc.h| 6 ++ > target-ppc/mmu-hash64.c | 43

Re: [Qemu-devel] [PATCHv2 3/3] target-ppc: Eliminate kvmppc_kern_htab global

2016-03-07 Thread Greg Kurz
assumption is that it must > be a KVM managed HPT). > > This also has some flow-on changes to the HPT access helpers, required by > the above changes. > > Reported-by: Greg Kurz > Signed-off-by: David Gibson > Reviewed-by: Thomas Huth > --- Typo in comment in target-p

Re: [Qemu-devel] [PATCHv2 1/3] target-ppc: Split out SREGS get/put functions

2016-03-08 Thread Greg Kurz
e is expected. > > > > Signed-off-by: David Gibson > > Greg, or Alexey, can I can an R-b for this one as well? > Reviewed-by: Greg Kurz > > --- > > target-ppc/kvm.c | 421 > > ++- > > 1 file

Re: [Qemu-devel] [PATCH] add CephFS support in VirtFS

2016-03-09 Thread Greg Kurz
On Wed, 9 Mar 2016 11:10:39 +0800 Gerard Braad wrote: > Hi All, > > > It has been a while since anyone responded to this thread, and I am > quite interested in this functionality. > What can be done this get this merged? > Hi, I'll try to spend some time on it. Cheers. -- Greg > For the de

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-09 Thread Greg Kurz
On Tue, 8 Mar 2016 08:51:23 +0800 Jevon Qiao wrote: > Any further comment on this patch? > First comment is: $ git show | ./scripts/checkpatch.pl - | grep ^total total: 44 errors, 7 warnings, 975 lines checked I'm now reading the patch and will come back with other comments. > Thanks, > Jevo

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-09 Thread Greg Kurz
On Wed, 2 Mar 2016 23:41:43 +0800 Jevon Qiao wrote: > Ceph as a promising unified distributed storage system is widely used in the > world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and > object (S3/Swift) are unsurprisingly looking at Manila and CephFS to round out > a unif

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-10 Thread Greg Kurz
On Wed, 9 Mar 2016 13:09:58 -0700 Eric Blake wrote: > On 03/09/2016 12:02 PM, Greg Kurz wrote: > > On Wed, 2 Mar 2016 23:41:43 +0800 > > Jevon Qiao wrote: > > > > >> +} > >> + > >> +static int cephfs_readdir_r(FsContext *ctx, V9fsFidOpen

[Qemu-devel] [PATCH] spapr_rng: fix race with main loop

2016-03-11 Thread Greg Kurz
r in h_random()->qemu_sem_wait(). This could not happen before 60253ed1e6ec because entropy_available() used to call random_recv() unconditionally. This patch ensures the lock is held to avoid the race. Signed-off-by: Greg Kurz --- Thomas, This is the problem mentioned by Cedric in: https://lists.no

Re: [Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

2016-03-14 Thread Greg Kurz
On Fri, 27 Nov 2015 16:02:39 +0100 Patrik Hermansson wrote: > This patch adds the option to specify virtio queue sizes. Currently the > queue sizes is hard coded to 256, which might not be suitable for all types > of applications. This patch makes it possible to specify the queue size > between

Re: [Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

2016-03-15 Thread Greg Kurz
On Mon, 14 Mar 2016 12:27:55 +0100 Greg Kurz wrote: > On Fri, 27 Nov 2015 16:02:39 +0100 > Patrik Hermansson wrote: > > > This patch adds the option to specify virtio queue sizes. Currently the > > queue sizes is hard coded to 256, which might not be suitable for all type

Re: [Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

2016-03-15 Thread Greg Kurz
On Tue, 15 Mar 2016 06:50:38 +0200 "Michael S. Tsirkin" wrote: > On Fri, Nov 27, 2015 at 04:02:39PM +0100, Patrik Hermansson wrote: > > This patch adds the option to specify virtio queue sizes. Currently the > > queue sizes is hard coded to 256, which might not be suitable for all types > > of ap

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-15 Thread Greg Kurz
On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: > Ceph as a promising unified distributed storage system is widely used in the > world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and > object (S3/Swift) are unsurprisingly looking at Manila and CephFS to round out > a unif

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-15 Thread Greg Kurz
On Tue, 15 Mar 2016 21:39:45 +0800 Jevon Qiao wrote: > On 15/3/16 17:30, Greg Kurz wrote: > > On Tue, 15 Mar 2016 00:02:48 +0800 > > Jevon Qiao wrote: > > > >> Ceph as a promising unified distributed storage system is widely used in > >> the > >&g

Re: [Qemu-devel] Virtio-9p

2016-03-30 Thread Greg Kurz
On Wed, 30 Mar 2016 14:10:38 +0200 Pradeep Kiruvale wrote: > Hi All, > > Is virtio-9p-pci device only supports the fsdev deices? I am trying to use > -drive option for applying QoS for block device using Virtio-9p-pci device, > but failing to create/add a device other than fsdev. Can you please

Re: [Qemu-devel] [PATCH v2] spapr: compute interrupt vector address from LPCR

2016-03-30 Thread Greg Kurz
; Signed-off-by: Cédric Le Goater > --- > Reviewed-by: Greg Kurz > Changes since v1: > > - moved helper routine under target-ppc/ > - moved the restore of excp_prefix under cpu_post_load() > > hw/ppc/spapr_hcall.c| 13 ++--- > include/hw/ppc/spa

Re: [Qemu-devel] [PATCH v2] spapr: compute interrupt vector address from LPCR

2016-03-30 Thread Greg Kurz
On Wed, 30 Mar 2016 17:38:34 +0200 Cédric Le Goater wrote: > This address is changed by the linux kernel using the H_SET_MODE hcall > and needs to be restored when migrating a spapr VM running in > TCG. This can be done using the AIL bits from the LPCR register. > > The patch introduces a helper

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: compute interrupt vector address from LPCR

2016-03-30 Thread Greg Kurz
On Wed, 30 Mar 2016 19:01:31 +0200 Greg Kurz wrote: > On Wed, 30 Mar 2016 17:38:34 +0200 > Cédric Le Goater wrote: > > > This address is changed by the linux kernel using the H_SET_MODE hcall > > and needs to be restored when migrating a spapr VM running in > > TCG.

Re: [Qemu-devel] Virtio-9p

2016-03-31 Thread Greg Kurz
using the Virtio-9p-pci. > What file ? > Basically I want to have QoS for virtio-9p-pci. > Can you provide a more detailed scenario on the result you want to reach ? > Regards, > Pradeep > Cheers. -- Greg > On 30 March 2016 at 16:13, Greg Kurz wrote: > > > On Wed, 30

Re: [Qemu-devel] Virtio-9p

2016-04-01 Thread Greg Kurz
ry foot print of the guests. > If you're using KVM and your guests run the same distro or application, you may try to use KSM (Kernel Same-page Merging) in the host. > Regards, > Pradeep > > On 31 March 2016 at 18:12, Greg Kurz wrote: > > > On Wed, 30 Mar 2016 16:27:48

Re: [Qemu-devel] [PATCH] checkpatch: add target_ulong to typelist

2016-04-01 Thread Greg Kurz
> [1] http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg06741.html > > Signed-off-by: Cédric Le Goater > --- Indeed, with this patch, the checkpatch script stops complaining when it sees: +if (prefix == (target_ulong) -1ULL) { And I tend to agree with Cedric... unles

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-05 Thread Greg Kurz
> > On 15/3/16 21:46, Greg Kurz wrote: > >> On Tue, 15 Mar 2016 21:39:45 +0800 > >> Jevon Qiao wrote: > >> > >>> On 15/3/16 17:30, Greg Kurz wrote: > >>>> On Tue, 15 Mar 2016 00:02:48 +0800 > >>>> Jevon Qiao wrote:

Re: [Qemu-devel] [PATCH 0/2] busy polling support for vhost-kernel

2016-04-05 Thread Greg Kurz
On Mon, 21 Mar 2016 13:25:53 +0800 Jason Wang wrote: > Hi: > > This series enable vhost-kernel busy polling support. It's done > through introducing a new property for tap backend - 'vhost_poll_us' > which is the maximum number of us could be spent for busy polling. > > Please reivew. > Hi Jas

Re: [Qemu-devel] [PATCH 0/2] busy polling support for vhost-kernel

2016-04-06 Thread Greg Kurz
On Wed, 6 Apr 2016 09:49:34 +0800 Jason Wang wrote: > On 04/05/2016 11:54 PM, Greg Kurz wrote: > > On Mon, 21 Mar 2016 13:25:53 +0800 > > Jason Wang wrote: > >> > Hi: > >> > > >> > This series enable vhost-kernel busy polling support. It&#

Re: [Qemu-devel] [PATCH V2] tap: vhost busy polling support

2016-04-06 Thread Greg Kurz
On Wed, 6 Apr 2016 09:05:21 -0600 Eric Blake wrote: > On 04/06/2016 03:15 AM, Jason Wang wrote: > > This patch add the capability of basic vhost net busy polling which is > > supported by recent kernel. User could configure the maximum number of > > us that could be spent on busy polling through

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-07 Thread Greg Kurz
On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: > Ceph as a promising unified distributed storage system is widely used in the > world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and > object (S3/Swift) are unsurprisingly looking at Manila and CephFS to round out > a unif

Re: [Qemu-devel] [PATCH V3] tap: vhost busy polling support

2016-04-07 Thread Greg Kurz
uot;vhost-poll-us". > > Signed-off-by: Jason Wang > --- Thanks for this feature Jason ! Tested-by: Greg Kurz > hw/net/vhost_net.c| 2 +- > hw/scsi/vhost-scsi.c | 2 +- > hw/virtio/vhost-backend.c | 8 &

Re: [Qemu-devel] Virtio-9p and cgroup io-throttling

2016-04-08 Thread Greg Kurz
On Thu, 7 Apr 2016 11:48:27 +0200 Pradeep Kiruvale wrote: > Hi All, > > I am using virtio-9p for sharing the file between host and guest. To test > the shared file I do read/write options in the guest.To have controlled io, > I am using cgroup blkio. > > While using cgroup I am facing two issue

Re: [Qemu-devel] Virtio-9p and cgroup io-throttling

2016-04-08 Thread Greg Kurz
ent runs. > AFAIK, no. Why don't you simply start QEMU in the cgroup ? Unless I miss something, all children threads, including the 9p ones, will be in the cgroup and honor the throttle setttings. > Regards, > Pradeep > Cheers. -- Greg > > On 8 April 2016 at 10:10, Greg K

Re: [Qemu-devel] Virtio-9p and cgroup io-throttling

2016-04-08 Thread Greg Kurz
d: # echo $$ > /sys/fs/cgroup/blkio/test/tasks # qemu. This being said, QEMU is a regular userspace program that is completely cgroup agnostic. It won't behave differently than 'dd if=/dev/sdb of=/dev/null'. This really doesn't look like a QEMU related issue to me. > Regar

Re: [Qemu-devel] Implementing 9p for Windows host

2016-04-11 Thread Greg Kurz
On Thu, 7 Apr 2016 13:41:24 +0200 Michael Fritscher wrote: > Good day, > > I'm using qemu on a Windows host. One thing I stumbled over was missing > 9p support. I thought it was because of missing (x)attr, but Stefan Weil > told me that 9p is supported only under Linux hosts. > > I searched a

Re: [Qemu-devel] Implementing 9p for Windows host

2016-04-11 Thread Greg Kurz
On Mon, 11 Apr 2016 16:37:11 +0200 Michael Fritscher wrote: > Hello Greg, > > thanks for your answer! Yes, I already jumped in - I was surprised how > fast it went. I was afraid of much bigger problems ;-) I've a already a > V2 nearly ready :-) As a teaser: Fixed read/write support and the >

Re: [Qemu-devel] [PATCH v2] [WIP] [RFC ]Add initial 9pfs support for Windows hosts v2

2016-04-13 Thread Greg Kurz
On Tue, 12 Apr 2016 09:52:00 +0200 Michael Fritscher wrote: > It was tested on Windows & Linux hosts, on the later no obvious regressions > could be found. The guest was a Knoppix 7.6.0 live cd. > > This is WIP and a RFC - it isn't meant to be upstreamed yet. The error_printf > are only for de

[Qemu-devel] [PATCH for-2.7 0/2] 9p: cleanup in #include directives

2016-04-13 Thread Greg Kurz
The recent RFC patch to bring 9p support to Windows hosts unveiled some nits. These two patches are preliminary cleanup. Michael, I'd like you to carry these patches in your patchset. Please rebase your current work on top of them. Thanks. --- Greg Kurz (2): 9p: don't include

[Qemu-devel] [PATCH for-2.7 2/2] 9p: some more cleanup in #include directives

2016-04-13 Thread Greg Kurz
The "9p-attr.h" header isn't needed by 9p synth and virtio 9p. While here, also drop last references to virtio from 9p synth since it is now transport agnostic code. Signed-off-by: Greg Kurz --- hw/9pfs/9p-synth.c |4 +--- hw/9pfs/virtio-9p-device.c |1 - 2 f

[Qemu-devel] [PATCH for-2.7 1/2] 9p: don't include

2016-04-13 Thread Greg Kurz
The system header doesn't exist on all host platforms. Code should include "qemu/osdep.h" instead to avoid build breaks on plafforms that don't define CONFIG_IOVEC (like win32, if it is to support 9p one day). Signed-off-by: Greg Kurz --- fsdev/9p-iov-marshal.c |1 -

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-13 Thread Greg Kurz
Hi Jevon, On Sun, 10 Apr 2016 14:55:55 +0800 Jevon Qiao wrote: > Hi Greg, > > Thank you for spending time reviewing this patch. > On 7/4/16 23:50, Greg Kurz wrote: > > On Tue, 15 Mar 2016 00:02:48 +0800 > > Jevon Qiao wrote: > > > >> Ceph as a promisin

Re: [Qemu-devel] [PATCH v2] [WIP] [RFC ]Add initial 9pfs support for Windows hosts v2

2016-04-14 Thread Greg Kurz
Hi Michael, I have some more comments that should end up in a preliminary patch. Cheers. -- Greg On Tue, 12 Apr 2016 09:52:00 +0200 Michael Fritscher wrote: > It was tested on Windows & Linux hosts, on the later no obvious regressions > could be found. The guest was a Knoppix 7.6.0 live cd.

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-15 Thread Greg Kurz
Hi Jevon, More findings in fsdev/qemu-fsdev.c and hw/9pfs/Makefile.objs, see below. Cheers. -- Greg On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: > Ceph as a promising unified distributed storage system is widely used in the > world of OpenStack. OpenStack users deploying Ceph for blo

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-15 Thread Greg Kurz
One more nit in configure. See below. Cheers. -- Greg On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: > Ceph as a promising unified distributed storage system is widely used in the > world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and > object (S3/Swift) are unsurpri

[Qemu-devel] [PATCH] PPC/KVM: early validation of vcpu id

2016-04-26 Thread Greg Kurz
sly bogus vcpu id. Signed-off-by: Greg Kurz --- include/sysemu/kvm.h|2 ++ kvm-all.c |6 ++ target-ppc/translate_init.c |8 3 files changed, 16 insertions(+) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index 0e18f15c9493..27bf50ef3

Re: [Qemu-devel] [Qemu-discuss] iolimits for virtio-9p

2016-04-27 Thread Greg Kurz
On Wed, 27 Apr 2016 16:39:58 +0200 Pradeep Kiruvale wrote: > On 27 April 2016 at 10:38, Alberto Garcia wrote: > > > On Wed, Apr 27, 2016 at 09:29:02AM +0200, Pradeep Kiruvale wrote: > > > > > Thanks for the reply. I am still in the early phase, I will let you > > > know if any changes are neede

Re: [Qemu-devel] [Qemu-discuss] iolimits for virtio-9p

2016-05-02 Thread Greg Kurz
On Thu, 28 Apr 2016 11:45:41 +0200 Pradeep Kiruvale wrote: > On 27 April 2016 at 19:12, Greg Kurz wrote: > > > On Wed, 27 Apr 2016 16:39:58 +0200 > > Pradeep Kiruvale wrote: > > > > > On 27 April 2016 at 10:38, Alberto Garcia wrote: > > > > &

[Qemu-devel] [PATCH] 9p: drop unused declaration from coth.h

2016-05-03 Thread Greg Kurz
Commit "ebac1202c95a virtio-9p: use QEMU thread pool" dropped function v9fs_init_worker_threads. Signed-off-by: Greg Kurz --- hw/9pfs/coth.h |1 - 1 file changed, 1 deletion(-) diff --git a/hw/9pfs/coth.h b/hw/9pfs/coth.h index 209fc6a9afbc..a911cbb16589 100644 --- a/hw/9pfs/co

Re: [Qemu-devel] [Qemu-discuss] iolimits for virtio-9p

2016-05-04 Thread Greg Kurz
On Mon, 2 May 2016 17:49:26 +0200 Pradeep Kiruvale wrote: > On 2 May 2016 at 14:57, Greg Kurz wrote: > > > On Thu, 28 Apr 2016 11:45:41 +0200 > > Pradeep Kiruvale wrote: > > > > > On 27 April 2016 at 19:12, Greg Kurz wrote: > > > > > > &

Re: [Qemu-devel] Migration ToDo list (a.k.a. Rant)

2016-05-04 Thread Greg Kurz
On Wed, 4 May 2016 13:47:12 +0100 "Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > > > Hi > > > > I am lots of times asked about what is the ToDo list for migration, that > > was on my head, and random notes over my desk, so, trying some > > organization (Yes,

[Qemu-devel] [PATCH] migration: introduce migrate_is_blocked()

2016-05-04 Thread Greg Kurz
uest using mount_tag 'host' Signed-off-by: Greg Kurz --- Since there has been some activity on 9p again since a few weeks, maybe it is not too late for 2.6, if everybody agrees the fix is ok ? include/migration/migration.h |1 + migration/migration.c | 21 +++--

Re: [Qemu-devel] [Qemu-discuss] iolimits for virtio-9p

2016-05-06 Thread Greg Kurz
On Fri, 6 May 2016 08:01:09 +0200 Pradeep Kiruvale wrote: > On 4 May 2016 at 17:40, Greg Kurz wrote: > > > On Mon, 2 May 2016 17:49:26 +0200 > > Pradeep Kiruvale wrote: > > > > > On 2 May 2016 at 14:57, Greg Kurz wrote: > > > > > > &

Re: [Qemu-devel] [PATCH v2] [WIP] [RFC ]Add initial 9pfs support for Windows hosts v2

2016-05-09 Thread Greg Kurz
More comments. On Tue, 12 Apr 2016 09:52:00 +0200 Michael Fritscher wrote: > It was tested on Windows & Linux hosts, on the later no obvious regressions > could be found. The guest was a Knoppix 7.6.0 live cd. > > This is WIP and a RFC - it isn't meant to be upstreamed yet. The error_printf >

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 1/2] target-ppc: migrate interrupt vectors address for spapr VM

2016-03-21 Thread Greg Kurz
On Mon, 21 Mar 2016 17:18:17 +0100 Thomas Huth wrote: > On 21.03.2016 15:02, Cédric Le Goater wrote: > > This address is changed by the linux kernel using the H_SET_MODE hcall > > and needs to be migrated in order to restart a spapr VM running in > > TCG. Other platforms should not be affected. >

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 1/2] target-ppc: migrate interrupt vectors address for spapr VM

2016-03-21 Thread Greg Kurz
ut the _V suffix? > > Yes. You are right. I think we need something like below. > It looks much better ! And just to be sure: this only affects TCG because excp_prefix isn't accessed by QEMU when running with KVM, right ? If the answer is as simple as yes, then: Reviewed-by: Greg

Re: [Qemu-devel] [Qemu-stable] [PATCH 28/35] spapr: skip configuration section during migration of older machines

2016-03-22 Thread Greg Kurz
On Mon, 21 Mar 2016 12:28:26 -0500 Michael Roth wrote: > From: Greg Kurz > > Since QEMU 2.4, we have a configuration section in the migration stream. > This must be skipped for older machines, like it is already done for x86. > > This patch fixes the migration of pseries-2.

Re: [Qemu-devel] [Qemu-stable] [PATCH 28/35] spapr: skip configuration section during migration of older machines

2016-03-23 Thread Greg Kurz
On Tue, 22 Mar 2016 17:35:18 -0500 Michael Roth wrote: > Quoting Greg Kurz (2016-03-22 02:49:35) > > On Mon, 21 Mar 2016 12:28:26 -0500 > > Michael Roth wrote: > > > > > From: Greg Kurz > > > > > > Since QEMU 2.4, we have a configuration sec

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 2/3] target-ppc: Add helpers for updating a CPU's SDR1 and external HPT

2016-03-25 Thread Greg Kurz
Hi Laurent, On Thu, 24 Mar 2016 09:41:59 +0100 Laurent Vivier wrote: > On 24/03/2016 06:35, David Gibson wrote: > > On Tue, Mar 22, 2016 at 05:33:45PM +0100, Laurent Vivier wrote: > >> Hi David, > >> > >> using kvm-unit-tests, I've found a side effect of your patches: the MSR > >> is cleared (

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: compute interrupt vector address from LPCR

2016-03-25 Thread Greg Kurz
Hi Cedric, On Thu, 24 Mar 2016 16:28:53 +0100 Cédric Le Goater wrote: > This address is changed by the linux kernel using the H_SET_MODE hcall > and needs to be migrated in order to restart a spapr VM running in > TCG. This can be done using the AIL bits from the LPCR register. > > The patch in

Re: [Qemu-devel] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

2016-05-25 Thread Greg Kurz
create a VM with a virtfs/9p mount > to the host. Do lots of rsyncs to this mount within the VM, watch 'lsof > | wc -l' go higher and higher on the host. > > Thanks, > > /Sean > Hi Sean ! I've just stumbled upon this mail... maybe worth to post directly to qemu

[Qemu-devel] [PATCH] 9p: getattr: use fstat if we have a fd

2016-05-25 Thread Greg Kurz
If we have an opened fd, it is better to call fstat() as the underlying file may have been unlinked and lstat() will fail. Signed-off-by: Greg Kurz --- This QEMU patch goes with the create-unlink-getattr fix at: http://git.kernel.org/cgit/linux/kernel/git/ericvh/v9fs.git/commit/?id

[Qemu-devel] [PATCH 0/3] PPC/KVM support higher vCPU ids

2016-05-26 Thread Greg Kurz
but since it hasn't been pushed to an official tree yet, I resend it so that the series applies against master. --- Greg Kurz (3): PPC/KVM: early validation of vcpu id linux-headers: update to Linux 4.6 KVM: use KVM_CAP_MAX_VCPU_ID include/standard-headers/linux/pc

[Qemu-devel] [PATCH 2/3] linux-headers: update to Linux 4.6

2016-05-26 Thread Greg Kurz
Signed-off-by: Greg Kurz --- include/standard-headers/linux/pci_regs.h | 20 +++- include/standard-headers/linux/virtio_config.h |2 ++ linux-headers/asm-arm/unistd.h |2 ++ linux-headers/asm-arm64/unistd.h |3 +++ linux-headers

[Qemu-devel] [PATCH 3/3] KVM: use KVM_CAP_MAX_VCPU_ID

2016-05-26 Thread Greg Kurz
returned from KVM_CAP_MAX_VCPUS. Signed-off-by: Greg Kurz --- kvm-all.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/kvm-all.c b/kvm-all.c index e56f38527815..e74e0c6e2352 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1459,10 +1459,16 @@ static int kvm_max_vcpus

[Qemu-devel] [PATCH 1/3] PPC/KVM: early validation of vcpu id

2016-05-26 Thread Greg Kurz
sly bogus vcpu id. Signed-off-by: Greg Kurz --- include/sysemu/kvm.h|2 ++ kvm-all.c |6 ++ target-ppc/translate_init.c |8 3 files changed, 16 insertions(+) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index f9f00e2e56cb..f357ccde9

Re: [Qemu-devel] [PULL 4/5] savevm: fail if migration blockers are present

2016-05-26 Thread Greg Kurz
On Mon, 23 May 2016 22:49:46 +0530 Amit Shah wrote: > From: Greg Kurz > > QEMU has currently two ways to prevent migration to occur: > - migration blocker when it depends on runtime state > - VMStateDescription.unmigratable when migration is not supported at all > > This

Re: [Qemu-devel] [PULL 5/5] migration: regain control of images when migration fails to complete

2016-05-26 Thread Greg Kurz
On Mon, 23 May 2016 22:49:47 +0530 Amit Shah wrote: > From: Greg Kurz > > We currently have an error path during migration that can cause > the source QEMU to abort: > > migration_thread() > migration_completion() > runstate_is_running() &g

Re: [Qemu-devel] [PATCH 3/3] KVM: use KVM_CAP_MAX_VCPU_ID

2016-05-27 Thread Greg Kurz
On Fri, 27 May 2016 13:58:28 +1000 David Gibson wrote: > On Thu, May 26, 2016 at 10:02:23AM +0200, Greg Kurz wrote: > > As stated in linux/Documentation/virtual/kvm/api.txt: > > > > The maximum possible value for max_vcpu_id can be retrieved using the > >

[Qemu-devel] [PATCH] virtio: move bi-endian target support to a single location

2016-05-31 Thread Greg Kurz
ds_vring_endian() is not called on a hot path and non bi-endian targets will return false anyway. While here, also rename TARGET_IS_BIENDIAN to be more precise: it is only for legacy virtio and bi-endian guests. Signed-off-by: Greg Kurz --- hw/virtio/vhost.c |4 incl

Re: [Qemu-devel] [PATCH] virtio: move bi-endian target support to a single location

2016-05-31 Thread Greg Kurz
On Tue, 31 May 2016 13:54:11 +0200 Paolo Bonzini wrote: > On 31/05/2016 10:09, Greg Kurz wrote: > > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > > index 440071815408..81cc5b0ae35c 100644 > > --- a/hw/virtio/vhost.c > > +++ b/hw/virtio/vhost.c > > @@ -767

Re: [Qemu-devel] [PATCH] virtio: move bi-endian target support to a single location

2016-05-31 Thread Greg Kurz
On Tue, 31 May 2016 14:14:15 +0100 Peter Maydell wrote: > On 31 May 2016 at 14:10, Greg Kurz wrote: > > Hence my tentative to put all the details in one place... would it > > be ok if I include "config-target.h" to ensure we have the TARGET macros ? > > No

Re: [Qemu-devel] [PATCH] virtio: move bi-endian target support to a single location

2016-05-31 Thread Greg Kurz
On Tue, 31 May 2016 15:15:21 +0200 Paolo Bonzini wrote: > On 31/05/2016 15:10, Greg Kurz wrote: > >>> > > +#if defined(TARGET_PPC64) || defined(TARGET_ARM) > >>> > > +#define LEGACY_VIRTIO_IS_BIENDIAN 1 > >>> > > +#endif > >&g

[Qemu-devel] [PATCH] 9p: drop useless inclusion of hw/i386/pc.h

2016-06-02 Thread Greg Kurz
Signed-off-by: Greg Kurz --- hw/9pfs/9p.c |1 - hw/9pfs/virtio-9p-device.c |1 - 2 files changed, 2 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index aab1da116894..587e901f81cc 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -13,7 +13,6 @@ #include "

<    2   3   4   5   6   7   8   9   10   11   >