Hi Marcin,
On 7/13/23 22:44, Marcin Juszkiewicz wrote:
W dniu 13.07.2023 o 14:34, Gavin Shan pisze:
On 7/13/23 21:52, Marcin Juszkiewicz wrote:
W dniu 13.07.2023 o 13:44, Peter Maydell pisze:
I see this isn't a change in this patch, but given that what the user specifies is not
"
Hi Connie,
On 7/13/23 22:46, Cornelia Huck wrote:
On Thu, Jul 13 2023, Gavin Shan wrote:
The CPU type 'host-arm-cpu' class won't be registered until KVM or
HVF is configured in target/arm/cpu64.c. Support the corresponding
CPU type only when KVM or HVF is configured.
Signe
Hi Philippe,
On 7/14/23 02:29, Philippe Mathieu-Daudé wrote:
On 13/7/23 14:34, Gavin Shan wrote:
On 7/13/23 21:52, Marcin Juszkiewicz wrote:
W dniu 13.07.2023 o 13:44, Peter Maydell pisze:
I see this isn't a change in this patch, but given that
what the user specifies is not "cor
Hi Richard,
On 7/14/23 05:27, Richard Henderson wrote:
On 7/13/23 13:34, Gavin Shan wrote:
On 7/13/23 21:52, Marcin Juszkiewicz wrote:
W dniu 13.07.2023 o 13:44, Peter Maydell pisze:
I see this isn't a change in this patch, but given that
what the user specifies is not "cortex-
On 7/14/23 10:51, Gavin Shan wrote:
On 7/14/23 02:29, Philippe Mathieu-Daudé wrote:
On 13/7/23 14:34, Gavin Shan wrote:
On 7/13/23 21:52, Marcin Juszkiewicz wrote:
W dniu 13.07.2023 o 13:44, Peter Maydell pisze:
I see this isn't a change in this patch, but given that
what the user spec
Hi Igor,
On 7/14/23 22:07, Igor Mammedov wrote:
On Thu, 13 Jul 2023 15:45:00 +1000
Gavin Shan wrote:
The CPU type invalidation logic in machine_run_board_init() is
independent enough. Lets factor it out into helper validate_cpu_type().
Since we're here, the relevant comments are impro
Hi Igor,
On 7/14/23 21:59, Igor Mammedov wrote:
On Thu, 13 Jul 2023 15:45:01 +1000
Gavin Shan wrote:
There is a generic CPU type invalidation in machine_run_board_init()
^
using that throughout the series is confusing to me.
Perhaps use original phrase
Hi Igor,
On 7/17/23 22:44, Igor Mammedov wrote:
On Fri, 14 Jul 2023 13:56:00 +0100
Peter Maydell wrote:
On Fri, 14 Jul 2023 at 12:50, Igor Mammedov wrote:
On Thu, 13 Jul 2023 12:59:55 +0100
Peter Maydell wrote:
On Thu, 13 Jul 2023 at 12:52, Marcin Juszkiewicz
wrote:
W dniu 13.07.20
Hi Mohd,
On 6/10/23 10:01 AM, Mohd Yusuf Abdul Hamid wrote:
I am trying to reserve a portion of the system memory in QEMU (arm64 virt),
v7.2.1 - but the kernel never honors the reserved memory area and keeps using
the area.
Say, I dumped out DTB and added:
reserved-memory {
#address-cells
hleper to do the check(Igor)
* More patches to move the check (Marcin)
Gavin Shan (32):
cpu: Add helper cpu_model_from_type()
target/alpha: Use generic helper to show CPU model names
target/arm: Use generic helper to show CPU model names
target/avr: Use gene
the
CPU type name to the CPU model name.
Suggested-by: Igor Mammedov
Signed-off-by: Gavin Shan
---
cpu.c | 16
include/hw/core/cpu.h | 12
2 files changed, 28 insertions(+)
diff --git a/cpu.c b/cpu.c
index 1c948d1161..a19e33ff96 100644
--- a/cpu.c
ng (1).
Use generic helper cpu_model_from_type() to show the CPU model names.
The variable @name is renamed to @model in arm_cpu_list_entry() since
it points to the CPU model name instead of the CPU type name.
Signed-off-by: Gavin Shan
---
target/arm/arm-qmp-cmds.c | 6 ++
target/arm
avr_cpu_class_by_name(), and use
the generic helper cpu_model_from_type() to show CPU model names
in cpu_list(), with adjusted format to match with other targets.
Signed-off-by: Gavin Shan
---
target/avr/cpu.c | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/target
e CPU model
names in arm_cpu_list_entry(), and rename @name to @model since
it's points to the CPU model name instead of the CPU type name.
Signed-off-by: Gavin Shan
---
target/cris/cpu.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/target/cris/cpu.c b/target/cris/cpu.c
ind
ed by alpha_cpu_class_by_name() successfully.
Lets follow (1) to show the CPU model names, with the suffix stripped.
With this, the output is compabitle with all of most cases.
Signed-off-by: Gavin Shan
---
target/alpha/cpu.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/
since it points
to the CPU model name instead of the CPU type name.
Signed-off-by: Gavin Shan
---
target/hexagon/cpu.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c
index f155936289..3d0174e6f1 100644
--- a/target
rename
@name to @model in x86_cpu_list_entry() since it points to the CPU
model name instead of the CPU type name.
Signed-off-by: Gavin Shan
---
target/i386/cpu.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 00f913b638
cpu_model_from_type() in above two functions to
show the CPU model names. The format of the output from cpu_list()
is also adjusted to match with other targets.
Signed-off-by: Gavin Shan
---
target/loongarch/cpu.c| 5 -
target/loongarch/loongarch-qmp-cmds.c | 3 +--
2 files changed, 5
x27;s for the
CPU model name instead of the CPU type name, and adjusted output
format to match with other targets.
Signed-off-by: Gavin Shan
---
target/m68k/helper.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/target/m68k/helper.c b/target/m68k/helper.c
@model since it
points to the CPU model name instead of the CPU type name. Besides,
openrisc_cpu_class_by_name() is simplified since the condtion of
'@oc == NULL' has been covered by object_class_dynamic_cast().
Signed-off-by: Gavin Shan
---
target/openrisc/cpu.c | 23 ++--
ement mips_cpu_list() by fetching the CPU model names from the
available CPU classes. Besides, the retrieved class needs to be
validated before it's returned in mips_cpu_class_by_name(), as other
targets do.
Signed-off-by: Gavin Shan
---
target/mips/cpu-defs.c.inc | 9 -
target/
e possible information, the CPU model name, aliases
of the CPU models and PVRs are all shown in ppc_cpu_list_entry().
Use generic helper cpu_model_from_type() in ppc_cpu_list_entry(),
and rename @name to @model since it points to the CPU model name
instead of the CPU type name.
Signed-off-by:
cast().
Signed-off-by: Gavin Shan
---
target/riscv/cpu.c| 23 +--
target/riscv/riscv-qmp-cmds.c | 3 +--
2 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 6b93b04453..a525e24c5a 100644
--- a/target/ri
, rx_cpu_class_by_name() is improved
by merging the condition of '@oc == NULL' to object_class_dynamic_cast().
Signed-off-by: Gavin Shan
---
target/rx/cpu.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/target/rx/cpu.c b/target/rx/cpu.c
index 157e57da0f..
functions. Besides, we need validate the CPU class
in s390_cpu_class_by_name(), as other targets do.
Signed-off-by: Gavin Shan
---
target/s390x/cpu_models.c| 18 +++---
target/s390x/cpu_models_sysemu.c | 9 -
2 files changed, 15 insertions(+), 12 deletions(-)
diff --git
el name
in the above function. Besides, superh_cpu_class_by_name() is improved
by avoiding "goto out" and validating the CPU class.
Signed-off-by: Gavin Shan
---
target/sh4/cpu.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/target/sh4/cpu.
Improve sparc_cpu_class_by_name() by validating @oc, to ensure it's
child of TYPE_SPARC_CPU since it's possible for other types of classes
to have TYPE_SPARC_CPU as the suffix of their type names.
Signed-off-by: Gavin Shan
---
target/sparc/cpu.c | 7 ++-
1 file changed, 6 insert
also improved
by merging the condition of '@oc == NULL' to object_class_dynamic_cast().
Signed-off-by: Gavin Shan
---
target/tricore/cpu.c| 9 +
target/tricore/helper.c | 13 +
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/target/tricore/cpu.
Improve xtensa_cpu_class_by_name() by merging the condition of
'@oc == NULL' to object_class_dynamic_cast().
Signed-off-by: Gavin Shan
---
target/xtensa/cpu.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/target/xtensa/cpu.c b/target/xtensa/cpu.c
index
Implement hppa_cpu_list() to support cpu_list(). With this applied,
the available CPU model names, same to the CPU type names, are shown
as below.
$ ./build/qemu-system-hppa -cpu ?
Available CPUs:
hppa-cpu
Signed-off-by: Gavin Shan
---
target/hppa/cpu.c | 19 +++
target
Implement microblaze_cpu_list() to support cpu_list(). With this applied,
the available CPU model names, same to the CPU type names, are shown
as below.
$ ./build/qemu-system-hppa -cpu ?
Available CPUs:
microblaze-cpu
Signed-off-by: Gavin Shan
---
target/microblaze/cpu.c | 20
Implement nios2_cpu_list() to support cpu_list(). With this applied,
the available CPU model names, same to the CPU type names, are shown
as below.
$ ./build/qemu-system-nios2 -cpu ?
Available CPUs:
nios2-cpu
Signed-off-by: Gavin Shan
---
target/nios2/cpu.c | 20
Remove the false conditions and comments since cpu_list() has been
supported on all targets.
Signed-off-by: Gavin Shan
---
bsd-user/main.c | 3 ---
cpu.c | 3 ---
2 files changed, 6 deletions(-)
diff --git a/bsd-user/main.c b/bsd-user/main.c
index f913cb55a7..3a2d84f14b 100644
--- a
Constify MachineClass::valid_cpu_types[i], as suggested by Richard
Henderson.
Suggested-by: Richard Henderson
Signed-off-by: Gavin Shan
---
hw/m68k/q800.c | 2 +-
include/hw/boards.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c
line spanning of code. The comments are tweaked
a bit either.
No functional change intended.
Signed-off-by: Gavin Shan
---
hw/core/machine.c | 82 +--
1 file changed, 44 insertions(+), 38 deletions(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
tions in the
same function.
No functional change intended.
Suggested-by: Igor Mammedov
Signed-off-by: Gavin Shan
---
hw/core/machine.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index da699cf4e1..6d3f8e133f 100644
--- a
Set mc->valid_cpu_types so that the user specified CPU type can be
validated in machine_run_board_init(). We needn't to do the check
by ourselves.
Signed-off-by: Gavin Shan
---
hw/arm/virt.c | 21 +++--
1 file changed, 3 insertions(+), 18 deletions(-)
diff --git a/hw/ar
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it
by ourselves.
Signed-off-by: Gavin Shan
---
hw/arm/sbsa-ref.c | 21 +++--
1 file changed, 3 insertions(+), 18 deletions(-)
diff --git a/hw/
The names of supported CPU models instead of CPU types should be
printed when the user specified CPU type isn't supported, to be
consistent with the output from '-cpu ?'.
Correct the error messages to print CPU model names instead of CPU
type names.
Signed-off-by: Gavin Sha
x-a15, cortex-a35, cortex-a55,
cortex-a72, cortex-a76, a64fx, neoverse-n1,
neoverse-v1, cortex-a53, cortex-a57, (null),
max
Hide 'host' CPU model until KVM or HVF is enabled.
Signed-off-by: Gavin Shan
---
hw/a
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it by
ourselves.
Signed-off-by: Gavin Shan
---
hw/arm/bananapi_m2u.c | 12 ++--
hw/arm/cubieboard.c | 12 ++--
hw/arm/mps2-tz.c
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it
by ourselves.
Signed-off-by: Gavin Shan
---
hw/riscv/shakti_c.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/hw/riscv/shakti_
On 9/7/23 18:54, Philippe Mathieu-Daudé wrote:
On 7/9/23 02:35, Gavin Shan wrote:
Add helper cpu_model_from_type() to extract the CPU model name from
the CPU type name in two circumstances: (1) The CPU type name is the
combination of the CPU model name and suffix. (2) The CPU type name
is same
On 9/7/23 18:31, Thomas Huth wrote:
On 07/09/2023 02.35, Gavin Shan wrote:
For target/s390x, the CPU type name is always the combination of the
CPU modle name and suffix. The CPU model names have been correctly
s/modle/model/
Thanks, will be fixed in next respin.
Thanks,
Gavin
On 9/7/23 18:20, David Hildenbrand wrote:
On 07.09.23 02:35, Gavin Shan wrote:
For target/s390x, the CPU type name is always the combination of the
CPU modle name and suffix. The CPU model names have been correctly
shown in s390_print_cpu_model_list_entry() and create_cpu_model_list().
Use
On 9/7/23 19:05, Philippe Mathieu-Daudé wrote:
On 7/9/23 02:35, Gavin Shan wrote:
The names of supported CPU models instead of CPU types should be
printed when the user specified CPU type isn't supported, to be
consistent with the output from '-cpu ?'.
Correct the error messag
Hi Philippe,
On 9/8/23 21:22, Philippe Mathieu-Daudé wrote:
Add a field to return the QOM type name of a CPU class.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/core/cpu.h | 2 ++
hw/core/cpu-common.c| 2 +-
target/alpha/cpu.c | 1 +
target/arm/cpu.c| 1 +
targ
On 9/8/23 21:22, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
target/alpha/cpu.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Gavin Shan
diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c
index 270ae787b1..351ee2e9f2 100644
On 9/8/23 21:22, Philippe Mathieu-Daudé wrote:
Leverage the public CPUClass::cpu_resolving_type field and
call object_class_dynamic_cast() once in cpu_class_by_name().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/core/cpu-common.c | 3 ++-
target/alpha/cpu.c | 3 +--
target/arm/cpu.
On 9/8/23 21:23, Philippe Mathieu-Daudé wrote:
On 8/9/23 10:04, Philippe Mathieu-Daudé wrote:
On 8/9/23 01:44, Gavin Shan wrote:
On 9/7/23 18:20, David Hildenbrand wrote:
On 07.09.23 02:35, Gavin Shan wrote:
For target/s390x, the CPU type name is always the combination of the
CPU modle name
On 9/8/23 17:56, Philippe Mathieu-Daudé wrote:
On 8/9/23 01:49, Gavin Shan wrote:
On 9/7/23 19:05, Philippe Mathieu-Daudé wrote:
On 7/9/23 02:35, Gavin Shan wrote:
The names of supported CPU models instead of CPU types should be
printed when the user specified CPU type isn't supported,
On 9/11/23 19:43, Philippe Mathieu-Daudé wrote:
On 11/9/23 01:28, Gavin Shan wrote:
On 9/8/23 21:22, Philippe Mathieu-Daudé wrote:
Add a field to return the QOM type name of a CPU class.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/core/cpu.h | 2 ++
hw/core/cpu-common.c
On 11/17/23 17:34, Philippe Mathieu-Daudé wrote:
On 17/11/23 00:26, Gavin Shan wrote:
On 11/17/23 02:20, Philippe Mathieu-Daudé wrote:
On 16/11/23 14:35, Philippe Mathieu-Daudé wrote:
I'm queuing patches 1-3 & 5-23 to my cpus-next tree. No need to
repost them, please base them o
nning of code. The error messages and comments
are tweaked a bit either.
No functional change intended.
Signed-off-by: Gavin Shan
---
v6: 'const MachineState *' in is_cpu_type_supported() (Phil)
Clearer hint if only one valid CPU is supported (Phil)
---
hw/core
m Philippe Mathieu-Daudé, Leif Lindholm,
Bastian Koppelmann, Daniel Henrique Barboza, Cédric Le Goater,
Gavin Shan (Gavin)
v3:
* Generic helper cpu_model_from_type()(Igor)
* Apply cpu_model_from_type() to the individu
tions in the
same function.
No functional change intended.
Suggested-by: Igor Mammedov
Signed-off-by: Gavin Shan
---
hw/core/machine.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 0c17398141..5b45dbbbd5 100644
--- a
Set mc->valid_cpu_types so that the user specified CPU type can be
validated in machine_run_board_init(). We needn't to do the check
by ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
v6: Move valid_cpu_ty
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it
by ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Philippe Mathieu-Daudé
---
v6: Move valid_cpu_types[] to shakti_c_machine_class_init() (Phil)
---
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it by
ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Richard Henderson
---
v6: To have unified valid_cpu_types[] and move it to board's
class_in
The names of supported CPU models instead of CPU types should be
printed when the user specified CPU type isn't supported, to be
consistent with the output from '-cpu ?'.
Correct the error messages to print CPU model names instead of CPU
type names.
Signed-off-by: Gavin Sha
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it
by ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Leif Lindholm
Reviewed-by: Richard Henderson
---
v6: Move valid_cpu_ty
,
the valid CPU models can be shown.
qemu-system-aarch64: Invalid CPU type: cortex-a8
The valid types are: cortex-a7, cortex-a15, cortex-a35, \
cortex-a55, cortex-a72, cortex-a76, cortex-a710, a64fx, \
neoverse-n1, neoverse-v1, neoverse-n2, cortex-a53, \
cortex-a57, max
Signed-off-b
eu-Daudé
---
include/hw/arm/stm32f405_soc.h | 4
hw/arm/netduinoplus2.c | 7 ++-
hw/arm/olimex-stm32-h405.c | 8 ++--
hw/arm/stm32f405_soc.c | 8 +---
4 files changed, 13 insertions(+), 14 deletions(-)
Reviewed-by: Gavin Shan
o2.c | 7 ++-
hw/arm/stm32f205_soc.c | 9 ++---
3 files changed, 8 insertions(+), 12 deletions(-)
Reviewed-by: Gavin Shan
/stm32f100_soc.h | 4
hw/arm/stm32f100_soc.c | 9 ++---
hw/arm/stm32vldiscovery.c | 7 ++-
3 files changed, 8 insertions(+), 12 deletions(-)
Reviewed-by: Gavin Shan
On 11/21/23 05:42, Marcin Juszkiewicz wrote:
W dniu 20.11.2023 o 01:27, Gavin Shan pisze:
Testing
===
With the following command lines, the output messages are varied before
and after the series is applied.
./build/qemu-system-aarch64 \
-accel tcg -machine virt,gic
insertions(+), 9 deletions(-)
For hw/arm/virt.c
Reviewed-by: Gavin Shan
(Philippe)
* Collected r-bs from Philippe Mathieu-Daudé, Leif Lindholm,
Bastian Koppelmann, Daniel Henrique Barboza, Cédric Le Goater,
Gavin Shan (Gavin)
v3:
* Generic helper cpu_model_from_type()(Igor)
* Apply cpu_
,
the valid CPU models can be shown.
qemu-system-aarch64: Invalid CPU type: cortex-a8
The valid types are: cortex-a7, cortex-a15, cortex-a35, \
cortex-a55, cortex-a72, cortex-a76, cortex-a710, a64fx, \
neoverse-n1, neoverse-v1, neoverse-n2, cortex-a53, \
cortex-a57, max
Signed-off-b
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it by
ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Richard Henderson
---
hw/arm/bananapi_m2u.c | 12 ++--
hw/arm/cubieboard.c | 12 ++--
nning of code. The error messages and comments
are tweaked a bit either.
No functional change intended.
Signed-off-by: Gavin Shan
---
hw/core/machine.c | 90 +++
1 file changed, 51 insertions(+), 39 deletions(-)
diff --git a/hw/core/machine.c b/hw
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it
by ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Leif Lindholm
Reviewed-by: Richard Henderson
---
hw/arm/sbsa-re
The names of supported CPU models instead of CPU types should be
printed when the user specified CPU type isn't supported, to be
consistent with the output from '-cpu ?'.
Correct the error messages to print CPU model names instead of CPU
type names.
Signed-off-by: Gavin Sha
tions in the
same function.
No functional change intended.
Suggested-by: Igor Mammedov
Signed-off-by: Gavin Shan
---
v7: Add 'return' after error_propagate() to avoid calling into
mc->init() in the failing case(Marcin)
---
hw/core/machine.c | 15 +-
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it
by ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Philippe Mathieu-Daudé
---
hw/riscv/shakti_c.c | 13 ++---
1 file changed, 6 insertions(+), 7 d
Set mc->valid_cpu_types so that the user specified CPU type can be
validated in machine_run_board_init(). We needn't to do the check
by ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
hw/arm/vir
On 11/23/23 15:41, Richard Henderson wrote:
This variable is not used or declared outside kvm-all.c.
Signed-off-by: Richard Henderson
---
accel/kvm/kvm-all.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Gavin Shan
Message-Id: <20231025070726.22689-1-duc...@eswincomputing.com>
Signed-off-by: Richard Henderson
---
target/arm/kvm64.c | 28 +++-
1 file changed, 7 insertions(+), 21 deletions(-)
Reviewed-by: Gavin Shan
On 11/23/23 15:42, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/arm/kvm_arm.h | 8
target/arm/kvm.c | 8 +++-
target/arm/kvm64.c | 12
3 files changed, 7 insertions(+), 21 deletions(-)
Reviewed-by: Gavin Shan
(+), 59 deletions(-)
Reviewed-by: Gavin Shan
On 11/23/23 15:42, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/arm/kvm_arm.h | 10 --
target/arm/kvm.c | 24
target/arm/kvm64.c | 17 -
3 files changed, 24 insertions(+), 27 deletions(-)
Reviewed-by: Gavin
On 11/23/23 15:42, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/arm/kvm_arm.h | 8
target/arm/kvm.c | 11 +++
target/arm/kvm64.c | 5 -
3 files changed, 11 insertions(+), 13 deletions(-)
Reviewed-by: Gavin Shan
(+), 79 deletions(-)
Reviewed-by: Gavin Shan
On 11/23/23 15:42, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/arm/kvm_arm.h | 16
target/arm/kvm.c | 16 ++--
2 files changed, 14 insertions(+), 18 deletions(-)
Reviewed-by: Gavin Shan
On 11/23/23 15:42, Richard Henderson wrote:
This function is only used once, and is quite simple.
Signed-off-by: Richard Henderson
---
target/arm/kvm_arm.h | 13 -
target/arm/kvm64.c | 7 +--
2 files changed, 1 insertion(+), 19 deletions(-)
Reviewed-by: Gavin Shan
(+), 276 deletions(-)
Reviewed-by: Gavin Shan
-by: Gavin Shan
diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c
index 504526b24c..61fb9dbde0 100644
--- a/target/arm/kvm64.c
+++ b/target/arm/kvm64.c
@@ -361,32 +361,18 @@ bool kvm_arm_reg_syncs_via_cpreg_list(uint64_t regidx)
}
}
-typedef struct CPRegStateLevel {
-uint64_t
On 11/23/23 15:42, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/arm/kvm_arm.h | 9 -
target/arm/kvm.c | 22 ++
target/arm/kvm64.c | 15 ---
3 files changed, 22 insertions(+), 24 deletions(-)
Reviewed-by: Gavin Shan
following nits addressed:
Reviewed-by: Gavin Shan
diff --git a/target/arm/kvm_arm.h b/target/arm/kvm_arm.h
index 2755ee8366..1043123cc7 100644
--- a/target/arm/kvm_arm.h
+++ b/target/arm/kvm_arm.h
@@ -77,16 +77,6 @@ void kvm_arm_register_device(MemoryRegion *mr, uint64_t
devid, uint64_t group
| 820 -
target/arm/meson.build | 2 +-
3 files changed, 790 insertions(+), 821 deletions(-)
delete mode 100644 target/arm/kvm64.c
With Phil's comments addressed:
Reviewed-by: Gavin Shan
On 11/23/23 15:42, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/arm/kvm_arm.h | 12
target/arm/kvm.c | 12 +++-
2 files changed, 11 insertions(+), 13 deletions(-)
Reviewed-by: Gavin Shan
On 11/23/23 15:42, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/arm/kvm_arm.h | 14 --
target/arm/kvm.c | 14 +-
2 files changed, 13 insertions(+), 15 deletions(-)
Reviewed-by: Gavin Shan
On 11/23/23 15:42, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/arm/kvm_arm.h | 12
target/arm/kvm.c | 10 --
2 files changed, 8 insertions(+), 14 deletions(-)
Reviewed-by: Gavin Shan
changed, 4 insertions(+), 17 deletions(-)
Reviewed-by: Gavin Shan
On 11/23/23 15:42, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/arm/kvm_arm.h | 20
target/arm/kvm.c | 20 ++--
2 files changed, 18 insertions(+), 22 deletions(-)
Reviewed-by: Gavin Shan
deletions(-)
Reviewed-by: Gavin Shan
On 11/23/23 15:42, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/arm/kvm_arm.h | 2 --
target/arm/kvm.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Gavin Shan
On 11/24/23 05:35, Philippe Mathieu-Daudé wrote:
kvm_arm_its_reset_hold() calls warn_report(), itself declared
in "qemu/error-report.h".
Signed-off-by: Philippe Mathieu-Daudé
---
hw/intc/arm_gicv3_its_kvm.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Gavin Shan
On 11/24/23 05:35, Philippe Mathieu-Daudé wrote:
Both MemoryRegion and Error types are forward declared
in "qemu/typedefs.h".
Signed-off-by: Philippe Mathieu-Daudé
---
target/arm/kvm_arm.h | 2 --
1 file changed, 2 deletions(-)
Reviewed-by: Gavin Shan
target/arm/kvm_arm.h | 4 ++--
target/arm/cpu.c | 2 +-
target/arm/kvm.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
With the following comments resolved:
Reviewed-by: Gavin Shan
diff --git a/target/arm/kvm_arm.h b/target/arm/kvm_arm.h
index 50967f4ae9..6fb8a5f67e
701 - 800 of 1041 matches
Mail list logo
