[PATCH 2/3] hw/gpio/avr_gpio.c: add tracing for read and writes

2021-03-11 Thread G S Niteesh Babu
Added tracing for gpio read, write, and update output irq. 1) trace_avr_gpio_update_ouput_irq 2) trace_avr_gpio_read 3) trace_avr_gpio_write Signed-off-by: G S Niteesh Babu --- hw/gpio/avr_gpio.c | 16 hw/gpio/trace-events | 6 ++ 2 files changed, 18 insertions(+), 4

[PATCH 0/3] AVR GPIO Emulation and Arduino D13 LED

2021-03-11 Thread G S Niteesh Babu
onboard LED. G S Niteesh Babu (2): hw/gpio/avr_gpio.c: add tracing for read and writes avr/arduino: Add D13 LED Heecheol Yang (1): hw/avr: Add limited support for avr gpio registers hw/avr/Kconfig | 2 + hw/avr/arduino.c | 15 hw/avr/atmega.c| 7

[PATCH 1/3] hw/avr: Add limited support for avr gpio registers

2021-03-11 Thread G S Niteesh Babu
From: Heecheol Yang Add some of these features for AVR GPIO: - GPIO I/O : PORTx registers - Data Direction : DDRx registers - DDRx toggling : PINx registers Following things are not supported yet: - MCUR registers Signed-off-by: Heecheol Yang Signed-off-by: G S Niteesh Babu Message

[PATCH 3/3] avr/arduino: Add D13 LED

2021-03-11 Thread G S Niteesh Babu
Signed-off-by: G S Niteesh Babu --- hw/avr/Kconfig | 1 + hw/avr/arduino.c | 15 +++ 2 files changed, 16 insertions(+) diff --git a/hw/avr/Kconfig b/hw/avr/Kconfig index 16a57ced11..e0d4fc5537 100644 --- a/hw/avr/Kconfig +++ b/hw/avr/Kconfig @@ -8,3 +8,4 @@ config AVR_ATMEGA_MCU

[PATCH 1/3] hw/avr: Add limited support for avr gpio registers

2021-03-02 Thread G S Niteesh Babu
From: Heecheol Yang Add some of these features for AVR GPIO: - GPIO I/O : PORTx registers - Data Direction : DDRx registers - DDRx toggling : PINx registers Following things are not supported yet: - MCUR registers Signed-off-by: Heecheol Yang --- hw/avr/Kconfig | 1 + h

[PATCH 2/3] avr/arduino: Add D13 LED

2021-03-02 Thread G S Niteesh Babu
Signed-off-by: G S Niteesh Babu --- hw/avr/Kconfig | 1 + hw/avr/arduino.c | 15 +++ 2 files changed, 16 insertions(+) diff --git a/hw/avr/Kconfig b/hw/avr/Kconfig index 16a57ced11..e0d4fc5537 100644 --- a/hw/avr/Kconfig +++ b/hw/avr/Kconfig @@ -8,3 +8,4 @@ config AVR_ATMEGA_MCU

[PATCH 3/3] hw/gpio/avr_gpio.c: add tracing for read and writes

2021-03-02 Thread G S Niteesh Babu
Added tracing for gpio read, write, and update output irq. 1) trace_avr_gpio_update_ouput_irq 2) trace_avr_gpio_read 3) trace_avr_gpio_write Signed-off-by: G S Niteesh Babu --- hw/gpio/avr_gpio.c | 16 hw/gpio/trace-events | 6 ++ 2 files changed, 18 insertions(+), 4

[PATCH] block/iscsi: Use lock guards

2021-02-06 Thread G S Niteesh Babu
--- block/iscsi.c | 37 - 1 file changed, 12 insertions(+), 25 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 4d2a416ce7..4f7abc665a 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -48,6 +48,7 @@ #include "crypto/secret.h" #include "scsi/util

[PATCH v4 0/7] AQMP TUI Draft

2021-08-19 Thread G S Niteesh Babu
minor changes. G S Niteesh Babu (7): python: disable pylint errors for aqmp-tui python: Add dependencies for AQMP TUI python/aqmp-tui: Add AQMP TUI draft python: Add entry point for aqmp-tui python: add optional pygments dependency python/aqmp-tui: Add syntax highlighting python/aqmp

[PATCH v4 1/7] python: disable pylint errors for aqmp-tui

2021-08-19 Thread G S Niteesh Babu
Disable missing-docstring and fixme pylint warnings. This is because since the AQMP is just a prototype it is currently not documented properly and lot of todo and fixme's are still in place. Signed-off-by: G S Niteesh Babu --- python/setup.cfg | 2 ++ 1 file changed, 2 insertions(+)

[PATCH v4 3/7] python/aqmp-tui: Add AQMP TUI draft

2021-08-19 Thread G S Niteesh Babu
Added a draft of AQMP TUI. Implements the follwing basic features: 1) Command transmission/reception. 2) Shows events asynchronously. 3) Shows server status in the bottom status bar. Also added type annotations and necessary pylint, mypy configurations Signed-off-by: G S Niteesh Babu

[PATCH v4 4/7] python: Add entry point for aqmp-tui

2021-08-19 Thread G S Niteesh Babu
Add an entry point for aqmp-tui. This will allow it to be run from the command line using "aqmp-tui localhost:1234" More options available in the TUI can be found using "aqmp-tui -h" Signed-off-by: G S Niteesh Babu --- python/setup.cfg | 1 + 1 file changed, 1 insertion(+)

[PATCH v4 2/7] python: Add dependencies for AQMP TUI

2021-08-19 Thread G S Niteesh Babu
Added dependencies for the upcoming AQMP TUI under the optional 'tui' group. The same dependencies have also been added under the devel group since no work around has been found for optional groups to imply other optional groups. Signed-off-by: G S Niteesh Babu --- python/Pipfile

[PATCH v4 7/7] python/aqmp-tui: Add QMP connection manager

2021-08-19 Thread G S Niteesh Babu
The connection manager will take care of connecting/disconnecting to the server. This will also try to reconnect to the server in certain situations where the client has been disconnected due to some error condition. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 127

[PATCH v4 5/7] python: add optional pygments dependency

2021-08-19 Thread G S Niteesh Babu
-off-by: G S Niteesh Babu --- python/Pipfile.lock | 8 python/setup.cfg| 5 + 2 files changed, 13 insertions(+) diff --git a/python/Pipfile.lock b/python/Pipfile.lock index da7a4ee164..d2a7dbd88b 100644 --- a/python/Pipfile.lock +++ b/python/Pipfile.lock @@ -200

[PATCH v4 6/7] python/aqmp-tui: Add syntax highlighting

2021-08-19 Thread G S Niteesh Babu
asier theme config using an external config of some sort. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/python/qemu/aqmp/aqmp_tui.py b/python/qemu/aqmp/aqmp_tui.py

[PATCH v5 0/5] python/aqmp: AQMP-TUI

2021-08-23 Thread G S Niteesh Babu
t name from master to parent. 2) Merged connection manager to the AQMP TUI patch 3) Fixed some docstrings. 4) Added scrolling support to history box. G S Niteesh Babu (5): python: Add dependencies for AQMP TUI python/aqmp-tui: Add AQMP TUI python: Add entry point for aqmp-tui python: add op

[PATCH v5 1/5] python: Add dependencies for AQMP TUI

2021-08-23 Thread G S Niteesh Babu
Added dependencies for the upcoming AQMP TUI under the optional 'tui' group. The same dependencies have also been added under the devel group since no work around has been found for optional groups to imply other optional groups. Signed-off-by: G S Niteesh Babu --- python/Pipfile

[PATCH v5 3/5] python: Add entry point for aqmp-tui

2021-08-23 Thread G S Niteesh Babu
Add an entry point for aqmp-tui. This will allow it to be run from the command line using "aqmp-tui localhost:1234" More options available in the TUI can be found using "aqmp-tui -h" Signed-off-by: G S Niteesh Babu --- python/setup.cfg | 1 + 1 file changed, 1 insertion(+)

[PATCH v5 2/5] python/aqmp-tui: Add AQMP TUI

2021-08-23 Thread G S Niteesh Babu
configurations. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 637 +++ python/setup.cfg | 13 +- 2 files changed, 649 insertions(+), 1 deletion(-) create mode 100644 python/qemu/aqmp/aqmp_tui.py diff --git a/python/qemu/aqmp/aqmp_tui.py b

[PATCH v5 4/5] python: add optional pygments dependency

2021-08-23 Thread G S Niteesh Babu
-off-by: G S Niteesh Babu --- python/Pipfile.lock | 8 python/setup.cfg| 5 + 2 files changed, 13 insertions(+) diff --git a/python/Pipfile.lock b/python/Pipfile.lock index da7a4ee164..d2a7dbd88b 100644 --- a/python/Pipfile.lock +++ b/python/Pipfile.lock @@ -200

[PATCH v5 5/5] python/aqmp-tui: Add syntax highlighting

2021-08-23 Thread G S Niteesh Babu
asier theme config using an external config of some sort. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/python/qemu/aqmp/aqmp_tui.py b/python/qemu/aqmp/aqmp_tui.py

[PATCH v6 5/5] python/aqmp-tui: Add syntax highlighting

2021-08-23 Thread G S Niteesh Babu
asier theme config using an external config of some sort. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/python/qemu/aqmp/aqmp_tui.py b/python/qemu/aqmp/aqmp_tui.py

[PATCH v6 1/5] python: Add dependencies for AQMP TUI

2021-08-23 Thread G S Niteesh Babu
Added dependencies for the upcoming AQMP TUI under the optional 'tui' group. The same dependencies have also been added under the devel group since no work around has been found for optional groups to imply other optional groups. Signed-off-by: G S Niteesh Babu --- python/Pipfile

[PATCH v6 4/5] python: add optional pygments dependency

2021-08-23 Thread G S Niteesh Babu
-off-by: G S Niteesh Babu --- python/Pipfile.lock | 8 python/setup.cfg| 5 + 2 files changed, 13 insertions(+) diff --git a/python/Pipfile.lock b/python/Pipfile.lock index da7a4ee164..d2a7dbd88b 100644 --- a/python/Pipfile.lock +++ b/python/Pipfile.lock @@ -200

[PATCH v6 3/5] python: Add entry point for aqmp-tui

2021-08-23 Thread G S Niteesh Babu
Add an entry point for aqmp-tui. This will allow it to be run from the command line using "aqmp-tui localhost:1234" More options available in the TUI can be found using "aqmp-tui -h" Signed-off-by: G S Niteesh Babu --- python/setup.cfg | 1 + 1 file changed, 1 insertion(+)

[PATCH v6 2/5] python/aqmp-tui: Add AQMP TUI

2021-08-23 Thread G S Niteesh Babu
configurations. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 620 +++ python/setup.cfg | 13 +- 2 files changed, 632 insertions(+), 1 deletion(-) create mode 100644 python/qemu/aqmp/aqmp_tui.py diff --git a/python/qemu/aqmp/aqmp_tui.py b

[PATCH v6 0/5] python/aqmp: AQMP TUI

2021-08-23 Thread G S Niteesh Babu
r init to class 2) Reworked the format_json function 3) Renamed the has_tui_handler function to has_handler_type 4) Added OSError to be considered for retrying 5) Reworked the editor to add messages to the end of the history stack. G S Niteesh Babu (5): python: Add dependencies for AQMP TUI

[PATCH v3 00/13] AQMP TUI Draft

2021-07-30 Thread G S Niteesh Babu
copying of QMP message from TUI using keyboard shortcut alt-c. G S Niteesh Babu (13): python/aqmp: Fix wait_closed work-around for python 3.6 python: disable pylint errors for aqmp-tui python: Add dependencies for AQMP TUI python/aqmp-tui: Add AQMP TUI draft python: add entry point for

[PATCH v3 01/13] python/aqmp: Fix wait_closed work-around for python 3.6

2021-07-30 Thread G S Niteesh Babu
-by: G S Niteesh Babu --- python/qemu/aqmp/util.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/python/qemu/aqmp/util.py b/python/qemu/aqmp/util.py index de0df44cbd..eaa5fc7d5f 100644 --- a/python/qemu/aqmp/util.py +++ b/python/qemu/aqmp/util.py @@ -134,7 +134,17

[PATCH v3 06/13] python/aqmp-tui: Added type annotations for aqmp-tui

2021-07-30 Thread G S Niteesh Babu
This patch adds type annotations for aqmp-tui using the mypy library. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 79 python/setup.cfg | 3 -- 2 files changed, 43 insertions(+), 39 deletions(-) diff --git a/python/qemu

[PATCH v3 02/13] python: disable pylint errors for aqmp-tui

2021-07-30 Thread G S Niteesh Babu
Disable missing-docstring and fixme pylint warnings. This is because since the AQMP is just a prototype it is currently not documented properly and lot of todo and fixme's are still in place. Signed-off-by: G S Niteesh Babu --- python/setup.cfg | 2 ++ 1 file changed, 2 insertions(+)

[PATCH v3 09/13] python/aqmp-tui: Add QMP connection manager

2021-07-30 Thread G S Niteesh Babu
Instead of manually connecting and disconnecting from the server. We now rely on the runstate to manage the QMP connection. Along with this the ability to reconnect on certain exceptions has also been added. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 109

[PATCH v3 04/13] python/aqmp-tui: Add AQMP TUI draft

2021-07-30 Thread G S Niteesh Babu
Added a draft of AQMP TUI. Implements the follwing basic features: 1) Command transmission/reception. 2) Shows events asynchronously. 3) Shows server status in the bottom status bar. Also added necessary pylint, mypy configurations Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp

[PATCH v3 10/13] python/aqmp-tui: Add scrolling to history box

2021-07-30 Thread G S Niteesh Babu
Adds scroll support to history box. The list can now be scrolled using arrow keys, page up/down and the mouse. The current implementation requires the widget to be in focus to enable scrolling. Therefore the user has to click on the widget before scrolling. Signed-off-by: G S Niteesh Babu

[PATCH v3 03/13] python: Add dependencies for AQMP TUI

2021-07-30 Thread G S Niteesh Babu
Added dependencies for the upcoming AQMP TUI under the optional 'tui' group. The same dependencies have also been added under the devel group since no work around has been found for optional groups to imply other optional groups. Signed-off-by: G S Niteesh Babu --- python/Pipfile

[PATCH v3 05/13] python: add entry point for aqmp-tui

2021-07-30 Thread G S Niteesh Babu
Add an entry point for aqmp-tui. This will allow it to be run from the command line using "aqmp-tui localhost:1234" More options available in the TUI can be found using "aqmp-tui -h" Signed-off-by: G S Niteesh Babu --- python/setup.cfg | 1 + 1 file changed, 1 insertion(+)

[PATCH v3 11/13] python/aqmp-tui: Add ability to highlight messages

2021-07-30 Thread G S Niteesh Babu
Adds ability to highlight messages in the history box. The messages can be selected using up/down arrow keys. This can be enhanced in the future to apply specific settings to a particular message. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 50

[PATCH v3 08/13] python/aqmp-tui: add syntax highlighting

2021-07-30 Thread G S Niteesh Babu
asier theme config using an external config of some sort. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 52 +++- 1 file changed, 40 insertions(+), 12 deletions(-) diff --git a/python/qemu/aqmp/aqmp_tui.py b/python/qemu/aqmp/aqmp_tui.py

[PATCH v3 07/13] python: add optional pygments dependency

2021-07-30 Thread G S Niteesh Babu
-off-by: G S Niteesh Babu --- python/Pipfile.lock | 8 python/setup.cfg| 5 + 2 files changed, 13 insertions(+) diff --git a/python/Pipfile.lock b/python/Pipfile.lock index 76cf1e4930..2c6d779348 100644 --- a/python/Pipfile.lock +++ b/python/Pipfile.lock @@ -200

[PATCH v3 12/13] python/aqmp-tui: Add pyperclip dependency

2021-07-30 Thread G S Niteesh Babu
This dependency is required to enable copying from the TUI using special keys to the system clipboard. pyperclip works out of the box on windows and macos but requires xsel/xclip to be installed on linux machines. Signed-off-by: G S Niteesh Babu --- python/Pipfile.lock | 22

[PATCH v3 13/13] python/aqmp-tui: Allow copying message from TUI

2021-07-30 Thread G S Niteesh Babu
This commit adds a feature that enables use to copy messages from the TUI after highlighting the message in the history box using up/down arrow keys and pressing alt-c. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 9 + 1 file changed, 9 insertions(+) diff --git a

[PATCH v2 1/6] python: disable pylint errors for aqmp-tui

2021-07-13 Thread G S Niteesh Babu
Disable missing-docstring and fixme pylint warnings. This is because since the AQMP is just a prototype it is currently not documented properly and lot of todo and fixme's are still in place. Signed-off-by: G S Niteesh Babu --- python/setup.cfg | 2 ++ 1 file changed, 2 insertions(+)

[PATCH v2 3/6] python/aqmp-tui: Add AQMP TUI draft

2021-07-13 Thread G S Niteesh Babu
Added a draft of AQMP TUI. Implements the follwing basic features: 1) Command transmission/reception. 2) Shows events asynchronously. 3) Shows server status in the bottom status bar. Also added necessary pylint, mypy configurations Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp

[PATCH v2 4/6] python: add optional pygments dependency

2021-07-13 Thread G S Niteesh Babu
-off-by: G S Niteesh Babu --- python/Pipfile.lock | 8 python/setup.cfg| 5 + 2 files changed, 13 insertions(+) diff --git a/python/Pipfile.lock b/python/Pipfile.lock index 76cf1e4930..2c6d779348 100644 --- a/python/Pipfile.lock +++ b/python/Pipfile.lock @@ -200

[PATCH v2 5/6] python/aqmp-tui: add syntax highlighting

2021-07-13 Thread G S Niteesh Babu
asier theme config using an external config of some sort. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/python/qemu/aqmp/aqmp_tui.py b/python/qemu/aqmp/aqmp_tui.py index f853efc1f5..9ee91f0e99 1

[PATCH v2 6/6] python: add entry point for aqmp-tui

2021-07-13 Thread G S Niteesh Babu
Add an entry point for aqmp-tui. This will allow it to be run from the command line using "aqmp-tui localhost:1234" More options available in the TUI can be found using "aqmp-tui -h" Signed-off-by: G S Niteesh Babu --- python/setup.cfg | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 0/6] python: AQMP-TUI Prototype

2021-07-13 Thread G S Niteesh Babu
in finding out bugs in the AQMP library. The intent for this patch series is to get comments on the architectural design of the prototype. These comments will lay down the foundation for the upcoming TUI. G S Niteesh Babu (6): python: disable pylint errors for aqmp-tui python: Add dependencies

[PATCH v2 2/6] python: Add dependencies for AQMP TUI

2021-07-13 Thread G S Niteesh Babu
Added dependencies for the upcoming AQMP TUI under the optional 'tui' group. The same dependencies have also been added under the devel group since no work around has been found for optional groups to imply other optional groups. Signed-off-by: G S Niteesh Babu --- python/Pipfile

[PATCH 1/6] python: disable pylint errors for aqmp-tui

2021-07-02 Thread G S Niteesh Babu
Disable missing-docstring and fixme pylint warnings. This is because since the AQMP is just a prototype it is currently not documented properly and lot of todo and fixme's are still in place. Signed-off-by: G S Niteesh Babu --- python/setup.cfg | 2 ++ 1 file changed, 2 insertions(+)

[PATCH 0/6] python: AQMP-TUI Prototype

2021-07-02 Thread G S Niteesh Babu
ctural design of the prototype. These comments will lay down the foundation for the upcoming TUI. G S Niteesh Babu (6): python: disable pylint errors for aqmp-tui python: Add dependencies for AQMP TUI python/aqmp-tui: Add AQMP TUI draft python: add optional pygments dependency python/aqmp-tu

[PATCH 4/6] python: add optional pygments dependency

2021-07-02 Thread G S Niteesh Babu
-off-by: G S Niteesh Babu --- python/Pipfile.lock | 8 python/setup.cfg| 5 + 2 files changed, 13 insertions(+) diff --git a/python/Pipfile.lock b/python/Pipfile.lock index 76cf1e4930..2c6d779348 100644 --- a/python/Pipfile.lock +++ b/python/Pipfile.lock @@ -200

[PATCH 2/6] python: Add dependencies for AQMP TUI

2021-07-02 Thread G S Niteesh Babu
Added dependencies for the upcoming AQMP TUI under the optional 'tui' group. The same dependencies have also been added under the devel group since no work around has been found for optional groups to imply other optional groups. Signed-off-by: G S Niteesh Babu --- python/Pipfile

[PATCH 5/6] python/aqmp-tui: add syntax highlighting

2021-07-02 Thread G S Niteesh Babu
asier theme config using an external config of some sort. Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp/aqmp_tui.py | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/python/qemu/aqmp/aqmp_tui.py b/python/qemu/aqmp/aqmp_tui.py index 8e9e8

[PATCH 3/6] python/aqmp-tui: Add AQMP TUI draft

2021-07-02 Thread G S Niteesh Babu
Added a draft of AQMP TUI. Implements the follwing basic features: 1) Command transmission/reception. 2) Shows events asynchronously. 3) Shows server status in the bottom status bar. Also added necessary pylint, mypy configurations Signed-off-by: G S Niteesh Babu --- python/qemu/aqmp

[PATCH 6/6] python: add entry point for aqmp-tui

2021-07-02 Thread G S Niteesh Babu
Add an entry point for aqmp-tui. This will allow it to be run from the command line using "aqmp-tui -a localhost:1234" Signed-off-by: G S Niteesh Babu --- python/setup.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/python/setup.cfg b/python/setup.cfg index 4782fe5241..23e3018