Re: [PATCH v2 1/5] aspeed/wdt: Introduce a container for the MMIO region

2021-10-21 Thread Francisco Iglesias
n top of the register region for this purpose. > > Signed-off-by: Cédric Le Goater Reviewed-by: Francisco Iglesias > --- > include/hw/watchdog/wdt_aspeed.h | 1 + > hw/watchdog/wdt_aspeed.c | 6 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --gi

Re: [PATCH v2 2/5] aspeed: Initialize the watchdog device models before the FMC models

2021-10-21 Thread Francisco Iglesias
SoC models for > consistency. > > Signed-off-by: Cédric Le Goater Reviewed-by: Francisco Iglesias > --- > hw/arm/aspeed_ast2600.c | 36 ++-- > hw/arm/aspeed_soc.c | 36 ++-- > 2 files changed, 36 insertions

Re: [PATCH v2 4/5] aspeed/smc: Use a container for the flash mmio address space

2021-10-21 Thread Francisco Iglesias
ainer is cleaner. > > Cc: Philippe Mathieu-Daudé > Signed-off-by: Cédric Le Goater Reviewed-by: Francisco Iglesias > --- > include/hw/ssi/aspeed_smc.h | 2 +- > hw/ssi/aspeed_smc.c | 11 +++ > 2 files changed, 8 insertions(+), 5 deletions(-) > > diff

Re: [PATCH] migration: Remove load_state_old and minimum_version_id_old

2022-02-15 Thread Francisco Iglesias
es removing one stray useless setting of > minimum_version_id_old in a VMStateDescription with no load_state_old > function, which crept in after the global weeding-out of them in > commit 17e313406126. > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- &g

Re: [PATCH] can: fix Xilinx ZynqMP CAN RX FIFO logic

2022-08-17 Thread Francisco Iglesias
the same values) Otherwise: Reviewed-by: Francisco Iglesias Best regards, Francisco Iglesias > > Signed-off-by: Anton Kochkov > Resolves: https://gitlab.com/qemu-projects/qemu/-/issues/1123 > --- > hw/net/can/xlnx-zynqmp-can.c | 32 > 1

Re: [RFC] hw/block/m25p80: implement Octal SPI commands

2022-08-17 Thread Francisco Iglesias
s->needed_bytes = 2; > +if (s->write_enable) { > +if (get_man(s) == MAN_NUMONYX) { > +s->needed_bytes = 2; > + } else if (get_man(s) == MAN_MICRON) { > +s->needed_bytes += get_addr_length(s); > +

Re: [PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency

2023-02-16 Thread Francisco Iglesias
ap: 6 Fix by adding the missing Kconfig dependency. Fixes: acc0b8b05a ("hw/arm/xlnx-zynqmp: Connect ZynqMP's USB controllers") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm

Re: [QEMU][PATCH v2 5/5] MAINTAINERS: Include canfd tests under Xilinx CAN

2022-11-08 Thread Francisco Iglesias
On [2022 Oct 21] Fri 22:47:46, Vikram Garhwal wrote: > Signed-off-by: Vikram Garhwal > Reviewed-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINE

Re: [QEMU][PATCH v2 4/5] tests/qtest: Introduce tests for Xilinx VERSAL CANFD controller

2022-11-08 Thread Francisco Iglesias
e with CANFD frame. > > Signed-off-by: Vikram Garhwal > Acked-by: Thomas Huth Reviewed-by: Francisco Iglesias > --- > tests/qtest/meson.build | 1 + > tests/qtest/xlnx-canfd-test.c | 422 ++ > 2 files changed, 423 insertions(+) >

Re: [QEMU][PATCH v2 3/5] xlnx-zynqmp: Connect Xilinx VERSAL CANFD controllers

2022-11-09 Thread Francisco Iglesias
Hi Vikram, In the git summary s/zynqmp/versal/. On [2022 Oct 21] Fri 22:47:44, Vikram Garhwal wrote: > Connect CANFD0 and CANFD1 on the Versal-virt machine and update > xlnx-versal-virt > document with CANFD command line examples. > > Signed-off-by: Vikram Garhwal > --- > docs/system/arm/xlnx

Re: [QEMU][PATCH 1/5] MAINTAINERS: Update maintainer's email for Xilinx CAN

2022-09-26 Thread Francisco Iglesias
On [2022 Sep 09] Fri 23:12:48, Vikram Garhwal wrote: > Signed-off-by: Vikram Garhwal Reviewed-by: Francisco Iglesias > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 1729c0901c..1d45

[PATCH v1 1/1] hw/block/m25p80: Micron Xccela mt35xu01g flash Octal command support

2022-09-30 Thread Francisco Iglesias
Provide the Micron Xccela flash mt35xu01g with Octal command support. Signed-off-by: Francisco Iglesias --- hw/block/m25p80.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index a8d2519141..79e26424ec

Re: [PATCH v2 1/2] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-09 Thread Francisco Iglesias
te *d) > { > Flash *s = M25P80(d); > > +s->wp_level = true; > +s->status_register_write_disabled = false; > + > reset_memory(s); > } > > @@ -1601,6 +1636,8 @@ static const VMStateDescription vmstate_m25p80 = { > VMSTATE_U

Re: [PATCH v3 1/2] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-20 Thread Francisco Iglesias
Hi Iris, On [2022 Jun 17] Fri 15:02:45, Iris Chen wrote: > Signed-off-by: Iris Chen > --- > Thanks everyone for your comments. This is a v3 patch that addresses all > suggestions (moving write_enable to decode_new_cmd). > I am waiting on some feedback from Dan's (dz4l...@gmail.com) patch > rega

Re: [PATCH] hw:m25p80: Add STATE_STANDBY command state

2022-06-20 Thread Francisco Iglesias
FFF; /* StandBy state SO shall be HiZ */ 0xFF should be enough here (since we are dealing with 8 bits, e.g. m25p80_transfer8). More safe is probably to return 0 though and see this as if a pulldown was connected to the line instead (this because r has been default to 0 and was the most likely r

Re: [PATCH 2/5] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check

2024-08-21 Thread Francisco Iglesias
Brown Reviewed-by: Francisco Iglesias > --- > hw/net/can/xlnx-versal-canfd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/net/can/xlnx-versal-canfd.c b/hw/net/can/xlnx-versal-canfd.c > index ad0c4da3c8..8968672b84 100644 > --- a/hw/net/can/xl

Re: [PATCH 1/5] hw/net/can/xlnx-versal-canfd: Fix interrupt level

2024-08-21 Thread Francisco Iglesias
; bit 0 when applying it, resulting in the IRQ never being delivered. > > Signed-off-by: Doug Brown Reviewed-by: Francisco Iglesias > --- > hw/net/can/xlnx-versal-canfd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/net/can/xlnx-versal-canfd.c

Re: [PATCH for-9.2 1/6] hw/misc/xlnx-versal-cfu: destroy fifo in finalize

2024-08-23 Thread Francisco Iglesias
gt; #9 0x55ec8d65c81d in qmp_device_list_properties qom/qom-qmp-cmds.c:144:11 > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > hw/misc/xlnx-versal-cfu.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/hw/misc/xlnx-versal-cfu.c

Re: [PATCH for-9.2 6/6] hm/nvram/xlnx-versal-efuse-ctrl: Call register_finalize_block

2024-08-23 Thread Francisco Iglesias
55f225b0bfe1 in object_new qom/object.c:797:12 > #9 0x55f226309e0d in qmp_device_list_properties qom/qom-qmp-cmds.c:144:11 > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > include/hw/nvram/xlnx-versal-efuse.h | 1 + > hw/nvram/xlnx-versal-efuse-ct

Re: [PATCH for-9.2 3/6] hw/nvram/xlnx-bbram: Call register_finalize_block

2024-08-23 Thread Francisco Iglesias
87aa11 in object_new qom/object.c:797:12 > #9 0x56415507883d in qmp_device_list_properties qom/qom-qmp-cmds.c:144:11 > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > include/hw/nvram/xlnx-bbram.h | 1 + > hw/nvram/xlnx-bbram.c | 13 ++--- > 2 files cha

Re: [PATCH for-9.2 4/6] hw/nvram/xlnx-zynqmp-efuse: Call register_finalize_block

2024-08-23 Thread Francisco Iglesias
533c01 in object_new qom/object.c:797:12 > #9 0x55f402d31a2d in qmp_device_list_properties qom/qom-qmp-cmds.c:144:11 > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > include/hw/nvram/xlnx-zynqmp-efuse.h | 1 + > hw/nvram/xlnx-zynqmp-efuse.c |

Re: [PATCH for-9.2 5/6] hw/misc/xlnx-versal-trng: Call register_finalize_block

2024-08-23 Thread Francisco Iglesias
df1 in object_new qom/object.c:797:12 > #9 0x558432427c1d in qmp_device_list_properties qom/qom-qmp-cmds.c:144:11 > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > include/hw/misc/xlnx-versal-trng.h | 1 + > hw/misc/xlnx-versal-trng.c | 6 +++--- > 2 files c

Re: [PATCH for-9.2 6/6] hm/nvram/xlnx-versal-efuse-ctrl: Call register_finalize_block

2024-08-23 Thread Francisco Iglesias
55f225b0bfe1 in object_new qom/object.c:797:12 > #9 0x55f226309e0d in qmp_device_list_properties qom/qom-qmp-cmds.c:144:11 > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > include/hw/nvram/xlnx-versal-efuse.h | 1 + > hw/nvram/xlnx-versal-efuse-ct

Re: [PATCH 3/5] hw/net/can/xlnx-versal-canfd: Translate CAN ID registers

2024-08-23 Thread Francisco Iglesias
_frame for all of its ID registers. Correct this problem for > both RX and TX, including RX filtering. > > Signed-off-by: Doug Brown Reviewed-by: Francisco Iglesias > --- > hw/net/can/xlnx-versal-canfd.c | 53 -- > 1 file changed, 50 insertions

Re: [QEMU][PATCH 1/1] hw/net/can: Fix sorting of the tx queue

2024-05-30 Thread Francisco Iglesias
the tx queue" Reviewed-by: Francisco Iglesias BR, F > --- > hw/net/can/xlnx-versal-canfd.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/hw/net/can/xlnx-versal-canfd.c b/hw/net/can/xlnx-versal-canfd.c > index 47a14cfe63..5f083c21e9 100644 >

Re: [PATCH v3 1/3] hw/misc/zynq_slcr: Add boot-mode property

2024-06-21 Thread Francisco Iglesias
On Thu, Jun 20, 2024 at 04:11:37PM +0530, Sai Pavan Boddu wrote: > boot-mode property sets user values into BOOT_MODE register, on hardware > these are derived from board switches. > > Signed-off-by: Sai Pavan Boddu Reviewed-by: Francisco Iglesias > Reviewed-by: Edgar E. Iglesi

Re: [PATCH v3 3/3] docs/system/arm: Add a doc for zynq board

2024-06-21 Thread Francisco Iglesias
On Thu, Jun 20, 2024 at 04:11:39PM +0530, Sai Pavan Boddu wrote: > Added the supported device list and an example command. > > Signed-off-by: Sai Pavan Boddu Reviewed-by: Francisco Iglesias > Reviewed-by: Edgar E. Iglesias > --- > MAINTAINERS | 1 + >

Re: [PATCH v3 2/3] hw/arm/xilinx_zynq: Add boot-mode property

2024-06-21 Thread Francisco Iglesias
mc = MACHINE_CLASS(oc); > +ObjectProperty *prop; > mc->desc = "Xilinx Zynq Platform Baseboard for Cortex-A9"; > mc->init = zynq_init; > mc->max_cpus = ZYNQ_MAX_CPUS; > @@ -379,6 +404,12 @@ static void zynq_machine_class_init(ObjectCla

Re: [PATCH 4/5] hw/net/can/xlnx-versal-canfd: Fix byte ordering

2024-08-23 Thread Francisco Iglesias
both the TX and RX code to put the data in the correct order. > > Signed-off-by: Doug Brown Reviewed-by: Francisco Iglesias > --- > hw/net/can/xlnx-versal-canfd.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/net/can/xlnx-vers

Re: [PATCH 5/5] hw/net/can/xlnx-versal-canfd: Handle RX of short FD frames

2024-08-23 Thread Francisco Iglesias
On Fri, Aug 16, 2024 at 09:35:05AM -0700, Doug Brown wrote: > There was no case for handling received CAN FD frames with a DLC of 0-8. > This was already handled properly with TX. Add similar code for RX. > > Signed-off-by: Doug Brown Reviewed-by: Francisco Iglesias > --- >

Re: [PATCH v2 6/7] hw/net/can/xlnx-versal-canfd: Simplify DLC conversions

2024-09-04 Thread Francisco Iglesias
with a DLC of 0-8, which was broken previously. > > Signed-off-by: Doug Brown Reviewed-by: Francisco Iglesias > --- > hw/net/can/xlnx-versal-canfd.c | 67 ++ > 1 file changed, 4 insertions(+), 63 deletions(-) > > diff --git a/hw/net/can/xlnx-v

Re: [PATCH v2 0/7] hw/net/can/xlnx-versal-canfd: Miscellaneous fixes

2024-09-06 Thread Francisco Iglesias
Hi Peter, On Fri, Sep 06, 2024 at 03:36:10PM +0100, Peter Maydell wrote: > On Tue, 27 Aug 2024 at 04:51, Doug Brown wrote: > > > > This series fixes several problems I ran into while trying to simulate > > the AMD/Xilinx Versal CANFD controller in the xlnx-versal-virt machine > > using Xilinx's v

Re: [PATCH v2 7/7] hw/net/can/xlnx-versal-canfd: Fix FIFO issues

2024-09-06 Thread Francisco Iglesias
-off-by: Doug Brown Reviewed-by: Francisco Iglesias Thanks a lot for the fixes and sorry for the delayed review! Best regards, Francisco > --- > hw/net/can/xlnx-versal-canfd.c | 36 +++--- > 1 file changed, 3 insertions(+), 33 deletions(-) > > dif

[PATCH v1 2/3] MAINTAINERS: Update Xilinx Versal OSPI maintainer's email address

2024-09-06 Thread Francisco Iglesias
Update my xilinx.com email address to my amd.com address. Signed-off-by: Francisco Iglesias --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ad957ca5e8..b03952f43e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1055,7 +1055,7

[PATCH v1 3/3] MAINTAINERS: Add my-self as CAN maintainer

2024-09-06 Thread Francisco Iglesias
Signed-off-by: Francisco Iglesias --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b03952f43e..a320ce759c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2701,6 +2701,7 @@ F: include/hw/rx/ CAN bus subsystem and hardware M: Pavel Pisa +M

[PATCH v1 0/3] CAN & Xilinx OSPI maintainer updates

2024-09-06 Thread Francisco Iglesias
amd.com one on the Xilinx Versal OSPI maintaintership section. In the third I volunteer to replace Vikram as maintainer for the CAN bus subsystem. Best regards, Francisco Francisco Iglesias (3): MAINTAINERS: Remove Vikram Garhwal as maintainer MAINTAINERS: Update Xilinx Versal OSPI mai

[PATCH v1 1/3] MAINTAINERS: Remove Vikram Garhwal as maintainer

2024-09-06 Thread Francisco Iglesias
Vikram's email is bouncing, pause his maintainership until a new email is provided. Signed-off-by: Francisco Iglesias --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0c1bc69828..ad957ca5e8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1

Re: [PATCH v2 1/1] m25p80: Add SFDP table for mt35xu01g flash

2024-09-06 Thread Francisco Iglesias
On Thu, Aug 29, 2024 at 05:31:17PM +0530, Shiva sagar Myana wrote: > Add the SFDP table for the Micron Xccela mt35xu01g flash. > > Signed-off-by: Shiva sagar Myana Reviewed-by: Francisco Iglesias > --- > V1->V2: Change subject and commit message > > hw/block/m25p

Re: [PATCH] hw/block: m25p80: Add support for w25q01jvq

2022-03-07 Thread Francisco Iglesias
0, 1024, ER_4K) }, > +{ INFO("w25q01jvq", 0xef4021, 0, 64 << 10, 2048, ER_4K) }, Reviewed-by: Francisco Iglesias > }; > > typedef enum { > -- > 2.34.1 > >

Re: [PATCH] hw/dma/xlnx_csu_dma: Set TYPE_XLNX_CSU_DMA class_size

2022-03-08 Thread Francisco Iglesias
gt; #2 0x559a21bf3442 in object_class_foreach_tramp > /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/san/../../qom/object.c:1070:5 > > Fixes: 00f05c02f9e7342f ("hw/dma/xlnx_csu_dma: Support starting a read > transfer through a class method") > Signed-off-by: Peter Mayde

Re: [PATCH v2] hw: m25p80: Add Block Protect and Top Bottom bits for write protect

2022-07-07 Thread Francisco Iglesias
Hi Iris On [2022 Jul 06] Wed 19:16:26, Iris Chen wrote: > Signed-off-by: Iris Chen A couple of suggestions below if you would like to go for a v3 but otherwise: Reviewed-by: Francisco Iglesias Thanks, Best regards, Francisco Iglesias > --- > Addressing all comments. > In rep

Re: [PATCH v3] hw: m25p80: Add Block Protect and Top Bottom bits for write protect

2022-07-08 Thread Francisco Iglesias
On [2022 Jul 08] Fri 09:45:52, Iris Chen wrote: > Signed-off-by: Iris Chen Reviewed-by: Francisco Iglesias > --- > Cosmetic suggestions addressed. > > hw/block/m25p80.c | 102 -- > 1 file changed, 90 insertions(+), 12 deletions(

Re: [PATCH 1/3] hw/nvram: Fix Memory Leak in Xilinx eFuse QOM

2021-10-18 Thread Francisco Iglesias
On [2021 Oct 15] Fri 13:35:30, Tong Ho wrote: > Signed-off-by: Tong Ho Reviewed-by: Francisco Iglesias > --- > hw/nvram/xlnx-efuse.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/hw/nvram/xlnx-efuse.c b/hw/nvram/xlnx-efuse.c > index e

Re: [PATCH 2/3] hw/nvram: Fix Memory Leak in Xilinx Versal eFuse device

2021-10-18 Thread Francisco Iglesias
On [2021 Oct 15] Fri 13:35:31, Tong Ho wrote: > Signed-off-by: Tong Ho Reviewed-by: Francisco Iglesias > --- > hw/nvram/xlnx-versal-efuse-ctrl.c | 20 +++- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/hw/nvram/xlnx-versal-efuse-ctrl.c

Re: [PATCH 3/3] hw/nvram: Fix Memory Leak in Xilinx ZynqMP eFuse device

2021-10-18 Thread Francisco Iglesias
On [2021 Oct 15] Fri 13:35:32, Tong Ho wrote: > Signed-off-by: Tong Ho Reviewed-by: Francisco Iglesias > --- > hw/nvram/xlnx-zynqmp-efuse.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/hw/nvram/xlnx-zynqmp-efuse.c b/hw/nvram/x

Re: [PATCH v1 1/2] timer: cadence_ttc: Break out header file to allow embedding

2022-04-01 Thread Francisco Iglesias
On [2022 Apr 01] Fri 00:20:16, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Break out header file to allow embedding of the the TTC. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > incl

Re: [PATCH v1 2/2] hw/arm/xlnx-zynqmp: Connect 4 TTC timers

2022-04-01 Thread Francisco Iglesias
On [2022 Apr 01] Fri 00:20:17, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Connect the 4 TTC timers on the ZynqMP. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > include/hw/arm/xlnx-zynqmp.h | 4 >

Re: [PATCH 1/1] xlnx-bbram: hw/nvram: Fix uninitialized Error *

2022-04-04 Thread Francisco Iglesias
On [2022 Apr 01] Fri 12:06:31, Tong Ho wrote: > This adds required initialization of Error * variable. > > Signed-off-by: Tong Ho Reviewed-by: Francisco Iglesias > --- > hw/nvram/xlnx-bbram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw

Re: [PATCH] docs/system/devices/can.rst: correct links to CTU CAN FD IP core documentation.

2022-04-04 Thread Francisco Iglesias
On [2022 Apr 02] Sat 22:45:23, Pavel Pisa wrote: > Signed-off-by: Pavel Pisa Reviewed-by: Francisco Iglesias > --- > docs/system/devices/can.rst | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/docs/system/devices/can.rst b/docs/system/devic

Re: [PATCH v1 1/4] hw/arm: versal: Create an APU CPU Cluster

2022-04-07 Thread Francisco Iglesias
On Wed, Apr 06, 2022 at 06:43:00PM +0100, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Create an APU CPU Cluster. This is in preparation to add the RPU. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > h

Re: [PATCH v1 2/4] hw/arm: versal: Add the Cortex-R5Fs

2022-04-07 Thread Francisco Iglesias
On Wed, Apr 06, 2022 at 06:43:01PM +0100, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add the Cortex-R5Fs of the Versal RPU (Real-time Processing Unit) > subsystem. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- >

Re: [PATCH v1 3/4] hw/misc: Add a model of the Xilinx Versal CRL

2022-04-07 Thread Francisco Iglesias
On Wed, Apr 06, 2022 at 06:43:02PM +0100, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add a model of the Xilinx Versal CRL. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > hw/misc/meson.build | 1

Re: [PATCH v1 4/4] hw/arm: versal: Connect the CRL

2022-04-07 Thread Francisco Iglesias
On Wed, Apr 06, 2022 at 06:43:03PM +0100, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Connect the CRL (Clock Reset LPD) to the Versal SoC. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > hw

Re: [PATCH for-7.1 02/18] hw/intc/exynos4210_gic: Remove unused TYPE_EXYNOS4210_IRQ_GATE

2022-04-07 Thread Francisco Iglesias
On [2022 Apr 04] Mon 16:46:42, Peter Maydell wrote: > Now we have removed the only use of TYPE_EXYNOS4210_IRQ_GATE we can > delete the device entirely. > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > hw/intc/exyn

[RFC PATCH v1 1/1] include/hw/pci/pcie_host: Correct PCIE_MMCFG_BUS_MASK

2022-04-11 Thread Francisco Iglesias
According to [1] address bits 27 - 20 are mapped to the bus number (the TLPs bus number field is 8 bits). [1] PCI Express® Base Specification Revision 5.0 Version 1.0 Signed-off-by: Francisco Iglesias --- include/hw/pci/pcie_host.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [RFC PATCH v1 1/1] include/hw/pci/pcie_host: Correct PCIE_MMCFG_BUS_MASK

2022-04-11 Thread Francisco Iglesias
Hi Michael, On [2022 Apr 11] Mon 17:12:47, Michael S. Tsirkin wrote: > On Mon, Apr 11, 2022 at 09:38:18PM +0200, Francisco Iglesias wrote: > > According to [1] address bits 27 - 20 are mapped to the bus number (the > > TLPs bus number field is 8 bits). > > > > [1] PCI

[PATCH v2 0/2] Correct a couple of defines in pcie_host.h

2022-04-11 Thread Francisco Iglesias
Hi, This series attempts to correct a couple of defines inside pcie_host.h. Best regards, Francisco Iglesias Changelog: v1->v2: * Went from RFC to patch proposal * Added more meat on the commit message of patch 1 Francisco Iglesias (2): include/hw/pci/pcie_host: Corr

[PATCH v2 1/2] include/hw/pci/pcie_host: Correct PCIE_MMCFG_BUS_MASK

2022-04-11 Thread Francisco Iglesias
vision 5.0 Version 1.0 Signed-off-by: Francisco Iglesias --- include/hw/pci/pcie_host.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h index 076457b270..b3c8ce973c 100644 --- a/include/hw/pci/pcie_host.h +++ b/incl

[PATCH v2 2/2] include/hw/pci/pcie_host: Correct PCIE_MMCFG_SIZE_MAX

2022-04-11 Thread Francisco Iglesias
found in PPC440 core SoCs")). [1] PCI Express® Base Specification Revision 5.0 Version 1.0 Signed-off-by: Francisco Iglesias --- include/hw/pci/pcie_host.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h index b3c

[PATCH v1 1/1] hw/arm/xlnx-zynqmp: Connect ZynqMP's USB controllers

2022-09-20 Thread Francisco Iglesias
From: Francisco Iglesias Connect ZynqMP's USB controllers. Signed-off-by: Francisco Iglesias --- hw/arm/xlnx-zynqmp.c | 36 include/hw/arm/xlnx-zynqmp.h | 3 +++ 2 files changed, 39 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm

Re: [PATCH v3 3/8] m25p80: Add the mx25l25635e SFPD table

2022-10-07 Thread Francisco Iglesias
27;extern' in above hdr if we like (also the other patches), either way: Reviewed-by: Francisco Iglesias > + > + > #endif > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index 13e7b28fd2b0..028b026d8ba2 100644 > --- a/hw/block/m25p80.c > +++ b/hw/block/m25p80

Re: [PATCH v3 8/8] arm/aspeed: Replace mx25l25635e chip model

2022-10-07 Thread Francisco Iglesias
On [2022 Jul 22] Fri 08:36:02, Cédric Le Goater wrote: > A mx25l25635f chip model is generally found on these machines. It's > newer and uses 4B opcodes which is better to exercise the support in > the Linux kernel. > > Signed-off-by: Cédric Le Goater Reviewed-by

Re: [PATCH v3 4/8] m25p80: Add the mx25l25635f SFPD table

2022-10-07 Thread Francisco Iglesias
27;ve found so might be that you can switch to just INFO and _ext_id 0 above (might be the same in the previous patch with the similar flash). Otherwise looks good to me: Reviewed-by: Francisco Iglesias > + .sfdp_read = m25p80_sfdp_mx25l25635f }, > { INFO("mx25l25655e", 0xc

Re: [PATCH v3 5/8] m25p80: Add the mx66l1g45g SFDP table

2022-10-07 Thread Francisco Iglesias
nt8_t m25p80_sfdp_mx66l1g45g(uint32_t addr); (optional -extern) Reviewed-by: Francisco Iglesias > > #endif > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index 6b120ce65212..52df24d24751 100644 > --- a/hw/block/m25p80.c > +++ b/hw/block/m25p80.c > @@ -240,7 +240,8 @@

Re: [PATCH v3 2/8] m25p80: Add the n25q256a SFDP table

2022-10-07 Thread Francisco Iglesias
"qemu/osdep.h" > +#include "qemu/host-utils.h" > +#include "m25p80_sfdp.h" > + > +#define define_sfdp_read(model) \ > +uint8_t m25p80_sfdp_##model(uint32_t addr)\ > +{

Re: [PATCH v3 7/8] m25p80: Add the w25q512jv SFPD table

2022-10-07 Thread Francisco Iglesias
tern uint8_t m25p80_sfdp_w25q512jv(uint32_t addr); (optional -extern) Reviewed-by: Francisco Iglesias > > #endif > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index 220dbc8fb327..8ba9d732a323 100644 > --- a/hw/block/m25p80.c > +++ b/hw/block/m25p80.c > @@ -347,7

Re: [PATCH v3 6/8] m25p80: Add the w25q256 SFPD table

2022-10-07 Thread Francisco Iglesias
b/hw/block/m25p80_sfdp.h > @@ -21,4 +21,6 @@ extern uint8_t m25p80_sfdp_mx25l25635e(uint32_t addr); > extern uint8_t m25p80_sfdp_mx25l25635f(uint32_t addr); > extern uint8_t m25p80_sfdp_mx66l1g45g(uint32_t addr); > > +extern uint8_t m25p80_sfdp_w25q256(uint32_t addr); (optional

Re: [PATCH] m25p80: Add the w25q01jvq SFPD table

2022-10-07 Thread Francisco Iglesias
a2fc..8fb1cd3f8a 100644 > --- a/hw/block/m25p80_sfdp.h > +++ b/hw/block/m25p80_sfdp.h > @@ -24,4 +24,6 @@ extern uint8_t m25p80_sfdp_mx66l1g45g(uint32_t addr); > extern uint8_t m25p80_sfdp_w25q256(uint32_t addr); > extern uint8_t m25p80_sfdp_w25q512jv(uint32_t addr); > > +extern uint8_t m25p80_sfdp_w25q01jvq(uint32_t addr); (optional -extern) Reviewed-by: Francisco Iglesias > + > #endif > -- > 2.35.1 >

Re: [PATCH v3 4/8] m25p80: Add the mx25l25635f SFPD table

2022-10-10 Thread Francisco Iglesias
Hi Cedric, On [2022 Oct 10] Mon 11:58:40, Michael Walle wrote: > Am 2022-10-10 08:23, schrieb Cédric Le Goater: > > On 10/7/22 16:44, Francisco Iglesias wrote: > > > > > --- a/hw/block/m25p80.c > > > > +++ b/hw/block/m25p80.c > > > > @@ -234,6 +2

Re: [PATCH v4 03/10] m25p80: Add erase size for mx25l25635e

2022-10-14 Thread Francisco Iglesias
On [2022 Oct 13] Thu 18:12:34, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater Reviewed-by: Francisco Iglesias > --- > hw/block/m25p80.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c &g

Re: [PATCH v3 04/10] hw/dma: Add the DMA control interface

2021-12-01 Thread Francisco Iglesias
On [2021 Nov 29] Mon 17:44:37, Peter Maydell wrote: > On Wed, 24 Nov 2021 at 10:16, Francisco Iglesias > wrote: > > > > Add an interface for controlling DMA models that are reused with other > > models. This allows a controlling model to start transfers through the > &g

[PATCH v4 05/11] hw/dma/xlnx_csu_dma: Implement the DMA control interface

2021-12-01 Thread Francisco Iglesias
Implement the DMA control interface for allowing direct control of DMA operations from inside peripheral models embedding (and reusing) the Xilinx CSU DMA. Signed-off-by: Francisco Iglesias --- hw/dma/xlnx_csu_dma.c | 32 include/hw/dma/xlnx_csu_dma.h

[PATCH v4 02/11] hw/arm/xlnx-versal: Connect Versal's PMC SLCR

2021-12-01 Thread Francisco Iglesias
Connect Versal's PMC SLCR (system-level control registers) model. Signed-off-by: Francisco Iglesias --- hw/arm/xlnx-versal.c | 17 + include/hw/arm/xlnx-versal.h | 6 ++ 2 files changed, 23 insertions(+) diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-ver

[PATCH v4 06/11] hw/ssi: Add a model of Xilinx Versal's OSPI flash memory controller

2021-12-01 Thread Francisco Iglesias
Add a model of Xilinx Versal's OSPI flash memory controller. Signed-off-by: Francisco Iglesias --- hw/ssi/meson.build|1 + hw/ssi/xlnx-versal-ospi.c | 1892 + include/hw/ssi/xlnx-versal-ospi.h | 86 ++ 3 files changed,

[PATCH v4 08/11] hw/block/m25p80: Add support for Micron Xccela flash mt35xu01g

2021-12-01 Thread Francisco Iglesias
Add support for Micron Xccela flash mt35xu01g. Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- hw/block/m25p80.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index b77503dc84..c6bf3c6bfa 100644 --- a/hw/block/m25p80.c +++ b/hw

[PATCH v4 01/11] hw/misc: Add a model of Versal's PMC SLCR

2021-12-01 Thread Francisco Iglesias
Add a model of Versal's PMC SLCR (system-level control registers). Signed-off-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias Acked-by: Edgar E. Iglesias --- hw/misc/meson.build|5 +- hw/misc/xlnx-versal-pmc-iou-slcr.c |

[PATCH v4 03/11] include/hw/dma/xlnx_csu_dma: Add in missing includes in the header

2021-12-01 Thread Francisco Iglesias
Add in the missing includes in the header for being able to build the DMA model when reusing it. Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- include/hw/dma/xlnx_csu_dma.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/hw/dma/xlnx_csu_dma.h b/include/hw

[PATCH v4 07/11] hw/arm/xlnx-versal: Connect the OSPI flash memory controller model

2021-12-01 Thread Francisco Iglesias
Connect the OSPI flash memory controller model (including the source and destination DMA). Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- hw/arm/xlnx-versal.c | 88 include/hw/arm/xlnx-versal.h | 20 ++ 2 files

[PATCH v4 09/11] hw/arm/xlnx-versal-virt: Connect mt35xu01g flashes to the OSPI

2021-12-01 Thread Francisco Iglesias
Connect Micron Xccela mt35xu01g flashes to the OSPI flash memory controller. Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- hw/arm/xlnx-versal-virt.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx

[PATCH v4 04/11] hw/dma: Add the DMA control interface

2021-12-01 Thread Francisco Iglesias
completion signaling will be read and catched through the DMA engine model's register API and signaling. Signed-off-by: Francisco Iglesias --- hw/dma/dma-ctrl-if.c | 31 +++ hw/dma/meson.build | 1 + include/hw/dma/dma

[PATCH v4 10/11] MAINTAINERS: Add an entry for Xilinx Versal OSPI

2021-12-01 Thread Francisco Iglesias
List myself as maintainer for the Xilinx Versal OSPI controller. Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7543eb4d59..e52cc94840 100644 --- a/MAINTAINERS +++ b

[PATCH v4 11/11] docs/devel: Add documentation for the DMA control interface

2021-12-01 Thread Francisco Iglesias
Also, since being the author, list myself as maintainer for the file. Signed-off-by: Francisco Iglesias --- MAINTAINERS| 1 + docs/devel/dma-ctrl-if.rst | 320 + docs/devel/index.rst | 1 + 3 files changed, 322 insertions

[PATCH v4 00/11] Xilinx Versal's PMC SLCR and OSPI support

2021-12-01 Thread Francisco Iglesias
a model of Versal's OSPI controller is added and connected to the Versal virt machine. The series then ends with adding initial support for the Micron Xccelera mt35xu01g flash and flashes of this type are connected to the OSPI in the Versal virt machine. Best regards, Francisco Iglesias Chan

Re: [PATCH v4 01/11] hw/misc: Add a model of Versal's PMC SLCR

2021-12-14 Thread Francisco Iglesias
On Fri, Dec 10, 2021 at 03:11:41PM +, Peter Maydell wrote: > On Wed, 1 Dec 2021 at 15:40, Francisco Iglesias > wrote: > > > > Add a model of Versal's PMC SLCR (system-level control registers). > > > > Signed-off-by: Francisco Iglesias > > Signed-off-b

Re: [PATCH v4 02/11] hw/arm/xlnx-versal: Connect Versal's PMC SLCR

2021-12-14 Thread Francisco Iglesias
On Fri, Dec 10, 2021 at 03:16:59PM +, Peter Maydell wrote: > On Wed, 1 Dec 2021 at 15:40, Francisco Iglesias > wrote: > > > > Connect Versal's PMC SLCR (system-level control registers) model. > > > > Signed-off-by: Francisco Iglesias > > diff --git a/

[PATCH v5 02/12] hw/arm/xlnx-versal: 'Or' the interrupts from the BBRAM and RTC models

2021-12-14 Thread Francisco Iglesias
Add an orgate and 'or' the interrupts from the BBRAM and RTC models. Signed-off-by: Francisco Iglesias --- hw/arm/xlnx-versal-virt.c| 2 +- hw/arm/xlnx-versal.c | 28 ++-- include/hw/arm/xlnx-versal.h | 5 +++-- 3 files changed, 30 insert

Re: [PATCH v4 06/11] hw/ssi: Add a model of Xilinx Versal's OSPI flash memory controller

2021-12-14 Thread Francisco Iglesias
On Fri, Dec 10, 2021 at 04:02:22PM +, Peter Maydell wrote: > On Wed, 1 Dec 2021 at 15:40, Francisco Iglesias > wrote: > > > > Add a model of Xilinx Versal's OSPI flash memory controller. > > > > Signed-off-by: Francisco Iglesias > > >

[PATCH v5 09/12] hw/block/m25p80: Add support for Micron Xccela flash mt35xu01g

2021-12-14 Thread Francisco Iglesias
Add support for Micron Xccela flash mt35xu01g. Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- hw/block/m25p80.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index b77503dc84..c6bf3c6bfa 100644 --- a/hw/block/m25p80.c +++ b/hw

[PATCH v5 01/12] hw/misc: Add a model of Versal's PMC SLCR

2021-12-14 Thread Francisco Iglesias
Add a model of Versal's PMC SLCR (system-level control registers). Signed-off-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias --- hw/misc/meson.build|5 +- hw/misc/xlnx-versal-pmc-iou-slcr.c | 1446 include/hw/misc

[PATCH v5 00/12] Xilinx Versal's PMC SLCR and OSPI support

2021-12-14 Thread Francisco Iglesias
a model of Versal's OSPI controller is added and connected to the Versal virt machine. The series then ends with adding initial support for the Micron Xccelera mt35xu01g flash and flashes of this type are connected to the OSPI in the Versal virt machine. Best regards, Francisco Iglesias Chan

[PATCH v5 10/12] hw/arm/xlnx-versal-virt: Connect mt35xu01g flashes to the OSPI

2021-12-14 Thread Francisco Iglesias
Connect Micron Xccela mt35xu01g flashes to the OSPI flash memory controller. Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias Reviewed-by: Peter Maydell --- hw/arm/xlnx-versal-virt.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/arm/xlnx

[PATCH v5 05/12] hw/dma: Add the DMA control interface

2021-12-14 Thread Francisco Iglesias
completion signaling will be read and caught through the DMA engine model's register API and signaling. Signed-off-by: Francisco Iglesias --- hw/dma/dma-ctrl-if.c | 30 ++ hw/dma/meson.build | 1 + include/hw/dma/dma

[PATCH v5 07/12] hw/ssi: Add a model of Xilinx Versal's OSPI flash memory controller

2021-12-14 Thread Francisco Iglesias
Add a model of Xilinx Versal's OSPI flash memory controller. Signed-off-by: Francisco Iglesias --- hw/ssi/meson.build|1 + hw/ssi/xlnx-versal-ospi.c | 1855 + include/hw/ssi/xlnx-versal-ospi.h | 111 +++ 3 files changed,

[PATCH v5 03/12] hw/arm/xlnx-versal: Connect Versal's PMC SLCR

2021-12-14 Thread Francisco Iglesias
Connect Versal's PMC SLCR (system-level control registers) model. Signed-off-by: Francisco Iglesias --- hw/arm/xlnx-versal.c | 71 +++- include/hw/arm/xlnx-versal.h | 5 2 files changed, 75 insertions(+), 1 deletion(-) diff --git a/h

[PATCH v5 12/12] docs/devel: Add documentation for the DMA control interface

2021-12-14 Thread Francisco Iglesias
Also, since being the author, list myself as maintainer for the file. Signed-off-by: Francisco Iglesias --- MAINTAINERS| 1 + docs/devel/dma-ctrl-if.rst | 234 + docs/devel/index.rst | 1 + 3 files changed, 236 insertions

[PATCH v5 04/12] include/hw/dma/xlnx_csu_dma: Add in missing includes in the header

2021-12-14 Thread Francisco Iglesias
Add in the missing includes in the header for being able to build the DMA model when reusing it. Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- include/hw/dma/xlnx_csu_dma.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/hw/dma/xlnx_csu_dma.h b/include/hw

[PATCH v5 06/12] hw/dma/xlnx_csu_dma: Implement the DMA control interface

2021-12-14 Thread Francisco Iglesias
Implement the DMA control interface for allowing direct control of DMA operations from inside peripheral models embedding (and reusing) the Xilinx CSU DMA. Signed-off-by: Francisco Iglesias --- hw/dma/xlnx_csu_dma.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/hw/dma

[PATCH v5 11/12] MAINTAINERS: Add an entry for Xilinx Versal OSPI

2021-12-14 Thread Francisco Iglesias
List myself as maintainer for the Xilinx Versal OSPI controller. Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias Reviewed-by: Peter Maydell --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7543eb4d59..e52cc94840 100644

[PATCH v5 08/12] hw/arm/xlnx-versal: Connect the OSPI flash memory controller model

2021-12-14 Thread Francisco Iglesias
Connect the OSPI flash memory controller model (including the source and destination DMA). Signed-off-by: Francisco Iglesias --- hw/arm/xlnx-versal.c | 93 include/hw/arm/xlnx-versal.h | 20 ++ 2 files changed, 113 insertions(+) diff

Re: [PATCH v4 11/11] docs/devel: Add documentation for the DMA control interface

2021-12-14 Thread Francisco Iglesias
On Fri, Dec 10, 2021 at 12:21:26PM +, Peter Maydell wrote: > On Wed, 1 Dec 2021 at 15:41, Francisco Iglesias > wrote: > > > > Also, since being the author, list myself as maintainer for the file. > > > > Signed-off-by: Francisco Iglesias > > --- &

<    1   2   3   4   5   6   >