Hi,
After I hotplug a pci device to a pci2pci bridge (I use "pci.1") with
machine type 1.7 or older,
I can not see the pci device via `lspci` in the guest, but can see it
via `info qtree` in the hmp.
What's more, after I reboot the guest or hotplug another pci device to
pci.0, I can see the
p
On 01/29/2018 09:33 PM, Igor Mammedov wrote:
On Thu, 25 Jan 2018 16:01:39 +0800
Fei Li wrote:
Hi,
After I hotplug a pci device to a pci2pci bridge (I use "pci.1") with
machine type 1.7 or older,
I can not see the pci device via `lspci` in the guest, but can see it
via `info qtr
Hi Juan,
Kindly ping again. :)
Have a nice day, thanks
Fei
On 11/12/2018 12:43 PM, Fei Li wrote:
Hi Juan,
Kindly ping, as this multifd migration topic needs your suggestions. :)
Have a nice day, thanks
Fei
On 11/03/2018 12:33 AM, Dr. David Alan Gilbert wrote:
* Peter Xu (pet...@redhat.com
On 11/30/2018 11:45 AM, Fei Li wrote:
On 11/29/2018 10:46 PM, Philippe Mathieu-Daudé wrote:
Hi Fei,
On 29/11/18 11:03, Fei Li wrote:
In our current code, when multifd is used during migration, if there
is an error before the destination receives all new channels, the
source keeps running
let users decide whether
to quit from the destination side when failing to receive packet via
some channel.
Cc: Dr. David Alan Gilbert
Signed-off-by: Fei Li
Reviewed-by: Peter Xu
---
migration/channel.c | 11 ++-
migration/migration.c | 9 +++--
migration/migration.h | 2
_init_vcpu() to propagate the error and let
the further callers check it.
Besides, make qemu_init_vcpu() return a Boolean value to let its
callers know whether it succeeds.
Cc: Paolo Bonzini
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
Reviewed-by: Juan Quintela
---
accel/tcg/user-exec-stub.c
caller.
Fixes: 2f78e491d7b46542158ce0b8132ee4e05bc0ade4
Cc: Paolo Bonzini
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
Reviewed-by: Markus Armbruster
---
util/main-loop.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/main-loop.c b/util/main-loop.c
index affe0403c5
- Merge v1's last two patches into one to avoid the compile error
- Fix one omitted error in patch1 and update some error messages
Fei Li (7):
Fix segmentation fault when qemu_signal_init fails
qemu_init_vcpu: add a new Error parameter to propagate
migration: fix the multifd code when rec
f-by: Fei Li
Reviewed-by: Juan Quintela
---
migration/migration.c | 5 +
migration/ram.c | 11 ---
migration/ram.h | 2 +-
3 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 72106bddf0..0537fc0c26 100644
-
Call postcopy_ram_incoming_cleanup() to do the cleanup when
postcopy_ram_enable_notify fails. Besides, report the error
message when qemu_ram_foreach_migratable_block() fails.
Cc: Dr. David Alan Gilbert
Signed-off-by: Fei Li
Reviewed-by: Dr. David Alan Gilbert
---
migration/postcopy-ram.c | 1
Make qemu_thread_create() return a Boolean to indicate if it succeeds
rather than failing with an error. And add an Error parameter to hold
the error message and let the callers handle it.
Cc: Markus Armbruster
Cc: Daniel P. Berrangé
Cc: Dr. David Alan Gilbert
Signed-off-by: Fei Li
To avoid the segmentation fault in qemu_thread_join(), just directly
return when the QemuThread *thread failed to be created in either
qemu-thread-posix.c or qemu-thread-win32.c.
Cc: Stefan Weil
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
util/qemu-thread-posix.c | 3 +++
util/qemu
On 11/05/2018 09:59 PM, Juan Quintela wrote:
Fei Li wrote:
Always call migrate_set_error() to set the error state without relying
on whether multifd_save_cleanup() succeeds. As the passed &local_err
is never used in multifd_save_cleanup(), remove it.
Error is not used, you are right.
Hi,
On 11/05/2018 09:32 PM, Juan Quintela wrote:
Fei Li wrote:
When qemu_signal_init() fails in qemu_init_main_loop(), we return
without setting an error. Its callers crash then when they try to
report the error with error_report_err().
To avoid such segmentation fault, add a new Error
On 11/02/2018 10:46 AM, Peter Xu wrote:
On Thu, Nov 01, 2018 at 06:17:12PM +0800, Fei Li wrote:
[...]
@@ -1339,7 +1339,7 @@ bool multifd_recv_all_channels_created(void)
}
/* Return true if multifd is ready for the migration, otherwise false */
-bool multifd_recv_new_channel
On 11/05/2018 09:53 PM, Juan Quintela wrote:
Fei Li wrote:
Make qemu_thread_create() return a Boolean to indicate if it succeeds
rather than failing with an error. And add an Error parameter to hold
the error message and let the callers handle it.
Nice work, thanks.
Signed-off-by: Fei
Hi Juan,
Kindly ping, as this multifd migration topic needs your suggestions. :)
Have a nice day, thanks
Fei
On 11/03/2018 12:33 AM, Dr. David Alan Gilbert wrote:
* Peter Xu (pet...@redhat.com) wrote:
On Fri, Nov 02, 2018 at 11:00:24AM +0800, Fei Li wrote:
On 11/02/2018 10:37 AM, Peter Xu
error_propagate
- Return a bool: false/true to indicate if one function succeeds
- Merge v1's last two patches into one to avoid the compile error
- Fix one omitted error in patch1 and update some error messages
Fei Li (7):
Fix segmentation fault when qemu_signal_init fails
u
succeeds.
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
accel/tcg/user-exec-stub.c | 2 +-
cpus.c | 34 +-
include/qom/cpu.h | 2 +-
target/alpha/cpu.c | 4 +++-
target/arm/cpu.c| 4
;c) is not
initialized, there is no need to close the channel. Or else a
segmentation fault will occur in multifd_recv_terminate_threads()
when multifd_recv_initial_packet() fails.
Signed-off-by: Fei Li
---
migration/ram.c | 22 --
1 file changed, 16 insertions(+), 6 del
ate the err to the final caller.
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
include/qemu/osdep.h | 2 +-
util/compatfd.c | 9 ++---
util/main-loop.c | 9 -
3 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
in
Make qemu_thread_create() return a Boolean to indicate if it succeeds
rather than failing with an error. And add an Error parameter to hold
the error message and let the callers handle it.
Signed-off-by: Fei Li
---
cpus.c | 45
Add error handling for qemu_ram_foreach_migratable_block() when
it fails.
Always call migrate_set_error() to set the error state without relying
on whether multifd_save_cleanup() succeeds. As the passed &local_err
is never used in multifd_save_cleanup(), remove it.
Signed-off-by: Fe
.
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
include/ui/console.h | 2 +-
ui/vnc-jobs.c| 9 ++---
ui/vnc-jobs.h| 2 +-
ui/vnc.c | 12 +---
4 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/include/ui/console.h b/include/ui/console.h
index
To avoid the segmentation fault in qemu_thread_join(), just directly
return when the QemuThread *thread failed to be created in either
qemu-thread-posix.c or qemu-thread-win32.c.
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
util/qemu-thread-posix.c | 3 +++
util/qemu-thread-win32.c | 2
On 10/11/2018 06:02 PM, Markus Armbruster wrote:
Fei Li writes:
Currently, when qemu_signal_init() fails it only returns a non-zero
value but without propagating any Error. But its callers need a
non-null err when runs error_report_err(err), or else 0->msg occurs.
The bug is
On 10/11/2018 09:13 PM, Markus Armbruster wrote:
Fei Li writes:
Add a new Error parameter for vnc_display_init() to handle errors
in its caller: vnc_init_func(), just like vnc_display_open() does.
And let the call trace propagate the Error.
Besides, make vnc_start_worker_thread() return a
On 10/11/2018 09:19 PM, Markus Armbruster wrote:
Fei Li writes:
The caller of qemu_init_vcpu() already passed the **errp to handle
Which caller? There are many. Or do you mean "The callers"?
Oh, sorry, I mean "The callers" :)
errors. In view of this, add a new Er
On 10/11/2018 09:45 PM, Markus Armbruster wrote:
Fei Li writes:
Make qemu_thread_create() return a Boolean to indicate if it succeeds
rather than failing with an error. And add an Error parameter to hold
the error message and let the callers handle it.
Signed-off-by: Fei Li
On 10/12/2018 03:56 PM, Markus Armbruster wrote:
Fei Li writes:
On 10/11/2018 06:02 PM, Markus Armbruster wrote:
Fei Li writes:
Currently, when qemu_signal_init() fails it only returns a non-zero
value but without propagating any Error. But its callers need a
non-null err when runs
On 10/12/2018 04:18 PM, Markus Armbruster wrote:
Fei Li writes:
On 10/11/2018 09:13 PM, Markus Armbruster wrote:
Fei Li writes:
Add a new Error parameter for vnc_display_init() to handle errors
in its caller: vnc_init_func(), just like vnc_display_open() does.
And let the call trace
On 10/12/2018 04:24 PM, Markus Armbruster wrote:
Fei Li writes:
On 10/11/2018 09:19 PM, Markus Armbruster wrote:
Fei Li writes:
The caller of qemu_init_vcpu() already passed the **errp to handle
Which caller? There are many. Or do you mean "The callers"?
Oh, sorry, I
On 10/12/2018 06:23 PM, Fei Li wrote:
On 10/12/2018 04:18 PM, Markus Armbruster wrote:
Fei Li writes:
On 10/11/2018 09:13 PM, Markus Armbruster wrote:
Fei Li writes:
Add a new Error parameter for vnc_display_init() to handle errors
in its caller: vnc_init_func(), just like
Add a new Error parameter for vnc_display_init() to handle errors
in its caller: vnc_init_func(), just like vnc_display_open() does.
And let its callees propagate the Error, like init_keyboard_layout().
Signed-off-by: Fei Li
---
include/ui/console.h | 2 +-
ui/curses.c | 4 +++-
ui
On 10/12/2018 07:50 PM, Fei Li wrote:
Add a new Error parameter for vnc_display_init() to handle errors
in its caller: vnc_init_func(), just like vnc_display_open() does.
And let its callees propagate the Error, like init_keyboard_layout().
Signed-off-by: Fei Li
As this version do a big
On 10/15/2018 03:58 PM, Markus Armbruster wrote:
Fei Li writes:
Add a new Error parameter for vnc_display_init() to handle errors
in its caller: vnc_init_func(), just like vnc_display_open() does.
And let its callees propagate the Error, like init_keyboard_layout().
Signed-off-by: Fei Li
On 10/15/2018 07:53 PM, Markus Armbruster wrote:
Calling error_report() in a function that takes an Error ** argument
is suspicious. vnc_init_func() does that, and then fails without
setting an error. Its caller main(), via qemu_opts_foreach(), is fine
with it, but clean it up anyway.
Cc: G
Sorry for the late reply! Omitted this one..
On 10/12/2018 09:26 PM, Markus Armbruster wrote:
Fei Li writes:
On 10/12/2018 03:56 PM, Markus Armbruster wrote:
Fei Li writes:
On 10/11/2018 06:02 PM, Markus Armbruster wrote:
Fei Li writes:
Currently, when qemu_signal_init() fails it
Kindly ping. :)
Main discuss whether adding the Error for qemu_thread_create() or not.
For details, please see blow:
On 10/17/2018 04:17 PM, Fei Li wrote:
Sorry for the late reply! Omitted this one..
On 10/12/2018 09:26 PM, Markus Armbruster wrote:
Fei Li writes:
On 10/12/2018 03:56 PM
ut after closing the window by clicking, the qemu on the dest still
hangs there until I exclusively kill the qemu on the source.
The source host keeps running as expected, but I guess the hang
phenonmenon in the dest is not right.
Would someone kindly give some suggestions on this? Thanks a lot.
Fei
;c) is not
initialized, there is no need to close the channel. Or else a
segmentation fault will occur in multifd_recv_terminate_threads()
when multifd_recv_initial_packet() fails.
Signed-off-by: Fei Li
---
migration/ram.c | 26 --
1 file changed, 20 insertions(+), 6 del
Add error handling for qemu_ram_foreach_migratable_block() when
it fails.
Always call migrate_set_error() to set the error state without relying
on whether multifd_save_cleanup() succeeds. As the passed &local_err
is never used in multifd_save_cleanup(), remove it.
Signed-off-by: Fe
On 10/25/2018 05:27 AM, Peter Xu wrote:
On Mon, Oct 22, 2018 at 07:08:52PM +0800, Fei Li wrote:
Hi,
these two patches are to fix live migration issues. The first is
about multifd, and the second is to fix some error handling.
But I have a question about using multifd migration.
In our
On 10/25/2018 08:55 PM, Dr. David Alan Gilbert wrote:
* Fei Li (f...@suse.com) wrote:
Hi,
these two patches are to fix live migration issues. The first is
about multifd, and the second is to fix some error handling.
But I have a question about using multifd migration.
In our current code
On 10/25/2018 08:58 PM, Peter Xu wrote:
On Thu, Oct 25, 2018 at 05:04:00PM +0800, Fei Li wrote:
[...]
@@ -1325,22 +1325,24 @@ bool multifd_recv_all_channels_created(void)
/* Return true if multifd is ready for the migration, otherwise false */
bool multifd_recv_new_channel(QIOChannel
On 10/26/2018 11:24 PM, Dr. David Alan Gilbert wrote:
* Peter Xu (pet...@redhat.com) wrote:
On Fri, Oct 26, 2018 at 09:10:19PM +0800, Fei Li wrote:
On 10/25/2018 08:58 PM, Peter Xu wrote:
On Thu, Oct 25, 2018 at 05:04:00PM +0800, Fei Li wrote:
[...]
@@ -1325,22 +1325,24 @@ bool
when it fails to receive
packet via some channel.
Cc: Dr. David Alan Gilbert
Cc: Peter Xu
Signed-off-by: Fei Li
---
migration/channel.c | 7 ++-
migration/migration.c | 9 +++--
migration/migration.h | 2 +-
migration/ram.c | 17 ++---
migration/ram.h | 2
caller.
Cc: Markus Armbruster
Cc: Fam Zheng
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
util/main-loop.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/main-loop.c b/util/main-loop.c
index affe0403c5..443cb4cfe8 100644
--- a/util/main-loop.c
+++ b/util/main
s
- Merge v1's last two patches into one to avoid the compile error
- Fix one omitted error in patch1 and update some error messages
Fei Li (7):
Fix segmentation fault when qemu_signal_init fails
qemu_init_vcpu: add a new Error parameter to propagate
qemu_thread_join: fix segmentation fau
)
when multifd_recv_initial_packet() fails.
Signed-off-by: Fei Li
---
migration/ram.c | 28 +---
1 file changed, 21 insertions(+), 7 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 7e7deec4d8..4db3b3e8f4 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -907,6 +907,11 @@
_init_vcpu() to propagate the error and let
the further callers check it.
Besides, make qemu_init_vcpu() return a Boolean value to let its
callers know whether it succeeds.
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
accel/tcg/user-exec-stub.c | 3 ++-
cpus.c
Add error handling for qemu_ram_foreach_migratable_block() when
it fails.
Always call migrate_set_error() to set the error state without relying
on whether multifd_save_cleanup() succeeds. As the passed &local_err
is never used in multifd_save_cleanup(), remove it.
Signed-off-by: Fe
To avoid the segmentation fault in qemu_thread_join(), just directly
return when the QemuThread *thread failed to be created in either
qemu-thread-posix.c or qemu-thread-win32.c.
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
util/qemu-thread-posix.c | 3 +++
util/qemu-thread-win32.c | 2
Make qemu_thread_create() return a Boolean to indicate if it succeeds
rather than failing with an error. And add an Error parameter to hold
the error message and let the callers handle it.
Signed-off-by: Fei Li
---
cpus.c | 45 ++-
dump.c
On 10/30/2018 02:05 PM, Peter Xu wrote:
On Mon, Oct 29, 2018 at 08:58:16PM +0800, Fei Li wrote:
In our current code, when multifd is used during migration, if there
is an error before the destination receives all new channels, the
source keeps running, however the destination does not exit
On 10/31/2018 03:49 AM, Dr. David Alan Gilbert wrote:
* Fei Li (f...@suse.com) wrote:
Add error handling for qemu_ram_foreach_migratable_block() when
it fails.
Always call migrate_set_error() to set the error state without relying
on whether multifd_save_cleanup() succeeds. As the passed
On 10/31/2018 06:18 AM, Peter Xu wrote:
On Tue, Oct 30, 2018 at 06:05:18PM +0800, Fei Li wrote:
[...]
@@ -1366,6 +1373,10 @@ bool multifd_recv_new_channel(QIOChannel *ioc)
QEMU_THREAD_JOINABLE);
atomic_inc(&multifd_recv_state->count);
this does not bother you too much. ;)
Have a nice day, thanks again
Fei
On 10/29/2018 08:58 PM, Fei Li wrote:
In our current code, when multifd is used during migration, if there
is an error before the destination receives all new channels, the
source keeps running, however the destination does n
On 11/01/2018 12:30 AM, Dr. David Alan Gilbert wrote:
* Fei Li (f...@suse.com) wrote:
On 10/31/2018 03:49 AM, Dr. David Alan Gilbert wrote:
* Fei Li (f...@suse.com) wrote:
Add error handling for qemu_ram_foreach_migratable_block() when
it fails.
Always call migrate_set_error() to set the
Set the migration state to "failed" instead of "setup" when failing
to send packet via some channel.
Cc: Peter Xu
Signed-off-by: Fei Li
---
migration/ram.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
index 4db3b3e8f4..c84
_init_vcpu() to propagate the error and let
the further callers check it.
Besides, make qemu_init_vcpu() return a Boolean value to let its
callers know whether it succeeds.
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
accel/tcg/user-exec-stub.c | 3 ++-
cpus.c
To avoid the segmentation fault in qemu_thread_join(), just directly
return when the QemuThread *thread failed to be created in either
qemu-thread-posix.c or qemu-thread-win32.c.
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
util/qemu-thread-posix.c | 3 +++
util/qemu-thread-win32.c | 2
caller.
Cc: Markus Armbruster
Cc: Fam Zheng
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
util/main-loop.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/main-loop.c b/util/main-loop.c
index affe0403c5..443cb4cfe8 100644
--- a/util/main-loop.c
+++ b/util/main
let users decide whether
to quit from the destination side when failing to receive packet via
some channel.
Cc: Dr. David Alan Gilbert
Cc: Peter Xu
Signed-off-by: Fei Li
---
migration/channel.c | 11 ++-
migration/migration.c | 9 +++--
migration/migration.h | 2 +-
migration
Always call migrate_set_error() to set the error state without relying
on whether multifd_save_cleanup() succeeds. As the passed &local_err
is never used in multifd_save_cleanup(), remove it.
Cc: Dr. David Alan Gilbert
Signed-off-by: Fei Li
---
migration/migration.c | 5 +
migration/r
)
when multifd_recv_initial_packet() fails.
Signed-off-by: Fei Li
---
migration/ram.c | 28 +---
1 file changed, 21 insertions(+), 7 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 7e7deec4d8..4db3b3e8f4 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -907,6 +907,11 @@
Make qemu_thread_create() return a Boolean to indicate if it succeeds
rather than failing with an error. And add an Error parameter to hold
the error message and let the callers handle it.
Signed-off-by: Fei Li
---
cpus.c | 45 -
dump.c
Call postcopy_ram_incoming_cleanup() to do the cleanup when
postcopy_ram_enable_notify fails. Besides, report the error
message when qemu_ram_foreach_migratable_block() fails.
Cc: Dr. David Alan Gilbert
Signed-off-by: Fei Li
---
migration/postcopy-ram.c | 1 +
migration/savevm.c | 1 +
2
to one to avoid the compile error
- Fix one omitted error in patch1 and update some error messages
Fei Li (9):
Fix segmentation fault when qemu_signal_init fails
qemu_init_vcpu: add a new Error parameter to propagate
qemu_thread_join: fix segmentation fault
migration: fix some segmentatio
On 11/02/2018 10:37 AM, Peter Xu wrote:
On Thu, Nov 01, 2018 at 06:17:11PM +0800, Fei Li wrote:
Set the migration state to "failed" instead of "setup" when failing
to send packet via some channel.
Could you please provide more information in the commit message?
E.g.,
On 11/02/2018 10:31 AM, Peter Xu wrote:
On Thu, Nov 01, 2018 at 06:17:10PM +0800, Fei Li wrote:
When multifd is used during migration, a segmentaion fault will
occur in the source when multifd_save_cleanup() is called again if
the multifd_send_state has been freed in earlier error handling
On 11/02/2018 11:32 AM, Peter Xu wrote:
On Fri, Nov 02, 2018 at 11:00:24AM +0800, Fei Li wrote:
On 11/02/2018 10:37 AM, Peter Xu wrote:
On Thu, Nov 01, 2018 at 06:17:11PM +0800, Fei Li wrote:
Set the migration state to "failed" instead of "setup" when failing
to
Sorry that somehow forget the "#include "qemu/error-report.h" for
hw/usb/ccid-card-emulated.c
Have a nice day, thanks
Fei
On 11/04/2018 02:09 AM, no-re...@patchew.org wrote:
Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you
.
Signed-off-by: Fei Li
---
include/ui/console.h | 2 +-
ui/vnc-jobs.c| 9 ++---
ui/vnc-jobs.h| 2 +-
ui/vnc.c | 12 +---
4 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/include/ui/console.h b/include/ui/console.h
index fb969caf70..c17803c530
succeeds.
Signed-off-by: Fei Li
---
accel/tcg/user-exec-stub.c | 2 +-
cpus.c | 34 +-
include/qom/cpu.h | 2 +-
target/alpha/cpu.c | 4 +++-
target/arm/cpu.c| 4 +++-
target/cris/cpu.c
ate the err to the final caller.
This patch also adds the omitted error handling when creating signalfd
pipe fails in qemu_signalfd_compat().
Signed-off-by: Fei Li
---
include/qemu/osdep.h | 2 +-
util/compatfd.c | 9 ++---
util/main-loop.c | 11 +--
3 files changed,
27; failed."
will occur. One test case can reproduce this error is: set the
compression on and fail to fully setup the eight compression thread
in compress_threads_save_setup().
Signed-off-by: Fei Li
---
migration/ram.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a
or messages
v2:
- Pass errp straightly instead of using a local_err & error_propagate
- Return a bool: false/true to indicate if one function succeeds
- Merge v1's last two patches into one to avoid the compile error
- Fix one omitted error in patch1 and update some error messages
Fei Li
;c) is not
initialized, there is no need to close the channel. Or else a
segmentation fault will occur in multifd_recv_terminate_threads()
when multifd_recv_initial_packet() fails.
Signed-off-by: Fei Li
---
migration/ram.c | 24 +++-
1 file changed, 19 insertions(+), 5 del
To avoid the segmentation fault in qemu_thread_join(), just directly
return when the QemuThread *thread was failed to be created in both
qemu-thread-posix.c and qemu-thread-win32.c.
Signed-off-by: Fei Li
---
util/qemu-thread-posix.c | 3 +++
util/qemu-thread-win32.c | 2 +-
2 files changed, 4
Make qemu_thread_create() return a Boolean to indicate if it succeeds
rather than failing with an error. And add an Error parameter to hold
the error message and let the callers handle it.
Signed-off-by: Fei Li
---
cpus.c | 45
On 09/19/2018 10:49 PM, Fam Zheng wrote:
On Wed, 09/19 21:35, Fei Li wrote:
Currently, when qemu_signal_init() fails it only returns a non-zero
value but without propagating any Error. But its callers need a
non-null err when runs error_report_err(err), or else 0->msg occurs.
To avoid s
On 09/20/2018 11:28 AM, Peter Xu wrote:
On Wed, Sep 19, 2018 at 09:35:17PM +0800, Fei Li wrote:
Currently, when qemu_signal_init() fails it only returns a non-zero
value but without propagating any Error. But its callers need a
non-null err when runs error_report_err(err), or else 0->
On 09/19/2018 11:14 PM, Fam Zheng wrote:
On Wed, 09/19 21:35, Fei Li wrote:
To avoid the segmentation fault in qemu_thread_join(), just directly
return when the QemuThread *thread was failed to be created in both
qemu-thread-posix.c and qemu-thread-win32.c.
Per English grammar, I think
On 09/20/2018 12:31 PM, Peter Xu wrote:
On Wed, Sep 19, 2018 at 09:35:20PM +0800, Fei Li wrote:
Add judgement in compress_threads_save_cleanup() to check whether the
static CompressParam *comp_param has been allocated. If not, just
return; or else Segmentation fault will occur when using the
On 09/19/2018 11:51 PM, Fam Zheng wrote:
On Wed, 09/19 21:35, Fei Li wrote:
Make qemu_thread_create() return a Boolean to indicate if it succeeds
rather than failing with an error. And add an Error parameter to hold
the error message and let the callers handle it.
Signed-off-by: Fei Li
On 09/20/2018 03:32 PM, Fam Zheng wrote:
On Wed, 09/19 23:51, Fam Zheng wrote:
diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
index d7a4bbd91f..e7cbb0c368 100644
--- a/hw/rdma/rdma_backend.c
+++ b/hw/rdma/rdma_backend.c
@@ -165,7 +165,8 @@ static void start_comp_thread(RdmaBacke
On 09/21/2018 09:05 AM, Fam Zheng wrote:
On Thu, 09/20 18:19, Fei Li wrote:
On 09/19/2018 11:51 PM, Fam Zheng wrote:
On Wed, 09/19 21:35, Fei Li wrote:
Make qemu_thread_create() return a Boolean to indicate if it succeeds
rather than failing with an error. And add an Error parameter to
Sorry for the late reply.
On 09/20/2018 01:33 PM, Peter Xu wrote:
On Thu, Sep 20, 2018 at 01:06:21PM +0800, Fei Li wrote:
On 09/20/2018 12:31 PM, Peter Xu wrote:
On Wed, Sep 19, 2018 at 09:35:20PM +0800, Fei Li wrote:
Add judgement in compress_threads_save_cleanup() to check whether the
r. Fix this by squashing the terminate_compression_threads() into
compress_threads_save_cleanup() and employing the existing judgement
condition. One test case can reproduce this error is: set the
compression on and fail to fully setup the default eight compression
thread in compress_threads_save_set
bool: false/true to indicate if one function succeeds
- Merge v1's last two patches into one to avoid the compile error
- Fix one omitted error in patch1 and update some error messages
Fei Li (7):
Fix segmentation fault when qemu_signal_init fails
ui/vnc.c: polish vnc_init_func
qemu_in
To avoid the segmentation fault in qemu_thread_join(), just directly
return when the QemuThread *thread failed to be created in either
qemu-thread-posix.c or qemu-thread-win32.c.
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
util/qemu-thread-posix.c | 3 +++
util/qemu-thread-win32.c | 2
;c) is not
initialized, there is no need to close the channel. Or else a
segmentation fault will occur in multifd_recv_terminate_threads()
when multifd_recv_initial_packet() fails.
Signed-off-by: Fei Li
---
migration/ram.c | 22 --
1 file changed, 16 insertions(+), 6 del
succeeds.
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
accel/tcg/user-exec-stub.c | 2 +-
cpus.c | 34 +-
include/qom/cpu.h | 2 +-
target/alpha/cpu.c | 4 +++-
target/arm/cpu.c| 4
Add error handling for qemu_ram_foreach_migratable_block() when
it fails.
Always call migrate_set_error() to set the error state without relying
on whether multifd_save_cleanup() succeeds. As the passed &local_err
is never used in multifd_save_cleanup(), remove it.
Signed-off-by: Fe
.
Signed-off-by: Fei Li
Reviewed-by: Fam Zheng
---
include/ui/console.h | 2 +-
ui/vnc-jobs.c| 9 ++---
ui/vnc-jobs.h| 2 +-
ui/vnc.c | 12 +---
4 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/include/ui/console.h b/include/ui/console.h
index
ate the err to the final caller.
Signed-off-by: Fei Li
---
include/qemu/osdep.h | 2 +-
util/compatfd.c | 9 ++---
util/main-loop.c | 9 -
3 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index a91068df0e..09ed85f
Make qemu_thread_create() return a Boolean to indicate if it succeeds
rather than failing with an error. And add an Error parameter to hold
the error message and let the callers handle it.
Signed-off-by: Fei Li
---
cpus.c | 45
On 09/26/2018 06:36 PM, Fam Zheng wrote:
On Wed, 09/26 18:02, Fei Li wrote:
diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c
index 289af4fab5..8b044e2798 100644
--- a/util/qemu-thread-posix.c
+++ b/util/qemu-thread-posix.c
@@ -15,6 +15,7 @@
#include "qemu/ato
On 09/29/2018 11:04 AM, Fam Zheng wrote:
> On Wed, Sep 26, 2018 at 7:13 PM Fei Li wrote:
>>
>>
>> On 09/26/2018 06:36 PM, Fam Zheng wrote:
>>> On Wed, 09/26 18:02, Fei Li wrote:
>>>> diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.
1 - 100 of 284 matches
Mail list logo
