On February 29, 2024 11:41 am, Fiona Ebner wrote:
> Am 28.02.24 um 17:24 schrieb Vladimir Sementsov-Ogievskiy:
>> On 16.02.24 13:55, Fiona Ebner wrote:
>>> Previous discussion from when this was sent upstream [0] (it's been a
>>> while). I rebased the patches and re-ordered and squashed like
>>> su
picking up on John's in-progress patch series from last summer, this is
a stab at rebasing and adding test cases for the low-hanging fruits:
- bitmap mirror mode with always/on-success/never bitmap sync mode
- incremental mirror mode as sugar for bitmap + on-success
Fabian Grünbichl
and assert the passing conditions in block/mirror.c. while incremental
mode was never available for drive-mirror, it makes the interface more
uniform w.r.t. backup block jobs.
Signed-off-by: Fabian Grünbichler
---
block/mirror.c | 28 +++
blockdev.c | 29
as one without the other does not make much sense with the current set
of modes.
Signed-off-by: Fabian Grünbichler
---
blockdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 8f7b7ba5eb..23df9f76ba 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3868,6
rence/test mirrors to verify that writes in parallel
with active mirror work as expected
intentionally keeping copyright and ownership of original test case to
honor provenance.
Signed-off-by: Fabian Grünbichler
---
tests/qemu-iotests/284 | 547 +++
tests/qemu-iotests/284.
since sync_bitmap is busy at the point of merging, and we checked access
beforehand.
Signed-off-by: Fabian Grünbichler
---
block/mirror.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 40d174a625..d6aca2874e 100644
--- a/block
From: John Snow
Teach mirror two new tricks for using bitmaps:
Always: no matter what, we synchronize the copy_bitmap back to the
sync_bitmap. In effect, this allows us resume a failed mirror at a later
date.
Conditional: On success only, we sync the bitmap. This is akin to
incremental backup m
ecording!
This patch was originally based on one by Ma Haocong, but it has since
been modified pretty heavily.
Suggested-by: Ma Haocong
Signed-off-by: Ma Haocong
Signed-off-by: John Snow
Signed-off-by: Fabian Grünbichler
---
Note: this is just rebased, and broken - see patch #4
I intentional
I traced this back to the switch to enabling virtio-1 mode by default in
2.7 in commit 9a4c0e220d8a4f82b5665d0ee95ef94d8e1509d5
forcing the old behaviour with a 2.6 machine type works.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
unfortunately cherry-picking the SeaBIOS 1.10 binary update commit from
qemu master (6e99f5741ff1) on top of v2.7.0 does not solve the issue
(the only observable change is the version string that is displayed on
booting, right when it hangs ;)).
I can still give your suggested route a try if you t
On Tue, Jan 17, 2017 at 08:33:46AM +0100, Alexandre DERUMIER wrote:
> Hi,
>
> proxmox users have reported recently corruption with qemu 2.7 and scsi-block
> (with passing physical /dev/sdX to virtio-scsi).
>
> working fine with qemu 2.6.
>
> qemu 2.7 + scsi-hd works fine
>
> https://forum.prox
On Tue, Jan 17, 2017 at 11:41:44AM +0100, Paolo Bonzini wrote:
>
>
> On 17/01/2017 09:03, Fabian Grünbichler wrote:
> > Commit 8fdc7839e40f43a426bc7e858cf1dbfe315a3804 (first included in
> > 2.7.0)[1] changed the behaviour of scsi-block passthrough. Previously
> >
On 17/01/2017 16:03, Paolo Bonzini wrote:
> On 17/01/2017 12:22, Fabian Grünbichler wrote:
>> 6) repeat 3-5 until md5sum does not match, kernel spews error
>> messages, or you are convinced that everything is OK
>>
>> sample kernel message (for ext3):
>> Jan 17 1
> Paolo Bonzini hat am 18. Januar 2017 um 17:30
> geschrieben:
>
>
>
>
> On 18/01/2017 17:19, Fabian Grünbichler wrote:
> > Jan 18 17:07:51 ubuntu kernel: sd 2:0:0:0: [sda] tag#109 FAILED Result:
> > hostbyte=DID_OK driverbyte=DRIVER_SENSE
> > Ja
On Wed, Jan 18, 2017 at 05:30:17PM +0100, Paolo Bonzini wrote:
>
>
> On 18/01/2017 17:19, Fabian Grünbichler wrote:
> > Jan 18 17:07:51 ubuntu kernel: sd 2:0:0:0: [sda] tag#109 FAILED Result:
> > hostbyte=DID_OK driverbyte=DRIVER_SENSE
> > Jan 18 17:07:51 ubuntu ke
On February 25, 2020 10:54 pm, John Snow wrote:
> On 2/18/20 5:07 AM, Fabian Grünbichler wrote:
>> picking up on John's in-progress patch series from last summer, this is
>> a stab at rebasing and adding test cases for the low-hanging fruits:
>>
>> - bitmap mi
On March 22, 2021 12:27 pm, Patrik Janoušek wrote:
> On 3/22/21 11:48 AM, Max Reitz wrote:
>> Hi,
>>
>> On 20.03.21 11:01, Patrik Janoušek wrote:
>>> I'm sorry, but I forgot to add you to the cc, so I'm forwarding the
>>> patch to you additionally. I don't want to spam the mailing list
>>> unnecess
On August 21, 2019 11:19 pm, John Snow wrote:
>
>
> On 8/21/19 10:21 AM, Vladimir Sementsov-Ogievskiy wrote:
>> [CC Nikolay]
>>
>> 21.08.2019 1:25, John Snow wrote:
>>> Hi, downstream here at Red Hat I've been fielding some questions about
>>> the usability and feature readiness of Bitmaps (and
On Tue, Jul 09, 2019 at 07:25:32PM -0400, John Snow wrote:
> This series adds a new "BITMAP" sync mode that is meant to replace the
> existing "INCREMENTAL" sync mode.
>
> This mode can have its behavior modified by issuing any of three bitmap sync
> modes, passed as arguments to the job.
>
> The
On Mon, Jul 22, 2019 at 01:21:02PM -0400, John Snow wrote:
>
>
> On 7/22/19 8:17 AM, Fabian Grünbichler wrote:
> > On Tue, Jul 09, 2019 at 07:25:32PM -0400, John Snow wrote:
> >> This series adds a new "BITMAP" sync mode that is meant to replace the
>
On Tue, Jul 23, 2019 at 12:58:10PM -0400, John Snow wrote:
>
>
> On 7/23/19 5:47 AM, Fabian Grünbichler wrote:
> > On Mon, Jul 22, 2019 at 01:21:02PM -0400, John Snow wrote:
> >>
> >>
> >> On 7/22/19 8:17 AM, Fabian Grünbichler wrote:
> >>&g
NOTE: patch #2 is still requiring a S-O-B by John before applying!
Fabian Grünbichler (2):
mirror: move some checks to qmp
iotests: add test for bitmap mirror
John Snow (2):
drive-mirror: add support for sync=bitmap mode=never
drive-mirror: add support for conditional and always bitmap sync
ecording!
This patch was originally based on one by Ma Haocong, but it has since
been modified pretty heavily.
Suggested-by: Ma Haocong
Signed-off-by: Ma Haocong
Signed-off-by: John Snow
Signed-off-by: Fabian Grünbichler
---
include/block/block_int.h | 4 +-
block/m
work by John Snow.
Signed-off-by: Fabian Grünbichler
---
block/mirror.c | 28
blockdev.c | 3 +++
2 files changed, 23 insertions(+), 8 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index d64c8203ef..bc4f4563d9 100644
--- a/block/mirror.c
+++ b/block
rence/test mirrors to verify that writes in parallel
with active mirror work
intentionally keeping copyright and ownership of original test case to
honor provenance.
Signed-off-by: Fabian Grünbichler
---
tests/qemu-iotests/306 | 546 +++
tests/qemu-iotests/306.
and assert the passing conditions in block/mirror.c. while incremental
mode was never available for drive-mirror, it makes the interface more
in line with backup block jobs.
Signed-off-by: Fabian Grünbichler
---
block/mirror.c | 28 +---
blockdev.c | 29
On October 1, 2020 7:31 pm, Max Reitz wrote:
> On 22.09.20 11:14, Fabian Grünbichler wrote:
>> heavily based on/practically forked off iotest 257 for bitmap backups,
>> but:
>>
>> - no writes to filter node 'mirror-top' between completion and
>> final
On October 1, 2020 7:01 pm, Max Reitz wrote:
> On 22.09.20 11:14, Fabian Grünbichler wrote:
>> From: John Snow
>>
>> Teach mirror two new tricks for using bitmaps:
>>
>> Always: no matter what, we synchronize the copy_bitmap back to the
>> sync_bitmap. In
On October 2, 2020 9:06 am, Markus Armbruster wrote:
> Fabian Grünbichler writes:
>
>> From: John Snow
>>
>> This patch adds support for the "BITMAP" sync mode to drive-mirror and
>> blockdev-mirror. It adds support only for the BitmapSyncMode &q
On August 21, 2020 3:03 pm, Max Reitz wrote:
> On 18.02.20 11:07, Fabian Grünbichler wrote:
>
> [Sorry :/]
same, I've been meaning to ping/pick this back up but other stuff got in
the way. so thanks for the reminder to get this upstream ;)
>
>> picking up on John
On September 3, 2020 3:23 pm, Kevin Wolf wrote:
> Am 03.09.2020 um 14:57 hat Max Reitz geschrieben:
>> On 03.09.20 14:38, Kevin Wolf wrote:
>> > Am 03.09.2020 um 13:04 hat Max Reitz geschrieben:
>> >> On 03.09.20 12:13, Fabian Grünbichler wrote:
>> >>>
31 matches
Mail list logo
