Re: [PATCH v3 3/3] cpu, softmmu/vl.c: Change parsing of -cpu argument to allow -cpu cpu, help to print options for the CPU type similar to how the '-device' option works.

2023-08-01 Thread Dinah B
Just realized that the commit message on this one got a little mangled. I'm happy to revise it but I'd prefer to get the code reviewed first before doing a purely commit message change. -Dinah On Sun, Jul 30, 2023 at 2:41 AM Dinah Baum wrote: > Resolves: https://gitlab.com/qemu-project/qemu/-/i

Re: [PATCH v3 3/3] cpu, softmmu/vl.c: Change parsing of -cpu argument to allow -cpu cpu, help to print options for the CPU type similar to how the '-device' option works.

2023-08-01 Thread Dinah B
Thanks, I will fix this. I somehow didn't catch that you had replied to the old one. -Dinah On Tue, Aug 1, 2023 at 10:10 AM Markus Armbruster wrote: > Dinah Baum writes: > > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1480 > > Signed-off-by: Dinah Baum > > > > Signed-off-by: Din

Re: [PATCH v2 0/3] Enable -cpu ,help

2023-03-21 Thread Dinah B
Friendly ping for code review on this patch series. Full series: https://lore.kernel.org/qemu-devel/20230314100026.536079-1-dinahbaum...@gmail.com/ Thanks, -DInah On Tue, Mar 14, 2023 at 6:00 AM Dinah Baum wrote: > Part 1 is a refactor/code motion patch for > qapi/machine target required for s

Re: [PATCH 1/2] configure: Add 'mkdir build' check

2023-02-15 Thread Dinah B
*ping* Patch series: https://lore.kernel.org/qemu-devel/20230208233111.398577-1-dinahbaum...@gmail.com/ -Dinah On Wed, Feb 8, 2023 at 6:31 PM Dinah Baum wrote: > QEMU configure script goes into an infinite error printing loop > when in read only directory due to 'build' dir never being created

Re: [PATCH] configure: Add 'mkdir build' check

2023-02-06 Thread Dinah B
Hi, thanks for the feedback - I'll revise it. Small question - Paolo Bonzini specified that 'configure --help' should work even if the build doesn't. Currently the script functions that handle argument reading aren't initialized or run until after the build is done, so if the build fails, so do the

Adopting abandoned patch?

2023-02-26 Thread Dinah B
Hi, I'm looking to get more involved in contributing to QEMU. I noticed that there are some issues in the tracker where a sample patch has been contributed but never got merged, like a proposal to add multiboot2 support: https://gitlab.com/qemu-project/qemu/-/issues/389 Is another dev allowed to

Re: Adopting abandoned patch?

2023-02-27 Thread Dinah B
Thanks, here's the original patch: https://bugs.debian.org/cgi-bin/bugreport.cgi?att=2;bug=621529;filename=multiboot2.patch;msg=15 On Mon, Feb 27, 2023 at 4:59 AM Alex Bennée wrote: > > Dinah B writes: > > > Hi, > > > > I'm looking to get more involved in

Re: Adopting abandoned patch?

2023-02-27 Thread Dinah B
It looks like the author didn't include a "Signed off" in their patch draft and it doesn't look like Debian qemu-kvm maintainers ever merged it. Does this change the patch adoption process? Thanks, -Dinah On Mon, Feb 27, 2023 at 4:23 PM Dinah B wrote: > Thanks, he

Re: [PATCH v3 3/3] cpu, softmmu/vl.c: Change parsing of -cpu argument to allow -cpu cpu, help to print options for the CPU type similar to how the '-device' option works.

2023-12-10 Thread Dinah B
m the qom or qmp based data structures it's currently intertwined with. Thanks, -Dinah On Tue, Nov 14, 2023 at 12:44 PM Markus Armbruster wrote: > Dinah B writes: > > > Hi, > > > > Is there a way to distinguish between qemu-system-* vs qemu-* builds? > > At fir

Re: [PATCH v3 3/3] cpu, softmmu/vl.c: Change parsing of -cpu argument to allow -cpu cpu, help to print options for the CPU type similar to how the '-device' option works.

2023-11-14 Thread Dinah B
Hi, Is there a way to distinguish between qemu-system-* vs qemu-* builds? At first I thought #CONFIG_LINUX_USER might be it but not all non-mmu builds set this. Thanks, -Dinah On Wed, Aug 2, 2023 at 1:36 AM Markus Armbruster wrote: > Dinah B writes: > > > Thanks, I will fix thi

Re: [PATCH v3 1/3] qapi: Moved architecture agnostic data types to `machine`

2023-10-31 Thread Dinah B
Hi, I noticed that qapi now has a machine-common category - do you think these changes would be more appropriate in that file rather than "machine" for the revision? Thanks and sorry for the delay, -Dinah On Tue, Aug 1, 2023 at 9:09 AM Markus Armbruster wrote: > Dinah Baum writes: > > > Signe