Re: [Qemu-devel] [PATCH v2 for 2.6 0/5] QMP wrappers for VM snapshot operations

2015-12-17 Thread Denis V. Lunev
On 12/11/2015 12:33 PM, Denis V. Lunev wrote: On 12/04/2015 05:44 PM, Denis V. Lunev wrote: EFI based VM with pflash storage for NVRAM could not be snapshoted as libvirt configures storage as 'raw' and writable. OK, this is a libvirt problem. Another problem is that libvirt can not d

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

2015-12-18 Thread Denis V. Lunev
On 12/18/2015 06:19 PM, Pavel Fedin wrote: Hello! I realize that it's perhaps too late, because patches are already on Linux-next, but i have one concern... May be it's not too late... I dislike implementing architecture-dependent exit code where we could implement an architecture-indep

Re: [Qemu-devel] guest kernel in the host RAM

2015-12-18 Thread Denis V. Lunev
On 12/15/2015 02:59 PM, Paolo Bonzini wrote: On 15/12/2015 12:27, Denis V. Lunev wrote: The idea is that we could boot with the uncompressed Linux kernel in the guest which serves 2 purposes: - faster boot time as per Intel opinion - memory savings Uncompressed kernel image could be the same

Re: [Qemu-devel] [PULL v3 00/15] Tracing patches

2015-12-20 Thread Denis V. Lunev
On 11/13/2015 01:44 PM, Stefan Hajnoczi wrote: On Fri, Nov 13, 2015 at 6:30 PM, Peter Maydell wrote: On 13 November 2015 at 07:58, Stefan Hajnoczi wrote: v3: * Include "exec/log.h" from translate-a64.c [Peter] v2: * Add missing log.py file [Peter] The following changes since commit 74fc

[Qemu-devel] [PATCH 1/1] qga: guest-set-user-password - added ability to create new user

2015-12-20 Thread Denis V. Lunev
f-by: Yuri Pudgorodskiy Signed-off-by: Denis V. Lunev CC: Michael Roth --- qga/commands-posix.c | 36 qga/commands-win32.c | 25 - qga/qapi-schema.json | 3 ++- 3 files changed, 62 insertions(+), 2 deletions(-) diff --git a/qga/commands

Re: [Qemu-devel] [PATCH 1/1] qga: guest-set-user-password - added ability to create new user

2015-12-21 Thread Denis V. Lunev
On 12/21/2015 05:00 PM, Eric Blake wrote: On 12/20/2015 11:40 PM, Denis V. Lunev wrote: From: Yuri Pudgorodskiy Added optional 'create' flag to guest-set-user-password command. When it is specified, a new user will be created if it is not exists yet. s/is not exists/does not ex

[Qemu-devel] [PATCH 1/1] block: fix inability to start VM with native AIO

2015-12-21 Thread Denis V. Lunev
Author: Kevin Wolf Date: Tue Dec 15 11:35:36 2015 +0100 raw-posix: Make aio=native option binding Signed-off-by: Denis V. Lunev CC: Kevin Wolf --- block.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block.c b/block.c index 411edbf..fe0fbbc 100644 --- a/block.c +++ b

[Qemu-devel] [PATCH 1/1] doc: document chardev option 'append'

2015-12-22 Thread Denis V. Lunev
. Signed-off-by: Denis V. Lunev CC: Dmitry Mishin CC: Eric Blake CC: Markus Armbruster CC: Paolo Bonzini --- qemu-options.hx | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 49afe6c..f706e4a 100644 --- a/qemu-options.hx +++ b/qemu

[Qemu-devel] [PATCH v2 1/1] doc: document chardev option 'append'

2015-12-22 Thread Denis V. Lunev
. Signed-off-by: Denis V. Lunev CC: Dmitry Mishin CC: Eric Blake CC: Markus Armbruster CC: Paolo Bonzini --- Changes from v1: - fixed default value to 'off' qemu-options.hx | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx ind

Re: [Qemu-devel] [PATCH v2 1/1] doc: document chardev option 'append'

2015-12-22 Thread Denis V. Lunev
On 12/22/2015 01:26 PM, Daniel P. Berrange wrote: On Tue, Dec 22, 2015 at 12:49:09PM +0300, Denis V. Lunev wrote: commit 31e38a22a0c5a25646f966f001e1f5513d5a186d Author: Olga Krishtal Date: Fri Dec 4 09:42:04 2015 +0300 qemu-char: append opt to stop truncation of

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2015-12-22 Thread Denis V. Lunev
On 12/23/2015 06:14 AM, Fam Zheng wrote: On Tue, 12/22 17:46, Kevin Wolf wrote: Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users doesn't seem to be a working strategy, so this series adds locking to qcow2 that refuses t

[Qemu-devel] [PATCH RFC 0/5] generic image locking and crash recovery

2015-12-22 Thread Denis V. Lunev
closed with the error. Patchset is not polished at all! Sent for a discussion as an alternative approach. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Max Reitz CC: Eric Blake CC: Fam Zheng Olga Krishtal (5): block: added lock image option and callback

[Qemu-devel] [PATCH 2/5] block: implemented bdrv_lock_image for raw file

2015-12-22 Thread Denis V. Lunev
-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Max Reitz CC: Eric Blake CC: Fam Zheng --- block/raw-posix.c | 15 +++ block/raw-win32.c | 19 +++ 2 files changed, 34 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index

[Qemu-devel] [PATCH 1/5] block: added lock image option and callback

2015-12-22 Thread Denis V. Lunev
V. Lunev CC: Kevin Wolf CC: Max Reitz CC: Eric Blake CC: Fam Zheng --- block.c | 41 + include/block/block.h | 1 + include/block/block_int.h | 1 + qapi/block-core.json | 9 + 4 files changed, 52 insertions

[Qemu-devel] [PATCH 5/5] block/paralels: added paralles implementation for bdrv_is_opened_unclean

2015-12-22 Thread Denis V. Lunev
From: Olga Krishtal Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Max Reitz CC: Eric Blake CC: Fam Zheng --- block/parallels.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block/parallels.c b/block/parallels.c index e4a56a5

[Qemu-devel] [PATCH 3/5] block: added check image option and callback bdrv_is_opened_unclean

2015-12-22 Thread Denis V. Lunev
not - to check and repair it. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Max Reitz CC: Eric Blake CC: Fam Zheng --- block.c | 32 include/block/block.h | 1 + include/block/block_int.h | 1 + 3 files

[Qemu-devel] [PATCH 4/5] qcow2: implemented bdrv_is_opened_unclean

2015-12-22 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Max Reitz CC: Eric Blake CC: Fam Zheng --- block/qcow2.c | 11 ++- block/qcow2.h | 1 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index 1789af4..de3b97f 100644 --- a/block/qcow2.c +++ b

Re: [Qemu-devel] [PATCH RFC 0/5] generic image locking and crash recovery

2015-12-23 Thread Denis V. Lunev
On 12/23/2015 11:09 AM, Fam Zheng wrote: On Wed, 12/23 10:46, Denis V. Lunev wrote: This series of patches is aimed to prevent usage of image file by different qemu instances. In case we are the first instance, and option lock is lockfile, - we lock the image file, and if check option is on, we

Re: [Qemu-devel] [PATCH 3/5] block: added check image option and callback bdrv_is_opened_unclean

2015-12-23 Thread Denis V. Lunev
On 12/23/2015 12:09 PM, Fam Zheng wrote: On Wed, 12/23 10:46, Denis V. Lunev wrote: From: Olga Krishtal If image is opened for writing and it was not closed correctly (the image is dirty) we have to check and repair it. By default the option is off. bdrv_is_opened_unclean - cheks if the

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2015-12-23 Thread Denis V. Lunev
On 12/23/2015 03:29 PM, Daniel P. Berrange wrote: On Wed, Dec 23, 2015 at 03:15:50PM +0300, Roman Kagan wrote: On Wed, Dec 23, 2015 at 10:47:22AM +, Daniel P. Berrange wrote: On Wed, Dec 23, 2015 at 11:14:12AM +0800, Fam Zheng wrote: As an alternative, can we introduce .bdrv_flock() in pro

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2015-12-23 Thread Denis V. Lunev
On 12/23/2015 03:34 PM, Daniel P. Berrange wrote: On Wed, Dec 23, 2015 at 03:15:50PM +0300, Roman Kagan wrote: On Wed, Dec 23, 2015 at 10:47:22AM +, Daniel P. Berrange wrote: On Wed, Dec 23, 2015 at 11:14:12AM +0800, Fam Zheng wrote: As an alternative, can we introduce .bdrv_flock() in pro

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2015-12-23 Thread Denis V. Lunev
On 12/23/2015 05:57 PM, Vasiliy Tolstov wrote: 2015-12-22 19:46 GMT+03:00 Kevin Wolf : Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users doesn't seem to be a working strategy, so this series adds locking to qcow2 that re

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2015-12-23 Thread Denis V. Lunev
On 12/23/2015 05:57 PM, Vasiliy Tolstov wrote: 2015-12-22 19:46 GMT+03:00 Kevin Wolf : Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users doesn't seem to be a working strategy, so this series adds locking to qcow2 that re

Re: [Qemu-devel] [PATCH v2 for 2.6 0/5] QMP wrappers for VM snapshot operations

2015-12-23 Thread Denis V. Lunev
On 12/18/2015 09:10 AM, Denis V. Lunev wrote: On 12/11/2015 12:33 PM, Denis V. Lunev wrote: On 12/04/2015 05:44 PM, Denis V. Lunev wrote: EFI based VM with pflash storage for NVRAM could not be snapshoted as libvirt configures storage as 'raw' and writable. OK, this is a libvi

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-23 Thread Denis V. Lunev
On 12/24/2015 12:40 AM, Eric Blake wrote: On 12/04/2015 07:44 AM, Denis V. Lunev wrote: 'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function is just a simple wrapper now and does not have knowl

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2015-12-23 Thread Denis V. Lunev
On 12/24/2015 02:19 AM, Max Reitz wrote: On 23.12.2015 04:14, Fam Zheng wrote: On Tue, 12/22 17:46, Kevin Wolf wrote: Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users doesn't seem to be a working strategy, so this seri

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2015-12-23 Thread Denis V. Lunev
On 12/24/2015 08:41 AM, Denis V. Lunev wrote: On 12/24/2015 02:19 AM, Max Reitz wrote: On 23.12.2015 04:14, Fam Zheng wrote: On Tue, 12/22 17:46, Kevin Wolf wrote: Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2015-12-23 Thread Denis V. Lunev
On 12/22/2015 07:46 PM, Kevin Wolf wrote: Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users doesn't seem to be a working strategy, so this series adds locking to qcow2 that refuses to access the image read-write from two

[Qemu-devel] [PATCH v3 1/1] doc: document chardev option 'append'

2016-01-03 Thread Denis V. Lunev
commit 31e38a22a0c5a25646f966f001e1f5513d5a186d Author: Olga Krishtal Date: Fri Dec 4 09:42:04 2015 +0300 qemu-char: append opt to stop truncation of serial file has added the option to the runtime but does not added it to -help output. Signed-off-by: Denis V. Lunev

Re: [Qemu-devel] [PULL v3 00/15] Tracing patches

2016-01-04 Thread Denis V. Lunev
11-13 15:52:57 +0800) -------- Denis V. Lunev (2): trace: no need to call trace_backend_init in different branches now log: move qemu-log.c into util/ directory Paolo Bonzini (11): trace: count number of ena

[Qemu-devel] [PATCH 1/2] create ga_run_program() helper for guest-set-user-password

2016-01-06 Thread Denis V. Lunev
-off-by: Yuri Pudgorodskiy Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Michael Roth --- qga/commands-posix.c | 201 --- 1 file changed, 141 insertions(+), 60 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 8fe708f

[Qemu-devel] [PATCH 2/2] guest-set-user-password - added ability to create new user

2016-01-06 Thread Denis V. Lunev
de is made specifically for Linux/Windows and is inside proper ifdef braces. Signed-off-by: Yuri Pudgorodskiy Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Michael Roth --- qga/commands-posix.c | 20 qga/commands-win32.c | 25 - qga/qapi-schema

[Qemu-devel] [PATCH v2 0/2] qga: guest-set-user-password - added ability to create new user

2016-01-06 Thread Denis V. Lunev
e stdout/stderr from useradd/chpasswd and send iti back with the error message to caller - split to two patches Signed-off-by: Yuri Pudgorodskiy Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Michael Roth Yuriy Pudgorodskiy (2): create ga_run_program() helper for guest-set-user-passw

Re: [Qemu-devel] [PATCH 1/2] create ga_run_program() helper for guest-set-user-password

2016-01-06 Thread Denis V. Lunev
On 01/06/2016 03:01 PM, Denis V. Lunev wrote: From: Yuriy Pudgorodskiy This helper properly starts chpasswd and collects stdout/stderr of this program to report it as error to the caller. The code will be reused later to run useradd in addition to chpasswd. This code is made specifically for

Re: [Qemu-devel] [Qemu-block] [PATCH v5 4/6] expose floppy drive geometry and CMOS type

2016-01-06 Thread Denis V. Lunev
On 01/04/2016 11:44 PM, John Snow wrote: On 12/30/2015 03:11 PM, Roman Kagan wrote: Make it possible to query the geometry and the CMOS type of a floppy drive outside of the respective source files. It will be useful, in particular, when dynamically building ACPI tables, and will allow to prop

[Qemu-devel] [PATCH 01/11] trace: fix documentation

2016-01-07 Thread Denis V. Lunev
From: Paolo Bonzini Mention the ftrace backend too. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger --- qemu-options.hx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 215d00d

[Qemu-devel] [PATCH 06/11] trace: add "-trace help"

2016-01-07 Thread Denis V. Lunev
From: Paolo Bonzini Print a list of trace points Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger --- qemu-options.hx | 2 ++ trace/control.c | 21 - trace/control.h | 7 +++ 3 files changed, 29 insertions(+), 1 deletion

[Qemu-devel] [PATCH 03/11] trace: split trace_init_file out of trace_init_backends

2016-01-07 Thread Denis V. Lunev
From: Paolo Bonzini This is cleaner, and improves error reporting with -daemonize. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger --- qemu-io.c | 2 +- trace/control.c | 17 - trace/control.h | 13 - trace

[Qemu-devel] [PATCH 09/11] trace: convert stderr backend to log

2016-01-07 Thread Denis V. Lunev
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger --- configure | 4 ++-- include/qemu/log.h | 1 + scripts/tracetool/backend/{stderr.py => log.py} |

[Qemu-devel] [PATCH 11/11] log: add "-d trace:PATTERN"

2016-01-07 Thread Denis V. Lunev
From: Paolo Bonzini This is a bit easier to use than "-trace" if you are also enabling other kinds of logging. It is also more discoverable for experienced QEMU users, and accessible from user-mode emulators. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by:

Re: [Qemu-devel] [PATCH v4 00/11] simplify usage of tracepoints, and connect them to logging

2016-01-07 Thread Denis V. Lunev
On 01/07/2016 08:04 PM, Eric Blake wrote: On 01/07/2016 06:55 AM, Denis V. Lunev wrote: This series does three things: 1) add a "-trace [enable=]foo" option to enable one or more trace events, and a "-trace help" option to show the list of tracepoints (patches 4-5)

Re: [Qemu-devel] [PATCH 1/5] migration: split hmp_savevm to do_savevm and hmp_savevm wrapper

2016-01-08 Thread Denis V. Lunev
On 12/24/2015 12:27 AM, Eric Blake wrote: On 12/04/2015 07:44 AM, Denis V. Lunev wrote: This would be useful in the next step when QMP version of this call will be introduced. Signed-off-by: Denis V. Lunev Reviewed-by: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake

Re: [Qemu-devel] [PATCH 1/1] block: fix inability to start VM with native AIO

2016-01-08 Thread Denis V. Lunev
On 12/22/2015 09:59 AM, Denis V. Lunev wrote: error: Failed to start domain rhel7 error: internal error: process exited while connecting to monitor: 2015-12-22T06:55:18.812637Z qemu-system-x86_64: -drive file=/var/lib/libvirt/images/rhel7.qcow2,if=none, id=drive-scsi0-0-0-0

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2016-01-08 Thread Denis V. Lunev
On 12/24/2015 12:40 AM, Eric Blake wrote: On 12/04/2015 07:44 AM, Denis V. Lunev wrote: 'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function is just a simple wrapper now and does not have knowl

[Qemu-devel] [PATCH 1/5] qmp: process system-reset event in paused state

2016-01-08 Thread Denis V. Lunev
command is that the guest will be force restarted. This is not true at the moment. Thus it is quite natural to process 'virh reset' aka qmp_system_reset this way, i.e. allow to reset the guest. This behavior is similar to one observed with 'reset' button on real hardware :) Sign

[Qemu-devel] [PATCH v3 0/5] QMP wrappers for VM snapshot operations

2016-01-08 Thread Denis V. Lunev
e snapshot sequence passes silently. The patchset adds QMP wrappers for the purpose. Signed-off-by: "Denis V. Lunev" CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake Changes from v2: - patches 1/2 are resplit to move processing HMP specific handling of snapsho

[Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2016-01-08 Thread Denis V. Lunev
'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about migration internals. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Ami

[Qemu-devel] [PATCH 5/5] qmp: create QMP implementation of loadvm command

2016-01-08 Thread Denis V. Lunev
Unfortunately load_vmstate has a return code (int) and this code is checked in the other places. Thus we could not just rename it to qmp_loadvm as returns void. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- migration/savevm.c | 10

[Qemu-devel] [PATCH 3/5] qmp: create qmp_delvm command

2016-01-08 Thread Denis V. Lunev
The patch also moves hmp_delvm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about migration internals. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- hmp.c | 11

[Qemu-devel] [PATCH 4/5] migration: improve error reporting for load_vmstate

2016-01-08 Thread Denis V. Lunev
The patch adds Error ** parameter to load_vmstate call and fills error inside. The caller after that properly reports error either through monitor or via local stderr facility during VM start. This helper will be useful too for qmp_loadvm implementation. Signed-off-by: Denis V. Lunev CC: Juan

Re: [Qemu-devel] [PATCH v3 0/5] QMP wrappers for VM snapshot operations

2016-01-08 Thread Denis V. Lunev
On 01/08/2016 05:00 PM, Denis V. Lunev wrote: EFI based VM with pflash storage for NVRAM could not be snapshoted as libvirt configures storage as 'raw' and writable. OK, this is a libvirt problem. Another problem is that libvirt can not detect this failure at all as it uses HM

[Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2016-01-08 Thread Denis V. Lunev
'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about migration internals. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Ami

[Qemu-devel] [PATCH 3/5] qmp: create qmp_delvm command

2016-01-08 Thread Denis V. Lunev
The patch also moves hmp_delvm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about migration internals. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- hmp.c | 11

[Qemu-devel] [PATCH 5/5] qmp: create QMP implementation of loadvm command

2016-01-08 Thread Denis V. Lunev
Unfortunately load_vmstate has a return code (int) and this code is checked in the other places. Thus we could not just rename it to qmp_loadvm as returns void. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- migration/savevm.c | 10

[Qemu-devel] [PATCH 4/5] migration: improve error reporting for load_vmstate

2016-01-08 Thread Denis V. Lunev
The patch adds Error ** parameter to load_vmstate call and fills error inside. The caller after that properly reports error either through monitor or via local stderr facility during VM start. This helper will be useful too for qmp_loadvm implementation. Signed-off-by: Denis V. Lunev CC: Juan

[Qemu-devel] [PATCH 1/5] migration: split hmp_savevm to migrate_savevm and hmp_savevm wrapper

2016-01-08 Thread Denis V. Lunev
temporary. It will be removed in the next patch with QMP level change. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Eric Blake CC: Amit Shah CC: Markus Armbruster --- hmp.c | 26 include/migration/migration.h | 3 +++ migration/savevm.c

[Qemu-devel] [PATCH v4 0/5] QMP wrappers for VM snapshot operations

2016-01-08 Thread Denis V. Lunev
e snapshot sequence passes silently. The patchset adds QMP wrappers for the purpose. Signed-off-by: "Denis V. Lunev" CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake Changes from v3: - wrong patch 1 is replaced Changes from v2: - patches 1/2 are resplit to move pro

Re: [Qemu-devel] [RFC 1/1] nbd (specification): add NBD_CMD_WRITE_ZEROES command

2016-02-18 Thread Denis V. Lunev
On 02/18/2016 12:18 PM, Roman Kagan wrote: On Wed, Feb 17, 2016 at 01:58:47PM -0700, Eric Blake wrote: On 02/17/2016 11:10 AM, Denis V. Lunev wrote: @@ -446,6 +448,11 @@ The following request types exist: about the contents of the export affected by this command, until overwriting

Re: [Qemu-devel] [RFC 1/1] nbd (specification): add NBD_CMD_WRITE_ZEROES command

2016-02-18 Thread Denis V. Lunev
On 02/18/2016 03:14 PM, Daniel P. Berrange wrote: On Wed, Feb 17, 2016 at 01:58:47PM -0700, Eric Blake wrote: On 02/17/2016 11:10 AM, Denis V. Lunev wrote: This patch proposes a new command to reduce the amount of data passed through the wire when it is known that the data is all zeroes. This

Re: [Qemu-devel] [PATCH v2 1/1] hyperv: cpu hotplug fix with HyperV enabled

2016-02-18 Thread Denis V. Lunev
On 02/17/2016 11:31 PM, Eduardo Habkost wrote: On Sat, Feb 13, 2016 at 03:00:15PM +0300, Denis V. Lunev wrote: With Hyper-V enabled CPU hotplug stops working. The CPU appears in device manager on Windows but does not appear in peformance monitor and control panel. The root of the problem is

[Qemu-devel] SUMMARY: Re: [RFC 1/1] nbd (specification): add NBD_CMD_WRITE_ZEROES command

2016-02-18 Thread Denis V. Lunev
On 02/18/2016 07:35 PM, Eric Blake wrote: On 02/18/2016 02:18 AM, Roman Kagan wrote: On Wed, Feb 17, 2016 at 01:58:47PM -0700, Eric Blake wrote: On 02/17/2016 11:10 AM, Denis V. Lunev wrote: @@ -446,6 +448,11 @@ The following request types exist: about the contents of the export

Re: [Qemu-devel] SUMMARY: Re: [RFC 1/1] nbd (specification): add NBD_CMD_WRITE_ZEROES command

2016-02-18 Thread Denis V. Lunev
On 02/18/2016 08:23 PM, Denis V. Lunev wrote: On 02/18/2016 07:35 PM, Eric Blake wrote: On 02/18/2016 02:18 AM, Roman Kagan wrote: On Wed, Feb 17, 2016 at 01:58:47PM -0700, Eric Blake wrote: On 02/17/2016 11:10 AM, Denis V. Lunev wrote: @@ -446,6 +448,11 @@ The following request types exist

[Qemu-devel] [PATCH 2/2] virtio-balloon: add 'available' counter

2016-02-19 Thread Denis V. Lunev
_AVAIL, to virtio_balloon memory statistics protocol, corresponding to 'Available' in /proc/meminfo. Signed-off-by: Denis V. Lunev CC: Igor Redko CC: Michael S. Tsirkin --- hw/virtio/virtio-balloon.c | 1 + include/standard-headers/linux/virtio_balloon.h | 3 ++-

[Qemu-devel] [PATCH 1/2] virtio-balloon: export all balloon statistics

2016-02-19 Thread Denis V. Lunev
egular names. Signed-off-by: Igor Redko Signed-off-by: Denis V. Lunev CC: Michael S. Tsirkin --- hw/virtio/virtio-balloon.c | 30 -- include/hw/virtio/virtio-balloon.h | 3 ++- 2 files changed, 26 insertions(+), 7 deletions(-) diff --git a/hw/virtio/virtio-

[Qemu-devel] [PATCH 0/2] virtio-balloon: improve balloon statistics

2016-02-19 Thread Denis V. Lunev
New counter from the Linux kernel + generic framework to pass currently unknown counters via QMP for debug purposes. Signed-off-by: Denis V. Lunev CC: Igor Redko CC: Michael S. Tsirkin

[Qemu-devel] [PATCH v3 1/1] hyperv: cpu hotplug fix with HyperV enabled

2016-02-22 Thread Denis V. Lunev
. Signed-off-by: Denis V. Lunev Reviewed-by: Roman Kagan CC: Paolo Bonzini CC: Richard Henderson CC: Eduardo Habkost CC: "Andreas Färber" --- Changes from v2: - bit set unconditionally upon the discussion Changes from v1: - dropped command line option and set the bit if HyperV is e

Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context

2016-02-22 Thread Denis V. Lunev
On 02/18/2016 08:17 AM, Amit Shah wrote: Can someone from the block team please give this a review? Thanks, guys? On (Fri) 12 Feb 2016 [09:39:32], Denis V. Lunev wrote: There is a possibility to hit an assert in qcow2_get_specific_info that s->qcow_version is undefined. This happens w

Re: [Qemu-devel] [PATCH v7 0/5] don't use NVDIMM for balooning

2016-02-22 Thread Denis V. Lunev
On 02/10/2016 11:49 AM, Vladimir Sementsov-Ogievskiy wrote: v7: 02: Reviewed-by: Igor Mammedov 04: object instead of dimm 05: arror_abort instead of NULL for getting size property, remove superfluous include v6: add stubbed pc_dimm_build_list, fix compilation for !CONFIG_MEM_

Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context

2016-02-23 Thread Denis V. Lunev
On 02/23/2016 01:47 PM, Amit Shah wrote: Hi Denis, On (Tue) 23 Feb 2016 [13:09:26], Amit Shah wrote: On (Fri) 12 Feb 2016 [09:39:32], Denis V. Lunev wrote: There is a possibility to hit an assert in qcow2_get_specific_info that s->qcow_version is undefined. This happens when VM in start

[Qemu-devel] [PATCH v2 0/2] virtio-balloon: improve balloon statistics

2016-02-23 Thread Denis V. Lunev
New counter from the Linux kernel + generic framework to pass currently unknown counters via QMP for debug purposes. Signed-off-by: Denis V. Lunev CC: Igor Redko CC: Michael S. Tsirkin Changes from v1: - removed !err in patch 1 by suggestion from Eric

[Qemu-devel] [PATCH 2/2] virtio-balloon: add 'available' counter

2016-02-23 Thread Denis V. Lunev
_AVAIL, to virtio_balloon memory statistics protocol, corresponding to 'Available' in /proc/meminfo. Signed-off-by: Denis V. Lunev Reviewed-by: Eric Blake CC: Igor Redko CC: Michael S. Tsirkin --- hw/virtio/virtio-balloon.c | 1 + include/standard-headers/linux/virtio_

[Qemu-devel] [PATCH 1/2] virtio-balloon: export all balloon statistics

2016-02-23 Thread Denis V. Lunev
egular names. Signed-off-by: Igor Redko Signed-off-by: Denis V. Lunev CC: Michael S. Tsirkin --- hw/virtio/virtio-balloon.c | 30 -- include/hw/virtio/virtio-balloon.h | 3 ++- 2 files changed, 26 insertions(+), 7 deletions(-) diff --git a/hw/virtio/virtio-

Re: [Qemu-devel] [PATCH 1/2] virtio-balloon: export all balloon statistics

2016-02-23 Thread Denis V. Lunev
On 02/23/2016 06:24 PM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2016 at 05:59:44PM +0300, Denis V. Lunev wrote: From: Igor Redko We are making experiments with different autoballooning strategies based on the guest behavior. Thus we need to experiment with different guest statistics. For

[Qemu-devel] [PATCH 2/2] migration (postcopy): move bdrv_invalidate_cache_all of of coroutine context

2016-02-23 Thread Denis V. Lunev
vm_state_main loadvm_process_command loadvm_postcopy_handle_run Signed-off-by: Denis V. Lunev Tested-by: Dr. David Alan Gilbert CC: Paolo Bonzini CC: Juan Quintela CC: Amit Shah --- migration/savevm.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --gi

[Qemu-devel] [PATCH v3 0/2] move qcow2_invalidate_cache() out of coroutine context

2016-02-23 Thread Denis V. Lunev
() closes the image and memset()s BDRVQcowState in the middle. This operation should not be performed in coroutine context. Changes from v2: - subject lines in patches Changes from v1: - fixed spelling. Eric, thank you for spell checking Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Juan

[Qemu-devel] [PATCH 1/2] migration (ordinary): move bdrv_invalidate_cache_all of of coroutine context

2016-02-23 Thread Denis V. Lunev
() closes the image and memset()s BDRVQcowState in the middle. The patch moves processing of bdrv_invalidate_cache_all out of coroutine context for standard migration to avoid that. Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Juan Quintela CC: Amit Shah --- migration/mig

[Qemu-devel] [PATCH v3 0/2] virtio-balloon: improve balloon statistics

2016-02-23 Thread Denis V. Lunev
New counter from the Linux kernel + generic framework to pass currently unknown counters via QMP for debug purposes. Signed-off-by: Denis V. Lunev CC: Igor Redko CC: Michael S. Tsirkin Changes from v2: - put "export unknown counters" code under ifdef Changes from v1: - removed !er

[Qemu-devel] [PATCH 1/2] virtio-balloon: export all balloon statistics

2016-02-23 Thread Denis V. Lunev
egular names. Signed-off-by: Igor Redko Signed-off-by: Denis V. Lunev CC: Michael S. Tsirkin --- configure | 12 hw/virtio/virtio-balloon.c | 32 ++-- include/hw/virtio/virtio-balloon.h | 3 ++- 3 files changed, 40 inserti

[Qemu-devel] [PATCH 2/2] virtio-balloon: add 'available' counter

2016-02-23 Thread Denis V. Lunev
_AVAIL, to virtio_balloon memory statistics protocol, corresponding to 'Available' in /proc/meminfo. Signed-off-by: Denis V. Lunev CC: Igor Redko CC: Michael S. Tsirkin --- hw/virtio/virtio-balloon.c | 1 + include/standard-headers/linux/virtio_balloon.h | 3 ++-

Re: [Qemu-devel] [PATCH v3 0/2] move qcow2_invalidate_cache() out of coroutine context

2016-02-24 Thread Denis V. Lunev
On 02/24/2016 11:22 AM, Amit Shah wrote: On (Tue) 23 Feb 2016 [18:49:00], Denis V. Lunev wrote: There is a possibility to hit an assert in qcow2_get_specific_info that s->qcow_version is undefined. This happens when VM in starting from suspended state, i.e. it processes incoming migration,

[Qemu-devel] [PATCH v4 0/2] move qcow2_invalidate_cache() out of coroutine context

2016-02-24 Thread Denis V. Lunev
pelling. Eric, thank you for spell checking Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Juan Quintela CC: Amit Shah

[Qemu-devel] [PATCH 1/2] migration (ordinary): move bdrv_invalidate_cache_all of of coroutine context

2016-02-24 Thread Denis V. Lunev
() closes the image and memset()s BDRVQcowState in the middle. The patch moves processing of bdrv_invalidate_cache_all out of coroutine context for standard migration to avoid that. Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Juan Quintela CC: Amit Shah --- include/migration/mig

[Qemu-devel] [PATCH 2/2] migration (postcopy): move bdrv_invalidate_cache_all of of coroutine context

2016-02-24 Thread Denis V. Lunev
vm_state_main loadvm_process_command loadvm_postcopy_handle_run Signed-off-by: Denis V. Lunev Tested-by: Dr. David Alan Gilbert CC: Paolo Bonzini CC: Juan Quintela CC: Amit Shah --- migration/savevm.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-)

Re: [Qemu-devel] [PATCH v3 0/2] virtio-balloon: improve balloon statistics

2016-02-24 Thread Denis V. Lunev
On 02/24/2016 05:34 PM, Michael S. Tsirkin wrote: On Wed, Feb 24, 2016 at 10:50:46AM +0300, Denis V. Lunev wrote: New counter from the Linux kernel + It is in AKPM's linux-next kernel but I will revert it there if the suggested interface extension is not submitted to the Virtio ABI comm

Re: [Qemu-devel] [PATCH 1/2] virtio-balloon: export all balloon statistics

2016-02-24 Thread Denis V. Lunev
On 02/24/2016 06:43 PM, Eric Blake wrote: On 02/24/2016 07:31 AM, Michael S. Tsirkin wrote: One of the benefits is forward compatibility, so that counters that have graduated into supported ones and have got their own number and name, can be made to work with qemu that doesn't yet recognize them

Re: [Qemu-devel] [PULL 0/6] migration pull

2016-02-26 Thread Denis V. Lunev
On 02/26/2016 04:15 PM, Amit Shah wrote: On (Fri) 26 Feb 2016 [12:23:01], Peter Maydell wrote: On 26 February 2016 at 09:55, Amit Shah wrote: The following changes since commit 0c6940d086f39bbf725d96104abe46da87429cb6: build: [bsd-user] Rename "syscall.h" to "target_syscall.h" in target d

Re: [Qemu-devel] [PULL 0/6] migration pull

2016-02-26 Thread Denis V. Lunev
On 02/26/2016 06:14 PM, Amit Shah wrote: On (Fri) 26 Feb 2016 [17:58:34], Denis V. Lunev wrote: On 02/26/2016 04:15 PM, Amit Shah wrote: On (Fri) 26 Feb 2016 [12:23:01], Peter Maydell wrote: Hi. I'm afraid this causes make check to fail: Oops, I should've caught that. /i386/

Re: [Qemu-devel] [PATCH v3 0/2] virtio-balloon: improve balloon statistics

2016-02-26 Thread Denis V. Lunev
On 02/24/2016 06:39 PM, Michael S. Tsirkin wrote: On Wed, Feb 24, 2016 at 06:33:38PM +0300, Denis V. Lunev wrote: On 02/24/2016 05:34 PM, Michael S. Tsirkin wrote: On Wed, Feb 24, 2016 at 10:50:46AM +0300, Denis V. Lunev wrote: New counter from the Linux kernel + It is in AKPM's linux

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-26 Thread Denis V. Lunev
On 02/26/2016 11:03 PM, Paolo Bonzini wrote: On 26/02/2016 20:55, Paolo Bonzini wrote: On 19/02/2016 09:51, Markus Armbruster wrote: Is it an abuse to "Get LBA Status" to return dirty information? Because in SCSI the command reports "mapped", "allocated" and "anchored" statuses. Does that mea

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-26 Thread Denis V. Lunev
On 02/26/2016 10:55 PM, Paolo Bonzini wrote: On 19/02/2016 09:51, Markus Armbruster wrote: Is it an abuse to "Get LBA Status" to return dirty information? Because in SCSI the command reports "mapped", "allocated" and "anchored" statuses. Does that mean NBD will use a different status set? Perh

Re: [Qemu-devel] [PATCH v3 0/2] virtio-balloon: improve balloon statistics

2016-03-01 Thread Denis V. Lunev
On 02/24/2016 10:50 AM, Denis V. Lunev wrote: New counter from the Linux kernel + generic framework to pass currently unknown counters via QMP for debug purposes. Signed-off-by: Denis V. Lunev CC: Igor Redko CC: Michael S. Tsirkin Changes from v2: - put "export unknown counters"

Re: [Qemu-devel] [PATCH v3 1/1] hyperv: cpu hotplug fix with HyperV enabled

2016-03-01 Thread Denis V. Lunev
On 02/22/2016 12:13 PM, Denis V. Lunev wrote: With Hyper-V enabled CPU hotplug stops working. The CPU appears in device manager on Windows but does not appear in peformance monitor and control panel. The root of the problem is the following. Windows checks

Re: [Qemu-devel] [PATCH 01/11] kvm/x86: move Hyper-V MSR's/hypercall code into hyperv.c file

2015-06-25 Thread Denis V. Lunev
On 22/06/15 19:04, Denis V. Lunev wrote: From: Andrey Smetanin This patch introduces Hyper-V related source code file - hyperv.c and per vm and per vcpu hyperv context structures. All Hyper-V MSR's and hypercall code moved into hyperv.c. All hyper-v kvm/vcpu fields moved into approp

[Qemu-devel] [PATCH v6 0/10] QGA: disk and volume info for Windows & guest exec

2015-06-30 Thread Denis V. Lunev
e-mail in patch 4 & and wrong mail in patch 10 Changes from v3: - fixed warnings with type mismatch - fixed the behavior of command quest-get-fsinfo in case when we do not have CD in CD-ROM and etc. Before this changes command failed with error 0x15 ERROR_DEVICE_NOT_READY. Now we are simply skipping this volume. - merged volume info & guest exec patchsets, resolved conflicts between them Changes from v2: - return code of commands changed to dictionary - ported to current HEAD - new way for moving pipe to non-blocking state (universal) Changes from v1: - Windows version of the patchset is added - SIGPIPE processing is added for Unix version of the patchset - added guest_exec_file_busy() to prevent GuestFileHandle* object from being deleted in case it's used in guest-exec command. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Michael Roth

[Qemu-devel] [PATCH 04/10] qga: handle possible SIGPIPE in guest-file-write

2015-06-30 Thread Denis V. Lunev
Krishtal Acked-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Michael Roth --- qga/commands-posix.c | 16 qga/main.c | 6 ++ 2 files changed, 22 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 81701b5..b1478bf 100644

[Qemu-devel] [PATCH 05/10] qga: guest-pipe-open for Windows guest

2015-06-30 Thread Denis V. Lunev
From: Olga Krishtal The patch creates anonymous pipe that can be passed as stdin/stdout/stderr handle to a child process spawned using forthcoming guest-file-exec command. Working with a pipe is done using the existing guest-file-* API. Signed-off-by: Olga Krishtal Signed-off-by: Denis V

[Qemu-devel] [PATCH 01/10] util, qga: drop guest_file_toggle_flags

2015-06-30 Thread Denis V. Lunev
-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Michael Roth --- qga/commands-posix.c | 27 ++- util/oslib-win32.c | 52 +++- 2 files changed, 49 insertions(+), 30 deletions(-) diff --git a/qga

[Qemu-devel] [PATCH 08/10] qga: added mountpoint and filesystem type for single volume

2015-06-30 Thread Denis V. Lunev
a single volume. It is worth mentioning that the information about every disk in the volume can be queried via IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Michael Roth --- qga/commands-win32.c | 51

[Qemu-devel] [PATCH 09/10] qga: added bus type and disk location path

2015-06-30 Thread Denis V. Lunev
Krishtal Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Michael Roth --- qga/commands-win32.c | 122 ++- qga/qapi-schema.json | 14 +- 2 files changed, 134 insertions(+), 2 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c

[Qemu-devel] [PATCH 07/10] qga: added empty qmp_quest_get_fsinfo functionality.

2015-06-30 Thread Denis V. Lunev
. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Michael Roth --- qga/commands-win32.c | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index ad445d9..0544ee4 100644 --- a

<    4   5   6   7   8   9   10   11   12   13   >