Signed-off-by: Denis V. Lunev
Reviwed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
tests/qemu-iotests/115 | 9 +
tests/qemu-iotests/115.out | 17 +
2 files changed, 26 insertions(+)
diff --git a/tests/qemu-iotests/115 b/tests/qemu-iotests/115
index
calculate offset of the BAT entry in the image file.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index
close will do the job right.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 50 ++
1 file changed, 50 insertions(+)
diff --git a/block/parallels.c b/block/parallels.c
index 0e5d4c3
This metadata cache would allow to properly batch BAT updates to disk
in next patches. These updates will be properly aligned to avoid
read-modify-write transactions on block level.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block
rom 800 Kb/sec to 45 Mb/sec.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index bafc74b..2605c1a 100644
--- a/block/
this follows QEMU coding convention
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index 4f9cd8d..dca0df6 100644
Signed-off-by: Denis V. Lunev
Reviwed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 28338ec..7ef3136 100644
--- a/block/parallels.c
+++ b/block
deduplicate copy/paste arithmetcs
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index a7c66dc..6bc5e62
This will help to avoid forward declarations for upcoming parallels_check
Some very obvious formatting fixes were made to the moved code to make
checkpatch happy.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 185
after synchronize_rcu
to free inside call_rcu.
Signed-off-by: Denis V. Lunev
Reported-by: Igor Redko
Tested-by: Igor Redko
CC: Anna Melekhova
CC: Juan Quintela
CC: Amit Shah
CC: Paolo Bonzini
CC: Wen Congyang
---
migration/ram.c | 44 +++-
1 file change
.
Thanks,
On (Mon) 28 Sep 2015 [14:41:58], Denis V. Lunev wrote:
Release qemu global mutex before call synchronize_rcu().
synchronize_rcu() waiting for all readers to finish their critical
sections. There is at least one critical section in which we try
to get QGM (critical section is in
On 09/29/2015 08:13 AM, Amit Shah wrote:
There have been multiple versions of this patch on the list, can you
please annotate that this is v3 so it supersedes the earlier v2?
Also, please include a changelog in the description in patch 0 so we
know what happened between the various versions.
Th
out/err
file descriptiors internally to pipes and collects subprocess
output.
Guest-exe-status is modified to return this collected data to requestor
in base64 encoding.
Signed-off-by: Yuri Pudgorodskiy
Signed-off-by: Denis V. Lunev
CC: Michael Roth
---
qga/commands.c | 173
.
Signed-off-by: Denis V. Lunev
Signed-off-by: Yuri Pudgorodskiy
CC: Michael Roth
Denis V. Lunev (2):
qga: drop guest_file_init helper and replace it with static
initializers
qga: handle possible SIGPIPE in guest-file-write
Yuri Pudgorodskiy (3):
qga: handle G_IO_STATUS_AGAIN in
From: Yuri Pudgorodskiy
glib may return G_IO_STATUS_AGAIN which is actually not an error.
Also fixed a bug when on incomplete write buf pointer was not adjusted.
Signed-off-by: Yuri Pudgorodskiy
Signed-off-by: Denis V. Lunev
CC: Michael Roth
---
qga/channel-posix.c | 23
On 09/15/2015 11:27 AM, Vasiliy Tolstov wrote:
2015-09-15 11:15 GMT+03:00 Denis V. Lunev :
we have discussed new approach on KVM forum
with a bit reduced set (guest-pipe-open/close
code should not be in the first version) and in
progress with a rework. I think that I'll post new version
a
qemu-ga should not exit on guest-file-write to pipe without read end
but proper error code should be returned. The behavior of the
spawned process should be default thus SIGPIPE processing should be
reset to default after fork() but before exec().
Signed-off-by: Denis V. Lunev
Signed-off-by
This just makes code shorter and better.
Signed-off-by: Denis V. Lunev
Signed-off-by: Yuri Pudgorodskiy
CC: Michael Roth
---
qga/commands-posix.c | 10 +++---
qga/commands-win32.c | 10 +++---
2 files changed, 6 insertions(+), 14 deletions(-)
diff --git a/qga/commands-posix.c b/qga
specify stdin in guest-exec command
and to get collected stdout/stderr with guest-exec-status.
Signed-off-by: Yuri Pudgorodskiy
Signed-off-by: Denis V. Lunev
CC: Michael Roth
---
qga/commands.c | 168 +++
qga/qapi-schema.json | 57
On 10/01/2015 10:50 AM, Vasiliy Tolstov wrote:
2015-10-01 10:43 GMT+03:00 Denis V. Lunev :
new simplified version posted. Can you pls look & review?
Sorry, i cant find it in qemu list
Subject: [PATCH 0/5] simplified QEMU guest exec
Date: Thu, 1 Oct 2015 10:37:58 +0300
Messag
qemu-ga should not exit on guest-file-write to pipe without read end
but proper error code should be returned. The behavior of the
spawned process should be default thus SIGPIPE processing should be
reset to default after fork() but before exec().
Signed-off-by: Denis V. Lunev
Signed-off-by
.
Changes from v1:
- use g_new0() instead of g_malloc0
- added explicit 'exited' bool to GuestExecStatus
- reworked documentation for GuestExecStatus
- added comment about platform-specific signals and exception codes
- replaces 'pid' with 'handle' in guest-exec api
Signed-
From: Yuri Pudgorodskiy
glib may return G_IO_STATUS_AGAIN which is actually not an error.
Also fixed a bug when on incomplete write buf pointer was not adjusted.
Signed-off-by: Yuri Pudgorodskiy
Signed-off-by: Denis V. Lunev
Reviewed-by: Michael Roth
---
qga/channel-posix.c | 23
specify stdin in guest-exec command
and to get collected stdout/stderr with guest-exec-status.
Signed-off-by: Yuri Pudgorodskiy
Signed-off-by: Denis V. Lunev
CC: Michael Roth
---
qga/commands.c | 188 +++
qga/qapi-schema.json | 62
This just makes code shorter and better.
Signed-off-by: Denis V. Lunev
Signed-off-by: Yuri Pudgorodskiy
Reviewed-by: Michael Roth
---
qga/commands-posix.c | 10 +++---
qga/commands-win32.c | 10 +++---
2 files changed, 6 insertions(+), 14 deletions(-)
diff --git a/qga/commands
out/err
file descriptiors internally to pipes and collects subprocess
output.
Guest-exe-status is modified to return this collected data to requestor
in base64 encoding.
Signed-off-by: Yuri Pudgorodskiy
Signed-off-by: Denis V. Lunev
CC: Michael Roth
---
qga/commands.c | 175
On 10/06/2015 09:46 PM, John Snow wrote:
Is there a convenient way of "pausing" or stalling a live migration to
allow methodical testing of race conditions?
I'd like to instrument something along the lines of:
(1) Live migration begins.
(2) migration is artificially halted or paused, but QEMU i
On 10/05/2015 05:57 PM, Denis V. Lunev wrote:
This patchset provides simplified guest-exec functionality. The
idea is simple. We drop original guest-pipe-open etc stuff and provides
simple and dumb API:
- spawn process (originally with stdin/stdout/stderr as /dev/null)
- later simple buffer is
. Fill corresponding fields in MigrationState.
8. After finishing of hook_ram_sync return error code "-42"
9. In migration_thread() error code "-42" is interpreted as successful
completion and MigrationStatus is changed
Signed-off-by: Denis V. Lunev
Signed-off-by: Igor R
understanding of the code. On the other
hand, using existing code decreases volume of the patchset and its
impact.
Signed-off-by: Igor Redko
Reviewed-by: Anna Melekhova
Signed-off-by: Denis V. Lunev
---
include/migration/migration.h | 1 +
include/migration/qemu-file.h | 1 +
migration/qemu
ase and recalculated only after transferring all memory
and if this process took more than 1 sec. So maybe just nobody noticed
that bug.
Signed-off-by: Igor Redko
Reviewed-by: Anna Melekhova
Signed-off-by: Denis V. Lunev
---
migration/migration.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
memory pages are processed one by one (~60msec per 4GB VM)
Signed-off-by: Igor Redko
Reviewed-by: Anna Melekhova
Signed-off-by: Denis V. Lunev
---
migration/migration.c | 8
migration/test.c | 36
2 files changed, 44 insertions(+)
diff --git a
rare circumstances)
If we left this check as is, VM would stop during test (that would happen
also under rare condition: no pages have been dirtied during test).
Signed-off-by: Igor Redko
Reviewed-by: Anna Melekhova
Signed-off-by: Denis V. Lunev
---
migration/migration.c | 3 ++-
migration/
ook, presence of implementation of which allows
to decide whether the migration is true
Signed-off-by: Igor Redko
Reviewed-by: Anna Melekhova
Signed-off-by: Denis V. Lunev
---
include/migration/migration.h | 2 ++
migration/migration.c | 9 +
qapi-schema.json | 5 -
the size of
the transferred data and drops the data itself.
Also, the Makefile modification to link this file included.
Signed-off-by: Igor Redko
Reviewed-by: Anna Melekhova
Signed-off-by: Denis V. Lunev
---
include/migration/migration.h | 2 ++
migration/Makefile.objs | 2
test migration and true migration
success states.
Signed-off-by: Igor Redko
Reviewed-by: Anna Melekhova
Signed-off-by: Denis V. Lunev
---
migration/migration.c | 12 ++--
qapi-schema.json | 4 +++-
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/migration/migration.c
From: Igor Redko
In this patch the output of the test results was added.
If the test was successfully completed, it would be displayed
in info migrate.
Signed-off-by: Igor Redko
Reviewed-by: Anna Melekhova
Signed-off-by: Denis V. Lunev
---
migration/migration.c | 18 ++
1
On 10/07/2015 02:02 AM, John Snow wrote:
On 10/06/2015 06:40 PM, Denis V. Lunev wrote:
On 10/06/2015 09:46 PM, John Snow wrote:
Is there a convenient way of "pausing" or stalling a live migration to
allow methodical testing of race conditions?
I'd like to instrument something
This just makes code shorter and better.
Signed-off-by: Denis V. Lunev
Signed-off-by: Yuri Pudgorodskiy
Reviewed-by: Michael Roth
---
qga/commands-posix.c | 10 +++---
qga/commands-win32.c | 10 +++---
2 files changed, 6 insertions(+), 14 deletions(-)
diff --git a/qga/commands
From: Yuri Pudgorodskiy
glib may return G_IO_STATUS_AGAIN which is actually not an error.
Also fixed a bug when on incomplete write buf pointer was not adjusted.
Signed-off-by: Yuri Pudgorodskiy
Signed-off-by: Denis V. Lunev
Reviewed-by: Michael Roth
---
qga/channel-posix.c | 23
exception codes
- replaces 'pid' with 'handle' in guest-exec api
Signed-off-by: Denis V. Lunev
Signed-off-by: Yuri Pudgorodskiy
CC: Michael Roth
Denis V. Lunev (2):
qga: drop guest_file_init helper and replace it with static
initializers
qga: handle possible SIG
out/err
file descriptiors internally to pipes and collects subprocess
output.
Guest-exe-status is modified to return this collected data to requestor
in base64 encoding.
Signed-off-by: Yuri Pudgorodskiy
Signed-off-by: Denis V. Lunev
CC: Michael Roth
---
qga/commands.c | 175
specify stdin in guest-exec command
and to get collected stdout/stderr with guest-exec-status.
Signed-off-by: Yuri Pudgorodskiy
Signed-off-by: Denis V. Lunev
CC: Michael Roth
---
qga/commands.c | 188 +++
qga/qapi-schema.json | 62
.
The only problem is that qemu_set_nonblock is void but this should not
be a big deal.
Signed-off-by: Olga Krishtal
Signed-off-by: Denis V. Lunev
Reviewed-by: Yuri Pudgorodskiy
CC: Michael Roth
CC: Stefan Weil
---
qga/commands-win32.c | 6 ++
util/oslib-win32.c | 52
We'd better use generic qemu_set_nonblock directly.
Signed-off-by: Denis V. Lunev
Reviewed-by: Yuri Pudgorodskiy
CC: Michael Roth
---
qga/commands-posix.c | 27 ++-
1 file changed, 2 insertions(+), 25 deletions(-)
diff --git a/qga/commands-posix.c b/qga/com
This patchset is reincarnation of one patch discussed in the scope of
QEMU 2.4 and rejected for that time. Actually we should use
non-blocking descriptors in QGA on Windows in guest-file-open exactly
like was done for Posix.
Signed-off-by: Denis V. Lunev
Signed-off-by: Olga Krishtal
Reviewed-by
qemu-ga should not exit on guest-file-write to pipe without read end
but proper error code should be returned. The behavior of the
spawned process should be default thus SIGPIPE processing should be
reset to default after fork() but before exec().
Signed-off-by: Denis V. Lunev
Signed-off-by
On 10/07/2015 07:47 PM, Max Reitz wrote:
On 05.09.2015 18:43, Vladimir Sementsov-Ogievskiy wrote:
Persistent dirty bitmaps will be saved into qcow2 files. It may be used
as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for
other drives (there may be qcow2 file with zero disk siz
On 10/07/2015 06:05 PM, Eric Blake wrote:
On 10/07/2015 12:20 AM, Denis V. Lunev wrote:
From: Igor Redko
This patch declares a new migration capability that allows
to distinguish between true migration and the test.
An alternative is using a custom URI but in this case the
following problems
On 10/07/2015 12:44 PM, Paolo Bonzini wrote:
On 07/10/2015 08:20, Denis V. Lunev wrote:
+if (migrate_is_test()) {
+/* since no data is transfered during estimation all
+ all measurements below will be incorrect.
+ as well no need for delays
On 10/07/2015 06:08 PM, Eric Blake wrote:
On 10/07/2015 07:56 AM, Dr. David Alan Gilbert wrote:
* Denis V. Lunev (d...@openvz.org) wrote:
From: Igor Redko
In this patch the ability to start a migration with test-only
capability was added. It allows to gather the guest VM’s memory
usage
On 10/07/2015 04:56 PM, Dr. David Alan Gilbert wrote:
* Denis V. Lunev (d...@openvz.org) wrote:
From: Igor Redko
In this patch the ability to start a migration with test-only
capability was added. It allows to gather the guest VM’s memory
usage statistics avoiding time and memory overheads
On 10/08/2015 11:28 PM, John Snow wrote:
On 10/07/2015 03:05 PM, Denis V. Lunev wrote:
On 10/07/2015 07:47 PM, Max Reitz wrote:
On 05.09.2015 18:43, Vladimir Sementsov-Ogievskiy wrote:
Persistent dirty bitmaps will be saved into qcow2 files. It may be used
as 'internal' bitmaps
On 10/07/2015 12:44 PM, Paolo Bonzini wrote:
On 07/10/2015 08:20, Denis V. Lunev wrote:
All calls of this hook will be from ram_save_pending().
At the first call of this hook we need to save the initial
size of VM memory and put the migration thread to sleep for
decent period (downtime for
writing to the
corresponding MSRs.
Signed-off-by: Andrey Smetanin
Reviewed-by: Roman Kagan
Signed-off-by: Denis V. Lunev
CC: Vitaly Kuznetsov
CC: "K. Y. Srinivasan"
CC: Gleb Natapov
CC: Paolo Bonzini
is extended to support GSI-SINT
mapping.
Signed-off-by: Andrey Smetanin
Reviewed-by: Roman Kagan
Signed-off-by: Denis V. Lunev
CC: Vitaly Kuznetsov
CC: "K. Y. Srinivasan"
CC: Gleb Natapov
CC: Paolo Bonzini
---
arch/powerpc/kvm/mpic.c | 18 +++
arch/s390/kvm/interrupt.c
From: Andrey Smetanin
A new vcpu exit is introduced to notify the userspace of the
changes in Hyper-V synic configuraion triggered by guest writing to the
corresponding MSRs.
Signed-off-by: Andrey Smetanin
Reviewed-by: Roman Kagan
Signed-off-by: Denis V. Lunev
CC: Vitaly Kuznetsov
CC: "
On 10/07/2015 01:32 PM, Denis V. Lunev wrote:
This patchset provides simplified guest-exec functionality. The
idea is simple. We drop original guest-pipe-open etc stuff and provides
simple and dumb API:
- spawn process (originally with stdin/stdout/stderr as /dev/null)
- later simple buffer is
Signed-off-by: Denis V. Lunev
CC: Markus Armbruster
CC: Luiz Capitulino
CC: Eric Blake
---
include/qemu/log.h | 1 +
monitor.c | 4
qemu-log.c | 1 +
3 files changed, 6 insertions(+)
diff --git a/include/qemu/log.h b/include/qemu/log.h
index f880e66..dfb587e 100644
--- a
On 10/07/2015 01:59 PM, Denis V. Lunev wrote:
This patchset is reincarnation of one patch discussed in the scope of
QEMU 2.4 and rejected for that time. Actually we should use
non-blocking descriptors in QGA on Windows in guest-file-open exactly
like was done for Posix.
Signed-off-by: Denis V
On 10/12/2015 11:41 AM, Denis V. Lunev wrote:
From: Pavel Butsykin
This log would be very welcome for long-term diagnostics of the system
in the production. This log is at least necessary to understand what
has been happened on the system and to identify issues at higher-level
subsystems
On 10/12/2015 04:42 PM, Eric Blake wrote:
On 10/09/2015 07:39 AM, Denis V. Lunev wrote:
From: Andrey Smetanin
A new vcpu exit is introduced to notify the userspace of the
changes in Hyper-V synic configuraion triggered by guest writing to the
s/configuraion/configuration/
Is 'synic'
On 10/12/2015 04:49 PM, Eric Blake wrote:
On 10/12/2015 02:41 AM, Denis V. Lunev wrote:
From: Pavel Butsykin
This log would be very welcome for long-term diagnostics of the system
in the production. This log is at least necessary to understand what
has been happened on the system and to
as described in the comment of the function
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
CC: Paolo Bonzini
---
block/io.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/block/io.c b/block/io.c
index 5ac6256..2e98d45 100644
--- a/block/io.c
+++ b/block/io.c
locking added
- comment is rewritten
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
CC: Paolo Bonzini
Denis V. Lunev (4):
fifolock: create rfifolock_is_locked helper
aio_context: create aio_context_is_locked helper
io: add locking constraints check into bdrv_drain to ensure locking
This helper is necessary to ensure locking constraints.
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
CC: Paolo Bonzini
---
include/qemu/rfifolock.h | 1 +
util/rfifolock.c | 9 +++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/include/qemu/rfifolock.h b
This helper is necessary to ensure locking constraints.
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
CC: Paolo Bonzini
---
async.c | 5 +
include/block/aio.h | 3 +++
2 files changed, 8 insertions(+)
diff --git a/async.c b/async.c
index bdc64a3..4a9250e 100644
--- a
V. Lunev
CC: Stefan Hajnoczi
CC: Paolo Bonzini
CC: Juan Quintela
CC: Amit Shah
---
block/snapshot.c | 5 +
migration/savevm.c | 7 +++
2 files changed, 12 insertions(+)
diff --git a/block/snapshot.c b/block/snapshot.c
index 89500f2..f6fa17a 100644
--- a/block/snapshot.c
+++ b/block
loading VM state
Signed-off-by: Pavel Butsykin
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
CC: "Michael S. Tsirkin"
CC: Kevin Wolf
CC: Paolo Bonzini
---
hw/block/virtio-blk.c | 5 +
hw/scsi/virtio-scsi.c | 5 +
2 files changed, 10 insertions(+)
diff --git a/hw/block/vir
From: Olga Krishtal
CloseHandle use HANDLE as an argument, but not *HANDLE
Signed-off-by: Olga Krishtal
Signed-off-by: Denis V. Lunev
CC: Michael Roth
CC: Stefan Weil
---
qga/commands-win32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/commands-win32.c b/qga
win32 there is a difference between file discriptors and file handles,
and all file ops are made via Win32 api.
Signed-off-by: Olga Krishtal
Signed-off-by: Denis V. Lunev
CC: Michael Roth
CC: Stefan Weil
---
include/qemu/sockets.h | 2 ++
qga/commands-win32.c | 6 ++
util/oslib-win32.c
- switched setting non-block for pipes to use separate function
Changes from v1:
- call to qemu_fd_register is moved to a proper place
- moved declaration of opt to a proper place
Signed-off-by: Denis V. Lunev
Signed-off-by: Olga Krishtal
CC: Yuri Pudgorodskiy
CC: Michael Roth
Denis V. Lunev (1
We'd better use generic qemu_set_nonblock directly.
Signed-off-by: Denis V. Lunev
Reviewed-by: Yuri Pudgorodskiy
Reviewed-by: Eric Blake
CC: Michael Roth
---
qga/commands-posix.c | 27 ++-
1 file changed, 2 insertions(+), 25 deletions(-)
diff --git a/qga/com
On 10/27/2015 09:12 PM, Paolo Bonzini wrote:
On 27/10/2015 15:09, Denis V. Lunev wrote:
aio_context should be locked in the similar way as was done in QMP
snapshot creation in the other case there are a lot of possible
troubles if native AIO mode is enabled for disk.
- the command can hang
On 10/27/2015 09:41 PM, Paolo Bonzini wrote:
On 27/10/2015 15:09, Denis V. Lunev wrote:
The following test
while /bin/true ; do
virsh snapshot-create rhel7
sleep 10
virsh snapshot-delete rhel7 --current
done
with enabled iothreads on a running VM leads to a
On 10/27/2015 10:11 PM, Michael Roth wrote:
Quoting Denis V. Lunev (2015-10-27 12:48:43)
From: Olga Krishtal
Set fd non-blocking to avoid common use cases (like reading from a
named pipe) from hanging the agent. This was missed in the original
code.
The patch introduces analog of
On 10/27/2015 10:05 PM, Denis V. Lunev wrote:
On 10/27/2015 09:41 PM, Paolo Bonzini wrote:
On 27/10/2015 15:09, Denis V. Lunev wrote:
The following test
while /bin/true ; do
virsh snapshot-create rhel7
sleep 10
virsh snapshot-delete rhel7 --current
done
On 10/28/2015 01:11 PM, Juan Quintela wrote:
"Denis V. Lunev" wrote:
aio_context should be locked in the similar way as was done in QMP
snapshot creation in the other case there are a lot of possible
troubles if native AIO mode is enabled for disk.
- the command can hang (HMP th
This helper is necessary to ensure locking constraints.
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
CC: Paolo Bonzini
---
include/qemu/rfifolock.h | 1 +
util/rfifolock.c | 9 +++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/include/qemu/rfifolock.h b
This helper is necessary to ensure locking constraints.
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
CC: Paolo Bonzini
---
async.c | 5 +
include/block/aio.h | 3 +++
2 files changed, 8 insertions(+)
diff --git a/async.c b/async.c
index bdc64a3..4a9250e 100644
--- a
(aio_context_is_locked(aio_context));
should be widely used to ensure proper locking.
Changes from v2:
- droppped patch 5 as already merged
- changed locking scheme in patch 4 by suggestion of Juan
Changes from v1:
- aio-context locking added
- comment is rewritten
Signed-off-by: Denis V. Lunev
CC: Stefan
as described in the comment of the function
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
CC: Paolo Bonzini
---
block/io.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/block/io.c b/block/io.c
index 5ac6256..2e98d45 100644
--- a/block/io.c
+++ b/block/io.c
drivers. This change should influence only HMP snapshot
operations.
AioContext lock is reqursive. Thus nested locking should not be a problem.
Signed-off-by: Denis V. Lunev
CC: Stefan Hajnoczi
CC: Paolo Bonzini
CC: Juan Quintela
CC: Amit Shah
---
block/snapshot.c | 5 +
migration/savevm.c
From: Olga Krishtal
CloseHandle use HANDLE as an argument, but not *HANDLE
Signed-off-by: Olga Krishtal
Signed-off-by: Denis V. Lunev
Reviewed-by: Stefan Weil
CC: Michael Roth
---
qga/commands-win32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/commands-win32.c
We'd better use generic qemu_set_nonblock directly.
Signed-off-by: Denis V. Lunev
Reviewed-by: Yuri Pudgorodskiy
Reviewed-by: Eric Blake
CC: Michael Roth
---
qga/commands-posix.c | 27 ++-
1 file changed, 2 insertions(+), 25 deletions(-)
diff --git a/qga/com
proper place
Signed-off-by: Denis V. Lunev
Signed-off-by: Olga Krishtal
CC: Yuri Pudgorodskiy
CC: Michael Roth
Denis V. Lunev (1):
qga: drop hand-made guest_file_toggle_flags helper
Olga Krishtal (2):
qga: fixed CloseHandle in qmp_guest_file_open
qga: set file descriptor in
qemu_set_non/block is impossible, because for
win32 there is a difference between file discriptors and file handles,
and all file ops are made via Win32 api.
Signed-off-by: Olga Krishtal
Signed-off-by: Denis V. Lunev
CC: Michael Roth
CC: Stefan Weil
---
qga/commands-win32.c | 27
On 10/26/2015 11:05 PM, Christian Borntraeger wrote:
Am 26.10.2015 um 18:10 schrieb Denis V. Lunev:
From: Paolo Bonzini
Mention the ftrace backend too.
Signed-off-by: Paolo Bonzini
Signed-off-by: Denis V. Lunev
Reviewed-by: Christian Borntraeger
Can you make that
Acked-by: Christian
On 10/27/2015 10:49 PM, Michael Roth wrote:
Quoting Denis V. Lunev (2015-10-27 14:13:57)
On 10/27/2015 10:11 PM, Michael Roth wrote:
Quoting Denis V. Lunev (2015-10-27 12:48:43)
From: Olga Krishtal
Set fd non-blocking to avoid common use cases (like reading from a
named pipe) from hanging
On 10/28/2015 06:33 PM, Juan Quintela wrote:
"Denis V. Lunev" wrote:
aio_context should be locked in the similar way as was done in QMP
snapshot creation in the other case there are a lot of possible
troubles if native AIO mode is enabled for disk.
- the command can hang (HMP th
On 10/29/2015 08:23 PM, Stefan Hajnoczi wrote:
On Mon, Oct 26, 2015 at 12:10:20PM +0300, Denis V. Lunev wrote:
From: Paolo Bonzini
This is cleaner, and improves error reporting with -daemonize.
Signed-off-by: Paolo Bonzini
Signed-off-by: Denis V. Lunev
Reviewed-by: Christian Borntraeger
From: Paolo Bonzini
Print a list of trace points
Signed-off-by: Paolo Bonzini
Signed-off-by: Denis V. Lunev
Acked-by: Christian Borntraeger
---
qemu-options.hx | 2 ++
trace/control.c | 21 -
trace/control.h | 7 +++
3 files changed, 29 insertions(+), 1 deletion
Signed-off-by: Paolo Bonzini
Signed-off-by: Denis V. Lunev
Acked-by: Christian Borntraeger
---
qemu-options.hx | 10 +-
trace/control.c | 48 +++-
trace/control.h | 9 +
vl.c| 11 +--
4 files changed, 54 inserti
.
Signed-off-by: Denis V. Lunev
Reviewed-by: Paolo Bonzini
---
vl.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/vl.c b/vl.c
index 0424ce5..4261662 100644
--- a/vl.c
+++ b/vl.c
@@ -4088,10 +4088,8 @@ int main(int argc, char **argv, char **envp
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Denis V. Lunev
Acked-by: Christian Borntraeger
---
configure | 4 ++--
include/qemu/log.h | 1 +
scripts/tracetool/backend/{stderr.py => log.py} |
From: Paolo Bonzini
This is cleaner, and improves error reporting with -daemonize.
Signed-off-by: Paolo Bonzini
Signed-off-by: Denis V. Lunev
Acked-by: Christian Borntraeger
---
qemu-io.c | 2 +-
trace/control.c | 17 -
trace/control.h | 13 -
trace
From: Paolo Bonzini
This is cleaner and has two advantages. First, it improves error
reporting with -daemonize. Second, multiple "-trace events" options
now cumulate.
Signed-off-by: Paolo Bonzini
Signed-off-by: Denis V. Lunev
Acked-by: Christian Borntraeger
---
qemu-io.c
From: Paolo Bonzini
This enables integration with other QEMU logging facilities.
Signed-off-by: Paolo Bonzini
Signed-off-by: Denis V. Lunev
Acked-by: Christian Borntraeger
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 5e65dd5
From: Paolo Bonzini
Split the bits that require it to exec/log.h.
Signed-off-by: Paolo Bonzini
Signed-off-by: Denis V. Lunev
Acked-by: Christian Borntraeger
---
bsd-user/main.c | 1 +
cpu-exec.c| 1 +
exec.c| 1 +
hw/acpi
log will become common facility with tracepoints support in next step.
Signed-off-by: Denis V. Lunev
Reviewed-by: Paolo Bonzini
---
Makefile.objs| 1 -
util/Makefile.objs | 1 +
qemu-log.c => util/log.c | 0
3 files changed, 1 insertion(+), 1 deletion(-)
rename qemu-lo
401 - 500 of 2549 matches
Mail list logo
