[Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2019-06-10 Thread Denis Plotnikov
on the channel level. Fortunately, monitor protocol is synchronous right now thus we should not face side effects in reality. Signed-off-by: Denis V. Lunev Signed-off-by: Denis Plotnikov --- include/monitor/monitor.h | 2 +- monitor.c | 2 +- 2 files changed, 2 insertions(+), 2

Re: [Qemu-devel] [PATCH v5] qemu-io: add pattern file for write command

2019-06-10 Thread Denis Plotnikov
On 31.05.2019 18:13, Eric Blake wrote: > On 5/31/19 2:46 AM, Denis Plotnikov wrote: >> The patch allows to provide a pattern file for write >> command. There was no similar ability before. >> >> Signed-off-by: Denis Plotnikov >> --- >> v5: >>* fi

[Qemu-devel] [PATCH v6] qemu-io: add pattern file for write command

2019-06-10 Thread Denis Plotnikov
The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v6: * the pattern file is read once to reduce io v5: * file name initiated with null to make compilers happy v4: * missing signed-off clause added v3

Re: [Qemu-devel] [PATCH 0/3] migration: add sztd compression

2019-03-11 Thread Denis Plotnikov
ping ping ping! On 04.03.2019 18:10, Denis Plotnikov wrote: > ping! > > On 26.02.2019 16:15, Denis Plotnikov wrote: >> zstd date compression algorithm shows better performance on data compression. >> It might be useful to employ the algorithm in VM migration to reduce CPU

[PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-10-18 Thread Denis Plotnikov
Stefan Hajnoczi CC: Kevin Wolf CC: Max Reitz CC: Gerd Hoffmann Signed-off-by: Denis V. Lunev Signed-off-by: Denis Plotnikov --- hw/block/virtio-blk.c | 3 ++- hw/scsi/vhost-scsi.c| 2 ++ hw/scsi/virtio-scsi.c | 4 +++- include/hw/virtio/virtio-blk.h | 1 + inclu

[PATCH] blockdev: modify blockdev-change-medium to change non-removable device

2019-10-18 Thread Denis Plotnikov
migration phase, the fake image file is replaced with the real one. Signed-off-by: Denis Plotnikov --- blockdev.c | 69 +++- hmp.c| 2 ++ qapi/block-core.json | 7 +++-- qmp.c| 3 +- 4 files changed, 57 insertions

Re: [PATCH] blockdev: modify blockdev-change-medium to change non-removable device

2019-10-20 Thread Denis Plotnikov
On 18.10.2019 18:02, Max Reitz wrote: > On 18.10.19 14:09, Denis Plotnikov wrote: >> The modification is useful to workaround exclusive file access restrictions, >> e.g. to implement VM migration with shared disk stored on a storage with >> the exclusive file opening model

Re: [PATCH] blockdev: modify blockdev-change-medium to change non-removable device

2019-10-22 Thread Denis Plotnikov
On 22.10.2019 14:05, Max Reitz wrote: > On 21.10.19 08:50, Denis Plotnikov wrote: >> On 18.10.2019 18:02, Max Reitz wrote: >>> On 18.10.19 14:09, Denis Plotnikov wrote: >>>> The modification is useful to workaround exclusive file access >>>> restrictions

Re: [PATCH] blockdev: modify blockdev-change-medium to change non-removable device

2019-10-22 Thread Denis Plotnikov
On 22.10.2019 16:18, Max Reitz wrote: > On 22.10.19 14:53, Denis Plotnikov wrote: >> On 22.10.2019 14:05, Max Reitz wrote: >>> On 21.10.19 08:50, Denis Plotnikov wrote: >>>> On 18.10.2019 18:02, Max Reitz wrote: >>>>> On 18.10.19 14:09, Denis Plotniko

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-10-23 Thread Denis Plotnikov
On 21.10.2019 16:24, Stefan Hajnoczi wrote: > On Fri, Oct 18, 2019 at 02:55:47PM +0300, Denis Plotnikov wrote: >> From: "Denis V. Lunev" >> >> Linux guests submit IO requests no longer than PAGE_SIZE * max_seg >> field reported by SCSI controler. Thus typi

Re: [PATCH v2] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-13 Thread Denis Plotnikov
On 12.02.2020 18:43, Stefan Hajnoczi wrote: On Tue, Feb 11, 2020 at 05:14:14PM +0300, Denis Plotnikov wrote: The goal is to reduce the amount of requests issued by a guest on 1M reads/writes. This rises the performance up to 4% on that kind of disk access pattern. The maximum chunk size to

Re: [PATCH v2] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-13 Thread Denis Plotnikov
On 13.02.2020 12:08, Stefan Hajnoczi wrote: On Thu, Feb 13, 2020 at 11:08:35AM +0300, Denis Plotnikov wrote: On 12.02.2020 18:43, Stefan Hajnoczi wrote: On Tue, Feb 11, 2020 at 05:14:14PM +0300, Denis Plotnikov wrote: The goal is to reduce the amount of requests issued by a guest on 1M

Re: [PATCH v2] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-13 Thread Denis Plotnikov
On 13.02.2020 14:45, Stefan Hajnoczi wrote: On Thu, Feb 13, 2020 at 12:28:25PM +0300, Denis Plotnikov wrote: On 13.02.2020 12:08, Stefan Hajnoczi wrote: On Thu, Feb 13, 2020 at 11:08:35AM +0300, Denis Plotnikov wrote: On 12.02.2020 18:43, Stefan Hajnoczi wrote: On Tue, Feb 11, 2020 at 05

[PATCH v2] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-13 Thread Denis Plotnikov
the original problem statment: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg03721.html Suggested-by: Denis V. Lunev Signed-off-by: Denis Plotnikov --- hw/block/virtio-blk.c | 2 +- hw/core/machine.c | 2 ++ hw/scsi/virtio-scsi.c | 2 +- 3 files changed, 4 insertions(+), 2

[PATCH v3] virtio: increase virtqueue size for virtio-scsi and virtio-blk

2020-02-13 Thread Denis Plotnikov
://lists.gnu.org/archive/html/qemu-devel/2017-12/msg03721.html Suggested-by: Denis V. Lunev Signed-off-by: Denis Plotnikov --- v3: * typos fixed v2: * seg_max default value changing removed --- hw/block/virtio-blk.c | 2 +- hw/core/machine.c | 2 ++ hw/scsi/virtio-scsi.c | 2 +- 3 files changed, 4

Re: [PATCH v2] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-18 Thread Denis Plotnikov
On 18.02.2020 16:53, Stefan Hajnoczi wrote: On Thu, Feb 13, 2020 at 05:59:27PM +0300, Denis Plotnikov wrote: v1: * seg_max default value changing removed --- The goal is to reduce the amount of requests issued by a guest on 1M reads/writes. This rises the performance up to 4% on that

Re: [PATCH v2] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-18 Thread Denis Plotnikov
On 18.02.2020 16:59, Denis Plotnikov wrote: On 18.02.2020 16:53, Stefan Hajnoczi wrote: On Thu, Feb 13, 2020 at 05:59:27PM +0300, Denis Plotnikov wrote: v1:    * seg_max default value changing removed --- The goal is to reduce the amount of requests issued by a guest on 1M reads/writes

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-12-05 Thread Denis Plotnikov
Ping! On 25.11.2019 12:16, Denis Plotnikov wrote: > > > On 06.11.2019 15:03, Michael S. Tsirkin wrote: >> On Thu, Oct 24, 2019 at 11:34:34AM +, Denis Lunev wrote: >>> On 10/24/19 12:28 AM, Michael S. Tsirkin wrote: >>>> On Fri, Oct 18, 2019 at 02:

[PING]Re: [PATCH v0 2/2] block: allow to set 'drive' property on a realized block device

2019-12-12 Thread Denis Plotnikov
On 18.11.2019 13:50, Denis Plotnikov wrote: > > > On 10.11.2019 22:08, Denis Plotnikov wrote: >> >> On 10.11.2019 22:03, Denis Plotnikov wrote: >>> This allows to change (replace) the file on a block device and is >>> useful >>> to workar

[PING] [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-12-13 Thread Denis Plotnikov
On 05.12.2019 10:59, Denis Plotnikov wrote: > Ping! > > On 25.11.2019 12:16, Denis Plotnikov wrote: >> >> >> On 06.11.2019 15:03, Michael S. Tsirkin wrote: >>> On Thu, Oct 24, 2019 at 11:34:34AM +, Denis Lunev wrote: >>>> On 10/24/19 12:28 AM

[PATCH v4 0/2] virtio: make seg_max virtqueue size dependent

2019-12-16 Thread Denis Plotnikov
series Denis Plotnikov (2): virtio: make seg_max virtqueue size dependent tests: add virtio-scsi and virtio-blk seg_max_adjust test hw/block/virtio-blk.c | 9 +- hw/core/machine.c | 3 + hw/scsi/vhost-scsi.c | 2 + hw/scsi

[PATCH v4 2/2] tests: add virtio-scsi and virtio-blk seg_max_adjust test

2019-12-16 Thread Denis Plotnikov
It tests proper seg_max_adjust settings for all machine types except 'none', 'isapc', 'microvm' Signed-off-by: Denis Plotnikov --- tests/acceptance/virtio_seg_max_adjust.py | 135 ++ 1 file changed, 135 insertions(+) creat

[PATCH v4 1/2] virtio: make seg_max virtqueue size dependent

2019-12-16 Thread Denis Plotnikov
e between old (seg_max = 126 always) and new (seg_max = queue_size - 2) behaviors. Not to change the behavior of the older VMs, prevent setting the default seg_max_adjust value for older machine types. Signed-off-by: Denis Plotnikov --- hw/block/virtio-blk.c | 9 - hw/core/machin

Re: [PATCH v0 2/2] block: allow to set 'drive' property on a realized block device

2019-12-16 Thread Denis Plotnikov
On 13.12.2019 13:32, Kevin Wolf wrote: > Am 18.11.2019 um 11:50 hat Denis Plotnikov geschrieben: >> >> On 10.11.2019 22:08, Denis Plotnikov wrote: >>> On 10.11.2019 22:03, Denis Plotnikov wrote: >>>> This allows to change (replace) the file on a block dev

Re: [PATCH v0 2/2] block: allow to set 'drive' property on a realized block device

2019-12-16 Thread Denis Plotnikov
On 16.12.2019 18:38, Kevin Wolf wrote: > Am 16.12.2019 um 15:51 hat Denis Plotnikov geschrieben: >> On 13.12.2019 13:32, Kevin Wolf wrote: >>> Am 18.11.2019 um 11:50 hat Denis Plotnikov geschrieben: >>>> Another problem here, is that the "size" of the dev

Re: [PATCH v0 1/2] qdev-properties-system: extend set_pionter for unrealized devices

2019-11-22 Thread Denis Plotnikov
On 18.11.2019 21:54, Eduardo Habkost wrote: > On Sun, Nov 10, 2019 at 10:03:09PM +0300, Denis Plotnikov wrote: >> Some device's property can be changed if the device has been already >> realized. For example, it could be "drive" property of a scsi disk device. &

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-11-25 Thread Denis Plotnikov
On 06.11.2019 15:03, Michael S. Tsirkin wrote: > On Thu, Oct 24, 2019 at 11:34:34AM +, Denis Lunev wrote: >> On 10/24/19 12:28 AM, Michael S. Tsirkin wrote: >>> On Fri, Oct 18, 2019 at 02:55:47PM +0300, Denis Plotnikov wrote: >>>> From: "Denis V. Lunev

Re: [PATCH v0 1/2] qdev-properties-system: extend set_pionter for unrealized devices

2019-11-25 Thread Denis Plotnikov
On 25.11.2019 18:30, Eduardo Habkost wrote: > On Fri, Nov 22, 2019 at 11:36:30AM +0000, Denis Plotnikov wrote: >> >> On 18.11.2019 21:54, Eduardo Habkost wrote: >>> On Sun, Nov 10, 2019 at 10:03:09PM +0300, Denis Plotnikov wrote: >>>> Some device's prope

[Qemu-devel] [PATCH v3 1/3] qcow2: introduce compression type feature

2019-08-19 Thread Denis Plotnikov
providing a comparable compression ratio and therefore provides a performance advantage in backup scenarios. The default compression is ZLIB. Images created with ZLIB compression type are backward compatible with older qemu versions. Signed-off-by: Denis Plotnikov --- block/qcow2.c | 94

[Qemu-devel] [PATCH v3 0/3] qcow2: add zstd cluster compression

2019-08-19 Thread Denis Plotnikov
2.5 sys 3.3 0.2 2.0 2.0 Both ZLIB and ZSTD gave the same compression ratio: ~1.5 compressed image size in both cases: ~1.4G Denis Plotnikov (3): qcow2: introduce compression type feature qcow2: rework the cluster compression routine qcow2: add zstd cluster compression block/qcow2

[Qemu-devel] [PATCH v3 3/3] qcow2: add zstd cluster compression

2019-08-19 Thread Denis Plotnikov
size in both cases: 1.4G Signed-off-by: Denis Plotnikov --- block/qcow2-threads.c | 94 ++ block/qcow2.c | 6 +++ configure | 34 +++ docs/interop/qcow2.txt | 20 + qapi/block-core.json | 3 +- 5 files changed

[Qemu-devel] [PATCH v3 2/3] qcow2: rework the cluster compression routine

2019-08-19 Thread Denis Plotnikov
The patch allow to process image compression type defined in the image header and choose an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov --- block/qcow2-threads.c | 78 +++ 1 file changed, 64 insertions(+), 14

[Qemu-devel] [PATCH v9] qemu-io: add pattern file for write command

2019-08-19 Thread Denis Plotnikov
The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v9: * replace flag cast to int with bool [Eric] * fix the error message [Eric] * use qemu_io_free instead of qemu_vfree [Eric] * add function description

Re: [Qemu-devel] [PATCH v7] qemu-io: add pattern file for write command

2019-07-30 Thread Denis Plotnikov
Ping! On Jul 5 2019, at 1:21 pm, Denis Plotnikov wrote: The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v7: * fix variable naming * make code more readable * extend help for write command v6: * the pattern

Re: [Qemu-devel] [PATCH v2 3/3] qcow2: add zstd cluster compression

2019-07-30 Thread Denis Plotnikov
On Jul 9 2019, at 9:18 am, Markus Armbruster wrote: Denis Plotnikov writes: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of compression ratio in comparison with zlib, which, by the moment, has been the only

Re: [Qemu-devel] [PATCH v2 0/3] add zstd cluster compression

2019-07-30 Thread Denis Plotnikov
Hi all! Is there any other comments besides Markus's one about adding zlib/zstd links to compressed cluster layout description? On Jul 4 2019, at 4:09 pm, Denis Plotnikov wrote: change log: v2: * relax the compression type setting restriction in the spec * fix qcow2 header size checking

[Qemu-devel] [PATCH v8] qemu-io: add pattern file for write command

2019-08-07 Thread Denis Plotnikov
The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v8: fix according to Max's comments * get rid of unnecessary buffer for the pattern * buffer allocation just in bytes * take into account the miss

Re: [Qemu-devel] [PATCH v2 0/3] add zstd cluster compression

2019-08-07 Thread Denis Plotnikov
Ping! On Jul 30 2019, at 5:45 pm, Denis Plotnikov wrote: Hi all! Is there any other comments besides Markus's one about adding zlib/zstd links to compressed cluster layout description? On Jul 4 2019, at 4:09 pm, Denis Plotnikov wrote: change log: v2: * relax the compression type se

Re: [PATCH v1 2/4] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-04 Thread Denis Plotnikov
On 30.01.2020 17:58, Stefan Hajnoczi wrote: On Wed, Jan 29, 2020 at 05:07:00PM +0300, Denis Plotnikov wrote: The goal is to reduce the amount of requests issued by a guest on 1M reads/writes. This rises the performance up to 4% on that kind of disk access pattern. The maximum chunk size to

Re: [PATCH v1 2/4] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-07 Thread Denis Plotnikov
On 05.02.2020 14:19, Stefan Hajnoczi wrote: On Tue, Feb 04, 2020 at 12:59:04PM +0300, Denis Plotnikov wrote: On 30.01.2020 17:58, Stefan Hajnoczi wrote: On Wed, Jan 29, 2020 at 05:07:00PM +0300, Denis Plotnikov wrote: The goal is to reduce the amount of requests issued by a guest on 1M

Re: [PATCH v1 2/4] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-10 Thread Denis Plotnikov
On 09.02.2020 10:49, Michael S. Tsirkin wrote: On Fri, Feb 07, 2020 at 11:48:05AM +0300, Denis Plotnikov wrote: On 05.02.2020 14:19, Stefan Hajnoczi wrote: On Tue, Feb 04, 2020 at 12:59:04PM +0300, Denis Plotnikov wrote: On 30.01.2020 17:58, Stefan Hajnoczi wrote: On Wed, Jan 29, 2020 at

[PATCH] pc: remove erroneous seg_max_adjust setting for vhost-blk-device

2020-02-11 Thread Denis Plotnikov
vhost-blk-device isn't a part of qemu.git Signed-off-by: Denis Plotnikov --- hw/core/machine.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index d8e30e4895..2501b540ec 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -31,7

[PATCH v2] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-11 Thread Denis Plotnikov
://lists.gnu.org/archive/html/qemu-devel/2017-12/msg03721.html Suggested-by: Denis V. Lunev Signed-off-by: Denis Plotnikov --- hw/block/virtio-blk.c | 4 ++-- hw/core/machine.c | 2 ++ hw/scsi/virtio-scsi.c | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw

[PATCH v1 2/2] tests/acceptance/virtio_check_params: prepare to check different params

2020-02-11 Thread Denis Plotnikov
Signed-off-by: Denis Plotnikov --- tests/acceptance/virtio_check_params.py | 38 ++--- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/tests/acceptance/virtio_check_params.py b/tests/acceptance/virtio_check_params.py index deec89bf86..e578952a97 100644 --- a

[PATCH v1 1/2] tests/acceptance/virtio_check_params: remove excluded machine types carefully

2020-02-11 Thread Denis Plotnikov
Before, the test failed if an excluded machine type was absent in the machine types lists. Signed-off-by: Denis Plotnikov --- tests/acceptance/virtio_check_params.py | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tests/acceptance/virtio_check_params.py b

[PATCH v1 0/2] Improve virtio_check_params test

2020-02-11 Thread Denis Plotnikov
* fixed failing on non-existed machine type removal * the test refactored to add more parameters to check Gereral questions left: How to restric test for using: 1. on a set of target OS-es 2. on a set target architectures Denis Plotnikov (2): tests/acceptance/virtio_check_params

Re: [PATCH v1 0/2] Improve virtio_check_params test

2020-02-11 Thread Denis Plotnikov
On 11.02.2020 17:37, Philippe Mathieu-Daudé wrote: Hi Denis, On 2/11/20 3:25 PM, Denis Plotnikov wrote: * fixed failing on non-existed machine type removal * the test refactored to add more parameters to check Gereral questions left:     How to restric test for using:     1. on a set of

Re: [PATCH v4] qapi/qmp: Add timestamps to qmp command responses

2023-01-10 Thread Denis Plotnikov
[ping] On 01.11.2022 18:37, Denis Plotnikov wrote: Add "start" & "end" time values to QMP command responses. These time values are added to let the qemu management layer get the exact command execution time without any other time variance which might be brought by o

[PING] [PATCH v4] qapi/qmp: Add timestamps to qmp command responses

2023-01-16 Thread Denis Plotnikov
On 10.01.2023 13:32, Denis Plotnikov wrote: [ping] On 01.11.2022 18:37, Denis Plotnikov wrote: Add "start" & "end" time values to QMP command responses. These time values are added to let the qemu management layer get the exact command execution time without any o

[PATCH v1 0/2] vl: flush all task from rcu queue before exiting

2021-11-15 Thread Denis Plotnikov
own because the rcu not always have enough time to run them. Denis Plotnikov (2): monitor: move monitor destruction to the very end of qemu cleanup vl: flush all task from rcu queue before exiting include/qemu/rcu.h | 1 + monitor/monitor.c | 6 ++ softmmu/runstate.c | 4 +++- u

[PATCH v1 1/2] monitor: move monitor destruction to the very end of qemu cleanup

2021-11-15 Thread Denis Plotnikov
vents. Signed-off-by: Denis Plotnikov --- monitor/monitor.c | 6 ++ softmmu/runstate.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/monitor/monitor.c b/monitor/monitor.c index 21c7a68758f5..b04ae4850db2 100644 --- a/monitor/monitor.c +++ b/monitor/monitor.c @@ -6

[PATCH v1 2/2] vl: flush all task from rcu queue before exiting

2021-11-15 Thread Denis Plotnikov
new rcu intreface function right before qemu main thread exit. Signed-off-by: Denis Plotnikov --- include/qemu/rcu.h | 1 + softmmu/runstate.c | 2 ++ util/rcu.c | 12 3 files changed, 15 insertions(+) diff --git a/include/qemu/rcu.h b/include/qemu/rcu.h index 515d327cf11c

[Ping] [PATCH v1 0/2] vl: flush all task from rcu queue before exiting

2021-11-19 Thread Denis Plotnikov
Ping! On 15.11.2021 12:41, Denis Plotnikov wrote: v1 -> v0: * move monitor cleanup to the very end of qemu cleanup [Paolo] The goal is to notify management layer about device destruction on qemu shutdown. Without this series DEVICE_DELETED event may not be sent because of stuck tasks in

[PING][Ping] [PATCH v1 0/2] vl: flush all task from rcu queue before exiting

2021-11-24 Thread Denis Plotnikov
ping ping On 19.11.2021 12:42, Denis Plotnikov wrote: Ping! On 15.11.2021 12:41, Denis Plotnikov wrote: v1 -> v0: * move monitor cleanup to the very end of qemu cleanup [Paolo] The goal is to notify management layer about device destruction on qemu shutdown. Without this ser

[PING][PATCH v5] qapi/qmp: Add timestamps to qmp command responses

2023-05-10 Thread Denis Plotnikov
Hi all! It seems that this series has come through a number of reviews and got some "reviewed-by". Is there any flaws to fix preventing to merge this series? Thanks, Denis On 26.04.2023 17:08, Denis Plotnikov wrote: Add "start" & "end" time values to

[PATCH v5] qapi/qmp: Add timestamps to qmp command responses

2023-04-26 Thread Denis Plotnikov
quot;: true}} The response of the QMP command contains the start & end time of the QMP command processing. Also, "start" & "end" timestaps are added to qemu guest agent responses as qemu-ga shares the same code for request dispatching. Suggested-by: Andrey Ryab

[PATCH v0 0/2] virtio-blk and vhost-user-blk cross-device migration

2021-10-04 Thread Denis Plotnikov
t ease to differ the new virtio-blk-compatible vhost-user-blk device from the existing non-compatible one using qemu machinery without any other modifiactions. That gives all the variety of qemu device related constraints out of box. 0001: adds new type "vhost-user-virtio-blk" 0002: ad

[PATCH v0 2/2] vhost-user-blk-pci: add new pci device type to support vhost-user-virtio-blk

2021-10-04 Thread Denis Plotnikov
To allow the recently added vhost-user-virtio-blk work via virtio-pci. This patch refactors the vhost-user-blk-pci object model to reuse the existing code. Signed-off-by: Denis Plotnikov --- hw/virtio/vhost-user-blk-pci.c | 43 +++--- 1 file changed, 40 insertions

[PATCH v0 1/2] vhost-user-blk: add a new vhost-user-virtio-blk type

2021-10-04 Thread Denis Plotnikov
e variety of qemu device related constraints out of box. Signed-off-by: Denis Plotnikov --- hw/block/vhost-user-blk.c | 63 ++ include/hw/virtio/vhost-user-blk.h | 2 + 2 files changed, 65 insertions(+) diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-u

[PATCH v0] vl: flush all task from rcu queue before exiting

2021-11-02 Thread Denis Plotnikov
new rcu intreface function right before qemu main thread exit. Signed-off-by: Denis Plotnikov --- include/qemu/rcu.h | 1 + softmmu/runstate.c | 3 +++ util/rcu.c | 12 3 files changed, 16 insertions(+) diff --git a/include/qemu/rcu.h b/include/qemu/rcu.h index

Re: [PATCH v0] vl: flush all task from rcu queue before exiting

2021-11-02 Thread Denis Plotnikov
On 02.11.2021 16:39, Denis Plotnikov wrote: The device destruction may superimpose over qemu shutdown. In this case some management layer, requested a device unplug and waiting for DEVICE_DELETED event, may never get this event. This happens because device_finalize() may never be called on

[Ping][PATCH v0] vl: flush all task from rcu queue before exiting

2021-11-08 Thread Denis Plotnikov
Ping ping! On 02.11.2021 16:39, Denis Plotnikov wrote: The device destruction may superimpose over qemu shutdown. In this case some management layer, requested a device unplug and waiting for DEVICE_DELETED event, may never get this event. This happens because device_finalize() may never be

Re: [Ping][PATCH v0] vl: flush all task from rcu queue before exiting

2021-11-10 Thread Denis Plotnikov
On 09.11.2021 20:46, Paolo Bonzini wrote: On 11/9/21 08:23, Denis Plotnikov wrote: Ping ping! Looks good, but can you explain why it's okay to call it before qemu_chr_cleanup() and user_creatable_cleanup()? I think a better solution to the ordering problem would be:   qemu_chr_cl

[PATCH v4] qapi/qmp: Add timestamps to qmp command responses

2022-11-01 Thread Denis Plotnikov
quot;: true}} The response of the QMP command contains the start & end time of the QMP command processing. Also, "start" & "end" timestaps are added to qemu guest agent responses as qemu-ga shares the same code for request dispatching. Suggested-by: Andrey Ryabinin

[patch v0] qapi/qmp: Add timestamps to qmp command responses.

2022-09-26 Thread Denis Plotnikov
"return": {"status": "running", "singlestep": false, "running": true}} The responce of the qmp command contains the start & end time of the qmp command processing. These times may be helpful for the management layer in understanding of the actua

Re: [patch v0] qapi/qmp: Add timestamps to qmp command responses.

2022-09-27 Thread Denis Plotnikov
On 27.09.2022 09:04, Markus Armbruster wrote: Daniel P. Berrangé writes: On Mon, Sep 26, 2022 at 12:59:40PM +0300, Denis Plotnikov wrote: Add "start" & "end" timestamps to qmp command responses. It's disabled by default, but can be enabled with 'time

[PATCH v1] qapi/qmp: Add timestamps to qmp command responses

2022-10-07 Thread Denis Plotnikov
econds": 1650367305, "microseconds": 831012}, "return": {"status": "running", "singlestep": false, "running": true}} The responce of the qmp command contains the start & end time of the qmp command processing. Sugge

[PATCH v2] qapi/qmp: Add timestamps to qmp command responses

2022-10-11 Thread Denis Plotnikov
econds": 1650367305, "microseconds": 831012}, "return": {"status": "running", "singlestep": false, "running": true}} The responce of the qmp command contains the start & end time of the qmp command processing. Sugge

[PATCH v3] qapi/qmp: Add timestamps to qmp command responses

2022-10-11 Thread Denis Plotnikov
econds": 1650367305, "microseconds": 831012}, "return": {"status": "running", "singlestep": false, "running": true}} The responce of the qmp command contains the start & end time of the qmp command processing. Suggested-by:

Re: [PATCH v3] qapi/qmp: Add timestamps to qmp command responses

2022-10-14 Thread Denis Plotnikov
On 13.10.2022 18:00, Markus Armbruster wrote: Denis Plotnikov writes: Add "start" & "end" time values to qmp command responses. Please spell it QMP. More of the same below. ok Can you tell me about a problem you cracked (or could have cracked) with the h

Re: [PATCH v3] qapi/qmp: Add timestamps to qmp command responses

2022-10-16 Thread Denis Plotnikov
Armbruster wrote: Denis Plotnikov writes: Add "start" & "end" time values to qmp command responses. Please spell it QMP. More of the same below. These time values are added to let the qemu management layer get the exact command execution time without any other time

Re: [PATCH v2] virtio: add VIRTQUEUE_ERROR QAPI event

2023-09-13 Thread Denis Plotnikov
Reviewed-by: Denis Plotnikov On 9/12/23 20:57, Vladimir Sementsov-Ogievskiy wrote: For now we only log the vhost device error, when virtqueue is actually stopped. Let's add a QAPI event, which makes possible: - collect statistics of such errors - make immediate actions: take core dum

[Qemu-devel] [PATCH] kvmclock: update system_time_msr address forcibly

2017-05-24 Thread Denis Plotnikov
R MSR access it doesn't enter L1 and processed it by itself. Thus, L1 kvm doesn't know about that TPR access happening and doesn't exit to qemu which in turn doesn't set system_time_msr address. This patch fixes this by making sure it knows the correct address every time it is need

Re: [Qemu-devel] [PATCH] kvmclock: update system_time_msr address forcibly

2017-05-24 Thread Denis Plotnikov
On 24.05.2017 17:09, Denis V. Lunev wrote: On 05/24/2017 05:07 PM, Denis Plotnikov wrote: Do an update of system_time_msr address every time before reading the value of tsc_timestamp from guest's kvmclock page. It should be done in a forcible manner because there is a situation

[Qemu-devel] [PATCH v2] kvmclock: update system_time_msr address forcibly

2017-05-26 Thread Denis Plotnikov
or L2, the effect of the bug is not revealed. This patch fixes this problem by making sure it knows the correct system_time_msr address every time it is needed. Signed-off-by: Denis Plotnikov --- hw/i386/kvm/clock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/kvm/clock.c b/hw/i3

[Qemu-devel] [PATCH v3] kvmclock: update system_time_msr address forcibly

2017-05-29 Thread Denis Plotnikov
or L2, the effect of the bug is not revealed. This patch fixes this problem by making sure it knows the correct system_time_msr address every time it is needed. Signed-off-by: Denis Plotnikov --- hw/i386/kvm/clock.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/i386/kvm/clock.c b/hw/i3

[Qemu-devel] [PATCH] i386: turn off l3-cache property by default

2017-11-24 Thread Denis Plotnikov
VMs should be able to tune them up themselves. So switch l3-cache off by default, and add a compat clause for the range of machine types where it was on. Signed-off-by: Denis Plotnikov Reviewed-by: Roman Kagan --- include/hw/i386/pc.h | 7 ++- target/i386/cpu.c| 2 +- 2 files changed, 7 i

[Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section"

2018-12-05 Thread Denis Plotnikov
may appear in vCPU context (here is the race) Signed-off-by: Denis Plotnikov --- block/block-backend.c | 31 +++ block/io.c| 3 ++- dma-helpers.c | 4 ++-- hw/block/nvme.c | 8 hw/block/xen_disk.c | 8 h

Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section"

2018-12-10 Thread Denis Plotnikov
On 07.12.2018 15:26, Kevin Wolf wrote: > Am 05.12.2018 um 13:23 hat Denis Plotnikov geschrieben: >> At the time, the "drained section" doesn't protect Block Driver State >> from the requests appearing in the vCPU threads. >> This could lead to the data los

Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section"

2018-12-11 Thread Denis Plotnikov
On 07.12.2018 15:26, Kevin Wolf wrote: > Am 05.12.2018 um 13:23 hat Denis Plotnikov geschrieben: >> At the time, the "drained section" doesn't protect Block Driver State >> from the requests appearing in the vCPU threads. >> This could lead to the data los

Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section"

2018-12-13 Thread Denis Plotnikov
On 12.12.2018 15:24, Kevin Wolf wrote: > Am 11.12.2018 um 17:55 hat Denis Plotnikov geschrieben: >>> Why involve the AioContext at all? This could all be kept at the >>> BlockBackend level without extending the layering violation that >>> aio_disable_external()

Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section"

2018-12-14 Thread Denis Plotnikov
On 13.12.2018 15:20, Kevin Wolf wrote: > Am 13.12.2018 um 12:07 hat Denis Plotnikov geschrieben: >> On 12.12.2018 15:24, Kevin Wolf wrote: >>> Am 11.12.2018 um 17:55 hat Denis Plotnikov geschrieben: >>>>> Why involve the AioContext at all? This could all be kep

Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section"

2018-12-18 Thread Denis Plotnikov
ping ping On 14.12.2018 14:54, Denis Plotnikov wrote: > > > On 13.12.2018 15:20, Kevin Wolf wrote: >> Am 13.12.2018 um 12:07 hat Denis Plotnikov geschrieben: >>> On 12.12.2018 15:24, Kevin Wolf wrote: >>>> Am 11.12.2018 um 17:55 hat Denis Plotnikov geschriebe

Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section"

2019-01-14 Thread Denis Plotnikov
ping ping ping ping On 09.01.2019 11:18, Denis Plotnikov wrote: > ping ping!!! > > On 18.12.2018 11:53, Denis Plotnikov wrote: >> ping ping >> >> On 14.12.2018 14:54, Denis Plotnikov wrote: >>> >>> >>> On 13.12.2018 15:20, Kevin Wolf

[Qemu-devel] PING: [PATCH] blk: postpone request execution on a context protected with "drained section"

2019-01-17 Thread Denis Plotnikov
Kevin, could you please take a look at my last comments? Thanks! Denis On 15.01.2019 10:22, Denis Plotnikov wrote: > ping ping ping ping > > On 09.01.2019 11:18, Denis Plotnikov wrote: >> ping ping!!! >> >> On 18.12.2018 11:53, Denis Plotnikov wrote: >>>

Re: [Qemu-devel] PING: [PATCH] blk: postpone request execution on a context protected with "drained section"

2019-01-17 Thread Denis Plotnikov
On 17.01.2019 17:23, Kevin Wolf wrote: > Am 17.01.2019 um 13:57 hat Denis Plotnikov geschrieben: >> Kevin, >> >> could you please take a look at my last comments? > > I read it, and what it told me is essentially that I need to work on it > myself to fully under

Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section"

2019-01-09 Thread Denis Plotnikov
ping ping!!! On 18.12.2018 11:53, Denis Plotnikov wrote: > ping ping > > On 14.12.2018 14:54, Denis Plotnikov wrote: >> >> >> On 13.12.2018 15:20, Kevin Wolf wrote: >>> Am 13.12.2018 um 12:07 hat Denis Plotnikov geschrieben: >>>> On 12.12.2018 15

Re: [Qemu-devel] [Qemu-block] [PATCH v0 0/2] Postponed actions

2018-08-27 Thread Denis Plotnikov
PING! PING! On 14.08.2018 10:08, Denis Plotnikov wrote: On 13.08.2018 19:30, Kevin Wolf wrote: Am 13.08.2018 um 10:32 hat Denis Plotnikov geschrieben: Ping ping! On 16.07.2018 21:59, John Snow wrote: On 07/16/2018 11:01 AM, Denis Plotnikov wrote: Ping! I never saw a reply to

Re: [Qemu-devel] [Qemu-block] [PATCH v0 0/2] Postponed actions

2018-08-28 Thread Denis Plotnikov
On 27.08.2018 19:05, John Snow wrote: On 08/27/2018 03:05 AM, Denis Plotnikov wrote: PING! PING! Sorry, Kevin and Stefan are both on PTO right now, I think. I can't promise I have the time to look soon, but you at least deserve an answer for the radio silence the last week.

Re: [Qemu-devel] [PATCH v1 00/17] Background snapshots

2018-09-04 Thread Denis Plotnikov
Hi Peter I moved the code to the repository https://github.com/denis-plotnikov/qemu/tree/background-snapshot-kvm. the current version includes fixes with respect to your comments for version 1. I moved KVM related patches to the end of the branch (formerly patch series). Since, the KVM

Re: [Qemu-devel] [PATCH v1 00/17] Background snapshots

2018-09-05 Thread Denis Plotnikov
04, 2018 at 04:00:31PM +0300, Denis Plotnikov wrote: Hi Peter Hi, Denis, I moved the code to the repository https://github.com/denis-plotnikov/qemu/tree/background-snapshot-kvm. the current version includes fixes with respect to your comments for version 1. I moved KVM related patches to the

Re: [Qemu-devel] [Qemu-block] [PATCH v0 0/2] Postponed actions

2018-09-10 Thread Denis Plotnikov
PING PING! On 28.08.2018 13:23, Denis Plotnikov wrote: On 27.08.2018 19:05, John Snow wrote: On 08/27/2018 03:05 AM, Denis Plotnikov wrote: PING! PING! Sorry, Kevin and Stefan are both on PTO right now, I think. I can't promise I have the time to look soon, but you at least deser

Re: [Qemu-devel] [PATCH v0 2/2] block: postpone the coroutine executing if the BDS's is drained

2018-09-12 Thread Denis Plotnikov
On 10.09.2018 15:41, Kevin Wolf wrote: Am 29.06.2018 um 14:40 hat Denis Plotnikov geschrieben: Fixes the problem of ide request appearing when the BDS is in the "drained section". Without the patch the request can come and be processed by the main event loop, as the ide re

Re: [Qemu-devel] [PATCH v0 2/2] block: postpone the coroutine executing if the BDS's is drained

2018-09-12 Thread Denis Plotnikov
On 12.09.2018 16:15, Kevin Wolf wrote: Am 12.09.2018 um 14:03 hat Denis Plotnikov geschrieben: On 10.09.2018 15:41, Kevin Wolf wrote: Am 29.06.2018 um 14:40 hat Denis Plotnikov geschrieben: Fixes the problem of ide request appearing when the BDS is in the "drained section". W

Re: [Qemu-devel] [PATCH v0 0/7] Background snapshots

2018-07-16 Thread Denis Plotnikov
On 13.07.2018 08:20, Peter Xu wrote: On Fri, Jun 29, 2018 at 11:03:13AM +0300, Denis Plotnikov wrote: The patch set adds the ability to make external snapshots while VM is running. The workflow to make a snapshot is the following: 1. Pause the vm 2. Make a snapshot of block devices using

Re: [Qemu-devel] [PATCH v0 0/2] Postponed actions

2018-07-16 Thread Denis Plotnikov
Ping! On 29.06.2018 15:40, Denis Plotnikov wrote: There are cases when a request to a block driver state shouldn't have appeared producing dangerous race conditions. This misbehaviour is usually happens with storage devices emulated without eventfd for guest to host notifications like IDE.

Re: [Qemu-devel] [Qemu-block] [PATCH v0 0/2] Postponed actions

2018-07-18 Thread Denis Plotnikov
On 16.07.2018 21:59, John Snow wrote: On 07/16/2018 11:01 AM, Denis Plotnikov wrote: Ping! I never saw a reply to Stefan's question on July 2nd, did you reply off-list? For some reason, there are no Stefan's replies on my server. Found it in the web. Will respond to

[Qemu-devel] [PATCH v1 09/17] background snapshot: extend RAM request for holding a page copy pointer

2018-07-18 Thread Denis Plotnikov
This pointer is going to be used to transfer a memory. Once the memory page is copied the content the snapshot interested in is saved for writing and we can make the page writable again. Signed-off-by: Denis Plotnikov --- migration/ram.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a

[Qemu-devel] [PATCH v1 15/17] kvm: add vCPU failed memeory access processing

2018-07-18 Thread Denis Plotnikov
Is done with support of the KVM patch returning the faulting address. Signed-off-by: Denis Plotnikov --- target/i386/kvm.c | 17 + 1 file changed, 17 insertions(+) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 3ac5302bc5..55b8860d1a 100644 --- a/target/i386/kvm.c

[Qemu-devel] [PATCH v1 05/17] ram: extend the data structures for background snapshotting

2018-07-18 Thread Denis Plotnikov
Signed-off-by: Denis Plotnikov --- include/exec/ram_addr.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h index 6cbc02aa0f..5b403d537d 100644 --- a/include/exec/ram_addr.h +++ b/include/exec/ram_addr.h @@ -36,6 +36,8 @@ struct

  1   2   3   4   5   6   >