On Mon, Jan 25, 2016 at 07:38:59PM +, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > The post-copy code does some I/O to/from an intermediate
> > in-memory buffer rather than direct to the underlying
> > I/O channel. Sw
ed-off-by: Daniel P. Berrange
---
hmp.c | 52 ---
include/monitor/monitor.h | 3 -
include/qom/object_interfaces.h | 48 ++
qmp.c | 76 ++
qom/object_interface
idth
- Update qemu-nbd/qemu-io to use constants for options
- Update qemu-nbd to avoid overlapping option values
Daniel P. Berrange (10):
qom: add helpers for UserCreatable object types
qemu-img: add support for --object command line arg
qemu-nbd: add support for --object command line arg
-nbd --object secret,id=sec0,file=mypasswd.txt \
...other nbd args...
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c| 54 ++
qemu-nbd.texi | 6 ++
2 files changed, 60 insertions(+)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index ede
qemu-img info --object secret,id=sec0,file=mypasswd.txt \
...other info args...
Signed-off-by: Daniel P. Berrange
---
qemu-img-cmds.hx | 44 -
qemu-img.c | 284 +--
qemu-img.texi| 8 ++
3 files changed, 306 insertions(+),
u-io --object secret,id=sec0,file=mypasswd.txt \
...other args...
Signed-off-by: Daniel P. Berrange
---
qemu-io.c | 54 ++
1 file changed, 54 insertions(+)
diff --git a/qemu-io.c b/qemu-io.c
index d593f19..d1432ea 100644
--- a/qemu-io.c
++
When declaring the 'struct option' array, use the standard
constants no_argument/required_argument, instead of magic
values 0 and 1.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
qemu-io.c | 30 +++---
1 file changed, 15 insertions(+), 15
#x27; flag.
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c | 45 -
1 file changed, 40 insertions(+), 5 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 8e5d36c..764698f 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -48,6 +48,7 @@
#define QEMU_NBD_O
ned-off-by: Daniel P. Berrange
---
qemu-io.c | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/qemu-io.c b/qemu-io.c
index d1432ea..51d8272 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -367,6 +367,7 @@ static void reenable_tty_echo(voi
When defining values for long options, the normal practice is
to start numbering from 256, to avoid overlap with the range
of valid values for short options.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions
When declaring the 'struct option' array, use the standard
constants no_argument/required_argument, instead of magic
values 0 and 1.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c | 47 ---
1 file changed, 24
filename should be interpreted as a full option string, not
just a filename.
qemu-img info --source driver=http,url=https://127.0.0.1/images,sslverify=off
This flag is mutually exclusive with the '-f' / '-F' flags.
Signed-off-by: Daniel P. Berrange
---
qemu-img-cmds.hx
On Tue, Jan 26, 2016 at 02:38:35PM +, Peter Maydell wrote:
> On 26 January 2016 at 13:46, Paolo Bonzini wrote:
> > The following changes since commit 3db34bf64ab4f8797565dd8750003156c32b301d:
> >
> > Merge remote-tracking branch
> > 'remotes/afaerber/tags/qom-devices-for-peter' into staging
implement x86_64-cpu properties.
> >
> > Signed-off-by: Valentin Rakush
> > Cc: Luiz Capitulino
> > Cc: Eric Blake
> > Cc: Markus Armbruster
> > Cc: Andreas Färber
> > Cc: Daniel P. Berrange
> > Cc: Eduardo Habkost
> > ---
> [...]
&g
very
much, so get rid of it and rename io_channel_send_full() to
just be io_channel_send().
Signed-off-by: Daniel P. Berrange
---
qemu-char.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 7ded3c2..4c3daa6 100644
--- a
On Tue, Jan 26, 2016 at 10:41:12AM -0600, Chris Friesen wrote:
> Hi,
>
> I'm using libvirt (1.2.12) with qemu (2.2.0) in the context of OpenStack.
>
> If I live-migrate a guest with virtio network interfaces, I see a ~1200msec
> delay in processing the network packets, and several hundred of them
On Tue, Jan 26, 2016 at 03:26:35PM -0200, Eduardo Habkost wrote:
> On Tue, Jan 26, 2016 at 03:51:21PM +0000, Daniel P. Berrange wrote:
> > On Tue, Jan 26, 2016 at 01:35:38PM -0200, Eduardo Habkost wrote:
> > > On Mon, Jan 25, 2016 at 11:24:47AM +0300, Valentin Rakush wrote:
>
s with a mis-match
# PKG_CONFIG_LIBDIR=/usr/lib64/pkgconfig ./configure --extra-cflags="-m32"
# PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig ./configure --extra-cflags="-m64"
ERROR: sizeof(size_t) doesn't match GLIB_SIZEOF_SIZE_T.
You probably need to set PKG_CONFIG_LIBDIR
to
On Wed, Jan 27, 2016 at 01:09:37PM -0200, Eduardo Habkost wrote:
> On Tue, Jan 26, 2016 at 10:19:13PM +0000, Daniel P. Berrange wrote:
> > On Tue, Jan 26, 2016 at 03:26:35PM -0200, Eduardo Habkost wrote:
> > > On Tue, Jan 26, 2016 at 03:51:21PM +, Daniel P. Berrange wrote:
&
On Thu, Jan 28, 2016 at 09:46:26AM +0100, Paolo Bonzini wrote:
>
>
> On 28/01/2016 08:28, Roy Shterman wrote:
> >
> > Important to understand that after modifying and saving configuration of
> > xml with virsh edit $name_of_guest
> >
> > when i reenter the xml i can't see the iothread configura
On Wed, Jan 20, 2016 at 10:31:56AM -0500, Stefan Berger wrote:
> "Daniel P. Berrange" wrote on 01/20/2016 10:00:41
> AM:
>
> > Subject: Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE
> > > The CUSE TPM and associated tools can be found her
On Wed, Jan 27, 2016 at 04:29:37PM +0800, zhanghailiang wrote:
> Make the helper object_create() public and fix its first
> parameter to accept NULL value.
>
> Signed-off-by: zhanghailiang
> Cc: Paolo Bonzini
> ---
> v2:
> - New patch
> ---
> include/qemu-common.h | 2 ++
> vl.c
On Wed, Jan 27, 2016 at 04:29:38PM +0800, zhanghailiang wrote:
> We add a new helper function netdev_add_filter(), this function
> can help adding a filter object to a netdev.
> Besides, we add a is_default member for struct NetFilterState
> to indicate whether the filter is default or not.
>
> Si
On Wed, Jan 27, 2016 at 03:26:51PM +0100, Kevin Wolf wrote:
> Am 26.01.2016 um 14:34 hat Daniel P. Berrange geschrieben:
> > -if ((argc - optind) == 1) {
> > +if (imageOpts) {
> > +char *file;
> > +qopts = qemu_opts_parse_noisily(&
On Wed, Jan 27, 2016 at 02:26:53PM +0100, Kevin Wolf wrote:
> Am 26.01.2016 um 14:34 hat Daniel P. Berrange geschrieben:
> > Allow creation of user creatable object types with qemu-img
> > via a new --object command line arg. This will be used to supply
> > passwords and/or e
On Wed, Jan 27, 2016 at 02:57:51PM +0100, Kevin Wolf wrote:
> Am 26.01.2016 um 14:34 hat Daniel P. Berrange geschrieben:
> > Allow creation of user creatable object types with qemu-nbd
> > via a new --object command line arg. This will be used to supply
> > passwords and/or e
On Wed, Jan 27, 2016 at 03:30:29PM +0100, Kevin Wolf wrote:
> Am 26.01.2016 um 14:34 hat Daniel P. Berrange geschrieben:
> > Currently qemu-img allows an image filename to be passed on the
> > command line, but unless using the JSON format, it does not have
> > a way to set a
On Tue, Feb 02, 2016 at 12:49:33PM +0100, Christoffer Dall wrote:
> On Fri, Jan 22, 2016 at 02:44:32PM +0000, Daniel P. Berrange wrote:
> > On Wed, Jan 06, 2016 at 01:30:16PM +, Peter Maydell wrote:
> > > On 6 January 2016 at 12:49, Andrea Bolognani wrote:
> > > >
ource code width
- Update qemu-nbd/qemu-io to use constants for options
- Update qemu-nbd to avoid overlapping option values
Daniel P. Berrange (10):
qom: add helpers for UserCreatable object types
qemu-img: add support for --object command line arg
qemu-nbd: add support for --object comma
#x27; flag.
Signed-off-by: Daniel P. Berrange
---
qemu-io.c | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/qemu-io.c b/qemu-io.c
index 65a28e4..3544fd7 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -366,6 +366,7 @@ static void reenable_tty_echo(voi
_foreach - variant on
user_creatable_add_opts which can be directly used
in conjunction with qemu_opts_foreach.
- user_creatable_del - takes an ID and deletes the
corresponding object
The existing code is updated to use these new methods.
Signed-off-by: Daniel P. Berrange
---
hmp.c
When defining values for long options, the normal practice is
to start numbering from 256, to avoid overlap with the range
of valid values for short options.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions
qemu-img info --object secret,id=sec0,file=mypasswd.txt \
...other info args...
Signed-off-by: Daniel P. Berrange
---
qemu-img-cmds.hx | 44 -
qemu-img.c | 269 +--
qemu-img.texi| 8 ++
3 files changed, 291 insertions(+),
the '-f' flag.
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c | 42 +-
1 file changed, 37 insertions(+), 5 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 0e019c1..ee91e47 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -47,6 +47,7 @
When declaring the 'struct option' array, use the standard
constants no_argument/required_argument, instead of magic
values 0 and 1.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c | 47 ---
1 file changed, 24
When declaring the 'struct option' array, use the standard
constants no_argument/required_argument, instead of magic
values 0 and 1.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
qemu-io.c | 30 +++---
1 file changed, 15 insertions(+), 15
-nbd --object secret,id=sec0,file=mypasswd.txt \
...other nbd args...
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c| 34 ++
qemu-nbd.texi | 6 ++
2 files changed, 40 insertions(+)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index ede4a54..0e019c1 100644
---
filename should be interpreted as a full option string, not
just a filename.
qemu-img info --image-opts
driver=https,url=https://127.0.0.1/images,sslverify=off
This flag is mutually exclusive with the '-f' / '-F' flags.
Signed-off-by: Daniel P. Berrange
---
qe
u-io --object secret,id=sec0,file=mypasswd.txt \
...other args...
Signed-off-by: Daniel P. Berrange
---
qemu-io.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/qemu-io.c b/qemu-io.c
index d593f19..65a28e4 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@
c0377a7cc6cb46aba295b744d237aeed94087ac0:
crypto: ensure qcrypto_hash_digest_len is always defined (2016-02-02 13:02:56
+)
Merge qcrypto-next 2016/2/2 v1
Daniel P. Berrange (3
The qcrypto_hash_digest_len method was accidentally inside
a CONFIG_GNUTLS_HASH block, even though it doesn't depend
on gnutls. Re-arrange it to be unconditionally defined.
Reviewed-by: Fam Zheng
Signed-off-by: Daniel P. Berrange
---
crypto/hash.c | 30 +-
1
The "Error **errp" parameters must be NULL initialized
not uninitialized.
Signed-off-by: Daniel P. Berrange
---
include/crypto/cipher.h | 8
include/crypto/hash.h | 12 ++--
include/crypto/tlssession.h | 8
3 files changed, 14 insertions(+), 14
This converts the tlscredsx509, tlscredsanon and secret objects
to register their properties against the class rather than object.
Signed-off-by: Daniel P. Berrange
---
crypto/secret.c | 60 +++
crypto/tlscreds.c | 36
On Tue, Feb 02, 2016 at 12:08:31PM -0500, Programmingkid wrote:
> https://patchwork.ozlabs.org/patch/570128/
>
> Mac OS X can be picky when it comes to allowing the user
> to use physical devices in QEMU. Most mounted volumes
> appear to be off limits to QEMU. If an issue is detected,
> a message
On Tue, Feb 02, 2016 at 12:28:24PM -0500, Programmingkid wrote:
>
> On Feb 2, 2016, at 12:16 PM, Daniel P. Berrange wrote:
>
> > On Tue, Feb 02, 2016 at 12:08:31PM -0500, Programmingkid wrote:
> >> https://patchwork.ozlabs.org/patch/570128/
> >>
> >&
On Tue, Feb 02, 2016 at 06:19:03PM +, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > Convert the tcp socket migration protocol driver to use
> > QIOChannel and QEMUFileChannel, instead of plain sockets
> > APIs.
> >
>
On Tue, Feb 02, 2016 at 06:46:01PM +, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > Convert the fd socket migration protocol driver to use
> > QIOChannel and QEMUFileChannel, instead of plain sockets
> > APIs. It can be unconditiona
On Tue, Feb 02, 2016 at 05:24:32PM -0700, Eric Blake wrote:
> On 02/02/2016 05:57 AM, Daniel P. Berrange wrote:
> > Allow creation of user creatable object types with qemu-img
> > via a new --object command line arg. This will be used to supply
> > passwords and/or encryptio
On Wed, Feb 03, 2016 at 10:29:50AM +, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > On Tue, Feb 02, 2016 at 06:46:01PM +, Dr. David Alan Gilbert wrote:
> > > > void fd_start_incoming_migration(const cha
On Tue, Feb 02, 2016 at 06:02:13PM +, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > Convert the unix socket migration protocol driver to use
> > QIOChannel and QEMUFileChannel, instead of plain sockets
> > APIs. It can be uncondition
On Tue, Feb 02, 2016 at 08:01:36PM +, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > This converts the RDMA code to provide a subclass of
> > QIOChannel that uses RDMA for the data transport.
> >
> > The RDMA code would be
On Wed, Feb 03, 2016 at 01:23:04PM +, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > On Tue, Feb 02, 2016 at 08:01:36PM +, Dr. David Alan Gilbert wrote:
> > > * Daniel P. Berrange (berra...@redhat.com) wrote:
> > > >
On Thu, Jan 28, 2016 at 05:53:46PM +, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > The QEMUFile writev_buffer / put_buffer functions are expected
> > to write out the full set of requested data, blocking until
> > complete. The qemu
On Tue, Feb 02, 2016 at 05:06:24PM +, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > Introduce a new QEMUFile implementation that is based on
> > the QIOChannel objects. This impl is different from existing
> > impls in that there
In the docs for qio_channel_socket_connect_async,
qio_channel_socket_listen_async and
qio_channel_socket_dgram_async, mention that the
SocketAddress parameters are copied, so can be freed
immediately.
Signed-off-by: Daniel P. Berrange
---
include/io/channel-socket.h | 11 +--
1 file
Depending on what object a file descriptor refers to a different
type of IO channel will be needed - either a QIOChannelFile or
a QIOChannelSocket. Introduce a qio_channel_new_fd() method
which will return the appropriate channel implementation.
Signed-off-by: Daniel P. Berrange
---
Suggested
On Wed, Feb 03, 2016 at 03:47:42PM +, Stefan Hajnoczi wrote:
> From: "Denis V. Lunev"
>
> log will become common facility with tracepoints support in next step.
>
> Signed-off-by: Denis V. Lunev
> Reviewed-by: Paolo Bonzini
> Signed-off-by: Paolo Bonzini
> Message-id: 1452174932-28657-9-g
On Wed, Feb 03, 2016 at 05:33:16PM +0100, Max Reitz wrote:
> We have to introduce a new object (BlockdevOptionsNbd) for several
> reasons:
> - Neither of InetSocketAddress nor UnixSocketAddress alone is
> sufficient, because both are supported
> - We cannot use SocketAddress because NBD does not
On Wed, Feb 03, 2016 at 08:37:15AM -0700, Eric Blake wrote:
> On 02/02/2016 05:57 AM, Daniel P. Berrange wrote:
> > Currently qemu-io allows an image filename to be passed on the
> > command line, but unless using the JSON format, it does not have
> > a way to set any options
On Wed, Feb 03, 2016 at 10:36:01PM +0800, Fam Zheng wrote:
> diff --git a/tests/docker/fedora22.docker b/tests/docker/fedora22.docker
> new file mode 100644
> index 000..5fd48d6
> --- /dev/null
> +++ b/tests/docker/fedora22.docker
Fedora 22 will go end of life in June. I think we should at le
On Wed, Feb 03, 2016 at 10:36:03PM +0800, Fam Zheng wrote:
> Only fedora22 has the required toolchain so it's not run elsewhere.
>
> Signed-off-by: Fam Zheng
> ---
> tests/docker/mingw.sh | 14 ++
> 1 file changed, 14 insertions(+)
> create mode 100755 tests/docker/mingw.sh
>
> dif
On Thu, Feb 04, 2016 at 02:08:23PM +0100, Kevin Wolf wrote:
> Am 03.02.2016 um 18:06 hat Daniel P. Berrange geschrieben:
> > On Wed, Feb 03, 2016 at 05:33:16PM +0100, Max Reitz wrote:
> > > We have to introduce a new object (BlockdevOptionsNbd) for several
> > >
w the user to set an explicit export name. When an
export name is set the server will always use the new style
NBD protocol.
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c| 14 --
qemu-nbd.texi | 3 +++
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/qemu-nbd.
actually done
using the raw POSIX sockets APIs.
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c | 89 +++---
1 file changed, 51 insertions(+), 38 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 0e019c1..e428e1a 100644
--- a/qemu-nbd.c
This converts the blockdev NBD server to use the QIOChannelSocket
class for initial listener socket setup and accepting of client
connections. Actual I/O is still being performed against the
socket file descriptor using the POSIX socket APIs.
Signed-off-by: Daniel P. Berrange
---
blockdev-nbd.c
_foreach - variant on
user_creatable_add_opts which can be directly used
in conjunction with qemu_opts_foreach.
- user_creatable_del - takes an ID and deletes the
corresponding object
The existing code is updated to use these new methods.
Signed-off-by: Daniel P. Berrange
---
hmp.c
-nbd --object secret,id=sec0,file=mypasswd.txt \
...other nbd args...
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c| 34 ++
qemu-nbd.texi | 6 ++
2 files changed, 40 insertions(+)
diff --git a/qemu-nbd.c b/qemu-nbd.c
k qemu-nbd, because it
fortunately only ever uses NBD_OPT_EXPORT_NAME, so was never
triggering the non-compliant server behaviour.
Signed-off-by: Daniel P. Berrange
---
nbd/server.c | 69
1 file changed, 46 insertions(+), 23 deletions(-)
di
if name is NULL or not as needed.
This facilitates later code which allows the client to
be capable of using the new style protocol regardless
of whether an export name is listed or not.
Signed-off-by: Daniel P. Berrange
---
nbd/client.c | 60 +
This extends the NBD protocol handling code so that it is capable
of negotiating TLS support during the connection setup. This involves
requesting the STARTTLS protocol option before any other NBD options.
Signed-off-by: Daniel P. Berrange
---
block/nbd-client.c | 12 +++--
blockdev-nbd.c
If the server advertizes support for the fixed new style
negotiation, the client should in turn enable new style.
This will allow the client to negotiate further NBD
options besides the export name.
Signed-off-by: Daniel P. Berrange
---
nbd/client.c | 27 +--
1 file
TLS is enabled
and none is provided by the user (Paolo)
- Rename qemu-nbd --exportname to --export-name (Paolo)
- Use iov_discard_front() to simplify iov handling (Paolo)
Changed in v3:
- Rebase to resolve conflicts with recently merged NBD patches
Changed in v2:
- Fix error codes used during
export name ""
TLS is only supported when using an IPv4/IPv6 socket listener.
It is not possible to use with UNIX sockets, which includes
when connecting the NBD server to a host device.
Signed-off-by: Daniel P. Berrange
---
qemu-nbd
Now that all callers are converted to use I/O channels for
initial connection setup, it is possible to switch the core
NBD protocol handling core over to use QIOChannel APIs for
actual sockets I/O.
Signed-off-by: Daniel P. Berrange
---
block/nbd-client.c | 19 +++
blockdev-nbd.c
the two point to the same object, but when
TLS support is added, they will point to different objects.
In this initial conversion though, all I/O is still actually done
using the raw POSIX sockets APIs.
Signed-off-by: Daniel P. Berrange
---
Makefile | 6 ++---
block/nbd-client.c | 76
exist on the server.
If the server does not support NBD_OPT_LIST, we just ignore
that and carry on with NBD_OPT_EXPORT_NAME as before.
Signed-off-by: Daniel P. Berrange
---
nbd/client.c | 195 ++-
nbd/server.c | 2 +
2 files changed, 194
e/berrange/security/qemutls \
-drive driver=nbd,host=localhost,port=9000,tls-creds=tls0
The client will drop the connection if the NBD server does not
provide TLS.
Signed-off-by: Daniel P. Berrange
---
block/nbd-client.c | 10 ---
block/nbd-client.h | 2 ++
block/nbd.c
rios.
Signed-off-by: Daniel P. Berrange
---
nbd/client.c | 4 ++--
nbd/server.c | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/nbd/client.c b/nbd/client.c
index e91821a..89e172e 100644
--- a/nbd/client.c
+++ b/nbd/client.c
@@ -314,8 +314,8 @@ int nbd_receive_negotiate(QIOChan
t listener.
Signed-off-by: Daniel P. Berrange
---
blockdev-nbd.c | 122 ++--
hmp.c | 2 +-
qapi/block.json | 4 +-
qmp-commands.hx | 2 +-
4 files changed, 105 insertions(+), 25 deletions(-)
diff --git a/blockdev-nbd.c b/blockdev-n
On Thu, Feb 04, 2016 at 03:36:56PM +, Peter Maydell wrote:
> On 4 February 2016 at 15:32, Eric Blake wrote:
> > On 02/04/2016 07:55 AM, Peter Maydell wrote:
> >> On 4 February 2016 at 14:39, Lluís Vilanova wrote:
> >>> Dynamically detects the files used to generate QAPI code, thus ensuring
>
On Thu, Feb 04, 2016 at 04:42:06PM +0100, Kevin Wolf wrote:
> Am 02.02.2016 um 13:57 hat Daniel P. Berrange geschrieben:
> > Currently qemu-img allows an image filename to be passed on the
> > command line, but unless using the JSON format, it does not have
> > a way to set a
On Thu, Feb 04, 2016 at 08:59:56AM -0700, Eric Blake wrote:
> On 02/02/2016 05:57 AM, Daniel P. Berrange wrote:
> > Currently qemu-img allows an image filename to be passed on the
> > command line, but unless using the JSON format, it does not have
> > a way to set any options
On Thu, Feb 04, 2016 at 05:05:45PM +0100, Lluís Vilanova wrote:
> Dynamically detects the files used to generate QAPI code, thus ensuring
> it's never out of sync with the sources.
>
> Signed-off-by: Lluís Vilanova
> ---
> Makefile |6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
On Thu, Feb 04, 2016 at 09:25:10AM -0700, Eric Blake wrote:
> On 02/04/2016 06:50 AM, Daniel P. Berrange wrote:
> > This modifies the nbd-server-start QMP command so that it
> > is possible to request use of TLS. This is done by adding
> > a new optional parameter "tls-cr
On Thu, Feb 04, 2016 at 05:06:06PM +0100, Kevin Wolf wrote:
> Am 04.02.2016 um 16:47 hat Daniel P. Berrange geschrieben:
> > On Thu, Feb 04, 2016 at 04:42:06PM +0100, Kevin Wolf wrote:
> > > Am 02.02.2016 um 13:57 hat Daniel P. Berrange geschrieben:
> > > > @@
On Thu, Nov 12, 2015 at 01:02:33PM -0600, miny...@acm.org wrote:
> From: Corey Minyard
>
> Allow the IPMI interface to request a forced power off.
>
> Signed-off-by: Corey Minyard
> ---
> hw/ipmi/ipmi_bmc_extern.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/ipmi/ipmi_bmc_
s with a mis-match
# PKG_CONFIG_LIBDIR=/usr/lib64/pkgconfig ./configure --extra-cflags="-m32"
# PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig ./configure --extra-cflags="-m64"
ERROR: sizeof(size_t) doesn't match GLIB_SIZEOF_SIZE_T.
You probably need to set PKG_CONFIG_LIBDIR
to p
s with a mis-match
# PKG_CONFIG_LIBDIR=/usr/lib64/pkgconfig ./configure --extra-cflags="-m32"
# PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig ./configure --extra-cflags="-m64"
ERROR: sizeof(size_t) doesn't match GLIB_SIZEOF_SIZE_T.
You probably need to set PKG_CONFIG_LIBDIR
to
On Fri, Nov 13, 2015 at 02:23:35PM +0100, Paolo Bonzini wrote:
>
>
> On 13/11/2015 14:22, Corey Minyard wrote:
> > On 11/13/2015 03:15 AM, Daniel P. Berrange wrote:
> >> On Thu, Nov 12, 2015 at 01:02:33PM -0600, miny...@acm.org wrote:
> >>> From: Corey
On Fri, Nov 13, 2015 at 01:01:52PM +, Peter Maydell wrote:
> On 13 November 2015 at 11:31, Daniel P. Berrange wrote:
> > Developers on 64-bit machines will often try to perform a
> > 32-bit build of QEMU by running
> >
> > ./configure --extra-cflags=&quo
avoid it though by
explicitly setting the buffer to NULL after free'ing
it.
Signed-off-by: Daniel P. Berrange
---
crypto/tlscreds.c | 4 ++--
crypto/tlscredsx509.c | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/crypto/tlscreds.c b/crypto/tlscreds.c
index 5
On Fri, Nov 13, 2015 at 10:00:58PM +0100, Christian Borntraeger wrote:
> On 11/13/2015 07:14 PM, Andreas Färber wrote:
> > Am 13.10.2015 um 14:37 schrieb Daniel P. Berrange:
> >> From: Pavel Fedin
> >>
> >> ARM GICv3 systems with large number of CPUs create lo
potential bugs in the
object_property_del_all method.
Signed-off-by: Daniel P. Berrange
---
tests/check-qom-proplist.c | 159 +
1 file changed, 159 insertions(+)
diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c
index 1be8b9e..e674c0f
On Mon, Nov 16, 2015 at 05:57:09PM +0100, Andreas Färber wrote:
> Instead of using g_assert() for integer comparisons, use
> g_assert_cmpint() so that we can see the respective values.
>
> While at it, fix one stray indentation.
>
> Cc: Daniel P. Berrange
> Signed-o
ry property add first makes sure there's no duplicates.
> >>> Traversing the list becomes very slow, therefore qemu initialization takes
> >>> significant time (several seconds for e. g. 16 CPUs).
> >>>
> >>> This patch replaces list with GHashTable, mak
On Tue, Nov 17, 2015 at 04:25:22PM +0100, Markus Armbruster wrote:
> I apologize for the lateness of my review.
> > +void object_property_iter_free(ObjectPropertyIterator *iter)
> > +{
> > +if (!iter) {
> > +return;
> > +}
> > +g_free(iter);
>
> g_free(NULL) is perfectly safe;
Removed accidental debug g_printerr()s
- Resolved conflicts with QAPI generator changes
that renamed various struct fields
Daniel P. Berrange (5):
sockets: remove use of QemuOpts from header file
sockets: remove use of QemuOpts from socket_listen
sockets: remove use of QemuOpts from socke
5 +0200
qemu-sockets: fix conversion of ipv4/ipv6 JSON to QemuOpts
Signed-off-by: Daniel P. Berrange
---
ui/vnc.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index c9f2fed..4dc7684 100644
--- a/ui/vnc.c
+++ b/ui/vnc
There are no callers of the sockets methods which accept
QemuOpts any more. Make all the QemuOpts related functions
static to avoid new callers being added, in preparation
for removal of all QemuOpts usage, in favour of QAPI
SocketAddress.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P
problem where ipv4=off && ipv6=off
would be treated the same as ipv4=on && ipv6=on
Signed-off-by: Daniel P. Berrange
---
util/qemu-sockets.c | 144 +++-
1 file changed, 87 insertions(+), 57 deletions(-)
diff --git a/util/qemu-socke
801 - 900 of 6827 matches
Mail list logo
