Re: [Qemu-devel] [libvirt] RFC decoupling VM NIC provisioning from VM NIC connection to backend networks

2011-11-01 Thread Daniel P. Berrange
On Mon, Oct 31, 2011 at 04:23:35PM -0500, Christian Benvenuti (benve) wrote: > > -Original Message- > > From: qemu-devel-bounces+benve=cisco@nongnu.org [mailto:qemu-devel- > > bounces+benve=cisco@nongnu.org] On Behalf Of Daniel P. Berrange > > Sent: Monday,

Re: [Qemu-devel] [PATCH] Raise 9pfs mount_tag limit from 32 to 255 bytes

2011-11-01 Thread Daniel P. Berrange
On Tue, Nov 01, 2011 at 01:27:56PM -0500, Anthony Liguori wrote: > On 10/20/2011 10:13 AM, Daniel P. Berrange wrote: > >On Fri, Oct 07, 2011 at 04:49:13PM +0530, Aneesh Kumar K.V wrote: > >>On Fri, 7 Oct 2011 10:27:56 +0100, "Daniel P. > >>Berrange" wrote: &g

Re: [Qemu-devel] [PATCH] ui/vnc: Convert sasl.mechlist to g_malloc() & friends

2011-11-08 Thread Daniel P. Berrange
On Tue, Nov 08, 2011 at 10:55:52AM +0100, Markus Armbruster wrote: > Fixes protocol_client_auth_sasl_mechname() not to crash when malloc() > fails. Spotted by Coverity. > > Signed-off-by: Markus Armbruster > --- > ui/vnc-auth-sasl.c | 10 +- > 1 files changed, 5 insertions(+), 5 deleti

Re: [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-10 Thread Daniel P. Berrange
On Thu, Nov 10, 2011 at 12:27:30PM -0600, Anthony Liguori wrote: > What does libvirt actually do in the monitor prior to migration > completing on the destination? The least invasive way of doing > delayed open of block devices is probably to make -incoming create a > monitor and run a main loop b

Re: [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-10 Thread Daniel P. Berrange
On Thu, Nov 10, 2011 at 01:11:42PM -0600, Anthony Liguori wrote: > On 11/10/2011 12:42 PM, Daniel P. Berrange wrote: > >On Thu, Nov 10, 2011 at 12:27:30PM -0600, Anthony Liguori wrote: > >>What does libvirt actually do in the monitor prior to migration > >>completing on

Re: [Qemu-devel] Storage requirements for live migration

2011-11-11 Thread Daniel P. Berrange
On Fri, Nov 11, 2011 at 10:38:20AM +0100, Kevin Wolf wrote: > Am 11.11.2011 01:11, schrieb Anthony Liguori: > > I did a brain dump of my understanding of the various storage requirements > > for > > live migration. I think it's accurate but I may have misunderstand some > > details > > so I wo

[Qemu-devel] [PATCH] Avoid SEGV when doing migration to an FD

2011-11-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When doing migration to an FD, a NULL 'mon' parameter is being accessed, resulting in SEGV * migration.c: Always set 's->mon' Signed-off-by: Daniel P. Berrange NB, I've no idea if this is the right way to solve this, since I h

[Qemu-devel] Long QEMU main loop pauses during migration (to file) under heavy load

2011-11-11 Thread Daniel P. Berrange
Libvirt recently introduced a change to the way it does 'save to file' with QEMU. Historically QEMU has a 32MB/s I/O limit on migration by default. When saving to file, we didn't want any artificial limit, but rather to max out the underlying storage. So when doing save to file, we set a large band

Re: [Qemu-devel] Long QEMU main loop pauses during migration (to file) under heavy load

2011-11-11 Thread Daniel P. Berrange
On Fri, Nov 11, 2011 at 01:03:20PM +, Daniel P. Berrange wrote: > Libvirt recently introduced a change to the way it does 'save to file' > with QEMU. Historically QEMU has a 32MB/s I/O limit on migration by > default. When saving to file, we didn't want any artificia

Re: [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Daniel P. Berrange
On Sat, Nov 12, 2011 at 12:25:34PM +0200, Avi Kivity wrote: > On 11/11/2011 12:15 PM, Kevin Wolf wrote: > > Am 10.11.2011 22:30, schrieb Anthony Liguori: > > > Live migration with qcow2 or any other image format is just not going to > > > work > > > right now even with proper clustered storage.

Re: [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Daniel P. Berrange
On Mon, Nov 14, 2011 at 12:24:22PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 14, 2011 at 10:16:10AM +0000, Daniel P. Berrange wrote: > > On Sat, Nov 12, 2011 at 12:25:34PM +0200, Avi Kivity wrote: > > > On 11/11/2011 12:15 PM, Kevin Wolf wrote: > > > > Am 10.

Re: [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Daniel P. Berrange
On Mon, Nov 14, 2011 at 12:21:53PM +0100, Kevin Wolf wrote: > Am 14.11.2011 12:08, schrieb Daniel P. Berrange: > > On Mon, Nov 14, 2011 at 12:24:22PM +0200, Michael S. Tsirkin wrote: > >> On Mon, Nov 14, 2011 at 10:16:10AM +, Daniel P. Berrange wrote: > >>> On S

Re: [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Daniel P. Berrange
On Mon, Nov 14, 2011 at 01:34:15PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 14, 2011 at 11:29:18AM +0000, Daniel P. Berrange wrote: > > On Mon, Nov 14, 2011 at 12:21:53PM +0100, Kevin Wolf wrote: > > > Am 14.11.2011 12:08, schrieb Daniel P. Berrange: > > > >

Re: [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Daniel P. Berrange
On Mon, Nov 14, 2011 at 01:51:40PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 14, 2011 at 11:37:27AM +0000, Daniel P. Berrange wrote: > > On Mon, Nov 14, 2011 at 01:34:15PM +0200, Michael S. Tsirkin wrote: > > > On Mon, Nov 14, 2011 at 11:29:18AM +, Daniel P. Berrange wro

Re: [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-14 Thread Daniel P. Berrange
On Mon, Nov 14, 2011 at 01:56:36PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 14, 2011 at 11:37:27AM +0000, Daniel P. Berrange wrote: > > On Mon, Nov 14, 2011 at 01:34:15PM +0200, Michael S. Tsirkin wrote: > > > On Mon, Nov 14, 2011 at 11:29:18AM +, Daniel P. Berrange wro

Re: [Qemu-devel] converging around a single guest agent

2011-11-16 Thread Daniel P. Berrange
On Tue, Nov 15, 2011 at 05:01:00PM -0600, Michael Roth wrote: > On 11/15/2011 11:24 AM, Barak Azulay wrote: > >Hi, > > > >One of the breakout sessions during the ovirt workshop [1] was about the > >guest > >tools, and focused mainly on the ovirt-guest-agent [2]. > > > >One of the issues discussed

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: > > > On 08/22/2011 02:39 PM, Blue Swirl wrote: > >On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryant > >wrote: > >>> > >>> > >>> On 08/22/2011 01:25 PM, Anthony Liguori wrote: &g

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 05:50:03PM +0200, Kevin Wolf wrote: > Am 23.08.2011 17:26, schrieb Daniel P. Berrange: > > On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: > >> > >> > >> On 08/22/2011 02:39 PM, Blue Swirl wrote: > >>&g

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 04:51:31PM +0100, Daniel P. Berrange wrote: > On Tue, Aug 23, 2011 at 05:50:03PM +0200, Kevin Wolf wrote: > > Am 23.08.2011 17:26, schrieb Daniel P. Berrange: > > > On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: > > >> > &

Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

2011-08-23 Thread Daniel P. Berrange
On Mon, Aug 22, 2011 at 02:29:00PM -0500, Anthony Liguori wrote: > On 08/22/2011 12:06 PM, Saggi Mizrahi wrote: > >libvdisk is a library that packages qemu's handling of disk images. This > >allows for other programs to link to it and get access to qemu image > >file abstractions. > > > >To use ins

Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 11:14:20AM -0500, Anthony Liguori wrote: > On 08/23/2011 11:12 AM, Daniel P. Berrange wrote: > >$(block-obj-y) pulls in 'aio.o' which is built from aio.c which > >is licensed "GPLv2 only". So even those many files are BSD > >licen

[Qemu-devel] [PATCH STABLE-0.14/0.15/master] CVE-2011-0011: fix VNC password change to not touch authentication settings

2011-08-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" In CVE-2011-0011 it was noted that setting an empty password would disable all authentication for the VNC password. Commit 1cd20f8bf0ecb9d1d1bd5e2ffab3b88835380c9b attempted to fix this but it just broke it in a different way, because now instead of blindly

Re: [Qemu-devel] [PATCH STABLE-0.14/0.15/master] CVE-2011-0011: fix VNC password change to not touch authentication settings

2011-08-24 Thread Daniel P. Berrange
On Wed, Aug 24, 2011 at 07:45:06AM -0500, Anthony Liguori wrote: > On 08/24/2011 06:01 AM, Daniel P. Berrange wrote: > >From: "Daniel P. Berrange" > > > >In CVE-2011-0011 it was noted that setting an empty password > >would disable all authen

Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

2011-08-24 Thread Daniel P. Berrange
On Wed, Aug 24, 2011 at 07:50:37AM -0500, Anthony Liguori wrote: > On 08/24/2011 06:32 AM, Saggi Mizrahi wrote: > >On Tue 23 Aug 2011 07:21:56 PM IDT, Anthony Liguori wrote: > >>But QEMU is GPL. Libraries derived from QEMU will also be GPL. > >> > >>Regards, > >> > >>Anthony Liguori > >> > >>> > >>

Re: [Qemu-devel] [PATCH STABLE-0.14/0.15/master] CVE-2011-0011: fix VNC password change to not touch authentication settings

2011-08-24 Thread Daniel P. Berrange
On Wed, Aug 24, 2011 at 07:55:38AM -0500, Anthony Liguori wrote: > On 08/24/2011 07:50 AM, Daniel P. Berrange wrote: > >On Wed, Aug 24, 2011 at 07:45:06AM -0500, Anthony Liguori wrote: > >>On 08/24/2011 06:01 AM, Daniel P. Berrange wrote: > >>>From: "Daniel P. Be

Re: [Qemu-devel] [PATCH 14/14] vnc: don't demote authentication protocol when disabling login

2011-08-24 Thread Daniel P. Berrange
On Wed, Aug 24, 2011 at 01:43:09PM -0500, Anthony Liguori wrote: > Currently when disabling login in VNC, the password is cleared out and the > authentication protocol is forced to AUTH_VNC. If you're using a stronger > authentication protocol, this has the effect of downgrading your security > pr

Re: [Qemu-devel] [PATCH 1/3] Avoid the use of deprecated gnutls gnutls_*_set_priority functions.

2011-08-25 Thread Daniel P. Berrange
; > "NORMAL" : "NORMAL:+ANON-DH", NULL) < 0) { > >             gnutls_deinit(vs->tls.session); > >             vs->tls.session = NULL; > >             vnc_client_error(vs); > > -- > > 1.7.6 > > Daniel, > This patch

Re: [Qemu-devel] [PATCH] ui: avoid use of deprecated gnutls_*_set_priority functions

2011-08-25 Thread Daniel P. Berrange
On Thu, Aug 25, 2011 at 01:27:00PM +0100, Peter Maydell wrote: > On 25 August 2011 13:11, Stefan Hajnoczi wrote: > > From: Raghavendra D Prabhu > > > > The gnutls_*_set_priority family of functions has been marked deprecated > > in 2.12.x. These functions have been superceded by > > gnutls_priori

Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009)

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 11:54:49AM +0200, Gerd Hoffmann wrote: > On 08/19/11 19:08, Alon Levy wrote: > >Fix the ticket expiration on target vm for a spice connection without > >introducing > >a race between the spice server switching the client to the new host itself > >and > >the target libvirt

Re: [Qemu-devel] [RfC PATCH] usb/vmstate: add parent dev path

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 12:11:20PM +0200, Gerd Hoffmann wrote: > ... to make vmstate id string truely unique with multiple host > controllers, i.e. move from "1/usb-ptr" to ":00:01.3/1/usb-ptr" > (usb tabled connected to piix3 uhci). > > Obvious problem with that is that it breaks migration fr

[Qemu-devel] [PATCH] Ensure migrate_cancel does not block doing I/O

2011-08-26 Thread Daniel P. Berrange
From: "Daniel P. Berrange" There are two common cases where migrate_cancel is intended to be used 1. When migration is not converging due to an overactive guest and insufficient network bandwidth 2. When migration is stuck due a network outage, waiting for the TCP transm

Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009)

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:00:29PM +0200, Gerd Hoffmann wrote: > Hi, > > >>Ok, so I think we should be able to fix the race outlined above > >>without adding new monitor commands, just by letting libvirt set the > >>spice ticket in stage 2. > > > >Is that different then what I suggested in my re

Re: [Qemu-devel] [PATCH] Ensure migrate_cancel does not block doing I/O

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 11:59:28AM +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > There are two common cases where migrate_cancel is intended to be > used > > 1. When migration is not converging due to an overactive > guest and insuf

Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009)

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 02:39:59PM +0200, Gerd Hoffmann wrote: > >> (1) libvirt sets spice ticket at dst (stage 2) > >> (2) migration src->dst (stage 3) > >> (3) spice client switches connection to dst > > > >This is actually what we have already. The problem is that > >the 'migration src->ds

Re: [Qemu-devel] [RFC] block I/O throttling: how to enable in libvirt

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 09:11:49AM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 01, 2011 at 01:05:31PM +0800, Zhi Yong Wu wrote: > > On Wed, Aug 31, 2011 at 08:18:19AM +0100, Stefan Hajnoczi wrote: > > >On Tue, Aug 30, 2011 at 2:46 PM, Adam Litke wrote: > > >> On Tue, Aug 30, 2011 at 09:53:33AM +01

[Qemu-devel] [PATCH] Preserve current monitor CPU when issuing HMP passthrough commands

2011-09-01 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Several info commands rely on the 'mon_cpu' field in the Monitor struct. This field can be updated using the 'cpu NN' command. The processing for HMP passthrough commands, however, does not use the global 'Monitor *' instance,

[Qemu-devel] QEMU online guest disk resize wrt host block devices

2011-09-01 Thread Daniel P. Berrange
We want to support online resize of guest disks in the libvirt API for QEMU, and had intended to use the fairly recently added 'block_resize' command: commit db97ee6a976bacbb0d18818e951cfc41b39269a7 Author: Christoph Hellwig Date: Mon Jan 24 13:32:41 2011 +0100 block: tell drivers a

Re: [Qemu-devel] QEMU online guest disk resize wrt host block devices

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 02:27:55PM +0100, Daniel P. Berrange wrote: > We want to support online resize of guest disks in the libvirt API for > QEMU, and had intended to use the fairly recently added 'block_resize' > command: > > commit db97ee6a976bacbb0d18818e95

Re: [Qemu-devel] QEMU online guest disk resize wrt host block devices

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 04:05:26PM +0200, Christoph Hellwig wrote: > On Thu, Sep 01, 2011 at 02:27:55PM +0100, Daniel P. Berrange wrote: > > I see two likely approaches: > > > > 1. Add a parameter to the existing 'block_resize' command > > 'refreshon

Re: [Qemu-devel] [PATCH] monitor: Protect outbuf from concurrent access

2011-09-01 Thread Daniel P. Berrange
APIs that monitor.c exposes to internal QEMU code, so we're future proofed against other surprises. > Signed-off-by: Luiz Capitulino Signed-off-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://l

Re: [Qemu-devel] [PATCH] monitor: Protect outbuf from concurrent access

2011-09-02 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 08:34:35PM -0500, Anthony Liguori wrote: > On 09/01/2011 02:35 PM, Luiz Capitulino wrote: > >Sometimes, when having lots of VMs running on a RHEV host and the user > >attempts to close a SPICE window, libvirt will get corrupted json from > >QEMU. > > > >After some investigat

Re: [Qemu-devel] QEMU online guest disk resize wrt host block devices

2011-09-02 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 05:55:43PM +0200, Christoph Hellwig wrote: > Please try the attached (untested) patch: Yes, this patch worked succesfully with the following test case: $ dd if=/dev/zero of=loop.img bs=1M seek=100 count=0 $ losetup -f loop.img $ ./x86_64-softmmu/qemu-system-x86_64 -

[Qemu-devel] [PATCH] Display sector count in 'info block' output

2011-09-02 Thread Daniel P. Berrange
From: "Daniel P. Berrange" To aid in knowing whether a 'block_resize' was succesful, display the sector count in the 'info block' output Signed-off-by: Daniel P. Berrange --- block.c |6 -- qmp-commands.hx |1 + 2 files changed, 5 insertions(

[Qemu-devel] [PATCH v2] Display logical disk size in 'info block' output

2011-09-02 Thread Daniel P. Berrange
From: "Daniel P. Berrange" To aid in knowing whether a 'block_resize' was succesful, display the logical disk size in bytes, in the 'info block' output In v2: - Replace sectors with bytes Signed-off-by: Daniel P. Berrange --- block.c |6 -- qmp

Re: [Qemu-devel] [PATCH] Display sector count in 'info block' output

2011-09-02 Thread Daniel P. Berrange
On Fri, Sep 02, 2011 at 04:37:24PM +0100, Stefan Hajnoczi wrote: > On Fri, Sep 2, 2011 at 4:01 PM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > To aid in knowing whether a 'block_resize' was succesful, display > > the sector coun

Re: [Qemu-devel] [PATCH 12/15] qapi: add change-vnc-listen (v2)

2011-09-12 Thread Daniel P. Berrange
On Fri, Sep 02, 2011 at 05:50:05PM -0300, Luiz Capitulino wrote: > On Fri, 2 Sep 2011 12:34:55 -0500 > Anthony Liguori wrote: > > > New QMP only command to change the VNC server's listening address. > > > > Signed-off-by: Anthony Liguori > > --- > > v1 -> v2 > > - Enhanced docs (Luiz) > > ---

Re: [Qemu-devel] [PATCH 12/15] qapi: add change-vnc-listen (v2)

2011-09-12 Thread Daniel P. Berrange
On Mon, Sep 12, 2011 at 10:17:21AM +0100, Daniel P. Berrange wrote: > On Fri, Sep 02, 2011 at 05:50:05PM -0300, Luiz Capitulino wrote: > > On Fri, 2 Sep 2011 12:34:55 -0500 > > Anthony Liguori wrote: > > > > > New QMP only command to change the

Re: [Qemu-devel] [PATCH V12 00/15] virtio-9p: chroot environment for passthrough security model

2011-09-12 Thread Daniel P. Berrange
On Tue, Sep 06, 2011 at 03:48:22PM +0100, Stefan Hajnoczi wrote: > On Mon, Sep 05, 2011 at 09:48:21PM +0530, M. Mohan Kumar wrote: > > Qemu need to be invoked by root user for using virtfs with passthrough > > security model (i.e to use chroot() syscall). > > > > Question is: Is running qemu by ro

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Daniel P. Berrange
On Thu, Sep 15, 2011 at 08:51:00AM +1000, ronnie sahlberg wrote: > On Thu, Sep 15, 2011 at 12:36 AM, Christoph Hellwig wrote: > ... > >> > +/* > >> > + * We support iscsi url's on the form > >> > + * iscsi://[%@][:]// > >> > + */ > > > > Is having username + password on the command line really a t

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread Daniel P. Berrange
On Thu, Sep 15, 2011 at 11:48:35AM +0300, Dor Laor wrote: > On 09/15/2011 09:04 AM, Paolo Bonzini wrote: > >On 09/15/2011 01:08 AM, ronnie sahlberg wrote: > >>I think it is reasonable to just not support iscsi at all for > >>blocksize that is not multiple of 512 bytes > >>since a read-modify-write

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Daniel P. Berrange
On Thu, Sep 15, 2011 at 12:17:54PM +0100, Stefan Hajnoczi wrote: > On Wed, Sep 14, 2011 at 6:05 PM, Stefan Berger > wrote: > >  One property of the blobstore is that it has a certain required size for > > accommodating all blobs of device that want to store their blobs onto. The > > assumption is

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Daniel P. Berrange
On Wed, Sep 14, 2011 at 01:05:44PM -0400, Stefan Berger wrote: > Hello! > > Over the last few days primarily Michael Tsirkin and I have > discussed the design of the 'blobstore' via IRC (#virtualization). > The intention of the blobstore is to provide storage to persist > blobs that devices crea

Re: [Qemu-devel] Design of the blobstore

2011-09-15 Thread Daniel P. Berrange
On Thu, Sep 15, 2011 at 09:13:25AM -0400, Stefan Berger wrote: > On 09/15/2011 09:05 AM, Daniel P. Berrange wrote: > >On Wed, Sep 14, 2011 at 01:05:44PM -0400, Stefan Berger wrote: > >>Hello! > >> > >> Over the last few days primarily Michael Tsirkin and I

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-04-10 Thread Daniel P. Berrange
On Wed, Mar 05, 2014 at 03:33:39PM +0100, Paolo Bonzini wrote: > Il 05/03/2014 15:21, Daniel P. Berrange ha scritto: > >>alpha/typhoon.c:b = pci_register_bus(dev, "pci", > >>mips/gt64xxx_pci.c: phb->bus = pci_register_bus(dev, "pci", > &

Re: [Qemu-devel] Should we have a 2.0-rc3 ?

2014-04-11 Thread Daniel P. Berrange
On Fri, Apr 11, 2014 at 10:01:37AM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > On 04/10/2014 07:45 AM, Alexander Graf wrote: > > > > > > Is this something that can be quickly fixed (perhaps by reverting the > > PPC patch until a more complete solution is ready), and if

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

2014-01-14 Thread Daniel P. Berrange
On Tue, Jan 14, 2014 at 04:19:41PM +0100, Paolo Bonzini wrote: > Il 14/01/2014 15:47, Richard Henderson ha scritto: > +echo "CONFIG_STAMP=`date +%s`_$$_$RANDOM" >> $config_host_mak > >>> >> > >>> >> I really really don't like random numbers that make for non-repeatable > >>> >> builds. > >>>

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

2014-01-14 Thread Daniel P. Berrange
On Tue, Jan 14, 2014 at 04:31:00PM +0100, Paolo Bonzini wrote: > Il 14/01/2014 16:25, Peter Maydell ha scritto: > > I definitely think we want at least a basic molly-guard on > > "module not compiled for this qemu"; we need not attempt > > to make it impervious to somebody who's determined to get >

Re: [Qemu-devel] [PATCH 4/6] virtfs-proxy-helper: replace send_fd with qemu_send_with_fd

2014-01-16 Thread Daniel P. Berrange
On Wed, Jan 08, 2014 at 05:12:54PM +0800, Lei Li wrote: > Signed-off-by: Lei Li > --- > fsdev/virtfs-proxy-helper.c | 51 ++ > hw/9pfs/virtio-9p-proxy.h |5 > 2 files changed, 8 insertions(+), 48 deletions(-) > > diff --git a/fsdev/virtfs-prox

Re: [Qemu-devel] [PATCH 5/6] virtio-9p-proxy: replace v9fs_receivefd with qemu_recv_with_fd

2014-01-16 Thread Daniel P. Berrange
On Wed, Jan 08, 2014 at 05:12:55PM +0800, Lei Li wrote: > Signed-off-by: Lei Li > --- > hw/9pfs/virtio-9p-proxy.c | 60 ++-- > 1 files changed, 3 insertions(+), 57 deletions(-) > > diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c > inde

Re: [Qemu-devel] [PATCH resend 0/6 RFC] Provide common methods for exchange FD

2014-01-16 Thread Daniel P. Berrange
On Wed, Jan 08, 2014 at 05:12:50PM +0800, Lei Li wrote: > This patch series tries to refactor the functions used for > exchange of FD in current code, provide common methods > for it. > > The series is based on the localhost migration with side channel > for ram series as it was already a good sh

Re: [Qemu-devel] [PATCH 1/6] qemu-fd-exchange: provide common methods for exchange fd

2014-01-17 Thread Daniel P. Berrange
On Wed, Jan 08, 2014 at 05:12:51PM +0800, Lei Li wrote: > Signed-off-by: Lei Li > --- > include/qemu/fd-exchange.h | 25 +++ > util/Makefile.objs |1 + > util/qemu-fd-exchange.c| 97 > > 3 files changed, 123 insertions(+),

Re: [Qemu-devel] [RFC][PATCH v2]Add timestamp to error message

2013-05-01 Thread Daniel P. Berrange
On Wed, May 01, 2013 at 06:16:33AM -0600, Eric Blake wrote: > On 05/01/2013 06:05 AM, Stefan Hajnoczi wrote: > > >> +error_printf( > >> + "%4d-%02d-%02d %02d:%02d:%02d.%03lld+ ", > >> + fields.tm_year + 1900, fields.tm_mon + 1, fields.tm_mday, > >> + fields.tm

Re: [Qemu-devel] [libvirt] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-03 Thread Daniel P. Berrange
On Thu, May 02, 2013 at 10:40:06AM -0500, Anthony Liguori wrote: > Kevin Wolf writes: > >> >> + > >> >> +if (strcmp(type, "ide-cd") == 0) { > >> >> +disk_type = DT_CDROM; > >> >> +} else if (strcmp(type, "isa-fdc") == 0) { > >> >> +disk_type = DT_FLOPPY; > >

Re: [Qemu-devel] [libvirt] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-03 Thread Daniel P. Berrange
On Fri, May 03, 2013 at 08:52:59AM -0500, Anthony Liguori wrote: > "Daniel P. Berrange" writes: > > > On Thu, May 02, 2013 at 10:40:06AM -0500, Anthony Liguori wrote: > >> Kevin Wolf writes: > >> >> >> + > >> >> >> +

Re: [Qemu-devel] [PATCH 1/9] Add API to manipulate dump_bitmap

2013-05-07 Thread Daniel P. Berrange
On Tue, May 07, 2013 at 10:14:11AM -0600, Eric Blake wrote: > On 05/07/2013 01:16 AM, Qiao Nuohan wrote: > > Struct dump_bitmap is associated with a tmp file, and the tmp file can be > > used > > to save data of bitmap in kdump-compressed format temporarily. > > The following patch will use these

Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

2013-05-10 Thread Daniel P. Berrange
On Fri, May 10, 2013 at 08:07:51AM -0500, Anthony Liguori wrote: > Chegu Vinod writes: > > > If a user chooses to turn on the auto-converge migration capability > > these changes detect the lack of convergence and throttle down the > > guest. i.e. force the VCPUs out of the guest for some dura

Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

2013-05-13 Thread Daniel P. Berrange
On Fri, May 10, 2013 at 10:08:05AM -0500, Anthony Liguori wrote: > "Daniel P. Berrange" writes: > > > On Fri, May 10, 2013 at 08:07:51AM -0500, Anthony Liguori wrote: > >> Chegu Vinod writes: > >> > >> > If a user chooses to turn on the auto

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Daniel P. Berrange
On Fri, May 17, 2013 at 11:54:12AM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment > > variable is set. The value of the environment variable determines the > > bit pattern used to wipe memory. For more informatio

Re: [Qemu-devel] [qemu-devel][libvirt] Default machine type setting for ppc64

2013-05-21 Thread Daniel P. Berrange
On Tue, May 21, 2013 at 09:31:26AM +0100, Peter Maydell wrote: > On 21 May 2013 09:19, Li Zhang wrote: > > We encounter this problem in openstack which always use > > default machine type. Currently, QEMU sets mac99 as default > > setting for ppc64 but it doesn't work on our platform at all. > > >

Re: [Qemu-devel] [qemu-devel][libvirt] Default machine type setting for ppc64

2013-05-21 Thread Daniel P. Berrange
On Tue, May 21, 2013 at 05:02:51PM +0800, Li Zhang wrote: > On 2013年05月21日 16:45, Peter Maydell wrote: > >On 21 May 2013 09:39, Daniel P. Berrange wrote: > >>Libvirt has always had support for specifying what machine type to use. > >>This discussion is simply about what

Re: [Qemu-devel] [qemu-devel][libvirt] Default machine type setting for ppc64

2013-05-21 Thread Daniel P. Berrange
On Tue, May 21, 2013 at 07:55:27PM +1000, Paul Mackerras wrote: > On Tue, May 21, 2013 at 09:39:53AM +0100, Daniel P. Berrange wrote: > > On Tue, May 21, 2013 at 09:31:26AM +0100, Peter Maydell wrote: > > > On 21 May 2013 09:19, Li Zhang wrote: > > > > We encounter t

Re: [Qemu-devel] [libvirt] [qemu-devel] Default machine type setting for ppc64

2013-05-21 Thread Daniel P. Berrange
On Tue, May 21, 2013 at 11:12:26AM -0600, Eric Blake wrote: > On 05/21/2013 10:42 AM, Anthony Liguori wrote: > > Perhaps the right thing to do for OpenStack is to allow for a user > > specified configuration file to select things like the default hardware > > models/machine types? Then this could

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-18 Thread Daniel P. Berrange
On Tue, Feb 18, 2014 at 11:07:53AM +0100, Paolo Bonzini wrote: > Il 18/02/2014 10:05, Stefan Hajnoczi ha scritto: > >>> SIGABRT is normally synchronous enough: it's sent by abort(). But of > >>> course, nothing stops the user from kill -ABRT. Or GLib from calling > >>> abort() in some place where

[Qemu-devel] [PATCH] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Daniel P. Berrange
encryption, directing users to dm-crypt / LUKS which can meet modern cryptography best practices. Signed-off-by: Daniel P. Berrange --- qemu-doc.texi | 23 --- qemu-img.texi | 23 --- 2 files changed, 40 insertions(+), 6 deletions(-) BTW, I based this pat

Re: [Qemu-devel] [PATCH] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Daniel P. Berrange
On Wed, Jan 22, 2014 at 11:49:21AM +, Peter Maydell wrote: > On 22 January 2014 11:36, Daniel P. Berrange wrote: > > Recommend against any use of QCow/QCow2 encryption, directing > > users to dm-crypt / LUKS which can meet modern cryptography > > best practices. > >

[Qemu-devel] [PATCH v2] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Daniel P. Berrange
encryption, directing users to dm-crypt / LUKS which can meet modern cryptography best practices. Signed-off-by: Daniel P. Berrange --- qemu-doc.texi | 23 --- qemu-img.texi | 23 --- 2 files changed, 40 insertions(+), 6 deletions(-) In v2: - Addre

Re: [Qemu-devel] [PATCH v2] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Daniel P. Berrange
On Wed, Jan 22, 2014 at 08:24:00AM -0700, Eric Blake wrote: > On 01/22/2014 05:28 AM, Daniel P. Berrange wrote: > > > > > Recommend against any use of QCow/QCow2 encryption, directing > > users to dm-crypt / LUKS which can meet modern cryptography > > best pra

[Qemu-devel] [PATCH v3] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Daniel P. Berrange
old files. Recommend against any use of QCow/QCow2 encryption, directing users to dm-crypt / LUKS which can meet modern cryptography best practices. Signed-off-by: Daniel P. Berrange Reviewed-by: Markus Armbruster --- qemu-doc.texi | 23 --- qemu-img.texi | 23

Re: [Qemu-devel] [PULL 3/4] trace: add glib 2.32+ static GMutex support

2014-01-27 Thread Daniel P. Berrange
On Mon, Jan 27, 2014 at 03:53:05PM +0100, Stefan Hajnoczi wrote: > The GStaticMutex API was deprecated in glib 2.32. We cannot switch over > to GMutex unconditionally since we would drop support for older glib > versions. But the deprecated API warnings during build are annoying so > use static G

Re: [Qemu-devel] [PATCH] configure: use glib in glib pkg-config check.

2014-02-03 Thread Daniel P. Berrange
On Mon, Feb 03, 2014 at 03:26:15PM +1100, Chris Johns wrote: > Building against with a recent glib in a custom prefix fails because > the gthread cflags in the pkg-config file do not have the correct path > while the glib pc file does. > > Signed-off-by: Chris Johns > --- > configure | 6 +++---

Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-02-03 Thread Daniel P. Berrange
On Mon, Feb 03, 2014 at 06:00:42PM +0800, Chen Gang wrote: > We can not assume "'path' + 'ctx->fs_root'" must be less than MAX_PATH, > so need use snprintf() instead of sprintf(). > > And also recommend to use ARRAY_SIZE instead of hard code macro for an > array size in snprintf(). In the event t

Re: [Qemu-devel] Improving patch tracking - something like gerrit?

2014-02-03 Thread Daniel P. Berrange
On Mon, Feb 03, 2014 at 12:45:31PM +, Mark Cave-Ayland wrote: > Hi all, > > It should be fairly evident to most people that the volume of > patches flowing through the qemu-devel mailing list is continually > increasing, and it is becoming increasingly difficult to track which > patches have b

Re: [Qemu-devel] [PATCH] configure: use glib in glib pkg-config check.

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 09:56:38AM +1100, Chris Johns wrote: > On 3/02/2014 9:29 pm, Daniel P. Berrange wrote: > >On Mon, Feb 03, 2014 at 03:26:15PM +1100, Chris Johns wrote: > >>Building against with a recent glib in a custom prefix fails because > >>the gthread cflag

Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 07:02:18PM +0800, Chen Gang wrote: > On 02/03/2014 06:39 PM, Chen Gang wrote: > > On 02/03/2014 06:34 PM, Daniel P. Berrange wrote: > >> On Mon, Feb 03, 2014 at 06:00:42PM +0800, Chen Gang wrote: > >>> We can not assume "'path'

Re: [Qemu-devel] [PATCH 06/17] migration-local: add send_pipefd()

2013-12-02 Thread Daniel P. Berrange
On Mon, Dec 02, 2013 at 05:19:06PM +0800, Lei Li wrote: > This patch adds send_pipefd() to pass the pipe file descriptor > to destination process. > > Signed-off-by: Lei Li > --- > migration-local.c | 46 ++ > 1 files changed, 46 insertions(+), 0 del

Re: [Qemu-devel] [PATCH 06/17] migration-local: add send_pipefd()

2013-12-03 Thread Daniel P. Berrange
On Tue, Dec 03, 2013 at 07:19:40PM +0800, Lei Li wrote: > On 12/02/2013 05:33 PM, Daniel P. Berrange wrote: > >On Mon, Dec 02, 2013 at 05:19:06PM +0800, Lei Li wrote: > >>This patch adds send_pipefd() to pass the pipe file descriptor > >>to destination process. >

Re: [Qemu-devel] [PATCH] seccomp: "-sandbox on" won't kill Qemu when option not built in

2013-12-09 Thread Daniel P. Berrange
On Mon, Dec 09, 2013 at 03:20:52PM -0200, Eduardo Otubo wrote: > This option was requested by virt-test team so they can run tests with > Qemu and "-sandbox on" set without breaking whole test if host doesn't > have support for seccomp in kernel. It covers two possibilities: > > 1) Host kernel su

Re: [Qemu-devel] [PATCH V17 02/11] NUMA: check if the total numa memory size is equal to ram_size

2013-12-11 Thread Daniel P. Berrange
On Tue, Dec 10, 2013 at 05:01:02PM -0200, Eduardo Habkost wrote: > On Tue, Dec 10, 2013 at 07:03:50PM +0100, Paolo Bonzini wrote: > > Il 10/12/2013 14:15, Eduardo Habkost ha scritto: > > >> > If the total number of the assigned numa nodes memory is not > > >> > equal to the assigned ram size, it wi

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread Daniel P. Berrange
On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: > This patch adds native support for accessing images on NFS shares without > the requirement to actually mount the entire NFS share on the host. > > NFS Images can simply be specified by an url of the form: > nfs: > > For example:

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Daniel P. Berrange
On Wed, Dec 18, 2013 at 12:03:24AM +0100, Peter Lieven wrote: > > > > Am 17.12.2013 um 18:32 schrieb "Daniel P. Berrange" : > > > >> On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: > >> This patch adds native support for accessing ima

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Daniel P. Berrange
On Wed, Dec 18, 2013 at 12:00:03PM +0200, Orit Wasserman wrote: > On 12/18/2013 01:03 AM, Peter Lieven wrote: > > > > > >>Am 17.12.2013 um 18:32 schrieb "Daniel P. Berrange" : > >> > >>>On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven w

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-12-18 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 09:29:54AM +0100, Stefan Hajnoczi wrote: > On Tue, Dec 10, 2013 at 10:23:41PM +, Alex Bennée wrote: > > > > stefa...@redhat.com writes: > > > > > On Mon, Nov 18, 2013 at 12:54:59PM +0800, Chunyan Liu wrote: > > >> 2013/11/15 Stefan Hajnoczi > > >> > > >> > On Thu, No

Re: [Qemu-devel] [PATCH v3 for-1.7] rdma: rename 'x-rdma' => 'rdma'

2013-11-15 Thread Daniel P. Berrange
On Wed, Nov 06, 2013 at 01:59:14PM -0500, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > As far as we can tell, all known bugs have been fixed: [snip] > 3. Libvirt patches are ready [snip] > Objections? There was a first round of patches posted to the libvirt list back in J

Re: [Qemu-devel] [PATCH v3 for-1.7] rdma: rename 'x-rdma' => 'rdma'

2013-11-16 Thread Daniel P. Berrange
On Fri, Nov 15, 2013 at 12:25:30PM -0700, Eric Blake wrote: > On 11/15/2013 10:40 AM, Michael R. Hines wrote: > > > > This is unrelated to RDMA - accessing the /dev/infiniband > > device nodes is already supported by libvirt my modifying > > the configuration file in /etc and that works just fine.

Re: [Qemu-devel] [PATCH 0/17 v3] Localhost migration with side channel for ram

2013-11-21 Thread Daniel P. Berrange
On Thu, Nov 21, 2013 at 05:11:23PM +0800, Lei Li wrote: > This patch series tries to introduce a mechanism using side > channel pipe for RAM via SCM_RIGHTS with unix domain socket > protocol migration. > > This side channel is used for the page flipping by vmsplice, > which is the internal mechani

Re: [Qemu-devel] [PATCH 0/17 v3] Localhost migration with side channel for ram

2013-11-22 Thread Daniel P. Berrange
On Fri, Nov 22, 2013 at 07:29:05PM +0800, Lei Li wrote: > On 11/21/2013 06:19 PM, Daniel P. Berrange wrote: > >On Thu, Nov 21, 2013 at 05:11:23PM +0800, Lei Li wrote: > >In discussions about supporting this for libvirt, we were told that > >when this localhost migration fails

Re: [Qemu-devel] [PATCH v3 for-1.7 resend] rdma: rename 'x-rdma' => 'rdma'

2013-11-22 Thread Daniel P. Berrange
On Sat, Nov 23, 2013 at 12:29:51AM +0800, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > As far as we can tell, all known bugs have been fixed: > 3. Libvirt patches are ready Please stop claiming this. A proof of concept was posted and got some review feedback. AFAIK, no follo

Re: [Qemu-devel] [RFC] allow special paths for libusbx

2013-11-27 Thread Daniel P. Berrange
On Wed, Nov 27, 2013 at 11:09:19AM +0100, Erik Rull wrote: > Hi all, > > I don't have libusbx installed on my system but the source package is > available > and compiled for development. > This may also help other users to enable the libusbx support without having it > actually installed on the c

Re: [Qemu-devel] [PATCH 06/17] migration-local: add send_pipefd()

2013-11-29 Thread Daniel P. Berrange
On Fri, Nov 29, 2013 at 06:06:13PM +0800, Lei Li wrote: > This patch adds send_pipefd() to pass the pipe file descriptor > to destination process. > > Signed-off-by: Lei Li > --- > migration-local.c | 46 ++ > 1 files changed, 46 insertions(+), 0 del

Re: [Qemu-devel] [GSoC] Wanted: small warmup tasks

2014-04-25 Thread Daniel P. Berrange
On Thu, Apr 24, 2014 at 08:19:19AM +0200, Jan Kiszka wrote: > On 2014-04-23 11:25, Stefan Hajnoczi wrote: > > Dear QEMU, Libvirt, and KVM communities, > > We are participating in Google Summer of Code 2014 > > (http://google-melange.com/) and Outreach Program for Women > > (http://opw.gnome.org/).

<    1   2   3   4   5   6   7   8   9   10   >