Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-06 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 11:36:54PM +0200, Pino Toscano wrote: > Rewrite the implementation of the ssh block driver to use libssh instead > of libssh2. The libssh library has various advantages over libssh2: > - easier API for authentication (for example for using ssh-agent) > - easier API for know

Re: [Qemu-devel] [PATCH] qapi: InitSocketAddress: add keepalive option

2019-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2019 at 01:15:33PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > Hi all! > > This is a continuation of "[PATCH v2 0/2] nbd: enable keepalive", but > it's a try from another side, so almost nothing common with v2. > > > qapi/

Re: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks

2019-06-07 Thread Daniel P . Berrangé
On Fri, Jun 07, 2019 at 08:59:31AM +0200, Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 27/05/19 10:00, Markus Armbruster wrote: > >> As long as we don't have an active QOM maintainer[*], the benefit is > >> low. > >> > >> > >> [*] We need one. I'm not volunteering. > > > > I think

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-07 Thread Daniel P . Berrangé
On Fri, Jun 07, 2019 at 12:14:37PM +0200, Philippe Mathieu-Daudé wrote: > On 6/7/19 12:08 PM, Daniel P. Berrangé wrote: > > On Thu, Jun 06, 2019 at 07:51:15PM +0200, Pino Toscano wrote: > >> On Thursday, 6 June 2019 13:12:32 CEST Daniel P. Berrangé wrote: > >>> On W

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-07 Thread Daniel P . Berrangé
On Thu, Jun 06, 2019 at 07:51:15PM +0200, Pino Toscano wrote: > On Thursday, 6 June 2019 13:12:32 CEST Daniel P. Berrangé wrote: > > On Wed, Jun 05, 2019 at 11:36:54PM +0200, Pino Toscano wrote: > > > Rewrite the implementation of the ssh block driver to use libssh instead >

Re: [Qemu-devel] [PATCH] MAINTAINERS: new maintainers for QOM

2019-06-07 Thread Daniel P . Berrangé
uardo Habkost > Suggested-by: Markus Armbruster > Signed-off-by: Paolo Bonzini > --- > MAINTAINERS | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.f

Re: [Qemu-devel] [RFC PATCH 00/10] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-07 Thread Daniel P . Berrangé
On Fri, Jun 07, 2019 at 03:54:20PM +0200, Kevin Wolf wrote: > monitor.c mixes a lot of different things in a single file: The core > monitor infrastructure, HMP infrastrcture, QMP infrastructure, and the > implementation of several HMP and QMP commands. Almost worse, struct > Monitor mixes state fo

Re: [Qemu-devel] [RFC PATCH 00/10] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-07 Thread Daniel P . Berrangé
On Fri, Jun 07, 2019 at 04:25:14PM +0200, Kevin Wolf wrote: > Am 07.06.2019 um 16:03 hat Daniel P. Berrangé geschrieben: > > On Fri, Jun 07, 2019 at 03:54:20PM +0200, Kevin Wolf wrote: > > > monitor.c mixes a lot of different things in a single file: The core > > >

Re: [Qemu-devel] Headers without multiple inclusion guards

2019-06-07 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 07:52:50PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, May 28, 2019 at 08:12:24PM +0200, Markus Armbruster wrote: > >> We have a bunch of headers without multiple inclusion guards. Some are > >> clearly int

Re: [Qemu-devel] [PATCH 7/8] VNC Acceptance test: check protocol version

2019-06-07 Thread Daniel P . Berrangé
On Fri, Jun 07, 2019 at 11:22:22AM -0400, Cleber Rosa wrote: > This goes a bit further than the other tests, and does a basic (read > only) interaction with the VNC protocol. > > This is not a enough to perform a handshake, but enough to make sure > that the socket is somewhat operational and that

Re: [Qemu-devel] [PATCH 2/2] qemu-tech.texi: Remove "QEMU compared to other emulators" section

2019-06-07 Thread Daniel P . Berrangé
to do that on the project's wiki where > we can update it more dynamically. > > Signed-off-by: Peter Maydell > --- > qemu-tech.texi | 107 --------- > 1 file changed, 107 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, D

Re: [Qemu-devel] [PATCH 15/18] Boot Linux Console Test: add a test for aarch64 + virt

2019-06-10 Thread Daniel P . Berrangé
On Fri, Jun 07, 2019 at 03:58:57PM -0300, Eduardo Habkost wrote: > CCing Daniel, who wrote commit 6ab3fc32ea64. > > On Fri, Jun 07, 2019 at 11:44:32AM -0400, Cleber Rosa wrote: > > On Fri, Jun 07, 2019 at 12:42:14AM -0300, Eduardo Habkost wrote: > > > On Fri, Jun 07, 2019 at 12:26:48AM -0300, Edua

Re: [Qemu-devel] [PATCH 7/8] VNC Acceptance test: check protocol version

2019-06-10 Thread Daniel P . Berrangé
On Fri, Jun 07, 2019 at 02:12:07PM -0400, Cleber Rosa wrote: > On Fri, Jun 07, 2019 at 06:29:15PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 07, 2019 at 11:22:22AM -0400, Cleber Rosa wrote: > > > This goes a bit further than the other tests, and does a basic (read >

Re: [Qemu-devel] [PATCH] RFC: qio: Improve corking of TLS sessions

2019-06-10 Thread Daniel P . Berrangé
On Fri, Jun 07, 2019 at 05:14:14PM -0500, Eric Blake wrote: > Our current implementation of qio_channel_set_cork() is pointless for > TLS sessions: we block the underlying channel, but still hand things > piecemeal to gnutls which then produces multiple encryption packets. > Better is to directly u

Re: [Qemu-devel] [PATCH 2/7] iotests: amendment for benchmark output of 039 061 137

2019-06-10 Thread Daniel P . Berrangé
On Sun, Jun 09, 2019 at 09:35:43PM +0300, Andrey Shinkevich wrote: > After including the Valgrind into the QEMU processes wrappers in the > common.rc script, the output for the tests 039 061 137 has been > changed and is to be amended. The change to common.rc was done in the previous patch, so thi

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

2019-06-10 Thread Daniel P . Berrangé
On Mon, Jun 10, 2019 at 02:21:57PM +0100, Peter Maydell wrote: > On Mon, 10 Jun 2019 at 14:11, Eduardo Habkost wrote: > > > > On Mon, Jun 10, 2019 at 01:58:50PM +0100, Peter Maydell wrote: > > > Hi. This fails to build on one of my buildtest machines: > > > > > > ERROR: Cannot use 'python3', Pytho

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

2019-06-10 Thread Daniel P . Berrangé
On Mon, Jun 10, 2019 at 06:15:46PM +0100, Peter Maydell wrote: > On Mon, 10 Jun 2019 at 18:12, Daniel P. Berrangé wrote: > > There's been two new LTS releases of Ubuntu since then > > with Xenial and Bionic, so IMHO, it is pretty reasonable > > to want to drop Trusty

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

2019-06-10 Thread Daniel P . Berrangé
On Mon, Jun 10, 2019 at 06:38:05PM +0100, Peter Maydell wrote: > On Mon, 10 Jun 2019 at 18:30, Daniel P. Berrangé wrote: > > Do you have access to any machine in the compile farm or is access > > granted on a per-machine basis ? If i'm reading this page ri

Re: [Qemu-devel] [PATCH for-4.1 v2] q35: Revert to kernel irqchip

2019-06-12 Thread Daniel P . Berrangé
On Mon, Jun 03, 2019 at 10:06:06AM +0200, Paolo Bonzini wrote: > On 29/05/19 05:30, Michael S. Tsirkin wrote: > > On Tue, May 14, 2019 at 02:14:41PM -0600, Alex Williamson wrote: > >> Commit b2fc91db8447 ("q35: set split kernel irqchip as default") changed > >> the default for the pc-q35-4.0 machin

Re: [Qemu-devel] [PATCH 0/4] add failover feature for assigned network devices

2019-06-12 Thread Daniel P . Berrangé
On Tue, Jun 11, 2019 at 11:42:54AM -0400, Laine Stump wrote: > On 5/17/19 8:58 AM, Jens Freimann wrote: > > This is another attempt at implementing the host side of the > > net_failover concept > > (https://www.kernel.org/doc/html/latest/networking/net_failover.html) > > > > Changes since last RFC

[Qemu-devel] [PATCH v2] qapi: report the default CPU type for each machine

2019-06-12 Thread Daniel P . Berrangé
hines" QMP command so that it reports the default CPU model typename for each machine. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- Changed in v2: - Fix qapi docs version tag qapi/misc.json | 6 +- vl.c | 4 2 files changed, 9 insertions(+), 1 deletion(-

Re: [Qemu-devel] converting build system to Meson?

2019-03-08 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 06:18:28PM +, Peter Maydell wrote: > On Thu, 7 Mar 2019 at 18:17, Marc-André Lureau > wrote: > > As someone who has also been annoyed having to support in-tree and > > out-of-tree, I support that move. I used to be a pretty happy use of > > in-tree builds, but out-of-tr

Re: [Qemu-devel] converting build system to Meson?

2019-03-08 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 01:24:07PM -0600, Eric Blake wrote: > On 3/7/19 1:04 PM, Eric Blake wrote: > > > I don't mind a switch to mandatory out-of-tree builds (I like the > > convenience of in-tree for quick hacks, but VPATH is infinitely more > > flexible when testing multiple build configuration

Re: [Qemu-devel] bundling edk2 platform firmware images with QEMU

2019-03-08 Thread Daniel P . Berrangé
On Fri, Mar 08, 2019 at 02:09:53PM +0100, Laszlo Ersek wrote: > Hi, > > I have a mostly-ready-for-posting patch set for $SUBJECT. My question is > what QEMU release I should be targeting with it. > > The Soft Feature Freeze for 4.0 is on 2019-03-12. Here's why that's a > bit inconvenient for me.

Re: [Qemu-devel] bundling edk2 platform firmware images with QEMU

2019-03-08 Thread Daniel P . Berrangé
On Fri, Mar 08, 2019 at 01:42:11PM +, Daniel P. Berrangé wrote: > On Fri, Mar 08, 2019 at 02:09:53PM +0100, Laszlo Ersek wrote: > > Hi, > > > > I have a mostly-ready-for-posting patch set for $SUBJECT. My question is > > what QEMU release I should be targeting

Re: [Qemu-devel] bundling edk2 platform firmware images with QEMU

2019-03-08 Thread Daniel P . Berrangé
On Fri, Mar 08, 2019 at 03:48:07PM +0100, Laszlo Ersek wrote: > On 03/08/19 14:42, Daniel P. Berrangé wrote: > >> pc-bios/edk2-aarch64-code.fd | Bin 0 -> 67108864 bytes > >> pc-bios/edk2-arm-code.fd | Bin 0 -> 67108864 bytes >

[Qemu-devel] [PATCH v2 1/1] chardev: add support for authorization for TLS clients

2019-03-08 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Currently any client which can complete the TLS handshake is able to use a chardev server. The server admin can turn on the 'verify-peer' option for the x509 creds to require the client to provide a x509 certificate. This means the client will have to acquire a certific

[Qemu-devel] [PATCH v2 0/1] chardev: support for authorization control on TLS connections

2019-03-08 Thread Daniel P . Berrangé
s is none the less ready for the chardev tree, should the maintainer consider it acceptable. Changed in v2: - Fix docs typo Daniel P. Berrangé (1): chardev: add support for authorization for TLS clients chardev/char-socket.c | 12 +++- chardev/char.c| 3 +++ qapi/char.

Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

2019-03-11 Thread Daniel P . Berrangé
On Sat, Mar 09, 2019 at 02:10:17PM +0100, Michal Prívozník wrote: > On 3/9/19 1:48 AM, Laszlo Ersek wrote: > > Repo: https://github.com/lersek/qemu.git > > Branch: edk2_build > > > > This series advances the roms/edk2 submodule to the "edk2-stable201903" > > release, and builds and captures plat

Re: [Qemu-devel] converting build system to Meson?

2019-03-11 Thread Daniel P . Berrangé
On Sun, Mar 10, 2019 at 05:28:44PM +0100, Markus Armbruster wrote: > Paolo Bonzini writes: > > > Hi all, > > > > lately I have been thinking of converting the QEMU build system to > > Meson. Meson is a relatively new build system that can replace > > Autotools or hand-written Makefiles such as Q

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 03:29:41PM -0800, John G Johnson wrote: > > > > On Mar 7, 2019, at 11:27 AM, Stefan Hajnoczi wrote: > > > > On Thu, Mar 07, 2019 at 02:51:20PM +, Daniel P. Berrangé wrote: > >> I guess one obvious answer is that the existing secu

Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

2019-03-11 Thread Daniel P . Berrangé
On Sat, Mar 09, 2019 at 02:20:06AM +0100, Philippe Mathieu-Daudé wrote: > On 3/9/19 1:48 AM, Laszlo Ersek wrote: > > Repo: https://github.com/lersek/qemu.git > > Branch: edk2_build > > > > This series advances the roms/edk2 submodule to the "edk2-stable201903" > > release, and builds and capture

Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

2019-03-11 Thread Daniel P . Berrangé
On Sun, Mar 10, 2019 at 12:21:55PM +0100, Philippe Mathieu-Daudé wrote: > On 3/10/19 4:56 AM, Michael S. Tsirkin wrote: > > On Sat, Mar 09, 2019 at 01:48:16AM +0100, Laszlo Ersek wrote: > >> Repo: https://github.com/lersek/qemu.git > >> Branch: edk2_build > >> > >> This series advances the roms/e

Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

2019-03-11 Thread Daniel P . Berrangé
On Mon, Mar 11, 2019 at 08:57:04AM -0400, Michael S. Tsirkin wrote: > On Mon, Mar 11, 2019 at 10:28:01AM +0000, Daniel P. Berrangé wrote: > > On Sat, Mar 09, 2019 at 02:20:06AM +0100, Philippe Mathieu-Daudé wrote: > > > On 3/9/19 1:48 AM, Laszlo Ersek wrote: > > > &

Re: [Qemu-devel] [PATCH v2 0/4] memfd fixes.

2019-03-11 Thread Daniel P . Berrangé
On Mon, Mar 11, 2019 at 01:50:37PM +0100, Marc-André Lureau wrote: > Hi > > On Mon, Mar 11, 2019 at 1:35 PM Ilya Maximets wrote: > > > > Hi. > > > > I'm trying to figure out the state of this patch set. > > Is there any chance for it to be accepted? > > > > The first patch needs minor rebase. I c

Re: [Qemu-devel] [libvirt] [PULL 0/5] Ui 20190311 v2 patches

2019-03-11 Thread Daniel P . Berrangé
On Mon, Mar 11, 2019 at 01:45:13PM +, Peter Maydell wrote: > On Mon, 11 Mar 2019 at 08:40, Gerd Hoffmann wrote: > > > > The following changes since commit e2a18635a400b0e68679614132e9ef6316105590: > > > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2019-03-08' > > into staging

Re: [Qemu-devel] [PATCH v2 0/4] memfd fixes.

2019-03-11 Thread Daniel P . Berrangé
On Mon, Mar 11, 2019 at 11:12:29AM -0300, Eduardo Habkost wrote: > On Mon, Mar 11, 2019 at 12:56:14PM +0000, Daniel P. Berrangé wrote: > > On Mon, Mar 11, 2019 at 01:50:37PM +0100, Marc-André Lureau wrote: > > > Hi > > > > > > On Mon, Mar 11, 2019 at

Re: [Qemu-devel] [libvirt] [PULL 0/5] Ui 20190311 v2 patches

2019-03-11 Thread Daniel P . Berrangé
On Mon, Mar 11, 2019 at 03:08:16PM +0100, Samuel Thibault wrote: > Daniel P. Berrangé, le lun. 11 mars 2019 13:51:16 +, a ecrit: > > On Mon, Mar 11, 2019 at 01:45:13PM +, Peter Maydell wrote: > > > On Mon, 11 Mar 2019 at 08:40, Gerd Hoffmann wrote: > > > >

Re: [Qemu-devel] [PULL 4/5] hw/display: Add basic ATI VGA emulation

2019-03-12 Thread Daniel P . Berrangé
On Mon, Mar 11, 2019 at 07:55:45PM +, Mark Cave-Ayland wrote: > On 11/03/2019 19:51, BALATON Zoltan wrote: > > > On Mon, 11 Mar 2019, Markus Armbruster wrote: > >> Gerd Hoffmann writes: > >>> From: BALATON Zoltan > >>> > >>> At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI

Re: [Qemu-devel] [PATCH] ati-vga: fix tracing

2019-03-12 Thread Daniel P . Berrangé
uint64_t > val) "%u 0x%"PRIx64 " %s <- 0x%"PRIx64 FWIW, it would be valid to just make log_stap.py automatically convert HWADDR_PRIx into "%x", which will have the same functional effect and protect us against similar cases in the future. I don't mi

Re: [Qemu-devel] [PATCH v4 08/19] Boot Linux Console Test: update the x86_64 kernel

2019-03-12 Thread Daniel P . Berrangé
On Tue, Mar 12, 2019 at 08:11:39AM -0400, Cleber Rosa wrote: > Update to the stock Fedora 29 kernel, from the Fedora 28. New tests > will be added using the 29 kernel, so for consistency, let's also > update it here. > > Signed-off-by: Cleber Rosa > Reviewed-by: Caio Carrara > Reviewed-by: Phil

Re: [Qemu-devel] [PATCH v4 15/19] Boot Linux Console Test: add a test for ppc64 + pseries

2019-03-12 Thread Daniel P . Berrangé
On Tue, Mar 12, 2019 at 08:11:46AM -0400, Cleber Rosa wrote: > Just like the previous tests, boots a Linux kernel on a ppc64 target > using the pseries machine. > > Signed-off-by: Cleber Rosa > Reviewed-by: Caio Carrara > --- > .travis.yml| 2 +- > tests/acceptance/

Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

2019-03-12 Thread Daniel P . Berrangé
On Tue, Mar 12, 2019 at 04:40:45PM +0100, Laszlo Ersek wrote: > On 03/11/19 11:35, Daniel P. Berrangé wrote: > > On Sun, Mar 10, 2019 at 12:21:55PM +0100, Philippe Mathieu-Daudé wrote: > >> On 3/10/19 4:56 AM, Michael S. Tsirkin wrote: > >>> On Sat, Mar 09, 2019 at

[Qemu-devel] [PATCH RFC] seccomp: don't kill process for resource control syscalls

2019-03-13 Thread Daniel P . Berrangé
broken & needs fixing regardless. Signed-off-by: Daniel P. Berrangé --- qemu-seccomp.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/qemu-seccomp.c b/qemu-seccomp.c index 36d5829831..9776c9ef40 100644 --- a/qemu-seccomp.c +++ b/qemu-s

Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

2019-03-13 Thread Daniel P . Berrangé
On Tue, Mar 12, 2019 at 08:30:02PM +0100, Laszlo Ersek wrote: > On 03/12/19 16:59, Daniel P. Berrangé wrote: > > On Tue, Mar 12, 2019 at 04:40:45PM +0100, Laszlo Ersek wrote: > >> On 03/11/19 11:35, Daniel P. Berrangé wrote: > >>> On Sun, Mar 10, 2019 at 12:21:55PM

Re: [Qemu-devel] [PATCH v3 2/4] hw/firmware: Add Edk2Crypto and edk2_add_host_crypto_policy()

2019-03-13 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 10:43:29AM +0100, Laszlo Ersek wrote: > On 03/10/19 01:47, Philippe Mathieu-Daudé wrote: > > The Edk2Crypto object is used to hold configuration values specific > > to EDK2. > > > > The edk2_add_host_crypto_policy() function loads crypto policies > > from the host, and regi

Re: [Qemu-devel] [PATCH v4 01/17] util: add helper APIs for dealing with inotify in portable manner

2019-03-13 Thread Daniel P . Berrangé
On Tue, Mar 12, 2019 at 07:07:42PM -0400, Bandan Das wrote: > Daniel P. Berrangé writes: > ... > > + > > +int > > +qemu_file_monitor_add_watch(QFileMonitor *mon, > > +const char *dirpath, > > +

Re: [Qemu-devel] [build-error] possible build error at the tip of the trunk? (dtc-related?)

2019-03-13 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 01:14:35PM +, Peter Maydell wrote: > On Wed, 13 Mar 2019 at 12:09, Stefan Hajnoczi wrote: > > > > On Mon, Mar 11, 2019 at 04:49:15PM +, Aleksandar Markovic wrote: > > > Hello, all > > > > > > All of the sudden, the latest code doesn't build on my host: (the code >

[Qemu-devel] [PATCH] configure: remove slirp submodule support that doesn't exist yet

2019-03-13 Thread Daniel P . Berrangé
lopers are seeing with QEMU's submodule sync process. Signed-off-by: Daniel P. Berrangé --- NB, this change should be reverted only once slirp exists in the .git-modules file. configure | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/configure b/configure i

Re: [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG

2019-03-13 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 08:25:45AM -0700, Richard Henderson wrote: > On 3/12/19 11:41 PM, no-re...@patchew.org wrote: > > time make docker-test-mingw@fedora SHOW_ENV=1 J=14 NETWORK=1 > > === TEST SCRIPT END === > > > > CC hw/acpi/trace.o > > CC hw/alpha/trace.o > > /tmp/qemu-test/src

Re: [Qemu-devel] [PATCH v4 01/17] util: add helper APIs for dealing with inotify in portable manner

2019-03-13 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 01:19:58PM -0400, Bandan Das wrote: > Daniel P. Berrangé writes: > > > On Tue, Mar 12, 2019 at 07:07:42PM -0400, Bandan Das wrote: > >> Daniel P. Berrangé writes: > >> ... > >> > + > >> > +int

Re: [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG

2019-03-14 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 11:35:33AM -0700, Richard Henderson wrote: > On 3/13/19 10:57 AM, Daniel P. Berrangé wrote: > > We already have an internal API for providing strong random bytes in > > QEMU qcrypto_random_bytes. It is preferentially backed by gnutls or > > gcrypt, but

Re: [Qemu-devel] Seccomp profile for swtpm as default

2019-03-14 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 03:43:13PM -0400, Stefan Berger wrote: > Hello! > >  If you have some feedback regarding a seccomp profile extension for swtpm > for v0.2, please let me know. I created this github issue here: > > > https://github.com/stefanberger/swtpm/issues/115 > > > Basically the ch

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Daniel P . Berrangé
On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote: > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > Since we now support the message VHOST_USER_GET_INFLIGHT_FD > > and VHOST_USER_SET_INFLIGHT_FD. The backend is able to restart > >

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 07:34:03AM -0400, Michael S. Tsirkin wrote: > On Thu, Mar 14, 2019 at 11:24:22AM +0000, Daniel P. Berrangé wrote: > > On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote: > > > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com w

Re: [Qemu-devel] why does our coverity-model.c g_strdup() say it is a size-sink?

2019-03-14 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 12:16:06PM +, Peter Maydell wrote: > On Thu, 14 Mar 2019 at 11:23, Paolo Bonzini wrote: > > > > On 14/03/19 11:51, Peter Maydell wrote: > > > Our coverity model of g_strdup() includes: > > > __coverity_string_size_sink__(s); > > > > > > This seems to be causing Coveri

[Qemu-devel] [PATCH 1/2] tests: refactor file monitor test to make it more understandable

2019-03-14 Thread Daniel P . Berrangé
giant operation sequence that validates all scenarios in a single test. Signed-off-by: Daniel P. Berrangé --- tests/test-util-filemonitor.c | 534 +- 1 file changed, 208 insertions(+), 326 deletions(-) diff --git a/tests/test-util-filemonitor.c b/tests/test-util

[Qemu-devel] [PATCH 0/2] filemonitor: fix watch ID allocation for directories

2019-03-14 Thread Daniel P . Berrangé
This fixes an problem with watch ID allocation identified by the USB MTP device usage of watches on subdirectories. Daniel P. Berrangé (2): tests: refactor file monitor test to make it more understandable filemon: ensure watch IDs are unique to QFileMonitor scope tests/test-util

[Qemu-devel] [PATCH 2/2] filemon: ensure watch IDs are unique to QFileMonitor scope

2019-03-14 Thread Daniel P . Berrangé
The watch IDs are mistakenly only unique within the scope of the directory being monitored. This is not useful for clients which are monitoring multiple directories. They require watch IDs to be unique globally within the QFileMonitor scope. Signed-off-by: Daniel P. Berrangé --- tests/test-util

Re: [Qemu-devel] [PATCH v2 02/14] crypto: Reverse code blocks in random-platform.c

2019-03-14 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 09:55:14PM -0700, Richard Henderson wrote: > Use #ifdef _WIN32 instead of #ifndef _WIN32. > This will make other tests easier to sequence. > > Cc: Daniel P. Berrangé > Signed-off-by: Richard Henderson > --- > crypto/r

Re: [Qemu-devel] [PATCH v2 03/14] crypto: Do not fail for EINTR during qcrypto_random_bytes

2019-03-14 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 09:55:15PM -0700, Richard Henderson wrote: > We can always get EINTR for read; /dev/urandom is no exception. > Clean up return paths and avoid unnecessary goto. > > Cc: Daniel P. Berrangé > Signed-off-by: Richard Henderson > --- > crypto/r

Re: [Qemu-devel] [PATCH v2 04/14] crypto: Use O_CLOEXEC in qcrypto_random_init

2019-03-14 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 09:55:16PM -0700, Richard Henderson wrote: > Avoids leaking the /dev/urandom fd into any child processes. > > Cc: Daniel P. Berrangé > Signed-off-by: Richard Henderson > --- > crypto/random-platform.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 d

Re: [Qemu-devel] [PATCH v2 05/14] crypto: Use getrandom for qcrypto_random_bytes

2019-03-14 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 09:55:17PM -0700, Richard Henderson wrote: > Prefer it to direct use of /dev/urandom. > > Cc: Daniel P. Berrangé > Signed-off-by: Richard Henderson > --- > crypto/random-platform.c | 21 + > configure| 18

Re: [Qemu-devel] [PATCH v2 07/14] ui/vnc: Use qcrypto_random_bytes for make_challenge

2019-03-14 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 09:55:19PM -0700, Richard Henderson wrote: > Use a better interface for random numbers than rand, > plus some useless floating point arithmetic. > > Cc: Gerd Hoffmann > Signed-off-by: Richard Henderson > --- > v2: Use qcrypto_random_bytes, not qemu_getrandom, as there is

Re: [Qemu-devel] [PATCH v2 06/14] crypto: Change the qcrypto_random_bytes buffer type to void*

2019-03-14 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 09:55:18PM -0700, Richard Henderson wrote: > Using uint8_t* merely requires useless casts for use with > other types to be filled with randomness. > > Cc: Daniel P. Berrangé > Signed-off-by: Richard Henderson > --- > include/crypto/random.h |

Re: [Qemu-devel] [PATCH v2 08/14] util: Add qemu_getrandom and support functions

2019-03-14 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 09:55:20PM -0700, Richard Henderson wrote: > Initialize the system from system and linux-user arguments. > Propagate deterministic seeds when creating new cpu threads. > > Signed-off-by: Richard Henderson > --- > include/qemu/random.h | 58

Re: [Qemu-devel] [PATCH v2 04/14] crypto: Use O_CLOEXEC in qcrypto_random_init

2019-03-14 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 10:43:11AM -0500, Eric Blake wrote: > On 3/14/19 10:34 AM, Daniel P. Berrangé wrote: > > On Wed, Mar 13, 2019 at 09:55:16PM -0700, Richard Henderson wrote: > >> Avoids leaking the /dev/urandom fd into any child processes. > >> > >> Cc: Da

Re: [Qemu-devel] [PATCH v2 01/14] crypto: Merge crypto-obj-y into libqemuutil.a

2019-03-14 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 09:55:13PM -0700, Richard Henderson wrote: > We will shortly need this in the user-only binaries, so drop the split > into system and tools binaries. This also means that crypto-aes-obj-y > can be merged back into crypto-obj-y. > > Cc: Daniel P. Berrangé

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-14 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 03:57:06PM +, Alex Bennée wrote: > Docker Images > = > > The addition of docker has unlocked the ability to build a lot more > tests as well as compile testing on a much wider range of distros. I > think there are two outstanding areas that need improvement

Re: [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG

2019-03-14 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 09:06:42AM -0700, Richard Henderson wrote: > On 3/14/19 2:54 AM, Daniel P. Berrangé wrote: > > The random interfact is pluggable with different impls though they are > > chosen at build time currently. I guess we could provide an impl that > > is back

Re: [Qemu-devel] [PATCH v2 08/14] util: Add qemu_getrandom and support functions

2019-03-14 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 09:15:39AM -0700, Richard Henderson wrote: > On 3/14/19 8:57 AM, Daniel P. Berrangé wrote: > >> tions.hx > >> +++ b/qemu-options.hx > >> @@ -3601,6 +3601,16 @@ the 0x200 sized block starting at > >> 0xffc8 and anoth

Re: [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG

2019-03-14 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 09:23:12AM -0700, Richard Henderson wrote: > On 3/14/19 9:15 AM, Daniel P. Berrangé wrote: > > So far best alternative is 'qemu_traceable_random' / tracable-random.h > > but its a bit of a verbose name. > > How about qemu_guest_getrandom / g

Re: [Qemu-devel] [PATCH v2 08/14] util: Add qemu_getrandom and support functions

2019-03-14 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 09:18:09AM -0700, Richard Henderson wrote: > On 3/14/19 8:57 AM, Daniel P. Berrangé wrote: > >> @@ -2070,6 +2078,7 @@ void qemu_init_vcpu(CPUState *cpu) > >> cpu->nr_cores = smp_cores; > >> cpu->nr_threads = smp_th

Re: [Qemu-devel] [PATCH v2 01/14] crypto: Merge crypto-obj-y into libqemuutil.a

2019-03-14 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 10:54:49AM -0700, Richard Henderson wrote: > On 3/14/19 8:43 AM, Daniel P. Berrangé wrote: > > I think this needs to replace test-crypto-obj-y with test-util-obj-y > > in tests/Makefile.include too > > test-crypto-obj-y = $(authz-obj-y) $(crypto-ob

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-15 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 03:31:47PM +0300, Yury Kotov wrote: > Hi, > > 14.03.2019, 14:44, "Daniel P. Berrangé" : > > On Thu, Mar 14, 2019 at 07:34:03AM -0400, Michael S. Tsirkin wrote: > >>  On Thu, Mar 14, 2019 at 11:24:22AM +, Daniel P. Berrangé wrote: >

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-15 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 06:22:44PM +, Peter Maydell wrote: > On Thu, 14 Mar 2019 at 15:57, Alex Bennée wrote: > > Testing in the Cloud > > > > > > After BuildBot went out-of-service we have been relying heavily on Travis > > as our primary CI platform. This has been creaki

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-15 Thread Daniel P . Berrangé
On Fri, Mar 15, 2019 at 09:34:27AM +, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Thu, Mar 14, 2019 at 03:57:06PM +, Alex Bennée wrote: > >> Docker Images > >> = > >> > >> The addition of docker has unlocked

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-03-15 Thread Daniel P . Berrangé
On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote: > > On 1/18/19 3:39 AM, Erik Skultety wrote: > > I proceeded with cloning [1] to systemd and creating an udev rule that I > > planned > > on submitting to systemd upstream - the initial idea was to mimic /dev/kvm > > and > > make it

Re: [Qemu-devel] [PATCH v2 09/12] pc-bios: document the edk2 firmware images; add firmware descriptors

2019-03-15 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 10:00:54PM +0100, Laszlo Ersek wrote: > Update the README file with information on the images added previously, > and provide firmware descriptor documents that conform to > "docs/interop/firmware.json". > > Signed-off-by: Laszlo Ersek > Reviewed-by: Michal Privoznik > Re

Re: RFC: Why dont we move to newer capstone?

2019-10-15 Thread Daniel P . Berrangé
On Sat, Oct 05, 2019 at 02:33:34PM +0100, Peter Maydell wrote: > On Sat, 5 Oct 2019 at 11:21, Lucien Murray-Pitts > wrote: > > Whilst working on a m68k patch I noticed that the capstone in use > > today (3.0) doesnt support the M68K and thus a hand turned disasm > > function is used. > > > > The n

Re: RFC: Why dont we move to newer capstone?

2019-10-15 Thread Daniel P . Berrangé
On Tue, Oct 15, 2019 at 10:36:40AM +0200, Thomas Huth wrote: > On 15/10/2019 10.27, Daniel P. Berrangé wrote: > > On Sat, Oct 05, 2019 at 02:33:34PM +0100, Peter Maydell wrote: > >> On Sat, 5 Oct 2019 at 11:21, Lucien Murray-Pitts > >> wrote: > >>> Whilst

Re: RFC: Why dont we move to newer capstone?

2019-10-15 Thread Daniel P . Berrangé
On Tue, Oct 15, 2019 at 11:02:43AM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Oct 15, 2019 at 10:48 AM Daniel P. Berrangé > wrote: > > > > On Tue, Oct 15, 2019 at 10:36:40AM +0200, Thomas Huth wrote: > > > On 15/10/2019 10.27, Daniel P. Berrangé wrote: &

Re: RFC: Why dont we move to newer capstone?

2019-10-15 Thread Daniel P . Berrangé
On Tue, Oct 15, 2019 at 10:57:44AM +0100, Peter Maydell wrote: > On Tue, 15 Oct 2019 at 10:14, Daniel P. Berrangé wrote: > > > > On Tue, Oct 15, 2019 at 11:02:43AM +0200, Marc-André Lureau wrote: > > > I suppose the same applies to dtc (1.4.2 required by qemu, but xenial

Re: TOPOEXT and CentOs 7 guests

2019-10-16 Thread Daniel P . Berrangé
On Wed, Oct 16, 2019 at 12:51:58PM +, Ani Sinha wrote: > Hi : > > I am looking at a patch where we disable TOPOEXT when -cpu host or -cpu max > is passed to qemu : > > if (cpu->max_features) { >    for (w = 0; w < FEATURE_WORDS; w++) { >      /* Override only features that weren't set explic

Re: [PATCH] configure: Require Python >= 3.5

2019-10-17 Thread Daniel P . Berrangé
On Wed, Oct 16, 2019 at 06:48:34PM -0400, John Snow wrote: > > > On 10/16/19 6:42 PM, Eduardo Habkost wrote: > > Python 3.5 is the oldest Python version available on our > > supported build platforms, and Python 2 end of life will be 3 > > weeks after the planned release date of QEMU 4.2.0. Drop

Re: [PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-17 Thread Daniel P . Berrangé
On Wed, Oct 16, 2019 at 12:12:40PM +0200, Sergio Lopez wrote: > Document the new microvm machine type. > > Signed-off-by: Sergio Lopez > Reviewed-by: Michael S. Tsirkin > --- > docs/microvm.rst | 98 > 1 file changed, 98 insertions(+) > create m

[PATCH 0/4] crypto: improve performance of ciphers in XTS mode

2019-10-17 Thread Daniel P . Berrangé
EMU's LUKS performance to be viable. Daniel P. Berrangé (4): tests: allow filtering crypto cipher benchmark tests tests: benchmark crypto with fixed data size, not time period crypto: add support for gcrypt's native XTS impl crypto: add support for nettle's native

[PATCH 1/4] tests: allow filtering crypto cipher benchmark tests

2019-10-17 Thread Daniel P . Berrangé
Add support for specifying a cipher mode and chunk size as argv to filter which combinations are benchmarked. For example to only benchmark XTS mode with 512 byte chunks: ./tests/benchmark-crypto-cipher xts 512 Signed-off-by: Daniel P. Berrangé --- tests/benchmark-crypto-cipher.c | 13

[PATCH 4/4] crypto: add support for nettle's native XTS impl

2019-10-17 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- configure | 18 ++ crypto/cipher-nettle.c | 18 ++ 2 files changed, 36 insertions(+) diff --git a/configure b/configure index 98edb0ff44..6650c72348 100755 --- a/configure +++ b/configure @@ -471,6 +471,

[PATCH 2/4] tests: benchmark crypto with fixed data size, not time period

2019-10-17 Thread Daniel P . Berrangé
16384 bytes 2748.52 MB/sec Dec chunk 16384 bytes 2653.76 MB/sec OK Enc chunk 65536 bytes 2814.08 MB/sec Dec chunk 65536 bytes 2712.74 MB/sec OK The actual crypto performance hasn't changed, which shows how significant the mis-measurement has been for small data sizes. Signed-off-by: Dan

[PATCH 3/4] crypto: add support for gcrypt's native XTS impl

2019-10-17 Thread Daniel P . Berrangé
B/sec. Signed-off-by: Daniel P. Berrangé --- configure | 22 ++ crypto/Makefile.objs | 2 +- crypto/cipher-gcrypt.c | 36 +++- tests/Makefile.include | 2 +- 4 files changed, 59 insertions(+), 3 deletions(-) diff --git a/config

Re: [Qemu-devel] [PATCH v2 3/4] trace: forbid use of %m in trace event format strings

2019-10-18 Thread Daniel P . Berrangé
On Fri, Oct 18, 2019 at 11:31:15AM +0200, Thomas Huth wrote: > On 22/01/2019 19.10, Eric Blake wrote: > > On 1/22/19 11:23 AM, Daniel P. Berrangé wrote: > > > >> > >>>> On this point though, does anyone know of any platforms we support[1], > >

Re: [PATCH] Do not use %m in common code to print error messages

2019-10-18 Thread Daniel P . Berrangé
On Fri, Oct 18, 2019 at 12:44:38PM +0200, Thomas Huth wrote: > The %m format specifier is an extension from glibc - and when compiling > QEMU for NetBSD, the compiler correctly complains, e.g.: > > /home/qemu/qemu-test.ELjfrQ/src/util/main-loop.c: In function 'sigfd_handler': > /home/qemu/qemu-tes

Re: [PATCH] Do not use %m in common code to print error messages

2019-10-18 Thread Daniel P . Berrangé
On Fri, Oct 18, 2019 at 01:31:34PM +0200, Thomas Huth wrote: > On 18/10/2019 12.57, Daniel P. Berrangé wrote: > > On Fri, Oct 18, 2019 at 12:44:38PM +0200, Thomas Huth wrote: > >> The %m format specifier is an extension from glibc - and when compiling > >> QEMU for Net

Re: [PATCH v2] Do not use %m in common code to print error messages

2019-10-18 Thread Daniel P . Berrangé
s > > hw/misc/tmp421.c | 4 ++-- > util/main-loop.c | 3 ++- > util/systemd.c | 4 ++-- > 3 files changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https

Re: [PATCH] tcg/LICENSE: Remove no-longer-true statement that TCG is BSD-licensed

2019-10-21 Thread Daniel P . Berrangé
On Mon, Oct 21, 2019 at 05:36:49PM +0100, Peter Maydell wrote: > On Mon, 21 Oct 2019 at 15:58, Peter Maydell wrote: > > Since 2008 the tcg/LICENSE file has not changed: it claims that > > everything under tcg/ is BSD-licensed. > > > > This is not true and hasn't been true for years: in 2013 we > >

Re: [PATCH] qemu-doc: Clarify extent of build platform support

2020-02-13 Thread Daniel P . Berrangé
gt; qemu-doc.texi | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé > > diff --git a/qemu-doc.texi b/qemu-doc.texi > index a1ef6b6484..33b9597b1d 100644 > --- a/qemu-doc.texi > +++ b/qemu-doc.texi > @@ -2880,10 +2880,11 @@ l

Re: [RFC 2/2] pci-expender-bus:Add pcie-root-port to pxb-pcie under arm.

2020-02-13 Thread Daniel P . Berrangé
On Thu, Feb 13, 2020 at 03:49:52PM +0800, Yubo Miao wrote: > From: miaoyubo > > Since devices could not directly plugged into pxb-pcie, under arm, one > pcie-root port is plugged into pxb-pcie. Due to the bus for each pxb-pcie > is defined as 2 in acpi dsdt tables(one for pxb-pcie, one for pcie-r

Re: [PATCH] qcow2: Fix alignment checks in encrypted images

2020-02-13 Thread Daniel P . Berrangé
eads.c | 12 > block/qcow2.c | 2 -- > 2 files changed, 8 insertions(+), 6 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [RFC 2/2] pci-expender-bus:Add pcie-root-port to pxb-pcie under arm.

2020-02-14 Thread Daniel P . Berrangé
On Fri, Feb 14, 2020 at 07:25:43AM +, miaoyubo wrote: > > > -Original Message- > > From: Daniel P. Berrangé [mailto:berra...@redhat.com] > > Sent: Thursday, February 13, 2020 9:52 PM > > To: miaoyubo > > Cc: peter.mayd...@linaro.org; shannon.zha...@g

<    4   5   6   7   8   9   10   11   12   13   >