On Mon, Mar 04, 2024 at 02:49:28PM +, Peter Maydell wrote:
> On Mon, 4 Mar 2024 at 14:46, Daniel P. Berrangé wrote:
> >
> > The 13.2 images have been deleted from gcloud
> >
> > Signed-off-by: Daniel P. Berrangé
> > ---
> > .gitlab-ci.d/cirrus.yml
On Mon, Mar 04, 2024 at 06:11:58PM +0100, Thomas Huth wrote:
> On 04/03/2024 17.56, Peter Maydell wrote:
> > On Mon, 4 Mar 2024 at 13:04, Thomas Huth wrote:
> > >
> > > The macOS jobs in our CI recently started failing, complaining that
> > > the distutils module is not available anymore. And ind
On Mon, Mar 04, 2024 at 05:15:05PM -0300, Fabiano Rosas wrote:
> Peter Xu writes:
>
> > On Mon, Mar 04, 2024 at 08:53:24PM +0800, Peter Xu wrote:
> >> On Mon, Mar 04, 2024 at 12:42:25PM +0000, Daniel P. Berrangé wrote:
> >> > On Mon, Mar 04, 2024 at
.xz. Downstream distributions
> mostly use .xz too.
>
> For the release maintenance providing two formats is definitely
> extra burden too.
>
> Signed-off-by: Michael Tokarev
> ---
> scripts/make-release | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Review
+- if: '$CI_PROJECT_NAMESPACE == $QEMU_CI_UPSTREAM && $CI_PIPELINE_SOURCE
> == "schedule" && $CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH'
> + when: on_success
> +- if: '$CI_PROJECT_NAMESPACE == $QEMU_CI_UPSTREAM'
> + when: n
ko
> Philippe Mathieu-Daudé
NB mailmap translations - the commit was phi...@redhat.com originally
> Markus Armbruster
> Eduardo Habkost
On behalf of Red Hat, I can confirm that any contributions to
this file where Red Hat would hold copyright are acceptable
to relicense to GPL-v2-
On Wed, Oct 04, 2023 at 04:34:10PM -0400, Tyler Fanelli wrote:
> The Rust sev library provides a C API for the AMD SEV launch ioctls, as
> well as the ability to build with meson. Add the Rust sev library as a
> QEMU subproject with the goal of outsourcing all SEV launch ioctls to C
> APIs provided
On Tue, Mar 05, 2024 at 02:25:09PM +0100, Anthony Harivel wrote:
> Daniel P. Berrangé, Mar 04, 2024 at 15:48:
> > On Mon, Mar 04, 2024 at 03:41:02PM +0100, Anthony Harivel wrote:
> > >
> > > Hi Daniel,
> > >
> > > > > +if (s->msr_ene
On Tue, Feb 06, 2024 at 02:47:34PM +0100, Tim Wiederhake wrote:
> Synchronizing the list of cpu features and models with qemu is a recurring
> task in libvirt. For x86, this is done by reading qom-list-properties for
> max-x86_64-cpu and manually filtering out everthing that does not look like
> a
On Tue, Mar 05, 2024 at 04:09:08PM +, Jonathan Cameron via wrote:
> On Mon, 4 Mar 2024 11:34:08 -0800
> nifan@gmail.com wrote:
>
> > From: Fan Ni
> >
> > With the change, we add the following two QMP interfaces to print out
> > extents information in the device,
> > 1. cxl-display-accep
On Tue, Mar 05, 2024 at 09:09:05AM -0800, fan wrote:
> On Tue, Mar 05, 2024 at 04:15:30PM +0000, Daniel P. Berrangé wrote:
> > On Tue, Mar 05, 2024 at 04:09:08PM +, Jonathan Cameron via wrote:
> > > On Mon, 4 Mar 2024 11:34:08 -0800
> > > nifan@gmail.com wrote:
gt; device");
> - return -1;
> -}
> if (qemu_close(fioc->fd) < 0) {
> error_setg_errno(errp, errno,
> "Unable to close file");
Upto here:
Reviewed-by: Daniel P. Berrangé
> diff --git a/migration/multi
On Fri, Mar 01, 2024 at 07:28:53PM +0200, Andrey Drobyshev wrote:
> When executing guest commands in *nix environment, we repeat the same
> fork/exec pattern multiple times. Let's just separate it into a single
> helper which would also be able to feed input data into the launched
> process' stdin
On Fri, Mar 01, 2024 at 07:28:57PM +0200, Andrey Drobyshev wrote:
> We replace the direct call to open() with a "sh -c 'echo ...'" call, so
> that it becomes an executable command.
Introduced an indirection via the shell is a significant step
backwards IMHO.
>
> Signed-off-by: Andrey Drobyshev
On Fri, Mar 01, 2024 at 07:28:58PM +0200, Andrey Drobyshev wrote:
> There's no need to check for the existence of the "chpasswd", "pw"
> executables, as the exec() call will do that for us.
>
> Signed-off-by: Andrey Drobyshev
> ---
> qga/commands-posix.c | 96 ++--
On Wed, Mar 06, 2024 at 08:52:41AM +0800, Peter Xu wrote:
> On Tue, Mar 05, 2024 at 05:49:33PM +0000, Daniel P. Berrangé wrote:
> > I don't think you should be removing this. Calling qio_channel_close()
> > remains recommended best practice, even with fdatasync() removed,
On Wed, Mar 06, 2024 at 02:33:05PM +, Chun Feng Wu wrote:
> Thanks Daniel for your response!
>
> I tried it with the following cmd
>
> qemu-system-x86_64 [other options...] \
> -object
> '{"qom-type":"throttle-group","id":"limits0","limits":{"iops-total":200}}'
>
> And I got error:
> qemu
On Wed, Mar 06, 2024 at 02:36:08PM +, Daniel P. Berrangé wrote:
> On Wed, Mar 06, 2024 at 02:33:05PM +, Chun Feng Wu wrote:
> > Thanks Daniel for your response!
> >
> > I tried it with the following cmd
> >
> > qemu-system-x86_64 [other options...]
On Tue, Jan 30, 2024 at 03:48:38PM -0800, dongwon@intel.com wrote:
> From: Dongwon Kim
>
> A new flag "visible" is added to show visibility status of the gfx console.
> The flag is set to 'true' when the VC is visible but set to 'false' when
> it is hidden or closed. When the VC is invisible,
On Thu, Feb 01, 2024 at 06:48:58PM +, Kim, Dongwon wrote:
> Hi Marc-André,
>
> Thanks for your feedback. Yes, you are right, rendering doesn't stop on
> Ubuntu system
> as it has preview even after the window is minimized. But this is not always
> the case.
> Some simple windows managers don
On Wed, Jan 31, 2024 at 11:12:57AM +0400, Marc-André Lureau wrote:
> Hi
>
> On Wed, Jan 31, 2024 at 3:50 AM wrote:
> >
> > From: Dongwon Kim
> >
> > UI size is set to 0 when the VC is invisible, which will prevent
> > the further scanout update by notifying the guest that the display
> > is not
On Tue, Mar 05, 2024 at 04:18:18PM +0400, Marc-André Lureau wrote:
> Hi Kim
>
> I am uncomfortable with the series in general.
>
> Not only we don't have the means to draw dmabuf/scanout "when
> required", so resuming drawing won't work until the guest draws (this
> is already a problem but you a
On Wed, Mar 06, 2024 at 10:28:22PM -0800, Justinien Bouron wrote:
> Depending on your use-case, it might be inconvenient to have qemu grab
> the input device immediately upon starting the guest, especially if the
> guest takes a while to start in which case it may take a few seconds
> before being
On Thu, Mar 07, 2024 at 05:53:24PM +, Kim, Dongwon wrote:
> Hi Daniel,
>
> > -Original Message-
> > From: Daniel P. Berrangé
> > Sent: Thursday, March 7, 2024 1:46 AM
> > To: Kim, Dongwon
> > Cc: Marc-André Lureau ; qemu-
> > de...@nong
os.)
The macros were intended to simplify QOM boilerplate. So given that
they're not currently addressing a common use case of no-Class objects,
it makes sense to extend the macros as you suggest here.
> docs/devel/qom.rst | 34 +++--
> include/qom/object.h | 114 +
Ping: Stefan, are you OK with picking up these trace patches
for merge ?
On Mon, Jan 08, 2024 at 05:13:54PM +, Daniel P. Berrangé wrote:
> Currently we're only generating .stp definitions for the system and
> user emulators forgetting all about the tools which support tr
On Sat, Feb 17, 2024 at 09:21:50AM -1000, Richard Henderson wrote:
> On 2/16/24 23:49, Alexander Monakov wrote:
> >
> > On Fri, 16 Feb 2024, Richard Henderson wrote:
> >
> > > Benchmark each acceleration function vs an aligned buffer of zeros.
> > >
> > > Signed-off-by: Richard Henderson
> > >
On Mon, Feb 19, 2024 at 01:34:37PM +0100, Markus Armbruster wrote:
> Xiaoyao Li writes:
>
> > Introduce tdx-guest object which implements the interface of
> > CONFIDENTIAL_GUEST_SUPPORT, and will be used to create TDX VMs (TDs) by
> >
> > qemu -machine ...,confidential-guest-support=tdx0 \
> >
On Mon, Feb 19, 2024 at 01:50:12PM +0100, Markus Armbruster wrote:
> Xiaoyao Li writes:
>
> > From: Isaku Yamahata
> >
> > Add property "quote-generation-socket" to tdx-guest, which is a property
> > of type SocketAddress to specify Quote Generation Service(QGS).
> >
> > On request of GetQuote,
On Mon, Feb 19, 2024 at 03:49:30PM +0100, Markus Armbruster wrote:
> One more thing...
>
> Markus Armbruster writes:
>
> > yong.hu...@smartx.com writes:
> >
> >> From: Hyman Huang
> >>
> >> Firstly, enable the ability to choose the block device containing
> >> a detachable LUKS header by adding
On Mon, Feb 19, 2024 at 02:57:13PM +, Daniel P. Berrangé wrote:
> On Mon, Feb 19, 2024 at 03:49:30PM +0100, Markus Armbruster wrote:
> > One more thing...
> >
> > Markus Armbruster writes:
> >
> > > yong.hu...@smartx.com writes:
> > >
> >
> ---
> tests/qemu-iotests/198.out | 2 ++
> tests/qemu-iotests/206.out | 1 +
> 2 files changed, 3 insertions(+)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org
On Mon, Feb 19, 2024 at 03:37:31PM +, Peter Maydell wrote:
> Our msys2 32-bit Windows host CI job has been failing recently
> because upstream MSYS2 are starting to phase out 32-bit windows
> host support and are steadily removing i686 versions of packages.
> The latest is dtc:
> https://gitlab
On Mon, Feb 19, 2024 at 04:40:38PM +, Peter Maydell wrote:
> On Mon, 19 Feb 2024 at 16:26, Thomas Huth wrote:
> >
> > On 19/02/2024 16.53, Daniel P. Berrangé wrote:
> > > On Mon, Feb 19, 2024 at 03:37:31PM +, Peter Maydell wrote:
> > >> Our msys2
On Tue, Feb 20, 2024 at 03:00:56PM +0100, Anthony Harivel wrote:
> Daniel P. Berrangé, Jan 29, 2024 at 20:29:
> > On Thu, Jan 25, 2024 at 08:22:14AM +0100, Anthony Harivel wrote:
> > > diff --git a/docs/specs/rapl-msr.rst b/docs/specs/rapl-msr.rst
> > > new f
build | 10 ++
> 2 files changed, 15 insertions(+), 16 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|
chema/doc-duplicate-features.out | 22 +++
> tests/qapi-schema/meson.build | 1 +
> 4 files changed, 34 insertions(+)
> create mode 100644 tests/qapi-schema/doc-duplicate-features.err
> create mode 100644 tests/qapi-schema/doc-duplicate-features.jso
ed, 30 insertions(+)
> create mode 100644 tests/qapi-schema/doc-empty-features.err
> create mode 100644 tests/qapi-schema/doc-empty-features.json
> create mode 100644 tests/qapi-schema/doc-empty-features.out
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://be
> code to generate documentation for implicitly defined union branch
> types. It does nothing for 'q_empty'. Simplify.
>
> Signed-off-by: Markus Armbruster
> ---
> docs/sphinx/qapidoc.py | 18 +++---
> 1 file changed, 7 insertions(+), 11 deletions(-)
Revie
| 2 +-
> tests/qapi-schema/doc-bad-event-arg.err | 2 +-
> tests/qapi-schema/doc-bad-feature.err | 2 +-
> tests/qapi-schema/doc-bad-union-member.err | 2 +-
> 8 files changed, 10 insertions(+), 8 deletions(-)
Reviewed-by: Daniel P. Berrangé
With r
t; Signed-off-by: Markus Armbruster
> ---
> scripts/qapi/parser.py | 10 +++---
> tests/qapi-schema/doc-invalid-return.err | 2 +-
> 2 files changed, 8 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com
--
> docs/sphinx/qapidoc.py | 4 ++--
> scripts/qapi/parser.py | 14 +++---
> tests/qapi-schema/doc-empty-section.err | 2 +-
> 3 files changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
-
Markus Armbruster
> ---
> docs/sphinx/qapidoc.py | 6 +++---
> scripts/qapi/parser.py | 30 +++---
> tests/qapi-schema/test-qapi.py | 2 +-
> 3 files changed, 19 insertions(+), 19 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regard
13 insertions(+), 4 deletions(-)
> create mode 100644 tests/qapi-schema/doc-non-first-section.err
> create mode 100644 tests/qapi-schema/doc-non-first-section.json
> create mode 100644 tests/qapi-schema/doc-non-first-section.out
Reviewed-by: Daniel P. Berrangé
With regards,
D
since.json | 1 +
> tests/qapi-schema/doc-good.json | 9 +
> tests/qapi-schema/doc-invalid-return.err | 2 +-
> tests/qapi-schema/doc-invalid-return.json| 1 +
> 9 files changed, 32 insertions(+), 12 deletions(-)
Reviewed-by: Daniel P. Berrangé
> @@ -
> exceeds the recommended cpus supported by KVM (12)
> qemu-system-x86_64: -accel kvm: warning: Number of hotpluggable cpus
> requested (1728) exceeds the recommended cpus supported by KVM (12)
> Number of SMP cpus requested (1728) exceeds the maximum cpus supported by KVM
> (1024
t; tests/qapi-schema/doc-duplicated-return.err | 2 +-
> tests/qapi-schema/doc-duplicated-since.err | 2 +-
> tests/qapi-schema/doc-empty-arg.err | 2 +-
> 5 files changed, 32 insertions(+), 42 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|:
off-by: Markus Armbruster
> ---
> scripts/qapi/parser.py | 3 +++
> tests/qapi-schema/doc-empty-features.out | 2 --
> 2 files changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-ht
y: Markus Armbruster
> ---
> scripts/qapi/schema.py | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o
qapi/ui.json| 324 ++--
> qapi/virtio.json| 778 ++--
> qapi/yank.json | 24 +-
> scripts/qapi/parser.py | 3 +
> tests/qapi-schema/doc-good.json | 12 +-
> 28 files changed, 2
tests/qapi-schema/doc-duplicate-features.err | 1 +
> tests/qapi-schema/doc-duplicate-features.out | 22
> tests/qapi-schema/doc-empty-features.err | 1 +
> tests/qapi-schema/doc-empty-features.out | 17 ---
> 6 files changed, 9 insertions(+), 42 deletions(-)
Re
On Tue, Feb 20, 2024 at 05:16:37PM +0100, Gerd Hoffmann wrote:
> On Tue, Feb 20, 2024 at 03:50:57PM +0000, Daniel P. Berrangé wrote:
> > On Tue, Feb 20, 2024 at 09:12:04PM +0530, Ani Sinha wrote:
> > > Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to
On Tue, Feb 20, 2024 at 05:06:42PM +0100, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Fri, Feb 16, 2024 at 03:58:35PM +0100, Markus Armbruster wrote:
> >> Putting a blank line before section tags and 'Features:' is good,
> >> existing
rkus Armbruster
> ---
> scripts/qapi/parser.py | 478 ++---
> 1 file changed, 210 insertions(+), 268 deletions(-)
Reviewing parsing code typically gives me a headache, and reviewing
diffs of parsing code is even worse. Thus instead of R-b I'll gi
ss-win32-system job.
>
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Peter Maydell
> ---
> Minimal patch that disables CI, for ease of backporting.
> ---
> .gitlab-ci.d/windows.yml | 9 -
> 1 file changed, 9 deletions(-)
Reviewed-by: Daniel P. Berrangé
With reg
; 1 file changed, 75 insertions(+), 75 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
ns(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
ot '%s'",
> optarg);
> }
Should we say '--repair/-r expects...' since we don't know which the
user passed
Either way
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
| 4 ++--
> qemu-img.c | 9 ++---
> 3 files changed, 9 insertions(+), 6 deletions(-)
With the fix you already mentioned for getopt:
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrang
On Sat, Feb 10, 2024 at 12:22:33AM +0300, Michael Tokarev wrote:
> also remove bdrv_oflags handling (only list can use RO mode)
> ---
> qemu-img.c | 13 -
> 1 file changed, 8 insertions(+), 5 deletions(-)
I'd suggest docs/tools/qemu-img.rst should also be updated to say
Lists all sn
On Sat, Feb 10, 2024 at 12:22:36AM +0300, Michael Tokarev wrote:
> 'qemu-img resize --help' does not work, since it wants more arguments.
> Only eat last option at the beginning if it starts like -N.., and allow
> getopt() to do its work, and eat it up at the end if not already eaten.
> This will n
On Tue, Feb 20, 2024 at 05:44:10PM +, Peter Maydell wrote:
> ---
> docs/about/build-platforms.rst | 2 ++
> docs/about/removed-features.rst | 15 +++
> 2 files changed, 17 insertions(+)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange
; .gitlab-ci.d/crossbuilds.yml | 14 ---
> .../dockerfiles/fedora-win32-cross.docker | 111 --
> tests/lcitool/refresh | 5 -
> 4 files changed, 135 deletions(-)
> delete mode 100644 tests/docker/dockerfiles/fedora-win32-cross.dock
On Tue, Feb 20, 2024 at 05:44:12PM +, Peter Maydell wrote:
> Now we don't build msys2-32bit we don't need the abstraction out of the
> common msys2 handling from the 32-vs-64-bit specifics. Collapse it
> down into the msys2-64bit job definition.
>
> Signed-off-by: Peter Maydell
> ---
> .gitl
bit Windows isn't supported.
>
> Fix a grammar nit in the page while we're here.
>
> Signed-off-by: Peter Maydell
> ---
> _download/windows.md | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
On Sat, Feb 10, 2024 at 12:22:23AM +0300, Michael Tokarev wrote:
> Add missing long options (eg --format).
>
> Create helper function cmd_help() to display command-specific
> help text, and use it to print --help for 'create' subcommand.
>
> Signed-off-by: Michael Tokarev
> ---
> qemu-img.c | 4
On Sat, Feb 10, 2024 at 12:22:43AM +0300, Michael Tokarev wrote:
> now once all individual subcommands has --help support, remove
> the large unreadable help() thing and replace it with small
> global --help, which refers to individual command --help for
> more info.
>
> While at it, also line-wra
On Sat, Feb 10, 2024 at 12:22:44AM +0300, Michael Tokarev wrote:
> also add short description to each command and use it in --help
>
> Signed-off-by: Michael Tokarev
> ---
> qemu-img.c | 42 +++---
> 1 file changed, 35 insertions(+), 7 deletions(-)
>
> diff -
On Sat, Feb 10, 2024 at 12:22:21AM +0300, Michael Tokarev wrote:
> Quite big patchset implementing normal, readable qemu-img --help
> (and qemu-img COMMAND --help) output with readable descriptions,
> and adding many long options in the process.
>
> In the end I stopped using qemu-img-opts.hx in q
On Tue, Feb 20, 2024 at 07:46:37PM +0100, Philippe Mathieu-Daudé wrote:
> On 20/2/24 18:44, Peter Maydell wrote:
> > We don't support 32-bit Windows any more, so we don't need to defend it
> > with this CI job.
> >
> > Signed-off-by: Peter Maydell
> > ---
> > .gitlab-ci.d/container-cross.yml
On Tue, Feb 20, 2024 at 10:02:32PM +0300, Michael Tokarev wrote:
> 20.02.2024 21:48, Daniel P. Berrangé:
> ...
> > $ ./build/qemu-img check --help
> > Check basic image integrity.
> >
> > Usage:
> >
> >qemu-img check [-f FMT | --image-opts] [-T CA
; 2 files changed, 9 insertions(+)
Reviewed-by: Daniel P. Berrangé
>
> diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
> index 071f7ca253..1aec9d5836 100644
> --- a/linux-user/ioctls.h
> +++ b/linux-user/ioctls.h
> @@ -134,6 +134,12 @@
> IOCTL(FICLONE, IOC_W, T
On Wed, Feb 21, 2024 at 02:19:11PM +0100, Anthony Harivel wrote:
> Daniel P. Berrangé, Jan 29, 2024 at 20:45:
> > On Mon, Jan 29, 2024 at 08:33:21PM +0100, Paolo Bonzini wrote:
> > > On Mon, Jan 29, 2024 at 7:53 PM Daniel P. Berrangé
> > > wrote:
> > > > &
On Wed, Feb 21, 2024 at 10:24:05AM -0300, Fabiano Rosas wrote:
> Markus Armbruster writes:
>
> > Fabiano Rosas writes:
> >
> >> Add a new migration capability 'fixed-ram'.
> >>
> >> The core of the feature is to ensure that each RAM page has a specific
> >> offset in the resulting migration stre
On Wed, Feb 21, 2024 at 07:31:42PM +0300, Michael Tokarev wrote:
> 20.02.2024 21:48, Daniel P. Berrangé:
>
> > This ends up looking a bit muddled together. I don't think we
> > need repeat 'qemu-img ' twice, and could add a little
> > more whitespace
>
owever, are 100% disposable so the upgrade
headaches don't exist. Thus we can undo the python defaults to allow
pip to work.
Signed-off-by: Daniel P. Berrangé
---
.gitlab-ci.d/cirrus/build.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
FYI lcitool recently added logic that purges th
Peter Maydell
> ---
> v2:
> - drop now-unused MINGW_TARGET variable
> - document why we need to set MSYSTEM
> - restore comment text truncated in commit 11961d08fcbddf
> ---
> .gitlab-ci.d/windows.yml | 85 +++-
> 1 file changed, 41 inse
On Wed, Jan 24, 2024 at 10:23:12PM -0500, Xiaoyao Li wrote:
> From: Isaku Yamahata
>
> Add property "quote-generation-socket" to tdx-guest, which is a property
> of type SocketAddress to specify Quote Generation Service(QGS).
>
> On request of GetQuote, it connects to the QGS socket, read reques
On Mon, Feb 26, 2024 at 10:48:14AM +0100, Philippe Mathieu-Daudé wrote:
> Hi,
>
> On 26/2/24 10:06, dinglimin wrote:
> > Signed-off-by: dinglimin
> > ---
> > semihosting/uaccess.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/semihosting/uaccess.c b/semi
rr already has
> all the info, no need to prepend additional text there.
>
> There are a few other places like this, but I'm unsure
> about these.
>
> Signed-off-by: Michael Tokarev
> ---
> qemu-img.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions
tring.
>
> Signed-off-by: Michael Tokarev
> ---
> qemu-img.c | 19 +++
> 1 file changed, 7 insertions(+), 12 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberra
is properly
> converted to unsigned), simplifying code.
>
> Signed-off-by: Michael Tokarev
> ---
> qemu-img.c | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https:
On Thu, Feb 22, 2024 at 12:15:45AM +0300, Michael Tokarev wrote:
> In order to correctly print executable name in various
> error messages, pass argv[0] to error_exit() function.
> This way, error messages will refer to actual executable
> name, which may be different from 'qemu-img'.
>
> For subc
On Thu, Feb 22, 2024 at 12:15:46AM +0300, Michael Tokarev wrote:
> This info will be used to generate --help output.
>
> Signed-off-by: Michael Tokarev
> ---
> qemu-img.c | 34 +-
> 1 file changed, 17 insertions(+), 17 deletions(-)
Rev
On Thu, Feb 22, 2024 at 12:15:47AM +0300, Michael Tokarev wrote:
> Create helper function cmd_help() to display command-specific
> help text, and use it to print --help for 'create' subcommand.
>
> Add missing long options (eg --format) in img_create().
>
> Remove usage of missing_argument()/unre
s(+), 35 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
e changed, 39 insertions(+), 133 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
On Thu, Feb 22, 2024 at 12:16:00AM +0300, Michael Tokarev wrote:
> 'qemu-img resize --help' does not work, since it wants more
> arguments. Also it -size is only recognized as a very last
> argument, but it is common for tools to handle other options
> after positional arguments too.
>
> Tell get
tions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
; variable. All these variables are okay to be signed, we never
> assign <0 value to them except of the cases of conversion error,
> where we return immediately.
>
> Signed-off-by: Michael Tokarev
> ---
> qemu-img.c | 118 ------
On Thu, Feb 22, 2024 at 12:15:45AM +0300, Michael Tokarev wrote:
> In order to correctly print executable name in various
> error messages, pass argv[0] to error_exit() function.
> This way, error messages will refer to actual executable
> name, which may be different from 'qemu-img'.
>
> For subc
On Sat, Jan 27, 2024 at 10:36:24PM +0800, Zhao Liu wrote:
> Hi Daniel,
>
> On Thu, Nov 23, 2023 at 11:40:25AM +0000, Daniel P. Berrangé wrote:
> > +Multiple authorship
> > +~~~
> > +
> > +It is not uncommon for a patch to have contributions from
On Mon, Jan 29, 2024 at 10:41:38AM +, Peter Maydell wrote:
> On Mon, 29 Jan 2024 at 09:47, Samuel Tardieu wrote:
> > However, this is not what QEMU has been using as far as I can see,
> > as S-o-b tend to stay in their original positions. I even opened
> > an issue on b4 a few weeks ago becaus
On Wed, Jan 24, 2024 at 10:22:35PM -0500, Xiaoyao Li wrote:
> Introduce a separate function kvm_confidential_guest_init(), which
> dispatches specific confidential guest initialization function by
> ms->cgs type.
>
> Signed-off-by: Xiaoyao Li
> Acked-by: Gerd Hoffmann
> Reviewed-by: Philippe Mat
On Thu, Jan 25, 2024 at 08:22:13AM +0100, Anthony Harivel wrote:
> Introduce a privileged helper to access RAPL MSR.
>
> The privileged helper tool, qemu-vmsr-helper, is designed to provide
> virtual machines with the ability to read specific RAPL (Running Average
> Power Limit) MSRs without requi
On Thu, Jan 25, 2024 at 08:22:14AM +0100, Anthony Harivel wrote:
> diff --git a/docs/specs/rapl-msr.rst b/docs/specs/rapl-msr.rst
> new file mode 100644
> index ..04d27c198fc0
> --- /dev/null
> +++ b/docs/specs/rapl-msr.rst
> @@ -0,0 +1,133 @@
> +
> +RAPL MSR support
> +
On Mon, Jan 29, 2024 at 08:25:29PM +0100, Paolo Bonzini wrote:
> On Thu, Jan 25, 2024 at 5:38 PM Daniel P. Berrangé
> wrote:
> > > +static void
> > > +qio_channel_socket_get_peerpid(QIOChannel *ioc,
> > > +
On Mon, Jan 29, 2024 at 08:33:21PM +0100, Paolo Bonzini wrote:
> On Mon, Jan 29, 2024 at 7:53 PM Daniel P. Berrangé
> wrote:
> > > diff --git a/meson.build b/meson.build
> > > index d0329966f1b4..93fc233b0891 100644
> > > --- a/meson.build
> > > +++ b/m
On Mon, Jan 29, 2024 at 07:45:51PM +, Daniel P. Berrangé wrote:
> On Mon, Jan 29, 2024 at 08:33:21PM +0100, Paolo Bonzini wrote:
> > On Mon, Jan 29, 2024 at 7:53 PM Daniel P. Berrangé
> > wrote:
> > > > diff --git a/meson.build b/meson.build
> > > >
On Tue, Jan 30, 2024 at 09:56:15AM +0200, Manos Pitsidianakis wrote:
> Check if a file argument is a cover letter patch produced by
> git-format-patch --cover-letter; It is initialized with subject suffix "
> *** SUBJECT HERE ***" and body prefix " *** BLURB HERE ***". If they
> exist, warn the use
301 - 400 of 12547 matches
Mail list logo
