[Qemu-devel] [PATCH] block.curl: adding 'curltimeout' option

2014-08-12 Thread Daniel Henrique Barboza
previous default timeout of 5 seconds will be used if this option is not present. Signed-off-by: Daniel Henrique Barboza --- block/curl.c| 13 - qemu-options.hx | 10 -- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/block/curl.c b/block/curl.c index

[Qemu-devel] [PATCH v2] block.curl: adding 'curltimeout' option

2014-08-12 Thread Daniel Henrique Barboza
previous default timeout of 5 seconds will be used if this option is not present. Signed-off-by: Daniel Henrique Barboza --- block/curl.c| 13 - qemu-options.hx | 10 -- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/block/curl.c b/block/curl.c index

[Qemu-devel] [PATCH v3] block.curl: adding 'timeout' option

2014-08-13 Thread Daniel Henrique Barboza
previous default timeout of 5 seconds will be used if this option is not present. Reviewed-by: Fam Zheng Signed-off-by: Daniel Henrique Barboza --- block/curl.c| 13 - qemu-options.hx | 10 -- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/block/curl.c b

[Qemu-devel] [PATCH v3] block.curl: timeout option

2014-08-13 Thread Daniel Henrique Barboza
Changes in v3: - changed option name from 'curltimeout' to 'timeout' Changes in v2: - remove double quote from the int value in qemu-options.hx Daniel Henrique Barboza (1): block.curl: adding 'timeout' option block/curl.c| 13 - qemu-optio

Re: [PATCH for-8.0 1/1] target/ppc: Use tcg_gen_atomic_cmpxchg_i128 for STQCX

2022-11-16 Thread Daniel Henrique Barboza
Richard, I believe the ppc64-linux-user target didn't like what you did in this patch. Here's the error: $ ../configure --target-list=ppc64-softmmu,ppc64-linux-user,ppc-softmmu,ppc-linux-user,ppc64le-linux-user $ make -j (...) [15/133] Compiling C object libqemu-ppc64-linux-user.fa.p/target_

Re: [PATCH for-8.0 1/1] target/ppc: Use tcg_gen_atomic_cmpxchg_i128 for STQCX

2022-11-17 Thread Daniel Henrique Barboza
On 11/16/22 23:48, Richard Henderson wrote: I think you missed the Based-on tag. r~ Duh. Sorry about that. Let me try it again. Daniel On Wed, 16 Nov 2022, 05:38 Daniel Henrique Barboza, mailto:danielhb...@gmail.com>> wrote: Richard, I believe the ppc64-linux-user

Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'

2022-11-17 Thread Daniel Henrique Barboza
Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags: Reported-by: Kowshik Jois B S Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops restore_state_to_opc") Fixes: 670f1da374 ("target/ppc: Implement hashst and hashchk") Resolves: https://gitlab.com/qemu-proj

Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'

2022-11-17 Thread Daniel Henrique Barboza
On 11/17/22 07:35, Vaibhav Jain wrote: Hi Daniel, Thanks for quick turnaround on this, Minor correction to the commit tags below: Daniel Henrique Barboza writes: Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags: Reported-by: Kowshik Jois B S Fixes

Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'

2022-11-17 Thread Daniel Henrique Barboza
On 11/17/22 07:50, Greg Kurz wrote: On Thu, 17 Nov 2022 07:11:51 -0300 Daniel Henrique Barboza wrote: Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags: You are planning a PR before 7.2-rc2, right ? I'll send it today. Reported-by: Kowshik Joi

[PULL 0/1] ppc queue

2022-11-17 Thread Daniel Henrique Barboza
The following changes since commit 2c8311241d1f7377bb4ff76064b1d1fe15166413: Update VERSION for v7.2.0-rc1 (2022-11-15 18:56:38 -0500) are available in the Git repository at: https://gitlab.com/danielhb/qemu.git tags/pull-ppc-20221117 for you to fetch changes up to 049b4ad66984aad278b3fc0a7

[PULL 1/1] target/ppc: Fix build warnings when building with 'disable-tcg'

2022-11-17 Thread Daniel Henrique Barboza
ed-by: Philippe Mathieu-Daudé Tested-by: Kowshik Jois B S Message-Id: <20221116131743.658708-1-vaib...@linux.ibm.com> Signed-off-by: Daniel Henrique Barboza --- target/ppc/cpu_init.c| 2 ++ target/ppc/excp_helper.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/target/ppc/cpu_init.c

[PATCH for-8.0] MAINTAINERS: downgrade PPC KVM/TCG CPUs and pSeries to 'Odd Fixes'

2022-11-17 Thread Daniel Henrique Barboza
ntainer no longer has exclusive time to dedicate to them. It'll also (hopefully) keep expectations under check when/if these components are used in a customer product. Cc: Cédric Le Goater Cc: David Gibson Cc: Greg Kurz Signed-off-by: Daniel Henrique Barboza --- MAINTAINERS | 6 +++--- 1

Re: [PATCH for-8.0 3/7] target/ppc: Use QEMU_IOTHREAD_LOCK_GUARD in ppc_maybe_interrupt

2022-11-18 Thread Daniel Henrique Barboza
On 11/18/22 06:18, Richard Henderson wrote: Signed-off-by: Richard Henderson --- Cc: qemu-...@nongnu.org --- Reviewed-by: Daniel Henrique Barboza target/ppc/excp_helper.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/target/ppc/excp_helper.c b

Re: [PATCH for-8.0 4/7] target/ppc: Use QEMU_IOTHREAD_LOCK_GUARD in cpu_interrupt_exittb

2022-11-18 Thread Daniel Henrique Barboza
s can be done. Reviewed-by: Daniel Henrique Barboza Cc: qemu-...@nongnu.org --- target/ppc/helper_regs.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/target/ppc/helper_regs.c b/target/ppc/helper_regs.c index c0aee5855b..779e7db513 100644 --- a/targe

Re: [PATCH for-8.0 6/7] hw/ppc: Use QEMU_IOTHREAD_LOCK_GUARD in ppc_set_irq

2022-11-18 Thread Daniel Henrique Barboza
On 11/18/22 06:18, Richard Henderson wrote: Signed-off-by: Richard Henderson --- Cc: qemu-...@nongnu.org --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index dc86c1c7db

Re: [PATCH for-8.0 1/1] target/ppc: Use tcg_gen_atomic_cmpxchg_i128 for STQCX

2022-11-21 Thread Daniel Henrique Barboza
val))); was incorrect because all references should have gone through cpu_reserve_val. Create a cpu_reserve_val2 tcg temp to fix this. Signed-off-by: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza Richard, since this depends on your int128 with helpers, do you want to queue this in

Re: [PATCH for-8.0] MAINTAINERS: downgrade PPC KVM/TCG CPUs and pSeries to 'Odd Fixes'

2022-11-21 Thread Daniel Henrique Barboza
Thanks everyone! Queued for 8.0. Daniel On 11/17/22 12:32, Daniel Henrique Barboza wrote: The maintainer is no longer being paid to maintain these components. All maintainership work is being done in his personal time since the middle of the 7.2 development cycle. Change the status of PPC

Re: [PATCH for-8.0 v3 34/45] tcg: Introduce tcg_target_call_oarg_reg

2022-11-22 Thread Daniel Henrique Barboza
On 11/11/22 04:40, Richard Henderson wrote: Replace the flat array tcg_target_call_oarg_regs[] with a function call including the TCGCallReturnKind. Signed-off-by: Richard Henderson --- For ppc and common code bits: Reviewed-by: Daniel Henrique Barboza tcg/tcg.c

Re: [PATCH for-8.0 v3 32/45] tcg: Introduce tcg_out_addi_ptr

2022-11-22 Thread Daniel Henrique Barboza
On 11/11/22 04:40, Richard Henderson wrote: Implement the function for arm, i386, and s390x, which will use it. Add stubs for all other backends. Signed-off-by: Richard Henderson --- For ppc and common code bits: Reviewed-by: Daniel Henrique Barboza tcg/tcg.c

Re: [PATCH for-8.0 v3 40/45] tcg: Add TCG_TARGET_CALL_{RET,ARG}_I128

2022-11-22 Thread Daniel Henrique Barboza
On 11/11/22 04:40, Richard Henderson wrote: Fill in the parameters for the host ABI for Int128 for those backends which require no extra modification. Signed-off-by: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza tcg/aarch64/tcg-target.h | 2 ++ tcg/arm/tcg-target.h

Re: [PATCH 1/2] target/ppc: Implement the DEXCR and HDEXCR

2022-11-28 Thread Daniel Henrique Barboza
On 11/24/22 02:51, Nicholas Miehlbradt wrote: Define the DEXCR and HDEXCR as special purpose registers. Each register occupies two SPR indicies, one which can be read in an unprivileged state and one which can be modified in the appropriate priviliged state, however both indicies refer to the

Re: [PATCH 2/2] target/ppc: Check DEXCR on hash{st, chk} instructions

2022-11-28 Thread Daniel Henrique Barboza
. Signed-off-by: Nicholas Miehlbradt --- LGTM Reviewed-by: Daniel Henrique Barboza target/ppc/excp_helper.c | 58 +--- 1 file changed, 43 insertions(+), 15 deletions(-) diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c index 94adcb766b

Re: [PATCH for-8.0 0/7] virtio, pci, xics: 3-phase reset conversions

2022-11-30 Thread Daniel Henrique Barboza
The last three deal with TYPE_PHB3_MSI and the parenT TYPE_ICS. This is all 8.0 material. Tested with the powern8 machine model that uses xics. Series: Tested-by: Daniel Henrique Barboza thanks -- PMM Peter Maydell (7): hw/virtio: Convert TYPE_VIRTIO_PCI to 3-phase reset hw/display/v

[PATCH for-7.2 03/10] hw/ppc: set machine->fdt in spapr machine

2022-07-22 Thread Daniel Henrique Barboza
es. Let's set machine->fdt in the two places where we manipulate the FDT: spapr_machine_reset() and CAS. spapr->fdt_blob is left untouched: what we want is a way to access the FDT from HMP, not replace spapr->fdt_blob. Cc: Cédric Le Goater Cc: qemu-...@nongnu.org Signed-off-by: Daniel H

[PATCH for-7.2 01/10] hw/arm/boot.c: do not free machine->fdt in arm_load_dtb()

2022-07-22 Thread Daniel Henrique Barboza
es allocates the FDT only once, we don't need to worry about leaking the existing FDT during a machine reset (which is something that other machines have to look after, e.g. the ppc64 pSeries machine). Cc: Peter Maydell Cc: qemu-...@nongnu.org Signed-off-by: Daniel Henrique Barboza --- hw/arm/bo

[PATCH for-7.2 08/10] device_node.c: enable 'info fdt' to print subnodes

2022-07-22 Thread Daniel Henrique Barboza
er0 { core0 { cpu = <0x8001> } } } } Signed-off-by: Daniel Henrique Barboza --- softmmu/device_tree.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/softmmu/device_tree.c b/softmmu/device_tree.

[PATCH for-7.2 05/10] hmp, device_tree.c: introduce 'info fdt' command

2022-07-22 Thread Daniel Henrique Barboza
linux,stdout-path; qemu,graphic-depth; qemu,graphic-height; qemu,graphic-width; } And the same node for the aarch64 'virt' machine: (qemu) info fdt /chosen chosen { stdout-path; rng-seed; kaslr-seed; } Cc: Dr. David Alan Gilbert Signed-off-by: Daniel

[PATCH for-7.2 06/10] device_tree.c: support printing of strings props

2022-07-22 Thread Daniel Henrique Barboza
' rng-seed; kaslr-seed; } Signed-off-by: Daniel Henrique Barboza --- softmmu/device_tree.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/softmmu/device_tree.c b/softmmu/device_tree.c index 899c239c5c..3c070acc0d 100644 --- a/softmmu/d

[PATCH for-7.2 04/10] hmp, device_tree.c: introduce fdt-save

2022-07-22 Thread Daniel Henrique Barboza
dumpdtb' that can be fired on demand via HMP. A valid FDT consists of a FDT that was created using libfdt being retrieved via 'current_machine->fdt' in device_tree.c. This condition is met by most FDT users in QEMU. Cc: Dr. David Alan Gilbert Signed-off-by: Daniel Henrique Bar

[PATCH for-7.2 02/10] hw/ppc/pegasos2.c: set machine->fdt in machine_reset()

2022-07-22 Thread Daniel Henrique Barboza
We'll introduce HMP commands that requires machine->fdt to be set properly. Cc: BALATON Zoltan Cc: qemu-...@nongnu.org Signed-off-by: Daniel Henrique Barboza --- hw/ppc/pegasos2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c index 61

[PATCH for-7.2 09/10] device_tree.c: add fdt_print_property() helper

2022-07-22 Thread Daniel Henrique Barboza
We want to be able to also print properties with 'info fdt'. Create a helper to print properties based on the already existing code from fdt_print_node(). Signed-off-by: Daniel Henrique Barboza --- softmmu/device_tree.c | 32 ++-- 1 file changed, 18

[PATCH for-7.2 07/10] device_tree.c: support remaining FDT prop types

2022-07-22 Thread Daniel Henrique Barboza
nly = <0x0> stdout-path = '/vdevice/vty@7100' linux,stdout-path = '/vdevice/vty@7100' qemu,graphic-depth = <0x20> qemu,graphic-height = <0x258> qemu,graphic-width = <0x320> } Signed-off-by: Daniel Henrique Barboza ---

[PATCH for-7.2 10/10] hmp, device_tree.c: add 'info fdt ' support

2022-07-22 Thread Daniel Henrique Barboza
-window /vdevice/v-scsi@7103/ibm,my-dma-window = <0x71000003 0x0 0x0 0x0 0x1000> (qemu) Cc: Dr. David Alan Gilbert Signed-off-by: Daniel Henrique Barboza --- hmp-commands-info.hx | 2 +- softmmu/device_tree.c | 79 --- 2 files changed,

[PATCH for-7.2 00/10] add hmp 'save-fdt' and 'info fdt' commands

2022-07-22 Thread Daniel Henrique Barboza
d the FDT must be reachable via MachineState->fdt. To meet the prerequisites for ARM machines, patch 1 makes a change in arm_load_dtb(). Patches 2 and 3 makes a similar change for two PowerPC machines that weren't using machine->fdt. Tests were done using the ARM machvirt machine and p

Re: [PATCH for-7.2 00/10] add hmp 'save-fdt' and 'info fdt' commands

2022-07-25 Thread Daniel Henrique Barboza
On 7/25/22 06:11, Daniel P. Berrangé wrote: On Fri, Jul 22, 2022 at 04:59:57PM -0300, Daniel Henrique Barboza wrote: Hi, After dealing with a FDT element that isn't being shown in the userspace and having to shutdown the guest, dump the FDT using 'machine -dumpdtb' and then

Re: [PATCH for-7.2 04/10] hmp, device_tree.c: introduce fdt-save

2022-07-25 Thread Daniel Henrique Barboza
On 7/22/22 20:13, BALATON Zoltan wrote: On Fri, 22 Jul 2022, Daniel Henrique Barboza wrote: To save the FDT blob we have the '-machine dumpdtb=' property. With this property set, the machine saves the FDT in and exit. The created file can then be converted to plain text dts fo

[PATCH v2 0/1] target/ppc: fix unreachable code in do_ldst_quad()

2022-07-25 Thread Daniel Henrique Barboza
changes from v1: - do not use ifdefs - returned to the code that was in placed before the macro - v1 link: https://lists.gnu.org/archive/html/qemu-devel/2022-07/msg03697.html Daniel Henrique Barboza (1): target/ppc: fix unreachable code in do_ldst_quad() target/ppc/translate/fixedpoint

[PATCH v2 1/1] target/ppc: fix unreachable code in do_ldst_quad()

2022-07-25 Thread Daniel Henrique Barboza
e ctx->pr condition and fire the exception if we're not privileged. The difference from the code back then to what we're doing now is an 'unlikely' compiler hint to ctx->pr and the use of gen_priv_opc() instead of gen_priv_exception(). Fixes: Coverity CID 1490757 Cc

Re: [PATCH v3] target/ppc: Implement new wait variants

2022-07-27 Thread Daniel Henrique Barboza
On 7/20/22 10:33, Nicholas Piggin wrote: ISA v2.06 adds new variations of wait, specified by the WC field. These are not all compatible with the prior wait implementation, because they add additional conditions that cause the processor to resume, which can cause software to hang or run very sl

Re: [RFC 1/2] hw/ppc/ppc440_uc: Initialize length passed to cpu_physical_memory_map()

2022-07-27 Thread Daniel Henrique Barboza
On 7/26/22 15:24, Peter Maydell wrote: On Tue, 26 Jul 2022 at 19:23, Peter Maydell wrote: In dcr_write_dma(), there is code that uses cpu_physical_memory_map() to implement a DMA transfer. That function takes a 'plen' argument, which points to a hwaddr which is used for both input and outp

Re: [PATCH v3 05/12] ppc/pnv: turn PnvPHB4 into a PnvPHB backend

2022-07-28 Thread Daniel Henrique Barboza
On 7/27/22 14:41, Frederic Barrat wrote: On 24/06/2022 10:49, Daniel Henrique Barboza wrote: diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 1df91971b8..b7273f386e 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -672,7 +672,14 @@ static void pnv_chip_power8_pic_print_info(PnvChip *chip

Re: [PATCH v3 00/12] powernv: introduce pnv-phb base/proxy devices

2022-07-28 Thread Daniel Henrique Barboza
On 7/27/22 14:28, Frederic Barrat wrote: On 24/06/2022 10:49, Daniel Henrique Barboza wrote: Hi, This is the version 3 of the pnv-phb proxy device which has the following main differences from v2: - it's rebased on top of "[PATCH v3 0/8] pnv-phb related cleanups" - it d

Re: [PATCH for-7.2] hw: Add compat machines for 7.2

2022-07-28 Thread Daniel Henrique Barboza
On 7/27/22 09:17, Cornelia Huck wrote: Add 7.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- Looking good for pseries. Reviewed-by: Daniel Henrique Barboza hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw

Re: [PATCH v3] target/ppc: Implement new wait variants

2022-07-28 Thread Daniel Henrique Barboza
On 7/28/22 02:29, Joel Stanley wrote: On Wed, 27 Jul 2022 at 13:49, Daniel Henrique Barboza wrote: On 7/20/22 10:33, Nicholas Piggin wrote: ISA v2.06 adds new variations of wait, specified by the WC field. These are not all compatible with the prior wait implementation, because they add

[PULL 0/3] ppc queue

2022-07-28 Thread Daniel Henrique Barboza
index() returns NULL -------- Daniel Henrique Barboza (1): hw/ppc: check if spapr_drc_index() returns NULL in spapr_nvdimm.c Nicholas Piggin (1): target/ppc: Implement new wait variants Peter Maydell (1): hw/ppc/ppc440_u

[PULL 1/3] hw/ppc: check if spapr_drc_index() returns NULL in spapr_nvdimm.c

2022-07-28 Thread Daniel Henrique Barboza
_flush(), the DRC object is wrongly freed/released (e.g. a bug in another part of the code). spapr_drc_index() would then return NULL in the callbacks. Fixes: Coverity CID 1487108, 1487178 Reviewed-by: Greg Kurz Message-Id: <20220409200856.283076-2-danielhb...@gmail.com> Signed-off-by: Daniel Henr

[PULL 3/3] target/ppc: Implement new wait variants

2022-07-28 Thread Daniel Henrique Barboza
y: Joel Stanley Reviewed-by: Daniel Henrique Barboza Message-Id: <20220720133352.904263-1-npig...@gmail.com> [danielhb: added information about the bug being fixed] Signed-off-by: Daniel Henrique Barboza --- target/ppc/internal.h | 3 ++ target/ppc/translate.c | 96

[PULL 2/3] hw/ppc/ppc440_uc: Initialize length passed to cpu_physical_memory_map()

2022-07-28 Thread Daniel Henrique Barboza
th memmove(). This was spotted by Coverity, which points out that we never initialized the variables before using them. Fixes: Coverity CID 1487137, 1487150 Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-Id: <20220726182341.1888115-2-peter.mayd...@linaro.org> Signed-off-by:

[PATCH] hw/riscv: remove 'fdt' param from riscv_setup_rom_reset_vec()

2022-07-28 Thread Daniel Henrique Barboza
The 'fdt' param is not being used in riscv_setup_rom_reset_vec(). Simplify the API by removing it. While we're at it, remove the redundant 'return' statement at the end of function. Cc: Palmer Dabbelt Cc: Alistair Francis Cc: Bin Meng Cc: Vijai Kumar K Signed-off-by

Re: [PULL 0/3] ppc queue

2022-07-28 Thread Daniel Henrique Barboza
On 7/28/22 17:18, Richard Henderson wrote: On 7/28/22 09:55, Daniel Henrique Barboza wrote:    https://gitlab.com/danielhb/qemu.git  pull-ppc-20220728 fatal: couldn't find remote ref pull-ppc-20220728 Did you forget to push the tag to gitlab? I guess I mistyped the credentials

Re: [PATCH] ppc: Remove redundant macro MSR_BOOK3S_MASK.

2022-07-28 Thread Daniel Henrique Barboza
;t being used. Reviewed-by: Daniel Henrique Barboza Laurent, I believe this is qemu-trivial material. Let me know if you want me to get it via the ppc tree instead. Daniel #if defined(TARGET_PPC64) void helper_rfid(CPUPPCState *env) {

Re: [PATCH for-7.1? 0/2] Re-enable ppc32 as a linux-user host

2022-07-29 Thread Daniel Henrique Barboza
On 7/29/22 14:21, Richard Henderson wrote: This is, technically, a regression from 6.2, so it's not implausible to apply before rc1. Thoughts? In gitlab #1097 the author comments that: https://gitlab.com/qemu-project/qemu/-/issues/1097#note_1044810483 "there are several distributions sti

Re: [PATCH 1/2] common-user/host/ppc: Implement safe-syscall.inc.S

2022-07-30 Thread Daniel Henrique Barboza
On 7/29/22 14:21, Richard Henderson wrote: Signed-off-by: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza common-user/host/ppc/safe-syscall.inc.S | 107 1 file changed, 107 insertions(+) create mode 100644 common-user/host/ppc/safe-syscall.inc.S

Re: [PATCH 2/2] linux-user: Implment host/ppc/host-signal.h

2022-07-30 Thread Daniel Henrique Barboza
y: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza linux-user/include/host/ppc/host-signal.h | 39 +++ 1 file changed, 39 insertions(+) create mode 100644 linux-user/include/host/ppc/host-signal.h diff --git a/linux-user/include/host/ppc/host-signal.h b/linux-us

Re: [PATCH 01/19] ppc/ppc405: Remove taihu machine

2022-08-02 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: It has been deprecated since 7.0. Signed-off-by: Cédric Le Goater --- docs/about/deprecated.rst| 9 -- docs/system/ppc/embedded.rst | 1 - hw/ppc/ppc405_boards.c | 232 --- 3 files changed, 242 deleti

Re: [PATCH 02/19] ppc/ppc405: Introduce a PPC405 generic machine

2022-08-02 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: We will use this machine as a base to define the ref405ep and possibly the PPC405 hotfoot board as found in the Linux kernel. Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405_boards.c | 31 --- 1 file changed, 28 insert

Re: [PATCH 03/19] ppc/ppc405: Move devices under the ref405ep machine

2022-08-02 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc405_boards.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc

Re: [PATCH 05/19] ppc/ppc405: Start QOMification of the SoC

2022-08-02 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: This moves all the code previously done in the ppc405ep_init() routine under ppc405_soc_realize(). Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 12 ++-- hw/ppc/ppc405_boards.c | 12 ++-- hw/ppc/ppc405_uc.c | 151 +

Re: [PATCH 04/19] ppc/ppc405: Introduce a PPC405 SoC

2022-08-02 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: It is an initial model to start QOMification of the PPC405 board. Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc405.h| 17 ++ hw/ppc/ppc405_boards.c | 29 ++- hw/ppc

Re: [PATCH 06/19] ppc/ppc405: QOM'ify CPU

2022-08-03 Thread Daniel Henrique Barboza
initializer of the CPU families needing it. Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc405.h| 2 +- hw/ppc/ppc405_boards.c | 2 +- hw/ppc/ppc405_uc.c | 34 -- 3 files changed, 26 insertions(+), 12

Re: [PATCH 07/19] ppc/ppc405: QOM'ify CPC

2022-08-03 Thread Daniel Henrique Barboza
- ppc_dcr_init(env, NULL, NULL); /* CPU control */ -ppc405ep_cpc_init(env, clk_setup, s->sysclk); +object_property_set_link(OBJECT(&s->cpc), "cpu", OBJECT(&s->cpu), + &error_abort); + if (!qdev_realize(DEVICE(&

Re: [PATCH 09/19] ppc/ppc405: QOM'ify OCM

2022-08-03 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc405.h| 18 hw/ppc/ppc405_uc.c | 73 -- 2 files changed, 63 insertions(+), 28 deletions(-) diff

Re: [PATCH 08/19] ppc/ppc405: QOM'ify GPT

2022-08-03 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc405.h| 22 hw/ppc/ppc405_uc.c | 90 +++--- 2 files changed, 67 insertions(+), 45 deletions(-) diff

Re: [PATCH 05/19] ppc/ppc405: Start QOMification of the SoC

2022-08-03 Thread Daniel Henrique Barboza
On 8/2/22 18:24, BALATON Zoltan wrote: On Tue, 2 Aug 2022, Daniel Henrique Barboza wrote: On 8/1/22 10:10, Cédric Le Goater wrote: This moves all the code previously done in the ppc405ep_init() routine under ppc405_soc_realize(). Signed-off-by: Cédric Le Goater ---   hw/ppc/ppc405.h

Re: [PATCH 10/19] ppc/ppc405: QOM'ify GPIO

2022-08-03 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc405.h| 21 +++ hw/ppc/ppc405_uc.c | 50 +- 2 files changed, 44 insertions(+), 27 deletions

Re: [PATCH 12/19] ppc/ppc405: QOM'ify EBC

2022-08-03 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc405.h| 16 +++ hw/ppc/ppc405_uc.c | 71 +++--- 2 files changed, 64 insertions(+), 23 deletions(-) diff

Re: [PATCH 11/19] ppc/ppc405: QOM'ify DMA

2022-08-03 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc405.h| 23 + hw/ppc/ppc405_uc.c | 80 +- 2 files changed, 73 insertions(+), 30 deletions(-) diff

Re: [PATCH 14/19] ppc/ppc405: QOM'ify POB

2022-08-03 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc405.h| 14 +++ hw/ppc/ppc405_uc.c | 58 +++--- 2 files changed, 53 insertions(+), 19 deletions(-) diff

Re: [PATCH 13/19] ppc/ppc405: QOM'ify OPBA

2022-08-03 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc405.h| 12 hw/ppc/ppc405_uc.c | 47 +++--- 2 files changed, 40 insertions(+), 19 deletions(-) diff

Re: [PATCH 17/19] ppc/ppc405: QOM'ify FPGA

2022-08-03 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc405_boards.c | 55 +- 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc

Re: [PATCH 15/19] ppc/ppc405: QOM'ify PLB

2022-08-03 Thread Daniel Henrique Barboza
is an old form of 'arbitrator'. I looked it up because I thought you misspelled 'arbiter', which is the name of a Protoss combat unit in Starcraft. And it happens to be a synonym of 'arbitrator' as well. 'arbitrer' is fine, don't worry about it. Revi

Re: [PATCH 19/19] ppc/ppc405: QOM'ify I2C

2022-08-03 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: Having an explicit I2C model object will help if one day we want to add I2C devices on the bus. Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc405.h| 2 ++ hw/ppc/ppc405_uc.c | 10 -- 2 files

Re: [PATCH 18/19] ppc/ppc405: QOM'ify UIC

2022-08-03 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- With the compile fix that you mentioned fixed up: Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc405.h| 3 ++- hw/ppc/ppc405_uc.c | 27 ++- 2 files changed, 16 insertions

Re: [PATCH 16/19] ppc/ppc405: QOM'ify MAL

2022-08-03 Thread Daniel Henrique Barboza
On 8/1/22 10:10, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc405.h | 1 + include/hw/ppc/ppc4xx.h | 28 ++ hw/ppc/ppc405_uc.c | 20 +-- hw/ppc/ppc4xx_devs.c| 120

[PATCH for-7.2 02/10] ppc/pnv: add phb-id/chip-id PnvPHB4RootBus properties

2022-08-03 Thread Daniel Henrique Barboza
deal with phb3 code. Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb4.c | 51 ++ include/hw/pci-host/pnv_phb4.h | 10 +++ 2 files changed, 61 insertions(+) diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c index b98c3

[PATCH for-7.2 08/10] ppc/pnv: enable user created pnv-phb powernv9

2022-08-03 Thread Daniel Henrique Barboza
Enable pnv-phb user created devices for powernv9 now that we have everything in place. Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb.c | 2 +- hw/pci-host/pnv_phb4_pec.c | 6 -- hw/ppc/pnv.c | 2 ++ 3 files changed, 7 insertions(+), 3 deletions(-) diff

[PATCH for-7.2 01/10] ppc/pnv: add phb-id/chip-id PnvPHB3RootBus properties

2022-08-03 Thread Daniel Henrique Barboza
t ports, without doing anything too shady with QOM. Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb3.c | 50 ++ include/hw/pci-host/pnv_phb3.h | 9 +- 2 files changed, 58 insertions(+), 1 deletion(-) diff --git a/hw/pci-host/pnv_phb3.c

[PATCH for-7.2 10/10] ppc/pnv: user creatable pnv-phb for powernv10

2022-08-03 Thread Daniel Henrique Barboza
Given that powernv9 and powernv10 uses the same pnv-phb backend, the logic to allow user created pnv-phbs for powernv10 is already in place. Let's flip the switch. Signed-off-by: Daniel Henrique Barboza --- hw/ppc/pnv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ppc/pnv.c b/h

[PATCH for-7.2 07/10] ppc/pnv: add PHB4 helpers for user created pnv-phb

2022-08-03 Thread Daniel Henrique Barboza
user-created PHB{3,4,5} devices". We'll use it to determine the appropriate PEC for a given user created pnv-phb that uses a PHB4 backend. This is done during realize() time, in pnv_phb_user_device_init(). Signed-off-by: Daniel Henrique Barboza --- hw/pci-host

[PATCH for-7.2 03/10] ppc/pnv: set root port chassis and slot using Bus properties

2022-08-03 Thread Daniel Henrique Barboza
sting default devices. Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/hw/pci-host/pnv_phb.c b/hw/pci-host/pnv_phb.c index c47ed92462..826c0c144e 100644 --- a/hw/pci-host/pnv_phb

[PATCH for-7.2 09/10] ppc/pnv: change pnv_phb4_get_pec() to also retrieve chip10->pecs

2022-08-03 Thread Daniel Henrique Barboza
The function assumes that we're always dealing with a PNV9_CHIP() object. This is not the case when the pnv-phb device belongs to a powernv10 machine. Change pnv_phb4_get_pec() to be able to work with PNV10_CHIP() if necessary. Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_

[PATCH for-7.2 04/10] ppc/pnv: add helpers for pnv-phb user devices

2022-08-03 Thread Daniel Henrique Barboza
e phb3/phb4 backends untouched. Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb.c | 69 +++ 1 file changed, 69 insertions(+) diff --git a/hw/pci-host/pnv_phb.c b/hw/pci-host/pnv_phb.c index 826c0c144e..da779dc298 100644 --- a/hw/pci-host/pnv_phb

[PATCH for-7.2 00/10] enable pnv-phb user created devices

2022-08-03 Thread Daniel Henrique Barboza
https://lists.gnu.org/archive/html/qemu-devel/2022-05/msg06254.html Daniel Henrique Barboza (10): ppc/pnv: add phb-id/chip-id PnvPHB3RootBus properties ppc/pnv: add phb-id/chip-id PnvPHB4RootBus properties ppc/pnv: set root port chassis and slot using Bus properties ppc/pnv: add helpers for

[PATCH for-7.2 05/10] ppc/pnv: turn chip8->phbs[] into a PnvPHB* array

2022-08-03 Thread Daniel Henrique Barboza
nted by the chip because pnv_xscom_dt() relies on it, and then assigned to the array. Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb.c | 11 +++ hw/ppc/pnv.c | 20 +++- include/hw/ppc/pnv.h | 6 +- 3 files changed, 31 insertions(+), 6 deletio

[PATCH for-7.2 06/10] ppc/pnv: enable user created pnv-phb for powernv8

2022-08-03 Thread Daniel Henrique Barboza
The bulk of the work was already done by previous patches. Use defaults_enabled() to determine whether we need to create the default devices or not. Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb.c | 9 +++-- hw/ppc/pnv.c | 6 ++ 2 files changed, 13 insertions

Re: [PATCH v2 01/20] ppc/ppc405: Remove taihu machine

2022-08-03 Thread Daniel Henrique Barboza
On 8/3/22 10:28, Cédric Le Goater wrote: It has been deprecated since 7.0. Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza docs/about/deprecated.rst | 9 -- docs/about/removed-features.rst | 6 + docs/system/ppc/embedded.rst| 1 - hw/ppc

Re: [PATCH v2 02/20] ppc/ppc405: Introduce a PPC405 generic machine

2022-08-03 Thread Daniel Henrique Barboza
On 8/3/22 14:03, BALATON Zoltan wrote: On Wed, 3 Aug 2022, Cédric Le Goater wrote: We will use this machine as a base to define the ref405ep and possibly the PPC405 hotfoot board as found in the Linux kernel. Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405_boards.c | 31 ++

[PATCH] hw/ppc: sam460ex.c: store all GPIO lines in mal_irqs[]

2022-08-03 Thread Daniel Henrique Barboza
ppc/sam460ex: Drop use of ppcuic_init()") Signed-off-by: Daniel Henrique Barboza --- hw/ppc/sam460ex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c index 7e8da657c2..0357ee077f 100644 --- a/hw/ppc/sam460ex.c +++ b/hw/ppc/sam460ex.c @@

Re: [PATCH v2 12/20] ppc/ppc405: QOM'ify EBC

2022-08-03 Thread Daniel Henrique Barboza
Cedric, On 8/3/22 10:28, Cédric Le Goater wrote: Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 16 +++ hw/ppc/ppc405_uc.c | 71 +++--- 2 files changed, 64 insertions(+), 23 deletions(-) diff

Re: [PATCH v2 15/20] ppc/ppc405: QOM'ify PLB

2022-08-03 Thread Daniel Henrique Barboza
On 8/3/22 10:28, Cédric Le Goater wrote: Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 14 ++ hw/ppc/ppc405_uc.c | 67 +- 2 files changed, 62 insertions(+), 19 deletions(-) diff --git a

Re: [PATCH v2 16/20] ppc/ppc405: QOM'ify MAL

2022-08-03 Thread Daniel Henrique Barboza
This patch really broke sam460ex boot, but not because of the QOMification. I managed to get it work by doing the following: On 8/3/22 10:28, Cédric Le Goater wrote: Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h | 1 + include/hw/ppc

Re: [PATCH v2 00/20] ppc: QOM'ify 405 board

2022-08-04 Thread Daniel Henrique Barboza
On 8/4/22 03:07, Cédric Le Goater wrote: Daniel, On 8/3/22 15:28, Cédric Le Goater wrote: Hello, Here is large series QOM'ifying the PPC405 board. It introduces a new generic machine and SoC models, converts the current device models to QOM and populates the SoC. The process is quite mechan

Re: [PATCH v2 1/1] target/ppc: fix unreachable code in do_ldst_quad()

2022-08-04 Thread Daniel Henrique Barboza
On 8/4/22 15:05, Peter Maydell wrote: On Mon, 25 Jul 2022 at 21:24, Daniel Henrique Barboza wrote: Coverity reports that commit fc34e81acd51 ("target/ppc: add macros to check privilege level") turned the following code unreachable: if (!prefixed && !(ctx->insns_fla

[PULL 1/1] hw/ppc: sam460ex.c: store all GPIO lines in mal_irqs[]

2022-08-04 Thread Daniel Henrique Barboza
ppc/sam460ex: Drop use of ppcuic_init()") Acked-by: BALATON Zoltan Reviewed-by: Cédric Le Goater Message-Id: <20220803233204.2724202-1-danielhb...@gmail.com> Signed-off-by: Daniel Henrique Barboza --- hw/ppc/sam460ex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PULL 0/1] ppc queue

2022-08-04 Thread Daniel Henrique Barboza
so let's fix it now. -------- Daniel Henrique Barboza (1): hw/ppc: sam460ex.c: store all GPIO lines in mal_irqs[] hw/ppc/sam460ex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH for-7.2 v2 05/20] hw/ppc: set machine->fdt in bamboo_load_device_tree()

2022-08-05 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' and 'info fdt' HMP commands for the bamboo machine. Cc: Cédric Le Goater Signed-off-by: Daniel Henrique Barboza --- hw/ppc/ppc440_bamboo.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/ppc/ppc4

[PATCH for-7.2 v2 04/20] hw/ppc: set machine->fdt in ppce500_load_device_tree()

2022-08-05 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' and 'info fdt' HMP commands for the e500 machine. Cc: Cédric Le Goater Signed-off-by: Daniel Henrique Barboza --- hw/ppc/e500.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/hw/ppc/e500.c b

[PATCH for-7.2 v2 01/20] hw/arm: do not free machine->fdt in arm_load_dtb()

2022-08-05 Thread Daniel Henrique Barboza
es allocates the FDT only once, we don't need to worry about leaking the existing FDT during a machine reset (which is something that other machines have to look after, e.g. the ppc64 pSeries machine). Cc: Peter Maydell Cc: qemu-...@nongnu.org Signed-off-by: Daniel Henrique Barboza --- hw/arm/boot

[PATCH for-7.2 v2 00/20] QMP/HMP: add 'dumpdtb' and 'info fdt' commands

2022-08-05 Thread Daniel Henrique Barboza
x-query-fdt' of 'info fdt' - patch 20 (former 10): - added the 'propname' parameter to support parameters instead of parsing the fullpath of the parameter - helper fdt_find_property() was removed. The logic is short enough to be open coded in qmp_x_query_fdt() - v1 link

[PATCH for-7.2 v2 10/20] hw/ppc: set machine->fdt in spapr machine

2022-08-05 Thread Daniel Henrique Barboza
es. Let's set machine->fdt in the two places where we manipulate the FDT: spapr_machine_reset() and CAS. spapr->fdt_blob is left untouched: what we want is a way to access the FDT from HMP, not replace spapr->fdt_blob. Cc: Cédric Le Goater Cc: qemu-...@nongnu.org Signed-off-by: Daniel H

  1   2   3   4   5   6   7   8   9   10   >