Re: [Qemu-devel] [RFC] KVM "fake DAX" device flushing

2017-10-11 Thread Dan Williams
On Wed, Oct 11, 2017 at 11:51 AM, Pankaj Gupta wrote: > We are sharing the prototype version of 'fake DAX' flushing > interface for the initial feedback. This is still work in progress > and not yet ready for merging. > > Protoype right now just implements basic functionality without advanced > fe

Re: [Qemu-devel] [RFC 1/2] pmem: Move reusable code to base header files

2017-10-12 Thread Dan Williams
On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta wrote: > This patch moves common code to base header files > so that it can be used for both ACPI pmem and VIRTIO pmem > drivers. More common code needs to be moved out in future > based on functionality required for virtio_pmem driver and > coupl

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Dan Williams
On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM guest. > Guest reads the persistent memory range information > over virtio bus from Qemu and reserves the range > as persistent memory. Guest also allocates a block > device corresponding to

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Dan Williams
On Thu, Oct 12, 2017 at 2:25 PM, Pankaj Gupta wrote: > >> > This patch adds virtio-pmem driver for KVM guest. >> > Guest reads the persistent memory range information >> > over virtio bus from Qemu and reserves the range >> > as persistent memory. Guest also allocates a block >> > device

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Dan Williams
On Thu, Oct 12, 2017 at 3:52 PM, Pankaj Gupta wrote: > Dan, > > I have a query regarding below patch [*]. My assumption is its halted > because of memory hotplug restructuring work? Anything I am missing > here? > > [*] https://www.mail-archive.com/linux-nvdimm@lists.01.org/msg02978.html It's fal

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-13 Thread Dan Williams
On Fri, Oct 13, 2017 at 2:44 AM, Stefan Hajnoczi wrote: > On Thu, Oct 12, 2017 at 09:20:26PM +0530, Pankaj Gupta wrote: [..] >> +#ifndef REQ_FLUSH >> +#define REQ_FLUSH REQ_PREFLUSH >> +#endif > > Is this out-of-tree kernel module compatibility stuff that can be > removed? Yes, this was copied fr

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-16 Thread Dan Williams
On Mon, Oct 16, 2017 at 7:47 AM, Stefan Hajnoczi wrote: > On Fri, Oct 13, 2017 at 06:48:15AM -0400, Pankaj Gupta wrote: >> > On Thu, Oct 12, 2017 at 09:20:26PM +0530, Pankaj Gupta wrote: >> > > +static blk_qc_t virtio_pmem_make_request(struct request_queue *q, >> > > + struct bio *

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-21 Thread Dan Williams
On Tue, Nov 21, 2017 at 10:19 AM, Rik van Riel wrote: > On Fri, 2017-11-03 at 14:21 +0800, Xiao Guangrong wrote: >> On 11/03/2017 12:30 AM, Dan Williams wrote: >> > >> > Good point, I was assuming that the mmio flush interface would be >> > discovered separatel

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-23 Thread Dan Williams
On Wed, Nov 22, 2017 at 8:05 PM, Xiao Guangrong wrote: > > > On 11/22/2017 02:19 AM, Rik van Riel wrote: > >> We can go with the "best" interface for what >> could be a relatively slow flush (fsync on a >> file on ssd/disk on the host), which requires >> that the flushing task wait on completion >

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-28 Thread Dan Williams
On Fri, Nov 24, 2017 at 4:40 AM, Pankaj Gupta wrote: [..] > 1] Expose vNVDIMM memory range to KVM guest. > >- Add flag in ACPI NFIT table for this new memory type. Do we need NVDIMM > spec > changes for this? Not a flag, but a new "Address Range Type GUID". See section "5.2.25.2 System

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2018-01-17 Thread Dan Williams
On Fri, Jan 12, 2018 at 10:23 PM, Pankaj Gupta wrote: > > Hello Dan, > >> Not a flag, but a new "Address Range Type GUID". See section "5.2.25.2 >> System Physical Address (SPA) Range Structure" in the ACPI 6.2A >> specification. Since it is a GUID we could define a Linux specific >> type for this

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2018-01-18 Thread Dan Williams
On Thu, Jan 18, 2018 at 8:53 AM, David Hildenbrand wrote: > On 24.11.2017 13:40, Pankaj Gupta wrote: >> >> Hello, >> >> Thank you all for all the useful suggestions. >> I want to summarize the discussions so far in the >> thread. Please see below: >> > >> We can go with the "best" interfac

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2018-01-18 Thread Dan Williams
On Thu, Jan 18, 2018 at 9:48 AM, David Hildenbrand wrote: >>> I'd like to emphasize again, that I would prefer a virtio-pmem only >>> solution. >>> >>> There are architectures out there (e.g. s390x) that don't support >>> NVDIMMs - there is no HW interface to expose any such stuff. >>> >>> However

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2018-01-18 Thread Dan Williams
On Thu, Jan 18, 2018 at 10:54 AM, Pankaj Gupta wrote: > >> >> >> I'd like to emphasize again, that I would prefer a virtio-pmem only >> >> solution. >> >> >> >> There are architectures out there (e.g. s390x) that don't support >> >> NVDIMMs - there is no HW interface to expose any such stuff. >> >

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2018-01-18 Thread Dan Williams
On Thu, Jan 18, 2018 at 11:36 AM, Pankaj Gupta wrote: > >> >> On Thu, Jan 18, 2018 at 10:54 AM, Pankaj Gupta wrote: >> > >> >> >> >> >> I'd like to emphasize again, that I would prefer a virtio-pmem only >> >> >> solution. >> >> >> >> >> >> There are architectures out there (e.g. s390x) that don'

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2018-01-18 Thread Dan Williams
On Thu, Jan 18, 2018 at 11:51 AM, David Hildenbrand wrote: > >>> 1] Existing pmem driver & virtio for region discovery: >>> - >>> Use existing pmem driver which is tightly coupled with concepts of >>> namespaces, labels etc >>> from ACPI r

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-06 Thread Dan Williams
On Thu, Apr 6, 2017 at 2:43 AM, Stefan Hajnoczi wrote: > On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: >> This patch series constructs the flush hint address structures for >> nvdimm devices in QEMU. >> >> It's of course not for 2.9. I send it out early in order to get >> comment

Re: [Qemu-devel] [PATCH v2 0/2] kvm "fake DAX" device

2018-10-13 Thread Dan Williams
On Fri, Oct 12, 2018 at 10:00 PM Pankaj Gupta wrote: > > This patch series has implementation for "fake DAX". > "fake DAX" is fake persistent memory(nvdimm) in guest > which allows to bypass the guest page cache. This also > implements a VIRTIO based asynchronous flush mechanism. Can we stop

Re: [Qemu-devel] [PATCH v2 2/2] virtio-pmem: Add virtio pmem driver

2018-10-13 Thread Dan Williams
On Fri, Oct 12, 2018 at 10:01 PM Pankaj Gupta wrote: > > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range informa

Re: [Qemu-devel] [PATCH v2 2/2] virtio-pmem: Add virtio pmem driver

2018-10-17 Thread Dan Williams
On Wed, Oct 17, 2018 at 12:11 PM Pankaj Gupta wrote: > > > > > On Fri, Oct 12, 2018 at 10:01 PM Pankaj Gupta wrote: > > > > > > This patch adds virtio-pmem driver for KVM guest. > > > > > > Guest reads the persistent memory range information from > > > Qemu over VIRTIO and registers it on nvdimm_

Re: [Qemu-devel] [PATCH 2/3] libnvdimm: nd_region flush callback support

2018-09-21 Thread Dan Williams
On Fri, Aug 31, 2018 at 6:32 AM Pankaj Gupta wrote: > > This patch adds functionality to perform flush from guest > to host over VIRTIO. We are registering a callback based > on 'nd_region' type. virtio_pmem driver requires this special > flush function. For rest of the region types we are registe

Re: [Qemu-devel] [PATCH 1/3] nd: move nd_region to common header

2018-09-21 Thread Dan Williams
On Fri, Aug 31, 2018 at 6:31 AM Pankaj Gupta wrote: > > This patch moves nd_region definition to common header > include/linux/nd.h file. This is required for flush callback > support for both virtio-pmem & pmem driver. > > Signed-off-by: Pankaj Gupta > --- > drivers/nvdimm/nd.h | 39 ---

Re: [Qemu-devel] [PATCH 3/3] virtio-pmem: Add virtio pmem driver

2018-09-21 Thread Dan Williams
On Fri, Aug 31, 2018 at 6:32 AM Pankaj Gupta wrote: > > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information from > Qemu over VIRTIO and registers it on nvdimm_bus. It also > creates a nd_region object with the persistent memory > range informat

Re: [Qemu-devel] [PATCH 3/3] virtio-pmem: Add virtio pmem driver

2018-09-27 Thread Dan Williams
On Thu, Sep 27, 2018 at 6:07 AM Pankaj Gupta wrote: [..] > > We are plugging VIRTIO based flush callback for virtio_pmem driver. If pmem > > driver (pmem_make_request) has to queue request we have to plug "blk_mq_ops" > > callbacks for corresponding VIRTIO vqs. AFAICU there is no existing > > mul

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-12 Thread Dan Williams
On Sat, Jan 12, 2019 at 5:38 PM Pankaj Gupta wrote: > > > > > > > On Thu 10-01-19 12:26:17, Dave Chinner wrote: > > > On Wed, Jan 09, 2019 at 08:17:31PM +0530, Pankaj Gupta wrote: > > > > This patch series has implementation for "virtio pmem". > > > > "virtio pmem" is fake persistent memory(nvdi

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-14 Thread Dan Williams
On Mon, Jan 14, 2019 at 1:25 PM Dave Chinner wrote: > > On Mon, Jan 14, 2019 at 02:15:40AM -0500, Pankaj Gupta wrote: > > > > > > Until you have images (and hence host page cache) shared between > > > > multiple guests. People will want to do this, because it means they > > > > only need a single

Re: [Qemu-devel] [PATCH v3 3/5] libnvdimm: add nd_region buffered dax_dev flag

2019-01-09 Thread Dan Williams
On Wed, Jan 9, 2019 at 5:53 AM Pankaj Gupta wrote: > > This patch adds 'DAXDEV_BUFFERED' flag which is set > for virtio pmem corresponding nd_region. This later > is used to disable MAP_SYNC functionality for ext4 > & xfs filesystem. > > Signed-off-by: Pankaj Gupta > --- > drivers/dax/super.c

Re: [Qemu-devel] Questions about vNVDIMM on qemu/KVM

2018-05-23 Thread Dan Williams
On Tue, May 22, 2018 at 10:08 PM, Yasunori Goto wrote: > Hello, > > I'm investigating status of vNVDIMM on qemu/KVM, > and I have some questions about it. I'm glad if anyone answer them. > > In my understanding, qemu/KVM has a feature to show NFIT for guest, > and it will be still updated about pl

Re: [Qemu-devel] Questions about vNVDIMM on qemu/KVM

2018-05-24 Thread Dan Williams
On Thu, May 24, 2018 at 12:19 AM, Yasunori Goto wrote: >> On Tue, May 22, 2018 at 10:08 PM, Yasunori Goto >> wrote: >> > Hello, >> > >> > I'm investigating status of vNVDIMM on qemu/KVM, >> > and I have some questions about it. I'm glad if anyone answer them. >> > >> > In my understanding, qemu/

Re: [Qemu-devel] RFC: altering the NVDIMM acpi table

2018-04-23 Thread Dan Williams
On Mon, Apr 23, 2018 at 1:35 PM, Schmauss, Erik wrote: > Hello, > > I work on ACPICA and we have recently made changes to the behavior of > the Linux AML interpreter to match other OS implementations. After > sending the patches to upstream Linux, we have identified that > hw/acpi/nvdimm.c specifi

Re: [Qemu-devel] [RFC v2 1/2] virtio: add pmem driver

2018-04-25 Thread Dan Williams
On Wed, Apr 25, 2018 at 4:24 AM, Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM > guest. Minor nit, please expand your changelog line wrapping to 72 columns. > > Guest reads the persistent memory range > information from Qemu over VIRTIO and registers > it on nvdimm_bus. It als

Re: [Qemu-devel] [RFC v2 2/2] pmem: device flush over VIRTIO

2018-04-25 Thread Dan Williams
On Wed, Apr 25, 2018 at 4:24 AM, Pankaj Gupta wrote: > This patch adds functionality to perform > flush from guest to hosy over VIRTIO > when 'ND_REGION_VIRTIO'flag is set on > nd_negion. Flag is set by 'virtio-pmem' > driver. > > Signed-off-by: Pankaj Gupta > --- > drivers/nvdimm/region_devs.c

Re: [Qemu-devel] [RFC v2 1/2] virtio: add pmem driver

2018-04-25 Thread Dan Williams
[ adding Jeff directly since he has also been looking at infrastructure to track when MAP_SYNC should be disabled ] On Wed, Apr 25, 2018 at 7:21 AM, Dan Williams wrote: > On Wed, Apr 25, 2018 at 4:24 AM, Pankaj Gupta wrote: >> This patch adds virtio-pmem driver for KVM >> guest

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-25 Thread Dan Williams
>> > Good to know, thanks. > > I have made a big mistake. I was comparing the resulting SSDT of this patch > to an SSDT > Generated by a much older version of kvm/qemu. The latest kvm/qemu upstream > builds > the SSDT with the operation region contained inside of methods. This should > resolve >

Re: [Qemu-devel] [RFC v2 2/2] pmem: device flush over VIRTIO

2018-04-26 Thread Dan Williams
On Thu, Apr 26, 2018 at 9:40 AM, Pankaj Gupta wrote: > >> >> On Wed, Apr 25, 2018 at 04:54:14PM +0530, Pankaj Gupta wrote: >> > This patch adds functionality to perform >> > flush from guest to hosy over VIRTIO >> > when 'ND_REGION_VIRTIO'flag is set on >> > nd_negion. Flag is set by 'virtio-pmem'

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Dan Williams
On Tue, Jun 5, 2018 at 9:42 AM, Ross Zwisler wrote: > On Tue, Jun 05, 2018 at 06:25:27PM +0300, Michael S. Tsirkin wrote: >> On Mon, May 21, 2018 at 10:32:02AM -0600, Ross Zwisler wrote: >> > Add a machine command line option to allow the user to control the Platform >> > Capabilities Structure in

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Dan Williams
On Tue, Jun 5, 2018 at 3:07 PM, Ross Zwisler wrote: > On Tue, Jun 05, 2018 at 09:37:25PM +0300, Michael S. Tsirkin wrote: >> On Tue, Jun 05, 2018 at 11:15:00AM -0700, Dan Williams wrote: >> > On Tue, Jun 5, 2018 at 9:42 AM, Ross Zwisler >> > wrote: >> > > O

Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-06 Thread Dan Williams
On Wed, Jun 6, 2018 at 4:20 PM, Elliott, Robert (Persistent Memory) wrote: > >> > Okay, we can move to the symbolic names. Do you want them to be that >> long, or >> > would: >> > >> > nvdimm-cap-cpu >> > nvdimm-cap-mem-ctrl >> > nvdimm-cap-mirroring >> >> Wait, why is mirroring part of this? > >

Re: [Qemu-devel] [RFC PATCH 1/1] nvdimm: let qemu requiring section alignment of pmem resource.

2018-06-11 Thread Dan Williams
On Mon, Jun 11, 2018 at 9:26 AM, Stefan Hajnoczi wrote: > On Mon, Jun 11, 2018 at 06:54:25PM +0800, Zhang Yi wrote: >> Nvdimm driver use Memory hot-plug APIs to map it's pmem resource, >> which at a section granularity. >> >> When QEMU emulated the vNVDIMM device, decrease the label-storage, >> QE

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-18 Thread Dan Williams
On Wed, Oct 18, 2017 at 6:03 AM, Stefan Hajnoczi wrote: > On Tue, Oct 17, 2017 at 04:30:41AM -0400, Pankaj Gupta wrote: >> >> > > Are you saying do it as existing i.e ACPI pmem like interface? >> > > The reason we have created this new driver is exiting pmem driver >> > > does not define proper se

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-19 Thread Dan Williams
On Thu, Oct 19, 2017 at 1:01 AM, Christoph Hellwig wrote: > On Wed, Oct 18, 2017 at 08:51:37AM -0700, Dan Williams wrote: >> This use case is not "Persistent Memory". Persistent Memory is >> something you can map and make persistent with CPU instructions. >> Anyth

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-20 Thread Dan Williams
On Fri, Oct 20, 2017 at 1:00 AM, Christoph Hellwig wrote: > On Thu, Oct 19, 2017 at 11:21:26AM -0700, Dan Williams wrote: >> The difference is that nvdimm_flush() is not mandatory, and that the >> platform will automatically perform the same flush at power-fail. >> Applicati

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-20 Thread Dan Williams
On Fri, Oct 20, 2017 at 9:06 AM, Christoph Hellwig wrote: > On Fri, Oct 20, 2017 at 08:05:09AM -0700, Dan Williams wrote: >> Right, that's the same recommendation I gave. >> >> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg08404.html >> >>

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-10-31 Thread Dan Williams
On Tue, Oct 31, 2017 at 12:13 AM, Xiao Guangrong wrote: > > > On 07/27/2017 08:54 AM, Dan Williams wrote: > >>> At that point, would it make sense to expose these special >>> virtio-pmem areas to the guest in a slightly different way, >>> so the regions tha

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-10-31 Thread Dan Williams
On Tue, Oct 31, 2017 at 8:43 PM, Xiao Guangrong wrote: > > > On 10/31/2017 10:20 PM, Dan Williams wrote: >> >> On Tue, Oct 31, 2017 at 12:13 AM, Xiao Guangrong >> wrote: >>> >>> >>> >>> On 07/27/2017 08:54 AM, Dan Williams wrot

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-01 Thread Dan Williams
> On 11/01/2017 12:25 PM, Dan Williams wrote: [..] >> It's not persistent memory if it requires a hypercall to make it >> persistent. Unless memory writes can be made durable purely with cpu >> instructions it's dangerous for it to be treated as a PMEM range. >&g

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-02 Thread Dan Williams
On Thu, Nov 2, 2017 at 1:50 AM, Xiao Guangrong wrote: [..] >> Yes, the GUID will specifically identify this range as "Virtio Shared >> Memory" (or whatever name survives after a bikeshed debate). The >> libnvdimm core then needs to grow a new region type that mostly >> behaves the same as a "pmem"

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-06 Thread Dan Williams
On Sun, Nov 5, 2017 at 11:57 PM, Pankaj Gupta wrote: > > >> [..] >> >> Yes, the GUID will specifically identify this range as "Virtio Shared >> >> Memory" (or whatever name survives after a bikeshed debate). The >> >> libnvdimm core then needs to grow a new region type that mostly >> >> behaves th

Re: [Qemu-devel] [PATCH] hw/acpi-build: build SRAT memory affinity structures for NVDIMM

2018-02-20 Thread Dan Williams
On Tue, Feb 20, 2018 at 6:10 AM, Igor Mammedov wrote: > On Sat, 17 Feb 2018 14:31:35 +0800 > Haozhong Zhang wrote: > >> ACPI 6.2A Table 5-129 "SPA Range Structure" requires the proximity >> domain of a NVDIMM SPA range must match with corresponding entry in >> SRAT table. >> >> The address ranges

Re: [Qemu-devel] [PATCH v2 5/7] ACPICA: Integrate package handling with module-level code

2018-04-16 Thread Dan Williams
On Mon, Apr 16, 2018 at 4:15 PM, Schmauss, Erik wrote: > [ trimming ] >> >> Rafael, we may want to hold back on the module-level code changes >> >> (the patches below) for rc1. Between this and the strange _TSS issue, >> >> it seems like there are a few more things to resolve before this is >> >>

Re: [Qemu-devel] [PATCH v2 5/7] ACPICA: Integrate package handling with module-level code

2018-04-16 Thread Dan Williams
On Mon, Apr 16, 2018 at 5:05 PM, Schmauss, Erik wrote: > >> -Original Message- >> From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- >> ow...@vger.kernel.org] On Behalf Of Dan Williams >> Sent: Monday, April 16, 2018 4:22 PM >> To: Schmauss, Erik

Re: [Qemu-devel] [PATCH] hw/acpi-build: build SRAT memory affinity structures for NVDIMM

2018-02-21 Thread Dan Williams
On Wed, Feb 21, 2018 at 5:55 AM, Igor Mammedov wrote: > On Tue, 20 Feb 2018 17:17:58 -0800 > Dan Williams wrote: > >> On Tue, Feb 20, 2018 at 6:10 AM, Igor Mammedov wrote: >> > On Sat, 17 Feb 2018 14:31:35 +0800 >> > Haozhong Zhang wrote: >> > >&g

Re: [Qemu-devel] [PATCH v2 7/8] migration/ram: ensure write persistence on loading compressed pages to PMEM

2018-02-07 Thread Dan Williams
On Wed, Feb 7, 2018 at 5:24 AM, Dr. David Alan Gilbert wrote: > * Haozhong Zhang (haozhong.zh...@intel.com) wrote: >> On 02/07/18 13:03 +, Dr. David Alan Gilbert wrote: >> > * Haozhong Zhang (haozhong.zh...@intel.com) wrote: >> > > On 02/07/18 11:54 +, Dr. David Alan Gilbert wrote: >> > >

Re: [Qemu-devel] [PATCH v2 7/8] migration/ram: ensure write persistence on loading compressed pages to PMEM

2018-02-07 Thread Dan Williams
On Wed, Feb 7, 2018 at 10:08 AM, Dr. David Alan Gilbert wrote: > * Dan Williams (dan.j.willi...@intel.com) wrote: >> On Wed, Feb 7, 2018 at 5:24 AM, Dr. David Alan Gilbert >> wrote: >> > * Haozhong Zhang (haozhong.zh...@intel.com) wrote: >> >> On 02/07/18

Re: [Qemu-devel] [PATCH v2 7/8] migration/ram: ensure write persistence on loading compressed pages to PMEM

2018-02-07 Thread Dan Williams
On Wed, Feb 7, 2018 at 10:37 AM, Dr. David Alan Gilbert wrote: > * Dan Williams (dan.j.willi...@intel.com) wrote: >> On Wed, Feb 7, 2018 at 10:08 AM, Dr. David Alan Gilbert >> wrote: >> > * Dan Williams (dan.j.willi...@intel.com) wrote: >> >> On Wed, Fe

Re: Microsoft and Intel NVDIMM ACPI _DSM interfaces status?

2021-03-17 Thread Dan Williams
On Wed, Mar 17, 2021 at 4:49 AM Stefan Hajnoczi wrote: > > Hi, > Microsoft and Intel developed two different ACPI NVDIMM _DSM interfaces. > > The specs for the Intel interface are available here: > https://pmem.io/documents/NVDIMM_DSM_Interface_Example.pdf > > This is the interface that QEMU emula

Re: [PATCH v4 0/3] nvdimm: Enable sync-dax property for nvdimm

2021-04-30 Thread Dan Williams
Some corrections to terminology confusion below... On Wed, Apr 28, 2021 at 8:49 PM Shivaprasad G Bhat wrote: > > The nvdimm devices are expected to ensure write persistence during power > failure kind of scenarios. No, QEMU is not expected to make that guarantee. QEMU is free to lie to the gues

Re: [PATCH v4 0/3] nvdimm: Enable sync-dax property for nvdimm

2021-05-03 Thread Dan Williams
On Mon, May 3, 2021 at 7:06 AM Shivaprasad G Bhat wrote: > > > On 5/1/21 12:44 AM, Dan Williams wrote: > > Some corrections to terminology confusion below... > > > > > > On Wed, Apr 28, 2021 at 8:49 PM Shivaprasad G Bhat > > wrote: > >>

Re: [RFC] Set addresses for memory devices [CXL]

2021-01-27 Thread Dan Williams
On Wed, Jan 27, 2021 at 7:52 PM Ben Widawsky wrote: > > Hi list, Igor. > > I wanted to get some ideas on how to better handle this. Per the recent > discussion [1], it's become clear that there needs to be more thought put into > how to manage the address space for CXL memory devices. If you see t

Re: [RFC PATCH 00/25] Introduce CXL 2.0 Emulation

2020-12-03 Thread Dan Williams
[ add linux-cxl for the Linux driver question ] On Thu, Dec 3, 2020 at 9:10 PM Chris Browy wrote: [..] I'll let Ben address the other questions... > 4. What are the userspace system APIs for targeting CXL HDM address domain? >Usually you can mmap a SPA if you know how to look it up. tl;dr

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Dan Williams
x27;align', so that we can compare > >> it with the NUM of 'align=NUM'. > >> The NUM needs to be larger than or equal to the devdax pmem file 'align'. > >> > >> It also fixes the problem that mmap() returns failure in qemu_ram_mmap() > &

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Dan Williams
al to the devdax pmem file 'align'. > > > > It also fixes the problem that mmap() returns failure in qemu_ram_mmap() > > when the NUM of 'align=NUM' is less than the devdax pmem file 'align'. > > > > Cc: Dan Williams > > Signed-off-by:

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-09 Thread Dan Williams
On Thu, Apr 9, 2020 at 7:33 AM Liu, Jingqi wrote: > > On 4/8/2020 5:42 PM, Joao Martins wrote: > > On 4/8/20 3:25 AM, Liu, Jingqi wrote: > >> On 4/8/2020 2:28 AM, Joao Martins wrote: > >>> On 4/7/20 5:55 PM, Dan Williams wrote: > >>>> On Tue, Ap

Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support

2019-04-11 Thread Dan Williams
On Tue, Apr 9, 2019 at 9:09 PM Pankaj Gupta wrote: > > This patch adds functionality to perform flush from guest > to host over VIRTIO. We are registering a callback based > on 'nd_region' type. virtio_pmem driver requires this special > flush function. For rest of the region types we are register

Re: [Qemu-devel] [PATCH v5 3/6] libnvdimm: add dax_dev sync flag

2019-04-11 Thread Dan Williams
On Tue, Apr 9, 2019 at 9:10 PM Pankaj Gupta wrote: > > This patch adds 'DAXDEV_SYNC' flag which is set > for nd_region doing synchronous flush. This later > is used to disable MAP_SYNC functionality for > ext4 & xfs filesystem for devices don't support > synchronous flush. > > Signed-off-by: Panka

Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support

2019-04-11 Thread Dan Williams
block layer > > > by creating a child bio and chaining it with parent bio. > > > > > > Signed-off-by: Pankaj Gupta > > > ---bio_chain Dan williams > > [..] > > > diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c > > > in

Re: [Qemu-devel] [PATCH v4 00/11] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-05-31 Thread Dan Williams
On Tue, May 7, 2019 at 11:32 PM Tao Xu wrote: > > This series of patches will build Heterogeneous Memory Attribute Table (HMAT) > according to the command line. The ACPI HMAT describes the memory attributes, > such as memory side cache attributes and bandwidth and latency details, > related to the

Re: [Qemu-devel] [PATCH v10 4/7] dm: enable synchronous dax

2019-05-31 Thread Dan Williams
On Tue, May 21, 2019 at 6:43 AM Pankaj Gupta wrote: > > This patch sets dax device 'DAXDEV_SYNC' flag if all the target > devices of device mapper support synchrononous DAX. If device > mapper consists of both synchronous and asynchronous dax devices, > we don't set 'DAXDEV_SYNC' flag. > > Sig

Re: [Qemu-devel] Why only devdax guarantees guest data persistence ?

2019-02-20 Thread Dan Williams
On Wed, Feb 20, 2019 at 7:37 AM Stefan Hajnoczi wrote: > > On Fri, Feb 15, 2019 at 05:09:31PM +, bipin.tomar--- via Qemu-devel wrote: > > Text from "docs/nvdimm.txt" says: > > Guest Data Persistence > > -- > > > > Though QEMU supports multiple types of vNVDIMM backends on L

Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support

2019-04-18 Thread Dan Williams
On Fri, Apr 12, 2019 at 6:12 AM Jeff Moyer wrote: > > Jan Kara writes: > > > On Thu 11-04-19 07:51:48, Dan Williams wrote: > >> On Tue, Apr 9, 2019 at 9:09 PM Pankaj Gupta wrote: > >> > + } else { > >> > + if (nd_region->

Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support

2019-04-18 Thread Dan Williams
On Thu, Apr 18, 2019 at 9:18 AM Christoph Hellwig wrote: > > On Thu, Apr 18, 2019 at 09:05:05AM -0700, Dan Williams wrote: > > > > I'd either add a comment about avoiding retpoline overhead here or just > > > > make ->flush == NULL mean generic_nvdimm_flush

Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support

2019-04-22 Thread Dan Williams
On Mon, Apr 22, 2019 at 8:59 AM Jeff Moyer wrote: > > Dan Williams writes: > > > On Thu, Apr 18, 2019 at 9:18 AM Christoph Hellwig > > wrote: > >> > >> On Thu, Apr 18, 2019 at 09:05:05AM -0700, Dan Williams wrote: > >> > > > I'd

Re: [Qemu-devel] Querying the size of devdax devices from userspace

2019-02-04 Thread Dan Williams
On Sun, Feb 3, 2019 at 11:56 PM Stefan Hajnoczi wrote: > > How can userspace applications query the size of devdax character > devices? > > stat(1) doesn't know how large the device is: > > # stat /dev/dax0.0 > File: /dev/dax0.0 > Size: 0 Blocks: 0 IO Block: 4096 c

Re: [Qemu-devel] [PATCH v9 2/7] virtio-pmem: Add virtio pmem driver

2019-05-15 Thread Dan Williams
On Tue, May 14, 2019 at 8:25 AM Pankaj Gupta wrote: > > > > On 5/14/19 7:54 AM, Pankaj Gupta wrote: > > > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > > > index 35897649c24f..94bad084ebab 100644 > > > --- a/drivers/virtio/Kconfig > > > +++ b/drivers/virtio/Kconfig > > > @@ -42,6

Re: [Qemu-devel] [PATCH v9 4/7] dm: enable synchronous dax

2019-05-15 Thread Dan Williams
[ add Mike and dm-devel ] Mike, any concerns with the below addition to the device-mapper-dax implementation? On Tue, May 14, 2019 at 7:58 AM Pankaj Gupta wrote: > > This patch sets dax device 'DAXDEV_SYNC' flag if all the target > devices of device mapper support synchrononous DAX. If device

Re: [Qemu-devel] [PATCH v9 1/7] libnvdimm: nd_region flush callback support

2019-05-15 Thread Dan Williams
On Tue, May 14, 2019 at 7:55 AM Pankaj Gupta wrote: > > This patch adds functionality to perform flush from guest > to host over VIRTIO. We are registering a callback based > on 'nd_region' type. virtio_pmem driver requires this special > flush function. For rest of the region types we are registe

Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-01-22 Thread Dan Williams
On Mon, Jan 21, 2019 at 7:27 PM Michael S. Tsirkin wrote: [..] > > 2. The reset of cases: > > - we will never pass the MAP_SYNC to mmap2 > > I don't see code probing for MAP_SYNC support. Did I miss it? > But if all you want is to have old linux ignore MAP_SYNC, > I think you got your wish a

Re: [PATCH] docs/cxl: Add serial number for persistent-memdev

2025-03-14 Thread Dan Williams
Jonathan Cameron wrote: > On Wed, 5 Mar 2025 18:35:40 +0800 > Yuquan Wang wrote: > > > > > > > On Tue, 4 Mar 2025 14:22:48 +0800 > > > Yuquan Wang wrote: > > > > > > > > > > > > > On Thu, Feb 20, 2025 at 04:12:13PM +, Jonathan Cameron wrote: > > > > > > On Mon, 17 Feb 2025 19:20:39

<    1   2