[PATCH] kvm/arm64: Fix memory section did not set to kvm

2022-03-18 Thread Cong Liu
on the arm64 platform, the PAGESIZE is 64k, the default qxl rom bar size is 8k(QXL_ROM_SZ), in the case memory size less than one page size, kvm_align_section return zero, the memory section did not commit kvm. Signed-off-by: Cong Liu --- accel/kvm/kvm-all.c | 1 + 1 file changed, 1 insertion

Re: [PATCH] kvm/arm64: Fix memory section did not set to kvm

2022-03-28 Thread Cong Liu
On 2022/3/25 23:00, Peter Maydell wrote: On Fri, 25 Mar 2022 at 14:42, wrote: I found this issue on qmeu 4.2 with host linux 4.19, I want to use qxl on arm64. on arm64, default page size is 64k, and the qxl_rom_size is fixed 8192. OK, so the fix to this is "use a newer QEMU". but when I

[PATCH] plugins/hotblocks: Fix potential deadlock in plugin_exit() function

2023-09-20 Thread Cong Liu
This patch fixes a potential deadlock in the plugin_exit() function of QEMU. The original code does not release the lock mutex if it is NULL. This patch adds a check for it being NULL and releases the mutex in that case. Signed-off-by: Cong Liu --- contrib/plugins/hotblocks.c | 2 ++ 1 file

[PATCH v2] plugins/hotblocks: Fix potential deadlock in plugin_exit() function

2023-09-21 Thread Cong Liu
This patch fixes a potential deadlock in the plugin_exit() function of QEMU. The original code does not release the lock mutex if it is NULL. This patch adds a check for it being NULL and releases the mutex in that case. Signed-off-by: Cong Liu Suggested-by: Philippe Mathieu-Daudé --- contrib

[PATCH] contrib/plugins: Close file descriptor on connect failure

2023-10-16 Thread Cong Liu
This patch closes the file descriptor fd on connect failure to avoid resource leak. Signed-off-by: Cong Liu --- contrib/plugins/lockstep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index f0cb8792c6fa..3c0f2b485181 100644 --- a

[PATCH v2] contrib/plugins: Close file descriptor on error return

2023-10-17 Thread Cong Liu
This patch closes the file descriptor fd on error return to avoid resource leak. Fixes: ec7ee95db909 ("contrib/plugins: fix coverity warning in lockstep") Signed-off-by: Cong Liu --- contrib/plugins/lockstep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/plugins/lo

[PATCH] virtio-gpu-rutabaga: Add empty interface to fix arm64 crash

2023-10-30 Thread Cong Liu
/runstate.c:817 10 0xab10d334 in qemu_init (argc=13, argv=0xf198) at ../system/vl.c:2760 11 0xaae4da6c in main (argc=, argv=) at ../system/main.c:47 Signed-off-by: Cong Liu Reviewed-by: Gurchetan Singh --- hw/display/virtio-gpu-pci-rutabaga.c | 1 + 1 file changed, 1

Re: [PATCH v11 04/10] virtio-gpu: Support asynchronous fencing

2025-04-10 Thread Cong Liu
I discovered that on an ARM64 environment, the 'virtio-gpu: Support asynchronous fencing' patch causes the virtual machine GUI to fail to display. Rolling back this patch and using virgl allows the virtual machine to start normally. When the VM screen is black, I can see some errors in QEMU. I u