Re: [Qemu-devel] [PATCH] hax: Honor CPUState::halted

2019-06-09 Thread Colin Xu
cc more. On 2019-06-10 10:19, Colin Xu wrote: QEMU tracks whether a vcpu is halted using CPUState::halted. E.g., after initialization or reset, halted is 0 for the BSP (vcpu 0) and 1 for the APs (vcpu 1, 2, ...). A halted vcpu should not be handed to the hypervisor to run (e.g. hax_vcpu_run

[Qemu-devel] [PATCH] hax: Honor CPUState::halted

2019-06-09 Thread Colin Xu
android emulator with Change-Id: I9c5752cc737fd305d7eace1768ea12a07309d716 Cc: Yu Ning Cc: Chuanxiao Dong Signed-off-by: Colin Xu --- cpus.c| 1 - target/i386/hax-all.c | 36 ++-- 2 files changed, 34 insertions(+), 3 deletions(-) diff --git a/cpus.c b/cpus.c index ffc57119ca5e..

[Qemu-devel] [PATCH] MAINTAINERS: Add entry for Guest X86 HAXM CPUs

2019-06-13 Thread Colin Xu
HAXM covers below files: include/sysemu/hax.h target/i386/hax-* Cc: Wenchao Wang Cc: Hang Yuan Signed-off-by: Colin Xu --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 588c8d947a08..fccae4e7de48 100644 --- a/MAINTAINERS +++ b

Re: [PATCH v2] [Qemu-devel] target/i386: HAX: Enable ROM/ROM device memory region support

2020-03-29 Thread Colin Xu
Looks good to me. Reviewed-by: Colin Xu On 2020-03-30 11:25, hang.y...@linux.intel.com wrote: From: Hang Yuan Add ROM and ROM device memory region support in HAX. Their memory region is read only and write access will generate EPT violation. The violation will be handled in the HAX kernel

Re: [PATCH] Add PAT, cr8 and EFER for 32-bit qemu to hax ioctl interface

2020-04-01 Thread Colin Xu
ruct vcpu_state_t {      uint32_t _activity_state;      uint32_t pad;      interruptibility_state_t _interruptibility_state; + +    uint64_t _cr8;  };  /* HAX exit status */ -- 2.15.0.windows.1 -- Best Regards, Colin Xu

Re: [PATCH V2] MAINTAINERS: Add entry for Guest X86 HAXM CPUs

2020-03-01 Thread Colin Xu
On 2020-02-28 19:00, Paolo Bonzini wrote: On 28/02/20 02:20, Colin Xu wrote: HAXM covers below files: include/sysemu/hax.h target/i386/hax-* V2: Add HAXM github page for wiki and issue tracking. Cc: Wenchao Wang Cc: Hang Yuan Reviewed-by: Hang Yuan Signed-off-by: Colin Xu

Re: [PATCH v2] [Qemu-devel] target/i386: HAX: Enable ROM/ROM device memory region support

2020-04-27 Thread Colin Xu
Hi Paolo, Would you please queue this one? -- Best Regards, Colin Xu On Mon, 30 Mar 2020, Colin Xu wrote: Looks good to me. Reviewed-by: Colin Xu On 2020-03-30 11:25, hang.y...@linux.intel.com wrote: From: Hang Yuan Add ROM and ROM device memory region support in HAX. Their memory

Re: [PATCH] hax: Add hax max vcpu IOCTL and support 64 vcpu

2020-04-27 Thread Colin Xu
Hi Paolo, Would you also help queue this one for PULL? -- Best Regards, Colin Xu On Mon, 20 Apr 2020, Colin Xu wrote: Looks good to me. Reviewed-by: Colin Xu -- Best Regards, Colin Xu On Fri, 10 Apr 2020, WangBowen wrote: This commit tried to obtain max vcpu of haxm driver by calling

Re: [PATCH] hax: Dynamic allocate vcpu state structure

2020-04-27 Thread Colin Xu
And this one. 3 patches for HAX. Thanks in advance. -- Best Regards, Colin Xu On Mon, 20 Apr 2020, Colin Xu wrote: Looks good to me. Reviewed-by: Colin Xu -- Best Regards, Colin Xu On Mon, 6 Apr 2020, WangBowen wrote: Dynamic allocating vcpu state structure according to smp value to

[Qemu-devel] [PATCH] ui: Correct icon install path

2019-06-24 Thread Colin Xu
The double slash in path will fail the installation on MINGW/MSYS. Fixes: a8260d387638 (ui: install logo icons to $prefix/share/icons) Signed-off-by: Colin Xu --- Makefile | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Makefile b/Makefile index

Re: [Qemu-devel] [PATCH] ui: Correct icon install path

2019-06-25 Thread Colin Xu
On 2019-06-25 18:43, Philippe Mathieu-Daudé wrote: Hi Colin, On 6/25/19 5:21 AM, Colin Xu wrote: The double slash in path will fail the installation on MINGW/MSYS. Fixes: a8260d387638 (ui: install logo icons to $prefix/share/icons) Signed-off-by: Colin Xu --- Makefile | 16

Re: [Qemu-devel] [PATCH] ui: Correct icon install path

2019-06-25 Thread Colin Xu
On 2019-06-25 21:40, Eric Blake wrote: On 6/25/19 5:42 AM, Daniel P. Berrangé wrote: On Tue, Jun 25, 2019 at 11:21:42AM +0800, Colin Xu wrote: The double slash in path will fail the installation on MINGW/MSYS. Fixes: a8260d387638 (ui: install logo icons to $prefix/share/icons) Signed-off-by

Re: [PATCH] hax: Dynamic allocate vcpu state structure

2020-04-19 Thread Colin Xu
Looks good to me. Reviewed-by: Colin Xu -- Best Regards, Colin Xu On Mon, 6 Apr 2020, WangBowen wrote: Dynamic allocating vcpu state structure according to smp value to be more precise and safe. Previously it will alloccate array of fixed size HAX_MAX_VCPU. This is achieved by using

Re: [PATCH] hax: Add hax max vcpu IOCTL and support 64 vcpu

2020-04-19 Thread Colin Xu
Looks good to me. Reviewed-by: Colin Xu -- Best Regards, Colin Xu On Fri, 10 Apr 2020, WangBowen wrote: This commit tried to obtain max vcpu of haxm driver by calling HAX_IOCTL_CAP_MAX_VCPU before creating the vm so that if using hax as the accelerator and the smp value is larger than the

Re: [PATCH 1/2] hax: Fix setting of FD_CLOEXEC

2020-04-20 Thread Colin Xu
Looks good to me. Reviewed-by: Colin Xu -- Best Regards, Colin Xu On Tue, 21 Apr 2020, Eric Blake wrote: Blindly setting FD_CLOEXEC without a read-modify-write will inadvertently clear any other intentionally-set bits, such as a proposed new bit for designating a fd that must behave in 32

[PATCH V2] hax: Dynamic allocate vcpu state structure

2020-05-08 Thread Colin Xu
, the process will terminate, otherwise it will allocate array of size smp to store the status. V2: Check max_cpus before open vm. (Philippe) Signed-off-by: WangBowen Signed-off-by: Colin Xu --- target/i386/hax-all.c | 25 +++-- target/i386/hax-i386.h | 5 +++-- 2 files

Re: [PATCH V2] hax: Dynamic allocate vcpu state structure

2020-05-08 Thread Colin Xu
Bowen is no longer working on the project so continue the revising. Sorry for the delayed reply. On 2020-05-09 11:59, Colin Xu wrote: From: WangBowen Dynamic allocating vcpu state structure according to smp value to be more precise and safe. Previously it will alloccate array of fixed size

Re: [PULL 09/61] MAINTAINERS: Add entry for Guest X86 HAXM CPUs

2020-03-17 Thread Colin Xu
Hi Paolo, For future HAX patch, once it's "Reviewed-by" haxm maintainers and other reviewers, do we need "SubmitAPullRequest" separately or you will do it together with other patches? Colin On 2020-03-17 05:26, Paolo Bonzini wrote: From: Colin Xu HAXM covers be

Re: [PULL 09/61] MAINTAINERS: Add entry for Guest X86 HAXM CPUs

2020-03-17 Thread Colin Xu
On 2020-03-17 16:26, Paolo Bonzini wrote: On 17/03/20 08:46, Colin Xu wrote: Hi Paolo, For future HAX patch, once it's "Reviewed-by" haxm maintainers and other reviewers, do we need "SubmitAPullRequest" separately or you will do it together with other patches? A

Re: [PULL 09/61] MAINTAINERS: Add entry for Guest X86 HAXM CPUs

2020-03-17 Thread Colin Xu
On 2020-03-17 18:27, Paolo Bonzini wrote: On 17/03/20 09:55, Colin Xu wrote: On 2020-03-17 16:26, Paolo Bonzini wrote: On 17/03/20 08:46, Colin Xu wrote: Hi Paolo, For future HAX patch, once it's "Reviewed-by" haxm maintainers and other reviewers, do we need "SubmitAPul

[PATCH] MAINTAINERS: Add entry for Guest X86 HAXM CPUs

2020-02-25 Thread Colin Xu
HAXM covers below files: include/sysemu/hax.h target/i386/hax-* Cc: Wenchao Wang Cc: Hang Yuan Signed-off-by: Colin Xu --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 36d94c17a654..27727e2fac13 100644 --- a/MAINTAINERS +++ b

Re: [PATCH] MAINTAINERS: Add entry for Guest X86 HAXM CPUs

2020-02-27 Thread Colin Xu
On 2020-02-27 16:00, Philippe Mathieu-Daudé wrote: On 2/27/20 8:56 AM, Philippe Mathieu-Daudé wrote: Cc'ing qemu-trivial@ On 2/26/20 5:32 AM, Colin Xu wrote: HAXM covers below files: include/sysemu/hax.h target/i386/hax-* Cc: Wenchao Wang Cc: Hang Yuan Signed-off-by: Colin Xu P

[PATCH V2] MAINTAINERS: Add entry for Guest X86 HAXM CPUs

2020-02-27 Thread Colin Xu
HAXM covers below files: include/sysemu/hax.h target/i386/hax-* V2: Add HAXM github page for wiki and issue tracking. Cc: Wenchao Wang Cc: Hang Yuan Reviewed-by: Hang Yuan Signed-off-by: Colin Xu --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b

[PATCH] input-linux: Reset il->fd handler before closing it

2020-09-24 Thread Colin Xu
If object-del input-linux object on-the-fly, instance finalize will close evdev fd without resetting it. However the main thread is still trying to lock_acquire/lock_release during ppoll, which leads to a very high CPU utilization. Signed-off-by: Colin Xu --- ui/input-linux.c | 1 + 1 file