Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-29 Thread BrillyWu
Hi, Jan > > > @@ -855,6 +870,8 @@ int cpu_x86_register (CPUX86State *env, > > env->cpuid_xlevel = def->xlevel; > > env->cpuid_kvm_features = def->kvm_features; > > env->cpuid_svm_features = def->svm_features; > > +env->cpuid_ext4_features = def->ext4_features; > > +env->cpui

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-30 Thread BrillyWu
From: BrillyWu Hi, Jan I'm very sorry for these bugs in the patch. Now I have made a new patch based on the newest uq/master where the patch has been applied to fix these bugs, is it feasible? If it is not acceptable, should I re-generate a patch based on previous uq/master, or

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-30 Thread BrillyWu
>From brill...@viatech.com.cn Hi, Jan Thank you for you review and guide. I have fixed the bugs and re-generated a clean patch which has been checked. It can be compiled without any error and work normally. The patch v3 is here now. Signed-off-by: BrillyWu Signed-off

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-30 Thread BrillyWu
Hi, Jan > patch which has > > been checked. It can be compiled without any error and work > normally. > > The patch v3 is here now. > > The above text can't be used as a commit log, so this needs to be > fixed. > Moreover, your patch still contains at least on style issues > scripts/checkp

[Qemu-devel] [PATCH uq/master V3] kvm: Add CPUID support for VIA CPU

2011-05-30 Thread BrillyWu
From: brill...@viatech.com.cn When KVM is running on VIA CPU with host cpu's model, the feautures of VIA CPU will be passed into kvm guest by calling the CPUID instruction for Centaur. Signed-off-by: BrillyWu Signed-off-by: KaryJin --- target-i386/cpu.h |7 +++ target-i386/cp

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-31 Thread BrillyWu
Hi, Jan > > I am sure I have checked it with the scripts/checkpatch.pl, and it > > shows no error or warning. Maybe I should check whether my windows > > editor and mail client can work well before sending it to > you. I 'm > > sorry. > > Sorry, you are right. Your patch revealed a bug in the che

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-31 Thread BrillyWu
> >> Blue, this does not trigger the missing braces warning: > > > > Do you mean the bug is that it can not trigger missing > braces warining? > > The script fails to detect missing braces as marked below. > > > It seems that there is no missing braces in my patch, but some > > unnecessary braces.

Re: [Qemu-devel] [PATCH uq/master V3] kvm: Add CPUID support for VIA CPU

2011-05-31 Thread BrillyWu
From: brill...@viatech.com.cn When KVM is running on VIA CPU with host cpu's model, the feautures of VIA CPU will be passed into kvm guest by calling the CPUID instruction for Centaur. Signed-off-by: BrillyWu Signed-off-by: KaryJin --- target-i386/cpu.h |7 target-i386/cpuid.c |

[Qemu-devel] [PATCH] qemu-kvm: Add CPUID support for VIA CPU

2011-05-04 Thread BrillyWu
When KVM is running on VIA CPU with host cpu's model, the feautures of VIA CPU will be passed into kvm guest by calling the CPUID instruction for Centaur. Signed-off-by: BrillyWu Signed-off-by: KaryJin --- target-i386/cpu.h |7 +++ target-i386/cpuid.c |

Re: [Qemu-devel] [PATCH] qemu-kvm: Add CPUID support for VIA CPU

2011-05-05 Thread BrillyWu
autures of > > VIA CPU will be passed into kvm guest by calling the CPUID > instruction > > for Centaur. > > > > Signed-off-by: BrillyWu > > Signed-off-by: KaryJin > > --- > > target-i386/cpu.h |7 +++ > > target-i386/cpuid.c | 48 >

Re: [Qemu-devel] [PATCH] qemu-kvm: Add CPUID support for VIA CPU

2011-05-06 Thread BrillyWu
el, the > >> feautures of > >>> VIA CPU will be passed into kvm guest by calling the CPUID > >> instruction > >>> for Centaur. > >>> > >>> Signed-off-by: BrillyWu > >>> Signed-off-by: KaryJin > >>> --- > >>&

Re: [Qemu-devel] [PATCH] qemu-kvm: Add CPUID support for VIA CPU

2011-05-08 Thread BrillyWu
> > I have submit a patch into upstream's KVM for supporting > these features before, and the patch has been applied in kvm-git. > > As far as I can see, nothing has been applied to any tree, neither > qemu.git nor qemu-kvm.git. Sorry, I have submit to kvm.git, not qemu.git or qemu-kvm.git. > >

[Qemu-devel] [PATCH uq/master] kvm: Add CPUID support for VIA CPU

2011-05-08 Thread BrillyWu
When KVM is running on VIA CPU with host cpu's model, the feautures of VIA CPU will be passed into kvm guest by calling the CPUID instruction for Centaur. Signed-off-by: BrillyWu Signed-off-by: KaryJin --- target-i386/cpu.h |3 +++ target-i386/cpuid.c |

[Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-10 Thread BrillyWu
From: BrillyWu When KVM is running on VIA CPU with host cpu's model, the feautures of VIA CPU will be passed into kvm guest by calling the CPUID instruction for Centaur. Signed-off-by: BrillyWu Signed-off-by: KaryJin --- target-i386/cpu.h |3 +++ target-i386/cpuid.c |

Re: [Qemu-devel] [PATCH uq/master] kvm: Add CPUID support for VIA CPU

2011-05-10 Thread BrillyWu
g the CPUID instruction > for Centaur. > > Signed-off-by: BrillyWu > Signed-off-by: KaryJin > --- > target-i386/cpu.h |3 +++ > target-i386/cpuid.c | 46 > +- Still line-wrapped. If your Exchange is unfixable, use a diffe