Re: [Qemu-devel] [PATCH for-2.7] pc-bios/optionrom: Fix OpenBSD build with better detection of linker emulation

2016-08-10 Thread Brad Smith
On 08/08/16 12:11, Peter Maydell wrote: The various host OSes are irritatingly variable about the name of the linker emulation we need to pass to ld's -m option to build the i386 option ROMs. Instead of doing this via a CONFIG ifdef, check in configure whether any of the emulation names we know a

[Qemu-devel] [Bug 1613133] [NEW] SLIRP code regression fails to build on OpenBSD

2016-08-14 Thread Brad Smith
Public bug reported: The SLIRP code has regressed between 2.6 and 2.7 and now fails to build on OpenBSD. cc -I/home/ports/pobj/qemu-2.7.0-rc2/qemu-2.7.0-rc2/tcg -I/home/ports/pobj/qemu-2.7.0-rc2/qemu-2.7.0-rc2/tcg/i386 -I. -I/home/ports/pobj/qemu-2.7.0-rc2/qemu-2.7.0-rc2 -I/home/ports/pobj/ qem

Re: [Qemu-devel] [PATCH for-2.7] pc-bios/optionrom: Fix OpenBSD build with better detection of linker emulation

2016-08-15 Thread Brad Smith
On 8/15/2016 1:26 PM, Peter Maydell wrote: On 8 August 2016 at 17:11, Peter Maydell wrote: The various host OSes are irritatingly variable about the name of the linker emulation we need to pass to ld's -m option to build the i386 option ROMs. Instead of doing this via a CONFIG ifdef, check in

Re: [Qemu-devel] [PATCH for-2.7] slirp: Rename "struct arphdr" to "struct slirp_arphdr"

2016-08-15 Thread Brad Smith
On 08/15/16 04:24, Thomas Huth wrote: struct arphdr is already used by the system headers on OpenBSD and thus QEMU does not compile here anymore. Fix it by renaming our struct to slirp_arphdr instead. Reported-by: Brad Smith Buglink: https://bugs.launchpad.net/qemu/+bug/1613133 Signed-off-by

Re: [Qemu-devel] [PATCH] configure: pick the right compiler for OpenBSD by default

2017-10-16 Thread Brad Smith
On 10/13/2017 12:14 PM, Peter Maydell wrote: On 13 October 2017 at 12:46, Thomas Huth wrote: I disagree. If the next OpenBSD release uses Clang by default, we're not building QEMU there with the *working default* C compiler anymore. You're then rather forcing the OpenBSD users then to install

[Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-11-26 Thread Brad Smith
Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* constants. Signed-off-by: Brad Smith diff --git a/configure b/configure index 0c6e7572db..9715b9c2cc 100755 --- a/configure +++ b/configure @@ -3186,7

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-11-27 Thread Brad Smith
On 11/27/2017 7:02 AM, Peter Maydell wrote: On 26 November 2017 at 22:13, Brad Smith wrote: Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* constants. ncurses 5.7 was released in 2008 and is now 9

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-11-27 Thread Brad Smith
On 11/27/17 07:02, Peter Maydell wrote: On 26 November 2017 at 22:13, Brad Smith wrote: Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* constants. ncurses 5.7 was released in 2008 and is now 9

Re: [Qemu-devel] [PATCH v3] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

2018-11-05 Thread Brad Smith
ping. On 10/19/2018 8:52 AM, Brad Smith wrote: Use MAP_STACK in qemu_alloc_stack() on OpenBSD. Added to our 6.4 release. MAP_STACK Indicate that the mapping is used as a stack. This flag must be used in combination with MAP_ANON and MAP_PRIVATE

Re: [Qemu-devel] [PATCH v4] tests: vm: auto_install OpenBSD

2018-11-11 Thread Brad Smith
ping. On 10/30/2018 10:57 PM, Fam Zheng wrote: Upgrade OpenBSD to 6.4 using auto_install. Especially, drop SDL1, include SDL2. Also do the build in $HOME since both /var/tmp and /tmp are tmpfs with limited capacities. Signed-off-by: Fam Zheng --- v4: Use 6.4. [Brad] --- tests/vm/basevm.py

Re: [Qemu-devel] [PATCH] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

2018-10-09 Thread Brad Smith
On Tue, Oct 09, 2018 at 03:52:30PM +0200, Kamil Rytarowski wrote: > On 07.10.2018 17:37, Brad Smith wrote: > > Use MAP_STACK in qemu_alloc_stack() on OpenBSD. > > > > Added to -current and will be in our soon to be 6.4 release. > > > > MAP_STACK Indicate th

Re: [Qemu-devel] OpenBSD with VirtIO networking causes QEMU to crash

2018-10-10 Thread Brad Smith
On 10/9/2018 2:42 PM, viq wrote: (please CC me as I'm not subscribed to the list) I verified the behaviour on two different machines, both running archlinux with QEMU 3.0.0 and reported it on https://bugs.archlinux.org/task/60141 where it was suggested I bring it to the list. So what happens: i

Re: [Qemu-devel] OpenBSD with VirtIO networking causes QEMU to crash

2018-10-10 Thread Brad Smith
On 10/10/2018 8:29 AM, viq wrote: On Wed, Oct 10, 2018 at 1:54 PM Brad Smith <mailto:b...@comstyle.com>> wrote: On 10/9/2018 2:42 PM, viq wrote: > (please CC me as I'm not subscribed to the list) > I verified the behaviour on two different machines, both r

Re: [Qemu-devel] [PATCH] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

2018-10-10 Thread Brad Smith
On 10/9/2018 11:04 AM, Kamil Rytarowski wrote: On 09.10.2018 16:12, Peter Maydell wrote: On 9 October 2018 at 14:52, Kamil Rytarowski wrote: On 07.10.2018 17:37, Brad Smith wrote: Use MAP_STACK in qemu_alloc_stack() on OpenBSD. Added to -current and will be in our soon to be 6.4 release

Re: [Qemu-devel] [PATCH] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

2018-10-11 Thread Brad Smith
On 10/11/2018 5:41 AM, Kamil Rytarowski wrote: On 11.10.2018 11:36, Peter Maydell wrote: On 11 October 2018 at 00:55, Brad Smith wrote: And from FreeBSD... MAP_STACK MAP_STACK implies MAP_ANON, and offset of 0. The fd argument must be -1 and prot must include at least PROT_READ and

Re: [Qemu-devel] [PATCH] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

2018-10-11 Thread Brad Smith
On Thu, Oct 11, 2018 at 09:31:23PM +0200, Kamil Rytarowski wrote: > On 11.10.2018 16:25, Brad Smith wrote: > > On 10/11/2018 5:41 AM, Kamil Rytarowski wrote: > > > >> On 11.10.2018 11:36, Peter Maydell wrote: > >>> On 11 October 2018 at 00:55, Brad S

[Qemu-devel] [PATCH v2] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

2018-10-18 Thread Brad Smith
only be set/cleared by mmap(), which zeroes the contents of the region -- there is no mprotect() equivalent operation, so there is no MAP_STACK-adding gadget. Signed-off-by: Brad Smith Reviewed-by: Kamil Rytarowski diff --git a/util/oslib-posix.c b/util/oslib-posix.c index fbd0dc8c57

[Qemu-devel] [PATCH v3] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

2018-10-19 Thread Brad Smith
(), which zeroes the contents of the region -- there is no mprotect() equivalent operation, so there is no MAP_STACK-adding gadget. Signed-off-by: Brad Smith Reviewed-by: Kamil Rytarowski Reviewed-by: Peter Maydell diff --git a/util/oslib-posix.c b/util/oslib-posix.c index fbd0dc8c57..c1bee2a581

Re: [Qemu-devel] [PATCH v2] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

2018-10-19 Thread Brad Smith
On 10/19/2018 7:55 AM, Peter Maydell wrote: On 18 October 2018 at 23:10, Brad Smith wrote: Use MAP_STACK in qemu_alloc_stack() on OpenBSD. Added to -current and will be in our soon to be 6.4 release. MAP_STACK Indicate that the mapping is used as a stack. This flag

[Qemu-devel] [PATCH] oslib-posix: Use MAP_STACK in qemu_alloc_stack() on OpenBSD

2018-10-07 Thread Brad Smith
only be set/cleared by mmap(), which zeroes the contents of the region -- there is no mprotect() equivalent operation, so there is no MAP_STACK-adding gadget. Signed-off-by: Brad Smith diff --git a/util/oslib-posix.c b/util/oslib-posix.c index fbd0dc8c57..51e9a012c2 100644 --- a/util/oslib

Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

2018-08-24 Thread Brad Smith
I very much appreciate the effort to bump up to 6.3 as I was going to suggest doing that at some point. But bumping up to 6.3 at the moment will fail with the configure script. We've switched from GCC 4.2 to Clang. The TLS check will fail with Clang's emulated TLS. We've had a local patch for awhi

Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

2018-08-24 Thread Brad Smith
On 8/24/2018 10:46 AM, Peter Maydell wrote: On 24 August 2018 at 15:43, Daniel P. Berrangé wrote: On Fri, Aug 24, 2018 at 10:36:30AM -0400, Brad Smith wrote: I very much appreciate the effort to bump up to 6.3 as I was going to suggest doing that at some point. But bumping up to 6.3 at the

Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

2018-08-27 Thread Brad Smith
On 8/27/2018 5:18 AM, Fam Zheng wrote: On Fri, 08/24 10:36, Brad Smith wrote: I very much appreciate the effort to bump up to 6.3 as I was going to suggest doing that at some point. But bumping up to 6.3 at the moment will fail with the configure script. We've switched from GCC 4.2 to

Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

2018-09-05 Thread Brad Smith
On 8/27/2018 5:05 AM, Gerd Hoffmann wrote: On Fri, Aug 24, 2018 at 10:36:30AM -0400, Brad Smith wrote: I very much appreciate the effort to bump up to 6.3 as I was going to suggest doing that at some point. But bumping up to 6.3 at the moment will fail with the configure script. We've swi

Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

2018-09-05 Thread Brad Smith
On 8/27/2018 5:18 AM, Fam Zheng wrote: On Fri, 08/24 10:36, Brad Smith wrote: I very much appreciate the effort to bump up to 6.3 as I was going to suggest doing that at some point. But bumping up to 6.3 at the moment will fail with the configure script. We've switched from GCC 4.2 to

[Qemu-devel] [Bug 902720] Re: TIME_MAX not set correctly for OpenBSD in qemu-common.h

2017-10-28 Thread Brad Smith
Since this bug report was filed OpenBSD has switched from 32-bit time_t to 64-bit time_t on all archs (yes, including 32-bit archs like i386, arm, powerpc). So instead of INT_MAX TIME_MAX should now be set to LLONG_MAX. -- You received this bug notification because you are a member of qemu- devel

[Qemu-devel] [PATCH] tap-bsd: OpenBSD uses tap(4) now

2016-09-25 Thread Brad Smith
Update the tap-bsd code now that OpenBSD uses tap(4). Signed-off-by: Brad Smith diff --git a/net/tap-bsd.c b/net/tap-bsd.c index c506ac3..8d0f049 100644 --- a/net/tap-bsd.c +++ b/net/tap-bsd.c @@ -55,11 +55,7 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr, if (*ifname

[Qemu-devel] [PATCH] configure: Deal with OpenBSD/i386 emulation linker

2017-11-05 Thread Brad Smith
OpenBSD/i386 uses elf_i386_obsd for the emulation linker. Signed-off-by: Brad Smith diff --git a/configure b/configure index dd73cce62f..02799d38ac 100755 --- a/configure +++ b/configure @@ -5159,9 +5159,9 @@ if test \( "$cpu" = "i386" -o "$cpu" = "

[Qemu-devel] [PATCH] osdep: Deal with TIME_MAX and OpenBSD 64-bit time_t

2017-11-05 Thread Brad Smith
Define TIME_MAX to LLONG_MAX for OpenBSD since OpenBSD uses 64-bit time_t. Signed-off-by: Brad Smith diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 6855b94bbf..824714049b 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -132,8 +132,12 @@ extern int daemon(int

[Qemu-devel] [PATCH v2] configure: Deal with OpenBSD/i386 emulation linker

2017-11-07 Thread Brad Smith
OpenBSD/i386 uses elf_i386_obsd for the emulation linker. Signed-off-by: Brad Smith diff --git a/configure b/configure index dd73cce62f..c9dd747283 100755 --- a/configure +++ b/configure @@ -5159,9 +5159,9 @@ if test \( "$cpu" = "i386" -o "$cpu" = "

Re: [Qemu-devel] [PATCH] configure: Deal with OpenBSD/i386 emulation linker

2017-11-07 Thread Brad Smith
On Mon, Nov 06, 2017 at 11:37:45AM +, Peter Maydell wrote: > On 6 November 2017 at 00:53, Brad Smith wrote: > > OpenBSD/i386 uses elf_i386_obsd for the emulation linker. > > > > Signed-off-by: Brad Smith > > > > > > diff --git a/configure b/configure

[Qemu-devel] [PATCH] maintainers: Add myself as a OpenBSD maintainer

2018-02-16 Thread Brad Smith
Add myself as an OpenBSD maintainer and add OpenBSD as maintained. Signed-off-by: Brad Smith diff --git a/MAINTAINERS b/MAINTAINERS index 57358a08e2..86329e274f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -386,6 +386,12 @@ M: Kamil Rytarowski S: Maintained K: ^Subject:.*(?i)NetBSD

[PATCH] util/cpuinfo: Make use of elf_aux_info(3) on OpenBSD

2024-07-27 Thread Brad Smith
util/cpuinfo: Make use of elf_aux_info(3) on OpenBSD Signed-off-by: Brad Smith --- meson.build| 8 util/cpuinfo-aarch64.c | 9 ++--- util/cpuinfo-ppc.c | 5 +++-- util/getauxval.c | 2 +- 4 files changed, 18 insertions(+), 6 deletions(-) diff --git a

[PATCH] audio: Add sndio backend

2020-03-04 Thread Brad Smith
Add a sndio backend. sndio is the native API used by OpenBSD, although it has been ported to other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.). The C code is from Alexandre Ratchov and the rest of the bits are from me. Signed-off-by: Alexandre Ratchov Signed-off-by:

Re: [PATCH] audio: Add sndio backend

2020-03-05 Thread Brad Smith
On 3/5/2020 3:50 AM, Gerd Hoffmann wrote: On Wed, Mar 04, 2020 at 07:04:07AM -0800, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200304145003.gb15...@humpty.home.comstyle.com/ Hi, This series seems to have some coding style problems. See output below for more informa

Re: [PULL 147/150] meson: convert po/

2020-08-18 Thread Brad Smith
On 8/18/2020 10:10 AM, Paolo Bonzini wrote: From: Marc-André Lureau Meson warns if xgettext is not found. In the future we may want to add a required argument to i18n.gettext(); in the meanwhile, I am adding a --enable-gettext/--disable-gettext option and feature detection in configure. This

Re: [PULL 147/150] meson: convert po/

2020-08-19 Thread Brad Smith
If you're in need of the tools then the package name needs to be gettext-tools. On August 19, 2020 4:06:32 a.m. Paolo Bonzini wrote: On 19/08/20 03:56, Brad Smith wrote: This last part is redundant. If glib2 and/or gtk+3 is installed then gettext is installed. The package name is wro

Re: [PATCH] util: qemu_get_thread_id for OpenBSD

2020-07-15 Thread Brad Smith
homas. Reviewed-by: Brad Smith

[PATCH] tap-bsd: Remove special casing for older OpenBSD releases

2021-03-26 Thread Brad Smith
OpenBSD added support for tap(4) 10 releases ago. Remove the special casing for older releases. Signed-off-by: Brad Smith diff --git a/net/tap-bsd.c b/net/tap-bsd.c index 77aaf674b1..59dfcdfae0 100644 --- a/net/tap-bsd.c +++ b/net/tap-bsd.c @@ -35,10 +35,6 @@ #include #endif -#if defined

Re: [PATCH] tap-bsd: Remove special casing for older OpenBSD releases

2021-03-28 Thread Brad Smith
It very much is correct. We don't care about such releases anymore. On March 28, 2021 10:24:51 p.m. Jason Wang wrote: 在 2021/3/27 上午7:49, Brad Smith 写道: OpenBSD added support for tap(4) 10 releases ago. Remove the special casing for older releases. Signed-off-by: Brad Smith diff --

Re: [PATCH] tap-bsd: Remove special casing for older OpenBSD releases

2021-03-29 Thread Brad Smith
On 3/28/2021 11:58 PM, Jason Wang wrote: 在 2021/3/29 上午11:03, Brad Smith 写道: It very much is correct. We don't care about such releases anymore. So is there a doc/wiki to say Qemu doesn't support those OpenBSD release? The (OpenBSD itself and QEMU) project only makes a concer

Re: [PATCH] migration: Remove time_t cast for OpenBSD

2021-03-31 Thread Brad Smith
On 3/13/2021 6:33 PM, Brad Smith wrote: On 3/11/2021 1:39 PM, Daniel P. Berrangé wrote: On Thu, Mar 11, 2021 at 06:28:57PM +, Dr. David Alan Gilbert wrote: * Laurent Vivier (laur...@vivier.eu) wrote: Le 08/03/2021 à 12:46, Thomas Huth a écrit : On 22/02/2021 08.28, Brad Smith wrote

Re: [PATCH] migration: Remove time_t cast for OpenBSD

2021-04-01 Thread Brad Smith
On 4/1/2021 4:14 AM, Daniel P. Berrangé wrote: On Wed, Mar 31, 2021 at 03:26:16PM -0400, Brad Smith wrote: On 3/13/2021 6:33 PM, Brad Smith wrote: On 3/11/2021 1:39 PM, Daniel P. Berrangé wrote: On Thu, Mar 11, 2021 at 06:28:57PM +, Dr. David Alan Gilbert wrote: * Laurent Vivier (laur

[PATCH] oslib-posix: Remove OpenBSD workaround for fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure

2021-04-01 Thread Brad Smith
OpenBSD prior to 6.3 required a workaround to utilize fcntl(F_SETFL) on memory devices. Since modern verions of OpenBSD that are only officialy supported and buildable on do not have this issue I am garbage collecting this workaround. Signed-off-by: Brad Smith diff --git a/util/oslib-posix.c

Re: [PATCH] migration: Remove time_t cast for OpenBSD

2021-03-13 Thread Brad Smith
On 3/11/2021 1:39 PM, Daniel P. Berrangé wrote: On Thu, Mar 11, 2021 at 06:28:57PM +, Dr. David Alan Gilbert wrote: * Laurent Vivier (laur...@vivier.eu) wrote: Le 08/03/2021 à 12:46, Thomas Huth a écrit : On 22/02/2021 08.28, Brad Smith wrote: OpenBSD has supported 64-bit time_t across

Re: [PATCH] tcg/ppc: Fix building with Clang

2021-05-27 Thread Brad Smith
On 5/2/2021 12:02 AM, Brad Smith wrote: On 4/22/2021 11:39 AM, Richard Henderson wrote: On 4/22/21 2:20 AM, Peter Maydell wrote: On Thu, 22 Apr 2021 at 06:18, Richard Henderson I'm thinking something like #if !defined(_CALL_SYSV) && \   !defined(_CALL_DARWIN) &&

Re: [PATCH] oslib-posix: Remove OpenBSD workaround for fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure

2021-05-30 Thread Brad Smith
ping. On 4/1/2021 1:34 PM, Brad Smith wrote: OpenBSD prior to 6.3 required a workaround to utilize fcntl(F_SETFL) on memory devices. Since modern verions of OpenBSD that are only officialy supported and buildable on do not have this issue I am garbage collecting this workaround. Signed-off

[PATCH] tests/vm: update openbsd to release 6.9

2021-05-30 Thread Brad Smith
tests/vm: update openbsd to release 6.9 Signed-off-by: Brad Smith --- tests/vm/openbsd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index 4d1399378e..c4c78a80f1 100755 --- a/tests/vm/openbsd +++ b/tests/vm/openbsd @@ -22,8 +22,8

[PATCH] tests/vm: update NetBSD to 9.2

2021-06-02 Thread Brad Smith
tests/vm: update NetBSD to 9.2 Signed-off-by: Brad Smith --- tests/vm/netbsd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vm/netbsd b/tests/vm/netbsd index b9efc269d2..4cc58df130 100755 --- a/tests/vm/netbsd +++ b/tests/vm/netbsd @@ -22,8 +22,8 @@ class NetBSDVM

Re: [PATCH] migration: Remove time_t cast for OpenBSD

2021-03-09 Thread Brad Smith
On 3/8/2021 6:46 AM, Thomas Huth wrote: On 22/02/2021 08.28, Brad Smith wrote: OpenBSD has supported 64-bit time_t across all archs since 5.5 released in 2014. Remove a time_t cast that is no longer necessary. Signed-off-by: Brad Smith diff --git a/migration/savevm.c b/migration/savevm.c

tcg/ppc: Fix building with Clang

2021-04-20 Thread Brad Smith
OpenBSD/powerpc. Signed-off-by: Brad Smith diff --git a/tcg/ppc/tcg-target.c.inc b/tcg/ppc/tcg-target.c.inc index 838ccfa42d..d2611832e5 100644 --- a/tcg/ppc/tcg-target.c.inc +++ b/tcg/ppc/tcg-target.c.inc @@ -25,6 +25,11 @@ #include "elf.h" #include "../tcg-pool.c.inc" +/* C

[PATCH] tcg/ppc: Fix building with Clang

2021-04-20 Thread Brad Smith
OpenBSD/powerpc. Signed-off-by: Brad Smith diff --git a/tcg/ppc/tcg-target.c.inc b/tcg/ppc/tcg-target.c.inc index 838ccfa42d..d2611832e5 100644 --- a/tcg/ppc/tcg-target.c.inc +++ b/tcg/ppc/tcg-target.c.inc @@ -25,6 +25,11 @@ #include "elf.h" #include "../tcg-pool.c.inc" +/* C

Re: [PATCH] tcg/ppc: Fix building with Clang

2021-05-01 Thread Brad Smith
On 4/22/2021 11:39 AM, Richard Henderson wrote: On 4/22/21 2:20 AM, Peter Maydell wrote: On Thu, 22 Apr 2021 at 06:18, Richard Henderson I'm thinking something like #if !defined(_CALL_SYSV) && \   !defined(_CALL_DARWIN) && \   !defined(_CALL_AIX) && \   !defined(_CALL_ELF) # if def

Re: [PATCH] oslib-posix: Remove OpenBSD workaround for fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure

2021-05-01 Thread Brad Smith
ping. On 4/1/2021 1:34 PM, Brad Smith wrote: OpenBSD prior to 6.3 required a workaround to utilize fcntl(F_SETFL) on memory devices. Since modern verions of OpenBSD that are only officialy supported and buildable on do not have this issue I am garbage collecting this workaround. Signed-off

Re: [PATCH] tap-bsd: Remove special casing for older OpenBSD releases

2021-05-01 Thread Brad Smith
On 4/1/2021 3:24 AM, Jason Wang wrote: 在 2021/3/30 上午4:38, Brad Smith 写道: On 3/28/2021 11:58 PM, Jason Wang wrote: 在 2021/3/29 上午11:03, Brad Smith 写道: It very much is correct. We don't care about such releases anymore. So is there a doc/wiki to say Qemu doesn't support tho

[PATCH] migration: Remove time_t cast for OpenBSD

2021-02-21 Thread Brad Smith
OpenBSD has supported 64-bit time_t across all archs since 5.5 released in 2014. Remove a time_t cast that is no longer necessary. Signed-off-by: Brad Smith diff --git a/migration/savevm.c b/migration/savevm.c index 52e2d72e4b..9557f85ba9 100644 --- a/migration/savevm.c +++ b/migration

[PATCH] tests/vm: update openbsd to release 6.8

2020-10-26 Thread Brad Smith
tests/vm: update openbsd to release 6.8 A double dash at the end of a package name removes ambiguity when the intent is to install a non-FLAVORed package. Signed-off-by: Brad Smith Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daud?? diff --git a/tests

Re: [PATCH] tests/vm: update openbsd to release 6.8

2020-10-27 Thread Brad Smith
On Tue, Oct 27, 2020 at 11:05:20AM +0100, Philippe Mathieu-Daud?? wrote: > On 10/27/20 6:30 AM, Brad Smith wrote: > > tests/vm: update openbsd to release 6.8 > > > > A double dash at the end of a package name removes ambiguity > > when the intent is to ins

Re: [PATCH] tests/vm: update openbsd to release 6.6

2019-11-13 Thread Brad Smith
Thanks. Reviewed-by: Brad Smith On 10/18/2019 6:24 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- tests/vm/openbsd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index b92c39f89a6f..9f82cd459fde 100755 --- a/tests/vm

Re: [PATCH] tests/vm: update openbsd to release 6.6

2019-12-19 Thread Brad Smith
ping. On 11/13/2019 10:33 PM, Brad Smith wrote: Thanks. Reviewed-by: Brad Smith On 10/18/2019 6:24 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- tests/vm/openbsd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index

Re: [PATCH] meson.build: Support ncurses on MacOS

2021-06-12 Thread Brad Smith
This same problem also applies to OpenBSD as we have the same version of ncurses with support for wide characters. I have a similar patch in our QEMU port. On 6/12/2021 4:03 AM, Stefan Weil wrote: MacOS provides header files for curses 5.7 with support for wide characters, but requires _XOPEN_SO

Re: [PATCH 00/11] Fixes for clang-13 plus tcg/ppc

2021-08-13 Thread Brad Smith
used. But please double-check. r~ Cc: Alex Bennée Cc: Brad Smith Cc: David Gibson Cc: Eric Blake Cc: Gerd Hoffmann Cc: Greg Kurz Cc: Jason Wang Cc: Laurent Vivier Cc: qemu-bl...@nongnu.org Cc: qemu-...@nongnu.org Cc: Vladimir Sementsov-Ogievskiy Richard Henderson (11): nbd/serv

Re: [PATCH] meson.build: Support ncurses on MacOS

2021-06-14 Thread Brad Smith
On 6/14/2021 1:45 AM, Philippe Mathieu-Daudé wrote: On 6/13/21 8:33 AM, Stefan Weil wrote: Am 13.06.21 um 03:40 schrieb Brad Smith: This same problem also applies to OpenBSD as we have the same version of ncurses with support for wide characters. I have a similar patch in our QEMU port

Re: Rust in Qemu BoF followup: Rust vs. qemu platform support

2021-09-19 Thread Brad Smith
On 9/17/2021 4:58 AM, David Gibson wrote: Hi all, At the qemu-in-rust BoF at KVM Forum, I volunteered to look into whether Rust supported all the host/build platforms that qemu does, which is obviously vital if we want to make Rust a non-optional component of the build. I've added the informati

Re: [PATCH] tests/vm: update openbsd to release 6.9

2021-06-29 Thread Brad Smith
ping. On 5/31/2021 12:55 AM, Gerd Hoffmann wrote: On Sun, May 30, 2021 at 10:01:28PM -0400, Brad Smith wrote: tests/vm: update openbsd to release 6.9 Signed-off-by: Brad Smith Tested-by: Gerd Hoffmann

Re: [PATCH] tests/vm: update NetBSD to 9.2

2021-06-29 Thread Brad Smith
ping. On 6/3/2021 3:19 AM, Gerd Hoffmann wrote: On Wed, Jun 02, 2021 at 01:21:49PM -0400, Brad Smith wrote: tests/vm: update NetBSD to 9.2 Signed-off-by: Brad Smith Tested-by: Gerd Hoffmann

Re: [PATCH] tests/vm: update NetBSD to 9.2

2021-06-30 Thread Brad Smith
uot;Philippe Mathieu-Daudé" (maintainer:Build and test au...) Thomas Huth (maintainer:Build and test au...) Wainer dos Santos Moschetta (reviewer:Build and test au...) Willian Rampazzo (reviewer:Build and test au...) qemu-devel@nongnu.org (open list:All patches CC here) On 6/2/21 7:21 PM, Br

Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports

2019-02-05 Thread Brad Smith
If someone could point me in the right direction as to how the image is created I could look at coming up with something newer. I would prefer that over some of the workarounds I've seen to date. On 2/5/2019 8:42 AM, Philippe Mathieu-Daudé wrote: Hi Peter, On 2/5/19 2:20 PM, Peter Maydell wro

Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports

2019-02-05 Thread Brad Smith
On 2/5/2019 9:23 AM, Philippe Mathieu-Daudé wrote: Hi Brad, On 2/5/19 2:57 PM, Brad Smith wrote: If someone could point me in the right direction as to how the image is created I could look at coming up with something newer. I would prefer that over some of the workarounds I've seen to

Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports

2019-02-06 Thread Brad Smith
On 2/5/2019 8:57 AM, Brad Smith wrote: If someone could point me in the right direction as to how the image is created I could look at coming up with something newer. I would prefer that over some of the workarounds I've seen to date. I started creating the image and then wondered what

Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports

2019-02-06 Thread Brad Smith
On 2/6/2019 3:25 PM, Alex Bennée wrote: Brad Smith writes: On 2/5/2019 8:57 AM, Brad Smith wrote: If someone could point me in the right direction as to how the image is created I could look at coming up with something newer. I would prefer that over some of the workarounds I've se

Re: [Qemu-devel] [PULL 02/29] ppc/spapr: Receive and store device tree blob from SLOF

2019-03-23 Thread Brad Smith
Now that I am checking out 4.0.0 rc's I see this diff is broken and depends on a function libfdt does not expose. The breakage is hidden by the fallback check in the configure script. On 1/8/2019 5:45 PM, David Gibson wrote: From: Alexey Kardashevskiy SLOF receives a device tree and updates it

Re: [Qemu-devel] [PULL 02/29] ppc/spapr: Receive and store device tree blob from SLOF

2019-03-24 Thread Brad Smith
I filed a bug report for libfdt.. https://github.com/dgibson/dtc/issues/27 On 3/24/2019 12:03 AM, Brad Smith wrote: Now that I am checking out 4.0.0 rc's I see this diff is broken and depends on a function libfdt does not expose. The breakage is hidden by the fallback check in the conf

Re: [Qemu-devel] QEMU on OpenBSD is broken?

2019-05-18 Thread Brad Smith
I just noticed when I had replied that my e-mail was sent from a different name, by accident, as I was testing something with my e-mail client. On 5/18/2019 5:27 PM, Jim Payne wrote: On 5/16/2019 9:04 PM, Thomas Huth wrote: On 10/05/2019 12.46, Gerd Hoffmann wrote: This patch series changes t

Re: [Qemu-devel] [PATCH 4/4] [RfC] audio: probe audio drivers by default

2019-01-23 Thread Brad Smith
On 1/23/2019 8:59 AM, Gerd Hoffmann wrote: Hi, What is the native sound interface for openbsd btw? oss doesn't compile (missing sys/soundcard.h header). OpenBSD uses sndio, a similar audio daemon to pulseaudio and it's enforced for all [well integrated] audio applications. Hmm. Yet anot

Re: [Qemu-devel] [RFC PATCH] ui/egl: Silent '__HAIKU__ undefined' warnings on OpenBSD 6.1

2019-01-23 Thread Brad Smith
https://cgit.freedesktop.org/mesa/mesa/commit/include/EGL/eglplatform.h?id=f744c6c1e28fe363474550b94af42a8b7fc1c755 Unfortunately that issue has only been fixed very recently. There is a possibility of us updating from Mesa 17.3.9 to 18.3.x which would bring in this header fix, but I don't know

Re: [Qemu-devel] [PATCH RFC 8/9] tests: Add OpenBSD image

2019-01-24 Thread Brad Smith
On 1/24/2019 11:52 AM, Daniel P. Berrangé wrote: On Thu, Jan 24, 2019 at 05:10:19PM +0100, Philippe Mathieu-Daudé wrote: On 1/24/19 4:56 PM, Kamil Rytarowski wrote: On 24.01.2019 16:52, Philippe Mathieu-Daudé wrote: On 8/16/17 9:21 AM, Fam Zheng wrote: The image is prepared following instruc

Re: [Qemu-devel] [PATCH RFC 8/9] tests: Add OpenBSD image

2019-01-25 Thread Brad Smith
On 1/25/2019 1:24 AM, Thomas Huth wrote: On 2019-01-25 01:48, Brad Smith wrote: On 1/24/2019 11:52 AM, Daniel P. Berrangé wrote: On Thu, Jan 24, 2019 at 05:10:19PM +0100, Philippe Mathieu-Daudé wrote: On 1/24/19 4:56 PM, Kamil Rytarowski wrote: On 24.01.2019 16:52, Philippe Mathieu-Daudé

Re: [Qemu-devel] [PULL v2 07/49] util: check the return value of fcntl in qemu_set_{block, nonblock}

2019-01-25 Thread Brad Smith
On 1/25/2019 1:53 PM, Philippe Mathieu-Daudé wrote: Hi, On 1/15/19 9:04 PM, Michael S. Tsirkin wrote: From: Li Qiang Assert that the return value is not an error. This is like commit 7e6478e7d4f for qemu_set_cloexec. Signed-off-by: Li Qiang Reviewed-by: Thomas Huth Reviewed-by: Michael S.

Re: [RFC PATCH v4 00/29] Hexagon patch series

2020-09-29 Thread Brad Smith
On 9/29/2020 1:01 PM, Philippe Mathieu-Daudé wrote: On 9/29/20 5:53 PM, Taylor Simpson wrote: -Original Message- From: Philippe Mathieu-Daudé On Behalf Of Philippe Mathieu-Daudé Sent: Tuesday, September 29, 2020 6:22 AM To: Taylor Simpson ; qemu-devel@nongnu.org Cc: a...@rev.ng; riku.vo

Re: [PATCH] tests/vm: update openbsd to release 6.8

2020-11-06 Thread Brad Smith
ping. On 10/27/2020 6:22 AM, Brad Smith wrote: On Tue, Oct 27, 2020 at 11:05:20AM +0100, Philippe Mathieu-Daud?? wrote: On 10/27/20 6:30 AM, Brad Smith wrote: tests/vm: update openbsd to release 6.8 A double dash at the end of a package name removes ambiguity when the intent is to install a

Re: [PATCH] tests/vm: update openbsd to release 6.8

2020-11-10 Thread Brad Smith
On 11/9/2020 3:13 AM, Thomas Huth wrote: On 07/11/2020 07.07, Brad Smith wrote: ping. It's not directly my turf, but I can add it to my next testing-related pull request if nobody else picks this patch up before. Please, if you could. Thank you. Thomas On 10/27/2020 6:22 AM, Brad

[PATCH] tests/vm: update NetBSD to 9.1

2020-11-13 Thread Brad Smith
tests/vm: update NetBSD to 9.1 Signed-off-by: Brad Smith Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann --- tests/vm/netbsd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/vm/netbsd b/tests/vm/netbsd index 447de9747d..596717cc76 100755 --- a/tests/vm

Re: [PATCH] tests/vm: update openbsd image to 7.6

2024-10-12 Thread Brad Smith
On 2024-10-13 2:06 a.m., Thomas Huth wrote: On 13/10/2024 05.36, Brad Smith wrote: tests/vm: update openbsd image to 7.6 Maybe change the patch description to something more meaningful, e.g. a comment about the removed py3-tomli package ? Ok, I will post an updated diff. Signed-off-by

[PATCH v2] tests/vm: update openbsd image to 7.6

2024-10-12 Thread Brad Smith
tests/vm: update openbsd image to 7.6 Remove tomli as Python has been updated to 3.11. Signed-off-by: Brad Smith --- tests/vm/openbsd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index 49cab08782..dfd11c93f0 100755 --- a/tests/vm

[PATCH] tests/vm: update openbsd image to 7.6

2024-10-12 Thread Brad Smith
tests/vm: update openbsd image to 7.6 Signed-off-by: Brad Smith --- tests/vm/openbsd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index 49cab08782..dfd11c93f0 100755 --- a/tests/vm/openbsd +++ b/tests/vm/openbsd @@ -22,8 +22,8

Re: [PATCH v2] tests/vm: update openbsd image to 7.6

2024-10-21 Thread Brad Smith
On 2024-10-21 5:27 a.m., Daniel P. Berrangé wrote: On Sun, Oct 13, 2024 at 02:19:41AM -0400, Brad Smith wrote: tests/vm: update openbsd image to 7.6 Remove tomli as Python has been updated to 3.11. Signed-off-by: Brad Smith --- tests/vm/openbsd | 6 +++--- 1 file changed, 3 insertions

[PATCH] meson.build: Remove ncurses workaround for OpenBSD

2024-10-11 Thread Brad Smith
meson.build: Remove ncurses workaround for OpenBSD OpenBSD 7.5 has upgraded to ncurses 6.4. Signed-off-by: Brad Smith --- meson.build | 2 +- ui/curses.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 4ea1984fc5..22e7629d81 100644 --- a

[PATCH] contrib/plugins: ensure build does not pick up a system copy of plugin header

2024-09-20 Thread Brad Smith
contrib/plugins: ensure build does not pick up a system copy of plugin header With the ordering of the header path if a copy of QEMU is installed it will pickup the system copy of the header before the build paths copy and the build will fail. Signed-off-by: Brad Smith --- contrib/plugins

Re: [PATCH] contrib/plugins: ensure build does not pick up a system copy of plugin header

2024-09-21 Thread Brad Smith
On 2024-09-21 8:55 a.m., Alex Bennée wrote: Brad Smith writes: contrib/plugins: ensure build does not pick up a system copy of plugin header I'm confused because this changes the ordering of the GLIB inclusion. We shouldn't be including the whole QEMU include path. That's i

<    1   2   3