Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-25 Thread Blue Swirl
On Fri, Aug 24, 2012 at 11:01 PM, Peter Maydell wrote: > On 24 August 2012 19:43, Andreas Färber wrote: >> Depends on what you mean with "disable"? Adding an #error would hurt our >> arm build just like earlier the ppc build, and I would hope from my last >> testing that the problems would only a

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/1] Add USB option in machine options

2012-08-26 Thread Blue Swirl
On Sat, Aug 25, 2012 at 2:27 PM, Alexander Graf wrote: > > > On 25.08.2012, at 00:43, Blue Swirl wrote: > >> On Wed, Aug 22, 2012 at 10:31 AM, Li Zhang wrote: >>> When -usb option is used, global varible usb_enabled is set. >>> And all the plafrom will create

Re: [Qemu-devel] Get host virtual address corresponding to guest physical address?

2012-08-26 Thread Blue Swirl
On Sat, Aug 25, 2012 at 1:17 PM, 陳韋任 (Wei-Ren Chen) wrote: > On Sat, Aug 25, 2012 at 11:56:13AM +0100, Peter Maydell wrote: >> On 24 August 2012 04:14, 陳韋任 (Wei-Ren Chen) wrote: >> > I would like to know if there is a function in QEMU which converts >> > a guest physical address into correspond

Re: [Qemu-devel] [PATCH for-1.2] target-ppc: fix altivec instructions

2012-08-26 Thread Blue Swirl
On Sun, Aug 26, 2012 at 2:14 PM, Aurelien Jarno wrote: > Altivec instructions are not working anymore in PowerPC emulation, > following commit d15f74fb, which inverted two registers in the call > to helper. Fix that. > > Cc: Blue Swirl Acked-by: Blue Swirl I wonder why TCG debu

Re: [Qemu-devel] [PATCH for-1.2] tcg/arm: Fix broken CONFIG_TCG_PASS_AREG0 code

2012-08-26 Thread Blue Swirl
Thanks, applied. On Sun, Aug 26, 2012 at 1:40 PM, Peter Maydell wrote: > The CONFIG_TCG_PASS_AREG0 code for calling ld/st helpers was > broken in that it did not respect the ABI requirement that 64 > bit values were passed in even-odd register pairs. The simplest > way to fix this is to implement

Re: [Qemu-devel] [PATCH] target-sparc: remove useless line in Makefile.objs

2012-08-27 Thread Blue Swirl
On Sun, Aug 26, 2012 at 7:08 PM, Aurelien Jarno wrote: > op_helper.c has been removed in commit 0184e266. Remove the corresponding > flags from Makefile.objs. > > Cc: Blue Swirl Acked-by: Blue Swirl As this is cleanup only, it could be postponed to 1.3. > Signed-off-by:

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/1] Add USB option in machine options

2012-08-27 Thread Blue Swirl
On Mon, Aug 27, 2012 at 1:59 AM, Alexander Graf wrote: > > > On 26.08.2012, at 10:34, Blue Swirl wrote: > >> On Sat, Aug 25, 2012 at 2:27 PM, Alexander Graf wrote: >>> >>> >>> On 25.08.2012, at 00:43, Blue Swirl wrote: >>> >>>>

Re: [Qemu-devel] [RFC][PATCH v4 3/3] tcg: Optimize qemu_ld/st by generating slow paths at the end of a block

2012-08-27 Thread Blue Swirl
On Mon, Aug 27, 2012 at 7:23 AM, Yeongkyoon Lee wrote: > On 2012년 07월 29일 00:39, Yeongkyoon Lee wrote: >> >> On 2012년 07월 25일 23:00, Richard Henderson wrote: >>> >>> On 07/25/2012 12:35 AM, Yeongkyoon Lee wrote: +#if defined(CONFIG_QEMU_LDST_OPTIMIZATION) && defined(CONFIG_SOFTMMU)

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-27 Thread Blue Swirl
On Mon, Aug 27, 2012 at 12:20 PM, Michael S. Tsirkin wrote: > In preparation for adding PV EOI support, disable PV EOI by default for > 1.1 and older machine types, to avoid CPUID changing during migration. > > PV EOI can still be enabled/disabled by specifying it explicitly. > Enable for 1.1

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-27 Thread Blue Swirl
On Mon, Aug 27, 2012 at 7:01 PM, Michael S. Tsirkin wrote: > On Mon, Aug 27, 2012 at 06:56:38PM +0000, Blue Swirl wrote: >> > +static uint32_t slow_bar_readb(void *opaque, target_phys_addr_t addr) >> > +{ >> > +AssignedDevRegion *d = opaque; >> > +

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-27 Thread Blue Swirl
On Mon, Aug 27, 2012 at 7:06 PM, Michael S. Tsirkin wrote: > On Mon, Aug 27, 2012 at 06:58:29PM +0000, Blue Swirl wrote: >> On Mon, Aug 27, 2012 at 12:20 PM, Michael S. Tsirkin wrote: >> > In preparation for adding PV EOI support, disable PV EOI by default for >> >

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-27 Thread Blue Swirl
On Mon, Aug 27, 2012 at 7:24 PM, Michael S. Tsirkin wrote: > On Mon, Aug 27, 2012 at 07:12:27PM +0000, Blue Swirl wrote: >> On Mon, Aug 27, 2012 at 7:06 PM, Michael S. Tsirkin wrote: >> > On Mon, Aug 27, 2012 at 06:58:29PM +, Blue Swirl wrote: >> >> On Mon, Aug

Re: [Qemu-devel] PPC heathrow broken - update OpenBIOS to r1063?

2012-08-28 Thread Blue Swirl
On Mon, Aug 27, 2012 at 9:13 PM, Aurelien Jarno wrote: > Hi, > > As you probably know, the PPC machines with a heathrow controller is > broken following commit 9e56edcf ("vga: raise default vgamem size"). > The PCI hole space is not big enough for such a new default size. > > Alexander has fixed i

Re: [Qemu-devel] [RFC][PATCH v4 3/3] tcg: Optimize qemu_ld/st by generating slow paths at the end of a block

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 6:52 AM, Yeongkyoon Lee wrote: > >>> It's been a long time. >>> >>> I've tested the performances of one jump difference when fast qemu_ld/st >>> (TLB hit). >>> The result shows 3.6% CoreMark enhancement when reducing one jump where >>> slow >>> paths are generated at the en

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: > On 27.08.2012 22:56, Blue Swirl wrote: > [] >>> +static uint32_t slow_bar_readb(void *opaque, target_phys_addr_t addr) >>> +{ >>> +AssignedDevRegion *d = opaque; >>> +uint8_t *in = d

Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 1:22 PM, Michael S. Tsirkin wrote: > In preparation for adding PV EOI support, disable PV EOI by default for > 1.1 and older machine types, to avoid CPUID changing during migration. > > PV EOI can still be enabled/disabled by specifying it explicitly. > Enable for 1.1 >

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 4:01 PM, Michael S. Tsirkin wrote: > We copied HACKING from libvirt but it has some bogus stuff: > neither underscore capital, double underscore, or underscore 't' suffixes > are reserved in Posix/C: this appears to be based on misreading of the > C standard. Using sane pre

Re: [Qemu-devel] [PATCH v4] configure: properly check if -lrt and -lm is needed

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 7:33 AM, Natanael Copa wrote: > On Tue, 21 Aug 2012 18:12:05 + > Blue Swirl wrote: >> >> Now I get this on mingw32: >> config-host.mak is out-of-date, running configure >> >> Error: librt check failed > > Any news on the v

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 5:21 PM, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 05:13:24PM +0000, Blue Swirl wrote: >> On Tue, Aug 28, 2012 at 4:01 PM, Michael S. Tsirkin wrote: >> > We copied HACKING from libvirt but it has some bogus stuff: >> > neither

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 5:28 PM, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 05:01:55PM +0000, Blue Swirl wrote: >> On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: >> > On 27.08.2012 22:56, Blue Swirl wrote: >> > [] >> >>> +s

Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 5:22 PM, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 05:05:25PM +0000, Blue Swirl wrote: >> > +static bool _kvm_pv_eoi_disabled; >> >> NACK. I find your lack of compliance disturbing. > > Compliance with what? Could you please add

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 7:31 PM, Anthony Liguori wrote: > Blue Swirl writes: > >> On Tue, Aug 28, 2012 at 5:28 PM, Michael S. Tsirkin wrote: >>> On Tue, Aug 28, 2012 at 05:01:55PM +, Blue Swirl wrote: >>>> On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev

Re: [Qemu-devel] [PATCH v2 07/10] block: add a transfer rate for floppy types

2012-01-23 Thread Blue Swirl
On Mon, Jan 23, 2012 at 08:51, Kevin Wolf wrote: > Am 21.01.2012 20:02, schrieb Blue Swirl: >> On Mon, Jan 16, 2012 at 10:18, Kevin Wolf wrote: >>> Am 15.01.2012 08:51, schrieb Hervé Poussineau: >>>> Floppies must be read at a specific transfer rate, dep

[Qemu-devel] [PATCH] hyperv: fix build on non-KVM hosts

2012-01-23 Thread Blue Swirl
Signed-off-by: Blue Swirl --- Maybe a better fix would be to allow hyperv to be used also on TCG. --- Makefile.target |2 +- target-i386/hyperv.h |4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Makefile.target b/Makefile.target index 092565a..69193d4 100644

Re: [Qemu-devel] [PATCH 1/4] vga: improve VGA logic

2012-01-24 Thread Blue Swirl
On Tue, Jan 24, 2012 at 15:57, Markus Armbruster wrote: > Current master dies for me: > > $ upstream-qemu -nodefaults -S -m 384 -vnc :0 -device cirrus-vga > RAMBlock "vga.vram" already registered, abort! > Aborted (core dumped) > > git-bisect blames this one: >

Re: [Qemu-devel] [PATCH 1/4] vga: improve VGA logic

2012-01-25 Thread Blue Swirl
On Tue, Jan 24, 2012 at 18:29, Markus Armbruster wrote: > Blue Swirl writes: > >> On Tue, Jan 24, 2012 at 15:57, Markus Armbruster wrote: >>> Current master dies for me: >>> >>> $ upstream-qemu -nodefaults -S -m 384 -vnc :0 -device cirrus-vga >>&g

Re: [Qemu-devel] [PATCH] hyperv: fix build on non-KVM hosts

2012-01-25 Thread Blue Swirl
On Tue, Jan 24, 2012 at 19:50, Vadim Rozenfeld wrote: > > > - Original Message - > From: "Blue Swirl" > To: vroze...@redhat.com, "qemu-devel" > Sent: Monday, January 23, 2012 10:10:51 PM > Subject: [PATCH] hyperv: fix build on non-KVM hosts >

Re: [Qemu-devel] [PATCH v3 0/28] qom: add QEMU Object Model type hierarchy to qdev

2012-01-25 Thread Blue Swirl
On Tue, Jan 24, 2012 at 19:32, Anthony Liguori wrote: > This series makes qdev a proper Object and converts qdev's type inheritance to > QOM inheritance. > > The first half of the series are manual cleanups/refactorings.  The second > half > is mostly scripted conversion, separated out into revie

Re: [Qemu-devel] [PATCH v5 0/3] VGA patches

2012-01-25 Thread Blue Swirl
On Tue, Jan 24, 2012 at 13:05, Avi Kivity wrote: > On 01/22/2012 03:06 PM, Blue Swirl wrote: >> Let's compile Cirrus in hwlib. >> >> http://repo.or.cz/r/qemu/blueswirl.git >> >> > > Patches look fine (after fixing #2). Thanks, I applied them. >

[Qemu-devel] [PATCH RFC 0/3] VGA patches

2012-01-25 Thread Blue Swirl
/blueswirl.git Blue Swirl (3): memory: memory: change dirty getting API to take a size vga: move Cirrus VGA template to its own file vga: compile in hwlib Makefile.objs|1 + Makefile.target |1 - arch_init.c |7 +- exec-obsolete.h | 14

[Qemu-devel] [PATCH 1/3] memory: memory: change dirty getting API to take a size

2012-01-25 Thread Blue Swirl
Instead of each target knowing or guessing the guest page size, just pass the desired size of dirtied memory area. Signed-off-by: Blue Swirl --- arch_init.c |7 --- exec-obsolete.h | 14 -- hw/framebuffer.c |9 + hw/g364fb.c |3 ++- hw/sm501.c

[Qemu-devel] [PATCH 2/3] vga: move Cirrus VGA template to its own file

2012-01-25 Thread Blue Swirl
Standard VGA does not use vga_draw_cursor_line_* functions. Move the template to cirrus_vga_template.h. Signed-off-by: Blue Swirl --- hw/cirrus_vga.c |9 hw/cirrus_vga_template.h | 102 ++ hw/vga_int.h | 13 -- hw

[Qemu-devel] [PATCH 3/3] vga: compile in hwlib

2012-01-25 Thread Blue Swirl
WIP Signed-off-by: Blue Swirl --- NB. This patch is not finished yet. I was trying the (ugly or impossible even) approach of passing a flag for endianness (is_be) in vga_init(). However, I noticed that even with is_be always true, VGA on x86, PPC and Sparc64 all still worked! What is going on

Re: [Qemu-devel] [PATCH v3 0/28] qom: add QEMU Object Model type hierarchy to qdev

2012-01-25 Thread Blue Swirl
On Wed, Jan 25, 2012 at 19:43, Anthony Liguori wrote: > On 01/25/2012 12:31 PM, Blue Swirl wrote: >> >> On Tue, Jan 24, 2012 at 19:32, Anthony Liguori >>  wrote: >>> >>> This series makes qdev a proper Object and converts qdev's type >>> inher

Re: [Qemu-devel] [PATCH V2] GRLIB UART: Add RX channel

2012-01-28 Thread Blue Swirl
On Thu, Jan 26, 2012 at 17:03, Fabien Chouteau wrote: > This patch implements the RX channel of GRLIB UART with a FIFO to > improve data rate. > > Signed-off-by: Fabien Chouteau > --- >  hw/grlib_apbuart.c |  106 +++ >  trace-events       |    1 + >

Re: [Qemu-devel] suspend/resume not working on tip due to 59abb06

2012-01-28 Thread Blue Swirl
2a2ff5e43cb91a21b17fbf047d8). >> >> commit 59abb06198ee9471e29c970f294eae80c0b39be1 >> Author: Blue Swirl >> Date:   Sun Jan 22 11:00:44 2012 + >> >> Once I revert this patch on the tip everything works fine again... >> >>   Stefan >> >> > And t

Re: [Qemu-devel] [PULL 0/5] target-arm queue

2012-01-28 Thread Blue Swirl
On Wed, Jan 25, 2012 at 15:27, Peter Maydell wrote: > Here's the latest target-arm pullreq. It includes Mark's fix for > config_base_register, which is in turn a dependency of the arm-devs > pullreq I'm about to send out, and which I'd like to get in before > Anthony's QOM patchset lands and inval

Re: [Qemu-devel] suspend/resume not working on tip due to 59abb06

2012-01-28 Thread Blue Swirl
On Sat, Jan 28, 2012 at 12:23, Blue Swirl wrote: > On Fri, Jan 27, 2012 at 21:27, Stefan Berger > wrote: >> On 01/27/2012 04:10 PM, Stefan Berger wrote: >>> >>> After bisecting the following commit seems to be the culprit for the >>> suspend/resume problem

[Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-28 Thread Blue Swirl
Fix suspend/resume broken by off-by-one error in 59abb06198ee9471e29c970f294eae80c0b39be1. Adjust the loop so that it handles correctly the case start = (ram_addr_t)-TARGET_PAGE_SIZE, length = TARGET_PAGE_SIZE. Reported-by: Stefan Berger Signed-off-by: Blue Swirl --- exec-obsolete.h | 10

Re: [Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-29 Thread Blue Swirl
On Sun, Jan 29, 2012 at 10:22, Avi Kivity wrote: > On 01/28/2012 08:13 PM, Blue Swirl wrote: >> Fix suspend/resume broken by off-by-one error in >> 59abb06198ee9471e29c970f294eae80c0b39be1. >> >> Adjust the loop so that it handles correctly the case >> star

Re: [Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-29 Thread Blue Swirl
On Sun, Jan 29, 2012 at 12:08, Avi Kivity wrote: > On 01/28/2012 08:13 PM, Blue Swirl wrote: >> Fix suspend/resume broken by off-by-one error in >> 59abb06198ee9471e29c970f294eae80c0b39be1. >> >> Adjust the loop so that it handles correctly the case >> star

[Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-29 Thread Blue Swirl
Fix suspend/resume broken by off-by-one error in 59abb06198ee9471e29c970f294eae80c0b39be1, based on patch by Stefan Berger. Reported-by: Stefan Berger Signed-off-by: Blue Swirl --- exec-obsolete.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/exec-obsolete.h b

Re: [Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-29 Thread Blue Swirl
On Sun, Jan 29, 2012 at 13:20, Avi Kivity wrote: > On 01/29/2012 03:16 PM, Blue Swirl wrote: >> On Sun, Jan 29, 2012 at 12:08, Avi Kivity wrote: >> > On 01/28/2012 08:13 PM, Blue Swirl wrote: >> >> Fix suspend/resume broken by off-by-one error in >> >>

Re: [Qemu-devel] [PATCH] Fix off-by-one in dirty bitmap functions

2012-01-29 Thread Blue Swirl
Thanks, applied. On Sun, Jan 29, 2012 at 14:47, Avi Kivity wrote: > Reported-by: Stefan Berger > Signed-off-by: Avi Kivity > --- >  exec-obsolete.h |   10 ++ >  1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/exec-obsolete.h b/exec-obsolete.h > index 03cf35e..d2749d3 1

[Qemu-devel] [PATCH 0/6] VGA patches

2012-01-29 Thread Blue Swirl
Patch 1 has been sent several times, though the logic has been copied from flawed implementations before. Other patches should be trivial. URL git://repo.or.cz/qemu/blueswirl.git http://repo.or.cz/r/qemu/blueswirl.git Blue Swirl (6): memory: change dirty getting API to take a size

[Qemu-devel] [PATCH 1/6] memory: change dirty getting API to take a size

2012-01-29 Thread Blue Swirl
Instead of each device knowing or guessing the guest page size, just pass the desired size of dirtied memory area. Signed-off-by: Blue Swirl --- arch_init.c |7 --- exec-obsolete.h | 15 +-- hw/framebuffer.c |9 + hw/g364fb.c |3 ++- hw/sm501.c

[Qemu-devel] [PATCH 2/6] vga: move Cirrus VGA template to its own file

2012-01-29 Thread Blue Swirl
Standard VGA does not use vga_draw_cursor_line_* functions. Move the template to cirrus_vga_template.h. Signed-off-by: Blue Swirl --- hw/cirrus_vga.c |9 hw/cirrus_vga_template.h | 102 ++ hw/vga_int.h | 13 -- hw

[Qemu-devel] [PATCH 3/6] Add vga.h unmodified from Linux

2012-01-29 Thread Blue Swirl
Signed-off-by: Blue Swirl --- hw/vga.h | 481 ++ 1 files changed, 481 insertions(+), 0 deletions(-) create mode 100644 hw/vga.h diff --git a/hw/vga.h b/hw/vga.h new file mode 100644 index 000..2b8691f --- /dev/null +++ b/hw/vga.h

[Qemu-devel] [PATCH 4/6] vga.h: remove unused stuff and reformat

2012-01-29 Thread Blue Swirl
Signed-off-by: Blue Swirl --- hw/vga.h | 534 +- 1 files changed, 106 insertions(+), 428 deletions(-) diff --git a/hw/vga.h b/hw/vga.h index 2b8691f..d917046 100644 --- a/hw/vga.h +++ b/hw/vga.h @@ -2,49 +2,21 @@ * linux/include

[Qemu-devel] [PATCH 6/6] vga: improve documentation

2012-01-29 Thread Blue Swirl
Add links to chipset docs and FreeVGA site. Signed-off-by: Blue Swirl --- hw/vga.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index 758bd92..d87c4f9 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -37,6 +37,18 @@ //#define DEBUG_BOCHS_VBE

Re: [Qemu-devel] [PATCH V2] GRLIB UART: Add RX channel

2012-01-30 Thread Blue Swirl
On Mon, Jan 30, 2012 at 09:22, Fabien Chouteau wrote: > On 28/01/2012 13:20, Blue Swirl wrote: >> On Thu, Jan 26, 2012 at 17:03, Fabien Chouteau wrote: >>> This patch implements the RX channel of GRLIB UART with a FIFO to >>> improve data rate. >>>

Re: [Qemu-devel] [PATCH] m48t59: use rtc_clock for alarm timer

2012-01-30 Thread Blue Swirl
Thanks, applied. On Fri, Jan 20, 2012 at 12:05, Paolo Bonzini wrote: > This lets the RTC get adjustments from the host NTP client. > The watchdog still uses the vm_clock.  The previous behavior is > available with "-rtc clock=vm". > > Cc: Andreas Färber > Signed-off-by: Paolo Bonzini > --- >  h

Re: [Qemu-devel] [PULL 00/21] ppc patch queue 2012-02-02

2012-02-04 Thread Blue Swirl
On Thu, Feb 2, 2012 at 01:49, Alexander Graf wrote: > Hi Blue / Aurelien, > > This is my current patch queue for ppc. Please pull. Thanks, pulled. > Alex > > > The following changes since commit d34e8f6e9d3a396c3327aa9807c83f9e1f4a7bd7: >  Michael Roth (1): >        main-loop: For tools, initial

Re: [Qemu-devel] [PATCH] This patch is used to move some struct definition, like QEMUTimer, QEMUClock, from .c to .h.

2012-02-04 Thread Blue Swirl
On Tue, Jan 31, 2012 at 06:56, Wei Yang wrote: > Tested on i386 platform. > > Signed-off-by: Wei Yang Nack. Definitions should reside in files where they are used, only in header files when they are used by multiple sources. > --- >  qemu-timer.c |   40 >

Re: [Qemu-devel] building qemu on Oracle Solaris 11 x64

2012-02-04 Thread Blue Swirl
2012/1/31 Günther Schmidt : > Hi everyone, > > I'm trying to build qemu on Oracle Solars 11 x64. I've figure out that I > need to set the --disable-guest-agent for ./configure, but there are other > errors I do not know how to fix. > > Setting LD_LIBRARY_PATH to /usr/lib/mps/amd64 helps but at leas

[Qemu-devel] [PATCH] ppc: remove unused variables

2012-02-04 Thread Blue Swirl
Fix this error: /src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size': /src/qemu/target-ppc/helper.c:1296:14: error: variable 'tlbncfg' set but not used [-Werror=unused-but-set-variable] Signed-off-by: Blue Swirl --- target-ppc/helper.c |3 --- 1 files c

Re: [Qemu-devel] [PATCH] w32: Fix build with new net bridge code

2012-02-04 Thread Blue Swirl
Thanks, applied. On Sat, Feb 4, 2012 at 08:24, Stefan Weil wrote: > Commit a7c36ee4920ea3acc227a0248dd161693f207357 added code for a net > bridge and explicitly said that "this is very Linux centric". > > Indeed, compilation failed for w32, so the bridge code is now > conditional. Hosts which don

Re: [Qemu-devel] [PATCH] usb-bsd: convert to QOM

2012-02-04 Thread Blue Swirl
On Fri, Feb 3, 2012 at 23:41, Anthony Liguori wrote: > Untested but simple enough. > > Signed-off-by: Anthony Liguori There are still some problems, though build does not fail anymore: CCusb-bsd.o /src/qemu/usb-bsd.c:417: warning: initialization from incompatible pointer type /src/qemu/usb

Re: [Qemu-devel] [PATCH] memory-region: Report if region is read-only on info mtree

2012-02-04 Thread Blue Swirl
On Fri, Feb 3, 2012 at 12:02, Jan Kiszka wrote: > Helpful to understand guest configurations of things like the i440FX's > PAM. > > Signed-off-by: Jan Kiszka > --- >  memory.c |    6 -- >  1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/memory.c b/memory.c > index ee4c98a..e

Re: [Qemu-devel] [PATCH] memory-region: Report if region is read-only on info mtree

2012-02-04 Thread Blue Swirl
On Sat, Feb 4, 2012 at 12:23, Jan Kiszka wrote: > On 2012-02-04 13:12, Blue Swirl wrote: >> On Fri, Feb 3, 2012 at 12:02, Jan Kiszka wrote: >>> Helpful to understand guest configurations of things like the i440FX's >>> PAM. >>> >>> Signe

Re: [Qemu-devel] [PULL] [PATCH 00/19] linux-user update

2012-02-04 Thread Blue Swirl
Thanks, pulled. On Fri, Feb 3, 2012 at 14:49, wrote: > From: Riku Voipio > > The following changes since commit d34e8f6e9d3a396c3327aa9807c83f9e1f4a7bd7: > >  main-loop: For tools, initialize timers as part of qemu_init_main_loop() > (2012-02-01 14:45:02 -0600) > > are available in the git rep

Re: [Qemu-devel] [PATCH 0/6] VGA patches

2012-02-04 Thread Blue Swirl
On Sun, Jan 29, 2012 at 19:12, Blue Swirl wrote: > Patch 1 has been sent several times, though the logic has been copied > from flawed implementations before. > > Other patches should be trivial. Pushed. I compared vga.o object files with codiff and objdump disassembler before a

Re: [Qemu-devel] [PATCH v2] memory-region: Report if region is read-only or write-only on info mtree

2012-02-04 Thread Blue Swirl
On Sat, Feb 4, 2012 at 14:57, Jan Kiszka wrote: > From: Jan Kiszka > > Helpful to understand guest configurations of things like the i440FX's > PAM or the state of ROM devices. > > Signed-off-by: Jan Kiszka > --- > > Changes in v2: >  - encode R and W separately >  - print ROMD memory region sta

Re: [Qemu-devel] [PATCH 0/6] VGA patches

2012-02-04 Thread Blue Swirl
On Sat, Feb 4, 2012 at 16:16, Jan Kiszka wrote: > On 2012-02-04 14:15, Blue Swirl wrote: >> On Sun, Jan 29, 2012 at 19:12, Blue Swirl wrote: >>> Patch 1 has been sent several times, though the logic has been copied >>> from flawed implementations before. >>>

Re: [Qemu-devel] [PATCH] usb-bsd: convert to QOM

2012-02-04 Thread Blue Swirl
On Sat, Feb 4, 2012 at 17:07, Anthony Liguori wrote: > On 02/04/2012 05:54 AM, Blue Swirl wrote: >> >> On Fri, Feb 3, 2012 at 23:41, Anthony Liguori  wrote: >>> >>> Untested but simple enough. >>> >>> Signed-off-by: Anthony Liguori >> &

Re: [Qemu-devel] [PATCH] usb-bsd: convert to QOM

2012-02-04 Thread Blue Swirl
On Sat, Feb 4, 2012 at 17:26, Blue Swirl wrote: > On Sat, Feb 4, 2012 at 17:07, Anthony Liguori wrote: >> On 02/04/2012 05:54 AM, Blue Swirl wrote: >>> >>> On Fri, Feb 3, 2012 at 23:41, Anthony Liguori  wrote: >>>> >>>> Untested but simp

[Qemu-devel] [PATCH] Fix memory dirty getting API change fallout

2012-02-04 Thread Blue Swirl
Fix confusion in length calculation in commit cd7a45c95ecf2404810f3c6becb7cb83c5010ad8. Reported-by: Jan Kiszka Signed-off-by: Blue Swirl --- hw/framebuffer.c |2 +- hw/sm501.c |4 ++-- hw/vga.c |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw

Re: [Qemu-devel] Restore consistent formatting

2012-02-11 Thread Blue Swirl
On Wed, Feb 8, 2012 at 15:23, Anthony Liguori wrote: > On 02/08/2012 09:04 AM, malc wrote: >> >> On Wed, 8 Feb 2012, Andreas F?rber wrote: >> >>> malc, >>> >>> Arbitrarily reformatting your files is not okay. If you want a different >>> formatting, you need to fix checkpatch.pl first to not error

Re: [Qemu-devel] Restore consistent formatting

2012-02-11 Thread Blue Swirl
On Wed, Feb 8, 2012 at 15:36, Andreas Färber wrote: > Am 08.02.2012 16:23, schrieb Anthony Liguori: >> On 02/08/2012 09:04 AM, malc wrote: >>> On Wed, 8 Feb 2012, Andreas F?rber wrote: >>> Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fi

Re: [Qemu-devel] [BUG] checkpatch: ERROR due to * recognized as operator

2012-02-11 Thread Blue Swirl
On Thu, Feb 9, 2012 at 15:30, Andreas Färber wrote: > Hello Blue, > > I recently stumbled over the following checkpatch.pl false positive: > > --8<-- > > --- a/hw/his.c > +++ b/hw/his.c > @@ -1,1 +1,1 @@ > -    cpu_reset(CPUState *env); > +    cpu_state_reset(CPUState *env); > > --- a/hw/hers.c >

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-11 Thread Blue Swirl
On Thu, Feb 9, 2012 at 14:59, Andreas Färber wrote: > Disable warnings for spaces before opening parenthesis in > hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c. > > Signed-off-by: Andreas Färber > Cc: Blue Swirl > Cc: malc > --- >  scripts/checkpatch.pl |    5 +++

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-11 Thread Blue Swirl
On Fri, Feb 10, 2012 at 17:47, Anthony Liguori wrote: > On 02/09/2012 10:02 PM, malc wrote: >> >> On Fri, 10 Feb 2012, Evgeny Voevodin wrote: >> >>> On 02/09/2012 06:59 PM, Andreas F?rber wrote: Disable warnings for spaces before opening parenthesis in hw/{ac97,adlib,cs4231a,es1370,

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Blue Swirl
On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: > As we have thread-local cpu_single_env now and KVM uses exactly one > thread per VCPU, we can drop the cpu_single_env updates from the loop > and initialize this variable only once during setup. I don't think this is correct. Maybe you missed the

Re: [Qemu-devel] [PATCH] ppc: remove unused variables

2012-02-11 Thread Blue Swirl
On Mon, Feb 6, 2012 at 15:57, Alexander Graf wrote: > > On 06.02.2012, at 16:21, Andreas Färber wrote: > >> Am 04.02.2012 12:49, schrieb Blue Swirl: >>> Fix this error: >>> /src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size': >&

Re: [Qemu-devel] [PATCH] cfi02: Fix lazy ROMD switching - once again

2012-02-11 Thread Blue Swirl
Thanks, applied. On Sat, Feb 4, 2012 at 14:58, Jan Kiszka wrote: > The conversion to memory regions broke lazy ROMD switching by forgetting > to update the rom_mode state variable. > > Signed-off-by: Jan Kiszka > --- >  hw/pflash_cfi02.c |    1 + >  1 files changed, 1 insertions(+), 0 deletions(

Re: [Qemu-devel] [PATCH v3] memory-region: Report if region is read-only or write-only on info mtree

2012-02-11 Thread Blue Swirl
Thanks, applied. On Sat, Feb 4, 2012 at 15:25, Jan Kiszka wrote: > From: Jan Kiszka > > Helpful to understand guest configurations of things like the i440FX's > PAM or the state of ROM devices. > > Signed-off-by: Jan Kiszka > --- > > Changes in v3: >  - refactored writable condition (which DO m

Re: [Qemu-devel] [PATCH] vga: Fix full updates in graphic mode

2012-02-11 Thread Blue Swirl
Thanks, applied. On Tue, Feb 7, 2012 at 15:03, Jan Kiszka wrote: > This fixes the regression introduced by cd7a45c95e: We lost the or'ing > with the full_update flag. > > Signed-off-by: Jan Kiszka > --- > > Applies on top of the other related fix: > http://thread.gmane.org/gmane.comp.emulators.q

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Blue Swirl
On Sat, Feb 11, 2012 at 10:06, Jan Kiszka wrote: > On 2012-02-11 11:02, Blue Swirl wrote: >> On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: >>> As we have thread-local cpu_single_env now and KVM uses exactly one >>> thread per VCPU, we can drop the cpu_single_env up

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Blue Swirl
On Sat, Feb 11, 2012 at 12:43, Jan Kiszka wrote: > On 2012-02-11 12:49, Andreas Färber wrote: >> Am 11.02.2012 12:25, schrieb Blue Swirl: >>> I think using cpu_single_env is an indication of a problem, like poor >>> code, layering violation or poor API (vmport). Wha

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Blue Swirl
On Sat, Feb 11, 2012 at 14:00, Jan Kiszka wrote: > On 2012-02-11 14:54, Blue Swirl wrote: >> On Sat, Feb 11, 2012 at 12:43, Jan Kiszka wrote: >>> On 2012-02-11 12:49, Andreas Färber wrote: >>>> Am 11.02.2012 12:25, schrieb Blue Swirl: >>>>> I thi

Re: [Qemu-devel] [PATCH v2 2/8] Allow to use pause_all_vcpus from VCPU context

2012-02-11 Thread Blue Swirl
On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: > In order to perform critical manipulations on the VM state in the > context of a VCPU, specifically code patching, stopping and resuming of > all VCPUs may be necessary. resume_all_vcpus is already compatible, now > enable pause_all_vcpus for this

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Blue Swirl
On Sat, Feb 11, 2012 at 14:18, Jan Kiszka wrote: > On 2012-02-11 15:11, Blue Swirl wrote: >> On Sat, Feb 11, 2012 at 14:00, Jan Kiszka wrote: >>> On 2012-02-11 14:54, Blue Swirl wrote: >>>> On Sat, Feb 11, 2012 at 12:43, Jan Kiszka wrote: >>>>&

Re: [Qemu-devel] [PATCH v2 3/8] target-i386: Add infrastructure for reporting TPR MMIO accesses

2012-02-11 Thread Blue Swirl
On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: > This will allow the APIC core to file a TPR access report. Depending on > the accelerator and kernel irqchip mode, it will either be delivered > right away or queued for later reporting. > > In TCG mode, we can restart the triggering instruction a

Re: [Qemu-devel] [PATCH v2 5/8] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-11 Thread Blue Swirl
On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: > This enables acceleration for MMIO-based TPR registers accesses of > 32-bit Windows guest systems. It is mostly useful with KVM enabled, > either on older Intel CPUs (without flexpriority feature, can also be > manually disabled for testing) or an

Re: [Qemu-devel] [PATCH v2 22/27] qdev: access properties via QOM

2012-02-11 Thread Blue Swirl
On Sat, Feb 4, 2012 at 08:02, Paolo Bonzini wrote: > Do not poke anymore in the struct when accessing qdev properties. > Instead, ask the object to set the right value. > > Signed-off-by: Paolo Bonzini > --- >  hw/qdev-addr.c       |    5 ++- >  hw/qdev-properties.c |   78 +++

Re: [Qemu-devel] [PATCH v2 5/8] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-13 Thread Blue Swirl
On Mon, Feb 13, 2012 at 10:16, Jan Kiszka wrote: > On 2012-02-11 16:25, Blue Swirl wrote: >> On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: >>> This enables acceleration for MMIO-based TPR registers accesses of >>> 32-bit Windows guest systems. It is mostly useful w

[Qemu-devel] [PATCH 0/6] AREG0 patches v5

2012-02-13 Thread Blue Swirl
haven't made performance tests yet, I need to find a setup with better S/N. Test reports welcome. Patches 1 and 2 could be committed separately if there are no objections. URL git://repo.or.cz/qemu/blueswirl.git http://repo.or.cz/r/qemu/blueswirl.git Blue Swirl (6): TCG: split

[Qemu-devel] [PATCH 4/6] TCG: add 5 arg helpers to def-helper.h

2012-02-13 Thread Blue Swirl
Signed-off-by: Blue Swirl --- def-helper.h | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/def-helper.h b/def-helper.h index 8a822c7..a13310e 100644 --- a/def-helper.h +++ b/def-helper.h @@ -118,6 +118,8 @@ DEF_HELPER_FLAGS_3(name, 0, ret

[Qemu-devel] [PATCH 6/6] Sparc: avoid AREG0 wrappers for memory access helpers

2012-02-13 Thread Blue Swirl
Adjust generation of load and store templates so that the functions take a parameter for CPUState instead of relying on global env. Remove wrappers. Move remaining memory helpers to ldst_helper.c. Signed-off-by: Blue Swirl --- Makefile.target| 12 ++- configure

Re: [Qemu-devel] [PATCH v4 1/4] cadence_uart: initial version of device model

2012-02-14 Thread Blue Swirl
On Tue, Feb 14, 2012 at 02:24, Peter A. G. Crosthwaite wrote: > Implemented cadence UART serial controller > > Signed-off-by: Peter A. G. Crosthwaite > Signed-off-by: John Linn > --- > changes from v1: > converted register file to array > added vmsd state save/load support > removed read side ef

Re: [Qemu-devel] profiling qemu

2012-02-14 Thread Blue Swirl
2012/2/14 Lluís Vilanova : > Artyom Tarasenko writes: > [...] >> QEMU 1.0.50 monitor - type 'help' for more information >> (qemu) profile >> unknown command: 'profile' >> (qemu) info profile >> async time  38505498320 (38.505) >> qemu time   35947093161 (35.947) > >> Is there a way to find out more

Re: [Qemu-devel] [PATCH 0/6] AREG0 patches v5

2012-02-14 Thread Blue Swirl
On Mon, Feb 13, 2012 at 23:41, Richard Henderson wrote: > On 02/13/2012 12:13 PM, Blue Swirl wrote: >> Blue Swirl (6): >>   TCG: split i386 and x86_64 >>   TCG: clean up i386 and x86_64 > > I object to these.  I do NOT think splitting these makes the code base > as a

Re: [Qemu-devel] [PATCH 0/2] fix startup crash on sparc/ppc guests

2012-02-14 Thread Blue Swirl
On Tue, Feb 14, 2012 at 09:19, Paolo Bonzini wrote: > The problem happens when qdev_set_prop_* is passed a NULL pointer. > The first patch allows this; the second improves the error message > if there are problems with qdev properties, as requested by Peter. > > Blue Swirl, can you

Re: [Qemu-devel] [MASCOT CONTEST] Benoit Canet #2

2012-02-15 Thread Blue Swirl
On Wed, Feb 15, 2012 at 17:29, Alexander Graf wrote: > > On 15.02.2012, at 17:27, Paolo Bonzini wrote: > >> On 02/15/2012 03:34 PM, Anthony Liguori wrote: >>> Please respond to this note with an '+1', or an Ack, to vote for this icon. >> >> ACK > > I only see the reply, not the original message? I

Re: [Qemu-devel] [PATCH v1 1/1] gdbserver: Keep VM state status replies from happening during a syscall

2012-02-15 Thread Blue Swirl
On Wed, Feb 15, 2012 at 16:55, Meador Inge wrote: > Fix an issue where the GDB server implementation was allowing > 'RUN_STATE_DEBUG' > transitions to send a signal trap status back to the GDB client while a > syscall > is being processed.  This eventually resulted in sending a SIGINT to the GDB

[Qemu-devel] [PATCH] i386: Remove REGPARM

2012-02-15 Thread Blue Swirl
Use stack based calling convention (GCC default) for interfacing with generated code instead of register based convention (regparm(3)). Signed-off-by: Blue Swirl --- Performance test results would be appreciated. Quickly tried on i386 and x86_64 hosts with 32 and 64 bit guests. --- osdep.h

Re: [Qemu-devel] [PATCH] i386: Remove REGPARM

2012-02-15 Thread Blue Swirl
On Wed, Feb 15, 2012 at 19:36, Richard Henderson wrote: > On 02/15/2012 10:11 AM, Blue Swirl wrote: >>  #if defined(CONFIG_SOFTMMU) >> -    int mem_index, s_bits, arg_idx; >> +    int mem_index, s_bits; >> +#if TCG_TARGET_REG_BITS == 64 >> +    int arg_idx; &

Re: [Qemu-devel] [MASCOT CONTEST] Clare Liguori #1

2012-02-15 Thread Blue Swirl
On Wed, Feb 15, 2012 at 14:46, Anthony Liguori wrote: > Please respond to this note with an '+1', or an Ack, to vote for this icon. +1

Re: [Qemu-devel] [MASCOT CONTEST] Benoit Canet #2

2012-02-15 Thread Blue Swirl
On Wed, Feb 15, 2012 at 14:34, Anthony Liguori wrote: > Please respond to this note with an '+1', or an Ack, to vote for this icon. +1

Re: [Qemu-devel] [PATCH v2 03/21] pci: pci capability must be in PCI space

2012-10-13 Thread Blue Swirl
On Tue, Oct 9, 2012 at 3:30 AM, Jason Baron wrote: > From: Isaku Yamahata > > pci capability must be in PCI space. > It can't lay in PCIe extended config space. > > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron > --- > hw/pci.c |5 ++--- > 1 files changed, 2 insertions(+), 3 d

<    1   2   3   4   5   6   7   8   9   10   >