Re: [Qemu-devel] [PATCH] ati-vga: i2c fix

2019-03-14 Thread BALATON Zoltan
ata); +#endif Thanks, I'll try and merge this. What's this #if 0 line? Regards, BALATON Zoltan +break; +case GPIO_DVI_DDC: +if (s->dev_id == PCI_DEVICE_ID_ATI_RAGE128_PF) { +break; } +s->regs.gpio_dvi_ddc = ati_i2c(s->bbi2c, data); break; case GPIO_MONID: if (s->dev_id != PCI_DEVICE_ID_ATI_RAGE128_PF) {

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-14 Thread BALATON Zoltan
more knowledge about MIPS to tell what might be the problem. Regards, BALATON Zoltan

Re: [Qemu-devel] Data bus error with redeonfb on mips_fulong2e

2019-03-14 Thread BALATON Zoltan
On Thu, 14 Mar 2019, Aleksandar Markovic wrote: From: BALATON Zoltan Subject: Data bus error with redeonfb on mips_fulong2e Hello, Trying to debug the Linux kernel oops with radeonfb I've added some more debug logs and got this: radeonfb_pci_register BEGIN pci_host_data: pci_data_read

Re: [Qemu-devel] Data bus error with redeonfb on mips_fulong2e

2019-03-15 Thread BALATON Zoltan
On Fri, 15 Mar 2019, Philippe Mathieu-Daudé wrote: On 3/14/19 11:08 PM, BALATON Zoltan wrote: On Thu, 14 Mar 2019, Aleksandar Markovic wrote: From: BALATON Zoltan Subject: Data bus error with redeonfb on mips_fulong2e Hello, Trying to debug the Linux kernel oops with radeonfb I've

[PATCH] target/ppc/cpu.h: Remove duplicate includes

2020-02-12 Thread BALATON Zoltan
Commit 74433bf083b added some includes but added them twice. Since these are guarded against multiple inclusion including them once is enough. Signed-off-by: BALATON Zoltan --- target/ppc/cpu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h index

[PATCH] target/ppc: Fix typo in comments

2020-02-13 Thread BALATON Zoltan
"Deferred" was misspelled as "differed" in some comments, correct this typo, Signed-off-by: BALATON Zoltan --- target/ppc/fpu_helper.c| 2 +- target/ppc/translate/fp-impl.inc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/targe

[PATCH v2] target/ppc: Fix typo in comments

2020-02-14 Thread BALATON Zoltan
"Deferred" was misspelled as "differed" in some comments, correct this typo, Signed-off-by: BALATON Zoltan --- v2: Found one more where even the typo was misspelled target/ppc/fpu_helper.c| 4 ++-- target/ppc/translate/fp-impl.inc.c | 6 +++--- 2 files changed

[PATCH 2/2] target/ppc/cpu.h: Clean up comments in the struct CPUPPCState definition

2020-02-16 Thread BALATON Zoltan
The cpu env struct is quite complex but comments supposed to explain it in its definition just make it harder to read. Reformat and reword some comments to make it clearer and more readable. Signed-off-by: BALATON Zoltan --- target/ppc/cpu.h | 145

[PATCH 1/2] target/ppc/cpu.h: Move fpu related members closer in cpu env

2020-02-16 Thread BALATON Zoltan
Move fp_status and fpscr closer to other floating point and vector related members in cpu env definition so they are in one group. Signed-off-by: BALATON Zoltan --- target/ppc/cpu.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h

[PATCH 0/2] Small clean up in target/ppc/cpu.h

2020-02-16 Thread BALATON Zoltan
Just some small clean ups to improve readability of struct CPUPPCState. BALATON Zoltan (2): target/ppc/cpu.h: Move fpu related members closer in cpu env target/ppc/cpu.h: Clean up comments in the struct CPUPPCState definition target/ppc/cpu.h | 146

Re: [PATCH v3] Implement the Screamer sound chip for the mac99 machine type

2020-02-16 Thread BALATON Zoltan
es if debugging is still needed. I don't mind DPRINTFs that much at least until things are stable enough but once the code is stable most DPRINTFs may not be needed any more. I can't really review the actual patch because I don't know audio in QEMU. Regards, BALATON Zoltan

[RFC PATCH 0/2] Enable hardfloat for PPC

2020-02-16 Thread BALATON Zoltan
this would break or give some ideas how this could be improved. Regards, BALATON Zoltan BALATON Zoltan (2): target/ppc/cpu: Add hardfloat property target/ppc: Enable hardfloat for PPC fpu/softfloat.c | 14 +++--- target/ppc/cpu.h| 2 ++ target

[RFC PATCH 1/2] target/ppc/cpu: Add hardfloat property

2020-02-16 Thread BALATON Zoltan
Add a property to allow setting a flag in cpu env that will be used to control if hardfloat is used for floating point ops (i.e. speed is preferred over accuracy). Signed-off-by: BALATON Zoltan --- target/ppc/cpu.h| 2 ++ target/ppc/translate_init.inc.c | 2 ++ 2 files changed

[RFC PATCH 2/2] target/ppc: Enable hardfloat for PPC

2020-02-16 Thread BALATON Zoltan
ned-off-by: BALATON Zoltan --- fpu/softfloat.c | 14 +++--- target/ppc/fpu_helper.c | 7 ++- target/ppc/translate_init.inc.c | 2 +- 3 files changed, 14 insertions(+), 9 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 301ce3b537..6d3f4af72a 100644

Re: [RFC PATCH 0/2] Enable hardfloat for PPC

2020-02-17 Thread BALATON Zoltan
On Mon, 17 Feb 2020, Peter Maydell wrote: On Mon, 17 Feb 2020 at 02:43, BALATON Zoltan wrote: Hello, This is an RFC series to start exploring the possibility of enabling hardfloat for PPC target that haven't progressed in the last two years. Hopefully we can work out something now. Previ

[RFC PATCH v2] target/ppc: Enable hardfloat for PPC

2020-02-18 Thread BALATON Zoltan
or testing different workloads to evaluate how viable would this be in practice. Thus, RFC and not ready for merge yet. Signed-off-by: BALATON Zoltan --- v2: use different approach to avoid needing if () in helper_reset_fpstatus() but this does not seem to change overhead much, also make it a singl

Re: [RFC PATCH v2] target/ppc: Enable hardfloat for PPC

2020-02-18 Thread BALATON Zoltan
On Tue, 18 Feb 2020, BALATON Zoltan wrote: While other targets take advantage of using host FPU to do floating point computations, this was disabled for PPC target because always clearing exception flags before every FP op made it slightly slower than emulating everyting with softfloat. To

Re: [PATCH v3 02/12] ppc: Remove stub of PPC970 HID4 implementation

2020-02-19 Thread BALATON Zoltan
could be removed now. (Does this count as a double ; that a recent patch was trying to fix?) Regards, BALATON Zoltan } env->spr[SPR_LPCR] = lpcr; diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c index a0d0eaabf2..d7d4f012b8 100644 --- a/target/ppc/tr

Re: [RFC PATCH v2] target/ppc: Enable hardfloat for PPC

2020-02-19 Thread BALATON Zoltan
Hello, On Tue, 18 Feb 2020, Programmingkid wrote: On Feb 18, 2020, at 12:10 PM, BALATON Zoltan wrote: While other targets take advantage of using host FPU to do floating point computations, this was disabled for PPC target because always clearing exception flags before every FP op made it

RE: Emulating Solaris 10 on SPARC64 sun4u

2020-02-19 Thread BALATON Zoltan
e, it may be expecting more interrupts than QEMU is generating or it may expect them to arrive with some delay or after previous one is cleared that QEMU could just raise once due to being faster or doing something differently? Does someone know what interrupts are generated on real hardware in DMA mode so we can compare that to what we see with QEMU? Regards, BALATON Zoltan

Re: [RFC PATCH v2] target/ppc: Enable hardfloat for PPC

2020-02-19 Thread BALATON Zoltan
in VM or one was on host (I'd guess OSX host with Linux and Windows VMs). Linux and OSX (with brew) use default compilers. Windows build cross-compiled from Fedora with x86_64-win64-mingw32 I assume Linux and OSX were 64 bit builds, is Windows 32 bit or 64 bit exe? Regards, BALATON Zoltan

RE: Emulating Solaris 10 on SPARC64 sun4u

2020-02-19 Thread BALATON Zoltan
On Wed, 19 Feb 2020, BALATON Zoltan wrote: faster or doing something differently? Does someone know what interrupts are generated on real hardware in DMA mode so we can compare that to what we see with QEMU? The document Programming Interface for Bus Master IDE Controller, Revision 1.0 (5/16

Re: QEMU VM crashes when enabling KVM

2019-12-12 Thread BALATON Zoltan
s some more freedom about host and guest as only user space runs on host CPU with privileged instructions are software emulated but mixing BookE and BookS is not supported even with PR KVM if I'm not mistaken. So you may have better luck with some BookS host but I can't tell for sure. Regrads, BALATON Zoltan

Re: [PATCH 2/3] q800: add djMEMC memory controller

2019-12-12 Thread BALATON Zoltan
ine Bank9Conf 10 +#define MemTop11 +#define Config12 +#define Refresh 13 Should this be an enum so the compiler can better verify values and if all cases are handled? Regards, BALATON Zoltan

Re: [PATCH] ppc: remove excessive logging

2019-12-15 Thread BALATON Zoltan
and not sure about potential performance impact). So my preferences would be in order: 1. leave it alone, 2. remove it, 3. convert to traces. Regards, BALATON Zoltan msr |= 0x0008; env->spr[SPR_BOOKE_ESR] = ESR_PIL; break;

Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board

2019-11-26 Thread BALATON Zoltan
me or similar components that I'm interested in for PPC machines emulation (VIA superio for Pegasos2 and ati-vga) and it was a good way to cross check these with something else but otherwise I don't use the MIPS boards. Regards, BALATON Zoltan

Re: [RFC 0/8] ATI R300 emulated graphics card

2019-11-26 Thread BALATON Zoltan
at existing devices and asking here or on IRC (if you prefer that, I don't use it but I know some do). Regards, BALATON Zoltan

Re: [RFC 09/10] Clean up Radeon Header files

2019-11-27 Thread BALATON Zoltan
hen the device can access system memory directly so we don't need to model the whole IOMMU/DMA but I'm not sure what GART is used for so I may be wrong. Comments from those who know more about ATI GPUs are welcome. Regards, BALATON Zoltan

Re: [RFC 00/10] R300 QEMU device V2

2019-11-27 Thread BALATON Zoltan
re & if we have any general policies about it ? I don't know but this may be similar to boards needing firmware ROMs or the firmware blobs needed by some Linux kernel drivers. How are those handled? Distros usually put them in a non-free repo I think. Regrads, BALATON Zoltan

Re: [RFC 00/10] R300 QEMU device V2

2019-11-29 Thread BALATON Zoltan
cumented. I've also said before that Xenia emulator has some code to parse command packets of the XBox 360 GPU which is similar to some late r5xx GPUs so some of these might be useful for emulating previous Radeons as well. Regards, BALATON Zoltan

Re: [RFC 0/1] ATI R300 emulated grpahics card V2

2019-11-29 Thread BALATON Zoltan
ind out which opcode means what. This microengine is probably very similar throughout the early Radeons, only the microcode changes so if we could implement that it might work for several cards (also even for Rage128Pro). Regards, BALATON Zoltan

Re: [RFC 0/1] ATI R300 emulated grpahics card V2

2019-11-30 Thread BALATON Zoltan
On Fri, 29 Nov 2019, BALATON Zoltan wrote: If the microcode of the microengine/CCE could be reversed or is documented somewhere it may be easier to implement emulation of that instead of doing the packet parsing for all possible command packets of which there are quite a lot, but in the real

[Qemu-devel] [PATCH 1/7] ati-vga: Add registers for getting apertures

2019-08-11 Thread BALATON Zoltan
Some drivers (e.g. Linux radeon drm and MacOS) access these to find apertures to access card. Try to implement these but not sure these are correct yet. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 15 +++ hw/display/ati_dbg.c | 5 + hw/display/ati_regs.h | 5

[Qemu-devel] [PATCH 0/7] Resend of all outstanding ati-vga patches

2019-08-11 Thread BALATON Zoltan
that may also need VBlank interrupts emulated so it won't boot yet. Regards, BALATON Zoltan BALATON Zoltan (7): ati-vga: Add registers for getting apertures ati-vga: Add some register definitions for debugging ati-vga: Fix GPIO_MONID register write ati-vga: Fix cursor color

[Qemu-devel] [PATCH 3/7] ati-vga: Fix GPIO_MONID register write

2019-08-11 Thread BALATON Zoltan
Also update bitbang_i2c state when output bits are changed while enable bits are set. This fixes EDID access by the ATI FCode ROM. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/display/ati.c b/hw/display

[Qemu-devel] [PATCH 7/7] ati-vga: Add limited support for big endian frame buffer aperture

2019-08-11 Thread BALATON Zoltan
x but MacOS has other problems yet so for now this might work. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 10 +- hw/display/ati_int.h | 1 + hw/display/ati_regs.h | 2 ++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/display/ati.c b/hw/display/ati.c

[Qemu-devel] [PATCH 6/7] ati-vga: Attempt to handle CRTC offset not exact multiple of stride

2019-08-11 Thread BALATON Zoltan
I wonder if they should be shared in case some drivers try to poke them via VGA regs or these are a separate set of regs for extended mode. Added a comment noting this but drivers I've tried so far program the card accessing ati regs so I did not attempt to change it. Signed-off-by: BALATON Z

[Qemu-devel] [PATCH 5/7] ati-vga: Fix hardware cursor image offset

2019-08-11 Thread BALATON Zoltan
The crtc_offset is not needed, cur_offset is relative to the start of vram not the start of displayed area. This fixes broken pointer image with MacOS that uses non-0 crtc_offset. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions

[Qemu-devel] [PATCH 2/7] ati-vga: Add some register definitions for debugging

2019-08-11 Thread BALATON Zoltan
stead. But since these are often probed by drivers it helps to see what happens by logging these registers by name. Signed-off-by: BALATON Zoltan --- hw/display/ati_dbg.c | 4 hw/display/ati_regs.h | 4 2 files changed, 8 insertions(+) diff --git a/hw/display/ati_dbg.c b/hw/display/ati_d

[Qemu-devel] [PATCH 4/7] ati-vga: Fix cursor color with guest_hwcursor=true

2019-08-11 Thread BALATON Zoltan
Fixes: a38127414bd007c5b6ae64c664d9e8839393277e Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index 699f38223b..b849f5d510 100644 --- a/hw/display/ati.c +++ b/hw/display/ati.c @@ -207,7

Re: [Qemu-devel] [PATCH 4/7] ati-vga: Fix cursor color with guest_hwcursor=true

2019-08-12 Thread BALATON Zoltan
On Mon, 12 Aug 2019, Philippe Mathieu-Daudé wrote: On 8/11/19 11:14 PM, BALATON Zoltan wrote: Fixes: a38127414bd007c5b6ae64c664d9e8839393277e Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/ati.c b/hw/display

Re: [Qemu-devel] [PATCH 4/7] ati-vga: Fix cursor color with guest_hwcursor=true

2019-08-12 Thread BALATON Zoltan
On Mon, 12 Aug 2019, Philippe Mathieu-Daudé wrote: On 8/12/19 12:28 PM, BALATON Zoltan wrote: On Mon, 12 Aug 2019, Philippe Mathieu-Daudé wrote: On 8/11/19 11:14 PM, BALATON Zoltan wrote: Fixes: a38127414bd007c5b6ae64c664d9e8839393277e Signed-off-by: BALATON Zoltan --- ?hw/display/ati.c | 2

Re: [Qemu-devel] [PATCH 0/2] hw/display: Compile various display devices as common object

2019-08-12 Thread BALATON Zoltan
y: Compile various display devices as common object hw/display/Makefile.objs | 18 +- hw/display/sm501.c | 1 - 2 files changed, 9 insertions(+), 10 deletions(-) Acked-by: BALATON Zoltan For sm501 and ati-vga parts. Regards, BALATON Zoltan

[Qemu-devel] [RFC PATCH] ati-vga: Implement dummy VBlank IRQ

2019-08-14 Thread BALATON Zoltan
itted upstream yet. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 41 + hw/display/ati_dbg.c | 1 + hw/display/ati_int.h | 4 hw/display/ati_regs.h | 1 + 4 files changed, 47 insertions(+) diff --git a/hw/display/ati.c b/hw/display/ati.c

Re: [Qemu-devel] [RFC PATCH] ati-vga: Implement dummy VBlank IRQ

2019-08-15 Thread BALATON Zoltan
On Thu, 15 Aug 2019, Gerd Hoffmann wrote: On Thu, Aug 15, 2019 at 02:25:07AM +0200, BALATON Zoltan wrote: The MacOS driver exits if the card does not have an interrupt. If we set PCI_INTERRUPT_PIN to 1 then it enables VBlank interrupts and it boots but the mouse poniter can not be moved. This

Re: [Qemu-devel] [RFC PATCH] ati-vga: Implement dummy VBlank IRQ

2019-08-15 Thread BALATON Zoltan
use we could get reg content in pieces and we need to decide when it's complete to act on it. I'll try to fix that and then it hopefully will work (well, at least boot to see it fail whenever tries to use any unimplemented acceleration but at least we can test emulation with it when further pieces are implemented in the future). Regards, BALATON Zoltan

[Qemu-devel] [PATCH 1/3] ati-vga: Implement dummy VBlank IRQ

2019-08-15 Thread BALATON Zoltan
still hangs somewhere before completely finishing boot. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 44 hw/display/ati_dbg.c | 1 + hw/display/ati_int.h | 4 hw/display/ati_regs.h | 6 ++ 4 files changed, 55 insertions

[Qemu-devel] [PATCH 3/3] ati-vga: Silence some noisy traces

2019-08-15 Thread BALATON Zoltan
Some registers are accessed very frequently so exclude these from traces to avoid flooding output with a lot of trace logs when traces are enabled thus helping debugging. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions

[Qemu-devel] [PATCH 0/3] ati-vga fixes for MacOS driver

2019-08-15 Thread BALATON Zoltan
still miss something somewhere. (Also to get to this point one needs to run an FCode ROM which needs patches to OpenBIOS currently.) Regards, BALATON Zoltan BALATON Zoltan (3): ati-vga: Implement dummy VBlank IRQ ati-vga: Support unaligned access to hardware cursor registers ati-vga: Silence

[Qemu-devel] [PATCH 2/3] ati-vga: Support unaligned access to hardware cursor registers

2019-08-15 Thread BALATON Zoltan
This fixes horizontal mouse movement and pointer color with MacOS that writes these registers with access size less than 4 so previously only the last portion of access was effective overwriting previous partial writes. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 87

[Qemu-devel] Machine specific option ROMs

2019-08-18 Thread BALATON Zoltan
is that too late by then to change ROM of the device? (Also this may need to work together with the -vga option to ensure card has the right ROM on different machines even if added by -vga.) Regards, BALATON Zoltan

Re: [Qemu-devel] Machine specific option ROMs

2019-08-19 Thread BALATON Zoltan
On Mon, 19 Aug 2019, Gerd Hoffmann wrote: > On Mon, Aug 19, 2019 at 02:38:09AM +0200, BALATON Zoltan wrote: >> I know about the possibility to set the option ROM of a PCIDevice with the >> romfile property (that we can set on command line or in a device's init >> method)

Re: [Qemu-devel] Machine specific option ROMs

2019-08-20 Thread BALATON Zoltan
s VGABios so then we can't put those in one binary because we had two x86 images in it. Therefore I think setting this based on machine like above is probably the easiest way for now. I'll wait for Mark's comments before going further with this. Regards, BALATON Zoltan

[Qemu-devel] [PATCH] ati-vga: Add limited support for big endian frame buffer aperture

2019-07-29 Thread BALATON Zoltan
Set frame buffer endianness according to requested endianness for frame buffer aperture 0. This fixes inverted colors with Xorg frame buffer driver. Setting endianness of aperture 1 and reg aperture are not implemented. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 9 - hw

Re: [PATCH v2 01/30] hw/arm/raspi: Use BCM2708 machine type with pre Device Tree kernels

2020-02-06 Thread BALATON Zoltan
.img here by default */ #define SPINTABLE_ADDR 0xd8 /* Pi 3 bootloader spintable */ -/* Table of Linux board IDs for different Pi versions */ -static const int raspi_boardid[] = {[1] = 0xc42, [2] = 0xc43, [3] = 0xc44}; Maybe worth a comment about why using this number (short, one line versi

Re: [PATCH v2 04/30] hw/arm/raspi: Extract the RAM size from the board revision

2020-02-06 Thread BALATON Zoltan
is not clear from the above and user getting it after a command line does not have context to tell what the printed number means. Regards, BALATON Zoltan +g_free(size_str); exit(1); }

Re: [PATCH v2 07/30] hw/arm/raspi: Make machines children of abstract RaspiMachineClass

2020-02-06 Thread BALATON Zoltan
On Thu, 6 Feb 2020, Philippe Mathieu-Daudé wrote: QOM'ify RaspiMachineState. Now machines inherite of RaspiMachineClass. Typo: inherite -> inherit Regards, BALATON Zoltan Cc: Igor Mammedov Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/rasp

Re: [PATCH v2 01/30] hw/arm/raspi: Use BCM2708 machine type with pre Device Tree kernels

2020-02-07 Thread BALATON Zoltan
On Fri, 7 Feb 2020, Philippe Mathieu-Daudé wrote: On 2/6/20 1:21 PM, BALATON Zoltan wrote: On Thu, 6 Feb 2020, Philippe Mathieu-Daudé wrote: When booting without device tree, the Linux kernels uses the $R1 register to determine the machine type. The list of values is registered at [1]. There

RE: Emulating Solaris 10 on SPARC64 sun4u

2020-02-07 Thread BALATON Zoltan
omething out. I've cc'd the IDE maintainer in case he has something more useful to add. Regards, BALATON Zoltan I've also tried using kmdb (Solaris kernel debugger) by running using `boot cdrom -kvd` at the OpenBIOS prompt. I thought this might help diagnose the problem. Af

RE: Emulating Solaris 10 on SPARC64 sun4u

2020-02-10 Thread BALATON Zoltan
On Sat, 8 Feb 2020, BALATON Zoltan wrote: Not sure if my problem I see on other machine emulation I'm working on is related at all but there's a possibility it might be. I got this with different arch (ppc but could also reproduce something similar with mips) and ide controller emul

Missing IRQ with bmdma on ppc/mips/sparc? (was: Re: Emulating Solaris 10 on SPARC64 sun4u)

2020-02-10 Thread BALATON Zoltan
I've changed title to avoid derailing the original thread as this is more about pegasos2 issue now but left cc list for now. Let me know if you don't want to be cc'd. On Mon, 10 Feb 2020, John Snow wrote: On 2/10/20 10:38 AM, BALATON Zoltan wrote: On Sat, 8 Feb 2020, BALAT

Re: [RFC 0/1] ATI R300 emulated grpahics card V2

2020-02-10 Thread BALATON Zoltan
On Sat, 30 Nov 2019, BALATON Zoltan wrote: That's all I could find out so far, any help to get further is appreciated. I've created a ticket at my qmiga.osdn.io page where I've summarised previous discussion at one place which could be used to track what we know about it. Se

Re: [PATCH] bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx

2023-01-10 Thread BALATON Zoltan
DR_PRIx PRIx64 Why are there both TARGET_FMT_plx and HWADDR_PRIx? Why not just use HWADDR_PRIx instead? Regards, BALATON Zoltan

Re: [PATCH v7 6/7] mac_newworld: Deprecate mac99 "via" option

2023-01-10 Thread BALATON Zoltan
On Tue, 10 Jan 2023, Mark Cave-Ayland wrote: On 04/01/2023 21:59, BALATON Zoltan wrote: Setting emulated machine type with a property called "via" is confusing users so deprecate the "via" option in favour of newly added explicit machine types. The default via=cuda option i

Re: [PATCH v7 4/7] mac_newworld: Add machine types for different mac99 configs

2023-01-10 Thread BALATON Zoltan
On Tue, 10 Jan 2023, Mark Cave-Ayland wrote: On 04/01/2023 21:59, BALATON Zoltan wrote: The mac99 machine emulates different machines depending on machine properties or even if it is run as qemu-system-ppc64 or qemu-system-ppc. This is very confusing for users and many hours were lost trying to

Re: [PATCH v7 3/7] mac_{old,new}world: Pass MacOS VGA NDRV in card ROM instead of fw_cfg

2023-01-10 Thread BALATON Zoltan
On Tue, 10 Jan 2023, Mark Cave-Ayland wrote: On 04/01/2023 21:59, BALATON Zoltan wrote: OpenBIOS cannot run FCode ROMs yet but it can detect NDRV in VGA card ROM and add it to the device tree for MacOS. Pass the NDRV this way instead of via fw_cfg. This solves the problem with OpenBIOS also

Re: [PATCH v7 6/7] mac_newworld: Deprecate mac99 "via" option

2023-01-12 Thread BALATON Zoltan
On Thu, 12 Jan 2023, Howard Spoelstra wrote: On Wed, Jan 11, 2023 at 1:15 AM BALATON Zoltan wrote: On Tue, 10 Jan 2023, Mark Cave-Ayland wrote: On 04/01/2023 21:59, BALATON Zoltan wrote: Setting emulated machine type with a property called "via" is confusing users so deprecat

Re: [PATCH 07/31] e1000: Use more constant definitions

2023-01-12 Thread BALATON Zoltan
if using -1 wouldn't be simpler, otherwise great Comparing unsigned type with negative value does not seem very clean to me. Either of the above (0x or UINT32_MAX) is more explicit and easier to understand. Regards, BALATON Zoltan cleanup! Reviewed-by: Philippe Mathieu-

Re: [PATCH v7 6/7] mac_newworld: Deprecate mac99 "via" option

2023-01-13 Thread BALATON Zoltan
On Fri, 13 Jan 2023, Howard Spoelstra wrote: On Fri, Jan 13, 2023 at 12:53 AM BALATON Zoltan wrote: The names also show what we intend to emulate even though the emulation may not be complete or have bugs (this is also true for other machines in QEMU where a lot of them are not fully emulated

Re: Display update issue on M1 Macs

2023-01-13 Thread BALATON Zoltan
On Thu, 5 Jan 2023, BALATON Zoltan wrote: Hello, I got reports from several users trying to run AmigaOS4 on sam460ex on Apple silicon Macs that they get missing graphics that I can't reproduce on x86_64. With help from the users who get the problem we've narrowed it down to the

Re: Display update issue on M1 Macs

2023-01-14 Thread BALATON Zoltan
On Sat, 14 Jan 2023, Akihiko Odaki wrote: On 2023/01/13 22:43, BALATON Zoltan wrote: On Thu, 5 Jan 2023, BALATON Zoltan wrote: Hello, I got reports from several users trying to run AmigaOS4 on sam460ex on Apple silicon Macs that they get missing graphics that I can't reproduce on x

Re: [PATCH 2/2] hw/ppc/pegasos2: Extract via_vt8231_create() helper

2023-01-17 Thread BALATON Zoltan
ome of it elsewhere then OK otherwise I'd say I'm OK with how it is now, it's just the normal unreadable QOM stuff you see everywhere after removing legacy init functions. Regards, BALATON Zoltan - "date"); -qdev_connect_

[PATCH] ppc/pegasos2: Improve readability of VIA south bridge creation

2023-01-17 Thread BALATON Zoltan
Slightly improve readability of creating the south btidge by cnamging type of a local variable to avoid some casts within function arguments which makes some lines shorter and easier to read. Also remove an unneded line break. Signed-off-by: BALATON Zoltan --- hw/ppc/pegasos2.c | 14

Re: [PATCH] ppc/pegasos2: Improve readability of VIA south bridge creation

2023-01-17 Thread BALATON Zoltan
On Tue, 17 Jan 2023, BALATON Zoltan wrote: Slightly improve readability of creating the south btidge by cnamging Still left a typo in "bridge" above... This is alternative, inspired by Phil's patches, maybe I'd also need to add Inspired-by: tag. type of a local variable

[PATCH 1/4] hw/misc/macio: Avoid some QOM casts

2023-01-17 Thread BALATON Zoltan
At several places we already have the object pointer with the right type so we don't need to cast it back and forth. Avoiding these casts improves readability. Signed-off-by: BALATON Zoltan --- hw/misc/macio/macio.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

[PATCH 4/4] hw/misc/macio: Return bool from functions taking errp

2023-01-17 Thread BALATON Zoltan
Use the convention to return bool from functions which take an error pointer which allows for callers to pass through their error pointer without needing a local. Signed-off-by: BALATON Zoltan --- hw/misc/macio/macio.c | 62 +-- 1 file changed, 25

[PATCH 3/4] hw/misc/macio: Remove some single use local variables

2023-01-17 Thread BALATON Zoltan
Drop some local variables that could just be substituted at the single place they were used. This makes the code shorter and simpler. Signed-off-by: BALATON Zoltan --- hw/misc/macio/macio.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/misc/macio/macio.c b

[PATCH 0/4] Misc macio clean ups

2023-01-17 Thread BALATON Zoltan
Just some small trivial clean ups that I've found while looking at hw/misc/macio/macio.c Regards, BALATON Zoltan BALATON Zoltan (4): hw/misc/macio: Avoid some QOM casts hw/misc/macio: Rename sysbus_dev to sbd for consistency and brevity hw/misc/macio: Remove some single use local vari

[PATCH 2/4] hw/misc/macio: Rename sysbus_dev to sbd for consistency and brevity

2023-01-17 Thread BALATON Zoltan
Some functions use sysbus_dev while others sbd name for local variable storing a sysbus device pointer. Standardise on the shorter name to be consistent and make the code easier to read as short name is less distracting and needs less line breaks. Signed-off-by: BALATON Zoltan --- hw/misc/macio

[PATCH v2] ppc/pegasos2: Improve readability of VIA south bridge creation

2023-01-18 Thread BALATON Zoltan
Slightly improve readability of creating the south bridge by changing type of a local variable to avoid some casts within function arguments which makes some lines shorter and easier to read. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé --- v2: Fixed typos in commit message

Re: [PATCH 2/2] hw/ppc/pegasos2: Extract via_vt8231_create() helper

2023-01-18 Thread BALATON Zoltan
On Wed, 18 Jan 2023, Philippe Mathieu-Daudé wrote: On 17/1/23 22:17, BALATON Zoltan wrote: On Tue, 17 Jan 2023, Philippe Mathieu-Daudé wrote: Simplify a bit pegasos2_init() by extracting the VIA southbridge creation code into a new via_vt8231_create() helper. Signed-off-by: Philippe Mathieu

[PATCH 1/2] log: Add separate debug option for logging invalid memory accesses

2023-01-19 Thread BALATON Zoltan
a new -d memaccess option to make it possible to control it independently of other guest error logs. Signed-off-by: BALATON Zoltan --- include/qemu/log.h | 1 + softmmu/memory.c | 6 +++--- softmmu/physmem.c | 2 +- util/log.c | 2 ++ 4 files changed, 7 insertions(+), 4 deletions

[PATCH 2/2] log: remove unneeded new line

2023-01-19 Thread BALATON Zoltan
The help text of the -d plugin option has a new line at the end which is not needed as one is added automatically. Fixing it removes the unexpected empty line in -d help output. Signed-off-by: BALATON Zoltan --- util/log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util

[PATCH] mac_nvram: Add block backend to persist NVRAM contents

2023-01-19 Thread BALATON Zoltan
for mac_oldworld for now but could be used by mac_newworld in the future too. Signed-off-by: BALATON Zoltan --- hw/nvram/mac_nvram.c | 28 hw/ppc/mac_oldworld.c| 8 +++- include/hw/nvram/mac_nvram.h | 1 + 3 files changed, 36 insertions(+), 1

Re: [PATCH v2 0/4] bulk: Replace TARGET_FMT_plx by HWADDR_PRIx

2023-01-20 Thread BALATON Zoltan
this might cause. I don't mind too much so maybe isn't worth the churn to have another patch for this. I'll let Philippe decide what he wants to do with it. Regards, BALATON Zoltan

Re: Audio playback speed issue on sam460ex and pegasos2

2023-03-29 Thread BALATON Zoltan
On Wed, 29 Mar 2023, Volker Rümelin wrote: Am 29.03.23 um 21:20 schrieb BALATON Zoltan: On Tue, 28 Mar 2023, Volker Rümelin wrote: it seems your Mac uses a 48kHz sample rate, although QEMU requested a 44.1kHz sample rate. Could you add -audiodev coreaudio,id=audio0,out.frequency=48000 to your

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-04-04 Thread BALATON Zoltan
lation in QEMU currently can't boot these because the machine is not emulated precisely enough for them.) Regards, BALATON Zoltan

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-04-04 Thread BALATON Zoltan
atch to start deprecating these but I could not get that merged. That thread ended here: https://lists.nongnu.org/archive/html/qemu-ppc/2023-01/msg00406.html Regards, BALATON Zoltan

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-04-04 Thread BALATON Zoltan
for anything than a Linux guest. Regards, BALATON Zoltan

Re: [PULL 092/126] hw/display/sm501: Add fallbacks to pixman routines

2023-04-04 Thread BALATON Zoltan
On Tue, 4 Apr 2023, Peter Maydell wrote: On Mon, 27 Feb 2023 at 14:38, Philippe Mathieu-Daudé wrote: From: BALATON Zoltan Pixman may return false if it does not have a suitable implementation. Add fallbacks to handle such cases. Signed-off-by: BALATON Zoltan Reported-by: Rene Engel

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-04-05 Thread BALATON Zoltan
On Wed, 5 Apr 2023, Thomas Huth wrote: On 04/04/2023 17.42, BALATON Zoltan wrote: On Tue, 4 Apr 2023, Cédric Le Goater wrote: [ adding Zoltan ] On 4/4/23 16:00, Thomas Huth wrote: On 05/02/2023 23.12, Mark Cave-Ayland wrote: On 30/01/2023 20:45, Alex Bennée wrote: Daniel P. Berrangé

[PATCH] hw/display/sm501: Remove unneeded increment from loop

2023-04-05 Thread BALATON Zoltan
. Reported-by: Peter Maydell Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index dbabbc4339..0eecd00701 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -901,7 +901,7 @@ static

Re: [PATCH 0/2] tests/migration: add support for ppc64le in guestperf.py

2023-01-21 Thread BALATON Zoltan
k you, BALATON Zoltan

[PATCH 3/3] hw/display/sm501: Code style fix

2023-01-21 Thread BALATON Zoltan
Fix checkpatch warning about multi-line comment. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 1e17072452..e1d0591d36 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501

[PATCH 2/3] hw/display/sm501: Remove unneeded casts from void pointer

2023-01-21 Thread BALATON Zoltan
This is not needed in C. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 0cbd1fecd5..1e17072452 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501

[PATCH 0/3] Misc sm501 clean ups

2023-01-21 Thread BALATON Zoltan
Some small trivial clean ups I've found while looking at this file. BALATON Zoltan (3): hw/display/sm501: Remove parenthesis around consant macro definitions hw/display/sm501: Remove unneeded casts from void pointer hw/display/sm501: Code style fix hw/display/sm501.c

[PATCH 1/3] hw/display/sm501: Remove parenthesis around consant macro definitions

2023-01-21 Thread BALATON Zoltan
No need to wrap constants in parenthesis. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 394 ++--- 1 file changed, 197 insertions(+), 197 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 52e42585af..0cbd1fecd5 100644 --- a

Re: [PATCH v7 0/8] Mac Old World ROM experiment

2023-01-22 Thread BALATON Zoltan
On Mon, 29 Jun 2020, BALATON Zoltan wrote: This is now a minimal set of patches needed to make it possible to experiment with a firmware ROM from real hardware. After finding out that the board firmware does not probe PCI devices but expects them at known fixed addresses we only need to change

Re: [PATCH] mac_nvram: Add block backend to persist NVRAM contents

2023-01-22 Thread BALATON Zoltan
On Fri, 20 Jan 2023, Cédric Le Goater wrote: On 1/19/23 23:28, BALATON Zoltan wrote: Add a way to set a backing store for the mac_nvram similar to what spapr_nvram or mac_via PRAM already does to allow to save its contents between runs. Use -drive file=nvram.img,format=raw,if=mtd to specify

Re: [PATCH v7 0/8] Mac Old World ROM experiment

2023-01-22 Thread BALATON Zoltan
On Sun, 22 Jan 2023, BALATON Zoltan wrote: On Mon, 29 Jun 2020, BALATON Zoltan wrote: This is now a minimal set of patches needed to make it possible to experiment with a firmware ROM from real hardware. After finding out that the board firmware does not probe PCI devices but expects them at

<    3   4   5   6   7   8   9   10   11   12   >