Re: [Qemu-devel] CPU hotplug, again

2016-02-23 Thread Bharata B Rao
On Tue, Feb 23, 2016 at 04:24:31PM +1100, David Gibson wrote: > Hi Andreas, > > I've now found (with Thomas' help) your RFC series for socket/core > based cpu hotplug on x86 > (https://github.com/afaerber/qemu-cpu/compare/qom-cpu-x86). It seems > sensible enough as far as it goes, but doesn't see

Re: [Qemu-devel] CPU hotplug, again

2016-02-23 Thread Bharata B Rao
On Tue, Feb 23, 2016 at 03:10:26PM +0530, Bharata B Rao wrote: > > 5) QOM-links > > Andreas, You have often talked about setting up links from machine object > to the CPU objects. Would the below code correctly capture that idea of > yours ? > > #define SPAPR_MAC

Re: [Qemu-devel] CPU hotplug, again

2016-02-23 Thread Bharata B Rao
On Wed, Feb 24, 2016 at 01:01:06PM +1100, David Gibson wrote: > On Tue, Feb 23, 2016 at 12:18:59PM +0100, Igor Mammedov wrote: > > On Tue, 23 Feb 2016 21:05:04 +1100 > > David Gibson wrote: > > > > > On Tue, Feb 23, 2016 at 03:10:26PM +0530, Bharata B Rao wrote: &

[Qemu-devel] [RFC PATCH v0 1/6] cpu: Abstract CPU core type

2016-02-25 Thread Bharata B Rao
Add an abstract CPU core type that could be used by machines that want to define and hotplug CPUs in core granularity. Signed-off-by: Bharata B Rao --- hw/cpu/Makefile.objs | 1 + hw/cpu/core.c | 22 ++ include/hw/cpu/core.h | 17 + 3 files changed

[Qemu-devel] [RFC PATCH v0 4/6] spapr: CPU hotplug support

2016-02-25 Thread Bharata B Rao
Set up device tree entries for the hotplugged CPU core and use the exising EPOW event infrastructure to send CPU hotplug notification to the guest. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 136 - hw/ppc/spapr_events.c | 3

[Qemu-devel] [RFC PATCH v0 0/6] Core based CPU hotplug for PowerPC sPAPR

2016-02-25 Thread Bharata B Rao
uot; for PowerPC (Probably not required) type: "spapr-cpu-core" for sPAPR realized: true/false indicating if the slot is populated or not I feel, the above information should be enough for the management to come up with an appropriate device_add command to create and fill a core into an

[Qemu-devel] [RFC PATCH v0 3/6] spapr: Represent boot CPUs as spapr-cpu-core devices

2016-02-25 Thread Bharata B Rao
l the CPU slots can be obtained by walking these links. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 65 +++--- include/hw/ppc/spapr.h | 3 +++ 2 files changed, 60 insertions(+), 8 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c

[Qemu-devel] [RFC PATCH v0 5/6] qmp, spapr: Show hot-plugged/pluggable CPU slots in the Machine

2016-02-25 Thread Bharata B Rao
Implement query cpu-slots that provides information about hot-plugged as well as hot-pluggable CPU slots that the machine supports. TODO: As Eric suggested use enum for type instead of str. TODO: @hotplug-granularity probably isn't required. Signed-off-by: Bharata B Rao --- hw/core/mach

[Qemu-devel] [RFC PATCH v0 6/6] hmp: Implement 'info cpu-slots'

2016-02-25 Thread Bharata B Rao
Signed-off-by: Bharata B Rao --- hmp-commands-info.hx | 14 + hmp.c| 56 hmp.h| 1 + 3 files changed, 71 insertions(+) diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 9b71351

[Qemu-devel] [RFC PATCH v0 2/6] spapr: CPU core device

2016-02-25 Thread Bharata B Rao
Add sPAPR specific CPU core device that is based on generic CPU core device. Creating this core device will result in creation of all the CPU thread devices that are part of this core. Signed-off-by: Bharata B Rao --- hw/ppc/Makefile.objs| 1 + hw/ppc/spapr_cpu_core.c

Re: [Qemu-devel] [RFC PATCH v0 3/6] spapr: Represent boot CPUs as spapr-cpu-core devices

2016-02-25 Thread Bharata B Rao
On Fri, Feb 26, 2016 at 02:45:35PM +1100, David Gibson wrote: > On Thu, Feb 25, 2016 at 09:52:39PM +0530, Bharata B Rao wrote: > > Initialize boot CPUs as spapr-cpu-core devices and create links from > > machine object to these core devices. These links can be considered > >

Re: [Qemu-devel] [RFC PATCH v0 2/6] spapr: CPU core device

2016-02-25 Thread Bharata B Rao
On Fri, Feb 26, 2016 at 01:57:44PM +1100, David Gibson wrote: > On Thu, Feb 25, 2016 at 09:52:38PM +0530, Bharata B Rao wrote: > > Add sPAPR specific CPU core device that is based on generic CPU core device. > > Creating this core device will result in creation of all the CPU thr

Re: [Qemu-devel] [RFC PATCH v0 5/6] qmp, spapr: Show hot-plugged/pluggable CPU slots in the Machine

2016-02-26 Thread Bharata B Rao
David, I am responding to just one comment here and will respond to others in detail later. On Fri, Feb 26, 2016 at 03:03:17PM +1100, David Gibson wrote: > > > +if (!strstart(prop->name, SPAPR_MACHINE_CPU_CORE_PROP, NULL)) { > > +continue; > > +} > > + > > +ele

Re: [Qemu-devel] [RFC PATCH v0 4/6] spapr: CPU hotplug support

2016-02-26 Thread Bharata B Rao
On Fri, Feb 26, 2016 at 02:03:57PM +0100, Thomas Huth wrote: > On 25.02.2016 17:22, Bharata B Rao wrote: > > Set up device tree entries for the hotplugged CPU core and use the > > exising EPOW event infrastructure to send CPU hotplug notification to > > the guest. > > &

Re: [Qemu-devel] [RFC PATCH v0 4/6] spapr: CPU hotplug support

2016-02-28 Thread Bharata B Rao
On Fri, Feb 26, 2016 at 02:51:41PM +1100, David Gibson wrote: > On Thu, Feb 25, 2016 at 09:52:40PM +0530, Bharata B Rao wrote: > > Set up device tree entries for the hotplugged CPU core and use the > > exising EPOW event infrastructure to send CPU hotplug notification t

Re: [Qemu-devel] [RFC PATCH v0 3/6] spapr: Represent boot CPUs as spapr-cpu-core devices

2016-02-28 Thread Bharata B Rao
On Fri, Feb 26, 2016 at 04:18:57PM +0100, Igor Mammedov wrote: > On Thu, 25 Feb 2016 21:52:39 +0530 > Bharata B Rao wrote: > > > Initialize boot CPUs as spapr-cpu-core devices and create links from > > machine object to these core devices. These links can be considered >

Re: [Qemu-devel] [RFC PATCH v0 2/6] spapr: CPU core device

2016-02-28 Thread Bharata B Rao
On Fri, Feb 26, 2016 at 11:46:19AM +0100, Thomas Huth wrote: > On 25.02.2016 17:22, Bharata B Rao wrote: > > Add sPAPR specific CPU core device that is based on generic CPU core device. > > Creating this core device will result in creation of all the CPU thread > > devices

Re: [Qemu-devel] [RFC PATCH v0 5/6] qmp, spapr: Show hot-plugged/pluggable CPU slots in the Machine

2016-02-28 Thread Bharata B Rao
On Fri, Feb 26, 2016 at 08:58:05AM -0700, Eric Blake wrote: > On 02/25/2016 09:22 AM, Bharata B Rao wrote: > > Implement query cpu-slots that provides information about hot-plugged > > as well as hot-pluggable CPU slots that the machine supports. > > > > TODO: As Eric

Re: [Qemu-devel] [RFC PATCH v0 2/6] spapr: CPU core device

2016-02-28 Thread Bharata B Rao
On Fri, Feb 26, 2016 at 12:13:39PM -0600, Michael Roth wrote: > Quoting Bharata B Rao (2016-02-25 10:22:38) > > Add sPAPR specific CPU core device that is based on generic CPU core device. > > Creating this core device will result in creation of all the CPU thread > > devices

Re: [Qemu-devel] [RFC PATCH v0 2/6] spapr: CPU core device

2016-02-29 Thread Bharata B Rao
On Mon, Feb 29, 2016 at 11:03:16AM +0100, Igor Mammedov wrote: > On Mon, 29 Feb 2016 11:20:19 +0530 > Bharata B Rao wrote: > > > On Fri, Feb 26, 2016 at 12:13:39PM -0600, Michael Roth wrote: > > > Quoting Bharata B Rao (2016-02-25 10:22:38) > > > > Add sP

Re: [Qemu-devel] [RFC PATCH v0 4/6] spapr: CPU hotplug support

2016-03-01 Thread Bharata B Rao
On Mon, Feb 29, 2016 at 10:12:10AM +0530, Bharata B Rao wrote: > > > diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c > > > index b7c5ebd..cc0369e 100644 > > > --- a/hw/ppc/spapr_rtas.c > > > +++ b/hw/ppc/spapr_rtas.c > > > @@ -34,6 +34

Re: [Qemu-devel] [RFC PATCH v0 2/6] spapr: CPU core device

2016-03-01 Thread Bharata B Rao
On Mon, Feb 29, 2016 at 04:15:25PM +0100, Igor Mammedov wrote: > On Mon, 29 Feb 2016 18:25:25 +0530 > Bharata B Rao wrote: > > > On Mon, Feb 29, 2016 at 11:03:16AM +0100, Igor Mammedov wrote: > > > On Mon, 29 Feb 2016 11:20:19 +0530 > > > Bharata B Rao wrote

Re: [Qemu-devel] [RFC PATCH v0 5/6] qmp, spapr: Show hot-plugged/pluggable CPU slots in the Machine

2016-03-01 Thread Bharata B Rao
On Mon, Feb 29, 2016 at 11:46:42AM +0100, Igor Mammedov wrote: > On Thu, 25 Feb 2016 21:52:41 +0530 > Bharata B Rao wrote: > > > Implement query cpu-slots that provides information about hot-plugged > > as well as hot-pluggable CPU slots that the machine supports. &

Re: [Qemu-devel] [RFC PATCH v0 2/6] spapr: CPU core device

2016-03-01 Thread Bharata B Rao
On Tue, Mar 01, 2016 at 10:16:18AM +0100, Igor Mammedov wrote: > On Tue, 1 Mar 2016 13:47:27 +0530 > Bharata B Rao wrote: > > > On Mon, Feb 29, 2016 at 04:15:25PM +0100, Igor Mammedov wrote: > > > On Mon, 29 Feb 2016 18:25:25 +0530 > > > Bharata B Rao wrote

Re: [Qemu-devel] [RFC PATCH v0 0/6] Core based CPU hotplug for PowerPC sPAPR

2016-03-01 Thread Bharata B Rao
On Thu, Feb 25, 2016 at 09:52:36PM +0530, Bharata B Rao wrote: > Hi, > > This is an attempt to implement CPU hotplug for PowerPC sPAPR based on > the approach suggested by Andreas. While I say that, I should also explicitly > add that I have tried to follow Andreas' suggestio

Re: [Qemu-devel] [PATCH v2 1/4] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine

2015-06-24 Thread Bharata B Rao
On Fri, Jun 19, 2015 at 10:40:21AM +0530, Bharata B Rao wrote: > pc_dimm_plug() has code that will be needed for memory plug handlers > in other archs too. Extract code from pc_dimm_plug() into a generic > routine pc_dimm_memory_plug() that resides in pc-dimm.c. Also > correspondingly

[Qemu-devel] [PATCH v5 0/6] Memory hotplug for PowerPC sPAPR guests

2015-06-24 Thread Bharata B Rao
red. (05/06) - Added a new patch to prevent memory hotplug to memory-less nodes (06/06) v4: https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg05242.html v3: https://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02910.html *** BLURB HERE *** Bharata B Rao (6): spapr: Initialize ho

[Qemu-devel] [PATCH v5 1/6] spapr: Initialize hotplug memory address space

2015-06-24 Thread Bharata B Rao
Initialize a hotplug memory region under which all the hotplugged memory is accommodated. Also enable memory hotplug by setting CONFIG_MEM_HOTPLUG. Modelled on i386 memory hotplug. Signed-off-by: Bharata B Rao --- default-configs/ppc64-softmmu.mak | 1 + hw/ppc/spapr.c| 18

[Qemu-devel] [PATCH v5 5/6] spapr: Memory hotplug support

2015-06-24 Thread Bharata B Rao
Make use of pc-dimm infrastructure to support memory hotplug for PowerPC. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c| 129 ++ hw/ppc/spapr_events.c | 8 ++-- 2 files changed, 134 insertions(+), 3 deletions(-) diff --git a/hw/ppc

[Qemu-devel] [PATCH v5 3/6] spapr: Support ibm, dynamic-reconfiguration-memory

2015-06-24 Thread Bharata B Rao
a SLOF enhancement which is already part of SLOF binary in QEMU. Signed-off-by: Bharata B Rao --- docs/specs/ppc-spapr-hotplug.txt | 48 + hw/ppc/spapr.c | 210 +++ hw/ppc/spapr_hcall.c | 51 -- include/hw/ppc

[Qemu-devel] [RFC PATCH v5 6/6] spapr: Don't allow memory hotplug to memory less nodes

2015-06-24 Thread Bharata B Rao
emory-less nodes, just prevent such attempts upfront in QEMU. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index f4792b8..003ef14 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -2

[Qemu-devel] [PATCH v5 4/6] spapr: Make hash table size a factor of maxram_size

2015-06-24 Thread Bharata B Rao
The hash table size is dependent on ram_size, but since with hotplug the memory can grow till maxram_size. Hence make hash table size dependent on maxram_size. This allows to hotplug huge amounts of memory to the guest. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --- hw/ppc/spapr.c

Re: [Qemu-devel] [RFC PATCH v4 3/5] spapr: Support ibm, dynamic-reconfiguration-memory

2015-06-24 Thread Bharata B Rao
On Wed, Jun 24, 2015 at 03:55:08PM +1000, David Gibson wrote: > On Wed, Jun 24, 2015 at 07:55:44AM +0530, Bharata B Rao wrote: > > On Tue, Jun 23, 2015 at 11:54:29AM +1000, David Gibson wrote: > > > On Fri, Jun 19, 2015 at 03:47:55PM +0530, Bharata B Rao wrote: > > > &

[Qemu-devel] [PATCH v5 2/6] spapr: Add LMB DR connectors

2015-06-24 Thread Bharata B Rao
ed by the memory hotplug code. Signed-off-by: Bharata B Rao Signed-off-by: Michael Roth [spapr_drc_reset implementation] --- hw/ppc/spapr.c | 79 ++ include/hw/ppc/spapr.h | 1 + 2 files changed, 80 insertions(+) diff --git

[Qemu-devel] [PATCH v3 0/5] Refactoring pc_dimm_plug and NUMA node lookup API

2015-06-25 Thread Bharata B Rao
el/2015-06/msg05157.html v1: https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg03212.html v0: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01078.html Bharata B Rao (5): pc,pc-dimm: Extract hotplug related fields in PCMachineState to a structure pc,pc-dimm: Factor out reusabl

[Qemu-devel] [PATCH v3 1/5] pc, pc-dimm: Extract hotplug related fields in PCMachineState to a structure

2015-06-25 Thread Bharata B Rao
Move hotplug_memory_base and hotplug_memory fields of PCMachineState into a separate structure so that the same can be made use of from other architectures supporing memory hotplug. Signed-off-by: Bharata B Rao --- hw/i386/acpi-build.c | 2 +- hw/i386/pc.c | 26

[Qemu-devel] [PATCH v3 3/5] numa, pc-dimm: Store pc-dimm memory information in numa_info

2015-06-25 Thread Bharata B Rao
Start storing the (start_addr, size, nodeid) of the pc-dimm memory in numa_info so that this information can be used to lookup node by address. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --- hw/mem/pc-dimm.c | 4 include/sysemu/numa.h | 10 ++ numa.c

[Qemu-devel] [PATCH v3 4/5] numa: Store boot memory address range in node_info

2015-06-25 Thread Bharata B Rao
Store memory address range information of boot memory in address range list of numa_info. This helps to have a common NUMA node lookup by address function that works for both boot time memory and hotplugged memory. Signed-off-by: Bharata B Rao --- numa.c | 17 + 1 file changed

[Qemu-devel] [PATCH v3 2/5] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine

2015-06-25 Thread Bharata B Rao
: Bharata B Rao --- hw/i386/pc.c | 66 --- hw/mem/pc-dimm.c | 80 include/hw/mem/pc-dimm.h | 4 +++ 3 files changed, 90 insertions(+), 60 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index

[Qemu-devel] [PATCH v3 5/5] numa: API to lookup NUMA node by address

2015-06-25 Thread Bharata B Rao
node which is needed for memory hotplug. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --- include/sysemu/numa.h | 1 + numa.c| 34 ++ 2 files changed, 35 insertions(+) diff --git a/include/sysemu/numa.h b/include/sysemu/numa.h index

Re: [Qemu-devel] [PATCH v3 4/5] numa: Store boot memory address range in node_info

2015-06-25 Thread Bharata B Rao
On Fri, Jun 26, 2015 at 09:36:03AM +0530, Bharata B Rao wrote: > Store memory address range information of boot memory in address > range list of numa_info. > > This helps to have a common NUMA node lookup by address function that > works for both boot time memory and ho

Re: [Qemu-devel] [RFC PATCH v5 6/6] spapr: Don't allow memory hotplug to memory less nodes

2015-06-25 Thread Bharata B Rao
On Fri, Jun 26, 2015 at 03:33:29PM +1000, David Gibson wrote: > On Thu, Jun 25, 2015 at 11:44:15AM +0530, Bharata B Rao wrote: > > Currently PowerPC kernel doesn't allow hot-adding memory to memory-less > > node, but instead will silently add the memory to the first node that

Re: [Qemu-devel] [PATCH v5 2/6] spapr: Add LMB DR connectors

2015-06-25 Thread Bharata B Rao
achines that support LMB DR, it should be fine to just terminate instead of silently disabling memory hotplug. Here is the replacement patch which does this. If you prefer a complete re-spin due to this, I can do that as well. Regards, Bharata. -- spapr: Add LMB DR conne

Re: [Qemu-devel] [PATCH v3 2/5] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine

2015-06-26 Thread Bharata B Rao
On Fri, Jun 26, 2015 at 10:21:54AM +0200, Igor Mammedov wrote: > On Fri, 26 Jun 2015 09:36:01 +0530 > Bharata B Rao wrote: > > > pc_dimm_plug() has code that will be needed for memory plug handlers > > in other archs too. Extract code from pc_dimm_plug() into

[Qemu-devel] [PATCH v4 2/6] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine

2015-06-29 Thread Bharata B Rao
: Bharata B Rao --- hw/i386/pc.c | 66 ++- hw/mem/pc-dimm.c | 80 include/hw/mem/pc-dimm.h | 4 +++ 3 files changed, 87 insertions(+), 63 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index

[Qemu-devel] [PATCH v4 0/6] Refactoring pc_dimm_plug and NUMA node lookup API

2015-06-29 Thread Bharata B Rao
org/archive/html/qemu-devel/2015-06/msg03212.html v0: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01078.html Bharata B Rao (6): pc,pc-dimm: Extract hotplug related fields in PCMachineState to a structure pc,pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate r

[Qemu-devel] [PATCH v4 3/6] pc: Abort if HotplugHandlerClass::plug() fails

2015-06-29 Thread Bharata B Rao
HotplugHandlerClass::plug() shouldn't fail and hence use error_abort to abort if it fails. Signed-off-by: Bharata B Rao --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 8df1f3e..a66416d 100644 --- a/hw/i386/pc.c +++ b/hw

[Qemu-devel] [PATCH v4 4/6] numa, pc-dimm: Store pc-dimm memory information in numa_info

2015-06-29 Thread Bharata B Rao
Start storing the (start_addr, end_addr) of the pc-dimm memory in corresponding numa_info[node] so that this information can be used to lookup node by address. Signed-off-by: Bharata B Rao --- hw/mem/pc-dimm.c | 4 include/sysemu/numa.h | 10 ++ numa.c| 26

[Qemu-devel] [PATCH v4 1/6] pc, pc-dimm: Extract hotplug related fields in PCMachineState to a structure

2015-06-29 Thread Bharata B Rao
Move hotplug_memory_base and hotplug_memory fields of PCMachineState into a separate structure so that the same can be made use of from other architectures supporing memory hotplug. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --- hw/i386/acpi-build.c | 2 +- hw/i386/pc.c

[Qemu-devel] [PATCH v4 5/6] numa: Store boot memory address range in node_info

2015-06-29 Thread Bharata B Rao
Store memory address range information of boot memory in address range list of numa_info. This helps to have a common NUMA node lookup by address function that works for both boot-time memory and hotplugged memory. Signed-off-by: Bharata B Rao --- numa.c | 27 +++ 1

[Qemu-devel] [PATCH v4 6/6] numa: API to lookup NUMA node by address

2015-06-29 Thread Bharata B Rao
node which is needed for memory hotplug. Signed-off-by: Bharata B Rao --- include/sysemu/numa.h | 1 + numa.c| 41 + 2 files changed, 42 insertions(+) diff --git a/include/sysemu/numa.h b/include/sysemu/numa.h index 7176364..a6392bc 100644

[Qemu-devel] [PATCH v6 1/6] spapr: Initialize hotplug memory address space

2015-06-29 Thread Bharata B Rao
Initialize a hotplug memory region under which all the hotplugged memory is accommodated. Also enable memory hotplug by setting CONFIG_MEM_HOTPLUG. Modelled on i386 memory hotplug. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --- default-configs/ppc64-softmmu.mak | 1 + hw/ppc

[Qemu-devel] [PATCH v6 2/6] spapr: Add LMB DR connectors

2015-06-29 Thread Bharata B Rao
ed by the memory hotplug code. Signed-off-by: Bharata B Rao Signed-off-by: Michael Roth [spapr_drc_reset implementation] --- hw/ppc/spapr.c | 88 ++ include/hw/ppc/spapr.h | 1 + 2 files changed, 89 insertions(+) diff --git

[Qemu-devel] [PATCH v6 4/6] spapr: Make hash table size a factor of maxram_size

2015-06-29 Thread Bharata B Rao
The hash table size is dependent on ram_size, but since with hotplug the memory can grow till maxram_size. Hence make hash table size dependent on maxram_size. This allows to hotplug huge amounts of memory to the guest. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --- hw/ppc/spapr.c

[Qemu-devel] [PATCH v6 3/6] spapr: Support ibm, dynamic-reconfiguration-memory

2015-06-29 Thread Bharata B Rao
a SLOF enhancement which is already part of SLOF binary in QEMU. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --- docs/specs/ppc-spapr-hotplug.txt | 48 + hw/ppc/spapr.c | 210 +++ hw/ppc/spapr_hcall.c | 51

[Qemu-devel] [PATCH v6 5/6] spapr: Memory hotplug support

2015-06-29 Thread Bharata B Rao
Make use of pc-dimm infrastructure to support memory hotplug for PowerPC. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c| 118 ++ hw/ppc/spapr_events.c | 8 ++-- 2 files changed, 123 insertions(+), 3 deletions(-) diff --git a/hw/ppc

[Qemu-devel] [PATCH v6 0/6] Memory hotplug for PowerPC sPAPR guests

2015-06-29 Thread Bharata B Rao
ry recovery after we have done guest visible changes. (5/6) v5: http://lists.nongnu.org/archive/html/qemu-ppc/2015-06/msg00267.html v4: https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg05242.html v3: https://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02910.html Bharata B Rao (6):

[Qemu-devel] [PATCH v6 6/6] spapr: Don't allow memory hotplug to memory less nodes

2015-06-29 Thread Bharata B Rao
ug to memory-less nodes, just prevent such attempts upfront in QEMU. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --- hw/ppc/spapr.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 77c2060..4c3eeed 100644 --- a/hw/ppc/sp

Re: [Qemu-devel] [PATCH v4 4/6] numa, pc-dimm: Store pc-dimm memory information in numa_info

2015-06-29 Thread Bharata B Rao
On Mon, Jun 29, 2015 at 02:08:20PM +0200, Igor Mammedov wrote: > On Mon, 29 Jun 2015 13:50:25 +0530 > Bharata B Rao wrote: > > > Start storing the (start_addr, end_addr) of the pc-dimm memory > > in corresponding numa_info[node] so that this information can be used > >

Re: [Qemu-devel] [PATCH v4 0/6] Refactoring pc_dimm_plug and NUMA node lookup API

2015-06-29 Thread Bharata B Rao
On Mon, Jun 29, 2015 at 02:32:09PM +0200, Igor Mammedov wrote: > On Mon, 29 Jun 2015 13:50:21 +0530 > Bharata B Rao wrote: > > > Hi, > > > > Here is the v4 of the patchset that refactors pc_dimm_plug and adds > > an API to lookup NUMA node by address. > >

Re: [Qemu-devel] [PATCH v6 0/6] Memory hotplug for PowerPC sPAPR guests

2015-06-29 Thread Bharata B Rao
On Tue, Jun 30, 2015 at 01:26:39PM +1000, David Gibson wrote: > On Mon, Jun 29, 2015 at 02:14:26PM +0530, Bharata B Rao wrote: > > Hi, > > > > This is v5 of memory hotplug support patchset for PowerPC > > sPAPR guests. > > > > This patchset applies on s

Re: [Qemu-devel] [PATCH v4 4/6] numa, pc-dimm: Store pc-dimm memory information in numa_info

2015-07-01 Thread Bharata B Rao
On Mon, Jun 29, 2015 at 04:53:12PM +0200, Igor Mammedov wrote: > On Mon, 29 Jun 2015 19:11:30 +0530 > Bharata B Rao wrote: > > > On Mon, Jun 29, 2015 at 02:08:20PM +0200, Igor Mammedov wrote: > > > On Mon, 29 Jun 2015 13:50:25 +0530 > > > Bharata B Rao wrote:

Re: [Qemu-devel] [PATCH 4/4] spapr: SPLPAR Characteristics

2015-07-02 Thread Bharata B Rao
s: set to smp_cpus, the inital number of CPUs in the > system. > > These tokens and values are specified by PAPR. > > Signed-off-by: Sam Bobroff > --- > hw/ppc/spapr_rtas.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/h

[Qemu-devel] inet_parse possibly broken by 879e45c72da1 ?

2012-11-08 Thread Bharata B Rao
Hi, Looks like inet_parse() isn't working as it used to earlier. With the latest git, I see this error: # qemu-system-x86_64 --enable-kvm -m 2048 -drive file=/test/F17,if=virtio Failed to start VNC server on `localhost:0,to=99': error parsing to= argument Before the commit 879e45c72da1, it works

[Qemu-devel] [RFC PATCH v1 0/3] pkg-config and discard support for gluster driver

2013-07-11 Thread Bharata B Rao
Hi, This is a patchset that achieves the following: - Use pkg-config to configure GlusterFS driver in QEMU. - Enable discard support in GlusterFS driver. Regards, Bharata.

[Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to configure GlusterFS block driver

2013-07-11 Thread Bharata B Rao
gluster: Use pkg-config to configure GlusterFS block driver Use pkg-config to determine the version and library dependency for GlusterFS block driver. Signed-off-by: Bharata B Rao --- configure | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a

[Qemu-devel] [RFC PATCH v1 2/2] gluster: Add discard support for GlusterFS block driver

2013-07-11 Thread Bharata B Rao
gluster: Add discard support for GlusterFS block driver. Implement bdrv_aio_discard for gluster. Signed-off-by: Bharata B Rao --- block/gluster.c | 45 + configure |8 2 files changed, 53 insertions(+) diff --git a/block

Re: [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to configure GlusterFS block driver

2013-07-16 Thread Bharata B Rao
On Tue, Jul 16, 2013 at 10:25:29AM +0200, Kevin Wolf wrote: > > - glusterfs_libs="-lgfapi -lgfrpc -lgfxdr" > > - if compile_prog "" "$glusterfs_libs" ; then > > -glusterfs=yes > > -libs_tools="$glusterfs_libs $libs_tools" > > -libs_softmmu="$glusterfs_libs $libs_softmmu" > > + if $pk

[Qemu-devel] [PATCH v2 1/2] gluster: Use pkg-config to configure GlusterFS block driver

2013-07-16 Thread Bharata B Rao
Use pkg-config to determine the version and library dependency for GlusterFS block driver. Signed-off-by: Bharata B Rao --- configure | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/configure b/configure index cb0f870..33f943a 100755 --- a/configure +++ b

[Qemu-devel] [PATCH v2 2/2] gluster: Add discard support for GlusterFS block driver.

2013-07-16 Thread Bharata B Rao
Implement bdrv_aio_discard for gluster. Signed-off-by: Bharata B Rao Reviewed-by: Kevin Wolf --- block/gluster.c | 45 + configure | 8 2 files changed, 53 insertions(+) diff --git a/block/gluster.c b/block/gluster.c index 61424bc

[Qemu-devel] [PATCH v2 0/2] pkg-config and discard support for gluster driver

2013-07-16 Thread Bharata B Rao
Hi, This is the v2 of the patchset that changes gluster driver in QEMU to use pkg-config and adds discard support. Changes in v2 - - Ensure that gluster libraries don't get linked to linux-user targets. Bharata B Rao (2): gluster: Use pkg-config to configure GlusterFS block d

[Qemu-devel] [PATCH] gluster: Add image resize support

2013-07-19 Thread Bharata B Rao
From: Paolo Bonzini Implement .bdrv_truncate in GlusterFS block driver so that GlusterFS backend can support image resizing. Signed-off-by: Paolo Bonzini Signed-off-by: Bharata B Rao Tested-by: Bharata B Rao --- block/gluster.c | 17 + 1 file changed, 17 insertions(+) diff

Re: [Qemu-devel] block: Review of .has_zero_init use

2013-06-25 Thread Bharata B Rao
On Tue, Jun 25, 2013 at 01:39:11PM +0200, Kevin Wolf wrote: > > Can you please review for the gluster, rbd, sheepdog and ssh driver > whether it's safe to assume that the image reads back as zeros after > bdrv_create? Gluster supports both file and block backends. While the above is true for file

Re: [Qemu-devel] block: Review of .has_zero_init use

2013-06-25 Thread Bharata B Rao
On Wed, Jun 26, 2013 at 07:59:27AM +0200, Peter Lieven wrote: > > Am 26.06.2013 um 05:14 schrieb Bharata B Rao : > > > On Tue, Jun 25, 2013 at 01:39:11PM +0200, Kevin Wolf wrote: > >> > >> Can you please review for the gluster, rbd, sheepdog and ssh driver >

[Qemu-devel] [PATCH] qemu-iotests: Cleanup test image in test number 007

2013-09-12 Thread Bharata B Rao
qemu-iotests number 007 doesn't do test image cleanup. This will affect those protocols that expect a clean state before every test. Hence ensure that test image is cleaned up in this test. Signed-off-by: Bharata B Rao --- tests/qemu-iotests/007 | 2 +- 1 file changed, 1 insertion(

[Qemu-devel] [Bug 891525] [NEW] Guest kernel crashes when booting a NUMA guest without explicitly specifying cpus= in -numa option

2011-11-17 Thread Bharata B Rao
Public bug reported: Target: x86_64-softmmu Qemu Command line: [root@hs22 qemu-1.0-rc2]# ./x86_64-softmmu/qemu- system-x86_64 -smp sockets=2,cores=4,threads=2 -numa node,nodeid=0,mem=4g -numa node,nodeid=1,mem=1g -cpu core2duo -m 5g /home/bharata/f15-lvm -nographic --enable-kvm -net nic,macaddr=5

Re: [Qemu-devel] [Bug 891525] [NEW] Guest kernel crashes when booting a NUMA guest without explicitly specifying cpus= in -numa option

2011-11-17 Thread Bharata B Rao
robin assignment nor do I understand the full implications of changing it, but here is a potential patch that fixes the problem for me. --- Fix VCPU enumeration between nodes From: Bharata B Rao Currently VCPUs are assigned to nodes in round robin manner. This is seen to break guest kernel for

Re: [Qemu-devel] [RFC PATCH] Exporting Guest RAM information for NUMA binding

2011-11-21 Thread Bharata B Rao
On Tue, Nov 08, 2011 at 09:33:04AM -0800, Chris Wright wrote: > * Alexander Graf (ag...@suse.de) wrote: > > On 29.10.2011, at 20:45, Bharata B Rao wrote: > > > As guests become NUMA aware, it becomes important for the guests to > > > have correct NUMA policies when t

Re: [Qemu-devel] [RFC PATCH] Exporting Guest RAM information for NUMA binding

2011-11-21 Thread Bharata B Rao
On Mon, Nov 21, 2011 at 04:25:26PM +0100, Peter Zijlstra wrote: > On Mon, 2011-11-21 at 20:48 +0530, Bharata B Rao wrote: > > > I looked at Peter's recent work in this area. > > (https://lkml.org/lkml/2011/11/17/204) > > > > It introduces two interfaces: >

[Qemu-devel] [PATCH] Guest stop notification

2011-11-29 Thread Eric B Munson
-off-by: Eric B Munson Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: a...@redhat.com Cc: k...@vger.kernel.org Cc: linux-ker...@vger.kernel.org --- target-i386/kvm.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/target-i386/kvm.c b

Re: [Qemu-devel] [PATCH] Guest stop notification

2011-12-01 Thread Eric B Munson
On Thu, 01 Dec 2011, Jan Kiszka wrote: > On 2011-11-29 22:36, Eric B Munson wrote: > > Often when a guest is stopped from the qemu console, it will report spurious > > soft lockup warnings on resume. There are kernel patches being discussed > > that > > will give t

Re: [Qemu-devel] [PATCH] Guest stop notification

2011-12-01 Thread Eric B Munson
On Thu, 01 Dec 2011, Jan Kiszka wrote: > On 2011-11-29 22:36, Eric B Munson wrote: > > Often when a guest is stopped from the qemu console, it will report spurious > > soft lockup warnings on resume. There are kernel patches being discussed > > that > > will give t

[Qemu-devel] [PATCH V2] Guest stop notification

2011-12-01 Thread Eric B Munson
patch uses the qemu Notifier system to tell the guest it is about to be stopped. Signed-off-by: Eric B Munson Cc: Avi Kivity Cc: Marcelo Tosatti Cc: Jan Kiszka Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: linux-ker...@vger.kernel.org Cc: k...@vger.kernel.org --- target-i386/kvm.c

Re: [Qemu-devel] [PATCH] Guest stop notification

2011-12-01 Thread Eric B Munson
On Thu, 01 Dec 2011, Marcelo Tosatti wrote: > On Thu, Dec 01, 2011 at 06:36:17PM +0100, Jan Kiszka wrote: > > On 2011-12-01 18:22, Eric B Munson wrote: > > > On Thu, 01 Dec 2011, Jan Kiszka wrote: > > > > > >> On 2011-11-29 22:36, Eric B Munson wrote: >

[Qemu-devel] [PATCH V3] Guest stop notification

2011-12-02 Thread Eric B Munson
-off-by: Eric B Munson Cc: Avi Kivity Cc: Marcelo Tosatti Cc: Jan Kiszka Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: k...@vger.kernel.org --- Changes from V2: Move ioctl into hw/kvmclock.c so as other arches can use it as it is implemented Changes from V1: Remove unnecessary

Re: [Qemu-devel] [PATCH V3] Guest stop notification

2011-12-02 Thread Eric B Munson
On Fri, 02 Dec 2011, Jan Kiszka wrote: > On 2011-12-02 20:19, Eric B Munson wrote: > > Often when a guest is stopped from the qemu console, it will report spurious > > soft lockup warnings on resume. There are kernel patches being discussed > > that > > will give t

Re: [Qemu-devel] [PATCH V3] Guest stop notification

2011-12-05 Thread Eric B Munson
On Sat, 03 Dec 2011, Jan Kiszka wrote: > On 2011-12-02 22:27, Eric B Munson wrote: > > On Fri, 02 Dec 2011, Jan Kiszka wrote: > > > >> On 2011-12-02 20:19, Eric B Munson wrote: > >>> Often when a guest is stopped from the qemu console, it will report > >

[Qemu-devel] [PATCH V4] Guest stop notification

2011-12-05 Thread Eric B Munson
patch uses the qemu Notifier system to tell the guest it is about to be stopped. Signed-off-by: Eric B Munson Cc: Avi Kivity Cc: Marcelo Tosatti Cc: Jan Kiszka Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: k...@vger.kernel.org --- Changes from V3: Collapse new state change notification

Re: [Qemu-devel] [PATCH v4 17/33] dimm: abstract dimm device from pc-dimm

2015-10-23 Thread Bharata B Rao
em/pc-dimm.h | 7 ++ > 7 files changed, 61 insertions(+), 12 deletions(-) > create mode 100644 hw/mem/pc-dimm.c > create mode 100644 include/hw/mem/pc-dimm.h > > diff --git a/default-configs/i386-softmmu.mak > b/default-configs/i386-softmmu.mak > index 43c9

[Qemu-devel] [PATCH v2 1/2] spapr: Accommadate alignment gaps in hotplug memory region

2015-10-26 Thread Bharata B Rao
objects spanning the entire alignment-adjusted hotplug memory region instead of just the acutal hotpluggable size (machine->maxram_size - machine->ram_size). In addition, pass 256M alignment to pc_dimm_memory_plug() so that the DIMM address gets aligned to 256M. Signed-off-by: Bharata B Rao Re

[Qemu-devel] [PATCH v2 0/2] Enforce gaps between DIMMs

2015-10-26 Thread Bharata B Rao
e mem sizes. This applies on David's spapr-next branch. Changes in v2 - - Minor rewording of patch description and code comment in 1/2. v1: http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg02414.html v0: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg00749.html

[Qemu-devel] [PATCH v2 2/2] spapr: Force gaps between DIMM's GPA

2015-10-26 Thread Bharata B Rao
ael S. Tsirkin Signed-off-by: Bharata B Rao Reviewed-by: Igor Mammedov --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index f29bb10..1a8df95 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -2170,7 +2170,7 @@ static

[Qemu-devel] [RFC PATCH v1] spapr: Memory hot-unplug support

2015-10-26 Thread Bharata B Rao
this situation, drmgr could be enhanced to support a command line option that results in removal of all the LMBs or none. Signed-off-by: Bharata B Rao --- Changes in v1: - Got rid of the patch that introduced a field in PCDIMMDevice to track DIMM marked for removal since we can track that using

Re: [Qemu-devel] [RFC PATCH v0] spapr: Abort when hash table size requirement isn't met

2015-07-27 Thread Bharata B Rao
Any views on this ? On Thu, Jul 16, 2015 at 12:25:01PM +0530, Bharata B Rao wrote: > On Wed, Jul 15, 2015 at 03:27:13PM +0530, Bharata B Rao wrote: > > [This patch addresses an issue which is not prominently seen in mainline, > > but seen frequently only in David's spapr-next

[Qemu-devel] [RFC PATCH] spapr: Provide an error message when migration fails due to htab_shift mismatch

2015-07-30 Thread Bharata B Rao
'spapr/htab' After this patch, the failure message will look like this: qemu-system-ppc64: htab_shift mismatch: source 29 target 24 qemu-system-ppc64: error while loading state for instance 0x0 of device 'spapr/htab' Signed-off-by: Bharata B Rao --- Applies against spapr-

Re: [Qemu-devel] [FIX PATCH] pc-dimm: Fail pc-dimm realization for invalid nodes in non-NUMA configuration

2015-08-02 Thread Bharata B Rao
On Mon, Jul 20, 2015 at 09:15:28AM +0200, Igor Mammedov wrote: > On Fri, 17 Jul 2015 18:19:40 +0530 > Bharata B Rao wrote: > > > pc_dimm_realize() validates the NUMA node to which memory hotplug is > > being performed only in case of NUMA configuration. Include a check >

[Qemu-devel] [RFC PATCH v0 1/5] spapr: Provide better error message when slots exceed max allowed

2015-08-02 Thread Bharata B Rao
supported 32 Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 6e24bf9..6d9cbd9 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1777,8 +1777,8 @@ static void ppc_spapr_init(MachineState

[Qemu-devel] [RFC PATCH v0 3/5] spapr: Revert to memory@XXXX representation for non-hotplugged memory

2015-08-02 Thread Bharata B Rao
-pluggable memory under ibm,dynamic-reconfiguration-memory. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 47 +-- 1 file changed, 9 insertions(+), 38 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 7f94f97..669dc43 100644 --- a/hw/ppc/spa

[Qemu-devel] [RFC PATCH v0 0/5] spapr-next: Memory hotplug updates

2015-08-02 Thread Bharata B Rao
mes, ibm,drc-indexes and ibm,dynamic-memory-reconfiguration nodes thus having only truly DR capable memory in these DT nodes/properties. Bharata B Rao (5): spapr: Provide better error message when slots exceed max allowed spapr: Populate ibm,associativity-lookup-arrays correctly for non-NUMA

[Qemu-devel] [RFC PATCH v0 2/5] spapr: Populate ibm, associativity-lookup-arrays correctly for non-NUMA

2015-08-02 Thread Bharata B Rao
at is hotplugged. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 6d9cbd9..7f94f97 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -728,6 +728,7 @@ static int spapr_populate_drconf_m

<    1   2   3   4   5   6   7   8   9   10   >