The original commit (3830c7a460b8252dc975f8115fdaed8c562d2d75)
stated "Datasheet states that default dummy cycles is 8 so fix it."
But since dummy cycles are handled in bytes it must be 1, not 8.
Signed-off-by: Aleksey Kuleshov
---
hw/block/m25p80.c | 2 +-
1 file changed, 1 inser
The original commit (3830c7a460b8252dc975f8115fdaed8c562d2d75)
stated "Datasheet states that default dummy cycles is 8 so fix it."
But since dummy cycles are handled in bytes it must be 1, not 8.
Signed-off-by: Aleksey Kuleshov
---
hw/block/m25p80.c | 2 +-
1 file changed, 1 inser
memset is not checked, so it's possible to go beyond the storage.
Add checks and truncate requested length.
Signed-off-by: Aleksey Kuleshov
---
hw/block/m25p80.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index ea142160b3..18ec5
Hello!
I hit unexpected disconnections because of this patch:
commit 9894dc0cdcc397ee5b26370bc53da6d360a363c2
Author: Daniel P. Berrange
Date: Tue Jan 19 11:14:29 2016 +
char: convert from GIOChannel to QIOChannel
In preparation for introducing TLS support to the TCP chardev
I'm using 2.11.0.
22.02.2018, 14:45, "Daniel P. Berrangé" :
> On Thu, Feb 22, 2018 at 02:38:04PM +0300, Aleksey Kuleshov wrote:
>> Hello!
>>
>> I hit unexpected disconnections because of this patch:
>>
>> commit 9894dc0cdcc397ee5b26370bc53da6d36
uthor: Marc-André Lureau
> Date: Fri Mar 11 18:55:24 2016 +0100
>
> char: translate from QIOChannel error to errno
>
> The tcp_chr_recv() function was changed back to return -1, with errno
> set to EAGAIN, without also re-addding support for this to tcp_chr_read()
Hello!
Explanation of what I saw is follows.
In hw/pci/pci_bridge.c function pci_bridge_update_mappings does follows:
```
void pci_bridge_update_mappings(PCIBridge *br)
{
PCIBridgeWindows *w = br->windows;
/* Make updates atomic to: handle the case of one VCPU updating the bridge
*