Re: [Qemu-devel] [PATCH] qemu-img: return allocated size for block device with qcow2 format

2018-05-03 Thread
Thanks for your review, Eric. Yes, the wr_highest_offset can tell the end offset at runtime, and write_threshold similar to it. But in my situation, I need to know the allocated end without a vm running. Eric Blake 于2018年5月2日周三 下午10:02写道: > On 05/02/2018 08:34 AM, Ivan Ren wrote: > > qemu-img in

Re: [Qemu-devel] [PATCH] qemu-img: return allocated size for block device with qcow2 format

2018-05-03 Thread
> The whole implementation reminds me a lot of qcow2's check function, > which basically just recalculates the refcounts. So I'm wondering > whether you could just count how many clusters with non-0 refcount there > are and thus simplify the implementation dramatically. Thanks for your review, Ma