Re: [PATCH] qapi: Add more cross-references

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 01:57:51PM +0200, Markus Armbruster wrote: > We recently (merge commit 504632dcc631) enclosed command and type > names in `backquotes`, so they become links in generated HTML. Take > care of a few we missed. > > Signed-off-by: Markus Armbruster > --- > qapi/dump.json

Re: [PATCH] target/i386: tdx: fix locking for interrupt injection

2025-07-17 Thread Xiaoyao Li
On 7/17/2025 6:39 PM, Paolo Bonzini wrote: Take tdx_guest->lock when injecting the event notification interrupt into the guest. Fixes CID 1612364. Reported-by: Peter Maydell Cc: Xiaoyao Li Signed-off-by: Paolo Bonzini Reviewed-by: Xiaoyao Li --- target/i386/kvm/tdx.c | 10 +++---

qemu-devel@nongnu.org

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 06:37:07PM +0800, Xiaoyao Li wrote: > Commit 40da501d8989 ("i386/tdx: handle TDG.VP.VMCALL") added > redundant qemu_mutex_init(&tdx->lock) in tdx_guest_init by mistake. > > Fix it by removing the redundant one. > > Fixes: 40da501d8989 ("i386/tdx: handle TDG.VP.VMCALL") > R

Re: [PATCH] docs/devel: fix over-quoting of QEMU_TEST_KEEP_SCRATCH

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 11:41:05AM +0100, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > docs/devel/testing/functional.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.f

Re: [PULL 14/17] esp.c: only call dma_memory_read function if transfer length is non-zero

2025-07-17 Thread Philippe Mathieu-Daudé
Hi Mark, On 15/7/25 08:19, Philippe Mathieu-Daudé wrote: From: Mark Cave-Ayland In the cases where mixed DMA/non-DMA transfers are used or no data is available, it is possible for the calculated transfer length to be zero. Only call the dma_memory_read function where the transfer length is non

[Stable-7.2.19 26/26] ui/vnc: Do not copy z_stream

2025-07-17 Thread Michael Tokarev
From: Akihiko Odaki vnc_worker_thread_loop() copies z_stream stored in its local VncState to the persistent VncState, and the copied one is freed with deflateEnd() later. However, deflateEnd() refuses to operate with a copied z_stream and returns Z_STREAM_ERROR, leaking the allocated memory. Avo

Re: [PULL V2 12/16] net: Add passt network backend

2025-07-17 Thread Laurent Vivier
On 17/07/2025 11:28, Peter Maydell wrote: On Tue, 15 Jul 2025 at 05:42, Jason Wang wrote: From: Laurent Vivier This commit introduces support for passt as a new network backend. passt is an unprivileged, user-mode networking solution that provides connectivity for virtual machines by launchi

[Stable-7.2.19 24/26] amd_iommu: Remove duplicated definitions

2025-07-17 Thread Michael Tokarev
From: Alejandro Jimenez No functional change. Signed-off-by: Alejandro Jimenez Reviewed-by: Vasant Hegde Message-Id: <20250617150427.20585-8-alejandro.j.jime...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry picked from commit 5959b641c98b5ae9677e2c1d89

[Stable-7.2.19 22/26] amd_iommu: Fix mask to retrieve Interrupt Table Root Pointer from DTE

2025-07-17 Thread Michael Tokarev
From: Alejandro Jimenez Fix an off-by-one error in the definition of AMDVI_IR_PHYS_ADDR_MASK. The current definition masks off the most significant bit of the Interrupt Table Root ptr i.e. it only generates a mask with bits [50:6] set. See the AMD I/O Virtualization Technology (IOMMU) Specificati

[PATCH v2 0/4] qga: Doc fixes and improvements

2025-07-17 Thread Markus Armbruster
This series touches only doc comments. I'd like to get it into 10.1. v2: * PATCH 4: More cross-references [Daniel] Markus Armbruster (4): qga: Fix guest-network-get-route return value documentation qga: Remove trivial "Returns:" sections qga: Rephrase return docs to avoid type name qga:

[PATCH v2 3/4] qga: Rephrase return docs to avoid type name

2025-07-17 Thread Markus Armbruster
"Returns: " is rendered like Return: – Mentioning the type in the description again is commonly redundant. There is just one such description. Rephrase it not to mention the type. We did this for qapi/ in commit f7296f8de5c (qapi: rephrase return docs to avoid type name). Signed-off-by:

Re: [PATCH v2 4/4] qga: Add cross-references

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 01:52:46PM +0200, Markus Armbruster wrote: > Enclose command and type names in `backquotes`, so they become links > in generated HTML. > > We did this for qapi/ in merge commit 504632dcc631. > > Signed-off-by: Markus Armbruster > --- > qga/qapi-schema.json | 80 +

Re: [PATCH-for-10.1 3/3] hw/arm/virt: Warn when HVF doesn't report IPA bit length

2025-07-17 Thread Mads Ynddal
> This happens with nested macOS guest. I took another look at the stack trace in the issue. Everything should be fine then. > Maybe we are missing an earlier check whether HVF is usable or not, but > we shouldn't brutally abort(). I agree. I think with this patchset you're doing it practicall

Re: [RFC PATCH 0/4] rust: use attrs crate to parse #[property]

2025-07-17 Thread Paolo Bonzini
Il gio 17 lug 2025, 11:18 Manos Pitsidianakis < manos.pitsidiana...@linaro.org> ha scritto: > Looks OK to me but are we sure it's necessary? This dependency is just > a syn::parse wrapper under the hood. Even serde's derive macros use > syn directly: > https://github.com/serde-rs/serde/blob/babafa

Re: [PATCH-for-10.1 1/3] accel/hvf: Display executable bit as 'X'

2025-07-17 Thread Xiaoyao Li
On 7/17/2025 1:28 AM, Philippe Mathieu-Daudé wrote: Developers are custom to read RWX, not RWE. Replace E -> X. Reported-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Xiaoyao Li --- accel/hvf/hvf-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [PATCH 0/7] hw/i386/amd_iommu: Cleanups and fixes

2025-07-17 Thread Alejandro Jimenez
On 7/17/25 2:07 AM, Michael S. Tsirkin wrote: On Thu, Jul 17, 2025 at 11:17:05AM +0530, Sairaj Kodilkar wrote: On 7/16/2025 6:59 PM, Michael S. Tsirkin wrote: On Wed, Jul 16, 2025 at 06:26:37PM +0530, Sairaj Kodilkar wrote: On 7/16/2025 6:07 PM, Philippe Mathieu-Daudé wrote: On 16/7/25

Re: [RFC PATCH 0/6] Fix building of sparc/sparc32plus test cases

2025-07-17 Thread Alex Bennée
Mark Cave-Ayland writes: > On 16/07/2025 11:54, Alex Bennée wrote: > >> We didn't have any reliable way to build sparc test cases. I have >> found someone who ships a compiler but the binaries still don't run >> due to the need for CASA. >> I'm posting mainly for those who actually care who might

Re: [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init()

2025-07-17 Thread Paolo Bonzini
Queued, thanks. Paolo

[PATCH] docs/devel/submitting-a-patch.rst: add b4 section

2025-07-17 Thread Manos Pitsidianakis
9bc20982b8fd86ef change-id: 20250717-docs_add_b4_section-fc37e538b20b -- γαῖα πυρί μιχθήτω

qemu-devel@nongnu.org

2025-07-17 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH v11 2/3] vfio: Move the TYPE_* to hw/vfio/types.h

2025-07-17 Thread Zhao Liu
On Thu, Jul 17, 2025 at 06:09:40AM -0400, Shaoqin Huang wrote: > Date: Thu, 17 Jul 2025 06:09:40 -0400 > From: Shaoqin Huang > Subject: [PATCH v11 2/3] vfio: Move the TYPE_* to hw/vfio/types.h > > Move the TYPE_* to a new file hw/vfio/types.h because the > TYPE_VFIO_PCI will be used in later patc

Re: [PATCH v4 00/23] migration: propagate vTPM errors using Error objects

2025-07-17 Thread Fabiano Rosas
Arun Menon writes: > Hi Fabiano, > > Thanks for the quick review and for catching the make check failure. > My apologies for that oversight, it's definitely an embarrassing miss on my > part. That's ok, you don't do this every day. =) > I see what happened there. I ran make check without sud

Re: [RFC PATCH 0/6] Fix building of sparc/sparc32plus test cases

2025-07-17 Thread Mark Cave-Ayland
On 16/07/2025 11:54, Alex Bennée wrote: We didn't have any reliable way to build sparc test cases. I have found someone who ships a compiler but the binaries still don't run due to the need for CASA. I'm posting mainly for those who actually care who might want to fix up the remaining cases. A

Re: [PATCH 1/2] migration: Fix postcopy latency distribution formatting computation

2025-07-17 Thread Fabiano Rosas
Prasad Pandit writes: > On Wed, 16 Jul 2025 at 19:06, Fabiano Rosas wrote: >> The condition should be >=. > > * I'm thinking of doing away with the loop and the string array. The > array has 3 values of which only one gets used due to conversion to > seconds. The point is not to convert to seco

[Stable-7.2.19 v2 00/26] Patch Round-up for stable 7.2.19, freeze on 2025-07-21

2025-07-17 Thread Michael Tokarev
The following patches are queued for QEMU stable v7.2.19: https://gitlab.com/qemu-project/qemu/-/commits/staging-7.2 Patch freeze is 2025-07-21, and the release is planned for 2025-07-23: https://wiki.qemu.org/Planning/7.2 Please respond here or CC qemu-sta...@nongnu.org on any additional p

[Stable-7.2.19 21/26] amd_iommu: Fix masks for various IOMMU MMIO Registers

2025-07-17 Thread Michael Tokarev
From: Alejandro Jimenez Address various issues with definitions of the MMIO registers e.g. for the Device Table Address Register, the size mask currently encompasses reserved bits [11:9], so change it to only extract the bits [8:0] encoding size. Convert masks to use GENMASK64 for consistency, a

[Stable-7.2.19 20/26] amd_iommu: Update bitmasks representing DTE reserved fields

2025-07-17 Thread Michael Tokarev
From: Alejandro Jimenez The DTE validation method verifies that all bits in reserved DTE fields are unset. Update them according to the latest definition available in AMD I/O Virtualization Technology (IOMMU) Specification - Section 2.2.2.1 Device Table Entry Format. Remove the magic numbers and

[Stable-7.2.19 17/26] migration: Don't sync volatile memory after migration completes

2025-07-17 Thread Michael Tokarev
From: "Chaney, Ben" Syncing volatile memory provides no benefit, instead it can cause performance issues in some cases. Only sync memory that is marked as non-volatile after migration completes on destination. Signed-off-by: Ben Chaney Fixes: bd108a44bc29 (migration: ram: Switch to ram block w

Re: [PATCH-for-10.1 3/3] hw/arm/virt: Warn when HVF doesn't report IPA bit length

2025-07-17 Thread Philippe Mathieu-Daudé
On 17/7/25 12:06, Mads Ynddal wrote: On 16 Jul 2025, at 19.28, Philippe Mathieu-Daudé wrote: Emit a warning when HVF doesn't return the IPA bit length and return -1 as "this accelerator is not usable", allowing QEMU to try with the next one (when using '-accel hvf:tcg'). Reported-by: Ivan Kr

[PATCH v2 4/4] qga: Add cross-references

2025-07-17 Thread Markus Armbruster
Enclose command and type names in `backquotes`, so they become links in generated HTML. We did this for qapi/ in merge commit 504632dcc631. Signed-off-by: Markus Armbruster --- qga/qapi-schema.json | 80 ++-- 1 file changed, 40 insertions(+), 40 deletions

[PATCH v2 1/4] qga: Fix guest-network-get-route return value documentation

2025-07-17 Thread Markus Armbruster
Tagged sections are only recognized at the beginning of a paragraph. guest-network-get-route's Returns: isn't, and therefore gets rendered as ordinary text within its paragraph: Retrieve information about route of network. Returns: List of route info of guest. Since there is no (recognize

[PATCH] qapi: Add more cross-references

2025-07-17 Thread Markus Armbruster
We recently (merge commit 504632dcc631) enclosed command and type names in `backquotes`, so they become links in generated HTML. Take care of a few we missed. Signed-off-by: Markus Armbruster --- qapi/dump.json | 2 +- qapi/machine.json | 2 +- qapi/migration.json | 4 ++-- qapi/misc-i38

Re: [PULL 14/17] esp.c: only call dma_memory_read function if transfer length is non-zero

2025-07-17 Thread Peter Maydell
On Thu, 17 Jul 2025 at 12:51, Philippe Mathieu-Daudé wrote: > > Hi Mark, > > On 15/7/25 08:19, Philippe Mathieu-Daudé wrote: > > From: Mark Cave-Ayland > > > > In the cases where mixed DMA/non-DMA transfers are used or no data is > > available, it is possible for the calculated transfer length to

Re: [PATCH] target/i386: do not expose ARCH_CAPABILITIES on AMD CPU

2025-07-17 Thread Xiaoyao Li
On 7/17/2025 6:34 PM, Paolo Bonzini wrote: KVM emulates the ARCH_CAPABILITIES on x86 for both Intel and AMD cpus, although the IA32_ARCH_CAPABILITIES MSR is an Intel-specific MSR and it makes no sense to emulate it on AMD. As a consequence, VMs created on AMD with qemu -cpu host and using KVM wi

Re: [PATCH v3 0/7] esp.c: only allow ESP commands permitted in the current mode

2025-07-17 Thread Mark Cave-Ayland
On 16/07/2025 16:13, Michael Tokarev wrote: On 11.07.2025 23:46, Mark Cave-Ayland wrote: This series contains a few minor tidy-ups along with an implementation of the logic to only allow ESP commands permitted in the current mode. The motivation is to fix GitLab issue #2464 which causes Windows

[Stable-7.2.19 16/26] linux-user: Hold the fd-trans lock across fork

2025-07-17 Thread Michael Tokarev
From: Geoffrey Thomas If another thread is holding target_fd_trans_lock during a fork, then the lock becomes permanently locked in the child and the emulator deadlocks at the next interaction with the fd-trans table. As with other locks, acquire the lock in fork_start() and release it in fork_end

Re: [PATCH] docs/devel: fix over-quoting of QEMU_TEST_KEEP_SCRATCH

2025-07-17 Thread Philippe Mathieu-Daudé
On 17/7/25 12:41, Alex Bennée wrote: Signed-off-by: Alex Bennée --- docs/devel/testing/functional.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

[Stable-7.2.19 25/26] amd_iommu: Fix truncation of oldval in amdvi_writeq

2025-07-17 Thread Michael Tokarev
From: Ethan Milon The variable `oldval` was incorrectly declared as a 32-bit `uint32_t`. This could lead to truncation and incorrect behavior where the upper read-only 32 bits are significant. Fix the type of `oldval` to match the return type of `ldq_le_p()`. Cc: qemu-sta...@nongnu.org Fixes: d

[Stable-7.2.19 19/26] amd_iommu: Fix Device ID decoding for INVALIDATE_IOTLB_PAGES command

2025-07-17 Thread Michael Tokarev
From: Alejandro Jimenez The DeviceID bits are extracted using an incorrect offset in the call to amdvi_iotlb_remove_page(). This field is read (correctly) earlier, so use the value already retrieved for devid. Cc: qemu-sta...@nongnu.org Fixes: d29a09ca6842 ("hw/i386: Introduce AMD IOMMU") Signed

[Stable-7.2.19 18/26] amd_iommu: Fix Miscellaneous Information Register 0 encoding

2025-07-17 Thread Michael Tokarev
From: Alejandro Jimenez The definitions encoding the maximum Virtual, Physical, and Guest Virtual Address sizes supported by the IOMMU are using incorrect offsets i.e. the VASize and GVASize offsets are switched. The value in the GVAsize field is also modified, since it was incorrectly encoded.

[Stable-7.2.19 23/26] amd_iommu: Fix the calculation for Device Table size

2025-07-17 Thread Michael Tokarev
From: Alejandro Jimenez Correctly calculate the Device Table size using the format encoded in the Device Table Base Address Register (MMIO Offset h). Cc: qemu-sta...@nongnu.org Fixes: d29a09ca6842 ("hw/i386: Introduce AMD IOMMU") Signed-off-by: Alejandro Jimenez Reviewed-by: Vasant Hegde M

Re: [PULL 17/77] meson: Add optional dependency on IGVM library

2025-07-17 Thread Stefano Garzarella
On Wed, 16 Jul 2025 at 13:31, Daniel P. Berrangé wrote: > > On Mon, Jul 14, 2025 at 01:03:06PM +0200, Paolo Bonzini wrote: > > From: Roy Hopkins > > > > The IGVM library allows Independent Guest Virtual Machine files to be > > parsed and processed. IGVM files are used to configure guest memory >

Re: [PATCH 1/2] migration: Fix postcopy latency distribution formatting computation

2025-07-17 Thread Daniel P . Berrangé
On Tue, Jul 15, 2025 at 09:45:51AM -0300, Fabiano Rosas wrote: > Coverity has caught a bug in the formatting of time intervals for > postcopy latency distribution display in 'info migrate'. > > While bounds checking the labels array, sizeof is incorrectly being > used. ARRAY_SIZE is the correct fo

Re: [PULL 17/77] meson: Add optional dependency on IGVM library

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 03:30:06PM +0200, Stefano Garzarella wrote: > On Wed, 16 Jul 2025 at 13:31, Daniel P. Berrangé wrote: > > > > On Mon, Jul 14, 2025 at 01:03:06PM +0200, Paolo Bonzini wrote: > > > From: Roy Hopkins > > > > > > The IGVM library allows Independent Guest Virtual Machine files

Re: [PULL 14/17] esp.c: only call dma_memory_read function if transfer length is non-zero

2025-07-17 Thread Mark Cave-Ayland
On 17/07/2025 12:58, Peter Maydell wrote: On Thu, 17 Jul 2025 at 12:51, Philippe Mathieu-Daudé wrote: Hi Mark, On 15/7/25 08:19, Philippe Mathieu-Daudé wrote: From: Mark Cave-Ayland In the cases where mixed DMA/non-DMA transfers are used or no data is available, it is possible for the cal

[PATCH v2 2/4] qga: Remove trivial "Returns:" sections

2025-07-17 Thread Markus Armbruster
The QAPI doc generator recently started to auto-generate return documentation when there is no "Returns:" section (commit 636c96cd77d "qapi: Fix undocumented return values by generating something"). Remove "Returns:" sections where the auto-generated text is obviously no worse. For instance, guest

Re: [PATCH] tests/functional: add --debug CLI arg

2025-07-17 Thread Alex Bennée
Thomas Huth writes: > On 17/07/2025 10.42, Alex Bennée wrote: >> Manos Pitsidianakis writes: >> >>> Add argument parsing to functional tests to improve developer experience >>> when running individual tests. All logs are printed to stdout >>> interspersed with TAP output. >>> >>>./pyvenv/bi

[PATCH] target/i386: tdx: fix locking for interrupt injection

2025-07-17 Thread Paolo Bonzini
Take tdx_guest->lock when injecting the event notification interrupt into the guest. Fixes CID 1612364. Reported-by: Peter Maydell Cc: Xiaoyao Li Signed-off-by: Paolo Bonzini --- target/i386/kvm/tdx.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target/i386/k

qemu-devel@nongnu.org

2025-07-17 Thread Xiaoyao Li
Commit 40da501d8989 ("i386/tdx: handle TDG.VP.VMCALL") added redundant qemu_mutex_init(&tdx->lock) in tdx_guest_init by mistake. Fix it by removing the redundant one. Fixes: 40da501d8989 ("i386/tdx: handle TDG.VP.VMCALL") Reported-by: Peter Maydell Signed-off-by: Xiaoyao Li --- target/i386/kvm

[PATCH] docs/devel: fix over-quoting of QEMU_TEST_KEEP_SCRATCH

2025-07-17 Thread Alex Bennée
Signed-off-by: Alex Bennée --- docs/devel/testing/functional.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/testing/functional.rst b/docs/devel/testing/functional.rst index 9d08abe284..2725633e09 100644 --- a/docs/devel/testing/functional.rst +++ b/docs/devel/

[PATCH] meson: re-generate scripts/meson-buildoptions.sh to fix IGVM entry

2025-07-17 Thread Stefano Garzarella
From: Stefano Garzarella Commit 84fe49d94a ("meson: Add optional dependency on IGVM library") was inconsistent with the contents of meson_options.txt and the one generated in scripts/meson-buildoptions.sh Let's regenerate the file in this way to keep them consistent and prevent future changes fr

Re: [PATCH v2 2/3] migration: HMP: Fix postcopy latency distribution label

2025-07-17 Thread Philippe Mathieu-Daudé
On 16/7/25 20:26, Fabiano Rosas wrote: Fix the loop condition to avoid having a label with "1000 us" instead of "1 ms". Reported-by: Prasad Pandit Signed-off-by: Fabiano Rosas --- migration/migration-hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Good catch. Reviewed-by

Re: [PATCH v5 08/11] hw/misc: Add RISC-V CMGCR and CPC device implementations

2025-07-17 Thread Djordje Todorovic
On 15. 7. 25. 12:04, Philippe Mathieu-Daudé wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you recognize the sender > and know the content is safe. > > > Hi, Hi Philippe, Thanks for the comments! > > On 3/7/25 12:49,

Re: [PATCH] tests/functional: add --debug CLI arg

2025-07-17 Thread Alex Bennée
Manos Pitsidianakis writes: > Add argument parsing to functional tests to improve developer experience > when running individual tests. All logs are printed to stdout > interspersed with TAP output. > > ./pyvenv/bin/python3 ../tests/functional/test_aarch64_virt.py --help > usage: test_aarch64

Re: [PATCH v5 09/11] hw/riscv: Add support for MIPS Boston-aia board model

2025-07-17 Thread Djordje Todorovic
Hi Philippe, Yes, I will do that. Thanks, Djordje On 15. 7. 25. 12:07, Philippe Mathieu-Daudé wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you recognize the sender > and know the content is safe. > > > On 3/7/25 12:4

Re: [PATCH v5 28/69] qapi: Move definitions related to accelerators in their own file

2025-07-17 Thread Philippe Mathieu-Daudé
On 16/7/25 11:24, Daniel P. Berrangé wrote: On Wed, Jul 16, 2025 at 10:23:26AM +0200, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Hi Markus, I missed this one, sorry! On 3/7/25 12:54, Philippe Mathieu-Daudé wrote: Extract TCG and KVM definitions from machine.json to accelerat

Re: [PATCH] tests/functional: add --debug CLI arg

2025-07-17 Thread Thomas Huth
On 17/07/2025 10.42, Alex Bennée wrote: Manos Pitsidianakis writes: Add argument parsing to functional tests to improve developer experience when running individual tests. All logs are printed to stdout interspersed with TAP output. ./pyvenv/bin/python3 ../tests/functional/test_aarch64_vir

Re: [PATCH] tests/functional: add --debug CLI arg

2025-07-17 Thread Manos Pitsidianakis
On Thu, Jul 17, 2025 at 11:42 AM Alex Bennée wrote: > > Manos Pitsidianakis writes: > > > Add argument parsing to functional tests to improve developer experience > > when running individual tests. All logs are printed to stdout > > interspersed with TAP output. > > > > ./pyvenv/bin/python3 ../

Re: [PATCH] target/riscv/kvm: Introduce simple handler for VS-file allocation failure

2025-07-17 Thread Bill Xiang
Hi drew,Thanks for your reply. I agree this patch remains insufficient. Regardless, Guest Interrupt Files represent a new and critical resource type that upper layers currently lack awareness of, and significant work is still needed to fully integrate them. > From: "Andrew Jones" > Date:  Thu, Ju

Re: [PATCH v5 08/11] hw/loongarch: Implement avec set irq

2025-07-17 Thread gaosong
在 2025/7/14 下午5:29, Bibo Mao 写道: On 2025/7/11 下午4:59, Song Gao wrote: Implement avec set irq and update CSR_MSIS. Signed-off-by: Song Gao ---   hw/intc/loongarch_avec.c | 34 --   1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/hw/intc/loongarch_

Re: [PATCH 3/4] qga: Rephrase return docs to avoid type name

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 10:21:16AM +0200, Markus Armbruster wrote: > "Returns: " is rendered like > > Return: – > > Mentioning the type in the description again is commonly redundant. > There is just one such description. Rephrase it not to mention the > type. > > We did this for qapi/ in

Re: [PATCH 2/4] qga: Remove trivial "Returns:" sections

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 10:21:15AM +0200, Markus Armbruster wrote: > The QAPI doc generator recently started to auto-generate return > documentation when there is no "Returns:" section (commit 636c96cd77d > "qapi: Fix undocumented return values by generating something"). > Remove "Returns:" section

Re: [PATCH 1/4] qga: Fix guest-network-get-route return value documentation

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 10:21:14AM +0200, Markus Armbruster wrote: > Tagged sections are only recognized at the beginning of a paragraph. > guest-network-get-route's Returns: isn't, and therefore gets rendered > as ordinary text within its paragraph: > > Retrieve information about route of net

Re: [PATCH 4/4] qga: Add cross-references

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 10:21:17AM +0200, Markus Armbruster wrote: > Enclose command and type names in `backquotes`, so they become links > in generated HTML. > > We did this for qapi/ in merge commit 504632dcc631. > > Signed-off-by: Markus Armbruster > --- > qga/qapi-schema.json | 50 +

Re: Add the stm32f407 SoC

2025-07-17 Thread 范艺豪
Thank you for your review. I will take your suggestions into account — I’ll send a proper patch series including the board model using this SoC, and switch to plain text email using git send-email. 范艺豪 fanyi...@rt-thread.org Original: From:Peter Maydell Date:2025-07-14 18:15:17

RE: [PATCH v3 07/20] intel_iommu: Check for compatibility with IOMMUFD backed device when x-flts=on

2025-07-17 Thread Duan, Zhenzhong
Hi Eric, >-Original Message- >From: Eric Auger >Subject: Re: [PATCH v3 07/20] intel_iommu: Check for compatibility with >IOMMUFD backed device when x-flts=on > >Hi Zhenzhong, > >On 7/17/25 5:47 AM, Duan, Zhenzhong wrote: >> Hi Eric, >> >>> -Original Message- >>> From: Eric Auger

RE: [PATCH v3 10/20] intel_iommu: Handle PASID entry removing and updating

2025-07-17 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Subject: Re: [PATCH v3 10/20] intel_iommu: Handle PASID entry removing and >updating ... >> +static bool vtd_pasid_entry_compare(VTDPASIDEntry *p1, VTDPASIDEntry >*p2) >> +{ >> +return !memcmp(p1, p2, sizeof(*p1)); >> +} >> + >> +/* >> + * This

RE: [PATCH v3 11/20] intel_iommu: Handle PASID entry adding

2025-07-17 Thread Duan, Zhenzhong
Hi Eric, >-Original Message- >From: Eric Auger >Subject: Re: [PATCH v3 11/20] intel_iommu: Handle PASID entry adding > >Hi Zhenzhong, > >On 7/8/25 1:05 PM, Zhenzhong Duan wrote: >> When guest modifies a PASID entry, QEMU will capture the guest pasid >selective >> pasid cache invalidation,

Re: [PATCH] target/riscv/kvm: Introduce simple handler for VS-file allocation failure

2025-07-17 Thread Andrew Jones
On Wed, Jul 16, 2025 at 03:47:37PM +0800, BillXiang wrote: > Consider a system with 8 harts, where each hart supports 5 > Guest Interrupt Files (GIFs), yielding 40 total GIFs. > If we launch a QEMU guest with over 5 vCPUs using > "-M virt,aia='aplic-imsic' -accel kvm,riscv-aia=hwaccel" – which > re

Re: [PATCH v5 09/23] migration: push Error **errp into ram_postcopy_incoming_init()

2025-07-17 Thread Arun Menon
Hi Akihiko, Thanks for the review. On Thu, Jul 17, 2025 at 12:34:21PM +0900, Akihiko Odaki wrote: > On 2025/07/17 9:37, Arun Menon wrote: > > This is an incremental step in converting vmstate loading > > code to report error via Error objects instead of directly > > printing it to console/monitor

Re: [PATCH v5 16/23] migration: push Error **errp into loadvm_process_enable_colo()

2025-07-17 Thread Arun Menon
On Thu, Jul 17, 2025 at 12:26:16PM +0900, Akihiko Odaki wrote: > On 2025/07/17 9:37, Arun Menon wrote: > > This is an incremental step in converting vmstate loading > > code to report error via Error objects instead of directly > > printing it to console/monitor. > > It is ensured that loadvm_proce

Re: [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init()

2025-07-17 Thread Zhao Liu
On Wed, Jul 16, 2025 at 02:31:16PM +0800, Xiaoyao Li wrote: > Date: Wed, 16 Jul 2025 14:31:16 +0800 > From: Xiaoyao Li > Subject: [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init() > X-Mailer: git-send-email 2.43.0 > > The implementation of host_cpu_max_instance_init() was merged into > host_

[PATCH 2/4] qga: Remove trivial "Returns:" sections

2025-07-17 Thread Markus Armbruster
The QAPI doc generator recently started to auto-generate return documentation when there is no "Returns:" section (commit 636c96cd77d "qapi: Fix undocumented return values by generating something"). Remove "Returns:" sections where the auto-generated text is obviously no worse. For instance, guest

[PATCH 4/4] qga: Add cross-references

2025-07-17 Thread Markus Armbruster
Enclose command and type names in `backquotes`, so they become links in generated HTML. We did this for qapi/ in merge commit 504632dcc631. Signed-off-by: Markus Armbruster --- qga/qapi-schema.json | 50 ++-- 1 file changed, 25 insertions(+), 25 deletions

[PATCH 0/4] qga: Doc fixes and improvements

2025-07-17 Thread Markus Armbruster
This series touches only doc comments. I'd like to get it into 10.1. Markus Armbruster (4): qga: Fix guest-network-get-route return value documentation qga: Remove trivial "Returns:" sections qga: Rephrase return docs to avoid type name qga: Add cross-references qga/qapi-schema.json | 7

[PATCH 1/4] qga: Fix guest-network-get-route return value documentation

2025-07-17 Thread Markus Armbruster
Tagged sections are only recognized at the beginning of a paragraph. guest-network-get-route's Returns: isn't, and therefore gets rendered as ordinary text within its paragraph: Retrieve information about route of network. Returns: List of route info of guest. Since there is no (recognize

Re: [PATCH-for-10.1] system/runstate: Document qemu_add_vm_change_state_handler_prio* in hdr

2025-07-17 Thread Zhao Liu
On Tue, Jul 15, 2025 at 07:19:20PM +0200, Philippe Mathieu-Daudé wrote: > Date: Tue, 15 Jul 2025 19:19:20 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-10.1] system/runstate: Document > qemu_add_vm_change_state_handler_prio* in hdr > X-Mailer: git-send-email 2.49.0 > > Generally API

[PATCH 3/4] qga: Rephrase return docs to avoid type name

2025-07-17 Thread Markus Armbruster
"Returns: " is rendered like Return: – Mentioning the type in the description again is commonly redundant. There is just one such description. Rephrase it not to mention the type. We did this for qapi/ in commit f7296f8de5c (qapi: rephrase return docs to avoid type name). Signed-off-by:

Re: [PATCH v4 00/27] refresh qemu-img options handling

2025-07-17 Thread Michael Tokarev
On 15.07.2025 21:42, Kevin Wolf wrote: Am 31.05.2025 um 19:15 hat Michael Tokarev geschrieben: This is another iteration of this patch series, which tries to add missing command-line options, --help output, make it all more or less consistent, etc. I addressed (hopefully) all comments so far, m

[PATCH v6 09/14] hw/misc: Add RISC-V CPC device implementation

2025-07-17 Thread Djordje Todorovic
Add RISC-V implementation of the Cluster Power Controller (CPC) device. It is based on the existing MIPS CPC implementations but adapted for RISC-V systems. The CPC device manages power control for CPU clusters in RISC-V systems. This is needed for the MIPS BOSTON AIA board. Signed-off-by: Chao-

Re: [RFC PATCH 0/4] rust: use attrs crate to parse #[property]

2025-07-17 Thread Manos Pitsidianakis
On Thu, Jul 17, 2025 at 9:27 AM Paolo Bonzini wrote: > > This needs a bit of preparation, but it simplifies the handwritten parsing > code down to approximately 10 lines, and slightly improves the error > messages too. All the scaffolding will be shared by future uses of > procedural macros. > >

[Stable-10.0.3 65/65] i386/cpu: Honor maximum value for CPUID.8000001DH.EAX[25:14]

2025-07-17 Thread Michael Tokarev
From: Zhao Liu CPUID.801DH:EAX[25:14] is "NumSharingCache", and the number of logical processors sharing this cache is the value of this field incremented by 1. Because of its width limitation, the maximum value currently supported is 4095. Though at present Q35 supports up to 4096 CPUs, by

[PATCH v6 12/14] hw/pci: Allow explicit function numbers in pci

2025-07-17 Thread Djordje Todorovic
Since there is no pch_gbe emulation, we could be using func other than 0 when adding new devices to specific boards. Signed-off-by: Chao-ying Fu Signed-off-by: Djordje Todorovic --- hw/pci/pci.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/pci/pci.c b/h

Re: [PULL v2 09/13] ui/spice: Blit the scanout texture if its memory layout is not linear

2025-07-17 Thread Peter Maydell
On Tue, 15 Jul 2025 at 07:43, wrote: > > From: Vivek Kasireddy > > In cases where the scanout buffer is provided as a texture (e.g. Virgl) > we need to check to see if it has a linear memory layout or not. If > it doesn't have a linear layout, then blitting it onto the texture > associated with t

[Stable-10.0.3 46/65] migration: Don't sync volatile memory after migration completes

2025-07-17 Thread Michael Tokarev
From: "Chaney, Ben" Syncing volatile memory provides no benefit, instead it can cause performance issues in some cases. Only sync memory that is marked as non-volatile after migration completes on destination. Signed-off-by: Ben Chaney Fixes: bd108a44bc29 (migration: ram: Switch to ram block w

[Stable-10.0.3 44/65] linux-user: Check for EFAULT failure in nanosleep

2025-07-17 Thread Michael Tokarev
From: Peter Maydell target_to_host_timespec() returns an error if the memory the guest passed us isn't actually readable. We check for this everywhere except the callsite in the TARGET_NR_nanosleep case, so this mistake was caught by a Coverity heuristic. Add the missing error checks to the cal

Re: [PATCH] tests/functional: add --debug CLI arg

2025-07-17 Thread Daniel P . Berrangé
On Wed, Jul 16, 2025 at 09:08:00AM +0300, Manos Pitsidianakis wrote: > Add argument parsing to functional tests to improve developer experience > when running individual tests. All logs are printed to stdout > interspersed with TAP output. > > ./pyvenv/bin/python3 ../tests/functional/test_aarch6

[Stable-10.0.3 59/65] file-posix: Fix aio=threads performance regression after enablign FUA

2025-07-17 Thread Michael Tokarev
From: Kevin Wolf For aio=threads, we're currently not implementing REQ_FUA in any useful way, but just do a separate raw_co_flush_to_disk() call. This changes behaviour compared to the old state, which used bdrv_co_flush() with its optimisations. As a quick fix, call bdrv_co_flush() again like be

[Stable-10.0.3 55/65] amd_iommu: Fix mask to retrieve Interrupt Table Root Pointer from DTE

2025-07-17 Thread Michael Tokarev
From: Alejandro Jimenez Fix an off-by-one error in the definition of AMDVI_IR_PHYS_ADDR_MASK. The current definition masks off the most significant bit of the Interrupt Table Root ptr i.e. it only generates a mask with bits [50:6] set. See the AMD I/O Virtualization Technology (IOMMU) Specificati

[Stable-10.0.3 41/65] target/arm: Don't enforce NSE, NS check for EL3->EL3 returns

2025-07-17 Thread Michael Tokarev
From: Peter Maydell In the Arm ARM, rule R_TYTWB that defines illegal exception return cases includes the case: If FEAT_RME is implemented, then if SCR_EL3.{NSE, NS} is {1, 0}, an exception return from EL3 to a lower Exception level Our implementation of this check fails to check that the retu

[Stable-10.0.3 45/65] linux-user: Hold the fd-trans lock across fork

2025-07-17 Thread Michael Tokarev
From: Geoffrey Thomas If another thread is holding target_fd_trans_lock during a fork, then the lock becomes permanently locked in the child and the emulator deadlocks at the next interaction with the fd-trans table. As with other locks, acquire the lock in fork_start() and release it in fork_end

[Stable-10.0.3 40/65] target/i386: fix TB exit logic in gen_movl_seg() when writing to SS

2025-07-17 Thread Michael Tokarev
From: Mark Cave-Ayland Before commit e54ef98c8a ("target/i386: do not trigger IRQ shadow for LSS"), any write to SS in gen_movl_seg() would cause a TB exit. The changes introduced by this commit were intended to restrict the DISAS_EOB_INHIBIT_IRQ exit to the case where inhibit_irq is true, but mi

Re: [PULL V2 13/16] net/passt: Implement vhost-user backend support

2025-07-17 Thread Peter Maydell
On Tue, 15 Jul 2025 at 05:37, Jason Wang wrote: > > From: Laurent Vivier > > This commit adds support for the vhost-user interface to the passt > network backend, enabling high-performance, accelerated networking for > guests using passt. > > The passt backend can now operate in a vhost-user mode

[Stable-10.0.3 64/65] i386/cpu: Fix overflow of cache topology fields in CPUID.04H

2025-07-17 Thread Michael Tokarev
From: Qian Wen According to SDM, CPUID.0x4:EAX[31:26] indicates the Maximum number of addressable IDs for processor cores in the physical package. If we launch over 64 cores VM, the 6-bit field will overflow, and the wrong core_id number will be reported. Since the HW reports 0x3f when the intel

[PATCH v6 04/14] target/riscv: Add MIPS P8700 CSRs

2025-07-17 Thread Djordje Todorovic
Define MIPS CSRs used for P8700 CPU. Signed-off-by: Chao-ying Fu Signed-off-by: Djordje Todorovic --- target/riscv/cpu.c | 3 + target/riscv/cpu.h | 3 + target/riscv/meson.build | 1 + target/riscv/mips_csr.c | 228 +++ 4 files changed, 23

[Stable-10.0.3 61/65] vhost: Fix used memslot tracking when destroying a vhost device

2025-07-17 Thread Michael Tokarev
From: David Hildenbrand When we unplug a vhost device, we end up calling vhost_dev_cleanup() where we do a memory_listener_unregister(). This memory_listener_unregister() call will end up disconnecting the listener from the address space through listener_del_address_space(). In that process, we

[Stable-10.0.3 48/65] accel/kvm: Adjust the note about the minimum required kernel version

2025-07-17 Thread Michael Tokarev
From: Thomas Huth Since commit 126e7f78036 ("kvm: require KVM_CAP_IOEVENTFD and KVM_CAP_IOEVENTFD_ANY_LENGTH") we require at least kernel 4.5 to be able to use KVM. Adjust the upgrade_note accordingly. While we're at it, remove the text about kvm-kmod and the SourceForge URL since this is not act

[PATCH v6 13/14] riscv/boston-aia: Add an e1000e NIC in slot 0 func 1

2025-07-17 Thread Djordje Todorovic
The Boston AIA board needs a basic GbE NIC. There is no PCH GbE device emulation, so use an `e1000e` instead. We place it in **slot 0, function 1** in order not to conflict with the existing AHCI device in slot 0 func 0. Signed-off-by: Chao-ying Fu Signed-off-by: Djordje Todorovic --- hw/risc

[PATCH v6 02/14] target/riscv: Add cpu_set_exception_base

2025-07-17 Thread Djordje Todorovic
Add a new function, so we can change reset vector from platforms during runtime. Signed-off-by: Chao-ying Fu Signed-off-by: Djordje Todorovic --- target/riscv/cpu.c | 13 + target/riscv/cpu.h | 4 2 files changed, 17 insertions(+) diff --git a/target/riscv/cpu.c b/target/risc

[Stable-10.0.3 54/65] amd_iommu: Fix masks for various IOMMU MMIO Registers

2025-07-17 Thread Michael Tokarev
From: Alejandro Jimenez Address various issues with definitions of the MMIO registers e.g. for the Device Table Address Register, the size mask currently encompasses reserved bits [11:9], so change it to only extract the bits [8:0] encoding size. Convert masks to use GENMASK64 for consistency, a

  1   2   3   >