[PATCH] hw/nvme: fix attachment of private namespaces

2025-04-08 Thread Klaus Jensen
; ARRAY_SIZE(subsys->namespaces); nsid++) { -NvmeNamespace *ns = subsys->namespaces[nsid]; -if (ns && ns->params.shared && !ns->params.detached) { -nvme_attach_ns(n, ns); -} -} - return cntlid; } --- base-commit: dfaecc04c46d298e9ee81bd0ca96d8754f1c27ed change-id: 20250408-fix-private-ns-19b2bdf62696 Best regards, -- Klaus Jensen

Re: [PATCH] Fix data races in test-bdrv-drain test

2025-04-08 Thread Kevin Wolf
Am 02.04.2025 um 12:21 hat Vitalii Mordan geschrieben: > This patch addresses potential data races involving access to Job fields > in the test-bdrv-drain test. > > Fixes: 7253220de4 ("test-bdrv-drain: Test drain vs. block jobs") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2900 > Sig

Re: hw/nvme: Issue with multiple controllers behind a subsystem

2025-04-08 Thread Klaus Jensen
On Apr 4 10:52, alan.adam...@oracle.com wrote: > I'm running into a issue with the latest qemu-nvme with v10.0.0-rc2 with > regards to multiple controllers behind a subsystem.  When I setup a > subsystem with 2 controllers, each with a private/non-shared namespace, the > two private/non-shared nam

Re: [PATCH v2 2/2] qapi/block-core: derpecate some block-job- APIs

2025-04-08 Thread Markus Armbruster
Typo in subject, make it "deprecate". Vladimir Sementsov-Ogievskiy writes: > For change, pause, resume, complete, dismiss and finalize actions > corresponding job- and block-job commands are almost equal. The > difference is in find_block_job_locked() vs find_job_locked() > functions. What's dif

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-04-08 Thread Gerd Hoffman
Hi, > Which means we are back to the single firmware image. I think it makes > sense to continue supporting classic rom images (which can also be > loaded via -bios). Any use case which needs more fine-grained control > must use igvm. We can use format bits in both capabilities and control >

[PULL 09/11] qapi/qapi-schema: Address the introduction's bit rot

2025-04-08 Thread Markus Armbruster
Cut the crap that stopped making sense years ago. Adjust the remainder. Signed-off-by: Markus Armbruster Message-ID: <20250404121413.1743790-10-arm...@redhat.com> Reviewed-by: Eric Blake --- qapi/qapi-schema.json | 27 +++ 1 file changed, 7 insertions(+), 20 deletions(-

[PATCH v6 2/4] virtio_net: Add the check for vdpa's mac address

2025-04-08 Thread Cindy Lu
When using a VDPA device, it is important to ensure that the MAC address is correctly set. The MAC address in the hardware should match the MAC address from the QEMU command line. This is a recommended configuration and will allow the system to boot. Signed-off-by: Cindy Lu --- hw/net/virtio-net

Re: [PATCH 00/16] Add Multi-Core Debug (MCD) API support

2025-04-08 Thread Markus Armbruster
Mario Fleischmann writes: > Apologies for the line wrapping in yesterday's answer. Should be fixed now. > > On 08.04.2025 09:00, Markus Armbruster wrote: >> Mario Fleischmann writes: >> >>> Thanks a lot for the response, I really appreciate your time. >>> >>> On 07.04.2025 14:33, Markus Armbrus

Re: [PATCH v8 0/6] Specifying cache topology on ARM

2025-04-08 Thread Alireza Sanaee via
On Mon, 7 Apr 2025 19:24:16 +0200 Eric Auger wrote: > Hi Ali, > > On 3/10/25 5:23 PM, Alireza Sanaee via wrote: > > Specifying the cache layout in virtual machines is useful for > > applications and operating systems to fetch accurate information > > about the cache structure and make appropriat

Re: [PATCH v8 1/6] target/arm/tcg: increase cache level for cpu=max

2025-04-08 Thread Alireza Sanaee via
On Mon, 7 Apr 2025 19:07:29 +0200 Eric Auger wrote: Hi Eric, > Hi Ali, > > On 3/10/25 5:23 PM, Alireza Sanaee via wrote: > > This patch addresses cache description in the > > `aarch64_max_tcg_initfn` function for cpu=max. It introduces three > > layers of caches and modifies the cache descripti

[PATCH v6 0/4] virtio_net: Add the check for vdpa's mac address

2025-04-08 Thread Cindy Lu
When using a VDPA device, it is important to ensure that the MAC address is correctly set. In this patch series, we add a new parameter to enable this check. Only three MAC setup configurations are acceptable; any other will fail to boot. The usage is: -netdev type=vhost-vdpa,vhostdev=/dev/v

Re: [PATCH v8 5/6] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology

2025-04-08 Thread Alireza Sanaee via
On Mon, 7 Apr 2025 19:30:47 +0200 Eric Auger wrote: > Hi, > > On 3/10/25 5:23 PM, Alireza Sanaee via wrote: > > Test new PPTT topolopy with cache representation. > > > > Signed-off-by: Alireza Sanaee > > Reviewed-by: Jonathan Cameron > > --- > > tests/qtest/bios-tables-test.c | 4 > > 1

Re: [PATCH v2 00/13] Introduce AST27x0 multi-SoC machine

2025-04-08 Thread Cédric Le Goater
On 4/8/25 08:35, Steven Lee wrote: -Original Message- From: Cédric Le Goater Sent: Wednesday, March 26, 2025 1:34 AM To: Steven Lee ; Peter Maydell ; Troy Lee ; Jamin Lin ; Andrew Jeffery ; Joel Stanley ; open list:ASPEED BMCs ; open list:All patches CC here Cc: Troy Lee ; Yunlin Tang

[PATCH v6 3/4] virtio_net: Add second acceptable configuration for MAC setup

2025-04-08 Thread Cindy Lu
For VDPA devices, Allow configurations where the hardware MAC address is non-zero while the MAC address in the QEMU command line is zero. Signed-off-by: Cindy Lu --- hw/net/virtio-net.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c

Re: [PATCH v2 1/2] vfio/spapr: Enhance error handling in vfio_spapr_create_window()

2025-04-08 Thread Amit Machhiwal
Hi Cédric, Thanks for taking a look at this patch. Please find my responses below: On 2025/04/08 08:29 AM, Cédric Le Goater wrote: > Hello Amit, > > Please use --cover-letter for the next spin. Sure, will do. > > > On 4/7/25 16:31, Amit Machhiwal wrote: > > Introduce an Error ** parameter to

[PULL 07/11] docs/sphinx/qmp_lexer: Highlight elisions like comments, not prompts

2025-04-08 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-ID: <20250404121413.1743790-8-arm...@redhat.com> Reviewed-by: Eric Blake --- docs/sphinx/qmp_lexer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/qmp_lexer.py b/docs/sphinx/qmp_lexer.py index 1bd1b81b70..7b3b808d12 1006

[PULL 03/11] docs/interop: Delete "QEMU Guest Agent Protocol Reference" TOC

2025-04-08 Thread Markus Armbruster
The "QEMU Guest Agent Protocol Reference" starts with the following table of contents: Contents * QEMU Guest Agent Protocol Reference * QEMU guest agent protocol commands and structs This is useless. Delete the entire TOC. Signed-off-by: Markus Armbruster Message-ID: <202504041

Re: [PATCH v2 1/2] vfio/spapr: Enhance error handling in vfio_spapr_create_window()

2025-04-08 Thread Cédric Le Goater
On 4/8/25 11:14, Amit Machhiwal wrote: Hi Cédric, Thanks for taking a look at this patch. Please find my responses below: On 2025/04/08 08:29 AM, Cédric Le Goater wrote: Hello Amit, Please use --cover-letter for the next spin. Sure, will do. On 4/7/25 16:31, Amit Machhiwal wrote: Intro

Re: [PATCH 2/3] add vnc h264 encoder

2025-04-08 Thread Dietmar Maurer
> Please resend the series with a cover letter > (https://www.qemu.org/docs/master/devel/submitting-a-patch.html#use-git-format-patch) Ok, just resend this series with a cover letter and commit message. (patches unchanged) > > +#include > > + > > +static void libavcodec_destroy_encoder_context(V

[PULL 10/11] storage-daemon/qapi/qapi-schema: Add a proper introduction

2025-04-08 Thread Markus Armbruster
Contents adapted from qapi/qapi-schema.json. Signed-off-by: Markus Armbruster Message-ID: <20250404121413.1743790-11-arm...@redhat.com> Reviewed-by: Eric Blake --- storage-daemon/qapi/qapi-schema.json | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/st

[PULL 06/11] docs/sphinx/qmp_lexer: Generalize elision syntax

2025-04-08 Thread Markus Armbruster
Accept "... lorem ipsum ..." in addition to "...". Signed-off-by: Markus Armbruster Message-ID: <20250404121413.1743790-7-arm...@redhat.com> Reviewed-by: Eric Blake --- docs/devel/qapi-code-gen.rst| 6 -- docs/sphinx/qmp_lexer.py| 2 +- tests/qapi-schema/doc-good.json | 2 +- t

[PULL 11/11] qga/qapi-schema: Add a proper introduction

2025-04-08 Thread Markus Armbruster
Contents adapted from qapi/qapi-schema.json. Signed-off-by: Markus Armbruster Message-ID: <20250404121413.1743790-12-arm...@redhat.com> Reviewed-by: Eric Blake --- qga/qapi-schema.json | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/qga/qapi-schema.json

[PULL 01/11] docs/devel/qapi-code-gen: Tidy up whitespace

2025-04-08 Thread Markus Armbruster
Consistently use two spaces to separate sentences. Put "::" on a line of its own when it's preceded by whitespace. Signed-off-by: Markus Armbruster Message-ID: <20250404121413.1743790-2-arm...@redhat.com> Reviewed-by: Eric Blake --- docs/devel/qapi-code-gen.rst | 26 ++

[PULL 04/11] docs/interop: Sanitize QMP reference manuals TOC

2025-04-08 Thread Markus Armbruster
The "QEMU QMP Reference Manual" and the "QEMU Storage Daemon QMP Reference Manual" start with a table of contents that looks like this: Contents * Title of the manual * Title of first first-level section * Title of its first second-level section * Title of its second

[PULL 00/11] QAPI patches patches for 2025-04-08

2025-04-08 Thread Markus Armbruster
The following changes since commit dfaecc04c46d298e9ee81bd0ca96d8754f1c27ed: Merge tag 'pull-riscv-to-apply-20250407-1' of https://github.com/alistair23/qemu into staging (2025-04-07 09:18:33 -0400) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git tags/pull-qapi-20

[PULL 05/11] docs/devel/qapi-code-gen: Improve the part on qmp-example directive

2025-04-08 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-ID: <20250404121413.1743790-6-arm...@redhat.com> Reviewed-by: Eric Blake --- docs/devel/qapi-code-gen.rst | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.

[PULL 08/11] qapi/qapi-schema: Update introduction for example notation

2025-04-08 Thread Markus Armbruster
The introduction explains example notation. The series merged in merge commit e6485190f77e (in 9.1) improved how they look in generated docs, but neglected to update the introduction accordingly. Do that now. Signed-off-by: Markus Armbruster Message-ID: <20250404121413.1743790-9-arm...@redhat.c

[PATCH 2/3] add vnc h264 encoder

2025-04-08 Thread Dietmar Maurer
This patch implements H264 support for VNC. The RFB protocol extension is defined in: https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#open-h-264-encoding Currently the Gstreamer x264enc plugin (software encoder) is used to encode the video stream. The gstreamer pipe is: appsrc ->

Re: [PATCH v3 03/12] qcow2: put discard requests in the common queue when discard-no-unref enabled

2025-04-08 Thread Jean-Louis Dupond
Hi, I hope this patchset can get merged soon, as it contains some good improvements. Next to that, the change below only improves the performance on discards? It's not that something is broken/can cause issues in the current code? Otherwise it might be a good idea to have this one merged as

Re: [PULL 00/11] QAPI patches patches for 2025-04-08

2025-04-08 Thread Markus Armbruster
Here's my argument for taking this into 10.0. The changes can be divided into four parts: 1. Address deficiencies right at the beginning of the three QMP manuals: * "QEMU QMP Reference Manual" section "Introduction" suffers from bit rot: much of the contents is useless or misleading.

Re: [PATCH rfcv2 03/20] HostIOMMUDevice: Introduce realize_late callback

2025-04-08 Thread Cédric Le Goater
On 4/7/25 13:19, Cédric Le Goater wrote: On 2/19/25 09:22, Zhenzhong Duan wrote: Currently we have realize() callback which is called before attachment. But there are still some elements e.g., hwpt_id is not ready before attachment. So we need a realize_late() callback to further initialize them

Re: [PATCH 00/16] Add Multi-Core Debug (MCD) API support

2025-04-08 Thread Mario Fleischmann
Apologies for the line wrapping in yesterday's answer. Should be fixed now. On 08.04.2025 09:00, Markus Armbruster wrote: > Mario Fleischmann writes: > >> Thanks a lot for the response, I really appreciate your time. >> >> On 07.04.2025 14:33, Markus Armbruster wrote: >> >>> Mario Fleischmann w

[PATCH 1/3] new configure option to enable gstreamer

2025-04-08 Thread Dietmar Maurer
GStreamer is required to implement H264 encoding for VNC. Please note that QEMU already depends on this library when you enable Spice. Signed-off-by: Dietmar Maurer --- meson.build | 10 ++ meson_options.txt | 2 ++ scripts/meson-buildoptions.sh | 5 -

Re: [PATCH 1/2] accel/tcg: add get_virtual_clock for TCG

2025-04-08 Thread Mark Burton
In principle I like this, but 1/ throughout the API can we please make everything consistent sure that all registrations take a handle (void *) and all callbacks functions pass that handle (and the ID) - right now, some things do, some things dont, and this specific case seems to take a handle

[PATCH v2] hw/i2c/aspeed: Fix wrong I2CC_DMA_LEN when I2CM_DMA_TX/RX_ADDR set first

2025-04-08 Thread Jamin Lin via
In the previous design, the I2C model would update I2CC_DMA_LEN (0x54) based on the value of I2CM_DMA_LEN (0x1C) when the firmware set either I2CM_DMA_TX_ADDR (0x30) or I2CM_DMA_RX_ADDR (0x34). However, this only worked correctly if the firmware set I2CM_DMA_LEN before setting I2CM_DMA_TX_ADDR or I

[PULL 1/2] hw/loongarch/virt: Fix cpuslot::cpu set at last in virt_cpu_plug()

2025-04-08 Thread Song Gao
From: Bibo Mao In function virt_cpu_plug(), Object cpuslot::cpu is set at last only when there is no any error, otherwise it is problematic that cpuslot::cpu is set in advance however it returns because of error. Fixes: ab9935d2991e (hw/loongarch/virt: Implement cpu plug interface) Signed-off-by

Re: [PATCH 02/11] qapi/rocker: Tidy up query-rocker-of-dpa-flows example

2025-04-08 Thread Markus Armbruster
Eric Blake writes: > On Fri, Apr 04, 2025 at 02:14:04PM +0200, Markus Armbruster wrote: >> The command can return any number of RockerOfDpaFlow objects. The >> example shows it returning exactly two, with the second objecy's > > object's Fixing... thanks! >> members elided. Tweak it so it el

Re: [PATCH v7 0/2] hw/loongarch/virt: Replace destination error with error_abort

2025-04-08 Thread gaosong
hi, Markus,  I had pick up this series for my 'loongarch bug fix for 10.0. 'branch thanks. Song Gao 在 2025/3/24 上午11:01, Bibo Mao 写道: In function virt_cpu_plug() and virt_cpu_unplug(), the error is impossile. Destination error is not propagated and replaced with error_abort. With this, the logi

[PATCH 3/3] vnc: h264: send additional frames after the display is clean

2025-04-08 Thread Dietmar Maurer
The H264 implementation only sends frames when it detects changes in the server's framebuffer. This leads to artifacts when there are no further changes, as the internal H264 encoder may still contain data. This patch modifies the code to send a few additional frames in such situations to flush th

[RFC 1/3] cxl_type3: Preparing information sharing between VMs

2025-04-08 Thread nifan . cxl
From: Fan Ni Add two data structures for sharing information between multiple VMs. The global cci_map_buf is used to provide mappings between cci name and cci pointer. Each VM has its own cci_map_buf. However, since we expect the two VMs share the same configuration, the same CCI name should poin

[PATCH 0/3] Add VNC Open H.264 Encoding

2025-04-08 Thread Dietmar Maurer
As defined by: https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#open-h-264-encoding The noVNC HTML application recently added support for this encoding. There is also an open pull request to add audio support to noVNC: https://github.com/novnc/noVNC/pull/1952 With that in place, th

Re: [PATCH 2/3] add vnc h264 encoder

2025-04-08 Thread Marc-André Lureau
Hi On Tue, Apr 8, 2025 at 1:54 PM Dietmar Maurer wrote: > > > Please resend the series with a cover letter > > (https://www.qemu.org/docs/master/devel/submitting-a-patch.html#use-git-format-patch) > > Ok, just resend this series with a cover letter and commit message. > (patches unchanged) ok, t

[PATCH v3 09/10] target/riscv: rvv: Apply vext_check_input_eew to vector indexed load/store instructions

2025-04-08 Thread Max Chou
Handle the overlap of source registers with different EEWs. Co-authored-by: Anton Blanchard Reviewed-by: Daniel Henrique Barboza Signed-off-by: Max Chou --- target/riscv/insn_trans/trans_rvv.c.inc | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/riscv/insn_trans

[PATCH v3 03/10] target/riscv: rvv: Apply vext_check_input_eew to vrgather instructions to check mismatched input EEWs encoding constraint

2025-04-08 Thread Max Chou
According to the v spec, a vector register cannot be used to provide source operands with more than one EEW for a single instruction. The vs1 EEW of vrgatherei16.vv is 16. Co-authored-by: Anton Blanchard Reviewed-by: Daniel Henrique Barboza Signed-off-by: Max Chou --- target/riscv/insn_trans/t

[PATCH v3 08/10] target/riscv: rvv: Apply vext_check_input_eew to vector narrow/widen instructions

2025-04-08 Thread Max Chou
Handle the overlap of source registers with different EEWs. The vd of vector widening mul-add instructions is one of the input operands. Co-authored-by: Anton Blanchard Reviewed-by: Daniel Henrique Barboza Signed-off-by: Max Chou --- target/riscv/insn_trans/trans_rvbf16.c.inc | 9 ++- target/

[PATCH v3 07/10] target/riscv: rvv: Apply vext_check_input_eew to vector integer extension instructions(OPMVV)

2025-04-08 Thread Max Chou
Handle the overlap of source registers with different EEWs. Co-authored-by: Anton Blanchard Reviewed-by: Daniel Henrique Barboza Signed-off-by: Max Chou --- target/riscv/insn_trans/trans_rvv.c.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/riscv/insn_trans/tr

[PATCH v3 02/10] target/riscv: rvv: Add CHECK arg to GEN_OPFVF_WIDEN_TRANS

2025-04-08 Thread Max Chou
From: Anton Blanchard Signed-off-by: Anton Blanchard Reviewed-by: Daniel Henrique Barboza Reviewed-by: Max Chou Signed-off-by: Max Chou --- target/riscv/insn_trans/trans_rvv.c.inc | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/target/riscv/insn_trans/t

[PATCH v3 04/10] target/riscv: rvv: Apply vext_check_input_eew to OPIVI/OPIVX/OPFVF(vext_check_ss) instructions

2025-04-08 Thread Max Chou
Handle the overlap of source registers with different EEWs. Co-authored-by: Anton Blanchard Reviewed-by: Daniel Henrique Barboza Signed-off-by: Max Chou --- target/riscv/insn_trans/trans_rvv.c.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/riscv/insn_trans/tra

[PATCH v3 10/10] target/riscv: Fix the rvv reserved encoding of unmasked instructions

2025-04-08 Thread Max Chou
According to the v spec, the encodings of vcomoress.vm and vector mask-register logical instructions with vm=0 are reserved. Reviewed-by: Daniel Henrique Barboza Signed-off-by: Max Chou --- target/riscv/insn32.decode | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff

[PULL 2/2] hw/loongarch/virt: Replace destination error with error_abort

2025-04-08 Thread Song Gao
From: Bibo Mao In function virt_cpu_plug() and virt_cpu_unplug(), the error is impossile. Destination error is not propagated and replaced with error_abort. With this, the logic is simple. Signed-off-by: Bibo Mao Acked-by: Markus Armbruster Message-Id: <20250324030145.3037408-3-maob...@loongso

[PATCH v3 05/10] target/riscv: rvv: Apply vext_check_input_eew to OPIVV/OPFVV(vext_check_sss) instructions

2025-04-08 Thread Max Chou
Handle the overlap of source registers with different EEWs. Co-authored-by: Anton Blanchard Reviewed-by: Daniel Henrique Barboza Signed-off-by: Max Chou --- target/riscv/insn_trans/trans_rvv.c.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/ta

[PATCH v6 1/4] vhost_vdpa : Add a new parameter to enable check mac address

2025-04-08 Thread Cindy Lu
When using a VDPA device, it's important to ensure that the MAC address is correctly set. Add a new parameter in qemu cmdline to enable this check, default value is false The usage is: -netdev type=vhost-vdpa,vhostdev=/dev/vhost-vdpa-0,id=vhost-vdpa0,check-mac=true\ -device virtio-net-pci,ne

[PATCH v3 2/5] util/qemu-sockets: Refactor setting client sockopts into a separate function

2025-04-08 Thread Juraj Marcin
From: Juraj Marcin This is done in preparation for enabling the SO_KEEPALIVE support for server sockets and adding settings for more TCP keep-alive socket options. Signed-off-by: Juraj Marcin --- util/qemu-sockets.c | 29 +++-- 1 file changed, 19 insertions(+), 10 delet

Re: [PATCH 00/16] Add Multi-Core Debug (MCD) API support

2025-04-08 Thread Alex Bennée
Markus Armbruster writes: > Mario Fleischmann writes: > >> Apologies for the line wrapping in yesterday's answer. Should be fixed now. >> >> On 08.04.2025 09:00, Markus Armbruster wrote: >>> Mario Fleischmann writes: >>> Thanks a lot for the response, I really appreciate your time. >

[PULL 2/4] qcow2: Don't crash qemu-img info with missing crypto header

2025-04-08 Thread Kevin Wolf
qcow2_refresh_limits() assumes that s->crypto is non-NULL whenever bs->encrypted is true. This is actually not the case: qcow2_do_open() allows to open an image with a missing crypto header for BDRV_O_NO_IO, and then bs->encrypted is true, but s->crypto is still NULL. It doesn't make sense to open

Re: [PATCH] ui/curses: Fix infinite loop on windows

2025-04-08 Thread Stefan Hajnoczi
On Thu, Apr 03, 2025 at 01:07:56AM +, William Hu via wrote: > >From a42046272f0544dd18ed58661e53ea17d1584c2c Mon Sep 17 00:00:00 2001 > From: William Hu > Date: Wed, 2 Apr 2025 12:00:00 -0400 > Subject: [PATCH] ui/curses: Fix infinite loop on windows > > Replace -1 comparisons for wint_t with

Re: [PATCH] Revert "virtio-net: Copy received header to buffer"

2025-04-08 Thread Stefan Hajnoczi
On Fri, Apr 04, 2025 at 05:18:21PM +0200, Antoine Damhet wrote: > This reverts commit 7987d2be5a8bc3a502f89ba8cf3ac3e09f64d1ce. > > The goal was to remove the need to patch the (const) input buffer > with a recomputed UDP checksum by copying headers to a RW region and > inject the checksum there.

[PULL 0/2] loongarch bug fix for 10.0

2025-04-08 Thread Song Gao
tags/pull-loongarch-20250408 for you to fetch changes up to fa0dde12db045ddc84f69b1aa0a4c98d176c903d: hw/loongarch/virt: Replace destination error with error_abort (2025-04-08 14:44:53 +0800) loongarch bug fi

Re: [PATCH 00/16] Add Multi-Core Debug (MCD) API support

2025-04-08 Thread Alex Bennée
Markus Armbruster writes: > Alex Bennée writes: > >> Markus Armbruster writes: >> >>> Mario Fleischmann writes: >>> Apologies for the line wrapping in yesterday's answer. Should be fixed now. On 08.04.2025 09:00, Markus Armbruster wrote: > > [...] > > What about providing th

[PULL 02/11] qapi/rocker: Tidy up query-rocker-of-dpa-flows example

2025-04-08 Thread Markus Armbruster
The command can return any number of RockerOfDpaFlow objects. The example shows it returning exactly two, with the second object's members elided. Tweak it so it elides elements after the first instead. Signed-off-by: Markus Armbruster Message-ID: <20250404121413.1743790-3-arm...@redhat.com> Re

Re: [PATCH] hw/nvme: fix attachment of private namespaces

2025-04-08 Thread alan . adamson
On 4/8/25 3:20 AM, Klaus Jensen wrote: From: Klaus Jensen Fix regression when attaching private namespaces that gets attached to the wrong controller. Keep track of the original controller "owner" of private namespaces, and only attach if this matches on controller enablement. Tested-by: A

Re: [PATCH] scripts/checkpatch: Fix typo in SPDX-License-Identifier keyword

2025-04-08 Thread Alex Bennée
Zhao Liu writes: > Fix the typo in the error message to help `grep` the example: > > ERROR: New file '***' requires 'SPDX-License-Identifer' > > Fixes: fa4d79c64dae ("scripts: mandate that new files have > SPDX-License-Identifier") > Signed-off-by: Zhao Liu Reviewed-by: Alex Bennée -- Alex

[PATCH v3 06/10] target/riscv: rvv: Apply vext_check_input_eew to vector slide instructions(OPIVI/OPIVX)

2025-04-08 Thread Max Chou
Handle the overlap of source registers with different EEWs. Co-authored-by: Anton Blanchard Reviewed-by: Daniel Henrique Barboza Signed-off-by: Max Chou --- target/riscv/insn_trans/trans_rvv.c.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/riscv/insn_trans/tr

[PATCH v3 01/10] target/riscv: rvv: Source vector registers cannot overlap mask register

2025-04-08 Thread Max Chou
From: Anton Blanchard Add the relevant ISA paragraphs explaining why source (and destination) registers cannot overlap the mask register. Signed-off-by: Anton Blanchard Reviewed-by: Daniel Henrique Barboza Reviewed-by: Max Chou Signed-off-by: Max Chou --- target/riscv/insn_trans/trans_rvv.c

Re: [PATCH 2/3] add vnc h264 encoder

2025-04-08 Thread Dietmar Maurer
> > > > +#include > > > > + > > > > +static void libavcodec_destroy_encoder_context(VncState *vs) > > > > > > it's not libavcodec. > > > > I will fix that in v2. > > What about encodebin suggestion? I found no way to configure codec specific option (i.e. x264 zerolatency). I there a way? It is

Configuring onboard devices, in particular memory contents (was: [PATCH v1 0/1] hw/misc/aspeed_sbc: Implement OTP memory and controller)

2025-04-08 Thread Markus Armbruster
Cédric Le Goater writes: > Hello Kane, > > + Markus (for ebc29e1beab0 implementation) > > On 4/7/25 09:33, Kane Chen wrote: >> Hi Cédric/Philippe, >> OTP (One-Time Programmable) memory is a type of non-volatile memory >> in which each bit can be programmed only once. It is typically used >> to st

Re: [PATCH v3 2/2] vfio/spapr: Fix L2 crash with PCI device passthrough and memory > 128G

2025-04-08 Thread Cédric Le Goater
On 4/8/25 14:40, Amit Machhiwal wrote: An L2 KVM guest fails to boot inside a pSeries LPAR when booted with a memory more than 128 GB and PCI device passthrough. The L2 guest also crashes when it is booted with a memory greater than 128 GB and a PCI device is hotplugged later. The issue arises f

Re: Query on the dirty bitmap

2025-04-08 Thread prashant patil
Thank you, Eric, for the thorough information—truly appreciate it. Just to confirm what I understood, when we are reading a bitmap with 'x-dirty-bitmap' (for powered on vm of course), the 'start' is always a logical offset no matter whether the record has 'offset' value or not. Is this correct?

[PATCH v1 12/24] hw/s390x/ipl: Add IPIB flags to IPL Parameter Block

2025-04-08 Thread Zhuoying Cai
Add IPIB flags to IPL Parameter Block to determine if IPL needs to perform securely and if IPL Information Report Block (IIRB) exists. Secure boot in audit mode will perform if certificate(s) exist in the key store. IIRB will exist and results of verification will be stored in IIRB. Signed-off-by

[PATCH v3 00/10] Fix RVV encoding corner cases

2025-04-08 Thread Max Chou
This patch series fixes several corner cases of RISC-V vector instruction's encoding constraints. This v3 series addresses: - Merge v2 patches (3 & 4, 9 & 10) - Remove extra blank line in v2 patch 5 - Remove redundant co-authored-by tags Thank for Daniel Henrique Barboza's suggestions and review.

Re: [PATCH] hw/nvme: fix attachment of private namespaces

2025-04-08 Thread Keith Busch
On Tue, Apr 08, 2025 at 12:20:46PM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Fix regression when attaching private namespaces that gets attached to > the wrong controller. > > Keep track of the original controller "owner" of private namespaces, and > only attach if this matches on cont

[PATCH v3 5/5] utils/qemu-sockets: Introduce inet socket options controlling TCP keep-alive

2025-04-08 Thread Juraj Marcin
From: Juraj Marcin With the default TCP stack configuration, it could be even 2 hours before the connection times out due to the other side not being reachable. However, in some cases, the application needs to be aware of a connection issue much sooner. This is the case, for example, for postcop

[PATCH v3 0/5] util/qemu-sockets: Introduce inet socket options controlling TCP keep-alive

2025-04-08 Thread Juraj Marcin
This series extends the work introduced by commit aec21d3175 ("qapi: Add InetSocketAddress member keep-alive"). [1] First, the series fixes an issue in qio_dns_resolver_lookup_sync_inet(), where the InetSocketAddress structure is only partially copied. Next, it refactors setting client socket opti

[PATCH v3 4/5] util/qemu-sockets: Add support for keep-alive flag to passive sockets

2025-04-08 Thread Juraj Marcin
From: Juraj Marcin Commit aec21d3175 (qapi: Add InetSocketAddress member keep-alive) introduces the keep-alive flag, which enables the SO_KEEPALIVE socket option, but only on client-side sockets. However, this option is also useful for server-side sockets, so they can check if a client is still r

[PULL 4/4] test-bdrv-drain: Fix data races

2025-04-08 Thread Kevin Wolf
From: Vitalii Mordan This patch addresses potential data races involving access to Job fields in the test-bdrv-drain test. Fixes: 7253220de4 ("test-bdrv-drain: Test drain vs. block jobs") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2900 Signed-off-by: Vitalii Mordan Message-ID: <202

[PULL 8/8] scripts/checkpatch: Fix typo in SPDX-License-Identifier keyword

2025-04-08 Thread Philippe Mathieu-Daudé
From: Zhao Liu Fix the typo in the error message to help `grep` the example: ERROR: New file '***' requires 'SPDX-License-Identifer' Fixes: fa4d79c64dae ("scripts: mandate that new files have SPDX-License-Identifier") Signed-off-by: Zhao Liu Reviewed-by: Alex Bennée Message-ID: <202504081627

[PULL 7/8] hw/nvme: fix attachment of private namespaces

2025-04-08 Thread Philippe Mathieu-Daudé
rk csi handling") Reported-by: Alan Adamson Suggested-by: Alan Adamson Signed-off-by: Klaus Jensen Tested-by: Alan Adamson Reviewed-by: Alan Adamson Reviewed-by: Keith Busch Message-ID: <20250408-fix-private-ns-v1-1-28e169b6b...@samsung.com> Signed-off-by: Philippe Mathieu-Daudé --- hw

[PULL 3/8] docs/arm: Add apple HVF host for supported guest CPU type

2025-04-08 Thread Philippe Mathieu-Daudé
From: Zhang Chen In my test, latest QEMU already support Apple HVF for -cpu host and max. >From guest VM lscpu: Architecture: aarch64 CPU op-mode(s): 64-bit Byte Order: Little Endian CPU(s): 11 On-line CPU(s) list:0-10 Vendor ID:

Re: [PATCH] ui/curses: Fix infinite loop on windows

2025-04-08 Thread Philippe Mathieu-Daudé
On 3/4/25 03:07, William Hu via wrote: From a42046272f0544dd18ed58661e53ea17d1584c2c Mon Sep 17 00:00:00 2001 From: William Hu Date: Wed, 2 Apr 2025 12:00:00 -0400 Subject: [PATCH] ui/curses: Fix infinite loop on windows Replace -1 comparisons for wint_t with WEOF to fix infinite loop caused b

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-08 Thread Bernhard Beschow
Am 5. April 2025 14:00:00 UTC schrieb Guenter Roeck : >This series is needed to support the USB interface on imx8mp-evk when >booting the Linux kernel. > >According to the XHCI specification, ERSTBA should be written in Low-High >order. The Linux kernel writes the high word first. This results i

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-08 Thread Guenter Roeck
On 4/8/25 12:57, Bernhard Beschow wrote: Am 8. April 2025 16:09:58 UTC schrieb Guenter Roeck : On 4/6/25 11:08, Bernhard Beschow wrote: [ .. ] Yeah, it works with Buildroot as described in the handbook. When I append `-netdev user,id=net0 -device virtio-net-pci,netdev=net0` on the cli I can

Re: [PATCH preview 0/3] rust: update build system for Meson 1.8.0

2025-04-08 Thread Bernhard Beschow
Am 5. April 2025 10:06:00 UTC schrieb Paolo Bonzini : >Meson 1.7.0 and 1.8.0 include improved support for Rust, namely: >* support for "objects" in Rust executables >* support for doctest targets Using Meson 1.7.2 (shipped with my distro) I didn't succeed with either of these. If just applying

Re: [PATCH-for-10.0 0/3] More imx8mp-evk improvements

2025-04-08 Thread Bernhard Beschow
Am 8. April 2025 18:57:45 UTC schrieb "Philippe Mathieu-Daudé" : >On 5/4/25 23:48, Bernhard Beschow wrote: > >> Guenter Roeck (2): >>hw/arm/imx8mp-evk: Remove unimplemented cpu-idle-states properties >> from devicetree >>hw/arm/imx8mp-evk: Remove unimplemented nxp,imx8mp-fspi node

Re: [PATCH 1/2] accel/tcg: add get_virtual_clock for TCG

2025-04-08 Thread Alex Bennée
Mark Burton writes: > In principle I like this, but > 1/ throughout the API can we please make everything consistent sure that all > registrations take a handle (void *) and all callbacks functions pass that > handle (and the ID) > - right now, some things do, some things dont, and this speci

Re: [PATCH v2 1/2] vfio/spapr: Enhance error handling in vfio_spapr_create_window()

2025-04-08 Thread Cédric Le Goater
I think following change should be enough along with your suggested changes: diff --git a/hw/vfio/spapr.c b/hw/vfio/spapr.c index 1a5d1611f2cd..27fed3cd463c 100644 --- a/hw/vfio/spapr.c +++ b/hw/vfio/spapr.c @@ -378,8 +378,7 @@ vfio_spapr_container_add_section_window(VFIOContainerBase *bcontaine

Re: [PATCH v8 08/28] vfio: add region cache

2025-04-08 Thread John Levon
On Fri, Apr 04, 2025 at 06:18:20PM +0100, John Levon wrote: > On Fri, Apr 04, 2025 at 06:57:46PM +0200, Cédric Le Goater wrote: > > > > > why not populate vbasedev->regions[index] in vfio_get_all_regions() ? > > > > > > Good question. I presume it's not possible for us to ever look up a region >

[PATCH v1 02/24] hw/s390x/ipl: Create certificate store

2025-04-08 Thread Zhuoying Cai
Create a certificate store for boot certificates used for secure IPL. Load certificates from the -boot-certificate option into the cert store. Currently, only x509 certificates in DER format and uses SHA-256 hashing algorithm are supported, as these are the types required for secure boot on s390.

[PATCH v1 09/24] s390x/diag: Implement DIAG 508 subcode 2 for signature verification

2025-04-08 Thread Zhuoying Cai
From: Collin Walling DIAG 508 subcode 2 performs signature-verfication on signed components. A signed component may be a Linux kernel image, or any other signed binary. **Verification of initrd is not supported.** The instruction call expects two item-pairs: an address of a device component, an

[PATCH v1 10/24] pc-bios/s390-ccw: Introduce IPL Information Report Block (IIRB)

2025-04-08 Thread Zhuoying Cai
The IPL information report block (IIRB) contains information used to locate IPL records and to report the results of signature verification of one or more secure components of the load device. IIRB is stored immediately following the IPL Parameter Block. Results on component verification in any ca

[PATCH v1 22/24] pc-bios/s390-ccw: Handle true secure IPL mode

2025-04-08 Thread Zhuoying Cai
When secure boot is enabled (-secure-boot on) and certificate(s) are provided, the boot operates in True Secure IPL mode. Any verification error during True Secure IPL mode will cause the entire boot process to terminate. Secure IPL in audit mode requires at least one certificate provided in the

[PATCH v1 17/24] pc-bios/s390-ccw: Add signature verification for secure boot in audit mode

2025-04-08 Thread Zhuoying Cai
Enable secure IPL in audit mode, which performs signature verification, but any error does not terminate the boot process. Only warnings will be logged to the console instead. Add a comp_len variable to store the length of a segment in zipl_load_segment. comp_len variable is necessary to store the

[PATCH v1 20/24] Add -secure-boot on|off option in QEMU command line

2025-04-08 Thread Zhuoying Cai
The `-secure-boot on|off` command line option is implemented to enable secure IPL. By default, -secure-boot is set to false if not specified in the command line. Signed-off-by: Zhuoying Cai --- qemu-options.hx | 8 system/vl.c | 21 + 2 files changed, 29 insert

[PATCH v1 14/24] s390x: Guest support for Secure-IPL Facility

2025-04-08 Thread Zhuoying Cai
Introduce Secure-IPL (SIPL) facility. Use the abbreviation CBL (Consolidated-Boot-Loader facility at bit 0 of byte 136) to represent bytes 136 and 137 for IPL device facilities of the SCLP Read Info block. Availability of SIPL facility is determined by byte 136 bit 1 of the SCLP Read Info block.

[PATCH v1 03/24] s390x: Guest support for Certificate Store Facility (CS)

2025-04-08 Thread Zhuoying Cai
DIAG 320 is supported when the certificate-store (CS) facility is installed. Availability of CS facility is determined by byte 134 bit 5 of the SCLP Read Info block. Signed-off-by: Zhuoying Cai --- target/s390x/cpu_features.c | 1 + target/s390x/cpu_features_def.h.inc | 1 + target/s390

[PATCH v1 07/24] s390x/diag: Implement DIAG 320 subcode 2

2025-04-08 Thread Zhuoying Cai
DIAG 320 subcode 2 provides certificates that are in the certificate store. The subcode value is denoted by setting the second-left-most bit of an 8-byte field. The verification-certificate-block (VCB) contains the output data when the operation completes successfully. VCB includes a common heade

[PATCH v1 11/24] pc-bios/s390-ccw: Define memory for IPLB and convert IPLB to pointers

2025-04-08 Thread Zhuoying Cai
This patch is necessary because of the architectural design of IPL Parameter Block (IPLB) and IPL Information Report Block (IIRB). IIRB will be introduced in the next patch. Define a memory space for both IPL Parameter Block (IPLB) and IPL Information Report Block (IIRB) since IIRB is stored immed

[PATCH v1 23/24] pc-bios/s390-ccw: Handle secure boot with multiple boot devices

2025-04-08 Thread Zhuoying Cai
The current approach to enabling secure boot relies on providing -secure-boot and -boot-certificates options, which apply to all boot devices. With the possibility of multiple boot devices, secure boot expects all provided devices to be supported and eligible (e.g., virtio-blk/virtio-scsi using th

[PATCH v1 15/24] pc-bios/s390-ccw: Refactor zipl_run()

2025-04-08 Thread Zhuoying Cai
Refactor to enhance readability before enabling secure IPL in later patches. Signed-off-by: Zhuoying Cai --- pc-bios/s390-ccw/bootmap.c | 58 ++ 1 file changed, 34 insertions(+), 24 deletions(-) diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootm

[PATCH v1 13/24] hw/s390x/ipl: Set iplb->len to maximum length of IPL Parameter Block

2025-04-08 Thread Zhuoying Cai
The IPL Information Report Block (IIRB) immediately follows the IPL Parameter Block (IPLB). The IPLB struct is allocated 4KB in memory, and iplb->len indicates the amount of memory currently used by the IPLB. To ensure proper alignment of the IIRB and prevent overlap, set iplb->len to the maximum

[PATCH v1 04/24] s390x/diag: Introduce DIAG 320 for certificate store facility

2025-04-08 Thread Zhuoying Cai
From: Collin Walling DIAGNOSE 320 is introduced to support certificate store facility, which includes operations such as query certificate storage information and provide certificates in the certificate store. Currently, only subcode 0 is supported with this patch, which is used to query a bitma

  1   2   >