On 26/03/2025 15.18, Hanna Czenczek wrote:
On 26.03.25 13:38, Thomas Huth wrote:
From: Thomas Huth
This reverts commit e2668ba1ed44ad56f2f1653ff5f53b277d534fac.
This commit made test 162 fail occasionally with:
162 fail [13:06:40] [13:06:40] 0.2s (last: 0.2s) output mismatch
Michael Roth writes:
> Quoting Tom Lendacky (2025-03-26 14:21:31)
>> On 3/26/25 13:46, Tom Lendacky wrote:
>> > On 3/7/25 12:15, Fabiano Rosas wrote:
>> >> From: Steve Sistare
>> >>
>> >> Unlike cpr-reboot mode, cpr-transfer mode cannot save volatile ram blocks
>> >> in the migration stream file
On Wed, Mar 26, 2025 at 2:08 AM Markus Armbruster wrote:
> John Snow writes:
>
> > A few transitive dependencies were left floating; as a result, pip's
> > dependency solver can pull in newer dependencies, which we don't
> > want. Pin them down.
> >
> > Signed-off-by: John Snow
>
> What problem
On Wed, Mar 26, 2025 at 3:18 AM Markus Armbruster wrote:
> John Snow writes:
>
> > On Tue, Mar 25, 2025 at 4:05 AM Markus Armbruster
> wrote:
> >
> >> John Snow writes:
> >>
> >> > The pylint config is being left in place because the settings differ
> >> > enough from the python/ directory set
Please fix this compiling error.
cc -m64 -mcx16 -Ilibcommon.a.p -Isubprojects/libvduse -I../subprojects/libvduse
-I/usr/include/p11-kit-1 -I/usr/include/pixman-1 -I/usr/include/libpng16
-I/usr/include/spice-server -I/usr/include/spice-1 -I/usr/include/libusb-1.0
-I/usr/include/glib-2.0 -I/usr
On 3/25/25 08:40, Philippe Mathieu-Daudé wrote:
mips_cpu_is_64bit() returns whether the CPU is a
32-bit or a 64-bit one.
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/cpu-qom.h | 2 ++
target/mips/cpu.c | 6 ++
2 files changed, 8 insertions(+)
diff --git a/target/mips/cpu-q
This patch changes the qapidoc transmogrifier to generate Return value
documentation for any command that has a return value but hasn't
explicitly documented that return value.
Signed-off-by: John Snow
---
docs/sphinx/qapidoc.py | 14 --
scripts/qapi/parser.py | 15 +++
s
Well, I tried. Maybe not very hard. Sorry!
Signed-off-by: John Snow
---
qapi/block-core.json | 6 +++---
qapi/block-export.json | 2 +-
qapi/block.json | 2 +-
qapi/control.json| 5 ++---
qapi/dump.json | 5 ++---
qapi/introspect.json | 6 +++---
qapi/job.jso
v2: fix multi-return-sections bug :(
John Snow (4):
docs/qapi-domain: add return-nodesc
docs, qapi: generate undocumented return sections
qapi: remove trivial "Returns:" sections
qapi: rephrase return docs to avoid type name
docs/devel/qapi-domain.rst | 30 ++
The new qapidoc transmogrifier can generate "Returns" statements with
type information just fine, so we can remove it from the source where it
doesn't add anything particularly novel or helpful and just repeats the
type info.
This patch does not touch Returns: lines that add some information
(pote
On Wed, Mar 26, 2025 at 05:13:50PM -0300, Fabiano Rosas wrote:
> Michael Roth writes:
>
> > Quoting Tom Lendacky (2025-03-26 14:21:31)
> >> On 3/26/25 13:46, Tom Lendacky wrote:
> >> > On 3/7/25 12:15, Fabiano Rosas wrote:
> >> >> From: Steve Sistare
> >> >>
> >> >> Unlike cpr-reboot mode, cpr-t
This form is used to annotate a return type without an accompanying
description, for when there is no "Returns:" information in the source
doc, but we have a return type we want to generate a cross-reference to.
The syntax is:
:return-nodesc: TypeName
It's primarily necessary because Sphinx alwa
On Wed, Mar 26, 2025 at 03:16:18PM +0100, Eric Auger wrote:
> > @@ -1395,6 +1403,13 @@ static int smmuv3_cmdq_consume(SMMUv3State *s)
> >
> > trace_smmuv3_cmdq_cfgi_cd(sid);
> > smmuv3_flush_config(sdev);
> > +
> > +if (smmuv3_accel_batch_cmds(sdev->smmu, sde
On Wed, Mar 26, 2025 at 06:18:49PM +0100, Eric Auger wrote:
> > @@ -561,6 +561,16 @@ static int decode_ste(SMMUv3State *s, SMMUTransCfg
> > *cfg,
> >
> > decode_ste_config(cfg, config);
> >
> > + /* S1DSS.Terminate is same as Config.abort for default stream */
>
> S1DSS. Termination
On Tue, Mar 25, 2025 at 09:00:11PM +0100, Thomas Huth wrote:
> From: Thomas Huth
>
> These tests are using the gdb-related library functions from the
> Avocado framework which we don't have in the functional framework
> yet. So for the time being, keep those imports and skip the test
> if the Avo
From: Qiang Yu
mesa/radeonsi is going to support explicit modifier with this MR:
* https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31658
The side effect is some texture will become multi-plane which
breaks qemu. Because qemu currently only support single plane
texture.
For example,
From: Qiang Yu
It's used already, just check it explicitly.
Signed-off-by: Qiang Yu
---
ui/egl-helpers.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c
index d194d004b7..432863d702 100644
--- a/ui/egl-helpers.c
+++ b/ui/egl-he
From: Zhu Yangyang
Calling qmp_block_set_io_throttle() will be blocked for a long time
when a network disk is configured and the network failure is just about
to occur.
Therefore, we add a timeout parameter for qmp_block_set_io_throttle to control
its execution duration.
The default value of ti
From: Qiang Yu
We need spice version >= 0.15.3 which has spice_qxl_gl_scanout2
API for multi plane scanout support.
v2:
* use new dmabuf API and check length
* check spice_qxl_gl_scanout2 present instead of
bump spice version dependency
Signed-off-by: Qiang Yu
---
meson.build|
From: Zhu Yangyang
The bdrv_drained_begin() function is a blocking function. In scenarios where
network storage
is used and network links fail, it may block for a long time.
Therefore, we add a timeout parameter to control the duration of the block.
Since bdrv_drained_begin() has been widely ad
From: Qiang Yu
To handle multi plane.
v2:
* use new dmabuf API and check length
Signed-off-by: Qiang Yu
---
ui/dbus-display1.xml | 37 +++
ui/dbus-listener.c | 108 ---
2 files changed, 138 insertions(+), 7 deletions(-)
diff --git a/ui
From: Qiang Yu
v2:
* use new dmabuf API and check length
Signed-off-by: Qiang Yu
---
include/ui/egl-helpers.h | 5 ++-
ui/dbus-listener.c | 19 +
ui/egl-helpers.c | 91 ++--
ui/spice-display.c | 58 -
4
I'm not speaking for the QEMU project. I hope to be helpful anyway. I
am the QAPI maintainer, so my thoughts carry a bit more weight there.
I understand your block driver depends on your libvitastor_client
library.
Dependencies that aren't available on at least one supported build
platform (and
On Tue, Mar 25, 2025 at 09:00:19PM +0100, Thomas Huth wrote:
> From: Thomas Huth
>
> This way we can do a full boot in record-replay mode and
> should get a similar test coverage compared to the old
> replay test from tests/avocado/replay_linux.py. Thus remove
> the x86 avocado replay_linux test
From: Huaitong Han
The vring call fd is set even when the guest does not use msix (e.g., in the
case of virtio pmd), leading to unnecessary CPU overhead for processing
interrupts. The previous patch optimized the condition where msix is enabled
but the queue vector is unset. However, there is a a
From: Qiang Yu
0 is used as DRM_FORMAT_MOD_LINEAR already.
Reviewed-by: Marc-André Lureau
Signed-off-by: Qiang Yu
---
hw/display/vhost-user-gpu.c | 3 ++-
hw/display/virtio-gpu-udmabuf.c | 4 +++-
ui/egl-helpers.c| 3 ++-
3 files changed, 7 insertions(+), 3 deletions(-)
d
Am 10. März 2025 11:36:35 UTC schrieb Ilya Chichkov :
>Add a unit test for pcf8563_rtc module
>
>- Check default value after initialization
>- Check set/get time
>- Check minute alarm
>- Check hour alarm
>- Check day alarm
>- Check wday alarm
>- Check minute & hour alarm
>- Check minute & day al
From: Zhu Yangyang
Calling qmp_block_set_io_throttle() will be blocked for a long time
when a network disk is configured and the network failure is just about
to occur.
This series add a timeout parameter for qmp_block_set_io_throttle to control
its execution duration.
Changelog
v3 ---
Unify
On Wed, Mar 26, 2025 at 11:36:09AM +0800, Xiaoyao Li wrote:
> On 3/26/2025 2:46 AM, Daniel P. Berrangé wrote:
> > On Fri, Jan 24, 2025 at 08:20:48AM -0500, Xiaoyao Li wrote:
> > > Add docs/system/i386/tdx.rst for TDX support, and add tdx in
> > > confidential-guest-support.rst
> > >
> > > Signed-o
Philippe Mathieu-Daudé writes:
> There are no more use of ldtul_p() in the code base,
> remove the definitions.
>
> Signed-off-by: Philippe Mathieu-Daudé
Queued to gdbstub/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
When only the -kernel parameter is used to load the elf kernel,
the initrd is loaded in the ram. If the initrd size is too large,
the loading fails, resulting in a VM startup failure.
This patch first loads initrd near the kernel.
When the nearby memory space of the kernel is insufficient,
it tries
On Mon, Mar 24, 2025 at 3:00 PM Sahil Siddiq wrote:
>
> Implement the insertion of available buffers in the descriptor area of
> packed shadow virtqueues. It takes into account descriptor chains, but
> does not consider indirect descriptors.
>
> Enable the packed SVQ to forward the descriptors to
On Mon, Mar 24, 2025 at 3:00 PM Sahil Siddiq wrote:
>
> Allocate memory for the packed vq format and map them to the vdpa device.
>
> Since "struct vring" and "struct vring_packed's vring" both have the same
> memory layout, the implementation in SVQ start and SVQ stop should not
> differ based on
On Mon, Mar 24, 2025 at 3:00 PM Sahil Siddiq wrote:
>
> Validate transport device features required for utilizing packed SVQ
> that both guests can use with the SVQ and SVQs can use with vdpa.
>
> Signed-off-by: Sahil Siddiq
> ---
> Changes from v4 -> v5:
> - Split from commit #2 in v4.
>
> hw/v
On Mon, Mar 24, 2025 at 3:00 PM Sahil Siddiq wrote:
>
> This commit is the first in a series to add support for packed
> virtqueues in vhost_shadow_virtqueue.
>
> Linux commit 1225c216d954 ("vp_vdpa: allow set vq state to initial
> state after reset") enabled the vp_vdpa driver to set the vq state
Hi Shameer, Nicolin,
On 3/11/25 3:10 PM, Shameer Kolothum wrote:
> From: Nicolin Chen
>
> Inroduce an SMMUCommandBatch and some helpers to batch and issue the
> commands. Currently separate out TLBI commands and device cache commands
can you precise which "device cache commands" you are talking
On Mon, 2025-03-10 at 16:14 +0100, Philippe Mathieu-Daudé wrote:
> When multiple QOM types are registered in the same file,
> it is simpler to use the the DEFINE_TYPES() macro. In
s/the the/the/
> particular because type array declared with such macro
> are easier to review.
>
> Signed-off-by: P
Hi,
On 3/11/25 3:10 PM, Shameer Kolothum wrote:
> Make use of smmuv3_accel provided _install_nested_ste() for CFGI_STE.
>
> Signed-off-by: Shameer Kolothum
> ---
> hw/arm/smmuv3.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
> index ea63731d61..831
When using a VDPA device, it is important to ensure that the MAC
address is correctly set. The MAC address in the hardware should
match the MAC address from the QEMU command line. This is a recommended
configuration and will allow the system to boot.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net
On Wed, Mar 26, 2025 at 10:38:11AM +0100, Markus Armbruster wrote:
> I'm not speaking for the QEMU project. I hope to be helpful anyway. I
> am the QAPI maintainer, so my thoughts carry a bit more weight there.
>
> I understand your block driver depends on your libvitastor_client
> library.
>
>
Hanna Czenczek writes:
> On 26.03.25 06:38, Markus Armbruster wrote:
>> Hanna Czenczek writes:
>>
>>> FUSE allows creating multiple request queues by "cloning" /dev/fuse FDs
>>> (via open("/dev/fuse") + ioctl(FUSE_DEV_IOC_CLONE)).
>>>
>>> We can use this to implement multi-threading.
>>>
>>> Not
Hi,
> The problem is that add-ons are
>
> 1) Separate binaries. So you need to match multiple files.
> 2) In this case, get generated out of the vendor (RH)'s control in a
> one-off fashion.
>
> I don't think "signing" is the correct way to address the latter. It's
> rather hashing. But I
Hi,
Could you please let us know if you have any comments
on the latest version of this patch?
Kind regards,
Aleksandar Rakic
From: Thomas Huth
This reverts commit e2668ba1ed44ad56f2f1653ff5f53b277d534fac.
This commit made test 162 fail occasionally with:
162 fail [13:06:40] [13:06:40] 0.2s (last: 0.2s) output mismatch
--- tests/qemu-iotests/162.out
+++ tests/qemu-iotests/scratch/qcow2-file-162/162.out
On Wed, 26 Mar 2025, Thomas Huth wrote:
On 26/03/2025 07.47, Thomas Huth wrote:
On 25/03/2025 23.42, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
hw/audio/wm8750.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/audio/wm8750.c b/hw/audio/wm8750.c
index 8d
Hi Daniel,
On 2025-03-24 10:30, Daniel P. Berrangé wrote:
> On Wed, Mar 19, 2025 at 05:36:19PM +0100, Juraj Marcin wrote:
> > From: Juraj Marcin
> >
> > Commit aec21d3175 (qapi: Add InetSocketAddress member keep-alive)
> > introduces the keep-alive flag, which enables the SO_KEEPALIVE socket
> >
On 25/03/25, Brian Cain wrote:
>
> On 3/24/2025 8:53 PM, ltaylorsimp...@gmail.com wrote:
> >
> > > -Original Message-
> > > From: Anton Johansson
> > > Sent: Wednesday, March 12, 2025 2:46 PM
> > > To: qemu-devel@nongnu.org
> > > Cc: a...@rev.ng; ltaylorsimp...@gmail.com; brian.c...@oss.
Excellent find. Thank you very much for checking on the history.
Hopefully my comments were not too hard to read. =)
FYI: I've since left Akamai last year and now work at Nvidia.
Reviewed-by: Michael Galaxy
On 3/26/25 04:52, Jack Wang wrote:
I hit following error which testing migration in p
On 3/11/25 3:10 PM, Shameer Kolothum wrote:
> From: Nicolin Chen
>
> Use the provided smmuv3-accel helper functions to issue the
> command to physical SMMUv3.
>
> Signed-off-by: Nicolin Chen
> Signed-off-by: Shameer Kolothum
> ---
> hw/arm/smmuv3-internal.h | 11
> hw/arm/smmuv3.c
On 26.03.25 13:38, Thomas Huth wrote:
From: Thomas Huth
This reverts commit e2668ba1ed44ad56f2f1653ff5f53b277d534fac.
This commit made test 162 fail occasionally with:
162 fail [13:06:40] [13:06:40] 0.2s (last: 0.2s) output mismatch
--- tests/qemu-iotests/162.out
+++ tests/q
On Tue, Mar 25, 2025 at 4:13 AM Suravee Suthikulpanit
wrote:
>
> Currently, the QEMU-emulated AMD IOMMU device use PCI vendor id 0x1022
> (AMD) with device id zero (undefined). Eventhough this does not cause any
> functional issue for AMD IOMMU driver since it normally uses information
> in the AC
VFIOAddressSpace is a common object used by VFIOContainerBase which is
declared in "hw/vfio/vfio-container-base.h". Move the VFIOAddressSpace
related services into "container-base.c".
While at it, rename :
vfio_get_address_space -> vfio_address_space_get
vfio_put_address_space -> vfio_address
Gather all VFIOcontainer related declarations into
"hw/vfio/vfio-container.h" to reduce exposure of VFIO internals in
"hw/vfio/vfio-common.h". These declarations were initially introduced
in commit 65501a745dba ("vfio: vfio-pci device assignment driver").
They are made available externally for PPC
Both of these routines are only used in file "migration.c". Move them
there.
Reviewed-by: Joao Martins
Link: https://lore.kernel.org/qemu-devel/20250318095415.670319-5-...@redhat.com
Signed-off-by: Cédric Le Goater
---
include/hw/vfio/vfio-common.h | 2 --
hw/vfio/common.c | 62 --
vfio_mig_active() is part of the VFIO migration API. Move the
definitions where VFIO migration is implemented.
Reviewed-by: Avihai Horon
Reviewed-by: John Levon
Link: https://lore.kernel.org/qemu-devel/20250318095415.670319-2-...@redhat.com
Signed-off-by: Cédric Le Goater
---
hw/vfio/common.c
Enforce a 'vfio_mig_' prefix for the VFIO migration API to better
reflect the namespace these routines belong to.
Reviewed-by: Avihai Horon
Reviewed-by: John Levon
Reviewed-by: Philippe Mathieu-Daudé
Link: https://lore.kernel.org/qemu-devel/20250318095415.670319-3-...@redhat.com
Signed-off-by:
'vfio_device_list' is VFIODevice related. Move its definitions into
"device.c".
Reviewed-by: John Levon
Link: https://lore.kernel.org/qemu-devel/20250318095415.670319-23-...@redhat.com
Signed-off-by: Cédric Le Goater
---
hw/vfio/common.c | 3 ---
hw/vfio/device.c | 3 +++
2 files changed, 3 ins
Routines of common.c :
vfio_devices_all_dirty_tracking_started
vfio_devices_all_device_dirty_tracking
vfio_devices_query_dirty_bitmap
vfio_get_dirty_bitmap
are all related to dirty page tracking directly at the container level
or at the container device level. Naming is a bit confusing. We wi
These routines are VFIODevice related. Move their definitions into
"device.c".
Reviewed-by: John Levon
Link: https://lore.kernel.org/qemu-devel/20250318095415.670319-24-...@redhat.com
Signed-off-by: Cédric Le Goater
---
hw/vfio/common.c | 37 -
hw/vfio/device
This routine is only used in file "migration.c". Move it there.
Reviewed-by: John Levon
Reviewed-by: Joao Martins
Link: https://lore.kernel.org/qemu-devel/20250318095415.670319-6-...@redhat.com
Signed-off-by: Cédric Le Goater
---
include/hw/vfio/vfio-common.h | 1 -
hw/vfio/common.c
The migration core subsystem makes use of the VFIO migration API to
collect statistics on the number of bytes transferred. These services
are declared in "hw/vfio/vfio-common.h" which also contains VFIO
internal declarations. Move the migration declarations into a new
header file "hw/vfio/vfio-migr
Hello,
Several large extensions were merged in VFIO recently: migration
support with dirty tracking, support for different host IOMMU backend
devices, multifd support, etc. This adds up to the previous
extensions: vfio-platform, AP, CCW. The result is that VFIO is now a
subsystem of over +16,000 l
Fixes: 9bc9e9511944 (make-release: switch to .xz format by default)
Signed-off-by: Michael Tokarev
Reviewed-by: Philippe Mathieu-Daudé
---
Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index b65b0bd41a..c92a3cf785 100644
--- a/Makefile
+++
Pass-through devices of a VM are not necessarily in the same group and
all groups/address_spaces need to be scanned when the machine is
reset. Commit f16f39c3fc97 ("Implement PCI hot reset") introduced a VM
reset handler for this purpose. Move it under device.c
Also reintroduce the comment which e
vfio_get_info_dma_avail() is a low level routine similar to the other
routines extracting capabilities from 'struct vfio_iommu_type1_info'.
It belongs to file "helpers.c".
Reviewed-by: John Levon
Link: https://lore.kernel.org/qemu-devel/20250318095415.670319-17-...@redhat.com
Signed-off-by: Cédri
These routines are migration related. Move their declaration and
implementation under the migration files.
Signed-off-by: Cédric Le Goater
---
hw/vfio/vfio-migration-internal.h | 2 ++
include/hw/vfio/vfio-common.h | 3 ---
hw/vfio/common.c | 16
hw/vfio/m
Rename these routines :
vfio_put_group -> vfio_group_put
vfio_get_group -> vfio_group_get
vfio_kvm_device_del_group -> vfio_group_del_kvm_device
vfio_kvm_device_add_group -> vfio_group_add_kvm_device
vfio_get_device -> vfio_device_get
vfio_put_base_device -> vfio_device_put
vfio_devi
"hw/vfio/vfio-common.h" has been emptied of most of its declarations
by the previous changes and the only declarations left are related to
VFIODevice. Rename it to "hw/vfio/vfio-device.h" and make the
necessary adjustments.
Signed-off-by: Cédric Le Goater
---
hw/vfio/migration-multifd.h
vfio_group_list is only used in file "container.c".
Reviewed-by: John Levon
Reviewed-by: Zhenzhong Duan
Link: https://lore.kernel.org/qemu-devel/20250318095415.670319-13-...@redhat.com
Signed-off-by: Cédric Le Goater
---
include/hw/vfio/vfio-common.h | 2 --
hw/vfio/container.c | 3 +
File "common.c" has been emptied of most of its definitions by the
previous changes and the only definitions left are related to the VFIO
MemoryListener handlers. Rename it to "listener.c" and introduce its
associated "vfio-listener.h" header file for the declarations.
Cleanup a little the include
Use the prefix 'vfio_container_devices_' to reflect the routine simply
loops over the container's device list.
Signed-off-by: Cédric Le Goater
---
include/hw/vfio/vfio-container-base.h | 3 ++-
hw/vfio/common.c | 4 ++--
hw/vfio/container-base.c | 5 +++--
hw/vf
Gather all VFIORegion related declarations and definitions into their
own files to reduce exposure of VFIO internals in "hw/vfio/vfio-common.h".
They were introduced for 'vfio-platform' support in commits
db0da029a185 ("vfio: Generalize region support") and a664477db8da
("hw/vfio/pci: Introduce VFI
Rename these routines :
vfio_disable_irqindex -> vfio_device_irq_disable
vfio_unmask_single_irqindex -> vfio_device_irq_unmask
vfio_mask_single_irqindex -> vfio_device_irq_mask
vfio_set_irq_signaling -> vfio_device_irq_set_signaling
vfio_attach_device -> vfio_device
Gather all VFIOIOMMUFD related declarations introduced by commits
5ee3dc7af785 ("vfio/iommufd: Implement the iommufd backend") and
5b1e96e65403 ("vfio/iommufd: Introduce auto domain creation") into
"vfio-iommufd.h". This to reduce exposure of VFIO internals in
"hw/vfio/vfio-common.h".
Cc: Joao Mar
Gather all CPR related declarations into "vfio-cpr.h" to reduce exposure
of VFIO internals in "hw/vfio/vfio-common.h". These were introduced in
commit d9fa4223b30a ("vfio: register container for cpr").
Order file list in meson.build while at it.
Cc: Steve Sistare
Signed-off-by: Cédric Le Goater
On Mon, Mar 24, 2025 at 07:58:33PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Mon, 24 Mar 2025 19:58:33 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH v3 3/7] target/ppc: Register CPUClass:list_cpus
> X-Mailer: git-send-email 2.47.1
>
> Register ppc_cpu_list() as CPUClass:list_cpus call
Also rename vfio_devices_all_device_dirty_tracking_started() while at
it and use the prefix 'vfio_container_devices_' for routines simply
looping over the container's device list.
Signed-off-by: Cédric Le Goater
---
include/hw/vfio/vfio-container-base.h | 3 ++-
hw/vfio/common.c
Move all VFIODevice related routines of "helpers.c" into a new "device.c"
file.
Signed-off-by: Cédric Le Goater
---
hw/vfio/device.c | 330 +++
hw/vfio/helpers.c| 303 ---
hw/vfio/meson.build | 1 +
hw/vfio/tr
Rename some routines to better reflect the namespace they belong to.
Signed-off-by: Cédric Le Goater
---
hw/vfio/listener.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/vfio/listener.c b/hw/vfio/listener.c
index
26ced6d4fb04b0dedf399686db40acaca5d85552..07
vfio_container_query_dirty_bitmap() is only used in "container-base.c".
Also, rename to vfio_container_vioc_query_dirty_bitmap() to reflect it
is using the VFIO IOMMU backend device ->query_dirty_bitmap() handler.
Signed-off-by: Cédric Le Goater
---
include/hw/vfio/vfio-container-base.h | 2 --
vfio_kvm_device_add/del_fd() are low level routines. Move them with
the other helpers.
Reviewed-by: Zhenzhong Duan
Reviewed-by: John Levon
Link: https://lore.kernel.org/qemu-devel/20250318095415.670319-18-...@redhat.com
Signed-off-by: Cédric Le Goater
---
hw/vfio/vfio-helpers.h| 3 ++
These definitions don't have any use outside of their respective
submodules. There is no need to expose them externally. Keep them
private.
Reviewed-by: Zhenzhong Duan
Reviewed-by: John Levon
Link: https://lore.kernel.org/qemu-devel/20250318095415.670319-15-...@redhat.com
Signed-off-by: Cédric L
vfio_devices_query_dirty_bitmap() is only used in "container-base.c".
Also, rename to vfio_container_devices_query_dirty_bitmap() to reflect
with the prefix 'vfio_container_devices_' that it simply loops over
the container's device list.
This rename also frees the vfio_devices_query_dirty_bitmap()
vfio_get_device_info() is a low level routine. Move it with the other
helpers.
Reviewed-by: Zhenzhong Duan
Reviewed-by: John Levon
Link: https://lore.kernel.org/qemu-devel/20250318095415.670319-19-...@redhat.com
Signed-off-by: Cédric Le Goater
---
hw/vfio/vfio-helpers.h| 1 +
include/
On Mon, Mar 24, 2025 at 07:58:34PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Mon, 24 Mar 2025 19:58:34 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH v3 4/7] target/sparc: Register CPUClass:list_cpus
> X-Mailer: git-send-email 2.47.1
>
> Register sparc_cpu_list() as CPUClass:list_cpus
VFIOHostDMAWindow is only used in file "spapr.c". Move it there.
Reviewed-by: John Levon
Link: https://lore.kernel.org/qemu-devel/20250318095415.670319-9-...@redhat.com
Signed-off-by: Cédric Le Goater
---
include/hw/vfio/vfio-common.h | 7 ---
hw/vfio/spapr.c | 7 +++
2 fi
This hides the MemoryListener implementation and makes the code common
to both IOMMU backends, legacy and IOMMUFD.
Signed-off-by: Cédric Le Goater
---
hw/vfio/vfio-listener.h | 3 ++-
hw/vfio/container.c | 11 +++
hw/vfio/iommufd.c | 9 ++---
hw/vfio/listener.c | 22
On 3/25/25 18:38, Aditya Gupta wrote:
On 25/03/25 22:45, Cédric Le Goater wrote:
On 3/25/25 18:07, Aditya Gupta wrote:
On 25/03/25 20:17, Cédric Le Goater wrote:
On 3/25/25 12:23, Aditya Gupta wrote:
<...snip...>
+ machine_class_allow_dynamic_sysbus_dev(mc, TYPE_PNV_PHB);
There was a
vfio_container_query_dirty_bitmap() is consistent the VFIO container
routine naming scheme and is now free to use.
Signed-off-by: Cédric Le Goater
---
include/hw/vfio/vfio-container-base.h | 4 ++--
hw/vfio/common.c | 6 +++---
hw/vfio/container-base.c | 5 +++--
Gather all helper routine declarations into "vfio-helpers.h" to reduce
exposure of VFIO internals in "hw/vfio/vfio-common.h".
Reviewed-by: John Levon
Link: https://lore.kernel.org/qemu-devel/20250318095415.670319-16-...@redhat.com
Signed-off-by: Cédric Le Goater
---
hw/vfio/vfio-helpers.h
On Mon, Mar 24, 2025 at 3:14 PM Sahil Siddiq wrote:
>
> Hi,
>
> I had a few queries here.
>
> On 3/24/25 7:29 PM, Sahil Siddiq wrote:
> > Implement the insertion of available buffers in the descriptor area of
> > packed shadow virtqueues. It takes into account descriptor chains, but
> > does not c
Gather all VFIO migration related declarations into
"vfio-migration-internal.h" to reduce exposure of VFIO internals in
"hw/vfio/vfio-common.h".
Cc: Kirti Wankhede
Cc: Avihai Horon
Signed-off-by: Cédric Le Goater
---
hw/vfio/vfio-migration-internal.h | 72 +++
inclu
Gather all VFIOdisplay related declarations into "vfio-display.h" to
reduce exposure of VFIO internals in "hw/vfio/vfio-common.h".
Reviewed-by: John Levon
Link: https://lore.kernel.org/qemu-devel/20250318095415.670319-8-...@redhat.com
Signed-off-by: Cédric Le Goater
---
hw/vfio/pci.h
On Mon, Mar 24, 2025 at 07:58:37PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Mon, 24 Mar 2025 19:58:37 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH v3 7/7] cpus: Remove #ifdef check on cpu_list definition
> X-Mailer: git-send-email 2.47.1
>
> Since we removed all definitions of cpu_l
On Mon, Mar 24, 2025 at 07:58:35PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Mon, 24 Mar 2025 19:58:35 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH v3 5/7] target/s390x: Declare
> s390_set_qemu_cpu_model/cpu_list in cpu_models.h
> X-Mailer: git-send-email 2.47.1
>
> Both s390_cpu_li
On Mon, Mar 24, 2025 at 07:58:36PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Mon, 24 Mar 2025 19:58:36 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH v3 6/7] target/s390x: Register CPUClass:list_cpus
> X-Mailer: git-send-email 2.47.1
>
> Register s390_cpu_list() as CPUClass:list_cpus c
The vfio_kvm_device_add/del_fd() routines opening the VFIO pseudo
device are defined in "helpers.c". Move 'vfio_kvm_device_fd'
definition there and its declaration into "vfio-helpers.h" to reduce
exposure of VFIO internals in "hw/vfio/vfio-common.h".
Reviewed-by: John Levon
Link: https://lore.ker
On 25/03/2025 23.43, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/dm163.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/dm163.c b/hw/display/dm163.c
index 75a91f62bd3..f6f0ec0c632 100644
--- a/hw/display/dm163.c
+++ b/hw/d
On 25/03/2025 23.43, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
hw/dma/i82374.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c
index 9652d47adcd..0bf69ef399b 100644
--- a/hw/dma/i82374.c
+++ b/hw/dma/i82374.c
@@ -150,6 +150
On 25/03/2025 23.43, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/m25p80.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index b84c6afb327..0887c103e4f 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -
101 - 200 of 246 matches
Mail list logo
