Re: [PATCH 0/1 RFC] FUSE Export Coroutine Integration Cover Letter

2025-03-24 Thread Stefan Hajnoczi
On Mon, Mar 24, 2025 at 04:05:09PM +0800, saz97 wrote: > This patch series refactors QEMU's FUSE export module to leverage coroutines > for read/write operations, > addressing concurrency limitations and aligning with QEMU's asynchronous I/O > model. The changes > demonstrate measurable performan

Re: [PATCH] vfio: Open code vfio_migration_set_error()

2025-03-24 Thread Avihai Horon
On 24/03/2025 14:33, Cédric Le Goater wrote: External email: Use caution opening links or attachments VFIO uses migration_file_set_error() in a couple of places where an 'Error **' parameter is not provided. In MemoryListener handlers : vfio_listener_region_add vfio_listener_log_global

Re: [PATCH] docs/devel/build-environment: enhance MSYS2 instructions

2025-03-24 Thread Pierrick Bouvier
On 3/5/25 13:38, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- docs/devel/build-environment.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/devel/build-environment.rst b/docs/devel/build-environment.rst index f133ef2e012..661f6ea8504 100644 --- a

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-03-24 Thread Gerd Hoffman
On Mon, Mar 24, 2025 at 05:31:30PM +0100, Alexander Graf wrote: > > > > > > What does all this mean for the hypervisor interface ? > > > > That means we'll go scratch the region list idea and depend on igvm > > > > instead. > > > > Which means we are back to the single firmware image. > > > So i

Re: [PATCH v2 09/11] target/ppc: convert gdbstub to new helpers

2025-03-24 Thread Richard Henderson
On 3/24/25 03:21, Alex Bennée wrote: +#ifdef TARGET_BIG_ENDIAN +MemOp end = MO_BE; +#else +MemOp end = MO_LE; +#endif +#endif That's what MO_TE is for. +/* + * Helpers copied from helpers.h just for handling target_ulong values + * from gdbstub's GByteArray based on what t

Re: [PATCH] target/s390x: Fix a typo in s390_cpu_class_init()

2025-03-24 Thread Philippe Mathieu-Daudé
On 24/3/25 07:05, Thomas Huth wrote: On 23/03/2025 16.30, Philippe Mathieu-Daudé wrote: Fixes: 41868f846d2 ("s390x/cpumodel: "host" and "qemu" as CPU subclasses") Signed-off-by: Philippe Mathieu-Daudé ---   target/s390x/cpu.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH-for-10.1 v2 4/7] tcg: Remove use of TCG_GUEST_DEFAULT_MO in tb_gen_code()

2025-03-24 Thread Richard Henderson
On 3/21/25 11:15, Philippe Mathieu-Daudé wrote: Use TCGCPUOps::guest_default_memory_order to set TCGContext::guest_mo. Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/translate-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-03-24 Thread Daniel P . Berrangé
On Mon, Mar 24, 2025 at 06:53:59PM +0100, Gerd Hoffman wrote: > On Mon, Mar 24, 2025 at 05:31:30PM +0100, Alexander Graf wrote: > > > > > > > > What does all this mean for the hypervisor interface ? > > > > > > That means we'll go scratch the region list idea and depend on igvm > > > > > instead.

Re: [PATCH-for-10.1 v2 0/7] cpus: Convert cpu_list definition to CPUClass:list_cpus callback

2025-03-24 Thread Philippe Mathieu-Daudé
On 24/3/25 19:59, Pierrick Bouvier wrote: On 3/24/25 11:46, Philippe Mathieu-Daudé wrote: Since v1 (Thomas review comments) - Move s390_set_qemu_cpu_model/s390_cpu_list to "cpu_models.h" - Correct 'target/s390x: Register CPUClass:list_cpus' subject 'cpu_list' might be defined per target, and fo

Re: [PATCH v2 04/11] gdbstub: introduce target independent gdb register helper

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 03:21, Alex Bennée wrote: The current helper.h functions rely on hard coded assumptions about target endianess to use the tswap macros. We also end up double swapping a bunch of values if the target can run in multiple endianess modes. Avoid this by getting the target to pass the endia

[PATCH-for-10.1 v2 1/7] cpus: Introduce CPUClass::list_cpus() callback

2025-03-24 Thread Philippe Mathieu-Daudé
Some targets define cpu_list to a method listing their CPUs on stdout. In order to make list_cpus() generic, introduce the CPUClass::list_cpus() callback. When no callback is registered, list_cpus() defaults to the cpu_list definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Hut

Re: [PATCH-for-10.1 v2 5/7] target/s390x: Declare s390_set_qemu_cpu_model/cpu_list in cpu_models.h

2025-03-24 Thread Richard Henderson
On 3/24/25 11:46, Philippe Mathieu-Daudé wrote: Both s390_cpu_list() and s390_set_qemu_cpu_model() are defined in cpu_models.c, move their declarations in the related "cpu_models.h" header. Use full path to header in s390-virtio-ccw.c file. Suggested-by: Thomas Huth Signed-off-by: Philippe Math

Re: [PATCH-for-10.1 v2 0/7] cpus: Convert cpu_list definition to CPUClass:list_cpus callback

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 11:46, Philippe Mathieu-Daudé wrote: Since v1 (Thomas review comments) - Move s390_set_qemu_cpu_model/s390_cpu_list to "cpu_models.h" - Correct 'target/s390x: Register CPUClass:list_cpus' subject 'cpu_list' might be defined per target, and force code to be built per-target. We can avo

[PATCH v3 6/7] target/s390x: Register CPUClass:list_cpus

2025-03-24 Thread Philippe Mathieu-Daudé
Register s390_cpu_list() as CPUClass:list_cpus callback and remove the cpu_list definition. Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/cpu.h | 3 --- target/s390x/cpu.c | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h index

[PATCH v3 7/7] cpus: Remove #ifdef check on cpu_list definition

2025-03-24 Thread Philippe Mathieu-Daudé
Since we removed all definitions of cpu_list, the #ifdef check is always true. Remove it, inlining cpu_list(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson --- cpu-target.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(

[PATCH v3 1/7] cpus: Introduce CPUClass::list_cpus() callback

2025-03-24 Thread Philippe Mathieu-Daudé
Some targets define cpu_list to a method listing their CPUs on stdout. In order to make list_cpus() generic, introduce the CPUClass::list_cpus() callback. When no callback is registered, list_cpus() defaults to the cpu_list definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Hut

[PATCH-for-10.1 v2 4/7] target/sparc: Register CPUClass:list_cpus

2025-03-24 Thread Philippe Mathieu-Daudé
Register sparc_cpu_list() as CPUClass:list_cpus callback. Reduce its scope and remove the cpu_list definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- target/sparc/cpu.h | 3 --- target/sparc/cpu.c | 3 ++- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH-for-10.1 v2 6/7] target/s390x: Register CPUClass:list_cpus

2025-03-24 Thread Philippe Mathieu-Daudé
Register s390_cpu_list() as CPUClass:list_cpus callback and remove the cpu_list definition. Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c index 8449bfee5a9..2876f2c4eb3 100644 --- a/target/

[PATCH-for-10.1 v2 7/7] cpus: Remove #ifdef check on cpu_list definition

2025-03-24 Thread Philippe Mathieu-Daudé
Since we removed all definitions of cpu_list, the #ifdef check is always true. Remove it, inlining cpu_list(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- cpu-target.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/cpu-target.c b/

[PATCH-for-10.1 v2 2/7] target/i386: Register CPUClass:list_cpus

2025-03-24 Thread Philippe Mathieu-Daudé
Register x86_cpu_list() as CPUClass:list_cpus callback. Reduce its scope and remove the cpu_list definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- target/i386/cpu.h | 3 --- target/i386/cpu.c | 3 ++- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/ta

[PATCH v3 5/7] target/s390x: Declare s390_set_qemu_cpu_model/cpu_list in cpu_models.h

2025-03-24 Thread Philippe Mathieu-Daudé
Both s390_cpu_list() and s390_set_qemu_cpu_model() are defined in cpu_models.c, move their declarations in the related "cpu_models.h" header. Use full path to header in s390-virtio-ccw.c file. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/cpu.h | 4 ---

RE: [PATCH 3/8] hw/hexagon: Add v68, sa8775-cdsp0 defs

2025-03-24 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Saturday, March 1, 2025 11:21 AM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; quic_mathb...@quicinc.com; a...@rev.ng; a...@rev.ng; > quic_mlie...@quicinc.com; ltaylorsimp

Re: [PATCH v2 17/30] exec/target_page: runtime defintion for TARGET_PAGE_BITS_MIN

2025-03-24 Thread Pierrick Bouvier
On 3/22/25 13:55, Richard Henderson wrote: On 3/21/25 17:20, Pierrick Bouvier wrote: On 3/21/25 17:01, Pierrick Bouvier wrote: On 3/21/25 15:19, Richard Henderson wrote: On 3/21/25 13:11, Pierrick Bouvier wrote: On 3/21/25 12:27, Richard Henderson wrote: On 3/21/25 11:09, Pierrick Bouvier wr

Re: [RFC PATCH v2 05/20] hw/arm/smmuv3-accel: Associate a pxb-pcie bus

2025-03-24 Thread Donald Dutile
On 3/24/25 10:56 AM, Eric Auger wrote: On 3/21/25 1:59 AM, Donald Dutile wrote: On 3/19/25 2:21 PM, Eric Auger wrote: Hi Don, On 3/19/25 5:21 PM, Donald Dutile wrote: On 3/19/25 5:26 AM, Shameerali Kolothum Thodi wrote: Hi Don, Hey! -Original Message- From: Donald Dutil

Re: [PATCH v2 26/30] hw/arm/armv7m: prepare compilation unit to be common

2025-03-24 Thread Richard Henderson
On 3/24/25 14:31, Pierrick Bouvier wrote: On 3/23/25 12:48, Richard Henderson wrote: On 3/20/25 15:29, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier ---    hw/arm/armv7m.c | 12    1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/arm/armv7m.c b/hw/arm/armv

Re: [RFC v5 3/7] vhost: Forward descriptors to device via packed SVQ

2025-03-24 Thread Sahil Siddiq
Hi, I had a few queries here. On 3/24/25 7:29 PM, Sahil Siddiq wrote: Implement the insertion of available buffers in the descriptor area of packed shadow virtqueues. It takes into account descriptor chains, but does not consider indirect descriptors. Enable the packed SVQ to forward the descr

Re: [PATCH v2 2/3] vhost: return failure if stop virtqueue failed in vhost_dev_stop

2025-03-24 Thread Stefano Garzarella
On Thu, Mar 20, 2025 at 08:21:25PM +0800, Haoqian He wrote: 2025年3月19日 23:11,Stefano Garzarella 写道: On Fri, Mar 14, 2025 at 06:15:33AM -0400, Haoqian He wrote: The backend maybe crash when vhost_dev_stop and GET_VRING_BASE would fail, we can return failure to indicate the connection with the

Re: [RFC PATCH v2 03/20] hw/arm/smmuv3-accel: Add initial infrastructure for smmuv3-accel device

2025-03-24 Thread Eric Auger
On 3/21/25 1:54 AM, Donald Dutile wrote: > > > On 3/19/25 1:04 PM, Eric Auger wrote: >> >> >> >> On 3/18/25 10:22 PM, Donald Dutile wrote: >>> >>> >>> On 3/18/25 3:13 PM, Nicolin Chen wrote: On Tue, Mar 18, 2025 at 07:31:36PM +0100, Eric Auger wrote: > On 3/17/25 9:19 PM, Nicolin Chen w

Re: [PATCH v2] virtio-net: Fix the interpretation of max_tx_vq

2025-03-24 Thread Lei Yang
QE tested this patch with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Sat, Mar 22, 2025 at 2:48 PM Akihiko Odaki wrote: > > virtio-net uses the max_tx_vq field of struct virtio_net_rss_config to > determine the number of queue pairs and emits an error message sayi

Re: [RFC PATCH v2 05/20] hw/arm/smmuv3-accel: Associate a pxb-pcie bus

2025-03-24 Thread Eric Auger
On 3/21/25 1:59 AM, Donald Dutile wrote: > > > On 3/19/25 2:21 PM, Eric Auger wrote: >> Hi Don, >> >> >> On 3/19/25 5:21 PM, Donald Dutile wrote: >>> >>> >>> On 3/19/25 5:26 AM, Shameerali Kolothum Thodi wrote: Hi Don, >>> Hey! >>> > -Original Message- > From: Donald Du

Re: [PULL 00/24] Mostly Rust changes for QEMU 10.0

2025-03-24 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v2 1/2] io/block: Refactoring the bdrv_drained_begin() function and implement a timeout mechanism.

2025-03-24 Thread Stefan Hajnoczi
On Fri, Mar 21, 2025 at 03:09:16PM +0800, zoudongjie wrote: > From: Zhu Yangyang > > The bdrv_drained_begin() function is a blocking function. In scenarios where > network storage > is used and network links fail, it may block for a long time. > Therefore, we add a timeout parameter to control t

[PATCH-for-10.1 v2 3/7] target/ppc: Register CPUClass:list_cpus

2025-03-24 Thread Philippe Mathieu-Daudé
Register ppc_cpu_list() as CPUClass:list_cpus callback. Reduce its scope and remove the cpu_list definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- target/ppc/cpu.h | 4 target/ppc/cpu_init.c | 3 ++- 2 files changed, 2 insertions(+), 5 deletions(-) diff -

Re: [PATCH v2 00/11] gdbstub: conversion to runtime endianess helpers

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 03:21, Alex Bennée wrote: The aim of this work is to get rid of the endian aware helpers in gdbstub/helpers.h which due to their use of tswap() mean target gdbstubs need to be built multiple times. While this series doesn't actually build each stub once it introduces a new helper - gdb

Re: [PATCH v2 08/11] target/ppc: make ppc_maybe_bswap_register static

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 03:21, Alex Bennée wrote: It's not used outside of the gdbstub code. Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- target/ppc/cpu.h | 1 - target/ppc/gdbstub.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff -

Re: [PATCH v2 10/11] target/microblaze: convert gdbstub to new helper

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 03:21, Alex Bennée wrote: This is a pretty simple conversion given a single set of registers and an existing helper to probe endianess. Signed-off-by: Alex Bennée --- v2 - use mb_cpu_is_big_endian - use explicit MO_32 size - handle differing size of env->ear between user/sy

RE: [PATCH 5/8] hw/hexagon: Modify "Standalone" symbols

2025-03-24 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Saturday, March 1, 2025 11:21 AM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; quic_mathb...@quicinc.com; a...@rev.ng; a...@rev.ng; > quic_mlie...@quicinc.com; ltaylorsimp

Re: [PATCH 1/6] ui/dmabuf: extend QemuDmaBuf to support multi-plane

2025-03-24 Thread Qiang Yu
On Mon, Mar 24, 2025 at 10:06 PM Marc-André Lureau wrote: > > Hi > > On Mon, Mar 24, 2025 at 5:20 PM Qiang Yu wrote: > > > > On Mon, Mar 24, 2025 at 6:04 PM Marc-André Lureau > > wrote: > > > > > > Hi > > > > > > On Mon, Mar 24, 2025 at 12:19 PM wrote: > > > > > > > > From: Qiang Yu > > > > >

Re: [PATCH v3 6/7] target/s390x: Register CPUClass:list_cpus

2025-03-24 Thread Philippe Mathieu-Daudé
On 24/3/25 20:02, Richard Henderson wrote: On 3/24/25 11:58, Philippe Mathieu-Daudé wrote: Register s390_cpu_list() as CPUClass:list_cpus callback and remove the cpu_list definition. Signed-off-by: Philippe Mathieu-Daudé ---   target/s390x/cpu.h | 3 ---   target/s390x/cpu.c | 1 +   2 files cha

Re: [PATCH v2 01/11] include/exec: fix assert in size_memop

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 03:21, Alex Bennée wrote: We can handle larger sized memops now, expand the range of the assert. Fixes: 4b473e0c60 (tcg: Expand MO_SIZE to 3 bits) Signed-off-by: Alex Bennée --- v2 - instead of 128 use 1 << MO_SIZE for future proofing --- include/exec/memop.h | 4 ++-- 1 file

[PATCH-for-10.1 v2 0/7] cpus: Convert cpu_list definition to CPUClass:list_cpus callback

2025-03-24 Thread Philippe Mathieu-Daudé
Since v1 (Thomas review comments) - Move s390_set_qemu_cpu_model/s390_cpu_list to "cpu_models.h" - Correct 'target/s390x: Register CPUClass:list_cpus' subject 'cpu_list' might be defined per target, and force code to be built per-target. We can avoid that by introducing a CPUClass callback. This

[PATCH-for-10.1 v2 5/7] target/s390x: Declare s390_set_qemu_cpu_model/cpu_list in cpu_models.h

2025-03-24 Thread Philippe Mathieu-Daudé
Both s390_cpu_list() and s390_set_qemu_cpu_model() are defined in cpu_models.c, move their declarations in the related "cpu_models.h" header. Use full path to header in s390-virtio-ccw.c file. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/cpu.h | 4 ---

Re: [PATCH v2 03/11] gdbstub: assert earlier in handle_read_all_regs

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 03:21, Alex Bennée wrote: When things go wrong we want to assert on the register that failed to be able to figure out what went wrong. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v2 02/11] include/gdbstub: fix include guard in commands.h

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 03:21, Alex Bennée wrote: Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- include/gdbstub/commands.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h index

Re: [PATCH v2 07/11] target/ppc: expand comment on FP/VMX/VSX access functions

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 03:21, Alex Bennée wrote: Mainly as an aid to myself getting confused too many bswaps deep into the code. Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- target/ppc/cpu.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target/ppc/cpu.h b/tar

RE: [PATCH 4/8] hw/hexagon: Add support for cfgbase

2025-03-24 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Saturday, March 1, 2025 11:21 AM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; quic_mathb...@quicinc.com; a...@rev.ng; a...@rev.ng; > quic_mlie...@quicinc.com; ltaylorsimp

Re: [PATCH v2 09/11] target/ppc: convert gdbstub to new helpers

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 13:04, Richard Henderson wrote: On 3/24/25 12:29, Pierrick Bouvier wrote: On 3/24/25 10:39, Richard Henderson wrote: On 3/24/25 03:21, Alex Bennée wrote: +    #ifdef TARGET_BIG_ENDIAN +    MemOp end = MO_BE; +    #else +    MemOp end = MO_LE; +    #endif +#endif That's what MO_TE

Re: [PATCH v8 00/20] Change ghes to use HEST-based offsets and add support for error inject

2025-03-24 Thread Mauro Carvalho Chehab
Hi Michael, Gentile ping. Regards, Mauro Em Fri, 7 Mar 2025 20:14:29 +0100 Mauro Carvalho Chehab escreveu: > Hi Michael, > > I'm sending v8 to avoid a merge conflict with v7 due to this > changeset: > >611f3bdb20f7 ("hw/acpi/ghes: Make static") > > As ghes_record_cper_errors() was wri

RE: [PATCH 2/2] target/hexagon: Drop `ident` postprocess step

2025-03-24 Thread ltaylorsimpson
> -Original Message- > From: Anton Johansson > Sent: Wednesday, March 12, 2025 2:46 PM > To: qemu-devel@nongnu.org > Cc: a...@rev.ng; ltaylorsimp...@gmail.com; brian.c...@oss.qualcomm.com; > phi...@linaro.org > Subject: [PATCH 2/2] target/hexagon: Drop `ident` postprocess step > > The

[PATCH v2] hw/i386/amd_iommu: Assign pci-id 0x1419 for the AMD IOMMU device

2025-03-24 Thread Suravee Suthikulpanit
Currently, the QEMU-emulated AMD IOMMU device use PCI vendor id 0x1022 (AMD) with device id zero (undefined). Eventhough this does not cause any functional issue for AMD IOMMU driver since it normally uses information in the ACPI IVRS table to probe and initialize the device per recommendation in t

Re: [PATCH v7 1/2] hw/loongarch/virt: Fix cpuslot::cpu set at last in virt_cpu_plug()

2025-03-24 Thread bibo mao
Markus, Thanks for your reviewing and guidance. Regards Bibo Mao On 2025/3/24 下午2:05, Markus Armbruster wrote: Bibo Mao writes: In function virt_cpu_plug(), Object cpuslot::cpu is set at last only when there is no any error, otherwise it is problematic that cpuslot::cpu is set in advance ho

Re: [PATCH 2/2] target/hexagon: Drop `ident` postprocess step

2025-03-24 Thread Brian Cain
On 3/24/2025 8:53 PM, ltaylorsimp...@gmail.com wrote: -Original Message- From: Anton Johansson Sent: Wednesday, March 12, 2025 2:46 PM To: qemu-devel@nongnu.org Cc: a...@rev.ng; ltaylorsimp...@gmail.com; brian.c...@oss.qualcomm.com; phi...@linaro.org Subject: [PATCH 2/2] target/hexag

[PATCH v4 3/8] hw/ppc: Trigger Fadump boot if fadump is registered

2025-03-24 Thread Aditya Gupta
According to PAPR: R1–7.3.30–3. When the platform receives an ibm,os-term RTAS call, or on a system reset without an ibm,nmi-interlock RTAS call, if the platform has a dump structure registered through the ibm,configure-kernel-dump call, the platform must process each registere

[PATCH v2 06/30] exec/cpu-all: remove exec/page-protection include

2025-03-24 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- include/exec/cpu-all.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index eb029b65552..4a2cac1252d 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -19,7 +19,6 @@ #ifndef CPU_ALL_H #defi

Re: [PATCH v2 11/11] include/gdbstub: add note to helpers.h

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 10:29, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 24/3/25 11:21, Alex Bennée wrote: We've not yet deprecated but we should steer users away from these helpers if they want to be in a single/heterogeneous binary. Why not deprecate? I guess philosophically do we expect

Re: [PATCH v2 04/11] gdbstub: introduce target independent gdb register helper

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 03:21, Alex Bennée wrote: The current helper.h functions rely on hard coded assumptions about target endianess to use the tswap macros. We also end up double swapping a bunch of values if the target can run in multiple endianess modes. Avoid this by getting the target to pass the endia

Re: [PATCH v2 11/11] include/gdbstub: add note to helpers.h

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 10:29, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 24/3/25 11:21, Alex Bennée wrote: We've not yet deprecated but we should steer users away from these helpers if they want to be in a single/heterogeneous binary. Why not deprecate? I guess philosophically do we expect

Re: [PATCH v2 04/11] gdbstub: introduce target independent gdb register helper

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 03:21, Alex Bennée wrote: The current helper.h functions rely on hard coded assumptions about target endianess to use the tswap macros. We also end up double swapping a bunch of values if the target can run in multiple endianess modes. Avoid this by getting the target to pass the endia

Re: [PATCH v2 09/11] target/ppc: convert gdbstub to new helpers

2025-03-24 Thread Richard Henderson
On 3/24/25 12:29, Pierrick Bouvier wrote: On 3/24/25 10:39, Richard Henderson wrote: On 3/24/25 03:21, Alex Bennée wrote: +    #ifdef TARGET_BIG_ENDIAN +    MemOp end = MO_BE; +    #else +    MemOp end = MO_LE; +    #endif +#endif That's what MO_TE is for. +/* + * Helpers copied from helper

Re: [PATCH v2 05/11] target/arm: convert 32 bit gdbstub to new helpers

2025-03-24 Thread Pierrick Bouvier
On 3/24/25 03:21, Alex Bennée wrote: For some of the helpers we need a temporary variable to copy from although we could add some helpers to return pointers into env in those cases if we wanted to. Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- v2 - use new wrappers - expl

Re: [PULL 0/3] aspeed queue

2025-03-24 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v2 24/30] meson: add common hw files

2025-03-24 Thread Pierrick Bouvier
On 3/23/25 12:58, Richard Henderson wrote: On 3/20/25 15:29, Pierrick Bouvier wrote: Those files will be compiled once per base architecture ("arm" in this case), instead of being compiled for every variant/bitness of architecture. We make sure to not include target cpu definitions (exec/cpu-de

Re: [PATCH] docs/devel/build-environment: enhance MSYS2 instructions

2025-03-24 Thread Philippe Mathieu-Daudé
Cc'ing Stefan and Yonggang On 5/3/25 22:38, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- docs/devel/build-environment.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/devel/build-environment.rst b/docs/devel/build-environment.rst index f133ef2e0

Re: [PATCH 03/17] target/avr: Improve decode of LDS, STS

2025-03-24 Thread Pierrick Bouvier
On 3/23/25 10:37, Richard Henderson wrote: The comment about not being able to define a field with zero bits is out of date since 94597b6146f3 ("decodetree: Allow !function with no input bits"). This fixes the missing load of imm in the disassembler. Cc: qemu-sta...@nongnu.org Fixes: 9d8caa67a2

Re: [PATCH 04/17] target/avr: Remove OFFSET_CPU_REGISTERS

2025-03-24 Thread Pierrick Bouvier
On 3/23/25 10:37, Richard Henderson wrote: This define isn't really used. Signed-off-by: Richard Henderson --- target/avr/cpu.h| 2 -- target/avr/helper.c | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/target/avr/cpu.h b/target/avr/cpu.h index 06f5ae4d1b..84a8f5c

Re: [PATCH v4 0/2] hw/i386/amd_iommu: Add migration support

2025-03-24 Thread Suthikulpanit, Suravee
Hi, Any other concerns for this series? Thanks Suravee On 3/4/2025 9:17 PM, Suravee Suthikulpanit wrote: Currently, amd-iommu device does not support migration. This series addresses an issue due hidden AMDVI-PCI device enumeration. Then introduces migratable VMStateDescription, which saves ne

[RFC PATCH] Hexagon (target/hexagon) analyze all reads before writes

2025-03-24 Thread Taylor Simpson
I noticed that analyze_packet is marking the implicit pred reads after marking all the writes. However, the semantics of the instrucion and packet are to do all the reads, then do the operation, then do all the writes. Here is the old code static void analyze_packet(DisasContext *ctx) { Packe

Re: [PULL 0/3] aspeed queue

2025-03-24 Thread Michael Tokarev
24.03.2025 23:46, Cédric Le Goater wrote: Is there anything in there worth to pick up for stable series? you are fast ! I was just about to send final announcements for a bunch of next stable releases, and noticed another pull request has been merged.. :) - "aspeed: Fix maximum number of

Re: [PATCH 13/17] target/avr: Handle offset_io in avr_cpu_realizefn

2025-03-24 Thread Pierrick Bouvier
On 3/23/25 10:37, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/avr/cpu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/avr/cpu.c b/target/avr/cpu.c index e4011004b4..538fcbc215 100644 --- a/target/avr/cpu.c +++ b/target/avr/cpu.c @@ -

Re: [PATCH 01/17] hw/core/cpu: Use size_t for memory_rw_debug len argument

2025-03-24 Thread Pierrick Bouvier
On 3/23/25 10:37, Richard Henderson wrote: Match the prototype of cpu_memory_rw_debug(). Signed-off-by: Richard Henderson --- include/hw/core/cpu.h | 2 +- target/sparc/cpu.h| 2 +- target/sparc/mmu_helper.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a

Re: [PATCH 2/6] ui/egl: require EGL_EXT_image_dma_buf_import_modifiers

2025-03-24 Thread Qiang Yu
On Mon, Mar 24, 2025 at 9:45 PM Marc-André Lureau wrote: > > Hi > > On Mon, Mar 24, 2025 at 5:27 PM Qiang Yu wrote: > > > > On Mon, Mar 24, 2025 at 6:09 PM Marc-André Lureau > > wrote: > > > > > > Hi > > > > > > On Mon, Mar 24, 2025 at 12:19 PM wrote: > > > > > > > > From: Qiang Yu > > > > > >

[PATCH-for-10.1 0/3] migration/cpu: Remove qemu_{get, put}_[s]betl[s] macros

2025-03-24 Thread Philippe Mathieu-Daudé
The following macros: - qemu_put_betl() - qemu_get_betl() - qemu_put_betls() - qemu_get_betls() - qemu_put_sbetl() - qemu_get_sbetl() - qemu_put_sbetls() - qemu_get_sbetls() are used twice. Expand tl -> 32/64 and remove them. Philippe Mathieu-Daudé (3): target/mips: Inline qemu_get_bet

Re: [RFC PATCH v2 05/20] hw/arm/smmuv3-accel: Associate a pxb-pcie bus

2025-03-24 Thread Daniel P . Berrangé
On Mon, Mar 24, 2025 at 03:56:12PM +0100, Eric Auger wrote: > > > On 3/21/25 1:59 AM, Donald Dutile wrote: > > > > > > On 3/19/25 2:21 PM, Eric Auger wrote: > >> Hi Don, > >> > >> > >> On 3/19/25 5:21 PM, Donald Dutile wrote: > >>> > >>> > >>> On 3/19/25 5:26 AM, Shameerali Kolothum Thodi wrote:

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-03-24 Thread Alexander Graf
On 24.03.25 16:48, Gerd Hoffman wrote: On Mon, Mar 24, 2025 at 04:42:28PM +0530, Ani Sinha wrote: On Mon, Mar 24, 2025 at 1:13 PM Gerd Hoffman wrote: Hi, Going ship the distro kernel as igvm image would work too. Will simplify the measurement pre-calculation. Also there is no need to

Re: [PATCH-for-10.1 5/6] target/sparc: Register CPUClass:list_cpus

2025-03-24 Thread Philippe Mathieu-Daudé
On 24/3/25 10:30, Thomas Huth wrote: On 23/03/2025 23.40, Philippe Mathieu-Daudé wrote: Register sparc_cpu_list() as CPUClass:list_cpus callback and remove the cpu_list definition. Copy-n-paste error in both, subject and patch description: This should be about s390x, not sparc. Oh oops. d

Re: [PATCH v2 01/11] include/exec: fix assert in size_memop

2025-03-24 Thread Philippe Mathieu-Daudé
On 24/3/25 11:21, Alex Bennée wrote: We can handle larger sized memops now, expand the range of the assert. Fixes: 4b473e0c60 (tcg: Expand MO_SIZE to 3 bits) Signed-off-by: Alex Bennée --- v2 - instead of 128 use 1 << MO_SIZE for future proofing --- include/exec/memop.h | 4 ++-- 1 file

Re: [PATCH] vfio: Open code vfio_migration_set_error()

2025-03-24 Thread Avihai Horon
On 24/03/2025 17:25, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 3/24/25 16:14, Avihai Horon wrote: On 24/03/2025 14:33, Cédric Le Goater wrote: External email: Use caution opening links or attachments VFIO uses migration_file_set_error() in a coup

Re: [PATCH 2/6] ui/egl: require EGL_EXT_image_dma_buf_import_modifiers

2025-03-24 Thread Marc-André Lureau
Hi On Mon, Mar 24, 2025 at 5:27 PM Qiang Yu wrote: > > On Mon, Mar 24, 2025 at 6:09 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Mon, Mar 24, 2025 at 12:19 PM wrote: > > > > > > From: Qiang Yu > > > > > > It's used already, just check it explicitly. > > > > > > Signed-off-by: Qiang Yu

Re: [PATCH 6/6] ui/spice: support multi plane dmabuf scanout

2025-03-24 Thread Marc-André Lureau
On Mon, Mar 24, 2025 at 5:35 PM Qiang Yu wrote: > > On Mon, Mar 24, 2025 at 5:30 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Mon, Mar 24, 2025 at 12:20 PM wrote: > > > > > > From: Qiang Yu > > > > > > Signed-off-by: Qiang Yu > > > --- > > > meson.build| 2 +- > > > ui/spice-d

Re: [PATCH] tests/functional: Add missing require_netdev('user') statements

2025-03-24 Thread Daniel P . Berrangé
On Mon, Mar 24, 2025 at 01:34:50PM +0100, Thomas Huth wrote: > From: Thomas Huth > > A bunch of tests are using "-netdev user" but fail to check > for the availability of SLIRP in the binary, so these tests > fail if QEMU has been configured with "--disable-slirp" > (most of the tests are disable

Re: [PATCH v2 3/3] vhost-user: return failure if backend crash when live migration

2025-03-24 Thread Stefano Garzarella
On Thu, Mar 20, 2025 at 08:21:30PM +0800, Haoqian He wrote: 2025年3月19日 23:20,Stefano Garzarella 写道: On Fri, Mar 14, 2025 at 06:15:34AM -0400, Haoqian He wrote: Live migration should be terminated if the backend crashes before the migration completes. Since the vhost device will be stopped

Re: [PATCH] vfio: Open code vfio_migration_set_error()

2025-03-24 Thread Cédric Le Goater
On 3/24/25 16:14, Avihai Horon wrote: On 24/03/2025 14:33, Cédric Le Goater wrote: External email: Use caution opening links or attachments VFIO uses migration_file_set_error() in a couple of places where an 'Error **' parameter is not provided. In MemoryListener handlers :    vfio_listener_

Re: [RFC PATCH v2 05/20] hw/arm/smmuv3-accel: Associate a pxb-pcie bus

2025-03-24 Thread Eric Auger
On 3/24/25 2:55 PM, Shameerali Kolothum Thodi wrote: > Hi Eric, > >> -Original Message- >> From: qemu-devel- >> bounces+shameerali.kolothum.thodi=huawei@nongnu.org > devel-bounces+shameerali.kolothum.thodi=huawei@nongnu.org> On >> Behalf Of Eric Auger >> Sent: Monday, March 24, 2

Re: [PATCH-for-10.1 1/4] target/riscv: Restrict RV128 MTTCG check on system emulation

2025-03-24 Thread Richard Henderson
On 3/21/25 08:59, Philippe Mathieu-Daudé wrote: Multi-threaded TCG only concerns system emulation. That's not really true. User emulation simply has no option to run in a single-threaded context. I really don't think we should allow RV128 in user-mode at all. Certainly not until there's a ker

Re: [RFC PATCH v2 05/20] hw/arm/smmuv3-accel: Associate a pxb-pcie bus

2025-03-24 Thread Nicolin Chen
On Mon, Mar 24, 2025 at 02:13:20PM +0100, Eric Auger wrote: > >> If VM has an emulated device and a passthrough device: > >> attach the emulated device to PCIE.0 <=> vSMMU bypass (or accel=off?) > >> attach the passthrough device to pxb-pcie <=> vSMMU0 (accel=on) > > This can be other way around

Re: [RFC PATCH v2 05/20] hw/arm/smmuv3-accel: Associate a pxb-pcie bus

2025-03-24 Thread Nicolin Chen
On Mon, Mar 24, 2025 at 08:19:27AM +, Shameerali Kolothum Thodi wrote: > > If VM has an emulated device and a passthrough device: > > attach the emulated device to PCIE.0 <=> vSMMU bypass (or accel=off?) > > attach the passthrough device to pxb-pcie <=> vSMMU0 (accel=on) > > This can be othe

RE: [PATCH 17/39] target/hexagon: Implement software interrupt

2025-03-24 Thread Sid Manning
> -Original Message- > From: ltaylorsimp...@gmail.com > Sent: Wednesday, March 19, 2025 4:28 PM > To: 'Brian Cain' ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; phi...@linaro.org; Matheus Bernardino > (QUIC) ; a...@rev.ng; a...@rev.ng; Marco > Liebel (QUIC) ; alex.ben...@li

[RFC 1/3] vdagent: Wrap vdagent_register_to_qemu_clipboard function

2025-03-24 Thread yong . huang
From: Hyman Huang For direct use in the upcoming commit, wrap the vdagent registry logic as vdagent_register_to_qemu_clipboard. Meanwhile, add a trace event for vdagent_recv_caps. Signed-off-by: Hyman Huang --- ui/trace-events | 1 + ui/vdagent.c| 23 --- 2 files chan

RE: [RFC PATCH v2 05/20] hw/arm/smmuv3-accel: Associate a pxb-pcie bus

2025-03-24 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Nicolin Chen > Sent: Monday, March 24, 2025 4:02 PM > To: Eric Auger > Cc: Shameerali Kolothum Thodi > ; Donald Dutile > ; qemu-...@nongnu.org; qemu-devel@nongnu.org; > peter.mayd...@linaro.org; j...@nvidia.com; berra...@redhat.com; > nath...@nvidia.com; mo

Re: [PATCH-for-10.1 3/3] migration/cpu: Remove qemu_{get,put}_[s]betl[s] macros

2025-03-24 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > The following macros: > > - qemu_put_betl() > - qemu_get_betl() > - qemu_put_betls() > - qemu_get_betls() > - qemu_put_sbetl() > - qemu_get_sbetl() > - qemu_put_sbetls() > - qemu_get_sbetls() > > are not used in the whole code base, remove them. > > Signed

Re: [PATCH for-10.1 24/32] vfio: Introduce new files for dirty tracking definitions and declarations

2025-03-24 Thread Cédric Le Goater
On 3/20/25 10:46, John Levon wrote: On Tue, Mar 18, 2025 at 10:54:07AM +0100, Cédric Le Goater wrote: File "common.c" has been emptied of most of its definitions by the previous changes and the only definitions left are related to dirty tracking. Rename it to "dirty-tracking.c" and introduce it

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-03-24 Thread Daniel P . Berrangé
On Fri, Mar 21, 2025 at 09:22:59AM +0100, Gerd Hoffman wrote: > On Thu, Mar 20, 2025 at 09:34:26AM +0100, Jörg Rödel wrote: > > On Tue, Mar 18, 2025 at 12:11:02PM +0100, Gerd Hoffman wrote: > > > Open questions: > > > > > > - Does the idea to use igvm parameters for the kernel hashes makes > > >

Re: [PULL 00/12] ppc-for-10.0-2 queue

2025-03-24 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/8] Error reporting patches for 2025-03-21

2025-03-24 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/6] Uefi 20250321 patches

2025-03-24 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] smbios: Fix buffer overrun when using path= option

2025-03-24 Thread Daniel P . Berrangé
CC qemu-stable - this needs cherry-picking into all active stable branches once accepted. On Mon, Mar 24, 2025 at 09:12:53AM +, Daniel P. Berrangé wrote: > On Sun, Mar 23, 2025 at 10:35:54PM +0100, Daan De Meyer wrote: > > We have to make sure the array of bytes read from the path= file > > is

Re: [PULL 0/3] loongarch-to-apply queue

2025-03-24 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/3] Trivial patches for 2025-03-21

2025-03-24 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [RFC PATCH v2 05/20] hw/arm/smmuv3-accel: Associate a pxb-pcie bus

2025-03-24 Thread Eric Auger
Hi Shameer, On 3/24/25 9:19 AM, Shameerali Kolothum Thodi wrote: > >> -Original Message- >> From: Nicolin Chen >> Sent: Thursday, March 20, 2025 5:03 PM >> To: Shameerali Kolothum Thodi >> Cc: Donald Dutile ; qemu-...@nongnu.org; qemu- >> de...@nongnu.org; eric.au...@redhat.com; peter.ma

Re: [PATCH 1/6] ui/dmabuf: extend QemuDmaBuf to support multi-plane

2025-03-24 Thread Qiang Yu
On Mon, Mar 24, 2025 at 6:04 PM Marc-André Lureau wrote: > > Hi > > On Mon, Mar 24, 2025 at 12:19 PM wrote: > > > > From: Qiang Yu > > > > mesa/radeonsi is going to support explicit midifier which > > may export a multi-plane texture. For example, texture with > > DCC enabled (a compressed forma

  1   2   3   4   >