Re: [PATCH] cryptodev: Fix error handling in cryptodev_lkcf_execute_task()

2025-03-18 Thread Markus Armbruster
zhenwei pi writes: > On 3/18/25 21:21, Markus Armbruster wrote: >> zhenwei pi writes: >> >>> Hi Markus, >>> >>> Current code style seems buggy, I think the main reason is that the Error >>> *errp is not generated at right place. keyctl_pkey_XXX fails without new >>> error, qcrypto_akcipher_XX

Re: [PATCH] cryptodev: Fix error handling in cryptodev_lkcf_execute_task()

2025-03-18 Thread zhenwei pi
LGTM, thanks! Reviewed-by: zhenwei pi On 3/12/25 18:11, Markus Armbruster wrote: When cryptodev_lkcf_set_op_desc() fails, we report an error, but continue anyway. This is wrong. We then pass a non-null @local_error to various functions, which could easily fail error_setv()'s assertion on fai

[PATCH v3 0/6] Improve Microchip Polarfire SoC customization

2025-03-18 Thread Sebastian Huber
Booting the microchip-icicle-kit machine using the latest PolarFire SoC Hart Software Services (HSS) no longer works since Qemu lacks support for several registers (clocks, DRAM controller). Also reading from the SDCard does not work currently. In order to allow tests runs for real-time kernels su

Re: [PATCH 13/17] rust/vmstate: Support vmstate_validate

2025-03-18 Thread Paolo Bonzini
Il mar 18 mar 2025, 07:16 Zhao Liu ha scritto: > > Would it be possible, or make sense, to move most of the code for > > field_exists inside .with_exist_check()? > > > > If so, the method would be like: > > pub fn with_exist_check( > mut self, > _cb: F > ) -> Self >

Re: [PATCH v2 29/42] include/exec: Split out watchpoint.h

2025-03-18 Thread Richard Henderson
On 3/18/25 17:30, Pierrick Bouvier wrote:   include/exec/watchpoint.h   | 41 +   include/hw/core/cpu.h   | 30 -   accel/tcg/tcg-accel-ops.c   |  1 +   system/watchpoint.c |  1 +   target/arm/debug_helper.c

Re: Generic way to detect qemu linux-user emulation

2025-03-18 Thread Peter Maydell
On Tue, 18 Mar 2025 at 13:55, Daniel P. Berrangé wrote: > > On Tue, Mar 18, 2025 at 01:06:17PM +, Peter Maydell wrote: > > The difficulty with vfork() (and, more generally, with various of > > the clone() syscall flag combinations) is that because we use the > > host libc we are restricted to

Re: Generic way to detect qemu linux-user emulation

2025-03-18 Thread Helge Deller
On 3/18/25 11:18, Andreas Schwab wrote: Is there a generic way for a program to detect that is it being run inside the linux-user emulation? Yes, having a reliable way to detect it would be good. My current (unreliable) way to detect it is using uname. The kernel string and arch name don't mat

[PATCH v2 03/14] rust/vmstate: Fix num field when varray flags are set

2025-03-18 Thread Zhao Liu
Array type vmstate has the VMStateField with `num` equals its length. When the varray vmstate is built based a array type, the `num` field should be cleaned to 0, because varray uses `num_offset` instead of `num` to store elements number information. Signed-off-by: Zhao Liu --- rust/qemu-api/sr

RE: [RFC PATCH v2 03/20] hw/arm/smmuv3-accel: Add initial infrastructure for smmuv3-accel device

2025-03-18 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Nicolin Chen > Sent: Monday, March 17, 2025 8:19 PM > To: Jason Gunthorpe > Cc: Eric Auger ; Shameerali Kolothum Thodi > ; qemu-...@nongnu.org; > qemu-devel@nongnu.org; peter.mayd...@linaro.org; ddut...@redhat.com; > berra...@redhat.com; nath...@nvidia.com;

<    1   2   3   4