Re: [PATCH v5 14/14] hw/sd/sdhci: Remove unnecessary 'endianness' property

2025-03-11 Thread Philippe Mathieu-Daudé
On 10/3/25 15:09, BALATON Zoltan wrote: On Mon, 10 Mar 2025, Philippe Mathieu-Daudé wrote: The previous commit removed the single use of instance setting the "endianness" property. Since classes can register their io_ops with correct endianness, no need to support different ones. Remove the co

Re: [PULL 00/21] target-arm queue

2025-03-11 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [RFC PATCH v3 4/5] hw/vfio/ap: Storing event information for an AP configuration change event

2025-03-11 Thread Anthony Krowiak
On 3/10/25 11:35 AM, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie Reyes --- hw/vfio/ap.c

Re: [PATCH v2 28/62] docs/qapi-domain: add CSS styling

2025-03-11 Thread Markus Armbruster
John Snow writes: > Improve the general look and feel of generated QAPI docs. > > Attempt to limit line lengths to offer a more comfortable measure on > maximized windows, and improve some margin and spacing for field lists. > > Signed-off-by: Harmonie Snow > Signed-off-by: John Snow > --- > d

[PULL 70/72] ppc/amigaone: Add kernel and initrd support

2025-03-11 Thread Nicholas Piggin
From: BALATON Zoltan Add support for -kernel, -initrd and -append command line options. Signed-off-by: BALATON Zoltan Reviewed-by: Nicholas Piggin Message-ID: <489b1be5d95d5153e924c95b0691b8b53f9ffb9e.1740673173.git.bala...@eik.bme.hu> Signed-off-by: Nicholas Piggin --- hw/ppc/amigaone.c |

Re: [PATCH v7 0/7] hw/char/pl011: Implement TX (async) FIFO to avoid blocking the main loop

2025-03-11 Thread Peter Maydell
On Mon, 10 Mar 2025 at 14:42, Peter Maydell wrote: > > On Mon, 10 Mar 2025 at 01:28, Philippe Mathieu-Daudé > wrote: > > > > Hi, > > > > This series add support for (async) FIFO on the transmit path > > of the PL011 UART. > > This hasn't made the last pre-softfreeze arm pullreq, but > I think we

[PATCH 09/16] mcd: Implement register query

2025-03-11 Thread Mario Fleischmann
Directly map MCD register groups to GDB features lists Signed-off-by: Mario Fleischmann --- mcd/libmcd_qapi.c | 48 +++ mcd/libmcd_qapi.h | 8 ++ mcd/mcdserver.c | 237 -- mcd/mcdstub_qapi.c| 93 qapi/mcd.json

Re: [PATCH] gitlab-ci: include full Rust backtraces in test runs

2025-03-11 Thread Peter Maydell
On Wed, 29 Jan 2025 at 08:21, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > --- > .gitlab-ci.d/buildtest-template.yml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitlab-ci.d/buildtest-template.yml > b/.gitlab-ci.d/buildtest-template.yml > index 39da7698b09..4cc19239319 1

[PATCH 0/1] util/cacheflush: Make first DSB unconditional on aarch64

2025-03-11 Thread Joe Komlodi
Hi all, This fixes some TCG TB corruption we would occasionally see on aarch64 hosts in certain situations. Specifically, if the host had CTR_EL0.DIC and CTR_EL0.IDC set, and if the TBs generated were very small, the instructions in the TB would sometimes be garbage. This would mostly result in a

[PATCH v3 32/63] qapi/parser: adjust info location for doc body section

2025-03-11 Thread John Snow
Instead of using the info object for the doc block as a whole (which always points to the very first line of the block), update the info pointer for each call to ensure_untagged_section when the existing section is otherwise empty. This way, Sphinx error information will match precisely to where th

Re: [PATCH v5 8/8] ppc/pnv: Update skiboot to support Power11

2025-03-11 Thread Aditya Gupta
On 10/03/25 17:15, Cédric Le Goater wrote: On 3/10/25 11:31, Aditya Gupta wrote: <...snip...>   pc-bios/skiboot.lid | Bin 2527328 -> 2527424 bytes   1 file changed, 0 insertions(+), 0 deletions(-) This change should come first as a sub maintainer PR, to avoid sending 2.5MB on the mailing lis

Re: [PATCH] trace/control-target: cleanup headers and make compilation unit common

2025-03-11 Thread Richard Henderson
On 3/10/25 10:17, Pierrick Bouvier wrote: On 3/4/25 21:07, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier ---   trace/control-target.c | 2 --   trace/meson.build  | 4 +---   2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/trace/control-target.c b/trace/control-target.

[RFC PATCH v3 5/5] s390: implementing CHSC SEI for AP config change

2025-03-11 Thread Rorie Reyes
Handle interception of the CHSC SEI instruction for requests indicating the guest's AP configuration has changed. Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak Tested-by: Anthony Krowiak --- target/s390x/ioinst.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff

Re: [RFC PATCH 2/4] hw/arm/raspi: Replace TARGET_AARCH64 by legacy_binary_is_64bit()

2025-03-11 Thread Daniel P . Berrangé
On Wed, Mar 05, 2025 at 05:12:46PM +0100, Philippe Mathieu-Daudé wrote: > For legacy ARM binaries, legacy_binary_is_64bit() is > equivalent of the compile time TARGET_AARCH64 definition. > > Use it as TypeInfo::registerable() callback to dynamically > add Aarch64 specific types in qemu-system-aarc

[PATCH v10 02/10] ui/sdl2: Implement dpy dmabuf functions

2025-03-11 Thread Dmitry Osipenko
From: Pierre-Eric Pelloux-Prayer If EGL is used, we can rely on dmabuf to import textures without doing copies. To get this working on X11, we use the existing SDL hint: SDL_HINT_VIDEO_X11_FORCE_EGL (because dmabuf can't be used with GLX). Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirki

[PATCH v5 17/29] hw/intc/aspeed: Add Support for AST2700 INTCIO Controller

2025-03-11 Thread Jamin Lin via
Introduce a new ast2700 INTCIO class to support AST2700 INTCIO. Added new register definitions for INTCIO, including enable and status registers for IRQs GICINT192 through GICINT197. Created a dedicated IRQ array for INTCIO, supporting six input pins and six output pins, aligning with the newly def

Re: [PATCH v7 5/5] migration: add MULTIFD_RECV_SYNC migration command

2025-03-11 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Mar 07, 2025 at 05:15:03PM +0530, Prasad Pandit wrote: >> diff --git a/migration/migration.c b/migration/migration.c >> index 65fc4f5eed..da2c49c303 100644 >> --- a/migration/migration.c >> +++ b/migration/migration.c >> @@ -3401,9 +3401,10 @@ static MigIterateState >>

[RFC PATCH v3 3/5] hw/vfio/ap: store object indicating AP config changed in a queue

2025-03-11 Thread Rorie Reyes
Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects will later be used to store event information for an AP configuration change when the CHSC instruction is intercepted. Signed-off-by: Rorie Reyes --- hw/vfio/ap.c | 10 +++

[PULL 2/3] hw/xen: Add "mode" parameter to xen-block devices

2025-03-11 Thread Anthony PERARD
From: David Woodhouse Block devices don't work in PV Grub (0.9x) if there is no mode specified. It complains: "Error ENOENT when reading the mode" Signed-off-by: David Woodhouse Message-Id: <20250207143724.30792-2-dw...@infradead.org> Signed-off-by: Anthony PERARD --- hw/block/xen-block.c | 2

[PATCH v4 04/14] hw/sd/sdhci: Make quirks a class property

2025-03-11 Thread Philippe Mathieu-Daudé
All TYPE_IMX_USDHC instances use the quirk: move it to the class layer. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sdhci.h | 3 ++- hw/sd/sdhci.c | 15 +-- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/include/hw/sd/sdhci.h b/include/hw/sd/sdhc

[RFC PATCH v3 0/5] Report vfio-ap configuration changes

2025-03-11 Thread Rorie Reyes
Changelog: v3: - changes that were made to patch 3/5 should have been made in patch 2/5 v2: - removed warnings that weren't needed - added unregister function - removed whitelines - changed variable names for consistency - removed rc variable and returning 1 or 0 outright - reversed logics for if

Re: [PATCH 2/2] 9pfs: reduce latency of v9fs_reclaim_fd()

2025-03-11 Thread Greg Kurz
On Tue, 4 Mar 2025 16:16:05 +0100 Christian Schoenebeck wrote: > This function calls v9fs_co_close() and v9fs_co_closedir() in a loop. Each > one of the calls adds two thread hops (between main thread and a fs driver > background thread). Each thread hop adds latency, which sums up in > function'

Re: [PATCH v5 23/29] hw/arm/aspeed: Add Machine Support for AST2700 A1

2025-03-11 Thread Cédric Le Goater
On 3/6/25 11:38, Jamin Lin wrote: Introduce "aspeed_machine_ast2700a1_evb_class_init" to initialize the AST2700 A1 EVB. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed.c | 24 1 file changed, 24 insertions(+) diff --git a

Re: [PATCH] pci-ids.rst: Add Red Hat pci-id for AMD IOMMU device

2025-03-11 Thread Daniel P . Berrangé
On Thu, Mar 06, 2025 at 09:11:53AM +0200, Yan Vugenfirer wrote: > On Wed, Mar 5, 2025 at 8:54 AM Michael S. Tsirkin wrote: > > > On Tue, Mar 04, 2025 at 06:37:47PM +, Suravee Suthikulpanit wrote: > > > The QEMU-emulated AMD IOMMU PCI device is implemented based on the AMD > > I/O > > > Virtua

Re: [PATCH 04/16] exec/memory.h: make devend_memop target agnostic

2025-03-11 Thread Pierrick Bouvier
On 3/10/25 09:30, Richard Henderson wrote: On 3/9/25 21:58, Pierrick Bouvier wrote: Will allow to make system/memory.c common later. Signed-off-by: Pierrick Bouvier --- include/exec/memory.h | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/include/exec/memo

[RFC PATCH v3 1/5] linux-headers: NOTFORMERGE - placeholder uapi updates for AP config change

2025-03-11 Thread Rorie Reyes
This patch adds enumeration constant VFIO_AP_CFG_CHG_IRQ_INDEX to specify an IRQ index for signaling that a change has been made to the guest's AP configuration. This is a placeholder for QEMU patches that use this value since it is a linux-headers update which includes changes that aren't merged i

Re: [PATCH v5 14/14] hw/sd/sdhci: Remove unnecessary 'endianness' property

2025-03-11 Thread Cédric Le Goater
On 3/10/25 18:38, Bernhard Beschow wrote: Am 10. März 2025 17:31:57 UTC schrieb "Philippe Mathieu-Daudé" : On 10/3/25 16:56, Guenter Roeck wrote: On 3/10/25 08:27, Philippe Mathieu-Daudé wrote: On 10/3/25 15:09, BALATON Zoltan wrote: On Mon, 10 Mar 2025, Philippe Mathieu-Daudé wrote: The

Re: Sapphire Rapids missing from "Preferred CPU models for Intel x86 hosts" ?

2025-03-11 Thread Daniel P . Berrangé
On Tue, Mar 11, 2025 at 10:47:09AM -0600, Chris Friesen via wrote: > Hi, > > I was looking at the website and noticed that the various Sapphire Rapids > variants were missing from the list of "Preferred CPU models for Intel x86 > hosts" located at > > https://qemu-project.gitlab.io/qemu/system/qe

[PATCH 2/4] 9pfs: Don't use file descriptors in core code

2025-03-11 Thread Greg Kurz
v9fs_getattr() currently peeks into V9fsFidOpenState to know if a fid has a valid file descriptor or directory stream. Even though the fields are accessible, this is an implementation detail of the local backend that should not be manipulated directly by the server code. Abstract that with a new h

Re: [PATCH qemu v2 1/3] hw/s390x: add CPI identifiers to QOM

2025-03-11 Thread Shalini Chellathurai Saroja
On 2025-03-06 17:05, Daniel P. Berrangé wrote: On Thu, Mar 06, 2025 at 04:44:33PM +0100, Nina Schoetterl-Glausch wrote: On Thu, 2025-03-06 at 15:55 +0100, Thomas Huth wrote: > On 06/03/2025 13.23, shalini wrote: > > On 2025-03-05 16:56, Thomas Huth wrote: > > > On 24/02/2025 13.04, Shalini Chell

Re: [PATCH 05/16] qemu/bswap: implement {ld,st}.*_p as functions

2025-03-11 Thread Pierrick Bouvier
On 3/10/25 09:08, Richard Henderson wrote: On 3/9/25 21:58, Pierrick Bouvier wrote: For now, they are duplicate of the same macros in cpu-all.h that we eliminate in next commit. Keep code readable by not defining them with macros, but simply their implementation. Signed-off-by: Pierrick Bouvie

Re: [PATCH] gitlab-ci: include full Rust backtraces in test runs

2025-03-11 Thread Peter Maydell
On Mon, 10 Mar 2025 at 09:25, Daniel P. Berrangé wrote: > > On Mon, Mar 10, 2025 at 09:21:37AM +, Peter Maydell wrote: > > On Wed, 29 Jan 2025 at 08:21, Paolo Bonzini wrote: > > > > > > Signed-off-by: Paolo Bonzini > > > --- > > > .gitlab-ci.d/buildtest-template.yml | 1 + > > > 1 file chan

[PATCH 14/16] system/physmem: compilation unit is now common to all targets

2025-03-11 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- system/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/meson.build b/system/meson.build index c83d80fa248..9d0b0122e54 100644 --- a/system/meson.build +++ b/system/meson.build @@ -2,7 +2,6 @@ specific_ss.add(when: 'CONFIG_

Re: [PATCH 5/5] aio-posix: Separate AioPolledEvent per AioHandler

2025-03-11 Thread Stefan Hajnoczi
On Fri, Mar 07, 2025 at 11:16:34PM +0100, Kevin Wolf wrote: > Adaptive polling has a big problem: It doesn't consider that an event > loop can wait for many different events that may have very different > typical latencies. > > For example, think of a guest that tends to send a new I/O request soo

[qemu-riscv] Error mapping file: Invalid argument

2025-03-11 Thread Chu, Benson
Hello all, I am working on a linker for the RISC-V target, and I was trying to use qemu-riscv32 to test my linker. However, I have noticed that qemu-riscv32 has some restrictions about how the program can be laid out in memory, and getting my linker to place the program in a way that qemu-risc

[PATCH v3 44/63] docs/qapidoc: add visit_paragraph() method

2025-03-11 Thread John Snow
This transforms "formerly known as untagged sections" into our pure intermediate rST format. These sections are already pure rST, so this method doesn't do a whole lot except ensure appropriate newlines. Signed-off-by: John Snow --- docs/sphinx/qapidoc.py | 9 + 1 file changed, 9 inserti

[PULL 06/10] qdev: Rename PropertyInfo member @name to @type

2025-03-11 Thread Markus Armbruster
PropertyInfo member @name becomes ObjectProperty member @type, while Property member @name becomes ObjectProperty member @name. Rename the former. Signed-off-by: Markus Armbruster Message-ID: <20250227085601.4140852-4-arm...@redhat.com> Reviewed-by: Daniel P. Berrangé [One missed instance of @t

Re: [PATCH v5 8/8] ppc/pnv: Update skiboot to support Power11

2025-03-11 Thread Cédric Le Goater
On 3/10/25 11:31, Aditya Gupta wrote: On 09/03/25 19:40, Cédric Le Goater wrote: On 3/8/25 21:51, Aditya Gupta wrote: Update skiboot.lid to below commit which adds support for booting on Power11: commit 785a5e3070a8 ("platform: Identify correct bmc platform based on bmc hw version") Bu

[PATCH v5 22/29] hw/arm/aspeed_ast27x0: Add SoC Support for AST2700 A1

2025-03-11 Thread Jamin Lin via
The memory map for AST2700 A1 remains compatible with AST2700 A0. However, the IRQ mapping has been updated for AST2700 A1, with GIC interrupts now ranging from 192 to 201. Add a new IRQ map table for AST2700 A1. Add "aspeed_soc_ast2700a1_class_init" to initialize the AST2700 A1 SoC. Signed-off-by

Re: [PATCH 0/3] vhost: fix the IO error after live migration

2025-03-11 Thread Lei Yang
QE tested this series of patches with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Sun, Mar 9, 2025 at 5:09 PM Haoqian He wrote: > > At the end of the VM live migration, the vhost device will be stopped. > Currently, if the vhost-user backend crash, vhost device's

Re: [PATCH 12/14] hw/vfio/ap: Check CONFIG_IOMMUFD at runtime using iommufd_builtin()

2025-03-11 Thread Richard Henderson
On 3/7/25 10:03, Philippe Mathieu-Daudé wrote: Convert the compile time check on the CONFIG_IOMMUFD definition by a runtime one by calling iommufd_builtin(). Since the file doesn't use any target-specific knowledge anymore, move it to system_ss[] to build it once. Signed-off-by: Philippe Mathie

Re: [PULL 8/8] migration: Add qtest for migration over RDMA

2025-03-11 Thread Fabiano Rosas
"Zhijian Li (Fujitsu)" via writes: > Hi Philippe, > > Thanks for your testing. > > > On 08/03/2025 14:00, Philippe Mathieu-Daudé wrote: >> Hi, >> >> On 7/3/25 19:15, Fabiano Rosas wrote: >>> From: Li Zhijian >>> >>> This qtest requires there is a RDMA(RoCE) link in the host. >>> In order to mak

Re: [PATCH 05/16] qemu/bswap: implement {ld,st}.*_p as functions

2025-03-11 Thread Pierrick Bouvier
On 3/10/25 09:53, Richard Henderson wrote: On 3/10/25 09:43, Pierrick Bouvier wrote: On 3/10/25 09:37, Richard Henderson wrote: On 3/10/25 09:14, Pierrick Bouvier wrote: On 3/10/25 09:08, Richard Henderson wrote: On 3/9/25 21:58, Pierrick Bouvier wrote: For now, they are duplicate of the sam

[PULL 33/72] pnv/xive2: Rename nvp_ to nvx_ if they can refer to NVP or NVGC

2025-03-11 Thread Nicholas Piggin
From: Glenn Miles The blk/index in some paths may refer to an NVP or an NVGC. When it is not known ahead of time, use the nvx_ prefix to prevent confusion. [npiggin: split out of larger fix patch and reworded] Signed-off-by: Glenn Miles Reviewed-by: Nicholas Piggin Signed-off-by: Nicholas Pigg

CXL memory pooling emulation inqury

2025-03-11 Thread Junjie Fu
> Note though that there is a long way to go before we can do what you > want. The steps I'd expect to see along the way: > > 1) Emulate an Multi Headed Device. >Initially connect two heads to different host bridges on a single QEMU >machine. That lets us test most of the code flows witho

Re: [PATCH 1/4] 9pfs: local : Introduce local_fid_fd() helper

2025-03-11 Thread Greg Kurz
On Tue, 11 Mar 2025 11:58:28 +0100 Christian Schoenebeck wrote: > On Monday, March 10, 2025 6:10:58 PM CET Greg Kurz wrote: > > Factor out duplicated code to a single helper. More users to come. > > > > Signed-off-by: Greg Kurz > > --- > > hw/9pfs/9p-local.c | 21 +++-- > > 1 f

Re: [PATCH 01/16] exec/memory_ldst: extract memory_ldst declarations from cpu-all.h

2025-03-11 Thread Richard Henderson
On 3/10/25 17:04, Pierrick Bouvier wrote: From what I understand, non endian versions are simply passing DEVICE_NATIVE_ENDIAN as a parameter for address_space_ldl_internal, which will thus match the target endianness. So what is the risk for common code to call this? You're right. I failed

Re: [PATCH V1 0/4] skip memory init during CPR

2025-03-11 Thread Fabiano Rosas
Steve Sistare writes: > Fix bugs where the realize method re-initializes some memory regions during > CPR. See the individual commit messages for details. > > Steve Sistare (4): > migration: cpr_is_incoming > pflash: fix cpr > hw/loader: fix roms during cpr > hw/qxl: fix cpr > > hw/bloc

Re: [PATCH 12/12] virtio-scsi: handle ctrl virtqueue in main loop

2025-03-11 Thread Kevin Wolf
Am 13.02.2025 um 19:00 hat Stefan Hajnoczi geschrieben: > Previously the ctrl virtqueue was handled in the AioContext where SCSI > requests are processed. When IOThread Virtqueue Mapping was added things > become more complicated because SCSI requests could run in other > AioContexts. > > Simplify

Re: [PULL 05/10] Add Hyper-V Dynamic Memory Protocol driver (hv-balloon) base

2025-03-11 Thread Philippe Mathieu-Daudé
Hi Maciej, On 6/11/23 15:20, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" This driver is like virtio-balloon on steroids: it allows both changing the guest memory allocation via ballooning and (in the next patch) inserting pieces of extra RAM into it on demand from a provided memory

[PATCH 04/16] mcd: Implement server connection API

2025-03-11 Thread Mario Fleischmann
This commit implements the necessary operations required to establish a connection with the MCD server: * query information about the server * connect to " * disconnect from " Signed-off-by: Mario Fleischmann --- mcd/libmcd_qapi.c | 13 +++ mcd/libmcd_qapi.h | 2 + mcd/mcdser

Re: [PATCH for-10.1] tests/functional: Convert the SMMU test to the functional framework

2025-03-11 Thread Eric Auger
Hi Thomas, On 3/11/25 11:49 AM, Thomas Huth wrote: > This test was using cloudinit and a "dnf install" command in the guest > to exercise the NIC with SMMU enabled. Since we don't have the cloudinit > stuff in the functional framework and we should not rely on having access > to external networks

[PULL 55/72] hw/ppc/spapr: Convert HPTE_VALID() macro as hpte_is_valid() method

2025-03-11 Thread Nicholas Piggin
From: Philippe Mathieu-Daudé Convert HPTE_VALID() macro as hpte_is_valid() method. sPAPR data structures including the hash page table are big-endian regardless of current CPU endian mode, so use the big-endian LD/ST API to access the hash PTEs. Signed-off-by: Philippe Mathieu-Daudé Reviewed-b

[PATCH v2 13/13] virtio-scsi: only expose cmd vqs via iothread-vq-mapping

2025-03-11 Thread Stefan Hajnoczi
Peter Krempa and Kevin Wolf observed that iothread-vq-mapping is confusing to use because the control and event virtqueues have a fixed location before the command virtqueues but need to be treated differently. Only expose the command virtqueues via iothread-vq-mapping so that the command-line par

[PULL 72/72] docs/system/ppc/amigang.rst: Update for NVRAM emulation

2025-03-11 Thread Nicholas Piggin
From: BALATON Zoltan Add NVRAM and hint on how to make it persistent. Also update Linux boot section which should now boot automatically with the new NVRAM defaults so manual settings in menu may not be needed normally. Signed-off-by: BALATON Zoltan Reviewed-by: Nicholas Piggin Message-ID: <20

[PULL 30/72] qtest/xive: Add group-interrupt test

2025-03-11 Thread Nicholas Piggin
From: Frederic Barrat Add XIVE2 tests for group interrupts and group interrupts that have been backlogged. Signed-off-by: Frederic Barrat Signed-off-by: Michael Kowal Reviewed-by: Nicholas Piggin Signed-off-by: Nicholas Piggin --- tests/qtest/pnv-xive2-test.c | 160 +

[PULL 54/72] hw/ppc/spapr: Convert HPTE() macro as hpte_get_ptr() method

2025-03-11 Thread Nicholas Piggin
From: Philippe Mathieu-Daudé Convert HPTE() macro as hpte_get_ptr() method. Reviewed-by: Nicholas Piggin Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Harsh Prateek Bora Message-ID: <20241220213103.6314-2-phi...@linaro.org> Signed-off-by: Nicholas Piggin --- hw/ppc/spapr.c | 38 +++

[PATCH v3 03/14] scsi: track per-SCSIRequest AioContext

2025-03-11 Thread Stefan Hajnoczi
Until now, a SCSIDevice's I/O requests have run in a single AioContext. In order to support multiple IOThreads it will be necessary to move to the concept of a per-SCSIRequest AioContext. Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf --- include/hw/scsi/scsi.h | 1 + hw/scsi/scsi-bus.

[PULL 62/72] spapr: nested: Add support for reporting Hostwide state counter

2025-03-11 Thread Nicholas Piggin
From: Vaibhav Jain Add support for reporting Hostwide state counters for nested KVM pseries guests running with 'cap-nested-papr' on Qemu-TCG acting as L0-hypervisor. The Hostwide state counters are statistics about state that L0-hypervisor maintains for the L2-guests and represent the state of a

Re: [PATCH 1/2] vfio/migration: Add also max in-flight VFIO device state buffers size limit

2025-03-11 Thread Avihai Horon
On 11/03/2025 15:04, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 3/7/25 14:45, Maciej S. Szmigiero wrote: On 7.03.2025 13:03, Cédric Le Goater wrote: On 3/7/25 11:57, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" There's already a max in-f

[PATCH v3 08/14] virtio-blk: extract cleanup_iothread_vq_mapping() function

2025-03-11 Thread Stefan Hajnoczi
This is the cleanup function that must be called after apply_iothread_vq_mapping() succeeds. virtio-scsi will need this function too, so extract it. Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf --- hw/block/virtio-blk.c | 27 +-- 1 file changed, 21 insertions(+

[PULL 07/22] aio-posix: Separate AioPolledEvent per AioHandler

2025-03-11 Thread Kevin Wolf
Adaptive polling has a big problem: It doesn't consider that an event loop can wait for many different events that may have very different typical latencies. For example, think of a guest that tends to send a new I/O request soon after the previous I/O request completes, but the storage on the hos

[PULL 03/22] file-posix: Support FUA writes

2025-03-11 Thread Kevin Wolf
Until now, FUA was always emulated with a separate flush after the write for file-posix. The overhead of processing a second request can reduce performance significantly for a guest disk that has disabled the write cache, especially if the host disk is already write through, too, and the flush isn'

[PULL 16/22] virtio-scsi: perform TMFs in appropriate AioContexts

2025-03-11 Thread Kevin Wolf
From: Stefan Hajnoczi With IOThread Virtqueue Mapping there will be multiple AioContexts processing SCSI requests. scsi_req_cancel() and other SCSI request operations must be performed from the AioContext where the request is running. Introduce a virtio_scsi_defer_tmf_to_aio_context() function a

[PATCH for-10.1 09/10] ui/vdagent: add migration support

2025-03-11 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/vdagent.c | 139 +++ 1 file changed, 139 insertions(+) diff --git a/ui/vdagent.c b/ui/vdagent.c index 125c659af7..cc5738a6ea 100644 --- a/ui/vdagent.c +++ b/ui/vdagent.c @@ -10,6 +10

[PULL 14/22] virtio-scsi: introduce event and ctrl virtqueue locks

2025-03-11 Thread Kevin Wolf
From: Stefan Hajnoczi Virtqueues are not thread-safe. Until now this was not a major issue since all virtqueue processing happened in the same thread. The ctrl queue's Task Management Function (TMF) requests sometimes need the main loop, so a BH was used to schedule the virtqueue completion back

[PULL 02/22] block: Zero block driver state before reopening

2025-03-11 Thread Kevin Wolf
Block drivers assume in their .bdrv_open() implementation that their state in bs->opaque has been zeroed; it is initially allocated with g_malloc0() in bdrv_open_driver(). bdrv_snapshot_goto() needs to make sure that it is zeroed again before calling drv->bdrv_open() to avoid that block drivers us

[PATCH for-10.1 06/10] ui/vdagent: replace Buffer with GByteArray

2025-03-11 Thread marcandre . lureau
From: Marc-André Lureau Buffer is slightly more advanced than GByteArray, since it has a cursor/position. But vdagent code doesn't need it. This simplify a bit the code, and migration state. Signed-off-by: Marc-André Lureau --- ui/vdagent.c | 25 - 1 file changed, 12 in

[PULL 13/22] scsi: introduce requests_lock

2025-03-11 Thread Kevin Wolf
From: Stefan Hajnoczi SCSIDevice keeps track of in-flight requests for device reset and Task Management Functions (TMFs). The request list requires protection so that multi-threaded SCSI emulation can be implemented in commits that follow. Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf

[PATCH for-10.1 05/10] ui/clipboard: delay clipboard update when not running

2025-03-11 Thread marcandre . lureau
From: Marc-André Lureau When VM is paused, we shouldn't notify of clipboard changes, similar to how input are being treated. On unsuspend, notify of the current state. Signed-off-by: Marc-André Lureau --- ui/clipboard.c | 40 ++-- 1 file changed, 38 inserti

[PULL 21/22] virtio-scsi: handle ctrl virtqueue in main loop

2025-03-11 Thread Kevin Wolf
From: Stefan Hajnoczi Previously the ctrl virtqueue was handled in the AioContext where SCSI requests are processed. When IOThread Virtqueue Mapping was added things become more complicated because SCSI requests could run in other AioContexts. Simplify by handling the ctrl virtqueue in the main

[PATCH for-10.1 07/10] ui/vdagent: keep "connected" state

2025-03-11 Thread marcandre . lureau
From: Marc-André Lureau During post-load of migration, virtio will notify of fe_open state. However vdagent code will handle this as a reconnection. This will trigger a connection reset/caps with the agent. Check if the state actually changed before resetting the connection. Signed-off-by: Marc

[PULL 19/22] virtio: extract iothread-vq-mapping.h API

2025-03-11 Thread Kevin Wolf
From: Stefan Hajnoczi The code that builds an array of AioContext pointers indexed by the virtqueue is not specific to virtio-blk. virtio-scsi will need to do the same thing, so extract the functions. Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf Message-ID: <20250311132616.1049687-11

[PULL 15/22] virtio-scsi: protect events_dropped field

2025-03-11 Thread Kevin Wolf
From: Stefan Hajnoczi The block layer can invoke the resize callback from any AioContext that is processing requests. The virtqueue is already protected but the events_dropped field also needs to be protected against races. Cover it using the event virtqueue lock because it is closely associated

[PATCH for-10.1 08/10] ui/vdagent: factor out clipboard peer registration

2025-03-11 Thread marcandre . lureau
From: Marc-André Lureau This allows common code reuse during migration. Note that resetting the serial is now done regardless if the clipboard peer was registered or not. This should still be correct. Signed-off-by: Marc-André Lureau --- ui/vdagent.c | 20 ++-- 1 file changed,

[PULL 17/22] virtio-blk: extract cleanup_iothread_vq_mapping() function

2025-03-11 Thread Kevin Wolf
From: Stefan Hajnoczi This is the cleanup function that must be called after apply_iothread_vq_mapping() succeeds. virtio-scsi will need this function too, so extract it. Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf Message-ID: <20250311132616.1049687-9-stefa...@redhat.com> Signed-of

[PATCH for-10.1 10/10] ui/vdagent: remove migration blocker

2025-03-11 Thread marcandre . lureau
From: Marc-André Lureau Fixes: https://issues.redhat.com/browse/RHEL-81894 Signed-off-by: Marc-André Lureau --- ui/vdagent.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/ui/vdagent.c b/ui/vdagent.c index cc5738a6ea..3b27ba25fb 100644 --- a/ui/vdagent.c +++ b/ui/vdagent.c @@ -

[PULL 12/22] scsi: track per-SCSIRequest AioContext

2025-03-11 Thread Kevin Wolf
From: Stefan Hajnoczi Until now, a SCSIDevice's I/O requests have run in a single AioContext. In order to support multiple IOThreads it will be necessary to move to the concept of a per-SCSIRequest AioContext. Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf Message-ID: <20250311132616.1

[PATCH 3/6] amd_iommu: Update bitmasks representing DTE reserved fields

2025-03-11 Thread Alejandro Jimenez
The DTE validation method verifies that all bits in reserved DTE fields are unset. Update them according to the latest definition available in AMD I/O Virtualization Technology (IOMMU) Specification - Section 2.2.2.1 Device Table Entry Format. Remove the magic numbers and use a macro helper to gene

[PULL 11/22] dma: use current AioContext for dma_blk_io()

2025-03-11 Thread Kevin Wolf
From: Stefan Hajnoczi In the past a single AioContext was used for block I/O and it was fetched using blk_get_aio_context(). Nowadays the block layer supports running I/O from any AioContext and multiple AioContexts at the same time. Remove the dma_blk_io() AioContext argument and use the current

Re: [PATCH v2 18/18] hw/rtc: Add Ricoh RS5C372 RTC emulation

2025-03-11 Thread Philippe Mathieu-Daudé
On 11/3/25 16:49, Corey Minyard wrote: On Tue, Mar 11, 2025 at 10:20:03AM +0100, Philippe Mathieu-Daudé wrote: On 11/3/25 08:34, Bernhard Beschow wrote: Am 7. März 2025 19:18:34 UTC schrieb Bernhard Beschow : Am 4. März 2025 18:53:10 UTC schrieb Bernhard Beschow : Am 23. Februar 2025 11

Re: [PATCH for-10.1 00/10] Support vdagent migration

2025-03-11 Thread Daniel P . Berrangé
On Tue, Mar 11, 2025 at 07:59:22PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > > iQJQBAABCAA6FiEEh6m9kz+HxgbSdvYt2ujhCXWWnOUFAmfQXbMcHG1hcmNhbmRy > ZS5sdXJlYXVAcmVkaGF0LmNvbQAKCRDa6OEJdZac5bmLD/49TJdk8vSnG/G53f3Z > UdUGdDiv98lAr/1wPZvmLPGfxiVLrVQK9Rarjnq9+dzmjoJC+w8TH

[PULL 20/22] virtio-scsi: add iothread-vq-mapping parameter

2025-03-11 Thread Kevin Wolf
From: Stefan Hajnoczi Allow virtio-scsi virtqueues to be assigned to different IOThreads. This makes it possible to take advantage of host multi-queue block layer scalability by assigning virtqueues that have affinity with vCPUs to different IOThreads that have affinity with host CPUs. The same f

[PULL 18/22] virtio-blk: tidy up iothread_vq_mapping functions

2025-03-11 Thread Kevin Wolf
From: Stefan Hajnoczi Use noun_verb() function naming instead of verb_noun() because the former is the most common naming style for APIs. The next commit will move these functions into a header file so that virtio-scsi can call them. Shorten iothread_vq_mapping_apply()'s iothread_vq_mapping_list

Re: [PATCH 1/2] vfio/migration: Add also max in-flight VFIO device state buffers size limit

2025-03-11 Thread Cédric Le Goater
On 3/11/25 17:01, Avihai Horon wrote: On 11/03/2025 17:45, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 3/11/25 15:57, Avihai Horon wrote: On 11/03/2025 15:04, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 3/7/2

Re: [PATCH 1/2] vfio/migration: Add also max in-flight VFIO device state buffers size limit

2025-03-11 Thread Avihai Horon
On 11/03/2025 17:45, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 3/11/25 15:57, Avihai Horon wrote: On 11/03/2025 15:04, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 3/7/25 14:45, Maciej S. Szmigiero wrote: O

[PATCH] docs/system: Fix the information on how to run certain functional tests

2025-03-11 Thread Thomas Huth
The tests have been converted to the functional framework, so we should not talk about Avocado here anymore. Fixes: f7d6b772200 ("tests/functional: Convert BananaPi tests to the functional framework") Fixes: 380f7268b7b ("tests/functional: Convert the OrangePi tests to the functional framework")

[PULL 22/22] virtio-scsi: only expose cmd vqs via iothread-vq-mapping

2025-03-11 Thread Kevin Wolf
From: Stefan Hajnoczi Peter Krempa and Kevin Wolf observed that iothread-vq-mapping is confusing to use because the control and event virtqueues have a fixed location before the command virtqueues but need to be treated differently. Only expose the command virtqueues via iothread-vq-mapping so t

Re: [PULL 05/10] Add Hyper-V Dynamic Memory Protocol driver (hv-balloon) base

2025-03-11 Thread Philippe Mathieu-Daudé
On 11/3/25 16:11, Maciej S. Szmigiero wrote: On 11.03.2025 16:00, Philippe Mathieu-Daudé wrote: Hi Maciej, On 6/11/23 15:20, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" This driver is like virtio-balloon on steroids: it allows both changing the guest memory allocation via balloo

[PULL 10/22] scsi-disk: drop unused SCSIDiskState->bh field

2025-03-11 Thread Kevin Wolf
From: Stefan Hajnoczi Commit 71544d30a6f8 ("scsi: push request restart to SCSIDevice") removed the only user of SCSIDiskState->bh. Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Kevin Wolf Message-ID: <20250311132616.1049687-2-stefa...@redhat.com> Signed-off-b

[PULL 11/72] ppc/pnv/occ: Better document OCCMISC bits

2025-03-11 Thread Nicholas Piggin
Use defines for the OCCMISC register bits, and add a comment about the IRQ request bit, which QEMU may not model quite correctly. Signed-off-by: Nicholas Piggin --- hw/ppc/pnv_occ.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/ppc/pnv_occ.c b/hw/ppc/pnv_o

[PULL 06/22] aio-posix: Factor out adjust_polling_time()

2025-03-11 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Message-ID: <20250307221634.71951-5-kw...@redhat.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- util/aio-posix.c | 77 ++-- 1 file changed, 41 insertions(+), 36 deletions(-) diff --git a/util/aio-posix.c b/u

Re: [RFC PATCH 01/11] system: Extract target-specific globals to their own compilation unit

2025-03-11 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > We shouldn't use target specific globals for machine properties. > These ones could be desugarized, as explained in [*]. While > certainly doable, not trivial nor my priority for now. Just move > them to a different file to clarify they are *globals*, like the > g

[PULL 44/61] docs/qapidoc: add add_field() and generate_field() helper methods

2025-03-11 Thread Markus Armbruster
From: John Snow These are simple rST generation methods that assist in getting the types and formatting correct for a field list entry. add_field() is a more raw, direct call while generate_field() is intended to be used for generating the correct field from a member object. Signed-off-by: John

[PULL 63/72] target/ppc: fix timebase register reset state

2025-03-11 Thread Nicholas Piggin
(H)DEC and PURR get reset before icount does, which causes them to be skewed and not match the init state. This can cause replay to not match the recorded trace exactly. For DEC and HDEC this is usually not noticable since they tend to get programmed before affecting the target machine. PURR has be

[PATCH v2] docs: Explain how to use passt

2025-03-11 Thread Laurent Vivier
Add a chapter to explain how to use passt(1) instead of '-net user'. passt(1) can be connected to QEMU using UNIX socket or vhost-user. With vhost-user, migration of the VM is allowed and internal state of passt(1) is transfered from one side to the other Bug: https://gitlab.com/qemu-project/qemu/

[PATCH v4 13/13] virtio-scsi: only expose cmd vqs via iothread-vq-mapping

2025-03-11 Thread Stefan Hajnoczi
Peter Krempa and Kevin Wolf observed that iothread-vq-mapping is confusing to use because the control and event virtqueues have a fixed location before the command virtqueues but need to be treated differently. Only expose the command virtqueues via iothread-vq-mapping so that the command-line par

[PATCH v4 07/13] virtio-scsi: perform TMFs in appropriate AioContexts

2025-03-11 Thread Stefan Hajnoczi
With IOThread Virtqueue Mapping there will be multiple AioContexts processing SCSI requests. scsi_req_cancel() and other SCSI request operations must be performed from the AioContext where the request is running. Introduce a virtio_scsi_defer_tmf_to_aio_context() function and the necessary VirtIOS

[RFC PATCH v2 09/20] hw/arm/smmuv3-accel: Add set/unset_iommu_device callback

2025-03-11 Thread Shameer Kolothum via
From: Nicolin Chen Implement a set_iommu_device callback: -Find an existing S2 hwpt to test attach() or allocate a new one (Devices behind the same physical SMMU should share an S2 HWPT.) -Attach the device to the S2 hwp -Allocate a viommu with the returned s2 hwpt. -Allocate bypass and ab

[RFC PATCH v2 10/20] hw/arm/smmuv3-accel: Support nested STE install/uninstall support

2025-03-11 Thread Shameer Kolothum via
From: Nicolin Chen Allocates a s1 HWPT for the Guest s1 stage and attaches that to the dev. This will be invoked in a subsequent patch when Guest issues SMMU_CMD_CFGI_STE. While at it, we are also exporting both smmu_find_ste() and smmuv3_flush_config() from smmuv3.c for use here. Signed-off-by

<    1   2   3   4   5   6   7   8   >