Re: [PATCH-for-10.0 3/3] hw/boards: Rename no_sdcard -> create_default_sdcard_drive

2025-02-04 Thread Philippe Mathieu-Daudé
On 4/2/25 08:07, Thomas Huth wrote: On 25/11/2024 19.14, Philippe Mathieu-Daudé wrote: Invert the 'no_sdcard' logic, renaming it as the more explicit "create_default_sdcard_drive". Machines are supposed to create a SD Card drive when this flag is set. In many cases it doesn't make much sense (as

Re: [PATCH v2 11/12] hw/arm/raspi: Deprecate old raspiX machine names

2025-02-04 Thread Peter Maydell
On Tue, 4 Feb 2025 at 09:57, Daniel P. Berrangé wrote: > > On Tue, Feb 04, 2025 at 10:51:04AM +0100, Philippe Mathieu-Daudé wrote: > > On 4/2/25 10:22, Peter Maydell wrote: > > > On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé > > > wrote: > > > > > > > > All previous raspi machines can be c

Re: [PATCH 1/1] Added support for get/set alert configuration commands

2025-02-04 Thread Jonathan Cameron via
On Mon, 3 Feb 2025 17:14:45 +0530 Sweta Kumari wrote: > Signed-off-by: Sweta Kumari > Reviewed-by: Alok Rathore > Reviewed-by: Krishna Kanth Reddy Hi Sweta, Thanks for the patch. Great to see someone working on these features. As in previous thread, in general RB tags that are given before

[PATCH] MAINTAINER: Add a maintainer for CPR

2025-02-04 Thread Cédric Le Goater
The CPR feature was added in QEMU 9.0 and it lacks a maintainer. Propose the main contributor to become one. Cc: Steve Sistare Signed-off-by: Cédric Le Goater --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index db8c41fbe0f9..efb9da02f142

Re: [PATCH v2] hw/virtio: reset virtio balloon stats on machine reset

2025-02-04 Thread David Hildenbrand
On 04.02.25 10:42, Daniel P. Berrangé wrote: When a machine is first booted, all virtio balloon stats are initialized to their default value -1 (18446744073709551615 when represented as unsigned). They remain that way while the firmware is loading, and early phase of guest OS boot, until the vir

Re: [PATCH v1 01/18] hw/intc/aspeed: Rename INTC to INTC0

2025-02-04 Thread Cédric Le Goater
On 2/4/25 09:22, Jamin Lin wrote: Hi Cedric, From: Cédric Le Goater Sent: Tuesday, February 4, 2025 3:35 PM To: Jamin Lin ; Andrew Jeffery ; Peter Maydell ; Steven Lee ; Troy Lee ; Joel Stanley ; open list:ASPEED BMCs ; open list:All patches CC here Cc: Troy Lee ; Yunlin Tang Subject: Re: [P

Re: [PATCH 1/3] hw/cxl/cxl-mailbox-utils.c: Added support for Get Log Capabilities (Opcode 0402h)

2025-02-04 Thread Jonathan Cameron via
On Mon, 3 Feb 2025 11:29:48 +0530 Arpit Kumar wrote: Please add some descriptive teext here. > Signed-off-by: Arpit Kumar > Reviewed-by: Alok Rathore > Reviewed-by: Krishna Kanth Reddy Hi Arpit, Whilst it is good to do internal reviews, I'd prefer to see feedback on the mailing list if pos

Re: [PATCH 1/8] hw/arm/exynos4210: Replace magic 32 by proper 'GIC_INTERNAL' definition

2025-02-04 Thread Peter Maydell
On Thu, 30 Jan 2025 at 18:25, Philippe Mathieu-Daudé wrote: > > The 32 IRQ lines skipped are the GIC internal ones. > Use the GIC_INTERNAL definition for clarity. > No logical change. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/exynos4210.c | 6 -- > 1 file changed, 4 insertions

Re: [PATCH V1 07/26] vfio/container: recover from unmap-all-vaddr failure

2025-02-04 Thread Cédric Le Goater
On 1/29/25 15:43, Steve Sistare wrote: If there are multiple containers and unmap-all fails for some container, we need to remap vaddr for the other containers for which unmap-all succeeded. Recover by walking all address ranges of all containers to restore the vaddr for each. Do so by invoking

Re: [PATCH] MAINTAINER: Add a maintainer for CPR

2025-02-04 Thread Steven Sistare
On 2/4/2025 8:42 AM, Cédric Le Goater wrote: On 2/4/25 14:31, Steven Sistare wrote: Hi Cedric, CPR is a mode of live migration, integrated so closely that it makes more sense for the migration maintainers to maintain it, and consult me if/when necessary.  "migration" appears in 4 of the 5 paths

Re: [PATCH 8/8] hw/cpu/arm_mpcore: Remove default values for GIC external IRQs

2025-02-04 Thread Peter Maydell
On Thu, 30 Jan 2025 at 18:27, Philippe Mathieu-Daudé wrote: > > Implicit default values are often hard to figure out, better > be explicit. Now that all boards explicitly set the number of > GIC external IRQs, remove the default values (displaying an > error message if it is not set). > diff --gi

Re: [PATCH v7 3/3] hw/acpi: Add vmclock device

2025-02-04 Thread David Woodhouse
On Tue, 2025-02-04 at 13:49 +, Peter Maydell wrote: > On Thu, 16 Jan 2025 at 14:05, David Woodhouse > wrote: > > > > From: David Woodhouse > > > > The vmclock device addresses the problem of live migration with > > precision clocks. The tolerances of a hardware counter (e.g. TSC) > > are >

<    1   2   3   4