Re: [PATCH 08/20] accel/tcg: Restrict tlb_init() / destroy() to TCG

On 1/23/25 15:44, Philippe Mathieu-Daudé wrote: Move CPU TLB related methods to accel/tcg/ scope, in "internal-common.h". Suggested-by: Richard Henderson Reviewed-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/internal-common.h | 11 +++ include/exec/exec-all

Re: [PATCH 09/20] accel/tcg: Restrict 'icount_align_option' global to TCG

On 1/23/25 15:44, Philippe Mathieu-Daudé wrote: Since commit 740b1759734 ("cpu-timers, icount: new modules") we don't need to expose icount_align_option to all the system code, we can restrict it to TCG. Since it is used as a boolean, declare it as 'bool' type. Signed-off-by: Philippe Mathieu-Da

Re: [PATCH 10/20] accel/tcg: Rename 'hw/core/tcg-cpu-ops.h' -> 'accel/tcg/cpu-ops.h'

On 1/26/25 12:36, Richard Henderson wrote: On 1/23/25 15:44, Philippe Mathieu-Daudé wrote: TCGCPUOps structure makes more sense in the accelerator context rather than hardware emulation. Move it under the accel/tcg/ scope. Mechanical change doing:   $  sed -i -e 's,hw/core/tcg-cpu-ops.h,accel/

Re: [PATCH 11/20] accel: Rename 'hw/core/accel-cpu.h' -> 'accel/accel-cpu-target.h'

On 1/23/25 15:44, Philippe Mathieu-Daudé wrote: AccelCPUClass is for accelerator to initialize target specific features of a vCPU. Not really related to hardware emulation, rename "hw/core/accel-cpu.h" as "accel/accel-cpu-target.h" (using the explicit -target suffix). More importantly, target sp

Re: [PATCH 12/20] accel/accel-cpu-target.h: Include missing 'cpu.h' header

On 1/23/25 15:44, Philippe Mathieu-Daudé wrote: CPU_RESOLVING_TYPE is declared per target in "cpu.h". Include it (along with "qom/object.h") to avoid when moving code around: include/accel/accel-cpu-target.h:26:50: error: expected ')' 26 | DECLARE_CLASS_CHECKERS(AccelCPUClass, ACCEL_CPU

<    1   2