Re: [PULL 00/48] virtio,pc,pci: features, fixes, cleanups

2025-01-16 Thread David Woodhouse
On Thu, 2025-01-16 at 02:05 -0500, Michael S. Tsirkin wrote: > > Yes pls do. You can add: > > Acked-by: Michael S. Tsirkin > > but, I noticed checkpatch warnings: > > 3634039b93cc51816263e0cb5ba32e1b61142d5d:89: WARNING: added, moved or > deleted file(s), does MAINTAINERS need updating? > 3634

Re: [PATCH v7 2/3] linux-headers: Update to Linux 6.13-rc7

2025-01-16 Thread Paul Durrant
On 16/01/2025 14:59, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- include/standard-headers/linux/vmclock-abi.h | 182 +++ linux-headers/linux/iommufd.h| 31 ++-- linux-headers/linux/stddef.h | 13 +- 3 fi

[PATCH v7 3/3] hw/acpi: Add vmclock device

2025-01-16 Thread David Woodhouse
From: David Woodhouse The vmclock device addresses the problem of live migration with precision clocks. The tolerances of a hardware counter (e.g. TSC) are typically around ±50PPM. A guest will use NTP/PTP/PPS to discipline that counter against an external source of 'real' time, and track the pre

Re: [PATCH v7 2/3] linux-headers: Update to Linux 6.13-rc7

2025-01-16 Thread David Woodhouse
On Thu, 2025-01-16 at 15:07 +0100, Paul Durrant wrote: > On 16/01/2025 14:59, David Woodhouse wrote: > > From: David Woodhouse > > > > Signed-off-by: David Woodhouse > > --- > >   include/standard-headers/linux/vmclock-abi.h | 182 +++ > >   linux-headers/linux/iommufd.h  

Re: [PATCH 1/3] pc-bios/s390-ccw/virtio: Add a function to reset a virtio device

2025-01-16 Thread Jared Rossi
Reviewed-by: Jared Rossi On 1/16/25 6:58 AM, Thomas Huth wrote: To be able to properly silence a virtio device after using it, we need a global function to reset the device. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/virtio.h | 1 + pc-bios/s390-ccw/virtio.c | 7 ++- 2 files chan

Re: [PATCH v2 0/2] block: Fix leak in send_qmp_error_event

2025-01-16 Thread Kevin Wolf
Am 11.11.2024 um 18:03 hat Philippe Mathieu-Daudé geschrieben: > Respin of Fabiano patch using g_autofree, > and clarifying method docstrings. > > Fabiano Rosas (1): > block: Fix leak in send_qmp_error_event > > Philippe Mathieu-Daudé (1): > block: Improve blk_get_attached_dev_id() docstring

Re: [PATCH v2] hw/riscv/virt: Add serial alias in DTB

2025-01-16 Thread Andrew Jones
On Thu, Jan 16, 2025 at 02:39:27PM +0100, Vasilis Liaskovitis wrote: > This patch adds an "aliases" node with a "serial0" entry for the s/This patch adds/Add/ > single UART in the riscv64 virt machine. s/riscv64/riscv/ > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2774 > Signed-o

Re: [PATCH 2/3] pc-bios/s390-ccw: Fix boot problem with virtio-net devices

2025-01-16 Thread Jared Rossi
Reviewed-by: Jared Rossi On 1/16/25 6:58 AM, Thomas Huth wrote: When we are trying to boot from virtio-net devices, the s390-ccw bios currently leaves the virtio-net device enabled after using it. That means that the receiving virt queues will continue to happily write incoming network packets

Re: [PATCH] firmware: qemu_fw_cfg: constify 'struct bin_attribute'

2025-01-16 Thread Michael S. Tsirkin
On Tue, Jan 14, 2025 at 10:50:20PM +0100, Thomas Weißschuh wrote: > The sysfs core now allows instances of 'struct bin_attribute' to be > moved into read-only memory. Make use of that to protect them against > accidental or malicious modifications. > > Signed-off-by: Thomas Weißschuh why not Ac

Re: [PATCH 13/13] hw/arm/virt: Remove VirtMachineClass::no_highmem_ecam field

2025-01-16 Thread Thomas Huth
On 15/01/2025 18.10, Philippe Mathieu-Daudé wrote: The VirtMachineClass::no_highmem_ecam field was only used by virt-2.12 machine, which got removed. Remove it and simplify virt_instance_init(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/virt.h | 1 - hw/arm/virt.c | 2

Re: [PATCH 11/13] hw/arm/virt: Remove VirtMachineClass::smbios_old_sys_ver field

2025-01-16 Thread Thomas Huth
On 15/01/2025 18.10, Philippe Mathieu-Daudé wrote: The VirtMachineClass::smbios_old_sys_ver field was only used by virt-2.11 machine, which got removed. Remove it and simplify virt_build_smbios(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/virt.h | 1 - hw/arm/virt.c |

[RFC v4 4/5] target/arm: Enable feature ARM_FEATURE_EL2 if EL2 is supported

2025-01-16 Thread Eric Auger
From: Haibo Xu KVM_CAP_ARM_EL2 must be supported by the cpu to enable ARM_FEATURE_EL2. In case the host does support NV, expose the feature. Signed-off-by: Haibo Xu Signed-off-by: Miguel Luis Signed-off-by: Eric Auger Reviewed-by: Richard Henderson --- v2 -> v3: - check pmu->has_el2 on kvm_

[RFC v4 1/5] linux-headers: update to nv-next (Jan 9)

2025-01-16 Thread Eric Auger
This is a temporary linux header update against Marc's nv-next branch (from Jan 9). As this branch is continuously evolving I made a snapshot at https://github.com/eauger/linux/tree/nv_next_jan9_2025 Signed-off-by: Eric Auger --- linux-headers/asm-arm64/kvm.h | 1 + linux-headers/linux/kvm.h

[RFC v4 5/5] hw/arm/virt: Allow virt extensions with KVM

2025-01-16 Thread Eric Auger
From: Haibo Xu Up to now virt support on guest has been only supported with TCG. Now it becomes feasible to use it with KVM acceleration. Also check only in-kernel GICv3 is used along with KVM EL2. Signed-off-by: Haibo Xu Signed-off-by: Miguel Luis Signed-off-by: Eric Auger Reviewed-by: Rich

Re: [PATCH] system/runstate: Fix regression, clarify BQL status of exit notifiers

2025-01-16 Thread David Woodhouse
On Wed, 2025-01-15 at 20:17 +0100, Phil Dennis-Jordan wrote: > > BQL_LOCK_GUARD expands to a call to bql_auto_lock(), which in turn > defends against recursive locking by checking bql_locked().  > > https://gitlab.com/qemu-project/qemu/-/blob/master/include/qemu/main-loop.h#L377 > > I think that

[RFC v4 3/5] target/arm/kvm: Add helper to detect EL2 when using KVM

2025-01-16 Thread Eric Auger
From: Haibo Xu Introduce query support for KVM_CAP_ARM_EL2. Signed-off-by: Haibo Xu Signed-off-by: Miguel Luis Signed-off-by: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- target/arm/kvm_arm.h | 12 target/arm/kvm.c | 5 + 2 files c

[RFC v4 0/5] ARM Nested Virt Support

2025-01-16 Thread Eric Auger
This is a rebase on top of qemu v9.2.0 and tested against Marc's nv-next from Jan 9, 2025. As this branch is continuously evolving I put a snapshot at https://github.com/eauger/linux/tree/nv_next_jan9_2025. This was tested with rhel L1 guest (4k/64k) and various L2 guests (buildroot, debian, rhel

Re: [PATCH 04/21] hw/i386/pc: Remove pc_compat_2_4[] array

2025-01-16 Thread Daniel P . Berrangé
On Thu, Jan 16, 2025 at 12:22:30AM +0100, Philippe Mathieu-Daudé wrote: > The pc_compat_2_4[] array was only used by the pc-q35-2.4 > and pc-i440fx-2.4 machines, which got removed. Remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/i386/pc.h | 3 --- > hw/i386/pc.c

Re: [PATCH 03/21] hw/i386/pc: Remove PCMachineClass::broken_reserved_end field

2025-01-16 Thread Daniel P . Berrangé
On Thu, Jan 16, 2025 at 12:22:29AM +0100, Philippe Mathieu-Daudé wrote: > The PCMachineClass::broken_reserved_end field was only used > by the pc-q35-2.4 and pc-i440fx-2.4 machines, which got removed. > Remove it and simplify pc_memory_init(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > in

Re: [PATCH 05/21] target/i386/cpu: Remove X86CPU::check_cpuid field

2025-01-16 Thread Daniel P . Berrangé
On Thu, Jan 16, 2025 at 12:22:31AM +0100, Philippe Mathieu-Daudé wrote: > The X86CPU::check_cpuid boolean was only set in the > pc_compat_2_4[] array, via the 'check=off' property. > We removed all machines using that array, lets remove > that CPU property and simplify x86_cpu_realizefn(). > > Sig

Re: [PATCH 06/21] target/i386/cpu: Pass Error** to x86_cpu_filter_features()

2025-01-16 Thread Daniel P . Berrangé
On Thu, Jan 16, 2025 at 12:22:32AM +0100, Philippe Mathieu-Daudé wrote: > Simplify x86_cpu_realizefn() by passing an Error** > argument to x86_cpu_filter_features(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/i386/cpu.c | 26 +- > 1 file changed, 9 insertion

[PATCH v3 13/37] tests/tcg/plugins/syscall: fix 32-bit build

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20241217224306.2900490-4-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- tests/tcg/plugins/syscall.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/t

[PATCH v3 02/37] semihosting/uaccess: Briefly document returned values

2025-01-16 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since it is not obvious the get/put_user*() methods can return an error, add brief docstrings about it. Also remind to use *unlock_user() when appropriate. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20241212115413.42109-1-phi.

[PATCH v3 12/37] contrib/plugins/howvec: ensure we don't regress if this plugin is extended

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20241217224306.2900490-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- contrib/plugins/howvec.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/contrib/p

[PATCH v3 30/37] include/exec: remove warning_printed from MemoryRegion

2025-01-16 Thread Alex Bennée
Since d197063fcf9 (memory: move unassigned_mem_ops to memory.c) this field is unused. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Xu --- include/exec/memory.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/exec/m

[PATCH v3 11/37] tests/tcg/plugins/insn: remove unused callback parameter

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20241217224306.2900490-2-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- tests/tcg/plugins/insn.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

[PATCH v3 01/37] semihosting: add guest_error logging for failed opens

2025-01-16 Thread Alex Bennée
This usually indicates the semihosting call was expecting to find something but didn't. Message-Id: <20250109170619.2271193-2-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- semihosting/syscalls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/semihos

[PATCH v3 14/37] tests/tcg/plugins/mem: fix 32-bit build

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20241217224306.2900490-5-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- tests/tcg/plugins/mem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/tcg/p

[PATCH v3 09/37] system: squash usb_parse into a single function

2025-01-16 Thread Alex Bennée
We don't need to wrap usb_device_add as usb_parse is already gated with an if (machine_usb(current_machine)) check. Instead just assert and directly fail if usbdevice_create returns NULL. Message-Id: <20250109170619.2271193-10-alex.ben...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off

[PATCH v3 00/37] maintainer updates for jan '25 (semihosting, gdb, plugins, docs) pre-PR-FINAL

2025-01-16 Thread Alex Bennée
Only a few changes from v2, sending out to cut a PR tomorrow - applied r-b tags - fixed bsd-user gdbserver_start - a few minor tweaks to commit messages This covers my remaining trees outside of testing/next and is mostly a consolidation of patches I've pulled from other people. For semiho

[PATCH v3 16/37] contrib/plugins/cache: fix 32-bit build

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Message-Id: <20241217224306.2900490-7-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- contrib/plugins/cache.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git

[PATCH v3 21/37] configure: reenable plugins by default for 32-bit hosts

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20241217224306.2900490-12-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- configure | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/configur

[PATCH v3 05/37] semihosting/arm-compat: Include missing 'cpu.h' header

2025-01-16 Thread Alex Bennée
From: Philippe Mathieu-Daudé ARM semihosting implementations in "common-semi-target.h" must de-reference the target CPUArchState, which is declared in each target "cpu.h" header. Include it in order to avoid when refactoring: In file included from ../../semihosting/arm-compat-semi.c:169: ../

[PATCH v3 04/37] semihosting/uaccess: Include missing 'exec/cpu-all.h' header

2025-01-16 Thread Alex Bennée
From: Philippe Mathieu-Daudé TLB_INVALID_MASK is defined in "exec/cpu-all.h". Include it in order to avoid when refactoring: ../semihosting/uaccess.c:41:21: error: use of undeclared identifier 'TLB_INVALID_MASK' 41 | if (flags & TLB_INVALID_MASK) { | ^

Re: [PATCH v3 00/37] maintainer updates for jan '25 (semihosting, gdb, plugins, docs) pre-PR-FINAL

2025-01-16 Thread Alex Bennée
Alex Bennée writes: > Only a few changes from v2, sending out to cut a PR tomorrow > > - applied r-b tags > - fixed bsd-user gdbserver_start > - a few minor tweaks to commit messages > > Most are already reviewed, the following remain: > > docs/sphinx: include kernel-doc script as a depe

[PATCH v3 10/37] system: propagate Error to gdbserver_start (and other device setups)

2025-01-16 Thread Alex Bennée
This started as a clean-up to properly pass a Error handler to the gdbserver_start so we could do the right thing for command line and HMP invocations. Now that we have cleaned up foreach_device_config_or_exit() in earlier patches we can further simplify by it by passing &error_fatal instead of ch

[PATCH v3 08/37] system/vl: more error exit into config enumeration code

2025-01-16 Thread Alex Bennée
All of the failures to configure devices will result in QEMU exiting with an error code. In preparation for passing Error * down the chain re-name the iterator to foreach_device_config_or_exit and exit using &error_fatal instead of returning a failure indication. Message-Id: <20250109170619.227119

[PATCH v3 06/37] semihosting/console: Avoid including 'cpu.h'

2025-01-16 Thread Alex Bennée
From: Philippe Mathieu-Daudé The CPUState structure is declared in "hw/core/cpu.h", the EXCP_HALTED definition in "exec/cpu-common.h". Both headers are indirectly include by "cpu.h". In order to remove "cpu.h" from "semihosting/console.h", explicitly include them in console.c, otherwise we'd get:

[PATCH v3 29/37] include/exec: fix some copy and paste errors in kdoc

2025-01-16 Thread Alex Bennée
A number of copy and paste kdoc comments are referring to the wrong definition. Fix those cases. Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier --- include/exec/memory.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory

[PATCH v3 03/37] semihosting/syscalls: Include missing 'exec/cpu-defs.h' header

2025-01-16 Thread Alex Bennée
From: Philippe Mathieu-Daudé target_ulong is defined in each target "cpu-param.h", itself included by "exec/cpu-defs.h". Include the latter in order to avoid when refactoring: include/semihosting/syscalls.h:26:24: error: unknown type name 'target_ulong' 26 |target_

[PATCH v3] hw/riscv/virt: Add serial alias in DTB

2025-01-16 Thread Vasilis Liaskovitis
Add an "aliases" node with a "serial0" entry for the single UART in the riscv virt machine. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2774 Signed-off-by: Vasilis Liaskovitis Reviewed-by: Andrew Jones --- hw/riscv/virt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/ris

[PATCH v3 07/37] semihosting/meson: Build config.o and console.o once

2025-01-16 Thread Alex Bennée
From: Philippe Mathieu-Daudé config.c and console.c don't use any target specific headers anymore, move them from specific_ss[] to system_ss[] so they are built once, but will also be linked once, removing global symbol clash in a single QEMU binary. Signed-off-by: Philippe Mathieu-Daudé Review

[PATCH v3 37/37] scripts/nsis.py: Run dependency check for each DLL file only once

2025-01-16 Thread Alex Bennée
From: Stefan Weil Each DLL should only be checked once for dependencies, but several hundred (781 in my test) unneeded checks were done. Now the script is significantly faster (16 s in my build). Signed-off-by: Stefan Weil Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Mes

[PATCH v1] ppc/pnv: Add new PowerPC Special Purpose Registers (RWMR)

2025-01-16 Thread dan tan
From: dan tan Register RWMR - Region Weighted Mode Register for privileged access in Power9 and Power10 It controls what the SPURR register produces. Specs: - Power9: https://ibm.ent.box.com/s/tmklq90ze7aj8f4n32er1mu3sy9u8k3k - Power10: https://files.openpower.foundation/s/EgCy7C43p2NSRfR Si

Re: [PATCH 2/3] pc-bios/s390-ccw: Fix boot problem with virtio-net devices

2025-01-16 Thread Philippe Mathieu-Daudé
On 16/1/25 12:58, Thomas Huth wrote: When we are trying to boot from virtio-net devices, the s390-ccw bios currently leaves the virtio-net device enabled after using it. That means that the receiving virt queues will continue to happily write incoming network packets into memory. This can corrupt

Re: [PATCH v7 1/3] linux-headers: Add vmclock-abi.h

2025-01-16 Thread Cornelia Huck
On Thu, Jan 16 2025, David Woodhouse wrote: > From: David Woodhouse > > This isn't a Linux-specific ABI but Linux does export the header file > with its definition, so import it from there instead of creating our own. > > Signed-off-by: David Woodhouse > Acked-by: Michael S. Tsirkin > --- > s

Re: [PATCH v7 2/3] linux-headers: Update to Linux 6.13-rc7

2025-01-16 Thread Cornelia Huck
On Thu, Jan 16 2025, David Woodhouse wrote: > On Thu, 2025-01-16 at 15:07 +0100, Paul Durrant wrote: >> On 16/01/2025 14:59, David Woodhouse wrote: >> > From: David Woodhouse >> > >> > Signed-off-by: David Woodhouse >> > --- >> >   include/standard-headers/linux/vmclock-abi.h | 182 +++

Re: [PATCH v7 3/3] hw/acpi: Add vmclock device

2025-01-16 Thread Philippe Mathieu-Daudé
On 16/1/25 16:32, David Woodhouse wrote: On Thu, 2025-01-16 at 16:15 +0100, Philippe Mathieu-Daudé wrote: --- a/hw/acpi/Kconfig +++ b/hw/acpi/Kconfig @@ -60,6 +60,11 @@ config ACPI_VMGENID    default y    depends on PC +config ACPI_VMCLOCK +    bool +    default y +    depends

Re: [PATCH] block-backend: protect setting block root to NULL with block graph write lock

2025-01-16 Thread Kevin Wolf
Am 10.01.2025 um 17:37 hat Fiona Ebner geschrieben: > Am 09.01.25 um 11:47 schrieb Kevin Wolf: > > Am 08.01.2025 um 13:46 hat Fiona Ebner geschrieben: > >> Setting blk->root is a graph change operation and thus needs to be > >> protected by the block graph write lock in blk_remove_bs(). The > >> as

Re: [PATCH v7 3/3] hw/acpi: Add vmclock device

2025-01-16 Thread David Woodhouse
On Thu, 2025-01-16 at 16:57 +0100, Philippe Mathieu-Daudé wrote: > > > > I'm only seeing e820_add_entry (I386) and ACPI API called. So: > > > > > >   depends on I386 && ACPI > > Actually the Kconfig should be: > > select ACPI > depends on I386 Ack. smime.p7s Description: S/MIM

[PATCH v3 36/37] docs: add a glossary

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20241209183104.365796-7-pierrick.bouv...@linaro.org> [AJB: update MAINTAINERS] Signed-off-by: Alex Bennée --- v3 - update MAINTAINERS --- MAINTAINERS | 1 + docs/d

[PATCH v3 22/37] accel/tcg: also suppress asynchronous IRQs for cpu_io_recompile

2025-01-16 Thread Alex Bennée
While it would be technically correct to allow an IRQ to happen (as the offending instruction never really completed) it messes up instrumentation. We already take care to only use memory instrumentation on the block, we should also suppress IRQs. Message-Id: <20250109170619.2271193-23-alex.ben...

Re: [PATCH] accel/tcg: Call tcg_tb_insert() for one-insn TBs

2025-01-16 Thread Ilya Leoshkevich
On Thu, 2025-01-16 at 15:41 +, Peter Maydell wrote: > On Thu, 16 Jan 2025 at 15:40, Alex Bennée > wrote: > > > > Richard Henderson writes: > > > > > On 1/16/25 07:06, Ilya Leoshkevich wrote: > > > > On Thu, 2025-01-16 at 06:54 -0800, Richard Henderson wrote: > > > > > On 1/15/25 15:20, Ilya

[PATCH v3 26/37] plugins: fix kdoc annotation

2025-01-16 Thread Alex Bennée
The function is qemu_plugin_mem_get_value() Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier --- include/qemu/qemu-plugin.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index 0fba36ae02..3a850aa216 100644 ---

[PATCH v3 32/37] docs/devel: add git-publish for patch submitting

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20241209183104.365796-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- docs/devel/submitting-a-patch.rst | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH v3 27/37] editorconfig: update for perl scripts

2025-01-16 Thread Alex Bennée
We have two types of perl scripts in the tree. The ones from the kernel are mostly tab based where as scripts we have written ourselves use 4 space indentation. Attempt to codify that in our .editorconfig Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier --- .editorconfig | 13 +

[PATCH v3 28/37] tests/qtest: fix some copy and paste errors in kdoc

2025-01-16 Thread Alex Bennée
A number of copy and paste kdoc comments are referring to the wrong definition. Fix those cases. Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier --- tests/qtest/libqos/qgraph.h | 2 +- tests/qtest/libqtest.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v3 33/37] docs/devel: add b4 for patch retrieval

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20241209183104.365796-4-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- docs/devel/submitting-a-patch.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/dev

[PATCH v3 19/37] contrib/plugins/hwprofile: fix 32-bit build

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20241217224306.2900490-10-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- contrib/plugins/hwprofile.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions

[PATCH v3 34/37] docs/devel: add information on how to setup build environments

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier MacOS and Linux are straightforward, but Windows needs a bit more details. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20241209183104.365796-5-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- v3 - add new files to MAINTAINER

[PATCH v3 35/37] docs/devel: add a codebase section

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Present the various parts of QEMU and organization of codebase. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20241209183104.365796-6-pierrick.bouv...@linaro.org> [AJB: tweak commit summary, update MAINTAINERS] Signed-off-by: Alex Bennée -

[PATCH v3 23/37] win32: remove usage of attribute gcc_struct

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier This attribute is not recognized by clang. An investigation has been performed to ensure this attribute has no effect on layout of structures we use in QEMU [1], so it's safe to remove now. In the future, we'll forbid introducing new bitfields in packed struct, as they ar

[PATCH v3 31/37] docs/sphinx: include kernel-doc script as a dependency

2025-01-16 Thread Alex Bennée
When we update the script we should rebuild the docs. Otherwise breaking changes made to the kdoc script don't become apparent until later. Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier --- docs/sphinx/depfile.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/sphinx/depf

[PATCH v3 15/37] contrib/plugins/stoptrigger: fix 32-bit build

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Message-Id: <20241217224306.2900490-6-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- contrib/plugins/stoptrigger.c | 48 --- 1 file changed, 27 insertions(+), 21

[PATCH v3 17/37] contrib/plugins/hotblocks: fix 32-bit build

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Message-Id: <20241217224306.2900490-8-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- contrib/plugins/hotblocks.c | 29 - 1 file changed, 24 insertions(+), 5 deletions

[PATCH v3 20/37] contrib/plugins/hotpages: fix 32-bit build

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20241217224306.2900490-11-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- contrib/plugins/hotpages.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib

[PATCH v3 24/37] docs/devel/style: add a section about bitfield, and disallow them for packed structures

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Tested-by: Stefan Weil Tested-by: Philippe Mathieu-Daudé Message-Id: <20250110203401.178532-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- docs/devel/sty

[PATCH v3 18/37] contrib/plugins/cflow: fix 32-bit build

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20241217224306.2900490-9-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- contrib/plugins/cflow.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git

Re: [PATCH v2 0/3] vfio/igd: VFIOConfigMirrorQuirk for igd mirrored registers

2025-01-16 Thread Alex Williamson
On Sat, 4 Jan 2025 23:42:15 +0800 Tomita Moeko wrote: > In commit 1a2623b5c9e7 ("vfio/igd: add macro for declaring mirrored > registers"), I introduced a macro to handle mirrored registers in igd > bar0. However, using the existing VFIOConfigMirrorQuirk should be a > better approach I think afte

Re: [PATCH v7 1/2] memory: Update inline documentation

2025-01-16 Thread BALATON Zoltan
On Thu, 16 Jan 2025, Peter Maydell wrote: On Tue, 14 Jan 2025 at 19:12, Peter Xu wrote: On Tue, Jan 14, 2025 at 05:42:57PM +, Peter Maydell wrote: There's at least one test in the arm qtests that will hit this. I suspect that you'll find that most architectures except x86 (where we don't

[PATCH v3 25/37] plugins: enable linking with clang/lld

2025-01-16 Thread Alex Bennée
From: Pierrick Bouvier Windows uses a special mechanism to enable plugins to work (DLL delay loading). Option for lld is different than ld. MSYS2 clang based environment use lld by default, so restricting to this config on Windows is safe, and will avoid false bug reports. Reviewed-by: Philippe

[PATCH v2] Add a simple zh_TW Traditional Chinese translation

2025-01-16 Thread Peter Dave Hello via
>From 600ed9784dd5c2b209a3f5e1a5c97fc9cf4fa24e Mon Sep 17 00:00:00 2001 From: Peter Dave Hello Date: Tue, 16 Apr 2024 00:43:29 +0800 Subject: [PATCH v2] Add a simple zh_TW Traditional Chinese translation This patch adds a basic zh_TW translation file for Taiwan Traditional Chinese users. Signed-

Re: [PATCH 2/3] pci: acpi: Windows 'PCI Label Id' bug workaround

2025-01-16 Thread Fiona Ebner
Am 15.01.25 um 13:53 schrieb Igor Mammedov: > Current versions of Windows call _DSM(func=7) regardless > of whether it is supported or not. It leads to NICs having bogus > 'PCI Label Id = 0', where none should be set at all. > > Also presence of 'PCI Label Id' triggers another Windows bug > on loc

Re: [PATCH v2 0/3] vfio/igd: VFIOConfigMirrorQuirk for igd mirrored registers

2025-01-16 Thread Cédric Le Goater
On 1/4/25 16:42, Tomita Moeko wrote: In commit 1a2623b5c9e7 ("vfio/igd: add macro for declaring mirrored registers"), I introduced a macro to handle mirrored registers in igd bar0. However, using the existing VFIOConfigMirrorQuirk should be a better approach I think after going through the vfio c

Re: [PATCH v2] Add a b4 configuration file

2025-01-16 Thread Cédric Le Goater
On 1/2/25 23:53, Jiaxun Yang wrote: b4 [1] is a convenient tool to manage patch series with mailing list working flow. Add a project default config file to match QEMU's mailing list conventions as well as adopting differences on scripting. Examples of b4: ``` $ b4 prep --check Checking patches

qemu-devel@nongnu.org

2025-01-16 Thread Richard Henderson
On 1/15/25 15:29, Philippe Mathieu-Daudé wrote: Create vCPUs from the last one to the first one. No need to use the &first_cpu global since we already have it referenced. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/loongson3_virt.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletion

Re: [PATCH v2 05/23] qapi/schema: add __repr__ to QAPIDoc.Section

2025-01-16 Thread John Snow
On Thu, Jan 16, 2025 at 6:51 AM Markus Armbruster wrote: > John Snow writes: > > > Makes debugging far more pleasant when you can just print(section) and > > get something reasonable to display. > > > > Signed-off-by: John Snow > > --- > > scripts/qapi/parser.py | 3 +++ > > 1 file changed, 3

Re: [PATCH-for-10.1 v2 12/13] hw/arm/virt: Remove deprecated virt-2.12 machine

2025-01-16 Thread Richard Henderson
On 1/16/25 06:59, Philippe Mathieu-Daudé wrote: This machine has been supported for a period of more than 6 years. According to our versioned machine support policy (see commit ce80c4fa6ff "docs: document special exception for machine type deprecation & removal") it can now be removed. Signed-of

Re: [PATCH-for-10.1 v2 11/13] hw/arm/virt: Remove VirtMachineClass::smbios_old_sys_ver field

2025-01-16 Thread Richard Henderson
On 1/16/25 06:59, Philippe Mathieu-Daudé wrote: The VirtMachineClass::smbios_old_sys_ver field was only used by virt-2.11 machine, which got removed. Remove it and simplify virt_build_smbios(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- include/hw/arm/virt.h | 1 - h

Re: [PATCH-for-10.1 v2 10/13] hw/arm/virt: Remove deprecated virt-2.11 machine

2025-01-16 Thread Richard Henderson
On 1/16/25 06:59, Philippe Mathieu-Daudé wrote: This machine has been supported for a period of more than 6 years. According to our versioned machine support policy (see commit ce80c4fa6ff "docs: document special exception for machine type deprecation & removal") it can now be removed. Signed-of

Re: [PATCH-for-10.1 v2 13/13] hw/arm/virt: Remove VirtMachineClass::no_highmem_ecam field

2025-01-16 Thread Richard Henderson
On 1/16/25 06:59, Philippe Mathieu-Daudé wrote: The VirtMachineClass::no_highmem_ecam field was only used by virt-2.12 machine, which got removed. Remove it and simplify virt_instance_init(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- include/hw/arm/virt.h | 1 - hw/

Re: [PATCH 06/22] exec/cpu: Call cpu_remove_sync() once in cpu_common_unrealize()

2025-01-16 Thread Philippe Mathieu-Daudé
On 28/11/23 17:42, Igor Mammedov wrote: On Mon, 18 Sep 2023 18:02:39 +0200 Philippe Mathieu-Daudé wrote: While create_vcpu_thread() creates a vCPU thread, its counterpart is cpu_remove_sync(), which join and destroy the thread. create_vcpu_thread() is called in qemu_init_vcpu(), itself called

Re: [PATCH 01/21] hw/i386/pc: Remove unused pc_compat_2_3 declarations

2025-01-16 Thread Richard Henderson
On 1/15/25 15:22, Philippe Mathieu-Daudé wrote: We removed the implementations in commit 46a2bd52571 ("hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine") but forgot to remove the declarations. Do it now. Fixes: 46a2bd52571 ("hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine") Signed-off-by:

Re: [PATCH] vfio: Support P2P access in confidential VM

2025-01-16 Thread Cédric Le Goater
--- a/linux-headers/linux/vfio.h +++ b/linux-headers/linux/vfio.h @@ -1560,6 +1560,7 @@ struct vfio_iommu_type1_dma_map { #define VFIO_DMA_MAP_FLAG_READ (1 << 0) /* readable from device */ #define VFIO_DMA_MAP_FLAG_WRITE (1 << 1)/* writable from device */ #define VFIO_DMA_MAP

Re: [PATCH] vfio/igd: Fix potential overflow in igd_gtt_memory_size()

2025-01-16 Thread Cédric Le Goater
On 1/7/25 14:06, Cédric Le Goater wrote: The risk is mainly theoretical since the applied bit mask will keep the 'ggms' shift value below 3. Nevertheless, let's use a 64 bit integer type and resolve the coverity issue. Resolves: Coverity CID 1585908 Fixes: 1e1eac5f3dcd ("vfio/igd: canonicalize m

Re: [RFC v3 1/5] vhost-vdpa: Decouple the IOVA allocator

2025-01-16 Thread Eugenio Perez Martin
On Fri, Jan 10, 2025 at 6:09 PM Jonah Palmer wrote: > > Decouples the IOVA allocator from the full IOVA->HVA tree to support a > SVQ IOVA->HVA tree for host-only memory mappings. > > The IOVA allocator still allocates an IOVA range but instead adds this > range to an IOVA-only tree (iova_map) that

Re: [PATCH v7 1/2] memory: Update inline documentation

2025-01-16 Thread Peter Xu
On Thu, Jan 16, 2025 at 02:50:26PM +, Peter Maydell wrote: > On Tue, 14 Jan 2025 at 19:12, Peter Xu wrote: > > > > On Tue, Jan 14, 2025 at 05:42:57PM +, Peter Maydell wrote: > > > There's at least one test in the arm qtests that will hit this. > > > I suspect that you'll find that most arc

Re: [RFC v3 2/5] vhost-iova-tree: Remove range check for IOVA allocator

2025-01-16 Thread Eugenio Perez Martin
On Fri, Jan 10, 2025 at 6:09 PM Jonah Palmer wrote: > > Removes the range check portion in vhost_iova_tree_map_alloc. > > The previous patch decoupled the IOVA allocator from adding mappings to > the IOVA->HVA tree (now a partial SVQ IOVA->HVA tree) and instead adds > the allocated IOVA range to a

Re: [PATCH-for-10.1 v2 04/13] hw/arm/virt: Remove deprecated virt-2.7 machine

2025-01-16 Thread Richard Henderson
On 1/16/25 06:59, Philippe Mathieu-Daudé wrote: This machine has been supported for a period of more than 6 years. According to our versioned machine support policy (see commit ce80c4fa6ff "docs: document special exception for machine type deprecation & removal") it can now be removed. Signed-of

Re: [PATCH] vfio: Support P2P access in confidential VM

2025-01-16 Thread Alex Williamson
On Thu, 16 Jan 2025 17:53:55 +0800 Wencheng Yang wrote: > On confidential VM platform, for example, AMD-SEV, P2P doesn't work. > The underlying reason is that IOMMU driver set encryption bit on > IOMMU page table pte entry, it's reasonalbe if the pte maps iova > to system memory. However, if the

Re: [PATCH] vfio/iommufd: Fix SIGSEV in iommufd_cdev_attach()

2025-01-16 Thread Cédric Le Goater
On 1/16/25 11:23, Zhenzhong Duan wrote: When iommufd_cdev_ram_block_discard_disable() fails for whatever reason, errp should be set or else SIGSEV is triggered in vfio_realize() when error_prepend() is called. By this chance, use the same error message for both legacy and iommufd backend. Fixes

Re: [PATCH-for-10.1 v2 01/13] hw/arm/virt: Remove deprecated virt-2.6 machine

2025-01-16 Thread Richard Henderson
On 1/16/25 06:59, Philippe Mathieu-Daudé wrote: This machine has been supported for a period of more than 6 years. According to our versioned machine support policy (see commit ce80c4fa6ff "docs: document special exception for machine type deprecation & removal") it can now be removed. Reviewed-

Re: [PATCH-for-10.1 v2 02/13] hw/arm/virt: Remove VirtMachineClass::no_pmu field

2025-01-16 Thread Richard Henderson
On 1/16/25 06:59, Philippe Mathieu-Daudé wrote: The VirtMachineClass::no_pmu field was only used by virt-2.6 machine, which got removed. Remove it and simplify machvirt_init(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- include/hw/arm/virt.h | 1 - hw/arm/virt.c

Re: [PATCH-for-10.1 v2 03/13] hw/arm/virt: Remove VirtMachineClass::disallow_affinity_adjustment

2025-01-16 Thread Richard Henderson
On 1/16/25 06:59, Philippe Mathieu-Daudé wrote: TheVirtMachineClass::disallow_affinity_adjustment field was only used by virt-2.6 machine, which got removed. Remove it and simplify virt_cpu_mp_affinity(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/virt.h | 1 - hw/arm/virt.c

Re: [PATCH-for-10.1 v2 05/13] hw/arm/virt: Remove VirtMachineClass::no_its field

2025-01-16 Thread Richard Henderson
On 1/16/25 06:59, Philippe Mathieu-Daudé wrote: The VirtMachineClass::no_its field was only used by virt-2.7 machine, which got removed. Remove it and simplify virt_instance_init() and virt_acpi_build(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- include/hw/arm/virt.h

Re: [PATCH-for-10.1 v2 06/13] hw/arm/virt: Remove deprecated virt-2.8 machine

2025-01-16 Thread Richard Henderson
On 1/16/25 06:59, Philippe Mathieu-Daudé wrote: This machine has been supported for a period of more than 6 years. According to our versioned machine support policy (see commit ce80c4fa6ff "docs: document special exception for machine type deprecation & removal") it can now be removed. Signed-of

Re: [PATCH-for-10.1 v2 08/13] hw/arm/virt: Remove deprecated virt-2.9 machine

2025-01-16 Thread Richard Henderson
On 1/16/25 06:59, Philippe Mathieu-Daudé wrote: This machine has been supported for a period of more than 6 years. According to our versioned machine support policy (see commit ce80c4fa6ff "docs: document special exception for machine type deprecation & removal") it can now be removed. Signed-of

Re: [PATCH-for-10.1 v2 07/13] hw/arm/virt: Remove VirtMachineClass::claim_edge_triggered_timers field

2025-01-16 Thread Richard Henderson
On 1/16/25 06:59, Philippe Mathieu-Daudé wrote: TheVirtMachineClass::claim_edge_triggered_timers field was only used by virt-2.8 machine, which got removed. Remove it and simplify fdt_add_timer_nodes() and build_gtdt(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- include

Re: [PATCH-for-10.1 v2 09/13] hw/arm/virt: Remove deprecated virt-2.10 machine

2025-01-16 Thread Richard Henderson
On 1/16/25 06:59, Philippe Mathieu-Daudé wrote: This machine has been supported for a period of more than 6 years. According to our versioned machine support policy (see commit ce80c4fa6ff "docs: document special exception for machine type deprecation & removal") it can now be removed. Signed-of

Re: [PATCH 3/3] pc-bios/s390-ccw/netmain: Fix error messages with regards to the TFTP server

2025-01-16 Thread Jared Rossi
Reviewed-by: Jared Rossi On 1/16/25 6:58 AM, Thomas Huth wrote: The code in net_init_ip() currently bails out early if "rc" is less than 0, so the if-statements that check for negative "rc" codes to print out some specific error messages with regards to the TFTP server are never reached. Move t

<    1   2   3   4   >