[PATCH] MAINTAINERS: Update path to coreaudio.m

2025-01-10 Thread Akihiko Odaki
Commit 8b46d7e2dc8e ("audio: Rename coreaudio extension to use Objective-C compiler") renamed coreaudio.c to coreaudio.m. Signed-off-by: Akihiko Odaki --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 38a290e9c2ce..1e30c0f1405

Re: [RFC PATCH 0/5] hw/arm/virt: Add support for user-creatable nested SMMUv3

2025-01-10 Thread Donald Dutile
Nicolin, Hi! On 1/8/25 11:45 PM, Nicolin Chen wrote: On Mon, Dec 16, 2024 at 10:01:29AM +, Shameerali Kolothum Thodi wrote: And patches prior to this commit adds that support: 4ccdbe3: ("cover-letter: Add HW accelerated nesting support for arm SMMUv3") Nicolin is soon going to send out th

Re: [PATCH v7 1/2] memory: Update inline documentation

2025-01-10 Thread Akihiko Odaki
On 2025/01/11 0:18, Peter Xu wrote: On Fri, Jan 10, 2025 at 05:43:15PM +0900, Akihiko Odaki wrote: On 2025/01/10 4:37, Peter Xu wrote: On Thu, Jan 09, 2025 at 02:29:21PM -0500, Peter Xu wrote: On Thu, Jan 09, 2025 at 01:30:35PM +0100, BALATON Zoltan wrote: On Thu, 9 Jan 2025, Akihiko Odaki wr

Re: [RFC]: port of embedded x86-mini disassembler to QEMU

2025-01-10 Thread Michael Clark
On 1/11/25 05:05, Paolo Bonzini wrote: Il ven 10 gen 2025, 14:03 Michael Clark ha scritto: On 1/11/25 00:07, Paolo Bonzini wrote: Il ven 10 gen 2025, 10:52 Michael Clark ha scritto: a note to announce a port of the x86-mini disassembler to QEMU. -https://github.com/michaeljclark/qemu/tree/x

Re: [PATCH 1/2] util/iov: Do not assert offset is in iov

2025-01-10 Thread Akihiko Odaki
Jason, can you pull this series? Regards, Akihiko Odaki On 2024/05/08 23:51, Philippe Mathieu-Daudé wrote: ping? On 28/4/24 13:11, Akihiko Odaki wrote: iov_from_buf(), iov_to_buf(), iov_memset(), and iov_copy() asserts that the given offset fits in the iov while tolerating the specified numbe

Re: [PATCH v4 0/7] util: Introduce qemu_get_runtime_dir()

2025-01-10 Thread Akihiko Odaki
Hi, It seems this series has been forgotten for a while. Can anyone take a look at it? Regards, Akihiko Odaki On 2024/07/16 16:27, Akihiko Odaki wrote: qemu_get_runtime_dir() returns a dynamically allocated directory path that is appropriate for storing runtime files. It corresponds to "run"

[PATCH v5 6/6] hostmem: Handle remapping of RAM

2025-01-10 Thread “William Roche
From: David Hildenbrand Let's register a RAM block notifier and react on remap notifications. Simply re-apply the settings. Exit if something goes wrong. Merging and dump settings are handled by the remap notification in addition to memory policy and preallocation. Signed-off-by: David Hildenbr

Re: [PATCH v2 3/3] docs/system/arm/virt: mention specific migration information

2025-01-10 Thread Philippe Mathieu-Daudé
On 10/1/25 23:59, Pierrick Bouvier wrote: On 1/10/25 13:29, Philippe Mathieu-Daudé wrote: On 10/1/25 17:30, Peter Maydell wrote: On Thu, 19 Dec 2024 at 18:32, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier ---    docs/system/arm/virt.rst | 14 +++---    1 file changed, 11 in

Re: [PATCH v2 2/2] hw/char/serial: Convert to three-phase reset

2025-01-10 Thread Philippe Mathieu-Daudé
On 10/1/25 19:27, Philippe Mathieu-Daudé wrote: Convert the TYPE_SERIAL (16550A UART) to three-phase reset. Only local states are reset so use the ResetHold handler, like other legacy devices. Signed-off-by: Philippe Mathieu-Daudé --- hw/char/serial.c | 10 -- 1 file changed, 4 inse

Re: [PATCH] rcu: Call drain_call_rcu at exit

2025-01-10 Thread Akihiko Odaki
Hi Paolo, Please review this patch. Regards, Akihiko Odaki On 2024/10/13 16:31, Akihiko Odaki wrote: call_rcu() callbacks may have potential memory leaks, but QEMU may sometimes exit before draining the callbacks and leave the leaks undetected by LeakSanitizer. For example, PCI devices registe

Re: [PATCH] tap-linux: Open ipvtap and macvtap

2025-01-10 Thread Akihiko Odaki
Hi Jason, Can you check this patch again? Regards, Akihiko Odaki On 2024/10/22 13:59, Akihiko Odaki wrote: On 2024/10/18 17:10, Jason Wang wrote: On Sat, Oct 12, 2024 at 5:05 PM Akihiko Odaki wrote: On 2024/10/09 16:41, Jason Wang wrote: On Tue, Oct 8, 2024 at 2:52 PM Akihiko Odaki wrote

Re: [PATCH] ui/cocoa: Do not automatically zoom for HiDPI

2025-01-10 Thread Akihiko Odaki
Hi, Can anyone review this change? Regards, Akihiko Odaki On 2024/03/18 18:02, Akihiko Odaki wrote: Cocoa automatically zooms for a HiDPI display like Retina and makes the display blurry. Revert the automatic zooming. Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 9 ++--- 1 file chang

Re: [PATCH v6 6/8] chardev/char-mux: implement backend chardev multiplexing

2025-01-10 Thread Roman Penyaev
On Thu, Jan 9, 2025 at 7:07 PM Daniel P. Berrangé wrote: > > On Thu, Jan 09, 2025 at 01:56:40PM +0100, Roman Penyaev wrote: > > Hi, > > > > On Tue, Jan 7, 2025 at 3:57 PM Marc-André Lureau > > wrote: > > > Whether we talk about multiplexing front-end or back-end, the issues > > > are similar. In

Re: [PATCH v7 1/2] memory: Update inline documentation

2025-01-10 Thread Akihiko Odaki
On 2025/01/10 4:37, Peter Xu wrote: On Thu, Jan 09, 2025 at 02:29:21PM -0500, Peter Xu wrote: On Thu, Jan 09, 2025 at 01:30:35PM +0100, BALATON Zoltan wrote: On Thu, 9 Jan 2025, Akihiko Odaki wrote: Do not refer to "memory region's reference count" -

[PATCH 2/4] hw/xen: Use xs_node_read() from xen_console_get_name()

2025-01-10 Thread David Woodhouse
From: David Woodhouse Now that xs_node_read() can construct a node path, no need to open-code it. Signed-off-by: David Woodhouse --- hw/char/xen_console.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c index

[PATCH 4/4] hw/xen: Use xs_node_read() from xenstore_read_str() instead of open-coding it

2025-01-10 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/xen/xen_pvdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c index c5ad71e8dc..c9143ba259 100644 --- a/hw/xen/xen_pvdev.c +++ b/hw/xen/xen_pvdev.c @@ -22,6 +22,7 @@

[PATCH 3/4] hw/xen: Use xs_node_read() from xen_netdev_get_name()

2025-01-10 Thread David Woodhouse
From: David Woodhouse Now that xs_node_read() can construct a node path, no need to open-code it. Signed-off-by: David Woodhouse --- hw/net/xen_nic.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/net/xen_nic.c b/hw/net/xen_nic.c index 97ebd9fa30..54100394

[PATCH 1/4] hw/xen: Use xs_node_read() from xs_node_vscanf()

2025-01-10 Thread David Woodhouse
From: David Woodhouse Reduce some duplication. Signed-off-by: David Woodhouse --- hw/xen/trace-events | 1 - hw/xen/xen-bus-helper.c | 15 ++- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/hw/xen/trace-events b/hw/xen/trace-events index 461dee7b23..b67942d07b

Re: [PATCH v2 0/2] xen: error handling and FreeBSD compatibility fixes

2025-01-10 Thread David Woodhouse
On Fri, 2025-01-10 at 10:35 +0100, Roger Pau Monne wrote: > Hello, > > First patch from David introduces a new helper to fetch xenstore nodes, > while second patch removes the usage of scanf related functions with the > "%ms" format specifier, as it's not supported by the FreeBSD scanf libc > impl

Re: [RFC 3/4] hw/nvme: add NVMe Admin Security SPDM support

2025-01-10 Thread Klaus Jensen
On Jan 7 15:29, Wilfred Mallawa via wrote: > Adds the NVMe Admin Security Send/Receive command support with support > for DMTFs SPDM. The transport binding for SPDM is defined in the > DMTF DSP0286. > > Signed-off-by: Wilfred Mallawa > --- > hw/nvme/ctrl.c | 207 ++

[RFC PATCH] Fix race in live migration failure path

2025-01-10 Thread Shivam Kumar
Even if a live migration fails due to some reason, migration status should not be set to MIGRATION_STATUS_FAILED until migrate fd cleanup is done, else the client can trigger another instance of migration before the cleanup is complete (as it would assume no migration is active) or reset migration

[RFC]: port of embedded x86-mini disassembler to QEMU

2025-01-10 Thread Michael Clark
a note to announce a port of the x86-mini disassembler to QEMU. - https://github.com/michaeljclark/qemu/tree/x86-mini - https://github.com/michaeljclark/x86/tree/x86-mini # x86-mini the x86-mini library is a lightweight x86 encoder, decoder, and disassembler that uses extensions to the Intel ins

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2025-01-10 Thread Tomoyuki HIROSE
On 2025/01/09 1:50, Peter Xu wrote: Hi, Tomoyuki, On Wed, Jan 08, 2025 at 11:58:10AM +0900, Tomoyuki HIROSE wrote: Happy new year, Peter. I had another job and was late in replying to your email, sorry. Happy new year. That's fine. :) [...] So.. it turns out we shouldn't drop impl.unalig

Re: [PATCH v4 2/2] tests/qtest/libqos: add DMA support for writing and reading fw_cfg files

2025-01-10 Thread Gerd Hoffmann
On Fri, Jan 10, 2025 at 10:53:32AM +0530, Ani Sinha wrote: > > > > On 10 Jan 2025, at 2:00 AM, Fabiano Rosas wrote: > > > > Ani Sinha writes: > > > >> At present, the libqos/fw_cfg.c library does not support the modern DMA > >> interface which is required to write to the fw_cfg files. It only

Re: [PATCH 2/2] xen: do not use '%ms' scanf specifier

2025-01-10 Thread David Woodhouse
On Thu, 2025-01-09 at 17:55 +0100, Roger Pau Monné wrote: > On Thu, Jan 09, 2025 at 11:25:13AM +, David Woodhouse wrote: > > On Thu, 2025-01-09 at 11:59 +0100, Anthony PERARD wrote: > > > > > > >   char label[32]; > > > >   XenDevice *xendev = NULL; > > > >   XenConsole *con; > > >

Re: [PATCH v6 6/8] chardev/char-mux: implement backend chardev multiplexing

2025-01-10 Thread Daniel P . Berrangé
On Fri, Jan 10, 2025 at 09:43:52AM +0100, Roman Penyaev wrote: > On Thu, Jan 9, 2025 at 7:07 PM Daniel P. Berrangé wrote: > > > > On Thu, Jan 09, 2025 at 01:56:40PM +0100, Roman Penyaev wrote: > > > Hi, > > > > > > On Tue, Jan 7, 2025 at 3:57 PM Marc-André Lureau > > > wrote: > > > > Whether we t

Re: [PATCH 2/7] guest_memfd: Introduce an object to manage the guest-memfd with RamDiscardManager

2025-01-10 Thread Xu Yilun
> > > > https://github.com/aik/qemu/commit/3663f889883d4aebbeb0e4422f7be5e357e2ee46 > > > > but I am not sure if this ever saw the light of the day, did not it? > > (ironically I am using it as a base for encrypted DMA :) ) > > Yeah, we are doing the same work. I saw a solution from Michael long

Re: [PATCH v2 1/1] hw/nvme: Add OCP SMART / Health Information Extended Log Page

2025-01-10 Thread Klaus Jensen
On Nov 29 09:27, Stephen Bates wrote: > The Open Compute Project [1] includes a Datacenter NVMe > SSD Specification [2]. The most recent version of this specification > (as of November 2024) is 2.6.1. This specification layers on top of > the NVM Express specifications [3] to provide additional > f

Re: [PATCH v3 3/3] plugins: enable linking with clang/lld

2025-01-10 Thread Philippe Mathieu-Daudé
+Akihiko & Yonggang for https://lore.kernel.org/qemu-devel/20201006120900.1579-1-luoyongg...@gmail.com/ On 28/11/24 21:15, Pierrick Bouvier wrote: Windows uses a special mechanism to enable plugins to work (DLL delay loading). Option for lld is different than ld. MSYS2 clang based environment u

Re: [PATCH 0/7] Enable shared device assignment

2025-01-10 Thread David Hildenbrand
On 10.01.25 08:06, Chenyi Qiang wrote: On 1/10/2025 9:42 AM, Alexey Kardashevskiy wrote: On 9/1/25 19:49, Chenyi Qiang wrote: On 1/9/2025 4:18 PM, Alexey Kardashevskiy wrote: On 9/1/25 18:52, Chenyi Qiang wrote: On 1/8/2025 7:38 PM, Alexey Kardashevskiy wrote: On 8/1/25 17:28, Ch

Re: [PATCH v4 00/11] Add RISC-V Counter delegation ISA extension support

2025-01-10 Thread Atish Kumar Patra
On Thu, Jan 9, 2025 at 6:10 PM Alistair Francis wrote: > > On Wed, Dec 4, 2024 at 9:18 AM Atish Patra wrote: > > > > This series adds the counter delegation extension support. The counter > > delegation ISA extension(Smcdeleg/Ssccfg) actually depends on multiple ISA > > extensions. > > > > 1. S[m

Re: [PATCH 2/7] guest_memfd: Introduce an object to manage the guest-memfd with RamDiscardManager

2025-01-10 Thread Xu Yilun
On Fri, Jan 10, 2025 at 05:00:22AM +0800, Xu Yilun wrote: > > > > > > https://github.com/aik/qemu/commit/3663f889883d4aebbeb0e4422f7be5e357e2ee46 > > > > > > but I am not sure if this ever saw the light of the day, did not it? > > > (ironically I am using it as a base for encrypted DMA :) ) > >

Re: Subject: [PATCH] loader: Add register setting support via cli

2025-01-10 Thread Philippe Mathieu-Daudé
Hi Sam, On 8/1/25 03:28, Sam Price wrote: I made the changes, and added documentation. https://gitlab.com/thesamprice/qemu/-/compare/master...loader?from_project_id=11167699 I left it as [PREFIX] I can switch this to just RegNumber if desired. I am still struggling with the email format sorry

Re: [PATCH v2 2/2] xen: do not use '%ms' scanf specifier

2025-01-10 Thread David Woodhouse
On Fri, 2025-01-10 at 10:35 +0100, Roger Pau Monne wrote: > The 'm' parameter used to request auto-allocation of the destination variable > is not supported on FreeBSD, and as such leads to failures to parse. > > What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as > it ju

Re: [PATCH v2 1/2] hw/xen: Add xs_node_read() helper function

2025-01-10 Thread Philippe Mathieu-Daudé
On 10/1/25 10:35, Roger Pau Monne wrote: From: David Woodhouse This returns the full contents of the node, having created the node path from the printf-style format string provided in its arguments. This will save various callers from having to do so for themselves (and from using xs_node_scan

Re: [PATCH 2/2] xen: do not use '%ms' scanf specifier

2025-01-10 Thread Philippe Mathieu-Daudé
On 10/1/25 09:08, David Woodhouse wrote: On Thu, 2025-01-09 at 17:55 +0100, Roger Pau Monné wrote: On Thu, Jan 09, 2025 at 11:25:13AM +, David Woodhouse wrote: On Thu, 2025-01-09 at 11:59 +0100, Anthony PERARD wrote:   char label[32];   XenDevice *xendev = NULL;   XenConso

RE: [PATCH v7 0/5] i386: Support SMP Cache Topology

2025-01-10 Thread Alireza Sanaee via
Hi Zhao, Thanks for this quick reiteration. I will prepare the ARM one too. I implemented the ACPI PPTT table to support thread but later when I worked on device tree noticed the mismatch. Will remove those PPTT thread support for now. Alireza -Original Message- From: Zhao Liu Sent

[PATCH v2 2/2] xen: do not use '%ms' scanf specifier

2025-01-10 Thread Roger Pau Monne
The 'm' parameter used to request auto-allocation of the destination variable is not supported on FreeBSD, and as such leads to failures to parse. What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as it just leads to a double allocation of the same string. Instead use xs_

[PATCH v2 1/2] hw/xen: Add xs_node_read() helper function

2025-01-10 Thread Roger Pau Monne
From: David Woodhouse This returns the full contents of the node, having created the node path from the printf-style format string provided in its arguments. This will save various callers from having to do so for themselves (and from using xs_node_scanf() with the non-portable %ms format string

[PATCH v2 0/2] xen: error handling and FreeBSD compatibility fixes

2025-01-10 Thread Roger Pau Monne
Hello, First patch from David introduces a new helper to fetch xenstore nodes, while second patch removes the usage of scanf related functions with the "%ms" format specifier, as it's not supported by the FreeBSD scanf libc implementation. Thanks, Roger. David Woodhouse (1): hw/xen: Add xs_nod

Re: [RFC]: port of embedded x86-mini disassembler to QEMU

2025-01-10 Thread Paolo Bonzini
Il ven 10 gen 2025, 10:52 Michael Clark ha scritto: > a note to announce a port of the x86-mini disassembler to QEMU. > > - https://github.com/michaeljclark/qemu/tree/x86-mini I assume the huge .h files are autogenerated? If so, QEMU cannot use them without including the human-readable sources

Re: [PATCH v4 2/4] qdev-properties: Accept bool for OnOffAuto

2025-01-10 Thread Daniel P . Berrangé
On Wed, Jan 08, 2025 at 03:17:51PM +0900, Akihiko Odaki wrote: > Accept bool literals for OnOffAuto properties for consistency with bool > properties. This enables users to set the "on" or "off" value in a > uniform syntax without knowing whether the "auto" value is accepted. > This behavior is esp

Re: [PATCH v2 3/3] docs/system/arm/virt: mention specific migration information

2025-01-10 Thread Pierrick Bouvier
On 1/10/25 13:29, Philippe Mathieu-Daudé wrote: On 10/1/25 17:30, Peter Maydell wrote: On Thu, 19 Dec 2024 at 18:32, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- docs/system/arm/virt.rst | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/d

[PATCH v3 2/2] hw/char/serial: Convert to three-phase reset

2025-01-10 Thread Philippe Mathieu-Daudé
Convert the TYPE_SERIAL (16550A UART) based devices to three-phase reset. Only local states are reset so use the ResetHold handler, like other legacy devices. TYPE_SERIAL is a plain QDev object: - Implement and register ResetHold - Remove call to serial_reset() in DeviceRealize - Remove qemu_[un]

[PATCH v3 1/2] hw/char/serial: Expose SerialState::irq as QDev GPIO

2025-01-10 Thread Philippe Mathieu-Daudé
Use the QDev GPIO API to set the TYPE_SERIAL output IRQ, this way we don't have to explicitly set the SerialState::irq pointer before realizing the object. Signed-off-by: Philippe Mathieu-Daudé --- hw/char/serial-isa.c | 2 +- hw/char/serial-pci-multi.c | 2 +- hw/char/serial-pci.c |

[PATCH v3 0/2] hw/char/serial: Convert to three-phase reset

2025-01-10 Thread Philippe Mathieu-Daudé
v3 (rework v2's crap): - SerialState::irq is supposed to be a 'protected' field, do not set it from 'outside' of the object, expose it as QDev GPIO. - Manually Reset SerialState from parents, register global reset handler for SERIAL_MM (not on qbus) v2: - Addressed Paolo's comments from v1 (

Re: [PATCH v2 1/2] hw/char/serial: Ensure SerialState::irq is set when realizing

2025-01-10 Thread Philippe Mathieu-Daudé
On 10/1/25 19:27, Philippe Mathieu-Daudé wrote: SerialState::irq must be set by parent when the object is realized. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- hw/char/serial-pci-multi.c | 2 +- hw/char/serial-pci.c | 2 +- hw/char/serial.c | 2 ++

Re: [PATCH v4 1/9] qapi: Make qapi_bool_parse() gracefully handle NULL value

2025-01-10 Thread Daniel P . Berrangé
On Wed, Jan 08, 2025 at 09:04:56PM +0100, Ilya Leoshkevich wrote: > Use g_strcmp0(), so that NULL is considered an invalid parameter value. Why are we calling qapi_bool_parse with a NULL value in the first place ? IMHO this is a sign of a bug higher up the call chain that ought to be fixed, as in

Re: [RFC PATCH v3 02/11] plugins: add API for registering discontinuity callbacks

2025-01-10 Thread Julian Ganz
Hi Alex, January 9, 2025 at 2:57 PM, "Alex Bennée" wrote: > Julian Ganz writes: > > diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h > > index 9c67374b7e..f998a465e5 100644 > > --- a/include/qemu/qemu-plugin.h > > +++ b/include/qemu/qemu-plugin.h > > @@ -273,6 +273,21 @@

Re: [PATCH 10/22] system: propagate Error to gdbserver_start (and other device setups)

2025-01-10 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 9/1/25 20:45, Alex Bennée wrote: >> Pierrick Bouvier writes: >> >>> On 1/9/25 09:06, Alex Bennée wrote: This started as a clean-up to properly pass a Error handler to the gdbserver_start so we could do the right thing for command line and HMP i

Re: [PATCH v5 1/3] libqos/fw_cfg: refactor file directory iteraton to make it more reusable

2025-01-10 Thread Fabiano Rosas
Ani Sinha writes: > fw-cfg file directory iteration code can be used by other functions that may > want to implement fw-cfg file operations. Refactor it into a smaller helper > so that it can be reused. > > No functional change. > > Signed-off-by: Ani Sinha Reviewed-by: Fabiano Rosas

Re: [PATCH v2 50/81] tcg: Add all_outop[]

2025-01-10 Thread Richard Henderson
On 1/9/25 15:21, Philippe Mathieu-Daudé wrote: On 7/1/25 09:00, Richard Henderson wrote: Add infrastructure for more consolidated output of opcodes. The base structure allows for constraints to be either static or dynamic, and for the existence of those constraints to replace TCG_TARGET_HAS_* an

Re: [PATCH 0/7] Enable shared device assignment

2025-01-10 Thread David Hildenbrand
On 10.01.25 15:14, Jason Gunthorpe wrote: On Fri, Jan 10, 2025 at 02:45:39PM +0100, David Hildenbrand wrote: In your commit I read: "Implement the cut operation to be hitless, changes to the page table during cutting must cause zero disruption to any ongoing DMA. This is the expectation of the

Re: [PATCH 22/22] accel/tcg: also suppress asynchronous IRQs for cpu_io_recompile

2025-01-10 Thread Richard Henderson
On 1/9/25 09:06, Alex Bennée wrote: While it would be technically correct to allow an IRQ to happen (as the offending instruction never really completed) it messes up instrumentation. We already take care to only use memory instrumentation on the block, we should also suppress IRQs. Signed-off-b

Re: [RFC PATCH v3 04/11] contrib/plugins: add plugin showcasing new dicontinuity related API

2025-01-10 Thread Julian Ganz
Hi Alex, January 9, 2025 at 3:04 PM, "Alex Bennée" wrote: > Julian Ganz writes: > > We recently introduced new plugin API for registration of discontinuity > > related callbacks. This change introduces a minimal plugin showcasing > > the new API. It simply counts the occurances of interrupts, e

Re: [RFC PATCH v3 11/11] tests: add plugin asserting correctness of discon event's to_pc

2025-01-10 Thread Julian Ganz
Hi Alex, Sorry for tha late reply. January 9, 2025 at 5:33 PM, "Alex Bennée" wrote: > "Julian Ganz" writes: > > (Add Richard to CC) > > > > > Hi Pierrick, > > > > December 5, 2024 at 12:33 AM, "Pierrick Bouvier" wrote: > > > > > > > > On 12/2/24 11:41, Julian Ganz wrote: > > > > +static

Re: [PATCH v4 4/4] virtio: Convert feature properties to OnOffAuto

2025-01-10 Thread Daniel P . Berrangé
On Wed, Jan 08, 2025 at 03:17:53PM +0900, Akihiko Odaki wrote: > Some features are not always available with vhost. Legacy features are > not available with vp_vdpa in particular. virtio devices used to disable > them when not available even if the corresponding properties were > explicitly set to

Re: [PATCH v4 2/4] qdev-properties: Accept bool for OnOffAuto

2025-01-10 Thread Akihiko Odaki
On 2025/01/10 20:09, Daniel P. Berrangé wrote: On Wed, Jan 08, 2025 at 03:17:51PM +0900, Akihiko Odaki wrote: Accept bool literals for OnOffAuto properties for consistency with bool properties. This enables users to set the "on" or "off" value in a uniform syntax without knowing whether the "aut

Re: [PATCH v4 4/4] virtio: Convert feature properties to OnOffAuto

2025-01-10 Thread Akihiko Odaki
On 2025/01/10 20:23, Daniel P. Berrangé wrote: On Wed, Jan 08, 2025 at 03:17:53PM +0900, Akihiko Odaki wrote: Some features are not always available with vhost. Legacy features are not available with vp_vdpa in particular. virtio devices used to disable them when not available even if the corres

Re: [PATCH] hw/misc: cast rpm to uint64_t

2025-01-10 Thread Peter Maydell
On Thu, 26 Dec 2024 at 13:59, Tigran Sogomonian wrote: > > The value of an arithmetic expression > 'rpm * NPCM7XX_MFT_PULSE_PER_REVOLUTION' is a subject > to overflow because its operands are not cast to > a larger data type before performing arithmetic. Thus, need > to cast rpm to uint64_t. > > F

Re: [PATCH v8 1/2] memory: Update inline documentation

2025-01-10 Thread BALATON Zoltan
On Fri, 10 Jan 2025, Akihiko Odaki wrote: Do not refer to "memory region's reference count" - Now MemoryRegions do have their own reference counts, but they will not be used when their owners are not themselves. However, the documentation of memory

Re: [PATCH v7 0/4] tests/qtest: Update tests using PL011 UART

2025-01-10 Thread Peter Maydell
On Fri, 3 Jan 2025 at 17:22, Philippe Mathieu-Daudé wrote: > > (Series fully reviewed) > > Since v6: > - Corrected ASM comment (Fabiano) > > This series split a patch [*] which was previously posted > too compact in multiple trivial steps. The last patch > initializes the PL011 Control register, e

[PULL 04/25] migration/ram: Move RAM_SAVE_FLAG* into ram.h

2025-01-10 Thread Fabiano Rosas
From: Peter Xu Firstly, we're going to use the multifd flag soon in multifd code, so ram.c isn't gonna work. Secondly, we have a separate RDMA flag dangling around, which is definitely not obvious. There's one comment that helps, but not too much. Put all RAM save flags altogether, so nothing

Re: [PATCH v2] hw/arm_sysctl: fix extracting 31th bit of val

2025-01-10 Thread Peter Maydell
On Fri, 20 Dec 2024 at 12:54, Anastasia Belova wrote: > > 1 << 31 is casted to uint64_t while bitwise and with val. > So this value may become 0x8000 but only > 31th "start" bit is required. This can't happen, because the MemoryRegionOps uses the default max access size of 4 bytes, an

Re: [PATCH v4 2/4] qdev-properties: Accept bool for OnOffAuto

2025-01-10 Thread Akihiko Odaki
On 2025/01/10 21:16, Daniel P. Berrangé wrote: On Fri, Jan 10, 2025 at 08:31:57PM +0900, Akihiko Odaki wrote: On 2025/01/10 20:09, Daniel P. Berrangé wrote: On Wed, Jan 08, 2025 at 03:17:51PM +0900, Akihiko Odaki wrote: Accept bool literals for OnOffAuto properties for consistency with bool pr

Re: macaddr: ignore the checking from index to 0xFF

2025-01-10 Thread Peter Maydell
On Tue, 24 Dec 2024 at 03:27, Liu Jaloo wrote: > > bash-5.1$ git diff net/net.c > diff --git a/net/net.c b/net/net.c > index c1bb19a523..af68029428 100644 > --- a/net/net.c > +++ b/net/net.c > @@ -173,6 +173,7 @@ static void qemu_macaddr_set_used(MACAddr *macaddr) > for (index = 0x56; index <

Re: CXL emulation on aarch64

2025-01-10 Thread Jonathan Cameron via
On Fri, 10 Jan 2025 09:20:54 + "Zhijian Li (Fujitsu)" via wrote: > On 10/01/2025 13:29, Itaru Kitayama wrote: > > Hi, > > Is anybody working on the CXL emulation on aarch64? > > I'm not currently working on the CXL emulation on aarch64. > > However, IIRC the CXL maintainer's tree should w

[PULL 01/25] migration/multifd: Fix compile error caused by page_size usage

2025-01-10 Thread Fabiano Rosas
From: Shameer Kolothum >From Commit 90fa121c6c07 ("migration/multifd: Inline page_size and page_count") onwards page_size is not part of MutiFD*Params but uses an inline constant instead. However, it missed updating an old usage, causing a compile error. Fixes: 90fa121c6c07 ("migration/multifd:

[PULL 03/32] tests/functional: add a m68k tuxrun tests

2025-01-10 Thread Alex Bennée
We didn't have this before and as it exercises the m68k virt platform it seems worth adding. We don't wait for the shutdown because QEMU will auto-exit on the shutdown. Cc: Laurent Vivier Cc: Anders Roxell Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-

[PULL 02/32] tests/functional: update the i386 tuxrun tests

2025-01-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-3-alex.ben...@linaro.org> diff --git a/tests/functional/test_i386_tuxrun.py b/tests/functio

[PULL 18/32] tests/functional: remove hacky sleep from the tests

2025-01-10 Thread Alex Bennée
We have proper detection of prompts now so we don't need to guess with sleep() sprinkled through the test. The extra step of calling halt is just to flush the final bits of the log (although the last line is still missed). Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108

[PULL 01/32] tests/functional: update the arm tuxrun tests

2025-01-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-2-alex.ben...@linaro.org> diff --git a/tests/functional/test_arm_tuxrun.py b/tests/function

[PULL 09/32] tests/functional: update the ppc64 tuxrun tests

2025-01-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-10-alex.ben...@linaro.org> diff --git a/tests/functional/test_ppc64_tuxrun.py b/tests/funct

[PULL 14/32] tests/functional: update the x86_64 tuxrun tests

2025-01-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-15-alex.ben...@linaro.org> diff --git a/tests/functional/test_x86_64_tuxrun.py b/tests/func

[PULL 11/32] tests/functional: update the riscv64 tuxrun tests

2025-01-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Note we re-use the riscv32 kernel and rootfs for test_riscv64_rv32. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-12-alex.ben...@linaro.org

[PULL 06/32] tests/functional: update the mips64 tuxrun tests

2025-01-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-7-alex.ben...@linaro.org> diff --git a/tests/functional/test_mips64_tuxrun.py b/tests/funct

[PULL 31/32] dockerfiles: Remove 'MAINTAINER' entry in debian-tricore-cross.docker

2025-01-10 Thread Alex Bennée
From: Philippe Mathieu-Daudé AMSAT closed its email service [*] so my personal email address is now defunct. Remove it to avoid bouncing emails. [*] https://web.archive.org/web/20240617194936/https://forum.amsat-dl.org/index.php?thread/4581-amsat-mail-alias-service-to-end-august-1-2024/ Signed

[PULL 07/32] tests/functional: update the mips64el tuxrun tests

2025-01-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-8-alex.ben...@linaro.org> diff --git a/tests/functional/test_mips64el_tuxrun.py b/tests/fun

[PULL 24/32] tests/lcitool: bump to latest version of libvirt-ci

2025-01-10 Thread Alex Bennée
We will shortly need this to build our riscv64 cross container. However to keep the delta down just do the bump first. As ccache4 is now preferred for FreeBSD to get the latest version there is a little update in the FreeBSD metadata. Reviewed-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Me

[PULL 10/32] tests/functional: update the riscv32 tuxrun tests

2025-01-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-11-alex.ben...@linaro.org> diff --git a/tests/functional/test_riscv32_tuxrun.py b/tests/fun

[PATCH v7 RESEND 0/5] i386: Support SMP Cache Topology

2025-01-10 Thread Zhao Liu
Hi folks, This is my v7 resend version (updated the commit message of origin v7's Patch 1). Compared with v6 [1], v7 dropped the "thread" level cache topology (cache per thread): - Patch 1 is the new patch to reject "thread" parameter for smp-cache. - Ptach 2 dropped cache per thread support.

[PATCH v7 RESEND 1/5] hw/core/machine: Reject thread level cache

2025-01-10 Thread Zhao Liu
Currently, neither i386 nor ARM have real hardware support for per- thread cache, and there is no clear demand for this specific cache topology. Additionally, since ARM even can't support this special cache topology in device tree, it is unnecessary to support it at this moment, even though per-th

[PATCH v7 RESEND 4/5] i386/pc: Support cache topology in -machine for PC machine

2025-01-10 Thread Zhao Liu
Allow user to configure l1d, l1i, l2 and l3 cache topologies for PC machine. Additionally, add the document of "-machine smp-cache" in qemu-options.hx. Signed-off-by: Zhao Liu Tested-by: Yongwei Ma Reviewed-by: Jonathan Cameron --- Changes since Patch v6: * Deleted the "thread" level from the

[PATCH v7 RESEND 5/5] i386/cpu: add has_caches flag to check smp_cache configuration

2025-01-10 Thread Zhao Liu
From: Alireza Sanaee Add has_caches flag to SMPCompatProps, which helps in avoiding extra checks for every single layer of caches in x86 (and ARM in future). Signed-off-by: Alireza Sanaee Signed-off-by: Zhao Liu Reviewed-by: Jonathan Cameron --- Note: Picked from Alireza's series with the cha

[PATCH v7 RESEND 3/5] i386/cpu: Update cache topology with machine's configuration

2025-01-10 Thread Zhao Liu
User will configure smp cache topology via -machine smp-cache. For this case, update the x86 CPUs' cache topology with user's configuration in MachineState. Signed-off-by: Zhao Liu Tested-by: Yongwei Ma Reviewed-by: Jonathan Cameron --- Changes since Patch v3: * Updated MachineState.smp_cache

[PATCH 6/9] ppc/ppc405: Remove timer support

2025-01-10 Thread Cédric Le Goater
Since the 405 CPU family was phased out, these timer models have no users anymore. Signed-off-by: Cédric Le Goater --- include/hw/ppc/ppc.h | 15 --- target/ppc/cpu.h | 7 - target/ppc/helper.h | 4 - target/ppc/spr_common.h | 4 - hw/ppc/ppc.c

[PATCH 5/9] ppc/ppc405: Remove 40x exception model

2025-01-10 Thread Cédric Le Goater
This exception model was only used by the 405 CPU family which was removed. The rest of the PPC 4xx CPUs use the BookE exception model. Signed-off-by: Cédric Le Goater --- target/ppc/cpu.h | 8 +-- target/ppc/helper.h | 1 - target/ppc/cpu_init.c| 11 target/ppc/excp_h

[PATCH v7 RESEND 2/5] i386/cpu: Support module level cache topology

2025-01-10 Thread Zhao Liu
Allow cache to be defined at the module level. This increases flexibility for x86 users to customize their cache topology. Signed-off-by: Zhao Liu Tested-by: Yongwei Ma Reviewed-by: Jonathan Cameron --- Changes since Patch v6: * Dropped "thread" level cache topology support. --- target/i386/c

[PULL 00/32] testing updates for 10.0 (tuxrun, libvirt, dockerfiles, misc)

2025-01-10 Thread Alex Bennée
The following changes since commit bc6afa1c711da5b4f37c9685a812c77b114d84cb: Merge tag 'pull-xenfv-20250109-1' of https://gitlab.com/dwmw2/qemu into staging (2025-01-09 08:39:32 -0500) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git tags/pull-10.0-testing-updates

[PULL 27/32] tests/vm: fix build_path based path

2025-01-10 Thread Alex Bennée
We no longer need to go into the per-arch build directories to find the build directories binary. Lets call it directly. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-28-alex.ben...@linaro.org> diff --git a/tests/vm/basevm.py b/tests/vm/basev

[PULL 25/32] tests/docker: move riscv64 cross container from sid to trixie

2025-01-10 Thread Alex Bennée
Although riscv64 isn't going to be a release architecture for trixie the packages are still built while it is testing. Moving from sid will also avoid some of the volatility we get from tracking the bleeding edge. Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-26-alex.ben...@linar

[PULL 13/32] tests/functional: update the sparc64 tuxrun tests

2025-01-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-14-alex.ben...@linaro.org> diff --git a/tests/functional/test_sparc64_tuxrun.py b/tests/fun

[PULL 20/32] tests/functional: update tuxruntest to use uncompress utility

2025-01-10 Thread Alex Bennée
Use the utility functions to reduce code duplication. Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-21-alex.ben...@linaro.org> diff --git a/tests/functional/qemu_test/tuxruntest.py b/tests/functional/qemu_test/tuxruntest.py index 7227a83757..41a4945a14

[PULL 23/32] tests/functional: extend test_aarch64_virt with vulkan test

2025-01-10 Thread Alex Bennée
Now that we have virtio-gpu Vulkan support, let's add a test for it. Currently this is using images build by buildroot: https://lists.buildroot.org/pipermail/buildroot/2024-December/768196.html Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-24-alex.ben

[PULL 21/32] tests/functional: remove unused kernel_command_line

2025-01-10 Thread Alex Bennée
The Alpine test boots from the CDROM so we don't --append a command line. Drop the unused code. Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-22-alex.ben...@linaro.org> diff --git a/tests/functional/test_aarch64_virt.py b/tests/functional/test_aarch64_

[PULL 16/32] tests/qtest: remove clock_steps from virtio tests

2025-01-10 Thread Alex Bennée
In the qtest environment time will not step forward if the system is paused (timers disabled) or we have no timer events to fire. As a result VirtIO events are responded to directly and we don't need to step time forward. We still do timeout processing to handle the fact the target QEMU may not be

Re: [PATCH 0/7] Enable shared device assignment

2025-01-10 Thread Jason Gunthorpe
On Fri, Jan 10, 2025 at 09:26:02AM +0100, David Hildenbrand wrote: > > > > > > > > > > One limitation (also discussed in the guest_memfd > > > > > > > > > > meeting) is that VFIO expects the DMA mapping for > > > > > > > > > > a specific IOVA to be mapped and unmapped with the > > > > > > > > > > s

[PULL 19/32] tests/functional: add zstd support to uncompress utility

2025-01-10 Thread Alex Bennée
Rather than using the python library (which has a different API anyway) lets just call the binary. zstdtools is already in out qemu.yml so all test containers should have it around. Tests should still use @skipIfMissingCommands('zstd') to gracefully handle when only minimal dependencies have been i

[PULL 12/32] tests/functional: update the s390x tuxrun tests

2025-01-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-13-alex.ben...@linaro.org> diff --git a/tests/functional/test_s390x_tuxrun.py b/tests/funct

[PULL 04/32] tests/functional: update the mips32 tuxrun tests

2025-01-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20250108121054.1126164-5-alex.ben...@linaro.org> diff --git a/tests/functional/test_mips_tuxrun.py b/tests/functio

  1   2   3   4   >