Re: or1k -M virt -hda and net.

2025-01-08 Thread Geert Uytterhoeven
Hi Rob, On Tue, Jan 7, 2025 at 11:53 PM Rob Landley wrote: > Microblaze has no /dev/?da (as in there's no device I could attach it to > even with the long option, I'd have to use NBD), sh4eb has -hda is > working but it's having some endianness hiccup with the network card > (works in sh4 but not

Re: [PATCH] system: Try hardware accelerators (KVM, HVF) before software one (TCG)

2025-01-08 Thread Phil Dennis-Jordan
On Mon, 6 Jan 2025 at 19:43, Daniel P. Berrangé wrote: > On Sat, Jan 04, 2025 at 12:28:14PM +0100, Phil Dennis-Jordan wrote: > > On Fri, 3 Jan 2025 at 16:16, Daniel P. Berrangé > wrote: > > > > > On Fri, Jan 03, 2025 at 04:05:58PM +0100, Philippe Mathieu-Daudé wrote: > > > > As Daniel suggested

[PULL 08/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.7 machine type

2025-01-08 Thread Thomas Huth
The s390-ccw-virtio-2.7 machine is older than 6 years, so according to our machine support policy, it can be removed now. Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Message-ID: <20250103144232.520383-8-th...@redhat.com> Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c

[PULL 03/14] hw/s390x/s390-skeys: Remove the "migration-enabled" property

2025-01-08 Thread Thomas Huth
This property was only set to "off" by the old s390-ccw-virtio-2.4 machine type which has now been removed. So we can now remove the property and the related code, too. Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Message-ID: <20250103144232.520383-3-th...@redhat.com> Signed-off-by

[PULL 07/14] hw/s390x/css-bridge: Remove the "css_dev_path" property

2025-01-08 Thread Thomas Huth
Now that the s390-ccw-virtio-2.6 and older machine types have been removed, the "css_dev_path" property of the css-bridge is also not used anymore and thus can be removed. This way we finally get rid of the problem that has been described in: https://gitlab.com/qemu-project/qemu/-/issues/2213 Rev

[PULL 11/14] hw/s390x: Remove the "adapter_routes_max_batch" property from the flic

2025-01-08 Thread Thomas Huth
Now that the s390-ccw-virtio-2.8 machine has been removed, we don't need the "adapter_routes_max_batch" property anymore and can remove it. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Message-ID: <202501031442

[PULL 02/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.4 and 2.5 machine types

2025-01-08 Thread Thomas Huth
They are older than 6 years, so according to our machine support policy, they can be removed now. This removes the requirements for the storage keys "migration-enabled" property which will be removed in the next patch. It also removes the code that sets "max_revision" to 0 for some CCW devices, bu

[PULL 04/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.6 machine type

2025-01-08 Thread Thomas Huth
The s390-ccw-virtio-2.6 machine is older than 6 years, so according to our machine support policy, it can be removed now. Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Message-ID: <20250103144232.520383-4-th...@redhat.com> Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c

[PULL 13/14] docs/about/deprecated: Remove paragraph about initial deprecation in 2.10

2025-01-08 Thread Thomas Huth
When we introduced the deprecation rule of keeping deprecated features for two more releases, we had to state that we would not remove features by surprise that had already been marked as deprecated before. Nowadays, this paragraph is not needed anymore, so we can remove it now. Reviewed-by: Danie

[PULL 09/14] hw/s390x: Remove the cpu_model_allowed flag and related code

2025-01-08 Thread Thomas Huth
Now that the last machine type that disabled cpu_model_allowed has been removed, we can also remove the cpu_model_allowed flag itself and all the related conditional code. Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Message-ID: <20250103144232.520383-9-th...@redhat.com> Signed-off

[PULL 05/14] hw/s390x: Remove the "ri_allowed" switch

2025-01-08 Thread Thomas Huth
Only s390-ccw-virtio-2.6 and older used to set this switch to "off", for newer machine types it is always enabled. Since we removed the old machine types now, we can also remove the switch in the code and assume that it is always enabled now. Reviewed-by: Cornelia Huck Acked-by: Christian Borntra

[PULL 06/14] hw/s390x/ipl: Remove the "iplbext_migration" property

2025-01-08 Thread Thomas Huth
Now that the old machine types that used this property have been removed, we can remove the property and the corresponding code. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Message-ID: <20250103144232.520383-6

[PULL 12/14] Remove the deprecated "-runas" command line option

2025-01-08 Thread Thomas Huth
It has been marked as deprecated two releases ago, so it should be fine now to remove this command line option. Reviewed-by: Daniel P. Berrangé Message-ID: <20250103155411.721759-1-th...@redhat.com> Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6 -- docs/about/removed-f

[PULL 01/14] tests/tcg/s390x: Use the SLOF libc headers for the multiarch tests

2025-01-08 Thread Thomas Huth
From: Ilya Leoshkevich Compiling the s390x tests on Fedora, which has the s390x cross-compiler installed, fails with: In file included from qemu/tests/tcg/s390x/console.c:8: qemu/tests/tcg/s390x/../../../pc-bios/s390-ccw/sclp.c:11:10: fatal error: string.h: No such file or directory

[PULL 14/14] tests/functional/test_x86_64_hotplug_cpu: Fix race condition during unplug

2025-01-08 Thread Thomas Huth
When unplugging the CPU, the test tries to check for a successful unplug by changing to the /sys/devices/system/cpu/cpu1 directory to see whether that fails. However, the "cd" could be faster than the unplug operation in the kernel, so there is a race condition and the test sometimes fails here. Fi

[PULL 00/14] Fixes for tests and removal of deprecated features

2025-01-08 Thread Thomas Huth
The following changes since commit 6528013b5f5ba6bb3934b7f5fe57a3110680530f: Merge tag 'qga-pull-2025-01-06' of https://github.com/kostyanf14/qemu into staging (2025-01-06 09:39:02 -0500) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2025-01-08

[PULL 10/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.8 machine type

2025-01-08 Thread Thomas Huth
The s390-ccw-virtio-2.8 machine is older than 6 years, so according to our machine support policy, it can be removed now. Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Message-ID: <20250103144232.520383-10-th...@redhat.com> Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c

Re: [RFC PATCH 8/9] rust: pl011: switch vmstate to new-style macros

2025-01-08 Thread Zhao Liu
On Tue, Dec 31, 2024 at 01:23:35AM +0100, Paolo Bonzini wrote: > Date: Tue, 31 Dec 2024 01:23:35 +0100 > From: Paolo Bonzini > Subject: [RFC PATCH 8/9] rust: pl011: switch vmstate to new-style macros > X-Mailer: git-send-email 2.47.1 > > Signed-off-by: Paolo Bonzini > --- > rust/hw/char/pl011/s

Re: [RFC PATCH 9/9] rust: vmstate: remove translation of C vmstate macros

2025-01-08 Thread Zhao Liu
On Tue, Dec 31, 2024 at 01:23:36AM +0100, Paolo Bonzini wrote: > Date: Tue, 31 Dec 2024 01:23:36 +0100 > From: Paolo Bonzini > Subject: [RFC PATCH 9/9] rust: vmstate: remove translation of C vmstate > macros > X-Mailer: git-send-email 2.47.1 > > Keep vmstate_clock!; because it uses a field of ty

Re: [PATCH v3 0/3] Introduce a new Write Protected pin inverted property

2025-01-08 Thread Cédric Le Goater
On 1/7/25 23:36, Peter Maydell wrote: On Tue, 7 Jan 2025 at 17:55, Cédric Le Goater wrote: Hello, I would not recommend using qemu_irq_invert() in new code. I guess in an ideal world we'd implement a QOM object that encapsulated the the "not gate" logic, similar to TYPE_OR_IRQ. (Though for

[PATCH 02/14] hw/char/imx_serial: Fix reset value of UFCR register

2025-01-08 Thread Bernhard Beschow
The value of the UCFR register is respected when echoing characters to the terminal, but its reset value is reserved. Fix the reset value to the one documented in the datasheet. While at it move the related attribute out of the section of unimplemented registers since its value is actually respect

[PATCH 00/14] i.MX and SDHCI improvements

2025-01-08 Thread Bernhard Beschow
This series fixes some details in i.MX platform devices, improves SDHCI compatibility with U-Boot and modernizes some code. The first 6 patches are bugfixes 1/ resolving infinite loop in U-Boot esdhc driver, 2/ fixing a character echoing issue in imx-serial, 3/ fixing IRQ sharing issue in Designwa

[PATCH 01/14] hw/sd/sdhci: Set SDHC_NIS_DMA bit when appropriate

2025-01-08 Thread Bernhard Beschow
In U-Boot, the fsl_esdhc[_imx] driver waits for both "transmit completed" and "DMA" bits in esdhc_send_cmd_common() by means of DATA_COMPLETE constant. QEMU currently misses to set the DMA bit which causes the driver to loop forever. Fix that by setting the DMA bit if enabled when doing DMA block t

[PATCH 14/14] hw/gpio/imx_gpio: Turn DPRINTF() into trace events

2025-01-08 Thread Bernhard Beschow
While at it add a trace event for input GPIO events. Signed-off-by: Bernhard Beschow --- hw/gpio/imx_gpio.c | 16 +--- hw/gpio/trace-events | 5 + 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/hw/gpio/imx_gpio.c b/hw/gpio/imx_gpio.c index 67c47a7280..f77132f

[PATCH 10/14] hw/timer/imx_gpt: Remove unused define

2025-01-08 Thread Bernhard Beschow
Signed-off-by: Bernhard Beschow --- hw/timer/imx_gpt.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/timer/imx_gpt.c b/hw/timer/imx_gpt.c index 2663a9d9ef..11eca9fa4d 100644 --- a/hw/timer/imx_gpt.c +++ b/hw/timer/imx_gpt.c @@ -20,10 +20,6 @@ #include "qemu/log.h" #include "trace.h"

[PATCH 08/14] hw/sd/sd: Allow for inverting polarities of presence and write-protect GPIOs

2025-01-08 Thread Bernhard Beschow
Signed-off-by: Bernhard Beschow --- hw/sd/sd.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index aa8d86e1af..a50e5c20c8 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -181,6 +181,8 @@ struct SDState { qemu_irq inserted_cb; QEMUTi

[PATCH 05/14] hw/pci-host/designware: Expose MSI IRQ

2025-01-08 Thread Bernhard Beschow
Fixes INTD and MSI interrupts poking the same IRQ line without keeping track of each other's IRQ level. Furthermore, SoCs such as the i.MX 8M Plus don't share the MSI IRQ with the INTx lines, so expose it as a dedicated pin. Signed-off-by: Bernhard Beschow --- include/hw/arm/fsl-imx6.h|

[PATCH 07/14] hw/sd/sd: Remove legacy sd_set_cb() in favor of GPIOs

2025-01-08 Thread Bernhard Beschow
Commit ce5dd27534b0 "hw/sd: Remove omap2_mmc device" removed the last user of sd_set_cb(). Rework this functionality into GPIOs. Signed-off-by: Bernhard Beschow --- include/hw/sd/sdcard_legacy.h | 1 - hw/sd/sd.c| 31 ++- 2 files changed, 14 inser

[PATCH 13/14] hw/misc/imx6_src: Convert DPRINTF() to trace events

2025-01-08 Thread Bernhard Beschow
Signed-off-by: Bernhard Beschow --- hw/misc/imx6_src.c | 23 +-- hw/misc/trace-events | 6 ++ 2 files changed, 11 insertions(+), 18 deletions(-) diff --git a/hw/misc/imx6_src.c b/hw/misc/imx6_src.c index dc6a2b92ba..06cc46292e 100644 --- a/hw/misc/imx6_src.c +++ b/hw/m

[PATCH 06/14] hw/gpio/imx_gpio: Don't clear input GPIO values upon reset

2025-01-08 Thread Bernhard Beschow
Input GPIO values such as a present SD card may get notified before the GPIO controller itself gets reset. Claring the input values thus loses data. Assuming that input GPIO events are only fired when the state changes, the input values shouldn't be reset. Signed-off-by: Bernhard Beschow --- hw/

[PATCH] hw/sd/sdcard: Remove sd_set_cb()

2025-01-08 Thread Cédric Le Goater
Last user of sd_set_cb() was removed in commit ce5dd27534b0 ("hw/sd: Remove omap2_mmc device"). Signed-off-by: Cédric Le Goater --- include/hw/sd/sdcard_legacy.h | 1 - hw/sd/sd.c| 8 2 files changed, 9 deletions(-) diff --git a/include/hw/sd/sdcard_legacy.h b/inclu

[PULL 1/1] hw/acpi: Add vmclock device

2025-01-08 Thread David Woodhouse
From: David Woodhouse The vmclock device addresses the problem of live migration with precision clocks. The tolerances of a hardware counter (e.g. TSC) are typically around ±50PPM. A guest will use NTP/PTP/PPS to discipline that counter against an external source of 'real' time, and track the pre

[PULL 0/1] vmclock queue

2025-01-08 Thread David Woodhouse
sers/dwmw2/qemu.git tags/pull-vmclock-20250108 for you to fetch changes up to 6502ea82b26dc28c83fbc9c766af7a408a8ca827: hw/acpi: Add vmclock device (2025-01-07 16:22:04 +) Add vmcl

Re: [PATCH v3 3/4] target/ppc: Move VSX vector storage access insns to decodetree.

2025-01-08 Thread Mark Cave-Ayland
On 18/06/2024 09:58, Chinmay Rath wrote: (resend due to qemu list outage during December) Moving the following instructions to decodetree specification: lxv{b16, d2, h8, w4, ds, ws}x : X-form stxv{b16, d2, h8, w4}x : X-form The changes were verified by validating that the tcg

[PATCH 21/26] vfio-user: dma map/unmap operations

2025-01-08 Thread John Levon
From: John Levon Implement DMA map/unmap for the vfio-user container. Add ability to do async operations during memory transactions. Originally-by: John Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Signed-off-by: John Levon --- hw/vfio/trace-events | 4 ++

[PATCH v4 08/32] tests/functional: update the ppc32 tuxrun tests

2025-01-08 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-29-alex.ben...@linaro.org> --- tests/functional/test_ppc_tuxrun.py | 8 1 file chang

[PATCH v4 02/32] tests/functional: update the i386 tuxrun tests

2025-01-08 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-23-alex.ben...@linaro.org> --- tests/functional/test_i386_tuxrun.py | 8 1 file chan

[PATCH v4 05/32] tests/functional: update the mips32el tuxrun tests

2025-01-08 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-26-alex.ben...@linaro.org> --- tests/functional/test_mipsel_tuxrun.py | 8 1 file ch

[PATCH v4 03/32] tests/functional: add a m68k tuxrun tests

2025-01-08 Thread Alex Bennée
We didn't have this before and as it exercises the m68k virt platform it seems worth adding. We don't wait for the shutdown because QEMU will auto-exit on the shutdown. Cc: Laurent Vivier Cc: Anders Roxell Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-2

[PATCH v4 10/32] tests/functional: update the riscv32 tuxrun tests

2025-01-08 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-31-alex.ben...@linaro.org> --- tests/functional/test_riscv32_tuxrun.py | 8 1 file c

[PATCH v4 22/32] tests/functional: bail aarch64_virt tests early if missing TCG

2025-01-08 Thread Alex Bennée
The set_machine and require_accelerator steps can bail early so move those to the front of the test functions. While we are at it also clean up some long lines when adding the vm arguments. Signed-off-by: Alex Bennée --- tests/functional/test_aarch64_virt.py | 11 +++ 1 file changed, 7 i

[PATCH v4 31/32] dockerfiles: Remove 'MAINTAINER' entry in debian-tricore-cross.docker

2025-01-08 Thread Alex Bennée
From: Philippe Mathieu-Daudé AMSAT closed its email service [*] so my personal email address is now defunct. Remove it to avoid bouncing emails. [*] https://web.archive.org/web/20240617194936/https://forum.amsat-dl.org/index.php?thread/4581-amsat-mail-alias-service-to-end-august-1-2024/ Signed

[PATCH v4 07/32] tests/functional: update the mips64el tuxrun tests

2025-01-08 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-28-alex.ben...@linaro.org> --- tests/functional/test_mips64el_tuxrun.py | 8 1 file

[PATCH v4 15/32] tests/functional/aarch64: add tests for FEAT_RME

2025-01-08 Thread Alex Bennée
From: Pierrick Bouvier This boot an OP-TEE environment, and launch a nested guest VM inside it using the Realms feature. We do it for virt and sbsa-ref platforms. Signed-off-by: Pierrick Bouvier Message-Id: <20241220165212.3653495-1-pierrick.bouv...@linaro.org> [AJB: tweak ordering of setup] Si

[PATCH v4 23/32] tests/functional: extend test_aarch64_virt with vulkan test

2025-01-08 Thread Alex Bennée
Now that we have virtio-gpu Vulkan support, let's add a test for it. Currently this is using images build by buildroot: https://lists.buildroot.org/pipermail/buildroot/2024-December/768196.html Signed-off-by: Alex Bennée --- v2 - use decorator for has_cmd(zstd) - un-handled->unhandled -

[PATCH v4 21/32] tests/functional: remove unused kernel_command_line

2025-01-08 Thread Alex Bennée
The Alpine test boots from the CDROM so we don't --append a command line. Drop the unused code. Signed-off-by: Alex Bennée --- tests/functional/test_aarch64_virt.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/functional/test_aarch64_virt.py b/tests/functional/test_aarch64_virt.py

[PATCH v4 12/32] tests/functional: update the s390x tuxrun tests

2025-01-08 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-33-alex.ben...@linaro.org> --- tests/functional/test_s390x_tuxrun.py | 8 1 file cha

[PATCH v4 13/32] tests/functional: update the sparc64 tuxrun tests

2025-01-08 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-34-alex.ben...@linaro.org> --- tests/functional/test_sparc64_tuxrun.py | 8 1 file c

[PATCH v4 01/32] tests/functional: update the arm tuxrun tests

2025-01-08 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-21-alex.ben...@linaro.org> --- tests/functional/test_arm_tuxrun.py | 28 ++---

[PATCH v4 18/32] tests/functional: remove hacky sleep from the tests

2025-01-08 Thread Alex Bennée
We have proper detection of prompts now so we don't need to guess with sleep() sprinkled through the test. The extra step of calling halt is just to flush the final bits of the log (although the last line is still missed). Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth --- v2 - avoid lon

[PATCH v4 04/32] tests/functional: update the mips32 tuxrun tests

2025-01-08 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-25-alex.ben...@linaro.org> --- tests/functional/test_mips_tuxrun.py | 8 1 file chan

[PATCH v4 14/32] tests/functional: update the x86_64 tuxrun tests

2025-01-08 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-35-alex.ben...@linaro.org> --- tests/functional/test_x86_64_tuxrun.py | 8 1 file ch

[PATCH v2] hw/i386/pc: Fix level interrupt sharing for Xen event channel GSI

2025-01-08 Thread David Woodhouse
From: David Woodhouse The system GSIs are not designed for sharing. One device might assert a shared interrupt with qemu_set_irq() and another might deassert it, and the level from the first device is lost. This could be solved by refactoring the x86 GSI code to use an OrIrq device, but that sti

[PATCH v4 06/32] tests/functional: update the mips64 tuxrun tests

2025-01-08 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-27-alex.ben...@linaro.org> --- tests/functional/test_mips64_tuxrun.py | 8 1 file ch

[PATCH v4 30/32] pc-bios: ensure keymaps dependencies set vnc tests

2025-01-08 Thread Alex Bennée
I was seeing failures on vnc-display-test on FreeBSD: make vm-build-freebsd V=1 TARGET_LIST=aarch64-softmmu BUILD_TARGET=check-qtest QEMU_LOCAL=1 DEBUG=1 Leads to: qemu-system-aarch64: -vnc none: could not read keymap file: 'en-us' Broken pipe ../src/tests/qtest/libqtest.c:196: kill_qem

[PATCH v4 16/32] tests/qtest: remove clock_steps from virtio tests

2025-01-08 Thread Alex Bennée
In the qtest environment time will not step forward if the system is paused (timers disabled) or we have no timer events to fire. As a result VirtIO events are responded to directly and we don't need to step time forward. We still do timeout processing to handle the fact the target QEMU may not be

[PATCH v4 09/32] tests/functional: update the ppc64 tuxrun tests

2025-01-08 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-30-alex.ben...@linaro.org> --- tests/functional/test_ppc64_tuxrun.py | 16 1

[PATCH] virtio-net: Fix num_buffers for version 1

2025-01-08 Thread Akihiko Odaki
The specification says the device MUST set num_buffers to 1 if VIRTIO_NET_F_MRG_RXBUF has not been negotiated. Fixes: df91055db5c9 ("virtio-net: enable virtio 1.0") Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/virtio-net.c b/hw

[PATCH v4 29/32] tests/vm: allow interactive login as root

2025-01-08 Thread Alex Bennée
This is useful when debugging and you want to add packages to an image. Signed-off-by: Alex Bennée --- tests/vm/Makefile.include | 3 ++- tests/vm/basevm.py| 9 +++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include

[PATCH v4 24/32] tests/lcitool: bump to latest version of libvirt-ci

2025-01-08 Thread Alex Bennée
We will shortly need this to build our riscv64 cross container. However to keep the delta down just do the bump first. As ccache4 is now preferred for FreeBSD to get the latest version there is a little update in the FreeBSD metadata. Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé --

[PATCH v4 27/32] tests/vm: fix build_path based path

2025-01-08 Thread Alex Bennée
We no longer need to go into the per-arch build directories to find the build directories binary. Lets call it directly. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- tests/vm/basevm.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/vm/basevm.py

[PATCH v4 28/32] tests/vm: partially un-tabify help output

2025-01-08 Thread Alex Bennée
While the make syntax itself uses tabs having a mixture of tabs and spaces in the vm-help output make no sense and confuses things lining up between terminal and editor. Fix that. Signed-off-by: Alex Bennée --- tests/vm/Makefile.include | 26 +- 1 file changed, 13 inserti

[PATCH v7 3/5] i386/cpu: Update cache topology with machine's configuration

2025-01-08 Thread Zhao Liu
User will configure smp cache topology via -machine smp-cache. For this case, update the x86 CPUs' cache topology with user's configuration in MachineState. Signed-off-by: Zhao Liu Tested-by: Yongwei Ma Reviewed-by: Jonathan Cameron --- Changes since Patch v3: * Updated MachineState.smp_cache

[PATCH v7 2/5] i386/cpu: Support module level cache topology

2025-01-08 Thread Zhao Liu
Allow cache to be defined at the module level. This increases flexibility for x86 users to customize their cache topology. Signed-off-by: Zhao Liu Tested-by: Yongwei Ma Reviewed-by: Jonathan Cameron --- Changes since Patch v6: * Dropped "thread" level cache topology support. --- target/i386/c

[PATCH v7 0/5] i386: Support SMP Cache Topology

2025-01-08 Thread Zhao Liu
Hi folks, This is my v7. Compared with v6 [1], v7 dropped the "thread" level cache topology (cache per thread): - Patch 1 is the new patch to reject "thread" parameter for smp-cache. - Ptach 2 dropped cache per thread support. (Others remain unchanged.) There're several reasons: * Currentl

[PATCH v7 4/5] i386/pc: Support cache topology in -machine for PC machine

2025-01-08 Thread Zhao Liu
Allow user to configure l1d, l1i, l2 and l3 cache topologies for PC machine. Additionally, add the document of "-machine smp-cache" in qemu-options.hx. Signed-off-by: Zhao Liu Tested-by: Yongwei Ma Reviewed-by: Jonathan Cameron --- Changes since Patch v6: * Deleted the "thread" level from the

[PATCH v7 1/5] hw/core/machine: Reject thread level cache

2025-01-08 Thread Zhao Liu
Currently, neither i386 nor ARM have real hardware support for per- thread cache, and there is no clear demand for this specific cache topology. Additionally, since supporting this special cache topology on ARM requires extra effort [1], it is unnecessary to support it at this moment, even though

[PATCH v8 0/1] target/riscv: rvv: Use wider accesses for unit stride load/store

2025-01-08 Thread Craig Blackmore
Thanks Richard for the review on v7. I have updated the patch based on your suggestions. Changes since v7: - Remove CONFIG_INT128_TYPE guards. - Strengthen condition for using atomic128. - Use memcpy for misaligned accesses. - Hoist atomic operation selection higher up the call stack. Previous v

[PATCH v8 1/1] target/riscv: rvv: Use wider accesses for unit stride load/store

2025-01-08 Thread Craig Blackmore
Use atomic load/store functions to access multiple elements from host. Co-authored-by: Paolo Savini Signed-off-by: Paolo Savini Signed-off-by: Craig Blackmore --- target/riscv/vector_helper.c | 90 1 file changed, 82 insertions(+), 8 deletions(-) diff --g

Re: 86_64 host is not supported by hypervisor - 2024

2025-01-08 Thread Adam
Will respond shortly.  Doing additional troubleshooting at the moment. I copied in a backup from 02JAN24.  And, I tried to create a new XML for same with a different name vFRANK2 vs vFRANK.  Prior to creating it, I specified in the virt-manager to use host-passthrough for the cpu.  However, up

Re: [PATCH 6/7] migration: Fix arrays of pointers in JSON writer

2025-01-08 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Jan 08, 2025 at 10:52:30AM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Tue, Jan 07, 2025 at 04:50:24PM -0300, Fabiano Rosas wrote: >> >> Currently, if an array of pointers contains a NULL pointer, that >> >> pointer will be encoded as '0' in the stream.

Re: [PATCH 04/14] hw/core: Introduce TYPE_SHARED_IRQ

2025-01-08 Thread BALATON Zoltan
On Wed, 8 Jan 2025, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow --- include/hw/core/shared-irq.h | 39 hw/core/shared-irq.c | 88 hw/core/Kconfig | 3 ++ hw/core/meson.build | 1 + 4 files changed, 131

Re: [PATCH 6/7] migration: Fix arrays of pointers in JSON writer

2025-01-08 Thread Fabiano Rosas
Peter Xu writes: > On Tue, Jan 07, 2025 at 04:50:24PM -0300, Fabiano Rosas wrote: >> Currently, if an array of pointers contains a NULL pointer, that >> pointer will be encoded as '0' in the stream. Since the JSON writer >> doesn't define a "pointer" type, that '0' will now be an uint64, which >>

Re: [PATCH 3/7] migration: Document the effect of vmstate_info_nullptr

2025-01-08 Thread Peter Xu
On Wed, Jan 08, 2025 at 10:31:05AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Tue, Jan 07, 2025 at 04:50:21PM -0300, Fabiano Rosas wrote: > >> The migration stream lacks magic numbers at some key points. It's easy > >> to mis-parse data. Unfortunately, the VMS_NULLPTR_MARKER continue

Re: [PULL 23/29] ui & main loop: Redesign of system-specific main thread event handling

2025-01-08 Thread David Woodhouse
On Tue, 2024-12-31 at 21:22 +0100, Philippe Mathieu-Daudé wrote: > > This change tidies up main thread management to be more flexible. > >  * The qemu_main global function pointer is a custom function for the >    main thread, and it may now be NULL. When it is, the main thread >    runs the main

Re: [PATCH v2 00/21] hw/uefi: add uefi variable service

2025-01-08 Thread Gerd Hoffmann
Hi, > > Typically the kind of new code that I wish would be in Rust. But I > > suppose it is too early yet, and you came to the same conclusion. > > Probably a good candidate for rewrite though! > > Perhaps too early for the device impl, but I would have thought > the general var-service code c

86_64 host is not supported by hypervisor - 2024

2025-01-08 Thread Adam
TWIMC: Had an issue with VM networking that turned out to be the host. In the process of troubleshooting, I     sudo apt reinstall libvirt   (and other QEMU/KVM virtualization dependencies) Now I am getting this particular error when trying to use the host-passthrough for the CPU. "error

Re: [PATCH v3 2/8] gdbstub: Try unlinking the unix socket before binding

2025-01-08 Thread Alex Bennée
Ilya Leoshkevich writes: > In case an emulated process execve()s another emulated process, bind() > will fail, because the socket already exists. So try deleting it. > > Note that it is not possible to handle this in do_execv(): deleting > gdbserver_user_state.socket_path before safe_execve() is

Re: [PATCH v2] hw/pci-bridge: Create PLX Virtual Switch Device

2025-01-08 Thread Michael S. Tsirkin
On Wed, Dec 18, 2024 at 07:43:19PM +, Patrick Leis wrote: > From: Nabih Estefan > > Create a PLX PEX PCIe Virtual Switch implementation that can be used > for modeling trays. This is a generalized version of the xio3130 switch where > we can set the PCI information on creation, allowing us to

Re: [PATCH v3 0/3] virtio: Convert feature properties to OnOffAuto

2025-01-08 Thread Michael S. Tsirkin
On Sat, Jan 04, 2025 at 04:36:04PM +0900, Akihiko Odaki wrote: > This series was spun off from: > "[PATCH 0/3] virtio-net: Convert feature properties to OnOffAuto" > (https://patchew.org/QEMU/20240714-auto-v3-0-e27401aab...@daynix.com/) > > Some features are not always available with vhost. Legacy

Re: [PATCH] crypto: fix bogus error benchmarking pbkdf on fast machines

2025-01-08 Thread Richard W.M. Jones
On Wed, Jan 08, 2025 at 06:43:54PM +, Daniel P. Berrangé wrote: > We're seeing periodic reports of errors like: > > $ qemu-img create -f luks --object secret,data=123456,id=sec0 \ > -o key-secret=sec0 luks-info.img 1M > Formatting 'luks-info.img', fmt=luks size=1048576 key-

Re: [PATCH v1 2/5] hw/vfio/ap: notification handler for AP config changed event

2025-01-08 Thread Rorie Reyes
On 1/8/25 2:34 AM, Cédric Le Goater wrote: On 1/7/25 19:43, Rorie Reyes wrote: Register an event notifier handler to process AP configuration change events by queuing the event and generating a CRW to let the guest know its AP configuration has changed Signed-off-by: Rorie Reyes Reviewed-by:

Re: [PATCH] crypto: fix bogus error benchmarking pbkdf on fast machines

2025-01-08 Thread Thomas Huth
On 08/01/2025 19.43, Daniel P. Berrangé wrote: We're seeing periodic reports of errors like: $ qemu-img create -f luks --object secret,data=123456,id=sec0 \ -o key-secret=sec0 luks-info.img 1M Formatting 'luks-info.img', fmt=luks size=1048576 key-secret=sec0 qemu-img: lu

[PATCH v4 5/9] user: Introduce host_interrupt_signal

2025-01-08 Thread Ilya Leoshkevich
Attaching to the gdbstub of a running process requires stopping its threads. For threads that run on a CPU, cpu_exit() is enough, but the only way to grab attention of a thread that is stuck in a long-running syscall is to interrupt it with a signal. Reserve a host realtime signal for this, just l

Re: [PATCH v2 64/81] tcg: Merge INDEX_op_orc_{i32,i64}

2025-01-08 Thread Philippe Mathieu-Daudé
On 7/1/25 09:00, Richard Henderson wrote: Signed-off-by: Richard Henderson --- include/tcg/tcg-opc.h | 3 +-- target/arm/tcg/translate-sve.c | 2 +- target/tricore/translate.c | 2 +- tcg/optimize.c | 6 -- tcg/tcg-op.c | 8 tcg/

Re: [PATCH v2 59/81] tcg: Merge INDEX_op_andc_{i32,i64}

2025-01-08 Thread Philippe Mathieu-Daudé
On 7/1/25 09:00, Richard Henderson wrote: Signed-off-by: Richard Henderson --- include/tcg/tcg-opc.h | 3 +-- target/arm/tcg/translate-a64.c | 2 +- target/tricore/translate.c | 2 +- tcg/optimize.c | 6 -- tcg/tcg-op.c | 8 tcg/

Re: [PATCH v2 61/81] tcg: Merge INDEX_op_or_{i32,i64}

2025-01-08 Thread Philippe Mathieu-Daudé
On 7/1/25 09:00, Richard Henderson wrote: Signed-off-by: Richard Henderson --- include/tcg/tcg-opc.h| 3 +-- target/sh4/translate.c | 4 ++-- tcg/optimize.c | 6 -- tcg/tcg-op.c | 4 ++-- tcg/tcg.c| 9 +++-- tcg/tci.c| 5

Re: [PATCH v2 66/81] tcg: Merge INDEX_op_xor_{i32,i64}

2025-01-08 Thread Philippe Mathieu-Daudé
On 7/1/25 09:00, Richard Henderson wrote: Signed-off-by: Richard Henderson --- include/tcg/tcg-opc.h| 3 +-- target/sh4/translate.c | 6 +++--- tcg/optimize.c | 18 -- tcg/tcg-op.c | 4 ++-- tcg/tcg.c| 9 +++-- tcg/tci.c

Re: [PATCH v2 69/81] tcg: Merge INDEX_op_eqv_{i32,i64}

2025-01-08 Thread Philippe Mathieu-Daudé
On 7/1/25 09:01, Richard Henderson wrote: Signed-off-by: Richard Henderson --- include/tcg/tcg-opc.h| 3 +-- tcg/optimize.c | 6 -- tcg/tcg-op.c | 8 tcg/tcg.c| 6 ++ tcg/tci.c| 5 ++--- tcg/tci/tcg-target.c.inc |

Re: [PATCH v1 1/3] hw/timer/aspeed: Support different memory region ops

2025-01-08 Thread Andrew Jeffery
On Mon, 2024-12-16 at 15:53 +0800, Jamin Lin wrote: > It set "aspeed_timer_ops" struct which containing read and write > callbacks > to be used when I/O is performed on the TIMER region. > > Besides, in the previous design of ASPEED SOCs, the timer registers > address > space are contiguous. > >

Re: or1k -M virt -hda and net.

2025-01-08 Thread BALATON Zoltan
On Wed, 8 Jan 2025, Rob Landley wrote: On 1/8/25 07:01, BALATON Zoltan wrote: On Tue, 7 Jan 2025, Rob Landley wrote: What's the alternative to -hda you suggest for that? Can I do "./run-qemu.sh -drive file=blah.img" without the rest? Perhaps specify all the details in the script and then opti

Re: [PATCH 2/7] guest_memfd: Introduce an object to manage the guest-memfd with RamDiscardManager

2025-01-08 Thread Chenyi Qiang
On 1/8/2025 7:20 PM, Alexey Kardashevskiy wrote: > > > On 8/1/25 21:56, Chenyi Qiang wrote: >> >> >> On 1/8/2025 12:48 PM, Alexey Kardashevskiy wrote: >>> On 13/12/24 18:08, Chenyi Qiang wrote: As the commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated discard") high

Re: [RFC PATCH 0/5] hw/arm/virt: Add support for user-creatable nested SMMUv3

2025-01-08 Thread Nicolin Chen
On Mon, Dec 16, 2024 at 10:01:29AM +, Shameerali Kolothum Thodi wrote: > And patches prior to this commit adds that support: > 4ccdbe3: ("cover-letter: Add HW accelerated nesting support for arm > SMMUv3") > > Nicolin is soon going to send out those for review. Or I can include > those in thi

RE: [PATCH v1 1/3] hw/timer/aspeed: Support different memory region ops

2025-01-08 Thread Jamin Lin
Hi Cedric, > -Original Message- > From: Cédric Le Goater > Sent: Thursday, January 9, 2025 3:02 PM > To: Jamin Lin ; Andrew Jeffery > ; Peter Maydell ; > Steven Lee ; Troy Lee ; > Joel Stanley ; open list:ASPEED BMCs > ; open list:All patches CC here > > Cc: Troy Lee ; Yunlin Tang > > S

Re: [PATCH v1 15/19] memory: Add an API for ATS support

2025-01-08 Thread CLEMENT MATHIEU--DRIF
On 08/01/2025 19:10, Michael S. Tsirkin wrote: > Caution: External email. Do not open attachments or click links, unless this > email comes from a known sender and you know the content is safe. > > > On Fri, Nov 29, 2024 at 07:44:00AM +, CLEMENT MATHIEU--DRIF wrote: >> From: Clément Mathieu

[PATCH v19 01/14] hw/pci: Rename has_power to enabled

2025-01-08 Thread Akihiko Odaki
The renamed state will not only represent powering state of PFs, but also represent SR-IOV VF enablement in the future. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé --- include/hw/pci/pci.h| 1 + include/hw/pci/pci_device.h | 2 +- hw/pci/pci.c| 17

[PATCH v19 04/14] s390x/pci: Avoid creating zpci for VFs

2025-01-08 Thread Akihiko Odaki
VFs are automatically created by PF, and creating zpci for them will result in unexpected usage of fids. Currently QEMU does not support multifunction for s390x so we don't need zpci for VFs anyway. Signed-off-by: Akihiko Odaki --- hw/s390x/s390-pci-bus.c | 21 +++-- 1 file chang

[PATCH v19 00/14] hw/pci: SR-IOV related fixes and improvements

2025-01-08 Thread Akihiko Odaki
Supersedes: <20240714-rombar-v2-0-af1504ef5...@daynix.com> ("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto") I submitted a RFC series[1] to add support for SR-IOV emulation to virtio-net-pci. During the development of the series, I fixed some trivial bugs and made improvements that I think

[PATCH v19 05/14] s390x/pci: Allow plugging SR-IOV devices

2025-01-08 Thread Akihiko Odaki
The guest cannot use VFs due to the lack of multifunction support but can use PFs. Signed-off-by: Akihiko Odaki --- hw/s390x/s390-pci-bus.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 8c5eb69f7d76..c396d55c72

[PATCH v19 10/14] pcie_sriov: Release VFs failed to realize

2025-01-08 Thread Akihiko Odaki
Release VFs failed to realize just as we do in unregister_vfs(). Fixes: 7c0fa8dff811 ("pcie: Add support for Single Root I/O Virtualization (SR/IOV)") Signed-off-by: Akihiko Odaki --- hw/pci/pcie_sriov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sri

  1   2   3   4   >