Re: [PATCH v16 14/14] hw/vmapple/vmapple: Add vmapple machine type

2025-01-04 Thread Phil Dennis-Jordan
On Sat, 4 Jan 2025 at 16:15, Akihiko Odaki wrote: > On 2024/12/28 5:36, Philippe Mathieu-Daudé wrote: > > On 23/12/24 23:16, Phil Dennis-Jordan wrote: > > > >> Known issues: > >> - Keyboard and mouse/tablet input is laggy. The reason for this is > >> that macOS's XHCI driver seems to expect

Re: [RFC PATCH 3/6] target/xtensa: Move xtensa-isa.c to common_ss[]

2025-01-04 Thread Richard Henderson
On 1/3/25 15:17, Philippe Mathieu-Daudé wrote: The Xtensa disassembler (selected with CONFIG_XTENSA_DIS=y) uses methods defined in xtensa-isa.c, so this file has to be compiled when the disassembler is linked. Signed-off-by: Philippe Mathieu-Daudé --- target/xtensa/meson.build | 3 ++- 1 fil

Re: [RFC PATCH 1/6] target: Only link capstone to targets requiring it

2025-01-04 Thread Richard Henderson
On 1/3/25 15:17, Philippe Mathieu-Daudé wrote: No need to link capstone to targets which don't use it. Signed-off-by: Philippe Mathieu-Daudé --- disas/meson.build| 1 - target/arm/meson.build | 1 + target/i386/meson.build | 1 + target/ppc/meson.build | 1 + target/s390x/mes

Re: [RFC PATCH 6/6] disas: Select capstone targets by default

2025-01-04 Thread Richard Henderson
On 1/3/25 15:17, Philippe Mathieu-Daudé wrote: When capstone is available, we get ARM/X86/PPC/S390X disassemblers in common_ss[] for free. Signed-off-by: Philippe Mathieu-Daudé --- disas/Kconfig | 4 1 file changed, 4 insertions(+) Acked-by: Richard Henderson Hopefully starting with

Re: [PATCH] MAINTAINERS: Remove myself from reviewers

2025-01-04 Thread Alex Bennée
waine...@redhat.com writes: > From: Wainer dos Santos Moschetta > > The time I spent contributing to QEMU was great, but I've not been active > for a long time now. So removing myself from the reviewers list of > "Integration Testing with the Avocado framework" and > "Build and test automation" s

Re: [PATCH v16 14/14] hw/vmapple/vmapple: Add vmapple machine type

2025-01-04 Thread Akihiko Odaki
On 2024/12/28 5:36, Philippe Mathieu-Daudé wrote: On 23/12/24 23:16, Phil Dennis-Jordan wrote: Known issues:   - Keyboard and mouse/tablet input is laggy. The reason for this is     that macOS's XHCI driver seems to expect interrupter mapping to     be disabled when MSI/MSI-X is unavailable. I

Re: [PATCH v5 1/2] memory: Update inline documentation

2025-01-04 Thread BALATON Zoltan
On Sat, 4 Jan 2025, Akihiko Odaki wrote: Do not refer to "memory region's reference count" - Now MemoryRegions do have their own reference counts, but they will not be used when their owners are not themselves. However, the documentation of memory_

[PATCH v8 4/9] pcie_sriov: Check PCI Express for SR-IOV PF

2025-01-04 Thread Akihiko Odaki
SR-IOV requires PCI Express. Signed-off-by: Akihiko Odaki --- hw/pci/pcie_sriov.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c index 109b2ebcccba..a5b546abe8bb 100644 --- a/hw/pci/pcie_sriov.c +++ b/hw/pci/pcie_sriov.c @@ -42,6 +42,11 @@ bool

[PATCH v8 8/9] docs: Document composable SR-IOV device

2025-01-04 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- MAINTAINERS | 1 + docs/system/index.rst | 1 + docs/system/sriov.rst | 36 3 files changed, 38 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 38a290e9c2ce..b0821a17c4fa 100644 --- a/MAINTAINERS +++ b/M

[PATCH v8 0/9] virtio-net: add support for SR-IOV emulation

2025-01-04 Thread Akihiko Odaki
Based-on: <20250104-reuse-v18-0-c349eafd8...@daynix.com> ("[PATCH v18 00/14] hw/pci: SR-IOV related fixes and improvements") Introduction This series is based on the RFC series submitted by Yui Washizu[1]. See also [2] for the context. This series enables SR-I

[PATCH v8 2/9] hw/pci: Fix SR-IOV VF number calculation

2025-01-04 Thread Akihiko Odaki
pci_config_get_bar_addr() had a division by vf_stride. vf_stride needs to be non-zero when there are multiple VFs, but the specification does not prohibit to make it zero when there is only one VF. Do not perform the division for the first VF to avoid division by zero. Signed-off-by: Akihiko Odak

[PATCH v8 3/9] pcie_sriov: Ensure PF and VF are mutually exclusive

2025-01-04 Thread Akihiko Odaki
A device cannot be a SR-IOV PF and a VF at the same time. Signed-off-by: Akihiko Odaki --- hw/pci/pcie_sriov.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c index 1eb4358256de..109b2ebcccba 100644 --- a/hw/pci/pcie_sriov.c +++ b/hw/pci/pcie_sr

[PATCH v8 9/9] pcie_sriov: Make a PCI device with user-created VF ARI-capable

2025-01-04 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- docs/system/sriov.rst | 3 ++- include/hw/pci/pcie_sriov.h | 7 +-- hw/pci/pcie_sriov.c | 8 +++- hw/virtio/virtio-pci.c | 16 ++-- 4 files changed, 24 insertions(+), 10 deletions(-) diff --git a/docs/system/sriov.rst b/d

[PATCH v8 6/9] virtio-pci: Implement SR-IOV PF

2025-01-04 Thread Akihiko Odaki
Allow user to attach SR-IOV VF to a virtio-pci PF. Signed-off-by: Akihiko Odaki --- include/hw/virtio/virtio-pci.h | 1 + hw/virtio/virtio-pci.c | 20 +++- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/include/hw/virtio/virtio-pci.h b/include/hw/virtio/

[PATCH v8 7/9] virtio-net: Implement SR-IOV VF

2025-01-04 Thread Akihiko Odaki
A virtio-net device can be added as a SR-IOV VF to another virtio-pci device that will be the PF. Signed-off-by: Akihiko Odaki --- hw/virtio/virtio-net-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio-net-pci.c b/hw/virtio/virtio-net-pci.c index e18953ad674b..430b727ea3

[PATCH v8 5/9] pcie_sriov: Allow user to create SR-IOV device

2025-01-04 Thread Akihiko Odaki
A user can create a SR-IOV device by specifying the PF with the sriov-pf property of the VFs. The VFs must be added before the PF. A user-creatable VF must have PCIDeviceClass::sriov_vf_user_creatable set. Such a VF cannot refer to the PF because it is created before the PF. A PF that user-creata

[PATCH v8 1/9] hw/pci: Do not add ROM BAR for SR-IOV VF

2025-01-04 Thread Akihiko Odaki
A SR-IOV VF cannot have a ROM BAR. Co-developed-by: Yui Washizu Signed-off-by: Akihiko Odaki --- hw/pci/pci.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 8f160c0c0d8a..c4fa32dc987a 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -2432,6 +2432,14

[PATCH v2 1/2] glib-compat: Define g_spawn_check_wait_status()

2025-01-04 Thread Akihiko Odaki
g_spawn_check_exit_status() is renamed to g_spawn_check_wait_status() in 2.70. Signed-off-by: Akihiko Odaki --- include/glib-compat.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/glib-compat.h b/include/glib-compat.h index 86be439ba0ef..0bddb327bd5d 100644 --- a/include/glib-com

[PATCH v2 0/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status()

2025-01-04 Thread Akihiko Odaki
g_spawn_sync() gives an informative message if it fails to execute the script instead of reporting exiting status 1. g_spawn_check_wait_status() also gives an message easier to understand than the raw value returned by waitpid(). Signed-off-by: Akihiko Odaki --- Changes in v2: - EDITME: describe

[PATCH v2 2/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status()

2025-01-04 Thread Akihiko Odaki
g_spawn_sync() gives an informative message if it fails to execute the script instead of reporting exiting status 1. g_spawn_check_wait_status() also gives an message easier to understand than the raw value returned by waitpid(). Signed-off-by: Akihiko Odaki --- net/tap.c | 169

Re: [PATCH] system: Try hardware accelerators (KVM, HVF) before software one (TCG)

2025-01-04 Thread Phil Dennis-Jordan
On Fri, 3 Jan 2025 at 16:16, Daniel P. Berrangé wrote: > On Fri, Jan 03, 2025 at 04:05:58PM +0100, Philippe Mathieu-Daudé wrote: > > As Daniel suggested [*]: > > > > > We should consider to rank HVF above TCG, on the basis > > > that HW acceleration is faster and should provide a > > > host<->gue

[PATCH v2 0/3] vfio/igd: VFIOConfigMirrorQuirk for igd mirrored registers

2025-01-04 Thread Tomita Moeko
In commit 1a2623b5c9e7 ("vfio/igd: add macro for declaring mirrored registers"), I introduced a macro to handle mirrored registers in igd bar0. However, using the existing VFIOConfigMirrorQuirk should be a better approach I think after going through the vfio code. This patch set introduces a new h

[PATCH v2 1/3] vfio/pci: declare generic quirks in a new header file

2025-01-04 Thread Tomita Moeko
Declare generic vfio_generic_{window_address,window_data,mirror}_quirk in newly created pci_quirks.h so that they can be used elsewhere, like igd.c. Signed-off-by: Tomita Moeko --- hw/vfio/pci-quirks.c | 55 +++--- hw/vfio/pci-quirks.h | 71 +++

[PATCH v2 3/3] vfio/igd: use VFIOConfigMirrorQuirk for mirrored registers

2025-01-04 Thread Tomita Moeko
With the introduction of config_offset field, VFIOConfigMirrorQuirk can now be used for those mirrored register in igd bar0. This eliminates the need for the macro intoduced in 1a2623b5c9e7 ("vfio/igd: add macro for declaring mirrored registers"). Signed-off-by: Tomita Moeko --- hw/vfio/igd.c |

[PATCH v2 2/3] vfio/pci: introduce config_offset field in VFIOConfigMirrorQuirk

2025-01-04 Thread Tomita Moeko
Device may only expose a specific portion of PCI config space through a region in a BAR, such behavior is seen in igd GGC and BDSM mirrors in BAR0. To handle these, config_offset is introduced to allow mirroring arbitrary region in PCI config space. Signed-off-by: Tomita Moeko --- hw/vfio/pci-qu