Re: [PATCH 07/12] rust: pl011: only leave embedded object initialization in instance_init

2024-12-25 Thread Zhao Liu
On Fri, Dec 20, 2024 at 03:29:49PM +0100, Paolo Bonzini wrote: > Date: Fri, 20 Dec 2024 15:29:49 +0100 > From: Paolo Bonzini > Subject: [PATCH 07/12] rust: pl011: only leave embedded object > initialization in instance_init > X-Mailer: git-send-email 2.47.1 > > Leave IRQ and MMIO initialization

Re: [PATCH 06/12] rust: qom: move device_id to PL011 class side

2024-12-25 Thread Zhao Liu
On Fri, Dec 20, 2024 at 03:29:48PM +0100, Paolo Bonzini wrote: > Date: Fri, 20 Dec 2024 15:29:48 +0100 > From: Paolo Bonzini > Subject: [PATCH 06/12] rust: qom: move device_id to PL011 class side > X-Mailer: git-send-email 2.47.1 > > There is no need to monkeypatch DeviceId::Luminary into the >

Re: [PATCH 08/12] rust: qom: make INSTANCE_POST_INIT take a shared reference

2024-12-25 Thread Zhao Liu
On Fri, Dec 20, 2024 at 03:29:50PM +0100, Paolo Bonzini wrote: > Date: Fri, 20 Dec 2024 15:29:50 +0100 > From: Paolo Bonzini > Subject: [PATCH 08/12] rust: qom: make INSTANCE_POST_INIT take a shared > reference > X-Mailer: git-send-email 2.47.1 > > Signed-off-by: Paolo Bonzini > --- > rust/hw/

Re: [PULL 1/6] target/loongarch: Fix vldi inst

2024-12-25 Thread bibo mao
On 2024/12/25 下午7:32, Philippe Mathieu-Daudé wrote: Hi Bibo, On 25/12/24 03:40, Bibo Mao wrote: From: ghy <2247883...@qq.com> Is this authorship correct? Should it be: From: Guo Hongyu yes, this is better. Refer to the link below for a description of the vldi instructions: https://ji

Re: [PATCH 09/12] rust: qdev: expose inherited methods to subclasses of SysBusDevice

2024-12-25 Thread Zhao Liu
On Fri, Dec 20, 2024 at 03:29:51PM +0100, Paolo Bonzini wrote: > Date: Fri, 20 Dec 2024 15:29:51 +0100 > From: Paolo Bonzini > Subject: [PATCH 09/12] rust: qdev: expose inherited methods to subclasses > of SysBusDevice > X-Mailer: git-send-email 2.47.1 > > The ObjectDeref trait now provides all

Re: [PATCH 10/12] rust: qemu-api-macros: extend error reporting facility to parse errors

2024-12-25 Thread Zhao Liu
On Fri, Dec 20, 2024 at 03:29:52PM +0100, Paolo Bonzini wrote: > Date: Fri, 20 Dec 2024 15:29:52 +0100 > From: Paolo Bonzini > Subject: [PATCH 10/12] rust: qemu-api-macros: extend error reporting > facility to parse errors > X-Mailer: git-send-email 2.47.1 > > Generalize the CompileError tuple t

Re: [PATCH 11/12] rust: qemu-api-macros: add automatic TryFrom/TryInto derivation

2024-12-25 Thread Zhao Liu
On Fri, Dec 20, 2024 at 03:29:53PM +0100, Paolo Bonzini wrote: > Date: Fri, 20 Dec 2024 15:29:53 +0100 > From: Paolo Bonzini > Subject: [PATCH 11/12] rust: qemu-api-macros: add automatic TryFrom/TryInto > derivation > X-Mailer: git-send-email 2.47.1 > > This is going to be fairly common. Using a

Re: [PATCH 12/12] rust: hide warnings for subprojects

2024-12-25 Thread Zhao Liu
On Fri, Dec 20, 2024 at 03:29:54PM +0100, Paolo Bonzini wrote: > Date: Fri, 20 Dec 2024 15:29:54 +0100 > From: Paolo Bonzini > Subject: [PATCH 12/12] rust: hide warnings for subprojects > X-Mailer: git-send-email 2.47.1 > > This matches cargo's own usage of "--cap-lints allow" when building > de

Re: [PATCH 01/12] rust: qom: add ParentField

2024-12-25 Thread Zhao Liu
On Fri, Dec 20, 2024 at 03:29:43PM +0100, Paolo Bonzini wrote: > Date: Fri, 20 Dec 2024 15:29:43 +0100 > From: Paolo Bonzini > Subject: [PATCH 01/12] rust: qom: add ParentField > X-Mailer: git-send-email 2.47.1 > > Add a type that, together with the C function object_deinit, ensures the > correct

[PATCH v8 0/2] Support RISC-V CSR read/write in Qtest environment

2024-12-25 Thread Ivan Klokov
These patches add functionality for unit testing RISC-V-specific registers. The first patch adds a Qtest backend, and the second implements a simple test. --- v8: - Delete RFC label. v7: - Fix build errors, add Reviewed-by, Acked-by. --- Ivan Klokov (2): target/riscv: Add RISC-V CSR qtest

[PATCH v8 1/2] target/riscv: Add RISC-V CSR qtest support

2024-12-25 Thread Ivan Klokov
The RISC-V architecture supports the creation of custom CSR-mapped devices. It would be convenient to test them in the same way as MMIO-mapped devices. To do this, a new call has been added to read/write CSR registers. Signed-off-by: Ivan Klokov Acked-by: Fabiano Rosas Reviewed-by: Daniel Henriq

[PATCH v8 2/2] tests/qtest: QTest example for RISC-V CSR register

2024-12-25 Thread Ivan Klokov
Added demo for reading CSR register from qtest environment. Signed-off-by: Ivan Klokov Reviewed-by: Fabiano Rosas Reviewed-by: Daniel Henrique Barboza --- tests/qtest/meson.build | 2 +- tests/qtest/riscv-csr-test.c | 56 2 files changed, 57 insertion

Re: [PATCH 1/5] aspeed: Make sdhci_attach_drive and write_boot_rom public

2024-12-25 Thread Philippe Mathieu-Daudé
On 25/12/24 03:03, Steven Lee via wrote: sdhci_attach_drive and write_boot_rom functions may be used by the aspeed machine supporting co-processors. Signed-off-by: Steven Lee --- hw/arm/aspeed.c | 4 ++-- include/hw/arm/aspeed.h | 6 ++ 2 files changed, 8 insertions(+), 2 deleti

Re: [PATCH 4/5] aspeed: Introduce ast2700-fc machine

2024-12-25 Thread Philippe Mathieu-Daudé
Hi Steven, On 25/12/24 03:03, Steven Lee via wrote: This patch introduces a new machine, ast2700-fc, which supports all cores available in the AST27x0 SoC. In this machine - The first 4 cores are Cortex-A35 cores. - CPU 4 is designated as the SSP core. - CPU 5 is designated as the TSP core. Tes

Re: [PULL 1/6] target/loongarch: Fix vldi inst

2024-12-25 Thread Philippe Mathieu-Daudé
Hi Bibo, On 25/12/24 03:40, Bibo Mao wrote: From: ghy <2247883...@qq.com> Is this authorship correct? Should it be: From: Guo Hongyu Refer to the link below for a description of the vldi instructions: https://jia.je/unofficial-loongarch-intrinsics-guide/lsx/misc/#synopsis_88 Fixed errors i

[PATCH] qemu-ga: Optimize freeze-hook script logic of logging error

2024-12-25 Thread Dehan Meng
Make sure the error log of fsfreeze hooks when freeze/thaw/snapshot could be logged to system logs if the default logfile of qga can't be written or other situations Signed-off-by: Dehan Meng --- scripts/qemu-guest-agent/fsfreeze-hook | 36 +++--- 1 file changed, 32 insertion

Re: [PULL 00/72] tcg patch queue

2024-12-25 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH 02/12] rust: add a utility module for compile-time type checks

2024-12-25 Thread Zhao Liu
On Fri, Dec 20, 2024 at 03:29:44PM +0100, Paolo Bonzini wrote: > Date: Fri, 20 Dec 2024 15:29:44 +0100 > From: Paolo Bonzini > Subject: [PATCH 02/12] rust: add a utility module for compile-time type > checks > X-Mailer: git-send-email 2.47.1 > > It is relatively common in the low-level qemu_api

Re: [PATCH 03/12] rust: macros: check that the first field of a #[derive(Object)] struct is a ParentField

2024-12-25 Thread Zhao Liu
On Fri, Dec 20, 2024 at 03:29:45PM +0100, Paolo Bonzini wrote: > Date: Fri, 20 Dec 2024 15:29:45 +0100 > From: Paolo Bonzini > Subject: [PATCH 03/12] rust: macros: check that the first field of a > #[derive(Object)] struct is a ParentField > X-Mailer: git-send-email 2.47.1 > > Signed-off-by: Pao

Re: [PULL 00/17] vfio queue

2024-12-25 Thread Cédric Le Goater
Hello Stefan, On 12/25/24 14:31, Stefan Hajnoczi wrote: Hi Cédric, Please take a look at the following 32-bit CI failure: Drat. I didn't check 32-bit ... Sorry about that. I will resend. Thanks, C.

Re: [PULL 00/17] vfio queue

2024-12-25 Thread Stefan Hajnoczi
Hi Cédric, Please take a look at the following 32-bit CI failure: i686-linux-gnu-gcc -m32 -Ilibqemu-x86_64-softmmu.a.p -I. -I.. -Itarget/i386 -I../target/i386 -Isubprojects/libvduse -I../subprojects/libvduse -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/capstone -I/usr/include/p11-kit-1 -I/usr

Re: [PATCH 04/12] rust: macros: check that #[derive(Object)] requires #[repr(C)]

2024-12-25 Thread Zhao Liu
On Fri, Dec 20, 2024 at 03:29:46PM +0100, Paolo Bonzini wrote: > Date: Fri, 20 Dec 2024 15:29:46 +0100 > From: Paolo Bonzini > Subject: [PATCH 04/12] rust: macros: check that #[derive(Object)] requires > #[repr(C)] > X-Mailer: git-send-email 2.47.1 > > Signed-off-by: Paolo Bonzini > --- > rust