[PATCH v3 29/32] tests/functional: remove now unused 'run_cmd' helper

2024-12-17 Thread Daniel P . Berrangé
All usage has been replaced by direct 'subprocess' helpers. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/__init__.py | 2 +- tests/functional/qemu_test/cmd.py | 11 --- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/test

[PATCH v3 15/32] tests/functional: remove redundant 'rmtree' call

2024-12-17 Thread Daniel P . Berrangé
Everything in the scratch directory is automatically purged. Calling 'rmtree' again breaks the ability to optionally preserve the scratch directory contents. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/test_sh4eb_r2d.py | 3 --- 1 file changed, 3 deletions(-)

Re: [PATCH 3/3] system/accel-ops: Remove unnecessary 'exec/cpu-common.h' header

2024-12-17 Thread Zhao Liu
On Tue, Dec 17, 2024 at 04:13:05PM +0100, Philippe Mathieu-Daudé wrote: > Date: Tue, 17 Dec 2024 16:13:05 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH 3/3] system/accel-ops: Remove unnecessary > 'exec/cpu-common.h' header > X-Mailer: git-send-email 2.45.2 > > Since commit c4b3f46c151 (

Re: [PATCH 0/2] Change default pointer authentication algorithm on aarch64 to impdef

2024-12-17 Thread Pierrick Bouvier
On 12/17/24 02:38, Peter Maydell wrote: On Tue, 17 Dec 2024 at 07:40, Alex Bennée wrote: Pierrick Bouvier writes: On 12/16/24 11:50, Richard Henderson wrote: On 12/16/24 13:26, Pierrick Bouvier wrote: On 12/16/24 11:10, Richard Henderson wrote: On 12/4/24 15:12, Pierrick Bouvier wrote:

Re: [PATCH 26/26] rust: callbacks: allow passing optional callbacks as ()

2024-12-17 Thread Paolo Bonzini
Il mer 18 dic 2024, 07:50 Zhao Liu ha scritto: > Am I using the wrong terminology? Function pointers in a structure should > be called a vtable, rather than callbacks (for example, methods in > TypeInfo, > read/write methods in MemoryRegionOps). Callbacks are typically function > pointers used as

[PATCH v2 1/2] target/riscv: refactor VSTART_CHECK_EARLY_EXIT() to accept vl as a parameter

2024-12-17 Thread Chao Liu
Some vector instructions are special, such as the vlm.v instruction, where setting its vl actually sets evl = (vl + 7) >> 3. To improve maintainability, we will uniformly use VSTART_CHECK_EARLY_EXIT() to check for the condition vstart >= vl. This function will also handle cases involving evl. Sign

Re: [PATCH 24/26] rust: qom: move device_id to PL011 class side

2024-12-17 Thread Paolo Bonzini
Il mer 18 dic 2024, 07:39 Zhao Liu ha scritto: > I supposed a case, where there is such a QOM (QEMU Object Model) > structure relationship: > > * DummyState / DummyClass: defined in Rust side, and registered the > TypeInfo by `Object` macro. > > - So its class_init will be called by C QOM cod

[PATCH v2 2/2] target/riscv: fix handling of nop for vstart >= vl in some vector instruction

2024-12-17 Thread Chao Liu
fix: https://lore.kernel.org/all/20240322085319.1758843-8-alistair.fran...@wdc.com/ Signed-off-by: Chao Liu --- target/riscv/vector_helper.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 4

[PATCH v2 0/2] Enhanced VSTART and VL Checks for Vector Instructions

2024-12-17 Thread Chao Liu
Hi, all: In the second version of this patch, I addressed the issue that other vector instructions didn't check for vstart >= vl correctly. I refactored the VSTART_CHECK_EARLY_EXIT() macro. This change is intended to: Vector instructions with special vl values can also be checked with this macro,

[PATCH 0/5] qtest: pci and e1000e/igb msix fixes

2024-12-17 Thread Nicholas Piggin
Hi, This series is split out from a larger one that added some more XHCI functionality and tests here. Just wanted to get more focus on the PCI issues first. https://lore.kernel.org/qemu-devel/20241212083502.1439033-1-npig...@gmail.com/T/#t It is quite reworked after feedback about the incorrect

[PATCH 1/5] qtest/pci: Enforce balanced iomap/unmap

2024-12-17 Thread Nicholas Piggin
Add assertions to ensure a BAR is not mapped twice, and only previously mapped BARs are unmapped. This can help catch some bugs. Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Reviewed-by: Fabiano Rosas Signed-off-by: Nicholas Piggin --- tests/qtest/libqos/ahci.h | 1 + tests/qtest/libqos

[PATCH 2/5] qtest/libqos/pci: Fix qpci_msix_enable sharing bar0

2024-12-17 Thread Nicholas Piggin
Devices where the MSI-X addresses are shared with other MMIO on BAR0 can not use msi_enable because it unmaps and remaps BAR0, which interferes with device MMIO mappings. xhci-nec is one such device we would like to test msix with. Use the BAR iomap tracking structure introduced in the previous ch

[PATCH 5/5] qtest/e1000e|igb: Fix msix to re-trigger interrupts

2024-12-17 Thread Nicholas Piggin
The e1000e and igb tests don't clear the msix pending bit after waiting for it, as it is masked so the irq doesn't get sent. Failing to clear the pending interrupt means all subsequent waits for that interrupt after the first do not actually wait for an interrupt genreated by the device. This affe

[PATCH 4/5] qtest/e1000e|igb: Clear interrupt-cause bits after irq

2024-12-17 Thread Nicholas Piggin
The e1000e and igb tests do not clear the ICR/EICR cause bits (or set auto-clear) on seeing queue interrupts, which inhibits the triggering of a new interrupt. Fix this by clearing the cause bits, and verify that the expected cause bit was set. Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Cc: Dm

[PATCH 3/5] qtest/libqos/pci: Do not write to PBA memory

2024-12-17 Thread Nicholas Piggin
The PCI Local Bus Specification says the result of writes to MSI-X PBA memory is undefined. QEMU implements them as no-ops, so remove the pointless write from qpci_msix_pending(). Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Cc: Dmitry Fleytman Cc: Akihiko Odaki Cc: Sriram Yagnaraman Signed-of

<    1   2   3   4