Re: [PATCH 05/46] tcg/optimize: Use finish_folding in fold_addsub2

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 3f2f351bae..135b14974f 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1292,7 +1292,7

Re: [PATCH 04/46] tcg/optimize: Use finish_folding in fold_add, fold_add_vec

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 6644d24da6..3f2f351bae 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -978,7 +9

Re: [PATCH 03/46] tcg/optimize: Add fold_masks_zsa, fold_masks_zs, fold_masks_z

On 12/10/24 07:23, Richard Henderson wrote: Add additional routines to pass masks directly, rather than storing them into OptContext. To be used in upcoming patches. Signed-off-by: Richard Henderson --- tcg/optimize.c | 24 1 file changed, 20 insertions(+), 4 deleti

Re: [PATCH 00/46] tcg: Remove in-flight mask data from OptContext

On 12/10/24 07:23, Richard Henderson wrote: The desire is to start re-using some of the fold_* functions while lowering or simplifying operations during tcg_optmize. Many of these fold_* functions set z_mask, s_mask, and a_mask, which hang around until the end of the tcg_optmize loop and are app

Re: [PATCH 06/46] tcg/optimize: Use fold_masks_zsa in fold_and

On 12/10/24 07:23, Richard Henderson wrote: Avoid the use of the OptContext slots. Signed-off-by: Richard Henderson --- tcg/optimize.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 135b14974f..000ac0f810 100644 --- a/tc

Re: [PATCH 07/46] tcg/optimize: Use fold_masks_zsa in fold_andc

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 000ac0f810..285407ce05 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@

Re: [PATCH 08/46] tcg/optimize: Use fold_masks_zs in fold_bswap

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 285407ce05..3363ebd48c 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1082,7 +108

Re: [PATCH 10/46] tcg/optimize: Use fold_masks_z in fold_ctpop

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index c97ec10989..424ed7674d 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1598,2

Re: [PATCH 11/46] tcg/optimize: Use fold_and and fold_masks_z in fold_deposit

On 12/10/24 07:23, Richard Henderson wrote: When we fold to and, use fold_and, which sets s_mask and a_mask more intelligently than we do for the rest of deposit. Signed-off-by: Richard Henderson --- tcg/optimize.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --

Re: [PATCH 09/46] tcg/optimize: Use fold_masks_z in fold_count_zeros

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 3363ebd48c..c97ec10989 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1088,7 +

Re: [PATCH 12/46] tcg/optimize: Use finish_folding in fold_divide

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 4d5fa04199..59f510b49a 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1671,7 +1671,7

Re: [PATCH 13/46] tcg/optimize: Use finish_folding in fold_dup, fold_dup2

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 59f510b49a..e6dc9f2e28 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1681,7 +168

Re: [PATCH 14/46] tcg/optimize: Use fold_masks_zs in fold_eqv

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index e6dc9f2e28..5f3a824a07 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1701,15

Re: [PATCH 15/46] tcg/optimize: Use fold_masks_zsa in fold_extract

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 5f3a824a07..955151f4cf 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1716,7

Re: [PATCH 17/46] tcg/optimize: Use fold_masks_zsa in fold_exts

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index a0ccf7f3f2..5d10e704a7 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1759,7

Re: [PATCH 16/46] tcg/optimize: Use finish_folding in fold_extract2

On 12/10/24 07:23, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 955151f4cf..a0ccf7f3f2 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1754,7 +1754,7

[PATCH v3 08/32] tests/functional: switch to new test skip decorators

This ensures consistency of behaviour across all the tests, and requires that we provide gitlab bug links when marking a test to be skipped due to unreliability. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/test_acpi_bits.py | 25 +++-- t

[PATCH v3 11/32] tests/functional: switch over to using self.log_file(...)

This removes direct access of the 'self.logdir' variable. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/testcase.py | 9 - tests/functional/test_virtio_gpu.py| 4 +--- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/tests/fu

[PATCH v3 00/32] tests/functional: various improvements wrt assets/scratch files

This series is an attempt to bring a little more guaranteed order to asset and scratch file handling in the functional tests. The main highlights are: * Add custom @skipX decorators for common scenarios present in QEMU tests * Add helpers for creating file paths for various well known

Re: [PATCH v2] pci: ensure valid link status bits for downstream ports

Hi, On Tue, 3 Dec 2024, Alex Williamson wrote: On Tue, 3 Dec 2024 13:19:28 +0100 Sebastian Ott wrote: PCI hotplug for downstream endpoints on arm fails because Linux' PCIe hotplug driver doesn't like the QEMU provided LNKSTA: pcieport :08:01.0: pciehp: Slot(2): Card present pcieport

Re: [PATCH 26/26] rust: callbacks: allow passing optional callbacks as ()

On Mon, Dec 09, 2024 at 01:37:17PM +0100, Paolo Bonzini wrote: > Date: Mon, 9 Dec 2024 13:37:17 +0100 > From: Paolo Bonzini > Subject: [PATCH 26/26] rust: callbacks: allow passing optional callbacks as > () > X-Mailer: git-send-email 2.47.1 > > In some cases, callbacks are optional. Using "Som

[PATCH v3 09/32] tests/functional: drop 'has_cmd' and 'has_cmds' helpers

The 'which' helper is simpler, not depending on the external 'which' binary, and is sufficient for test needs. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/__init__.py | 2 +- tests/functional/qemu_test/cmd.py| 54 ++--

[PATCH v3 25/32] tests/functional: add 'uncompress' to QemuBaseTest

This helper wrappers utils.uncompress, forcing the use of the scratch directory, to ensure any uncompressed files are cleaned at test termination. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/testcase.py | 25 + 1 file changed

[PATCH v3 06/32] tests/functional: drop 'tesseract_available' helper

Platforms we target have new enough tesseract that it suffices to merely check if the binary exists. Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/tesseract.py | 12 +--- tests/functional/test_m68k_nextcube.py | 8 +++- 2 files changed, 4 insertions(+), 16 deleti

[PATCH v3 13/32] tests/functional: switch over to using self.data_file(...)

This removes direct path manipulation to figure out the source dir Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/test_acpi_bits.py | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/tests/functional/test_acpi_bits.py b/

[PATCH v3 05/32] tests/functional: simplify 'which' implementation

The 'access' check implies the file exists. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/cmd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/qemu_test/cmd.py b/tests/functional/

[PATCH v3 32/32] MAINTAINERS: add myself as reviewer for functional test suite

Signed-off-by: Daniel P. Berrangé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 822f34344b..54201da578 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4157,6 +4157,7 @@ W: https://cirrus-ci.com/github/qemu/qemu Functional testing framework M:

Re: [PATCH v2 1/2] log: Add separate debug option for logging invalid memory accesses

On Sat, 2 Nov 2024 at 12:18, BALATON Zoltan wrote: > > Currently -d guest_errors enables logging of different invalid actions > by the guest such as misusing hardware, accessing missing features or > invalid memory areas. The memory access logging can be quite verbose > which obscures the other me

[PATCH v3 03/32] tests/functional: resolve str(Asset) to cache file path

Allow an Asset object to be used in place of a filename but making its string representation resolve to the cache file path. Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/asset.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/functional/qemu_test/asset.py b/tes

[PATCH v3 26/32] tests/functional: convert tests to new uncompress helper

Replace use of lzma_uncompress and gzip_uncompress with the new uncompress helper. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/test_aarch64_raspi4.py | 5 + tests/functional/test_aarch64_sbsaref.py | 10 +++--- tests/functional/test_alpha_clipper.

[PATCH v3 16/32] tests/functional: move archive handling into new archive.py file

More archive related code will be added shortly, so having a separate file makes more sense. The utils.py imports the functions from archive.py, so that existing callers don't need to be modified. This avoids redundant code churn until later in the series when all calls will be adapted for other r

Re: [PATCH v2 0/7] Introduce SMP Cache Topology

> Hi Zhao, > > I wonder if this patch-set requires rebase for the new cycle? > Hi Alireza, Yes, as some general patches are merged. (Pls refer the v5: https://lore.kernel.org/qemu-devel/20241101083331.340178-1-zhao1@intel.com/) I'll send a new version this week, to include the remaining p

[PATCH v3 18/32] tests/functional: add common zip_extract helper

This mirrors the existing archive_extract and cpio_extract helpers Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/archive.py | 8 1 file changed, 8 insertions(+) diff --git a/tests/functional/qemu_test/archive.py b/tests/functional/qemu_test

[PATCH v3 12/32] tests/functional: switch over to using self.build_file(...)

This removes direct access of the 'BUILD_DIR' variable. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/cmd.py | 5 ++--- tests/functional/qemu_test/testcase.py | 4 ++-- tests/functional/test_aarch64_virt.py | 5 ++--- tests/functional/test_vi

[PATCH v3 21/32] tests/functional: add a generalized archive_extract

There are many types of archives that the tests deal with. Provide a generalized 'archive_extract' that can detect the format and delegate to the appropriate helper for extraction. This ensures that all archive extraction code follows the same design pattern. Reviewed-by: Thomas Huth Signed-off-b

[PATCH] tests/qtest/migration: Restore include for postcopy

Commit 124a3c58b8 ("tests/qtest/migration: Move ufd_version_check to utils") moved the ufd_version_check() function to another file but failed to bring along the include, which is necessary to pull in for __NR_userfaultd. Restore the missing include. While here, remove the ifdef __linux__ that'

Re: [PATCH] contrib/plugins/bbv.c: Start bb index from 1

Hi, On 12/17/24 06:24, ckf104 wrote: Standard simpoint tool reqeusts that index of basic block index starts from 1. Signed-off-by: ckf104 <1900011...@pku.edu.cn> --- contrib/plugins/bbv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/plugins/bbv.c b/contrib/plug

Re: (Proposal) New TDX Global Metadata To Report FIXED0 and FIXED1 CPUID Bits

On Mon, 2024-12-16 at 17:53 -0800, Sean Christopherson wrote: > Every new feature that lands in hardware needs to either be "benign" or have > the > appropriate virtualization controls.  KVM already has to deal with cases where > features can effectively be used without KVM's knowledge.  E.g. ther

Re: [PATCH 09/13] contrib/plugins/hotblocks: fix 32-bit build

On 12/17/24 07:34, Richard Henderson wrote: On 12/16/24 19:07, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- contrib/plugins/hotblocks.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index

Re: [PATCH 01/13] plugins: change signature of qemu_plugin_insn_haddr

On 12/17/24 06:41, Richard Henderson wrote: On 12/16/24 19:06, Pierrick Bouvier wrote: It makes more sense to return the same type than qemu_plugin_insn_vaddr. Signed-off-by: Pierrick Bouvier --- include/qemu/qemu-plugin.h | 2 +- plugins/api.c | 12 ++-- 2 files c

[PATCH v3 28/32] tests/functional: replace 'run_cmd' with subprocess helpers

The 'run_cmd' helper is re-implementing a convenient helper that already exists in the form of the 'run' and 'check_call' methods provided by 'subprocess'. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/archive.py| 9 --- tests/functional/qemu

Re: [PATCH 2/3] system/numa: Remove unnecessary 'exec/cpu-common.h' header

On Tue, Dec 17, 2024 at 04:13:04PM +0100, Philippe Mathieu-Daudé wrote: > Date: Tue, 17 Dec 2024 16:13:04 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH 2/3] system/numa: Remove unnecessary 'exec/cpu-common.h' > header > X-Mailer: git-send-email 2.45.2 > > Nothing requires definitions fr

[PATCH v3 19/32] tests/functional: add common deb_extract helper

This mirrors the existing archive_extract, cpio_extract and zip_extract helpers Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/archive.py | 13 + tests/functional/qemu_test/linuxkernel.py | 13 - 2 files changed, 17 insertio

Re: [PATCH v2 0/2] Separate memory access logs from guest_errors

On Fri, 13 Dec 2024 at 12:41, BALATON Zoltan wrote: > > On Sat, 2 Nov 2024, BALATON Zoltan wrote: > > Originally memory access logs were a debug define that then were > > converted to log messages but were classified as guest_errors which > > already logs misc errors. As invalid memory access logs

[PATCH v3 10/32] tests/functional: add helpers for building file paths

Add helper methods that construct paths for * log files - to be preserved at the end of a test * scratch files - to be purged at the end of a test * build files - anything relative to the build root * data files - anything relative to the functional test source root * socket files - a short t

[PULL 16/19] target/arm: Enable FEAT_XS for the max cpu

From: Manos Pitsidianakis Add FEAT_XS feature report value in max cpu's ID_AA64ISAR1 sys register. Signed-off-by: Manos Pitsidianakis Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 2024121110.2700268-6-peter.mayd...@linaro.org [PMM: Add entry for FEAT_XS to docume

[PULL 17/19] tests/tcg/aarch64: add system test for FEAT_XS

From: Manos Pitsidianakis Add system test to make sure FEAT_XS is enabled for max cpu emulation and that QEMU doesn't crash when encountering an NXS instruction variant. Signed-off-by: Manos Pitsidianakis Signed-off-by: Peter Maydell Message-id: 2024121110.2700268-7-peter.mayd...@linaro.or

[PULL 05/19] target/arm: Convert neon_helper.c to fpst alias

From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20241206031224.78525-6-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.h | 14 +++--- target/arm/tcg/neon_helper.c | 21 +++

[PULL 08/19] target/arm: Convert vec_helper.c to use env alias

From: Richard Henderson Allow the helpers to receive CPUARMState* directly instead of via void*. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20241206031224.78525-9-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.h |

[PULL 18/19] hw/intc/arm_gicv3_its: Zero initialize local DTEntry etc structs

In the GICv3 ITS model, we have a common coding pattern which has a local C struct like "DTEntry dte", which is a C representation of an in-guest-memory data structure, and we call a function such as get_dte() to read guest memory and fill in the C struct. These functions to read in the struct som

[PULL 01/19] target/arm: remove redundant code

From: Denis Rastyogin This call is redundant as it only retrieves a value that is not used further. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Denis Rastyogin Reviewed-by: Richard Henderson Message-id: 20241212120618.518369-1-ger...@altlinux.org Signed-of

[PULL 00/19] target-arm queue

; of https://gitlab.com/kraxel/qemu into staging (2024-12-16 14:20:33 -0500) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20241217 for you to fetch changes up to e91254250acb8570bd7b8a8f89d30e6d18291d02: tests/functional: updat

[PULL 13/19] target/arm: Add ARM_CP_ADD_TLBI_NXS type flag for NXS insns

All of the TLBI insns with an NXS variant put that variant at the same encoding but with a CRn field that is one greater than for the original TLBI insn. To avoid having to define every TLBI insn effectively twice, once in the normal way and once in a set of cpreg arrays that are only registered w

[PULL 07/19] target/arm: Convert sme_helper.c to fpst alias

From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20241206031224.78525-8-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/helper-sme.h | 4 ++-- target/arm/tcg/sme_helper.c | 8 2 files changed, 6 insertions(+)

[PULL 19/19] tests/functional: update sbsa-ref firmware used in test

From: Marcin Juszkiewicz Update the URLs for the binaries we use for the firmware in the sbsa-ref functional tests. The firmware is built using Debian 'bookworm' cross toolchain (gcc 12.2.0). Used versions: - Trusted Firmware v2.12.0 - Tianocore EDK2 stable202411 - Tianocore EDK2 Platforms cod

[PULL 02/19] target/arm: Convert vfp_helper.c to fpst alias

From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20241206031224.78525-3-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.h | 268 target/arm/vfp_helper.c | 120 +

[PATCH v3 01/32] tests/functional: add execute permission to aspeed tests

Tests are expected to be directly invoked when debugging so must have execute permission. Signed-off-by: Daniel P. Berrangé --- tests/functional/test_aarch64_aspeed.py | 0 tests/functional/test_arm_aspeed_ast1030.py | 0 tests/functional/test_arm_aspeed_ast2500.py | 0 tests/functional/t

[PULL 14/19] target/arm: Add ARM_CP_ADD_TLBI_NXS type flag to TLBI insns

Add the ARM_CP_ADD_TLBI_NXS to the TLBI insns with an NXS variant. This is every AArch64 TLBI encoding except for the four FEAT_RME TLBI insns. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 2024121110.2700268-4-peter.mayd...@linaro.org --- target/arm/tcg/tlb-insns.

[PULL 11/19] target/arm: Use float_status in helper_vfp_fcvt{ds,sd}

From: Richard Henderson Pass float_status not env to match other functions. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20241206031952.78776-3-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.h| 4 ++-- target/a

[PULL 15/19] target/arm: Add decodetree entry for DSB nXS variant

From: Manos Pitsidianakis The DSB nXS variant is always both a reads and writes request type. Ignore the domain field like we do in plain DSB and perform a full system barrier operation. The DSB nXS variant is part of FEAT_XS made mandatory from Armv8.7. Signed-off-by: Manos Pitsidianakis Sign

Re: [PATCH] target/arm: Move minor arithmetic helpers out of helper.c

On Tue, 17 Dec 2024 at 18:17, Richard Henderson wrote: > > On 12/17/24 11:44, Peter Maydell wrote: > > helper.c includes some small TCG helper functions used for mostly > > arithmetic instructions. These are TCG only and there's no need for > > them to be in the large and unwieldy helper.c. Move

Re: [PATCH] tests/qtest/migration: Restore include for postcopy

On Tue, Dec 17, 2024 at 06:22:01PM -0300, Fabiano Rosas wrote: > Commit 124a3c58b8 ("tests/qtest/migration: Move ufd_version_check to > utils") moved the ufd_version_check() function to another file but > failed to bring along the include, which is necessary to > pull in for __NR_userfaultd. > >

Re: [PATCH V4 02/19] physmem: fd-based shared memory

On 12/16/2024 1:19 PM, Peter Xu wrote: On Fri, Dec 13, 2024 at 11:41:45AM -0500, Steven Sistare wrote: On 12/12/2024 4:22 PM, Peter Xu wrote: On Thu, Dec 12, 2024 at 03:38:00PM -0500, Steven Sistare wrote: On 12/9/2024 2:42 PM, Peter Xu wrote: On Mon, Dec 02, 2024 at 05:19:54AM -0800, Steve S

[PATCH v3 20/32] tests/functional: let cpio_extract accept filenames

Currently cpio_extract differs from tar_extract/zip_extract in that it only allows a file-like object as input. Adapt it to also support filenames. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/archive.py | 16 +++- 1 file changed, 11 inse

Re: [PATCH v8 06/12] util/dsa: Implement zero page checking in DSA task.

Yichen Wang writes: > From: Hao Xiang > > Create DSA task with operation code DSA_OPCODE_COMPVAL. > Here we create two types of DSA tasks, a single DSA task and > a batch DSA task. Batch DSA task reduces task submission overhead > and hence should be the default option. However, due to the way D

Re: [PATCH v8 07/12] util/dsa: Implement DSA task asynchronous submission and wait for completion.

Yichen Wang writes: > From: Hao Xiang > > * Add a DSA task completion callback. > * DSA completion thread will call the tasks's completion callback > on every task/batch task completion. > * DSA submission path to wait for completion. > * Implement CPU fallback if DSA is not able to complete the

[PATCH v3 04/32] tests/functional: remove duplicated 'which' function impl

Put the 'which' function into shared code. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/__init__.py | 2 +- tests/functional/qemu_test/cmd.py | 10 ++ tests/functional/test_acpi_bits.py | 13 + tests/functional/tes

[PATCH v3 24/32] tests/functional: add a generalized uncompress helper

There are many types of compression that the tests deal with, and it makes sense to have a single helper 'uncompress' that can deal with all. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/__init__.py | 1 + tests/functional/qemu_test/uncompress.py

Re: [PATCH v8 09/12] migration/multifd: Enable DSA offloading in multifd sender path.

Yichen Wang writes: > From: Hao Xiang > > Multifd sender path gets an array of pages queued by the migration > thread. It performs zero page checking on every page in the array. > The pages are classfied as either a zero page or a normal page. This > change uses Intel DSA to offload the zero pag

[PULL 17/17] tests/qtest/migration: Fix compile errors when CONFIG_UADK is set

From: Shameer Kolothum Removes accidental inclusion of unrelated functions within CONFIG_UADK as this causes compile errors like: error: redefinition of ‘migrate_hook_start_xbzrle’ Fixes: 932f74f3fe6e ("tests/qtest/migration: Split compression tests from migration-test.c") Signed-off-by: Shame

[PULL 06/19] target/arm: Convert sve_helper.c to fpst alias

From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20241206031224.78525-7-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/helper-sve.h | 414 ++-- target/arm/tcg/sve_helper.c |

[PULL 03/19] target/arm: Convert helper-a64.c to fpst alias

From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20241206031224.78525-4-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/helper-a64.h | 94 +-- target/arm/tcg/helper-a64.c | 98

[PULL 04/19] target/arm: Convert vec_helper.c to fpst alias

From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20241206031224.78525-5-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.h | 284 ++-- target/arm/tcg/helper-a64.h |

[PULL 10/19] target/arm: Use float_status in helper_fcvtx_f64_to_f32

From: Richard Henderson Pass float_status not env to match other functions. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20241206031952.78776-2-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/helper-a64.h| 2 +- target/arm/

[PULL 09/19] target/arm: Convert neon_helper.c to use env alias

From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20241206031224.78525-10-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.h | 56 ++-- target/arm/tcg/neon_helper.c |

[PULL 12/19] target/arm: Implement fine-grained-trap handling for FEAT_XS

FEAT_XS introduces a set of new TLBI maintenance instructions with an "nXS" qualifier. These behave like the stardard ones except that they do not wait for memory accesses with the XS attribute to complete. They have an interaction with the fine-grained-trap handling: the FGT bits that a hypervis

Re: Missing PDF file download.

On Wed, 20 Nov 2024 at 17:41, Asif wrote: > Secondly, you have broken links on you page: > QEMU Internals: Big Picture Overview > > Broken Link: > Jan Kiszka's Linux Kongress 2010 presentation on the Architecture of the > Kernel-based Virtual Machine (KVM). Very good material. Hi Asif, Sorry for

Re: [PATCH] target/arm: Move minor arithmetic helpers out of helper.c

On 12/17/24 11:44, Peter Maydell wrote: helper.c includes some small TCG helper functions used for mostly arithmetic instructions. These are TCG only and there's no need for them to be in the large and unwieldy helper.c. Move them out to their own source file in the tcg/ subdirectory, together

Re: [PATCH 01/46] tcg/optimize: Split out finish_bb, finish_ebb

On 12/10/24 07:23, Richard Henderson wrote: Call them directly from the opcode switch statement in tcg_optimize, rather than in finish_folding based on opcode flags. Adjust folding of conditional branches to match. Signed-off-by: Richard Henderson --- tcg/optimize.c | 47

Re: [PATCH 02/46] tcg/optimize: Copy mask writeback to fold_masks

On 12/10/24 07:23, Richard Henderson wrote: Use of fold_masks should be restricted to those opcodes that can reliably make use of it -- those with a single output, and from higher-level folders that set up the masks. Prepare for conversion of each folder in turn. Signed-off-by: Richard Henderson

[PATCH v3 23/32] tests/functional: convert tests to new archive_extract helper

Replace use of utils.archive_extract and extract_from_deb with the new archive_extract helper. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/linuxkernel.py | 19 -- tests/functional/test_aarch64_aspeed.py | 5 ++- tests/functional/t

[PATCH v3 07/32] tests/functional: introduce some helpful decorators

Reduce repeated boilerplate with some helper decorators: @skipIfNotPlatform("x86_64", "aarch64") => Skip unless the build host platform matches @skipIfMissingCommands("mkisofs", "losetup") => Skips unless all listed commands are found in $PATH @skipIfMissingImports("numpy", "cv2") =>

[PATCH v3 22/32] tests/functional: add 'archive_extract' to QemuBaseTest

This helper wrappers archive.archive_extract, forcing the use of the scratch directory, to ensure any extracted files are cleaned at test termination. If a specific member is requested, then the path to the extracted file is also returned. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrang

[PATCH] target/arm: Move minor arithmetic helpers out of helper.c

helper.c includes some small TCG helper functions used for mostly arithmetic instructions. These are TCG only and there's no need for them to be in the large and unwieldy helper.c. Move them out to their own source file in the tcg/ subdirectory, together with the op_addsub.h multiply-included tem

Re: [PATCH] tests/functional: Convert the hotplug_cpu avocado test

On 17/12/24 15:20, Thomas Huth wrote: Since we don't have ssh support in the functional test framework yet, simply use the serial console for this test instead. It's also sufficient to only boot into an initrd here, no need to fire up a full-blown guest, so the test now finishes much faster. Whi

[PULL 11/17] migration: Add helper to get target runstate

From: Peter Xu In 99% cases, after QEMU migrates to dest host, it tries to detect the target VM runstate using global_state_get_runstate(). There's one outlier so far which is Xen that won't send global state. That's the major reason why global_state_received() check was always there together wi

[PULL 06/17] migration/multifd: Remove sync processing on postcopy

From: Peter Xu Multifd never worked with postcopy, at least yet so far. Remove the sync processing there, because it's confusing, and they should never appear. Now if RAM_SAVE_FLAG_MULTIFD_FLUSH is observed, we fail hard instead of trying to invoke multifd code. Reviewed-by: Fabiano Rosas Sig

[PULL 13/17] migration/block: Make late-block-active the default

From: Peter Xu Migration capability 'late-block-active' controls when the block drives will be activated. If enabled, block drives will only be activated until VM starts, either src runstate was "live" (RUNNING, or SUSPENDED), or it'll be postponed until qmp_cont(). Let's do this unconditionall

Re: [PATCH v3 32/32] MAINTAINERS: add myself as reviewer for functional test suite

On 17/12/2024 16.59, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 822f34344b..54201da578 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4157,6 +4157,7 @@ W: https://cirrus-ci.com

Re: [PATCH 26/26] rust: callbacks: allow passing optional callbacks as ()

Il mar 17 dic 2024, 16:55 Zhao Liu ha scritto: > On Mon, Dec 09, 2024 at 01:37:17PM +0100, Paolo Bonzini wrote: > > Date: Mon, 9 Dec 2024 13:37:17 +0100 > > From: Paolo Bonzini > > Subject: [PATCH 26/26] rust: callbacks: allow passing optional callbacks > as > > () > > X-Mailer: git-send-email

Re: [PATCH RFCv2 00/20] kvm/arm: Introduce a customizable aarch64 KVM host model

Hi Marc, On 12/17/24 16:21, Marc Zyngier wrote: > On Fri, 06 Dec 2024 11:21:53 +, > Cornelia Huck wrote: >> A respin/update on the aarch64 KVM cpu models. Also available at >> gitlab.com/cohuck/qemu arm-cpu-model-rfcv2 >> >> Find Eric's original cover letter below, so that I do not need to >>

[PATCH v3 14/32] tests/functional: switch over to using self.scratch_file()

Replace any instances of os.path.join(self.workdir, ".../...") self.workdir + "/.../..." with self.scratch_file("...", "...") which is more compact and portable Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/linuxkernel.py | 7 ++- tests

Re: [PATCH 2/2] target/i386: Print CPUID subleaf info for unsupported feature

On Tue, Dec 17, 2024 at 07:39:32AM -0500, Xiaoyao Li wrote: > Date: Tue, 17 Dec 2024 07:39:32 -0500 > From: Xiaoyao Li > Subject: [PATCH 2/2] target/i386: Print CPUID subleaf info for unsupported > feature > X-Mailer: git-send-email 2.34.1 > > Some CPUID leaves have meaningful subleaf index. Pri

Re: [PATCH 1/3] hw/xen: Remove unnecessary 'exec/cpu-common.h' header

On Tue, Dec 17, 2024 at 04:13:03PM +0100, Philippe Mathieu-Daudé wrote: > Date: Tue, 17 Dec 2024 16:13:03 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH 1/3] hw/xen: Remove unnecessary 'exec/cpu-common.h' header > X-Mailer: git-send-email 2.45.2 > > Nothing requires definitions from "exec

Re: [PATCH 24/26] rust: qom: move device_id to PL011 class side

Il mar 17 dic 2024, 04:39 Zhao Liu ha scritto: > > +impl ClassInitImpl for PL011State { > > +fn class_init(klass: &mut PL011Class) { > > +klass.device_id = DeviceId::ARM; > > +>::class_init(&mut > klass.parent_class); > > This seems a bit of a conflict with the C version of QO

Re: [PATCH 1/2] i386: Remove unused parameter "uint32_t bit" in feature_word_description()

On Tue, Dec 17, 2024 at 07:39:31AM -0500, Xiaoyao Li wrote: > Date: Tue, 17 Dec 2024 07:39:31 -0500 > From: Xiaoyao Li > Subject: [PATCH 1/2] i386: Remove unused parameter "uint32_t bit" in > feature_word_description() > X-Mailer: git-send-email 2.34.1 > > From: Lei Wang > > Parameter "uint32_

[PATCH v3 02/32] tests/functional: remove many unused imports

Identified using 'pylint --disable=all --enable=W0611' Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/asset.py | 1 - tests/functional/qemu_test/tesseract.py | 1 - tests/functional/qemu_test/tuxruntest.py | 3 +-- tests/f

Re: [PATCH v3 03/32] tests/functional: resolve str(Asset) to cache file path

On 12/17/24 09:59, Daniel P. Berrangé wrote: Allow an Asset object to be used in place of a filename but making its string representation resolve to the cache file path. Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/asset.py | 3 +++ 1 file changed, 3 insertions(+) Review

Re: [PATCH v3 01/32] tests/functional: add execute permission to aspeed tests

On 12/17/24 09:59, Daniel P. Berrangé wrote: Tests are expected to be directly invoked when debugging so must have execute permission. Signed-off-by: Daniel P. Berrangé Reviewed-by: Richard Henderson r~ --- tests/functional/test_aarch64_aspeed.py | 0 tests/functional/test_arm_aspe

[PATCH v3 30/32] tests/functional: skip tests if assets are not available

If downloading of assets has been disabled, then skip running a test if the assets it has registered are not already downloaded. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/asset.py| 8 +++- tests/functional/qemu_test/testcase.py | 11 +

<    1   2   3   4   >