On 17/12/2024 04:44, Alistair Francis wrote:
> On Fri, Nov 29, 2024 at 12:15 AM Clément Léger wrote:
>>
>> A double trap typically arises during a sensitive phase in trap handling
>> operations — when an exception or interrupt occurs while the trap
>> handler (the component responsible for mana
From: Alexey Baturo
Zjpm extension is finally ratified. And it's much simplier compared to the
experimental one.
The newer version doesn't allow to specify custom mask or base for pointer
masking.
Instead it allows only certain options for masking top bits.
Signed-off-by: Alexey Baturo
Acked-
From: Alexey Baturo
Signed-off-by: Alexey Baturo
Reviewed-by: Daniel Henrique Barboza
Reviewed-by: Alistair Francis
---
target/riscv/cpu.h | 1 +
target/riscv/cpu_helper.c| 19 +
target/riscv/internals.h | 54
target/riscv/op
From: Alexey Baturo
Hi,
Rebased and addressed Alistair's comments on code style.
Thanks
[v13]:
Rebased and addressed Daniel's comments about the return type of the helper.
Thanks
[v12]:
Rebased and addressed Richard's comments about proper masking virtualized
accesses.
Thanks
[v11]:
As su
From: Alexey Baturo
Signed-off-by: Alexey Baturo
Reviewed-by: Alistair Francis
---
target/riscv/cpu.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 0a00be66f1..144ce822d5 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -186,
From: Alexey Baturo
Signed-off-by: Alexey Baturo
Reviewed-by: Richard Henderson
Reviewed-by: Alistair Francis
---
target/riscv/translate.c | 22 --
target/riscv/vector_helper.c | 16
2 files changed, 32 insertions(+), 6 deletions(-)
diff --git a/targe
From: Alexey Baturo
Signed-off-by: Alexey Baturo
Reviewed-by: Richard Henderson
Reviewed-by: Alistair Francis
Reviewed-by: LIU Zhiwei
---
target/riscv/cpu.h| 3 +++
target/riscv/cpu_helper.c | 3 +++
target/riscv/translate.c | 5 +
3 files changed, 11 insertions(+)
diff --git a
From: Alexey Baturo
Signed-off-by: Alexey Baturo
Reviewed-by: Daniel Henrique Barboza
Reviewed-by: Alistair Francis
---
target/riscv/cpu.h | 8
target/riscv/cpu_bits.h | 4
target/riscv/cpu_cfg.h | 3 +++
target/riscv/csr.c | 31 ++-
tar
From: Alexey Baturo
Signed-off-by: Alexey Baturo
Reviewed-by: Daniel Henrique Barboza
---
target/riscv/cpu.h| 5 +++
target/riscv/cpu_helper.c | 78 +++
2 files changed, 83 insertions(+)
diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 41
Hi Alistair,
Thanks for the review. I've tried to address your comments and submitted a
new version.
Could you please take a look if it's ok with you and if so, could you
please put these patches to the queue for the next qemu update?
Thanks!
вт, 17 дек. 2024 г. в 09:13, Alistair Francis :
> On
17.12.2024 14:13, Michael Tokarev wrote:
12.12.2024 11:44, Gerd Hoffmann wrote:
Needed to build ipxe nic roms.
This one seems to be for qemu-stable too, no?
For 8.2.x, I also picked 6539c73dccfa8fff1
"edk2: get version + date from git submodule",
fwiw.
Thanks,
/mjt
Some CPUID leaves have meaningful subleaf index. Print the subleaf info
in feature_word_description for CPUID features.
Signed-off-by: Xiaoyao Li
Reviewed-by: Eduardo Habkost
---
target/i386/cpu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/i386/cpu.c b/targe
From: Lei Wang
Parameter "uint32_t bit" is not used in function feature_word_description(),
so remove it.
Signed-off-by: Lei Wang
Reviewed-by: Igor Mammedov
Reviewed-by: Xiaoyao Li
Signed-off-by: Xiaoyao Li
---
target/i386/cpu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
dif
On 12/16/24 19:06, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier
---
tests/tcg/plugins/insn.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Richard Henderson
r~
diff --git a/tests/tcg/plugins/insn.c b/tests/tcg/plugins/insn.c
index baf2d07205d..0c723cb
On 12/16/24 19:06, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier
---
contrib/plugins/howvec.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson
r~
On 12/12/24 00:53, Richard Henderson wrote:
On 12/11/24 17:03, Philippe Mathieu-Daudé wrote:
Some files indirectly get "exec/tswap.h" declarations via
"exec/cpu-all.h". Include it directly to be able to remove
the former from the latter, otherwise we get:
hw/arm/boot.c:175:19: error: call to
Do not include "exec/cpu-common.h" when we don't need it.
(I plan to merge this series myself).
Philippe Mathieu-Daudé (3):
hw/xen: Remove unnecessary 'exec/cpu-common.h' header
system/numa: Remove unnecessary 'exec/cpu-common.h' header
system/accel-ops: Remove unnecessary 'exec/cpu-common.
Nothing requires definitions from "exec/cpu-common.h",
do not include this header.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/xen/xen.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h
index ecb89ecfc14..e94c6e5a318 100644
--- a/include/h
Nothing requires definitions from "exec/cpu-common.h",
do not include this header.
Signed-off-by: Philippe Mathieu-Daudé
---
include/sysemu/numa.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/sysemu/numa.h b/include/sysemu/numa.h
index 04676141470..1338db9502d 100644
--- a/include/
On Fri, 06 Dec 2024 11:21:53 +,
Cornelia Huck wrote:
>
> A respin/update on the aarch64 KVM cpu models. Also available at
> gitlab.com/cohuck/qemu arm-cpu-model-rfcv2
>
> Find Eric's original cover letter below, so that I do not need to
> repeat myself on the aspects that have not changed si
Hi,
> +Fw-cfg Files
> +
> +
> +Guests drive vmfwupdate through special ``fw-cfg`` files that control its
> flow
> +followed by a standard system reset operation. When vmfwupdate is available,
> +it provides the following ``fw-cfg`` files:
> +
> +* ``vmfwupdate/cap`` (``u64``) - Read
Since commit c4b3f46c151 ("include/exec: Move vaddr defines to
separate file") we only need to include "exec/vaddr.h" to get
the 'vaddr' type definition, no need for "exec/cpu-common.h".
Signed-off-by: Philippe Mathieu-Daudé
---
include/sysemu/accel-ops.h | 2 +-
1 file changed, 1 insertion(+),
Pierrick Bouvier writes:
> Signed-off-by: Pierrick Bouvier
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
On 12/16/24 19:06, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier
---
tests/tcg/plugins/syscall.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson
r~
diff --git a/tests/tcg/plugins/syscall.c b/tests/tcg/plugins/syscall.c
index ff452178
On Tue, 17 Dec 2024 at 07:10, Marcin Juszkiewicz
wrote:
>
> W dniu 16.12.2024 o 13:46, Peter Maydell pisze:
> > On Mon, 25 Nov 2024 at 13:25, Peter Maydell
> > wrote:
> >>
> >> On Mon, 25 Nov 2024 at 12:54, Marcin Juszkiewicz
> >> wrote:
> >>>
> >>> Firmware is built using Debian 'bookworm' cro
Peter Xu writes:
> CI: https://gitlab.com/peterx/qemu/-/pipelines/1577280033
> (note: it's a pipeline of two patchsets, to save CI credits and time)
>
> v1: https://lore.kernel.org/r/20241205185303.897010-1-pet...@redhat.com
> v2: https://lore.kernel.org/r/20241206005834.1050905-1-pet...@redhat.
Shameer Kolothum via writes:
> Removes accidental inclusion of unrelated functions within CONFIG_UADK
> as this causes compile errors like:
>
> error: redefinition of ‘migrate_hook_start_xbzrle’
>
> Fixes: 932f74f3fe6e ("tests/qtest/migration: Split compression tests from
> migration-test.c")
>
Peter Xu writes:
> CI: https://gitlab.com/peterx/qemu/-/pipelines/1577280033
> (note: it's a pipeline of two patchsets, to save CI credits and time)
>
> v1: https://lore.kernel.org/r/20241204005138.702289-1-pet...@redhat.com
>
> This is v2 of the series, removing RFC tag, because my goal is to h
On 12/16/24 19:07, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier
---
tests/tcg/plugins/mem.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson
r~
diff --git a/tests/tcg/plugins/mem.c b/tests/tcg/plugins/mem.c
index b0fa8a9f277..d87d662
On 17/12/24 11:06, Ani Sinha wrote:
On 16 Dec 2024, at 8:35 PM, Philippe Mathieu-Daudé wrote:
Hi Ani,
On 16/12/24 12:48, Ani Sinha wrote:
VM firmware update is a mechanism where the virtual machines can use their
preferred and trusted firmware image in their execution environment without
h
This series grabs two patches related to feature_word_description() from
two different old threads, they are simple and straightforward.
Patch 1 is grabbed from [1] while patch 2 is grabbed from [2].
[1]:
https://lore.kernel.org/qemu-devel/20230106083826.5384-3-lei4.w...@intel.com/
[2]:
https:
On 17.12.24 12:12, Michael Tokarev wrote:
12.12.2024 12:00, Heinrich Schuchardt wrote:
Without descriptor libvirt cannot discover the EDK II binaries via
the qemu:///system connection.
Shouldn't this one be picked up for qemu-stable@?
Thanks,
/mjt
Hello Michael,
Yes, please, the patch sho
On 12/16/24 19:07, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier
---
contrib/plugins/hotblocks.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c
index 02bc5078bdd..09b0932275c 100644
--- a/contrib/
On 12/16/24 19:07, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier
---
contrib/plugins/cflow.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson
r~
diff --git a/contrib/plugins/cflow.c b/contrib/plugins/cflow.c
index b39974
On 12/16/24 19:07, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier
---
configure | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
Reviewed-by: Richard Henderson
r~
diff --git a/configure b/configure
index 18336376bff..02f1dd2311f 100755
--- a/configur
On 12/16/24 19:07, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier
---
contrib/plugins/hotpages.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson
r~
diff --git a/contrib/plugins/hotpages.c b/contrib/plugins/hotpages.c
index 8316ae50c72
On 12/16/24 19:07, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier
---
contrib/plugins/hwprofile.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
Reviewed-by: Richard Henderson
r~
diff --git a/contrib/plugins/hwprofile.c b/contrib/plugins/hw
On 12/17/24 09:13, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (3):
hw/xen: Remove unnecessary 'exec/cpu-common.h' header
system/numa: Remove unnecessary 'exec/cpu-common.h' header
system/accel-ops: Remove unnecessary 'exec/cpu-common.h' header
Reviewed-by: Richard Henderson
On 16/12/2024 23:43, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 12/16/24 10:46, Avihai Horon wrote:
Hello,
This follows up on Peter's series [1] to simplify migration status API
to a single migration_is_running() function.
Peter's series tried to dr
On 17/12/2024 5:01, Yong Huang wrote:
*External email: Use caution opening links or attachments*
On Mon, Dec 16, 2024 at 5:47 PM Avihai Horon wrote:
vcpu_dirty_rate_stat_collect() uses migration_is_active() to detect
whether migration is running or not, in order to get the correct
As described in docs/devel/qapi-code-gen.rst line 998,
there should be no space between "Since" and ":".
Signed-off-by: Victor Toso
---
qapi/cxl.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qapi/cxl.json b/qapi/cxl.json
index 9f65589bce..dd947d3bbc 100644
--- a/qa
On Fri, 6 Dec 2024 at 16:02, Alex Bennée wrote:
>
> When FEAT_SEL2 was implemented the SEL2 timers where missed. This
> shows up when building the latest Hafnium with SPMC_AT_EL=2. The
> actual implementation utilises the same logic as the rest of the
> timers so all we need to do is:
>
> - defi
The workaround applied in
commit c60473d29254b79d9437eface8b342e84663ba66
Author: Alex Bennée
Date: Wed Oct 2 10:03:33 2024 +0200
testing: bump mips64el cross to bookworm and fix package list
Is no longer required since the affected builds are now fixed.
Signed-off-by: Daniel P. Be
On 17/12/24 12:09, Ani Sinha wrote:
On 17 Dec 2024, at 4:11 PM, Philippe Mathieu-Daudé wrote:
On 17/12/24 11:06, Ani Sinha wrote:
On 16 Dec 2024, at 8:35 PM, Philippe Mathieu-Daudé wrote:
Hi Ani,
+static void vmfwupdate_device_class_init(ObjectClass *klass, void *data)
+{
+DeviceC
On Thu, Dec 12, 2024 at 11:24:03AM -0600, Ira Weiny wrote:
> On Wed, Nov 06, 2024 at 07:13:56AM +0200, Tony Lindgren wrote:
> > On Wed, Nov 06, 2024 at 10:01:04AM +0800, Xiaoyao Li wrote:
> > > On 11/6/2024 4:51 AM, Edgecombe, Rick P wrote:
> > > > +Tony
> > > >
> > > > On Tue, 2024-11-05 at 01:23
Hi, all:
Recently, when I was writing a RISCV test, I found that when VL is set to 0, the
instruction should be nop, but when I tested it, I found that QEMU will treat
all elements as tail elements, and in the case of VTA=1, write all elements
to 1.
After troubleshooting, it was found that the ve
fix:
https://lore.kernel.org/all/20240322085319.1758843-8-alistair.fran...@wdc.com/
Signed-off-by: Chao Liu
---
target/riscv/vector_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
index a85dd1d200..54bac
11.04.2024 12:48, Gerd Hoffmann wrote:
If the binary loaded via -kernel is *not* a linux kernel (in which
case protocol == 0), do not patch the linux kernel header fields.
It's (a) pointless and (b) might break binaries by random patching
and (c) changes the binary hash which in turn breaks secu
12.12.2024 12:00, Heinrich Schuchardt wrote:
Without descriptor libvirt cannot discover the EDK II binaries via
the qemu:///system connection.
Shouldn't this one be picked up for qemu-stable@?
Thanks,
/mjt
> On 17 Dec 2024, at 4:11 PM, Philippe Mathieu-Daudé wrote:
>
> On 17/12/24 11:06, Ani Sinha wrote:
>>> On 16 Dec 2024, at 8:35 PM, Philippe Mathieu-Daudé
>>> wrote:
>>>
>>> Hi Ani,
>>>
>>> On 16/12/24 12:48, Ani Sinha wrote:
VM firmware update is a mechanism where the virtual machine
12.12.2024 11:44, Gerd Hoffmann wrote:
Needed to build ipxe nic roms.
This one seems to be for qemu-stable too, no?
Thanks,
/mjt
On 12/13/24 15:42, Ira Weiny wrote:
On Tue, Nov 05, 2024 at 01:23:51AM -0500, Xiaoyao Li wrote:
For TDs, only MSR_IA32_UCODE_REV in kvm_init_msrs() can be configured
by VMM, while the features enumerated/controlled by other MSRs except
MSR_IA32_UCODE_REV in kvm_init_msrs() are not under control
On 16/12/2024 17:58, Joao Martins wrote:
External email: Use caution opening links or attachments
On 16/12/2024 14:55, Avihai Horon wrote:
On 16/12/2024 14:45, Joao Martins wrote:
External email: Use caution opening links or attachments
On 16/12/2024 09:46, Avihai Horon wrote:
During DMA
> On 16 Dec 2024, at 8:35 PM, Philippe Mathieu-Daudé wrote:
>
> Hi Ani,
>
> On 16/12/24 12:48, Ani Sinha wrote:
>> VM firmware update is a mechanism where the virtual machines can use their
>> preferred and trusted firmware image in their execution environment without
>> having to depend on a
On Tue, 2024-12-17 at 15:13 +0100, Philippe Mathieu-Daudé wrote:
> We have 2 headers using qatomic_read() without including
> its declaration from "qemu/atomic.h". Include the missing
> header. For my own convenience I plan to merge these 2 patches
> via my tree.
>
> Regards,
>
> Phil.
>
> Phili
On 12/16/24 19:06, Pierrick Bouvier wrote:
It makes more sense to return the same type than qemu_plugin_insn_vaddr.
Signed-off-by: Pierrick Bouvier
---
include/qemu/qemu-plugin.h | 2 +-
plugins/api.c | 12 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
No, it
Standard simpoint tool reqeusts that index of basic block index starts from 1.
Signed-off-by: ckf104 <1900011...@pku.edu.cn>
---
contrib/plugins/bbv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/plugins/bbv.c b/contrib/plugins/bbv.c
index a5256517dd..b9da6f815e 100
On Tue, Dec 17, 2024 at 01:10:46PM +, Shameer Kolothum wrote:
> Removes accidental inclusion of unrelated functions within CONFIG_UADK
> as this causes compile errors like:
>
> error: redefinition of ‘migrate_hook_start_xbzrle’
>
> Fixes: 932f74f3fe6e ("tests/qtest/migration: Split compressio
> +pub unsafe trait FnCall: 'static + Sync + Sized {
> +/// Referring to this internal constant asserts that the `Self` type is
> +/// zero-sized. Can be replaced by an inline const expression in
> +/// Rust 1.79.0+.
> +const ASSERT_ZERO_SIZED: () = { assert!(mem::size_of::() == 0)
On Tue, Dec 17, 2024 at 12:15:36AM +0100, Maciej S. Szmigiero wrote:
> On 16.12.2024 17:29, Peter Xu wrote:
> > On Thu, Dec 12, 2024 at 11:53:24PM +0100, Maciej S. Szmigiero wrote:
> > > On 12.12.2024 17:38, Peter Xu wrote:
> > > > On Wed, Dec 11, 2024 at 12:05:23AM +0100, Maciej S. Szmigiero wrote
On Tue, 17 Dec 2024 at 07:40, Alex Bennée wrote:
>
> Pierrick Bouvier writes:
>
> > On 12/16/24 11:50, Richard Henderson wrote:
> >> On 12/16/24 13:26, Pierrick Bouvier wrote:
> >>> On 12/16/24 11:10, Richard Henderson wrote:
> On 12/4/24 15:12, Pierrick Bouvier wrote:
> > qemu-system-aa
The first patch introduces a helper function for retrieving the
hostfwd ports from QEMU.
We then use this helper function to run a HTTP server in the guest
in the second patch to exercise the network of the guest.
v3:
- Use the new hostfwd helper function instead of trying to probe
for an unused
Convert the intel_iommu test to the new functional framework.
This test needs some changes since we neither support the old 'LinuxTest'
class in the functional framework yet, nor a way to use SSH for running
commands in the guest. So we now directly download a Fedora kernel and
initrd and set up th
It's just a wrapper around get_info_usernet_hostfwd_port from the
qemu module that is also calling the right monitor command for
retrieving the information from QEMU.
Signed-off-by: Thomas Huth
---
tests/functional/qemu_test/utils.py | 7 +++
tests/functional/test_info_usernet.py | 8 +++--
Since we don't have ssh support in the functional test framework yet,
simply use the serial console for this test instead. It's also
sufficient to only boot into an initrd here, no need to fire up a
full-blown guest, so the test now finishes much faster.
While we're at it, also unplug the CPU now
On 12/16/24 15:40, Philippe Mathieu-Daudé wrote:
curr_cflags() is only used within accel/tcg/,
move its declaration to accel/tcg/internal-common.h.
Suggested-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/internal-common.h | 3 +++
include/exec/cpu-common.h | 3
On Sun, 8 Sep 2024 20:59:13 +0800
Zhao Liu wrote:
> Hi all,
>
> Compared with previous Patch v1 [1], I've put the cache properties
> list into -machine, this is to meet current needs and also remain
> compatible with my future topology support (more discussion details,
> pls refer [2]).
>
> Th
On Tue, Dec 17, 2024 at 02:15:15PM +, Daniel P. Berrangé wrote:
> On Mon, Dec 16, 2024 at 11:50:49AM +0100, Gerd Hoffmann wrote:
> > Add a new "etc/boot/kernel" fw_cfg file, containing the kernel without
> > the setup header patches. Intended use is booting in UEFI with secure
> > boot enabled
On 12/17/24 08:06, Philippe Mathieu-Daudé wrote:
Move cpu_loop_exit_requested() declaration to "exec/cpu-common.h",
along with the related cpu_loop_exit_noexc(), cpu_loop_exit(),
cpu_loop_exit_atomic() and cpu_loop_exit_restore() methods.
Signed-off-by: Philippe Mathieu-Daudé
---
Based-on:<20241
On Tue, Dec 17, 2024 at 03:26:35PM +0100, Gerd Hoffmann wrote:
> On Tue, Dec 17, 2024 at 02:15:15PM +, Daniel P. Berrangé wrote:
> > On Mon, Dec 16, 2024 at 11:50:49AM +0100, Gerd Hoffmann wrote:
> > > Add a new "etc/boot/kernel" fw_cfg file, containing the kernel without
> > > the setup header
PropertyInfo member @name becomes ObjectProperty member @type, while
Property member @name becomes ObjectProperty member @name. Rename the
former.
Signed-off-by: Markus Armbruster
---
include/hw/qdev-properties.h | 2 +-
backends/tpm/tpm_util.c | 2 +-
hw/block/xen-block.c
Signed-off-by: Markus Armbruster
---
hw/block/xen-block.c | 2 +-
hw/core/qdev-properties-system.c | 2 +-
hw/core/qdev-properties.c| 1 +
hw/s390x/ccw-device.c| 4 ++--
target/sparc/cpu.c | 1 +
5 files changed, 6 insertions(+), 4 deletions(-)
diff
On 12/17/24 08:13, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (2):
exec/translation-block: Include missing 'qemu/atomic.h' header
qemu/coroutine: Include missing 'qemu/atomic.h' header
Reviewed-by: Richard Henderson
r~
QOM properties could use similar work. Left for another day.
Markus Armbruster (6):
qdev: Delete unused qdev_prop_enum
qdev: Change qdev_prop_pci_devfn member @name from "int32" to "str"
qdev: Rename PropertyInfo member @name to @type
qdev: Change values of PropertyInfo member @type to be
PropertyInfo member @type is externally visible via QMP
device-list-properties and qom-list-properies.
Its meaning is not documented at its definition.
It gets passed to as @type argument to object_property_add() and
object_class_property_add(). This argument's documentation isn't of
much help,
Signed-off-by: Markus Armbruster
---
include/hw/qdev-properties.h | 1 -
hw/core/qdev-properties.c| 7 ---
2 files changed, 8 deletions(-)
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 26ebd23068..1e7ae2e01a 100644
--- a/include/hw/qdev-properties.h
+++ b
Consistently use format "DESCRIPTION (VALUE/VALUE...)".
Signed-off-by: Markus Armbruster
---
hw/core/qdev-properties-system.c | 26 +++---
1 file changed, 11 insertions(+), 15 deletions(-)
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index
Properties using qdev_prop_pci_devfn initially accepted a string of
the form "DEV.FN" or "DEV" where DEV and FN are in hexadecimal.
Member @name was "pci-devfn" initially.
Commit b403298adb5 (qdev: make the non-legacy pci address property
accept an integer) changed them to additionally accept inte
Hi Markus,
Thanks for the explicit info. But I have a lot to ask :)
Do I understand correctly that there are two ways to parse
arguments: classic, via qemu_opts_parse_noisily() and modern, via
qobject_input_visitor_new_str()? (for example, I look in
net/net.c, netdev_parse_modern()). My goal is no
On 17/12/2024 09:38, Avihai Horon wrote:
> +bool vfio_dma_unmap_dirty_sync_needed(const VFIOContainerBase
> *bcontainer)
> {
> - VFIODevice *vbasedev;
> -
> - if (!migration_is_active()) {
> + if (!migration_is_running()) {
> return false;
>>>
On 16/12/2024 21:53, Joao Martins wrote:
External email: Use caution opening links or attachments
On 16/12/2024 16:05, Joao Martins wrote:
On 16/12/2024 15:52, Joao Martins wrote:
On 16/12/2024 14:52, Avihai Horon wrote:
On 16/12/2024 14:32, Joao Martins wrote:
External email: Use caution
Removes accidental inclusion of unrelated functions within CONFIG_UADK
as this causes compile errors like:
error: redefinition of ‘migrate_hook_start_xbzrle’
Fixes: 932f74f3fe6e ("tests/qtest/migration: Split compression tests from
migration-test.c")
Signed-off-by: Shameer Kolothum
---
tests/q
On Tue, Dec 17, 2024 at 5:47 PM Avihai Horon wrote:
>
> On 17/12/2024 5:01, Yong Huang wrote:
> > *External email: Use caution opening links or attachments*
> >
> >
> >
> >
> > On Mon, Dec 16, 2024 at 5:47 PM Avihai Horon wrote:
> >
> > vcpu_dirty_rate_stat_collect() uses migration_is_active
On 12/16/24 10:46, Avihai Horon wrote:
After being removed from VFIO and dirty limit, migration_is_active() no
longer has any users outside the migration subsystem, and in fact, it's
only used in migration.c.
Unexport it and also relocate it so it can be made static.
Signed-off-by: Avihai Horon
On 12/16/24 10:46, Avihai Horon wrote:
After being removed from VFIO, migration_is_device() no longer has any
users. Drop it.
Signed-off-by: Avihai Horon
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
include/migration/misc.h | 1 -
migration/migration.c| 7 ---
2 files chang
On Mon, 16 Dec 2024 at 19:32, Alex Bennée wrote:
>
> Peter Maydell writes:
>
> > On Fri, 6 Dec 2024 at 16:02, Alex Bennée wrote:
> >>
> >> When FEAT_SEL2 was implemented the SEL2 timers where missed. This
> >> shows up when building the latest Hafnium with SPMC_AT_EL=2. The
> >> actual implement
On Mon, 16 Dec 2024 at 19:27, Nabih Estefan wrote:
>
> Actually after some more debugging with the help of Roque (cc'd) we
> realized that this patch doesn't actually fix the issue, it only hides
> it behind the watchdog.
>
> The root issue comes from
> https://lists.gnu.org/archive/html/qemu-s390
Philippe Mathieu-Daudé writes:
> Move cpu_loop_exit_requested() declaration to "exec/cpu-common.h",
> along with the related cpu_loop_exit_noexc(), cpu_loop_exit(),
> cpu_loop_exit_atomic() and cpu_loop_exit_restore() methods.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
Move cpu_loop_exit_requested() declaration to "exec/cpu-common.h",
along with the related cpu_loop_exit_noexc(), cpu_loop_exit(),
cpu_loop_exit_atomic() and cpu_loop_exit_restore() methods.
Signed-off-by: Philippe Mathieu-Daudé
---
Based-on: <20241212185341.2857-19-phi...@linaro.org>
---
include
Shameer Kolothum via writes:
> Removes accidental inclusion of unrelated functions within CONFIG_UADK
> as this causes compile errors like:
>
> error: redefinition of ‘migrate_hook_start_xbzrle’
>
> Fixes: 932f74f3fe6e ("tests/qtest/migration: Split compression tests from
> migration-test.c")
>
On Tue, Dec 17, 2024 at 02:13:48PM +0300, Michael Tokarev wrote:
> 12.12.2024 11:44, Gerd Hoffmann wrote:
> > Needed to build ipxe nic roms.
>
> This one seems to be for qemu-stable too, no?
Yes, makes sense indeed.
thanks,
Gerd
When moving tb_cflags() in commit 88d4b5138a8 ("tcg: Make
tb_cflags() usable from target-agnostic code") we forgot to
include "qemu/atomic.h", which declares qatomic_read().
Explicitly include it now to avoid issue when refactoring
unrelated headers.
Signed-off-by: Philippe Mathieu-Daudé
---
inc
On Tue, Dec 17, 2024 at 02:09:30PM +0300, Michael Tokarev wrote:
> 11.04.2024 12:48, Gerd Hoffmann wrote:
> > If the binary loaded via -kernel is *not* a linux kernel (in which
> > case protocol == 0), do not patch the linux kernel header fields.
> >
> > It's (a) pointless and (b) might break bina
We have 2 headers using qatomic_read() without including
its declaration from "qemu/atomic.h". Include the missing
header. For my own convenience I plan to merge these 2 patches
via my tree.
Regards,
Phil.
Philippe Mathieu-Daudé (2):
exec/translation-block: Include missing 'qemu/atomic.h' head
Commit 944f3d5dd21 ("coroutine: Add qemu_co_mutex_assert_locked")
added an inline method which uses qatomic_read(), itself declared
in "qemu/atomic.h". Explicitly include it now to avoid issue when
refactoring unrelated headers.
Signed-off-by: Philippe Mathieu-Daudé
---
include/qemu/coroutine.h
On Mon, Dec 16, 2024 at 11:50:49AM +0100, Gerd Hoffmann wrote:
> Add a new "etc/boot/kernel" fw_cfg file, containing the kernel without
> the setup header patches. Intended use is booting in UEFI with secure
> boot enabled, where the setup header patching breaks secure boot
> verification.
>
> Ne
With the current implementation, if we had the following scenario:
- Set bit x in menvcfg
- Set bit x in henvcfg
- Clear bit x in menvcfg
then, the internal variable env->henvcfg would still contain bit x due
to both a wrong menvcfg mask used in write_henvcfg() as well as a
missing update of henvcf
When the Ssdbltrp extension is enabled, SSTATUS.SDT field is cleared
when executing sret. When executing mret/mnret, SSTATUS.SDT is cleared
when returning to U, VS or VU and VSSTATUS.SDT is cleared when returning
to VU from HS.
Signed-off-by: Clément Léger
Reviewed-by: Alistair Francis
---
targ
Add ext_ssdbltrp in RISCVCPUConfig and implement MSTATUS.SDT,
{H|M}ENVCFG.DTE and modify the availability of MTVAL2 based on the
presence of the Ssdbltrp ISA extension.
Signed-off-by: Clément Léger
Reviewed-by: Daniel Henrique Barboza
Reviewed-by: Alistair Francis
---
target/riscv/cpu.h
When the Ssdbltrp extension is enabled, SSTATUS.MDT field is cleared
when executing sret if executed in M-mode. When executing mret/mnret,
SSTATUS.MDT is cleared.
Signed-off-by: Clément Léger
Reviewed-by: Alistair Francis
---
target/riscv/op_helper.c | 12
1 file changed, 12 insert
1 - 100 of 315 matches
Mail list logo
