[PATCH v4 7/7] system/physmem: Memory settings applied on remap notification

2024-12-14 Thread “William Roche
From: William Roche Merging and dump settings are handled by the remap notification in addition to memory policy and preallocation. Signed-off-by: William Roche --- system/physmem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/system/physmem.c b/system/physmem.c index 9fc74a5699..c0bfa

[PATCH v4 4/7] numa: Introduce and use ram_block_notify_remap()

2024-12-14 Thread “William Roche
From: David Hildenbrand Notify registered listeners about the remap at the end of qemu_ram_remap() so e.g., a memory backend can re-apply its settings correctly. Signed-off-by: David Hildenbrand Signed-off-by: William Roche --- hw/core/numa.c | 11 +++ include/exec/ramlist.h |

[PATCH v4 6/7] hostmem: Handle remapping of RAM

2024-12-14 Thread “William Roche
From: David Hildenbrand Let's register a RAM block notifier and react on remap notifications. Simply re-apply the settings. Exit if something goes wrong. Note: qemu_ram_remap() will not remap when RAM_PREALLOC is set. Could be that hostmem is still missing to update that flag ... Signed-off-by:

[PATCH v4 2/7] system/physmem: poisoned memory discard on reboot

2024-12-14 Thread “William Roche
From: William Roche Repair poisoned memory location(s), calling ram_block_discard_range(): punching a hole in the backend file when necessary and regenerating a usable memory. If the kernel doesn't support the madvise calls used by this function and we are dealing with anonymous memory, fall back

Re: contrib/plugins does not build on 32-bit host

2024-12-14 Thread Philippe Mathieu-Daudé
On 14/12/24 06:29, Richard Henderson wrote: On 12/13/24 21:44, Pierrick Bouvier wrote: Hi Richard, On 12/13/24 13:47, Richard Henderson wrote: Hi, Several of the recent contrib/plugins/ patches do not build on e.g. arm32. All of the issues are related to casting between pointers and uint64_

Re: [PATCH] hw/m68k/next-cube: Disable the default CD-ROM drive

2024-12-14 Thread Philippe Mathieu-Daudé
On 14/12/24 10:17, Thomas Huth wrote: The NeXT-Cube does not have a CD-ROM drive by default, and the kernel does not seem to deal with the empty drive very well, so let's disable the CD-ROM drive for this machine. Signed-off-by: Thomas Huth --- hw/m68k/next-cube.c | 1 + 1 file changed, 1 in

Re: [PATCH v2 10/34] next-cube: map ESCC registers as a subregion of the next.scr memory region

2024-12-14 Thread Philippe Mathieu-Daudé
On 12/12/24 12:45, Mark Cave-Ayland wrote: Since the ESCC device exists within the memory range of the next.scr memory region, map the ESCC device registers as a subregion of the next.scr memory region instead of directly to the system address space. Signed-off-by: Mark Cave-Ayland Reviewed-b

Re: [PATCH v2 03/34] next-cube: create new next.scsi container memory region

2024-12-14 Thread Philippe Mathieu-Daudé
On 12/12/24 12:45, Mark Cave-Ayland wrote: Move the ESP SCSI and SCSI CSR registers to the new next.scsi container memory region. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 11/34] next-cube: move ESCC to be QOM child of next-pc device

2024-12-14 Thread Philippe Mathieu-Daudé
On 14/12/24 07:10, Thomas Huth wrote: Am Thu, 12 Dec 2024 11:45:57 + schrieb Mark Cave-Ayland : Since the ESCC is part of the next-pc device, move the ESCC to be a QOM child of the next-pc device. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 54 ++---

Re: [PATCH 50/71] hw/remote: Constify all Property

2024-12-14 Thread Jag Raman
> On Dec 13, 2024, at 2:14 PM, Richard Henderson > wrote: > > Signed-off-by: Richard Henderson Reviewed-by: Jagannathan Raman > --- > hw/remote/proxy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/remote/proxy.c b/hw/remote/proxy.c > index 302a0a4d4d..6f84fdd

Re: [PATCH 67/71] hw/watchdog: Constify all Property

2024-12-14 Thread Cédric Le Goater
On 12/13/24 20:30, Richard Henderson wrote: Signed-off-by: Richard Henderson For the aspeed part, Reviewed-by: Cédric Le Goater Thanks, C. --- hw/watchdog/sbsa_gwdt.c | 2 +- hw/watchdog/wdt_aspeed.c | 2 +- hw/watchdog/wdt_imx2.c | 2 +- 3 files changed, 3 insertions(+), 3 delet

Re: [PATCH 65/71] hw/vfio: Constify all Property

2024-12-14 Thread Cédric Le Goater
On 12/13/24 20:29, Richard Henderson wrote: Signed-off-by: Richard Henderson Reviewed-by: Cédric Le Goater Thanks, C. --- hw/vfio/ap.c | 2 +- hw/vfio/ccw.c | 2 +- hw/vfio/pci.c | 4 ++-- hw/vfio/platform.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-)

Re: [PATCH v2 12/34] next-cube: move timer MMIO to separate memory region on next-pc device

2024-12-14 Thread Philippe Mathieu-Daudé
On 12/12/24 12:45, Mark Cave-Ayland wrote: Move the timer MMIO accesses to a separate memory region on the next-pc device instead of being part of the next.scr MMIO memory region. Signed-off-by: Mark Cave-Ayland Reviewed-by: Thomas Huth --- hw/m68k/next-cube.c | 63 ++

Re: [PATCH v2 14/34] next-cube: add empty slots for unknown accesses to next.scr memory region

2024-12-14 Thread Philippe Mathieu-Daudé
On 12/12/24 12:46, Mark Cave-Ayland wrote: The next.scr memory is now effectively unused, however there are 3 separate region accesses still logged that occur when booting a NeXTStep disk image. Use the empty_slot device to capture and ignore memory accesses to these 3 memory regions. Signed-o

Re: [PATCH v2 16/34] next-cube: rearrange NeXTState declarations to improve readability

2024-12-14 Thread Philippe Mathieu-Daudé
On 12/12/24 12:46, Mark Cave-Ayland wrote: Move the NeXTState, next_dma and TYPE_NEXT_MACHINE definition to the same area at the top of next-cube.c. Signed-off-by: Mark Cave-Ayland Reviewed-by: Thomas Huth --- hw/m68k/next-cube.c | 64 ++--- 1 file ch

Re: [PULL 00/18] loongarch-to-apply queue

2024-12-14 Thread Stefan Hajnoczi
On Fri, 13 Dec 2024 at 04:42, Bibo Mao wrote: > > The following changes since commit a5ba0a7e4e150d1350a041f0d0ef9ca6c8d7c307: > > Merge tag 'pull-aspeed-20241211' of https://github.com/legoater/qemu into > staging (2024-12-11 15:16:47 +) > > are available in the Git repository at: > > ht

Re: [PATCH v2 26/34] next-cube: move reset of next-rtc fields from next-pc to next-rtc

2024-12-14 Thread Philippe Mathieu-Daudé
On 12/12/24 12:46, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland Reviewed-by: Thomas Huth --- hw/m68k/next-cube.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) +static void next_rtc_reset_hold(Object *obj, ResetType type) +{ +NeXTRTC *rtc = NEXT_R

Re: [PATCH v2 33/34] next-cube: add my copyright to the top of the file

2024-12-14 Thread Philippe Mathieu-Daudé
On 12/12/24 12:46, Mark Cave-Ayland wrote: This series has involved rewriting and/or updating a considerable part of the next-cube emulation so update the copyright in next-cube.c to reflect this. Signed-off-by: Mark Cave-Ayland Reviewed-by: Thomas Huth --- hw/m68k/next-cube.c | 1 + 1 file

Re: [PATCH v2 17/34] next-cube: convert next-pc device to use Resettable interface

2024-12-14 Thread Philippe Mathieu-Daudé
On 12/12/24 12:46, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland Acked-by: Thomas Huth --- hw/m68k/next-cube.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH v4 3/7] accel/kvm: Report the loss of a large memory page

2024-12-14 Thread “William Roche
From: William Roche In case of a large page impacted by a memory error, enhance the existing Qemu error message which indicates that the error is injected in the VM, adding "on lost large page SIZE@ADDR". Include also a similar message to the ARM platform. In the case of a large page impacted,

[PATCH v4 5/7] hostmem: Factor out applying settings

2024-12-14 Thread “William Roche
From: David Hildenbrand We want to reuse the functionality when remapping or resizing RAM. Signed-off-by: David Hildenbrand Signed-off-by: William Roche --- backends/hostmem.c | 155 - 1 file changed, 82 insertions(+), 73 deletions(-) diff --git a/

[PATCH v4 0/7] Poisoned memory recovery on reboot

2024-12-14 Thread “William Roche
From: William Roche Hello David, Here is an new version of our code and an updated description of the patch set: --- This set of patches fixes several problems with hardware memory errors impacting hugetlbfs memory backed VMs and the generic memory recovery on VM reset. When using hugetlbfs la

[PATCH v4 1/7] hwpoison_page_list and qemu_ram_remap are based on pages

2024-12-14 Thread “William Roche
From: William Roche The list of hwpoison pages used to remap the memory on reset is based on the backend real page size. When dealing with hugepages, we create a single entry for the entire page. Co-developed-by: David Hildenbrand Signed-off-by: William Roche --- accel/kvm/kvm-all.c |

Re: [PATCH 69/71] hw/xen: Use DEFINE_PROP_END_OF_LIST in xen_sysdev_properties

2024-12-14 Thread Jason Andryuk
On 2024-12-13 14:30, Richard Henderson wrote: Signed-off-by: Richard Henderson Reviewed-by: Jason Andryuk

Re: [PATCH 18/71] hw/block/xen-block: Unexport PropertyInfo

2024-12-14 Thread Jason Andryuk
On 2024-12-13 14:06, Richard Henderson wrote: xen_block_prop_vdev is not used outside the file. Signed-off-by: Richard Henderson Reviewed-by: Jason Andryuk

Re: [PATCH 68/71] hw/xen: Constify all Property

2024-12-14 Thread Jason Andryuk
On 2024-12-13 14:30, Richard Henderson wrote: Signed-off-by: Richard Henderson Reviewed-by: Jason Andryuk

Re: [PATCH 30/71] hw/ide: Constify all Property

2024-12-14 Thread Bernhard Beschow
Am 13. Dezember 2024 19:07:04 UTC schrieb Richard Henderson : >Signed-off-by: Richard Henderson >--- > hw/ide/ahci.c| 2 +- > hw/ide/cf.c | 2 +- > hw/ide/cmd646.c | 2 +- > hw/ide/ide-dev.c | 6 +++--- > hw/ide/isa.c | 2 +- > hw/ide/macio.c | 2 +- > hw/ide/mmio.c| 2 +- > 7 fil

Re: [PATCH 00/71] whole-tree: Constify Property structures

2024-12-14 Thread Bernhard Beschow
Am 13. Dezember 2024 19:06:30 UTC schrieb Richard Henderson : >Since d36f165d952 (qdev: make properties array "const"), we can >define our Property structure const. Do this across the entire tree. > >There are a few other minor changes: > - Two instances where it was obvious that an empty pro

Re: [PATCH 62/71] hw/tricore: Constify all Property

2024-12-14 Thread Bastian Koppelmann
On Fri, Dec 13, 2024 at 01:07:36PM -0600, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > hw/tricore/tc27x_soc.c | 2 +- > hw/tricore/tricore_testdevice.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Bastian Koppelmann Cheers, Bastian

[PATCH] hw/m68k/next-cube: Disable the default CD-ROM drive

2024-12-14 Thread Thomas Huth
The NeXT-Cube does not have a CD-ROM drive by default, and the kernel does not seem to deal with the empty drive very well, so let's disable the CD-ROM drive for this machine. Signed-off-by: Thomas Huth --- hw/m68k/next-cube.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/m68k/next-cube

Re: [PATCH 14/71] hw/adc: Constify all Property

2024-12-14 Thread Cédric Le Goater
On 12/13/24 20:06, Richard Henderson wrote: Signed-off-by: Richard Henderson Reviewed-by: Cédric Le Goater Thanks, C. --- hw/adc/aspeed_adc.c | 2 +- hw/adc/npcm7xx_adc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/adc/aspeed_adc.c b/hw/adc/aspeed_adc.c

Re: [PATCH 12/71] hw/9pfs: Constify all Property

2024-12-14 Thread Christian Schoenebeck
On Friday, December 13, 2024 8:06:46 PM CET Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- Reviewed-by: Christian Schoenebeck > hw/9pfs/virtio-9p-device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p

Re: [PATCH 40/71] hw/misc: Constify all Property

2024-12-14 Thread Cédric Le Goater
On 12/13/24 20:07, Richard Henderson wrote: Signed-off-by: Richard Henderson --- hw/misc/a9scu.c | 2 +- hw/misc/allwinner-h3-dramc.c | 2 +- hw/misc/allwinner-r40-dramc.c| 2 +- hw/misc/allwinner-sid.c | 2 +- hw/misc/applesmc.c | 2 +- hw/

Re: [PATCH 15/71] hw/arm: Constify all Property

2024-12-14 Thread Cédric Le Goater
On 12/13/24 20:06, Richard Henderson wrote: Signed-off-by: Richard Henderson --- hw/arm/armsse.c| 8 hw/arm/armv7m.c| 4 ++-- hw/arm/aspeed_soc_common.c | 2 +- hw/arm/bcm2836.c | 2 +- hw/arm/fsl-imx25.c | 2 +- hw/arm/fsl-imx6.c

Re: [PATCH 28/71] hw/i2c: Constify all Property

2024-12-14 Thread Cédric Le Goater
On 12/13/24 20:07, Richard Henderson wrote: Signed-off-by: Richard Henderson Reviewed-by: Cédric Le Goater Thanks, C. --- hw/i2c/aspeed_i2c.c | 4 ++-- hw/i2c/core.c| 2 +- hw/i2c/i2c_mux_pca954x.c | 2 +- hw/i2c/omap_i2c.c| 2 +- 4 files changed, 5 insert

Re: [PATCH 41/71] hw/net: Constify all Property

2024-12-14 Thread Cédric Le Goater
On 12/13/24 20:07, Richard Henderson wrote: Signed-off-by: Richard Henderson --- hw/net/allwinner-sun8i-emac.c | 2 +- hw/net/allwinner_emac.c| 2 +- hw/net/cadence_gem.c | 2 +- hw/net/can/xlnx-versal-canfd.c | 2 +- hw/net/can/xlnx-zynqmp-can.c | 2 +- hw/net/dp8393

Re: [PATCH 60/71] hw/timer: Constify all Property

2024-12-14 Thread Cédric Le Goater
On 12/13/24 20:07, Richard Henderson wrote: Signed-off-by: Richard Henderson --- hw/timer/a9gtimer.c | 2 +- hw/timer/allwinner-a10-pit.c | 2 +- hw/timer/arm_mptimer.c | 2 +- hw/timer/arm_timer.c | 2 +- hw/timer/aspeed_timer.c | 2 +- hw/timer/avr_timer16.c

Re: [PATCH 59/71] hw/ssi: Constify all Property

2024-12-14 Thread Cédric Le Goater
On 12/13/24 20:07, Richard Henderson wrote: Signed-off-by: Richard Henderson --- hw/ssi/aspeed_smc.c | 4 ++-- hw/ssi/ibex_spi_host.c| 2 +- hw/ssi/npcm7xx_fiu.c | 2 +- hw/ssi/pnv_spi.c | 2 +- hw/ssi/sifive_spi.c | 2 +- hw/ssi/ssi.c | 2 +- h

Re: [PATCH 56/71] hw/sd: Constify all Property

2024-12-14 Thread Cédric Le Goater
On 12/13/24 20:07, Richard Henderson wrote: Signed-off-by: Richard Henderson --- hw/sd/allwinner-sdhost.c | 2 +- hw/sd/aspeed_sdhci.c | 2 +- hw/sd/sd.c | 6 +++--- hw/sd/sdhci-pci.c| 2 +- hw/sd/sdhci.c| 2 +- 5 files changed, 7 insertions(+), 7 del

Re: [PATCH v2 12/34] next-cube: move timer MMIO to separate memory region on next-pc device

2024-12-14 Thread Mark Cave-Ayland
On 14/12/2024 13:29, Philippe Mathieu-Daudé wrote: On 12/12/24 12:45, Mark Cave-Ayland wrote: Move the timer MMIO accesses to a separate memory region on the next-pc device instead of being part of the next.scr MMIO memory region. Signed-off-by: Mark Cave-Ayland Reviewed-by: Thomas Huth ---

Re: [PATCH 35/71] hw/isa: Constify all Property

2024-12-14 Thread Bernhard Beschow
Am 13. Dezember 2024 19:07:09 UTC schrieb Richard Henderson : >Signed-off-by: Richard Henderson >--- > hw/isa/lpc_ich9.c | 2 +- > hw/isa/pc87312.c | 2 +- > hw/isa/piix.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c >index

Re: [PATCH v2 02/34] next-cube: remove overlap between next.dma and next.mmio memory regions

2024-12-14 Thread Mark Cave-Ayland
On 13/12/2024 19:37, Thomas Huth wrote: Hi Mark! Am Thu, 12 Dec 2024 11:45:48 + schrieb Mark Cave-Ayland : Change the start of the next.mmio memory region so that it follows on directly after the next.dma memory region. Increase the address offsets in next_mmio_read() and next_mmio_writ

Re: [PATCH v2 34/34] next-cube: replace boiler-plate GPL 2.0 or later license text with SPDX identifier

2024-12-14 Thread Mark Cave-Ayland
On 12/12/2024 17:28, Daniel P. Berrangé wrote: On Thu, Dec 12, 2024 at 11:46:20AM +, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index 1e

Re: [PATCH v2 14/34] next-cube: add empty slots for unknown accesses to next.scr memory region

2024-12-14 Thread Mark Cave-Ayland
On 14/12/2024 13:32, Philippe Mathieu-Daudé wrote: On 12/12/24 12:46, Mark Cave-Ayland wrote: The next.scr memory is now effectively unused, however there are 3 separate region accesses still logged that occur when booting a NeXTStep disk image. Use the empty_slot device to capture and ignore

Re: [PATCH v2 25/34] next-cube: QOMify NeXTRTC

2024-12-14 Thread Mark Cave-Ayland
On 14/12/2024 06:08, Thomas Huth wrote: Am Thu, 12 Dec 2024 11:46:11 + schrieb Mark Cave-Ayland : This is to allow the RTC functionality to be maintained within its own separate device rather than as part of the next-pc device. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c |

Re: [PATCH v2 11/34] next-cube: move ESCC to be QOM child of next-pc device

2024-12-14 Thread Mark Cave-Ayland
On 14/12/2024 06:10, Thomas Huth wrote: Am Thu, 12 Dec 2024 11:45:57 + schrieb Mark Cave-Ayland : Since the ESCC is part of the next-pc device, move the ESCC to be a QOM child of the next-pc device. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 54 ++

Re: [PATCH] hw/m68k/next-cube: Disable the default CD-ROM drive

2024-12-14 Thread Mark Cave-Ayland
On 14/12/2024 09:17, Thomas Huth wrote: The NeXT-Cube does not have a CD-ROM drive by default, and the kernel does not seem to deal with the empty drive very well, so let's disable the CD-ROM drive for this machine. Signed-off-by: Thomas Huth --- hw/m68k/next-cube.c | 1 + 1 file changed, 1

Re: [PULL 0/5] hex queue

2024-12-14 Thread Brian Cain
+ Stefan On 12/12/2024 10:18 PM, Brian Cain wrote: The following changes since commit a5ba0a7e4e150d1350a041f0d0ef9ca6c8d7c307: Merge tag 'pull-aspeed-20241211' of https://github.com/legoater/qemu into staging (2024-12-11 15:16:47 +) are available in the Git repository at: https://