Re: [PATCH v3] riscv/gdb: add V bit to priv register

2024-12-13 Thread Yanfeng Liu
On Fri, 2024-12-13 at 10:04 +0100, Mario Fleischmann wrote: > Hi, > > apologies for the delayed review; I've just gotten to it now. > > On 06.12.2024 01:14, Yanfeng Liu wrote: > > This adds virtualization mode (V bit) as bit(2) of register `priv` > > per RiscV debug spec v1.0.0-rc3. Checked with

Re: [PATCH] MAINTAINERS: correct my email address

2024-12-13 Thread Philippe Mathieu-Daudé
On 13/12/24 20:16, Philippe Mathieu-Daudé wrote: On 9/12/24 19:12, Brian Cain wrote: Mea culpa, I don't know how I got this wrong in 2dfe93699c.  Still getting used to the new address, I suppose.  Somehow I got it right in the mailmap, though. Signed-off-by: Brian Cain ---   MAINTAINERS | 2

Re: [PATCH v2 0/7] hw/nvram/fw_cfg: Move PCI bus methods out

2024-12-13 Thread Philippe Mathieu-Daudé
On 13/12/24 14:33, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (7): hw/nvram/fw_cfg: Rename fw_cfg_add_[file]_from_generator() hw/nvram/fw_cfg: Pass QOM parent to fw_cfg_add_file_from_generator() hw/nvram/fw_cfg: Skip FW_CFG_DATA_GENERATOR when no data to generate hw/pci: Ha

Re: [PATCH 1/2] s390x/pci: add support for guests that request direct mapping

2024-12-13 Thread Matthew Rosato
On 12/10/24 3:58 AM, David Hildenbrand wrote: > Maybe there is a reason s390x needs to handle this using > memory_region_notify_iommu() callbacks instead of doing it similar to "struct > vfio_memory_listener" when registered on &address_space_memory without a > viommu. > Hi David, I think I

Re: [PATCH v2] tests/qtest/sse-timer-test: Add watchdog reset to sse-timer test

2024-12-13 Thread Nabih Estefan
Some of the info I was asked for in V1 of the patch: I'm seeing the failure on 2 different machines, the compiler versions are: - gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04) - gcc version 14.2.0 (Debian 14.2.0-3+build3) Both of the outputs below are run on the Debian machine. Output of the

Re: [RFC PATCH 0/5] hw/arm/virt: Add support for user-creatable nested SMMUv3

2024-12-13 Thread Daniel P . Berrangé
On Fri, Nov 08, 2024 at 12:52:37PM +, Shameer Kolothum via wrote: > Hi, > > This series adds initial support for a user-creatable "arm-smmuv3-nested" > device to Qemu. At present the Qemu ARM SMMUv3 emulation is per machine > and cannot support multiple SMMUv3s. > > In order to support vfio-p

Re: [RFC PATCH 0/5] hw/arm/virt: Add support for user-creatable nested SMMUv3

2024-12-13 Thread Daniel P . Berrangé
On Fri, Nov 22, 2024 at 05:38:54PM +, Shameerali Kolothum Thodi via wrote: > > > > -Original Message- > > From: Nathan Chen > > Sent: Friday, November 22, 2024 1:42 AM > > To: Shameerali Kolothum Thodi > > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; > > eric.au...@redhat.com; pe

Re: [PATCH v3 17/26] hw/arm/virt: Reserve one bit of guest-physical address for RME

2024-12-13 Thread Gavin Shan
Hi Jean, On 11/26/24 5:56 AM, Jean-Philippe Brucker wrote: When RME is enabled, the upper GPA bit is used to distinguish protected from unprotected addresses. Reserve it when setting up the guest memory map. Signed-off-by: Jean-Philippe Brucker --- hw/arm/virt.c | 14 -- 1 file

Re: [PATCH 4/4] hw/timer/hpet: Hold fw_cfg state within HPET class

2024-12-13 Thread Daniel P . Berrangé
On Fri, Dec 06, 2024 at 08:11:24PM +0100, Philippe Mathieu-Daudé wrote: > We maintain one hpet_cfg[] state for all HPET instances. > Move it to a new HPET class. It is a conceptually rather wierd having state stored in a class rather than an instance. I don't know what hpet_cfg is used for though

Re: [PATCH v2 30/31] tests/functional: skip tests if assets are not available

2024-12-13 Thread Thomas Huth
On 12/12/2024 16.02, Daniel P. Berrangé wrote: On Thu, Dec 12, 2024 at 03:14:53PM +0100, Thomas Huth wrote: On 11/12/2024 18.26, Daniel P. Berrangé wrote: If downloading of assets has been disabled, then skip running a test if the assets it has registered are not already downloaded. Signed-off

Re: [PATCH v2 31/31] tests/functional: ignore errors when caching assets, except for 404

2024-12-13 Thread Thomas Huth
On 11/12/2024 18.26, Daniel P. Berrangé wrote: We see periodic errors caching assets due to a combination of transient networking and server problems. With the previous patch to skip running a test when it has missing assets, we can now treat most cache download errors as non-fatal. Only HTTP 40

Re: [PATCH 0/2] s390x/pci: relax I/O address translation requirement

2024-12-13 Thread Thomas Huth
On 12/12/2024 15.42, Matthew Rosato wrote: On 12/12/24 4:10 AM, Thomas Huth wrote: On 09/12/2024 20.29, Matthew Rosato wrote: This series introduces the concept of the relaxed translation requirement for s390x guests in order to allow bypass of the guest IOMMU for more efficient PCI passthrough

Re: [PATCH 19/26] rust: rename qemu-api modules to follow C code a bit more

2024-12-13 Thread Zhao Liu
> > In this commit, this comment is a bit ahead, but I think it's okay. > > > > qom and qdev are both good names. In addition, we can rename the files > > of PL011 as well. Perhaps device_class.rs could be merged into device.rs > > (and eventually renamed to pl011.rs). I guess you might be plannin

[PATCH v2] hw/cxl: Fix msix_notify: Assertion `vector < dev->msix_entries_nr`

2024-12-13 Thread Li Zhijian via
This assertion always happens when we sanitize the CXL memory device. $ echo 1 > /sys/bus/cxl/devices/mem0/security/sanitize It is incorrect to register an MSIX number beyond the device's capability. Expand the device's MSIX number and use the enum to maintain the *USED* and MAX MSIX number Fixe

答复: 答复: [PATCH] hw/arm/aspeed: fix connect_serial_hds_to_uarts

2024-12-13 Thread kenneth_jia--- via
> Which QEMU machine are you using ? ast2600-evb Thanks, Kenneth -邮件原件- 发件人: Cédric Le Goater 发送时间: 2024年12月13日 17:57 收件人: Kenneth Jia(贾纪东_华硕上海) ; 'qemu-...@nongnu.org' 抄送: 'Cédric Le Goater' ; 'Philippe Mathieu-Daudé' ; 'Jamin Lin' ; 'Andrew Jeffery' ; 'Gavin Shan' ; 'open lis

Re: [PATCH] hw/arm/aspeed: fix connect_serial_hds_to_uarts

2024-12-13 Thread Cédric Le Goater
On 12/12/24 14:31, Kenneth Jia(贾纪东_华硕上海) wrote: From 24d3badbbb9dcc0d220609a7dd30f8da5002cba7 Mon Sep 17 00:00:00 2001 From: Kenneth Jia Date: Thu, 12 Dec 2024 20:42:04 +0800 Subject: [PATCH]    hw/arm/aspeed: fix connect_serial_hds_to_uarts    In the loop, we need ignore the index increas

Re: [PATCH v3 24/24] vfio/migration: Multifd device state transfer support - send side

2024-12-13 Thread Cédric Le Goater
By the way, this kind of an implicit dependency in VMState between devices is really hard to manage, there should be a way to specify it in code somehow.. vmstate has a MigrationPriority field to order loading between devices. Maybe we could extend but I think it is better to handle ordering at

Re: [PATCH 00/18] accel/tcg: Extract user APIs out of 'exec/[cpu,exec]-all.h'

2024-12-13 Thread Philippe Mathieu-Daudé
On 12/12/24 19:53, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (18): exec: Introduce 'user/guest-host.h' header linux-user/aarch64: Include missing 'user/abitypes.h' header include: Include missing 'qemu/clang-tsa.h' header accel/tcg: Declare mmap_[un]lock() in 'exec/page-pr

Re: [PATCH 0/6] hw/nvram/fw_cfg: Move PCI bus methods out

2024-12-13 Thread Philippe Mathieu-Daudé
On 6/12/24 19:13, Philippe Mathieu-Daudé wrote: In order to keep fw_cfg device model clean, remove the PCI bus specific code. Instead, the equivalent functionality is implemented within the PCI_BUS object in hw/pci/, implementing TYPE_FW_CFG_DATA_GENERATOR_INTERFACE. Philippe Mathieu-Daudé (6):

Re: [PATCH 0/4] hw/timer/hpet: Make fw_cfg state private to HPET class

2024-12-13 Thread Philippe Mathieu-Daudé
On 6/12/24 20:11, Philippe Mathieu-Daudé wrote: No need to have an external hpet_cfg[] array accessed outside of hpet.c. Move it in the class state. Philippe Mathieu-Daudé (4): hw/timer/hpet: Introduce hpet_add_fw_cfg_bytes() hw/timer/hpet: Reduce hpet_cfg[] scope hw/timer/hpet: Have hp

Re: [PATCH 1/6] hw/nvram/fw_cfg: Rename fw_cfg_add_[file]_from_generator()

2024-12-13 Thread Daniel P . Berrangé
On Fri, Dec 06, 2024 at 07:13:47PM +0100, Philippe Mathieu-Daudé wrote: > fw_cfg_add_from_generator() is adding a 'file' entry, > so rename as fw_cfg_add_file_from_generator() for > clarity. Besides, we might introduce generators for > other entry types. > > Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH 19/26] rust: rename qemu-api modules to follow C code a bit more

2024-12-13 Thread Paolo Bonzini
Il ven 13 dic 2024, 10:01 Zhao Liu ha scritto: > I found vmstate_array_of_pointer_to_struct missed a `info` field, and I > could submit a patch to fix this nit next week (along with other cleanup > you and other miantainers suggested for HPET). > I wouldn't worry too much about VMState, it's not

Re: [PATCH 2/6] hw/nvram/fw_cfg: Pass QOM parent to fw_cfg_add_file_from_generator()

2024-12-13 Thread Daniel P . Berrangé
On Fri, Dec 06, 2024 at 07:13:48PM +0100, Philippe Mathieu-Daudé wrote: > Currently fw_cfg_add_file_from_generator() is restricted > to command line created objects which reside in the > '/objects' QOM container. In order to extend to other > types of containers, pass the QOM parent by argument. >

Re: [PATCH 3/6] hw/pci: Have PCI_BUS implement TYPE_FW_CFG_DATA_GENERATOR_INTERFACE

2024-12-13 Thread Daniel P . Berrangé
On Fri, Dec 06, 2024 at 07:13:49PM +0100, Philippe Mathieu-Daudé wrote: > The FW_CFG_DATA_GENERATOR allows any object to produce ^ ^^^ ^ insert word 'interface' > blob of data consumable by the fw_cfg device. Implem

Re: [PATCH 5/6] hw: Use pci_bus_add_fw_cfg_extra_pci_roots()

2024-12-13 Thread Daniel P . Berrangé
On Fri, Dec 06, 2024 at 07:13:51PM +0100, Philippe Mathieu-Daudé wrote: > We want to remove fw_cfg_add_extra_pci_roots() which introduced > PCI bus knowledge within the generic hw/nvram/fw_cfg.c file. > Replace the calls by the pci_bus_add_fw_cfg_extra_pci_roots() > which is a 1:1 equivalent, but u

Re: [PATCH 4/6] hw/pci: Add pci_bus_add_fw_cfg_extra_pci_roots() helper

2024-12-13 Thread Daniel P . Berrangé
On Fri, Dec 06, 2024 at 07:13:50PM +0100, Philippe Mathieu-Daudé wrote: > pci_bus_add_fw_cfg_extra_pci_roots() calls the fw_cfg > API with PCI bus specific arguments. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/pci/pci.h | 3 +++ > hw/pci/pci.c | 16 >

Re: [PATCH 6/6] hw/nvram/fw_cfg: Remove fw_cfg_add_extra_pci_roots()

2024-12-13 Thread Daniel P . Berrangé
On Fri, Dec 06, 2024 at 07:13:52PM +0100, Philippe Mathieu-Daudé wrote: > Now that all uses of fw_cfg_add_extra_pci_roots() have been > converted to the newer pci_bus_add_fw_cfg_extra_pci_roots(), > we can remove that bogus method. hw/nvram/fw_cfg must > stay generic. Device specific entries have t

答复: [PATCH] hw/arm/aspeed: fix connect_serial_hds_to_uarts

2024-12-13 Thread kenneth_jia--- via
We plans to use a relatively large number of UART connections, and currently test all UARTs that can be used. When we use qumu for simulation, the problem was discovered. The current code does not allocate char devices with index 5 (label serial5). And even if there are more serial devices, th

[PULL 09/18] include: Add loongarch_extioi_common header file

2024-12-13 Thread Bibo Mao
Add common header file include/hw/intc/loongarch_extioi_common.h, and move some macro definition from include/hw/intc/loongarch_extioi.h to the common header file. Signed-off-by: Bibo Mao Reviewed-by: Song Gao --- include/hw/intc/loongarch_extioi.h| 50 +-- include/hw/in

[PULL 12/18] hw/intc/loongarch_extioi: Rename LoongArchExtIOI with LoongArchExtIOICommonState

2024-12-13 Thread Bibo Mao
With some structure such as vmstate and property, rename LoongArchExtIOI with LoongArchExtIOICommonState, these common structure will be moved to common file. Signed-off-by: Bibo Mao Reviewed-by: Song Gao --- hw/intc/loongarch_extioi.c | 41 +++--- 1 file changed

[PULL 08/18] hw/intc/loongarch_pch: Code cleanup about loongarch_pch_pic

2024-12-13 Thread Bibo Mao
Remove definition about LoongArchPCHPIC and LOONGARCH_PCH_PIC, and replace them with LoongArchPICCommonState and LOONGARCH_PIC_COMMON separately. Also remove unnecessary header files. Signed-off-by: Bibo Mao Reviewed-by: Song Gao --- hw/intc/loongarch_pch_pic.c | 24 ++--

[PULL 01/18] include: Add loongarch_pic_common header file

2024-12-13 Thread Bibo Mao
Add common header file hw/intc/loongarch_pic_common.h, and move some macro definition from hw/intc/loongarch_pch_pic.h to the common header file. Signed-off-by: Bibo Mao Reviewed-by: Song Gao --- include/hw/intc/loongarch_pch_pic.h| 36 +++--- include/hw/intc/loongarch_pic_c

[PULL 04/18] hw/intc/loongarch_pch: Rename LoongArchPCHPIC with LoongArchPICCommonState

2024-12-13 Thread Bibo Mao
With pic vmstate, rename structure name vmstate_loongarch_pch_pic with vmstate_loongarch_pic_common, and with pic property rename loongarch_pch_pic_properties with loongarch_pic_common_properties. Signed-off-by: Bibo Mao Reviewed-by: Song Gao --- hw/intc/loongarch_pch_pic.c | 52 +++

[PULL 11/18] include: Rename LoongArchExtIOI with LoongArchExtIOICommonState

2024-12-13 Thread Bibo Mao
Rename structure LoongArchExtIOI with LoongArchExtIOICommonState, since it is defined in file loongarch_extioi_common.h Signed-off-by: Bibo Mao Reviewed-by: Song Gao --- include/hw/intc/loongarch_extioi.h| 1 + include/hw/intc/loongarch_extioi_common.h | 2 +- 2 files changed, 2 inserti

[PULL 02/18] include: Move struct LoongArchPCHPIC to loongarch_pic_common header file

2024-12-13 Thread Bibo Mao
Move structure LoongArchPCHPIC from header file loongarch_pch_pic.h to file loongarch_pic_common.h, and rename structure name with LoongArchPICCommonState. Signed-off-by: Bibo Mao Reviewed-by: Song Gao --- include/hw/intc/loongarch_pch_pic.h| 27 + include/hw/intc/lo

[PULL 05/18] hw/intc/loongarch_pch: Move some functions to file loongarch_pic_common

2024-12-13 Thread Bibo Mao
Move some common functions to file loongarch_pic_common.c, the common functions include loongarch_pic_common_realize(), property structure loongarch_pic_common_properties and vmstate structure vmstate_loongarch_pic_common. Signed-off-by: Bibo Mao Reviewed-by: Song Gao --- hw/intc/loongarch_pch_

[PULL 06/18] hw/intc/loongarch_pch: Inherit from loongarch_pic_common

2024-12-13 Thread Bibo Mao
Set TYPE_LOONGARCH_PIC inherit from TYPE_LOONGARCH_PIC_COMMON object, it shares vmsate and property of TYPE_LOONGARCH_PIC_COMMON, and has its own realize() function. Signed-off-by: Bibo Mao Reviewed-by: Song Gao --- hw/intc/loongarch_pch_pic.c| 38 -- hw/intc

[PULL 10/18] include: Move struct LoongArchExtIOI to header file loongarch_extioi_common

2024-12-13 Thread Bibo Mao
Move definiton of structure LoongArchExtIOI from header file loongarch_extioi.h to file loongarch_extioi_common.h. Signed-off-by: Bibo Mao Reviewed-by: Song Gao --- include/hw/intc/loongarch_extioi.h| 26 -- include/hw/intc/loongarch_extioi_common.h | 27

[PULL 00/18] loongarch-to-apply queue

2024-12-13 Thread Bibo Mao
The following changes since commit a5ba0a7e4e150d1350a041f0d0ef9ca6c8d7c307: Merge tag 'pull-aspeed-20241211' of https://github.com/legoater/qemu into staging (2024-12-11 15:16:47 +) are available in the Git repository at: https://gitlab.com/bibo-mao/qemu.git pull-loongarc

[PULL 03/18] hw/intc/loongarch_pch: Merge instance_init() into realize()

2024-12-13 Thread Bibo Mao
Memory region is created in instance_init(), merge it into function realize(). There is no special class_init() for loongarch_pch object. Signed-off-by: Bibo Mao Reviewed-by: Song Gao --- hw/intc/loongarch_pch_pic.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --

[PULL 07/18] hw/intc/loongarch_pch: Add pre_save and post_load interfaces

2024-12-13 Thread Bibo Mao
Add vmstate pre_save and post_load interfaces, which can be used by pic kvm driver in future. Signed-off-by: Bibo Mao Reviewed-by: Song Gao --- hw/intc/loongarch_pic_common.c | 26 ++ include/hw/intc/loongarch_pic_common.h | 2 ++ 2 files changed, 28 insertions(

Re: 答复: [PATCH] hw/arm/aspeed: fix connect_serial_hds_to_uarts

2024-12-13 Thread Cédric Le Goater
On 12/13/24 10:48, Kenneth Jia(贾纪东_华硕上海) wrote: We plans to use a relatively large number of UART connections, and currently test all UARTs that can be used. When we use qumu for simulation, the problem was discovered. Which QEMU machine are you using ? Thanks, C.

Re: [PULL 0/4] tcg patch queue

2024-12-13 Thread Philippe Mathieu-Daudé
Hi Stefan, On 13/12/24 02:21, Stefan Hajnoczi wrote: Applied, thanks. I guess you are pushing to the 'master' of your personal repository, not the QEMU project's one.

Re: [PULL 00/72] target-arm queue

2024-12-13 Thread Peter Maydell
On Fri, 13 Dec 2024 at 01:25, Stefan Hajnoczi wrote: > > Applied, thanks. This doesn't seem to have been applied -- did you forget to push to upstream master? thanks -- PMM

Re: [RFC PATCH 0/5] hw/arm/virt: Add support for user-creatable nested SMMUv3

2024-12-13 Thread Jason Gunthorpe
On Fri, Dec 13, 2024 at 11:58:02AM +, Daniel P. Berrangé wrote: > Libvirt does not rquire use of pcie-switch. It supports them, but in the > absence of app requested configs, libvirt will always just populate > pcie-root-port devices. switches are something that has to be explicitly > asked fo

Re: [RFC PATCH 0/5] hw/arm/virt: Add support for user-creatable nested SMMUv3

2024-12-13 Thread Jason Gunthorpe
On Fri, Dec 13, 2024 at 12:00:43PM +, Daniel P. Berrangé wrote: > On Fri, Nov 08, 2024 at 12:52:37PM +, Shameer Kolothum via wrote: > > Hi, > > > > This series adds initial support for a user-creatable "arm-smmuv3-nested" > > device to Qemu. At present the Qemu ARM SMMUv3 emulation is per

Re: [PATCH] hw/cxl: Fix msix_notify: Assertion `vector < dev->msix_entries_nr`

2024-12-13 Thread Zhijian Li (Fujitsu)
>From: Jonathan Cameron >Sent: Thursday, December 12, 2024 20:02 > >On Thu, 12 Dec 2024 16:55:33 +0800 >Li Zhijian via wrote: > >> This assertion always happens when we sanitize the CXL memory device. >> $ echo 1 > /sys/bus/cxl/devices/mem0/security/sanitize >> >> It is incorrect to register an M

Re: [PATCH 14/26] rust: qom: move bridge for TypeInfo functions out of pl011

2024-12-13 Thread Zhao Liu
> I see -- though, thinking more about it, since you have > > fn init_timer(&mut self) { > let raw_ptr: *mut HPETState = self; > > for i in 0..HPET_MAX_TIMERS { > let mut timer = self.get_timer(i).borrow_mut(); > timer.init(i, raw_ptr).init_timer_with_s

Re: [PATCH 0/2] support block encryption/decryption in parallel

2024-12-13 Thread Guoyi Tu
Hi Kevin and Hanna, could you share your thoughts on this patch? I’d greatly appreciate your feedback -- Guoyi On 2024/11/28 18:51, t...@chinatelecom.cn wrote: From: Guoyi Tu Currently, disk I/O encryption and decryption operations are performed sequentially in the main thread or IOthread.

Re: [PATCH v3] riscv/gdb: add V bit to priv register

2024-12-13 Thread Mario Fleischmann
Hi, apologies for the delayed review; I've just gotten to it now. On 06.12.2024 01:14, Yanfeng Liu wrote: This adds virtualization mode (V bit) as bit(2) of register `priv` per RiscV debug spec v1.0.0-rc3. Checked with gdb-multiarch v12.1. Note that GDB may display `INVALID` tag for the value

Re: [PATCH 0/2] s390x/pci: relax I/O address translation requirement

2024-12-13 Thread Cédric Le Goater
On 12/12/24 15:42, Matthew Rosato wrote: On 12/12/24 4:10 AM, Thomas Huth wrote: On 09/12/2024 20.29, Matthew Rosato wrote: This series introduces the concept of the relaxed translation requirement for s390x guests in order to allow bypass of the guest IOMMU for more efficient PCI passthrough.

Re: [PATCH] tests/qtest/sse-timer-test: Add watchdog reset to sse-timer test

2024-12-13 Thread Thomas Huth
On 13/12/2024 01.26, Nabih Estefan wrote: Recent CDMSK Watchdog changes (eff9dc5660fad3a610171c56a5ec3fada245e519) updated the CDMSK APB Watchdog to not free run out of reset. That led to this test failing since it never triggers the watchdog to start running. No watchdog running means that the t

Re: [PULL 0/4] tcg patch queue

2024-12-13 Thread Stefan Hajnoczi
On Fri, 13 Dec 2024 at 05:42, Philippe Mathieu-Daudé wrote: > > Hi Stefan, > > On 13/12/24 02:21, Stefan Hajnoczi wrote: > > Applied, thanks. > > I guess you are pushing to the 'master' of your personal > repository, not the QEMU project's one. You're right. Thanks for letting me know! Stefan

Re: [PATCH v2 00/14] s390x: virtio-mem support

2024-12-13 Thread Thomas Huth
On 12/12/2024 22.52, David Hildenbrand wrote: On 13.11.24 15:46, David Hildenbrand wrote: On 08.10.24 12:54, David Hildenbrand wrote: Based on current master. There is really not much left to do on s390x, because virtio-mem already implements most things we need today (e.g., early-migration, u

Re: [PATCH v2 09/14] s390x/s390-skeys: prepare for memory devices

2024-12-13 Thread Thomas Huth
On 08/10/2024 12.54, David Hildenbrand wrote: With memory devices, we will have storage keys for memory that exceeds the initial ram size. The TODO already states that current handling is subopimal, but we won't worry about improving that (TCG-only) thing for now. Acked-by: Michael S. Tsirkin

Re: [PATCH v2 0/2] Separate memory access logs from guest_errors

2024-12-13 Thread BALATON Zoltan
On Sat, 2 Nov 2024, BALATON Zoltan wrote: Originally memory access logs were a debug define that then were converted to log messages but were classified as guest_errors which already logs misc errors. As invalid memory access logs can come from accessing not emulated peripherals or memory areas,

Re: [PATCH v2 10/14] s390x/s390-virtio-ccw: prepare for memory devices

2024-12-13 Thread Thomas Huth
On 08/10/2024 12.54, David Hildenbrand wrote: Let's prepare our address space for memory devices if enabled via "maxmem" and if we have CONFIG_MEM_DEVICE enabled at all. Note that CONFIG_MEM_DEVICE will be selected automatically once we add support for devices. Just like on other architectures,

Re: [PATCH v2 12/14] s390x: remember the maximum page size

2024-12-13 Thread Thomas Huth
On 08/10/2024 12.54, David Hildenbrand wrote: Let's remember the value (successfully) set via s390_set_max_pagesize(). This will be helpful to reject hotplugged memory devices that would exceed this initially set page size. Handle it just like how we handle s390_get_memory_limit(), storing it in

Re: [PATCH v3 0/4] Minor fixes for Arm documentation

2024-12-13 Thread Pierrick Bouvier
On 12/13/24 07:37, Peter Maydell wrote: On Fri, 6 Dec 2024 at 19:23, Pierrick Bouvier wrote: Reviewed following things: - system/arm/cpu-features (options) - system/arm/virt (options) - boards documented and listed with -machine help (arm and aarch64) - grep object_class_property_set_descripti

[PULL 24/85] target/arm: Convert FMOV, FABS, FNEG (scalar) to decodetree

2024-12-13 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20241211163036.2297116-25-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 7 +++ target/arm/tcg/translate-a64.c | 105 +++---

[PULL 57/85] target/arm: Convert FCVT* (vector, integer) scalar to decodetree

2024-12-13 Thread Peter Maydell
From: Richard Henderson Arm silliness with naming, the scalar insns described as part of the vector instructions, as separate from the "regular" scalar insns which output to general registers. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20241211163036.2297116-58-ric

[PULL 39/85] target/arm: Introduce gen_gvec_cnt, gen_gvec_rbit

2024-12-13 Thread Peter Maydell
From: Richard Henderson Add gvec interfaces for CNT and RBIT operations. Use ctpop8 for CNT and revbit+bswap for RBIT. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20241211163036.2297116-40-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/he

[PULL 47/85] target/arm: Remove helper_neon_{add,sub}l_u{16,32}

2024-12-13 Thread Peter Maydell
From: Richard Henderson These have generic equivalents: tcg_gen_vec_{add,sub}{16,32}_i64. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20241211163036.2297116-48-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.h | 4

Re: [PATCH] tests/qtest/sse-timer-test: Add watchdog reset to sse-timer test

2024-12-13 Thread Fabiano Rosas
Thomas Huth writes: > On 13/12/2024 01.26, Nabih Estefan wrote: >> Recent CDMSK Watchdog changes (eff9dc5660fad3a610171c56a5ec3fada245e519) >> updated the CDMSK APB Watchdog to not free run out of reset. That led to >> this test failing since it never triggers the watchdog to start running. >> No

Re: [PATCH 0/6] linux-user: Add support for various missing netlink sockopt entries

2024-12-13 Thread Helge Deller
ping for review... On 11/29/24 15:38, del...@kernel.org wrote: From: Helge Deller This patchset adds various missing sockopt calls, so that qemu linux-user is able to successfully build the debian gupnp package in a chroot. Tested with a 32-bit big-endian hppa linux-user chroot running on a p

Re: [PATCH] MAINTAINERS: correct my email address

2024-12-13 Thread Philippe Mathieu-Daudé
On 9/12/24 19:12, Brian Cain wrote: Mea culpa, I don't know how I got this wrong in 2dfe93699c. Still getting used to the new address, I suppose. Somehow I got it right in the mailmap, though. Signed-off-by: Brian Cain --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 24/71] hw/display: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/display/artist.c | 2 +- hw/display/ati.c | 2 +- hw/display/bcm2835_fb.c | 2 +- hw/display/bochs-display.c | 2 +- hw/display/cg3.c | 2 +- hw/display/cirrus_vga.c | 2 +- hw/display/cir

[PATCH 59/71] hw/ssi: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ssi/aspeed_smc.c | 4 ++-- hw/ssi/ibex_spi_host.c| 2 +- hw/ssi/npcm7xx_fiu.c | 2 +- hw/ssi/pnv_spi.c | 2 +- hw/ssi/sifive_spi.c | 2 +- hw/ssi/ssi.c | 2 +- hw/ssi/xilinx_spi.c | 2 +- hw/ssi/xilinx_spips.

[PATCH 66/71] hw/virtio: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/virtio/vdpa-dev-pci.c | 2 +- hw/virtio/vdpa-dev.c | 2 +- hw/virtio/vhost-scsi-pci.c | 2 +- hw/virtio/vhost-user-blk-pci.c | 2 +- hw/virtio/vhost-user-device.c| 2 +- hw/virtio/vhost-user-fs-pci.c| 2 +- hw/virtio/vhos

[PATCH 51/71] hw/riscv: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/riscv/opentitan.c | 2 +- hw/riscv/riscv-iommu-pci.c | 2 +- hw/riscv/riscv-iommu.c | 2 +- hw/riscv/riscv_hart.c | 2 +- hw/riscv/sifive_u.c| 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/riscv/opentitan.c b

[PATCH 46/71] hw/pci-host/astro: Remove empty Property list

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/pci-host/astro.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/pci-host/astro.c b/hw/pci-host/astro.c index 379095b356..62e9c8acbf 100644 --- a/hw/pci-host/astro.c +++ b/hw/pci-host/astro.c @@ -461,10 +461,6 @@ static void elroy_pcihost_init(Ob

[PATCH 63/71] hw/ufs: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ufs/lu.c | 2 +- hw/ufs/ufs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ufs/lu.c b/hw/ufs/lu.c index 81bfff9b4e..74ff52ad09 100644 --- a/hw/ufs/lu.c +++ b/hw/ufs/lu.c @@ -274,7 +274,7 @@ static UfsReqResult ufs_process_scsi_

[PATCH 32/71] hw/intc: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/intc/apic_common.c | 2 +- hw/intc/arm_gic_common.c | 2 +- hw/intc/arm_gicv2m.c | 2 +- hw/intc/arm_gicv3_common.c| 2 +- hw/intc/arm_gicv3_its.c | 2 +- hw/intc/arm_gicv3_its_kvm.c | 2 +- hw/intc/armv7m_nvic.c |

[PATCH 42/71] hw/nubus: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/nubus/nubus-bridge.c | 2 +- hw/nubus/nubus-device.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/nubus/nubus-bridge.c b/hw/nubus/nubus-bridge.c index a42c86080f..83893e5a46 100644 --- a/hw/nubus/nubus-bridge.c +++ b/hw/nubus/nu

[PATCH 01/71] target/arm: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.c | 26 +- target/arm/cpu64.c | 6 +++--- target/arm/tcg/cpu64.c | 2 +- 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 0cbda76ba0..1afa07511e 100644

[PATCH 44/71] hw/nvram: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/nvram/ds1225y.c | 2 +- hw/nvram/eeprom_at24c.c| 2 +- hw/nvram/fw_cfg.c | 6 +++--- hw/nvram/mac_nvram.c | 2 +- hw/nvram/nrf51_nvm.c | 2 +- hw/nvram/spapr_nvram.c | 2 +-

[PATCH 63/71] hw/ufs: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ufs/lu.c | 2 +- hw/ufs/ufs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ufs/lu.c b/hw/ufs/lu.c index 81bfff9b4e..74ff52ad09 100644 --- a/hw/ufs/lu.c +++ b/hw/ufs/lu.c @@ -274,7 +274,7 @@ static UfsReqResult ufs_process_scsi_

Re: [PATCH] tests/qtest/sse-timer-test: Add watchdog reset to sse-timer test

2024-12-13 Thread Nabih Estefan
>From what I can tell this is the same issue Thomas was looking at yes. I saw the failure on the master branch at the v9.2.0 tag (ae35f033) and just re-tested it against (83aaec1d) and still see it. I haven't seen it be an intermittent failure, it has failed 100% of the time that I have tested it

Re: [PATCH v14 00/15] macOS PV Graphics and new vmapple machine type

2024-12-13 Thread Phil Dennis-Jordan
Sigh… apologies for re-sending v13 together with v14 here. Please ignore v13 of course. git send-email is not my friend… On Fri, 13 Dec 2024 at 16:24, Phil Dennis-Jordan wrote: > > This patch series has been through months of review and > refinement. It now has end-to-end Reviewed-by: tags and

[PATCH 36/71] hw/m68k: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/m68k/mcf5206.c | 2 +- hw/m68k/mcf_intc.c | 2 +- hw/m68k/next-cube.c | 2 +- hw/m68k/q800-glue.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/m68k/mcf5206.c b/hw/m68k/mcf5206.c index 7247cdbe5e..45e5f74600 100644 --- a/hw/m6

[PATCH 69/71] hw/xen: Use DEFINE_PROP_END_OF_LIST in xen_sysdev_properties

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/xen/xen-legacy-backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xen/xen-legacy-backend.c b/hw/xen/xen-legacy-backend.c index b15393e934..f6ad58fe13 100644 --- a/hw/xen/xen-legacy-backend.c +++ b/hw/xen/xen-legacy-backend.c @@

[PATCH 39/71] hw/misc/xlnx-versal-trng: Constify trng_props

2024-12-13 Thread Richard Henderson
Use DEFINE_PROP_UNSIGNED instead of DEFINE_PROP_UINT64 so that we can set the PropertyInfo during initialization, instead of updating within trng_class_init. Signed-off-by: Richard Henderson --- hw/misc/xlnx-versal-trng.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

[PATCH 43/71] hw/nvme: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/nvme/ctrl.c | 2 +- hw/nvme/ns.c | 2 +- hw/nvme/subsys.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index ec75419566..33a3062466 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -8927,7 +

Re: [PATCH] device/virtio-nsm: Support string data for extendPCR

2024-12-13 Thread Philippe Mathieu-Daudé
On 9/11/24 13:32, Dorjoy Chowdhury wrote: NSM device in AWS Nitro Enclaves supports extending with both bytestring and string data. Signed-off-by: Dorjoy Chowdhury --- hw/virtio/virtio-nsm.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) Queued, thanks!

[PATCH 50/71] hw/remote: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/remote/proxy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/remote/proxy.c b/hw/remote/proxy.c index 302a0a4d4d..6f84fdd3fa 100644 --- a/hw/remote/proxy.c +++ b/hw/remote/proxy.c @@ -191,7 +191,7 @@ static void pci_proxy_write_conf

[PATCH 20/71] hw/char: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/char/avr_usart.c | 2 +- hw/char/bcm2835_aux.c | 2 +- hw/char/cadence_uart.c | 2 +- hw/char/cmsdk-apb-uart.c| 2 +- hw/char/debugcon.c | 2 +- hw/char/digic-uart.c| 2 +- hw/char/escc.c | 2 +- hw/char/

[PATCH 67/71] hw/watchdog: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/watchdog/sbsa_gwdt.c | 2 +- hw/watchdog/wdt_aspeed.c | 2 +- hw/watchdog/wdt_imx2.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/watchdog/sbsa_gwdt.c b/hw/watchdog/sbsa_gwdt.c index 80f9b36e79..2e25d4b4e9 100644 --- a/hw/wat

[PATCH 71/71] docs: Constify all Property in examples

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- docs/devel/migration/compatibility.rst | 4 ++-- docs/devel/virtio-backends.rst | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/devel/migration/compatibility.rst b/docs/devel/migration/compatibility.rst index 5a5417ef06..c7

[PATCH 68/71] hw/xen: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/xen/xen-bus.c| 2 +- hw/xen/xen-legacy-backend.c | 4 ++-- hw/xen/xen_pt.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c index 95b207ac8b..0d7defb8cd 100644 --- a/hw/xen/xe

[PATCH 64/71] hw/usb: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/usb/bus.c | 2 +- hw/usb/canokey.c | 2 +- hw/usb/ccid-card-emulated.c | 2 +- hw/usb/ccid-card-passthru.c | 2 +- hw/usb/dev-audio.c| 2 +- hw/usb/dev-hid.c | 6 +++--- hw/usb/dev-hub.c

[PATCH 60/71] hw/timer: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/timer/a9gtimer.c | 2 +- hw/timer/allwinner-a10-pit.c | 2 +- hw/timer/arm_mptimer.c | 2 +- hw/timer/arm_timer.c | 2 +- hw/timer/aspeed_timer.c | 2 +- hw/timer/avr_timer16.c | 2 +- hw/timer/grlib_gptimer.c | 2 +- h

[PATCH 65/71] hw/vfio: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/vfio/ap.c | 2 +- hw/vfio/ccw.c | 2 +- hw/vfio/pci.c | 4 ++-- hw/vfio/platform.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index 4013e7b436..2e6ea2dd93 100644 --- a/hw/vfio/ap.c +++

[PATCH 70/71] tests/unit: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tests/unit/test-qdev-global-props.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/test-qdev-global-props.c b/tests/unit/test-qdev-global-props.c index c8862cac5f..1eb95d2429 100644 --- a/tests/unit/test-qdev-global-props.c +++

[PATCH 19/71] hw/block: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/block/fdc-isa.c| 2 +- hw/block/fdc-sysbus.c | 4 ++-- hw/block/fdc.c| 2 +- hw/block/m25p80.c | 2 +- hw/block/nand.c | 2 +- hw/block/pflash_cfi01.c | 2 +- hw/block/pflash_cfi02.c | 2 +- hw/block/swim.c

[PULL 4/4] target/sparc: Use memcpy() and remove memcpy32()

2024-12-13 Thread Richard Henderson
From: Philippe Mathieu-Daudé Rather than manually copying each register, use the libc memcpy(), which is well optimized nowadays. Suggested-by: Pierrick Bouvier Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20241205205418.6761

[PULL 37/85] target/arm: Introduce gen_gvec_cls, gen_gvec_clz

2024-12-13 Thread Peter Maydell
From: Richard Henderson Add gvec interfaces for CLS and CLZ operations. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-id: 20241211163036.2297116-38-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/translate.h | 5 + target/

[PULL 51/85] target/arm: Convert FCVTXN to decodetree

2024-12-13 Thread Peter Maydell
From: Richard Henderson Remove handle_2misc_narrow as this was the last insn decoded by that function. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20241211163036.2297116-52-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode

[PULL 78/85] target/arm: Move AArch64 TLBI insns from v8_cp_reginfo[]

2024-12-13 Thread Peter Maydell
Move the AArch64 TLBI insns that are declared in v8_cp_reginfo[] into tlb-insns.c. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20241210160452.2427965-4-peter.mayd...@linaro.org --- target/arm/cpregs.h| 11 +++ target/arm/helper.c| 182 +++

[PULL 08/85] target/arm: Convert CLZ, CLS to decodetree

2024-12-13 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-id: 20241211163036.2297116-9-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 3 ++ target/arm/tcg/translate-a64.c | 72 ++---

[PULL 46/85] target/arm: Convert handle_2misc_pairwise to decodetree

2024-12-13 Thread Peter Maydell
From: Richard Henderson This includes SADDLP, UADDLP, SADALP, UADALP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20241211163036.2297116-47-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/helper-a64.h| 2 - target/arm/tcg/a64.deco

  1   2   3   4   >