Re: [PATCH] i386/kvm: Set return value after handling KVM_EXIT_HYPERCALL

2024-12-11 Thread Zhao Liu
On Thu, Dec 12, 2024 at 11:26:28AM +0800, Binbin Wu wrote: > Date: Thu, 12 Dec 2024 11:26:28 +0800 > From: Binbin Wu > Subject: [PATCH] i386/kvm: Set return value after handling > KVM_EXIT_HYPERCALL > X-Mailer: git-send-email 2.46.0 > > Userspace should set the ret field of hypercall after handl

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2024-12-11 Thread Tomoyuki HIROSE
On 2024/12/12 7:54, Peter Xu wrote: On Wed, Dec 11, 2024 at 06:35:57PM +0900, Tomoyuki HIROSE wrote: Sorry for late reply. On 2024/12/07 1:42, Peter Xu wrote: On Fri, Dec 06, 2024 at 05:31:33PM +0900, Tomoyuki HIROSE wrote: In this email, I explain what this patch set will resolve and an over

Re: [PATCH] i386/kvm: Set return value after handling KVM_EXIT_HYPERCALL

2024-12-11 Thread Binbin Wu
On 12/12/2024 3:09 PM, Xiaoyao Li wrote: On 12/12/2024 1:18 PM, Binbin Wu wrote: On 12/12/2024 11:44 AM, Xiaoyao Li wrote: On 12/12/2024 11:26 AM, Binbin Wu wrote: Userspace should set the ret field of hypercall after handling KVM_EXIT_HYPERCALL.  Otherwise, a stale value could be retur

Re: [PATCH v2] hw/virtio: Fix check available index on virtio loading

2024-12-11 Thread Eugenio Perez Martin
On Thu, Dec 12, 2024 at 3:30 AM Wafer wrote: > > > > > -Original Message- > > From: Eugenio Perez Martin > > Sent: 2024年12月11日 20:45 > > To: Wafer > > Cc: m...@redhat.com; jasow...@redhat.com; qemu-devel@nongnu.org; > > Angus Chen > > Subject: Re: [PATCH v2] hw/virtio: Fix check availab

Re: [RFC PATCH 3/4] i386: Track cores_per_module in CPUX86State

2024-12-11 Thread Xiaoyao Li
On 12/11/2024 10:50 AM, Zhao Liu wrote: On Tue, Dec 10, 2024 at 05:43:38PM +0100, Igor Mammedov wrote: Date: Tue, 10 Dec 2024 17:43:38 +0100 From: Igor Mammedov Subject: Re: [RFC PATCH 3/4] i386: Track cores_per_module in CPUX86State X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-

Re: [RFC PATCH 1/4] i386/topology: Update the comment of x86_apicid_from_topo_ids()

2024-12-11 Thread Xiaoyao Li
On 12/11/2024 10:54 AM, Zhao Liu wrote: On Thu, Dec 05, 2024 at 09:57:13AM -0500, Xiaoyao Li wrote: Date: Thu, 5 Dec 2024 09:57:13 -0500 From: Xiaoyao Li Subject: [RFC PATCH 1/4] i386/topology: Update the comment of x86_apicid_from_topo_ids() X-Mailer: git-send-email 2.34.1 Update the commen

Re: [PATCH] i386/kvm: Set return value after handling KVM_EXIT_HYPERCALL

2024-12-11 Thread Yao Yuan
On Thu, Dec 12, 2024 at 11:26:28AM +0800, Binbin Wu wrote: > Userspace should set the ret field of hypercall after handling > KVM_EXIT_HYPERCALL. Otherwise, a stale value could be returned to KVM. > > Fixes: 47e76d03b15 ("i386/kvm: Add KVM_EXIT_HYPERCALL handling for > KVM_HC_MAP_GPA_RANGE") > Re

Re: [PATCH] i386/kvm: Set return value after handling KVM_EXIT_HYPERCALL

2024-12-11 Thread Binbin Wu
On 12/12/2024 11:44 AM, Xiaoyao Li wrote: On 12/12/2024 11:26 AM, Binbin Wu wrote: Userspace should set the ret field of hypercall after handling KVM_EXIT_HYPERCALL.  Otherwise, a stale value could be returned to KVM. Fixes: 47e76d03b15 ("i386/kvm: Add KVM_EXIT_HYPERCALL handling for KVM_H

Re: [PATCH v2 05/31] tests/functional: drop 'tesseract_available' helper

2024-12-11 Thread Thomas Huth
On 11/12/2024 18.26, Daniel P. Berrangé wrote: Platforms we target have new enough tesseract that it suffices to merely check if the binary exists. Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/tesseract.py | 12 +--- tests/functional/test_m68k_nextcube.py | 8 ++

Re: [PATCH v2 06/31] tests/functional: introduce some helpful decorators

2024-12-11 Thread Thomas Huth
On 11/12/2024 18.26, Daniel P. Berrangé wrote: Reduce repeated boilerplate with some helper decorators: @skipIfNotPlatform("x86_64", "aarch64") => Skip unless the build host platform matches @skipIfMissingCommands("mkisofs", "losetup") => Skips unless all listed commands are found i

Re: [PATCH] i386/kvm: Set return value after handling KVM_EXIT_HYPERCALL

2024-12-11 Thread Xiaoyao Li
On 12/12/2024 1:18 PM, Binbin Wu wrote: On 12/12/2024 11:44 AM, Xiaoyao Li wrote: On 12/12/2024 11:26 AM, Binbin Wu wrote: Userspace should set the ret field of hypercall after handling KVM_EXIT_HYPERCALL.  Otherwise, a stale value could be returned to KVM. Fixes: 47e76d03b15 ("i386/kvm: Ad

Re: [PATCH v2 08/31] tests/functional: drop 'has_cmd' and 'has_cmds' helpers

2024-12-11 Thread Thomas Huth
On 11/12/2024 18.26, Daniel P. Berrangé wrote: The 'which' helper is simpler and sufficient for test needs. ... and it does not depend on the external "which" program that might not be installed on all host systems, so this is much better indeed! Signed-off-by: Daniel P. Berrangé --- tes

Re: [PATCH] i386/kvm: Set return value after handling KVM_EXIT_HYPERCALL

2024-12-11 Thread Xiaoyao Li
On 12/12/2024 11:26 AM, Binbin Wu wrote: Userspace should set the ret field of hypercall after handling KVM_EXIT_HYPERCALL. Otherwise, a stale value could be returned to KVM. Fixes: 47e76d03b15 ("i386/kvm: Add KVM_EXIT_HYPERCALL handling for KVM_HC_MAP_GPA_RANGE") Reported-by: Farrah Chen Sig

Re: [RFC PATCH 2/4] i386: Extract a common fucntion to setup value of MSR_CORE_THREAD_COUNT

2024-12-11 Thread Xiaoyao Li
On 12/11/2024 12:35 AM, Igor Mammedov wrote: On Thu, 5 Dec 2024 22:38:41 +0100 Philippe Mathieu-Daudé wrote: Hi Xiaoyao, On 5/12/24 15:57, Xiaoyao Li wrote: There are duplicated code to setup the value of MSR_CORE_THREAD_COUNT. Extract a common function for it. Signed-off-by: Xiaoyao Li --

Re: [RFC PATCH 3/4] i386: Track cores_per_module in CPUX86State

2024-12-11 Thread Xiaoyao Li
On 12/11/2024 12:43 AM, Igor Mammedov wrote: On Thu, 5 Dec 2024 09:57:15 -0500 Xiaoyao Li wrote: x86 is the only user of CPUState::nr_cores. Define cores_per_module in CPUX86State, which can serve as the substitute of CPUState::nr_cores. After x86 switches to use CPUX86State::cores_per_modul

<    1   2   3   4   5