Re: [RFC PATCH 3/4] i386: Track cores_per_module in CPUX86State

2024-12-10 Thread Zhao Liu
On Tue, Dec 10, 2024 at 05:43:38PM +0100, Igor Mammedov wrote: > Date: Tue, 10 Dec 2024 17:43:38 +0100 > From: Igor Mammedov > Subject: Re: [RFC PATCH 3/4] i386: Track cores_per_module in CPUX86State > X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) > > On Thu, 5 Dec 2024 09:57

Re: [PATCH 15/20] tests/functional/aarch64: add tests for FEAT_RME

2024-12-10 Thread Pierrick Bouvier
On 12/10/24 14:15, Richard Henderson wrote: On 12/10/24 14:43, Alex Bennée wrote: From: Pierrick Bouvier This boot an OP-TEE environment, and launch a nested guest VM inside it using the Realms feature. We do it for virt and sbsa-ref platforms. Signed-off-by: Pierrick Bouvier - v2: - mov

[RFC PATCH v4 0/1] Sbsa-ref CXL Enablement

2024-12-10 Thread Yuquan Wang
v3 -> v4: - based on 'cxl/cxl-host: Support creation of a new CXL Host Bridge'[1] - Align base addresses of CXL relevant Windows - Remove redundant header files v2 -> v3: - create a new host bridge type: TYPE_SBSA_CXL_HOST - CXL exclusive ECAM, PIO, MMIO32 & MMIO64 space in sbsa-ref - combine all

Re: [RFC PATCH 1/4] i386/topology: Update the comment of x86_apicid_from_topo_ids()

2024-12-10 Thread Zhao Liu
On Thu, Dec 05, 2024 at 09:57:13AM -0500, Xiaoyao Li wrote: > Date: Thu, 5 Dec 2024 09:57:13 -0500 > From: Xiaoyao Li > Subject: [RFC PATCH 1/4] i386/topology: Update the comment of > x86_apicid_from_topo_ids() > X-Mailer: git-send-email 2.34.1 > > Update the comment of x86_apicid_from_topo_ids(

RE: [PATCH v5 18/20] intel_iommu: Introduce a property x-flts for scalable modern mode

2024-12-10 Thread Duan, Zhenzhong
Hi Jason, Clement, Sorry for late reply, just back from vacation. >-Original Message- >From: CLEMENT MATHIEU--DRIF >Subject: Re: [PATCH v5 18/20] intel_iommu: Introduce a property x-flts for >scalable modern mode > > > > >On 09/12/2024 07:24, Jason Wang wrote: >> Caution: External email.

Re: [RFC PATCH 4/4] cpu: Remove nr_cores from struct CPUState

2024-12-10 Thread Zhao Liu
On Thu, Dec 05, 2024 at 09:57:16AM -0500, Xiaoyao Li wrote: > Date: Thu, 5 Dec 2024 09:57:16 -0500 > From: Xiaoyao Li > Subject: [RFC PATCH 4/4] cpu: Remove nr_cores from struct CPUState > X-Mailer: git-send-email 2.34.1 > > There is no user of it now, remove it. > > Signed-off-by: Xiaoyao Li >

Re: [PATCH v3 00/26] arm: Run Arm CCA VMs with KVM

2024-12-10 Thread Gavin Shan
Hi Jean, On 11/26/24 5:55 AM, Jean-Philippe Brucker wrote: This series enables running confidential VMs on Arm CCA. The host KVM support is progressing but still under discussion [1], so there is no urgency to upstream this series. I'm sending this new version to give a status update, and also t

Re: [PATCH v2] tests/functional: Convert the intel_iommu avocado test

2024-12-10 Thread Philippe Mathieu-Daudé
On 10/12/24 13:56, Thomas Huth wrote: Convert the intel_iommu test to the new functional framework. This test needs some changes since we neither support the old 'LinuxTest' class in the functional framework yet, nor a way to use SSH for running commands in the guest. So we now directly download

[PATCH v2 1/3] dump/dump: Include missing 'exec/memory.h' header

2024-12-10 Thread Philippe Mathieu-Daudé
dump.c calls address_space_read() which is declared in "exec/memory.h". Include it explicitly to avoid when refactoring unrelated headers: dump/dump.c:1892:13: error: call to undeclared function 'address_space_read'; ISO C99 and later do not support implicit function declarations [-Wimplicit-f

[PATCH v2 2/3] bulk: Replace legacy cpu_physical_memory_rw() API

2024-12-10 Thread Philippe Mathieu-Daudé
Use the following coccinelle script: @@ expression addr, buf, len, is_write; @@ ( - cpu_physical_memory_read(addr, buf, len) + address_space_read(&address_space_memory, addr, MEMTXATTRS_UNSPECIFIED, buf, len) | - cpu_physical_memory_rw(addr, buf, len, false) +

[PATCH 07/46] tcg/optimize: Use fold_masks_zsa in fold_andc

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 000ac0f810..285407ce05 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1339,7 +1339,7 @@ static bool fold_and(OptConte

[PATCH 42/46] tcg/optimize: Use finish_folding in fold_bitsel_vec

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index fec46014be..24ec14f476 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2821,7 +2821,7 @@ static bool fold_bitsel_vec(OptContext *ctx,

Re: [PATCH 11/17] target/hexagon: Use float32_muladd for helper_sffm[as]_lib

2024-12-10 Thread Brian Cain
On 12/8/2024 4:48 PM, Richard Henderson wrote: There are multiple special cases for this instruction. (1) The saturate to normal maximum instead of overflow to infinity is handled by the new float_round_nearest_even_max rounding mode. (2) The 0 * n + c special case is handled by the new

[PATCH 04/46] tcg/optimize: Use finish_folding in fold_add, fold_add_vec

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 6644d24da6..3f2f351bae 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -978,7 +978,7 @@ static void finish_ebb(OptContext *ctx)

[PATCH 08/46] tcg/optimize: Use fold_masks_zs in fold_bswap

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 285407ce05..3363ebd48c 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1082,7 +1082,6 @@ static bool fold_masks_zsa(OptContext *ct

[PATCH 40/46] tcg/optimize: Use finish_folding in fold_tcg_ld_memcopy

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 4cccb3b0cf..46116970f3 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2674,7 +2674,7 @@ static bool fold_tcg_ld_memcopy(OptContext *c

[PATCH 41/46] tcg/optimize: Use fold_masks_zs in fold_xor

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 46116970f3..fec46014be 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1093,11 +1093,6 @@ static bool fold_masks_z(

[PATCH 16/46] tcg/optimize: Use finish_folding in fold_extract2

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 955151f4cf..a0ccf7f3f2 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1754,7 +1754,7 @@ static bool fold_extract2(OptContext *ctx, TC

[PATCH 45/46] tcg/optimize: Move fold_bitsel_vec into alphabetic sort

2024-12-10 Thread Richard Henderson
The big comment just above says functions should be sorted. Add forward declarations as needed. Signed-off-by: Richard Henderson --- tcg/optimize.c | 114 + 1 file changed, 59 insertions(+), 55 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimi

[PATCH 43/46] tcg/optimize: Use finish_folding as default in tcg_optimize

2024-12-10 Thread Richard Henderson
All non-default cases now finish folding within each function. Do the same with the default case and assert it is done after. Signed-off-by: Richard Henderson --- tcg/optimize.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 24ec14

[PATCH 21/46] tcg/optimize: Use fold_masks_zs in fold_nand

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 111969c2e3..924ee165ba 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2011,14 +2011,16 @@ static bool fold_multiply2(OptConte

[PATCH 28/46] tcg/optimize: Return true from fold_qemu_st, fold_tcg_st

2024-12-10 Thread Richard Henderson
Stores have no output operands, and so need no further work. Signed-off-by: Richard Henderson --- tcg/optimize.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 6f41ef5adb..ee00620ce0 100644 --- a/tcg/optimize.c +++ b/tcg/opti

[PATCH 38/46] tcg/optimize: Use finish_folding in fold_sub, fold_sub_vec

2024-12-10 Thread Richard Henderson
Duplicate fold_sub_vec into fold_sub instead of calling it, now that fold_sub_vec always returns true. Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index bec5a07288..6412d5df37 100

[PATCH 05/46] tcg/optimize: Use finish_folding in fold_addsub2

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 3f2f351bae..135b14974f 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1292,7 +1292,7 @@ static bool fold_addsub2(OptContext *ctx, TCG

[PATCH 46/46] tcg/optimize: Move fold_cmp_vec, fold_cmpsel_vec into alphabetic sort

2024-12-10 Thread Richard Henderson
The big comment just above says functions should be sorted. Signed-off-by: Richard Henderson --- tcg/optimize.c | 60 +- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 54082042aa..2c5691e3c9 10

[PATCH 27/46] tcg/optimize: Use fold_masks_zs in fold_qemu_ld

2024-12-10 Thread Richard Henderson
Be careful not to call fold_masks_zs when the memory operation is wide enough to require multiple outputs, so split into two functions: fold_qemu_ld_1reg and fold_qemu_ld_2reg. Signed-off-by: Richard Henderson --- tcg/optimize.c | 28 ++-- 1 file changed, 22 insertions(+)

[PATCH 22/46] tcg/optimize: Use fold_masks_z in fold_neg_no_const

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 924ee165ba..cc3dc91d3f 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2027,14 +2027,9 @@ static bool fold_neg_no_const(OptCo

[PATCH 39/46] tcg/optimize: Use fold_masks_zs in fold_tcg_ld

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 6412d5df37..4cccb3b0cf 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2636,33 +2636,35 @@ static bool fold_s

[PATCH 13/46] tcg/optimize: Use finish_folding in fold_dup, fold_dup2

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 59f510b49a..e6dc9f2e28 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1681,7 +1681,7 @@ static bool fold_dup(OptContext *ctx, TCG

[PATCH 24/46] tcg/optimize: Use fold_masks_zs in fold_not

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index aa5242a380..ae1386c681 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2056,12 +2056,7 @@ static bool fold_not(OptContext *ctx,

Re: [PATCH v2 0/3] bulk: Remove legacy cpu_physical_memory_rw() API

2024-12-10 Thread Peter Maydell
On Tue, 10 Dec 2024 at 15:10, Philippe Mathieu-Daudé wrote: > > On 10/12/24 16:03, Peter Maydell wrote: > > On Tue, 10 Dec 2024 at 15:00, Peter Maydell > > wrote: > >> > >> On Tue, 10 Dec 2024 at 14:01, Philippe Mathieu-Daudé > >> wrote: > >>> > >>> cpu_physical_memory_rw() API is documented a

Re: [PATCH 14/26] rust: qom: move bridge for TypeInfo functions out of pl011

2024-12-10 Thread Zhao Liu
On Mon, Dec 09, 2024 at 01:37:05PM +0100, Paolo Bonzini wrote: > Date: Mon, 9 Dec 2024 13:37:05 +0100 > From: Paolo Bonzini > Subject: [PATCH 14/26] rust: qom: move bridge for TypeInfo functions out of > pl011 > X-Mailer: git-send-email 2.47.1 > > Allow the ObjectImpl trait to expose Rust funct

Re: [PATCH 14/26] rust: qom: move bridge for TypeInfo functions out of pl011

2024-12-10 Thread Zhao Liu
> +unsafe extern "C" fn rust_instance_init(obj: *mut Object) { > +// SAFETY: obj is an instance of T, since rust_instance_init > +// is called from QOM core as the instance_init function > +// for class T > +unsafe { T::INSTANCE_INIT.unwrap()(&mut *obj.cast::()) } > +} Here's the d

Re: [PATCH 10/26] rust: qom: move ClassInitImpl to the instance side

2024-12-10 Thread Zhao Liu
On Mon, Dec 09, 2024 at 01:37:01PM +0100, Paolo Bonzini wrote: > Date: Mon, 9 Dec 2024 13:37:01 +0100 > From: Paolo Bonzini > Subject: [PATCH 10/26] rust: qom: move ClassInitImpl to the instance side > X-Mailer: git-send-email 2.47.1 > > Put all traits on the instance struct, which makes it poss

Re: [PATCH v2 0/3] bulk: Remove legacy cpu_physical_memory_rw() API

2024-12-10 Thread Peter Maydell
On Tue, 10 Dec 2024 at 15:10, Philippe Mathieu-Daudé wrote: > > On 10/12/24 16:03, Peter Maydell wrote: > > On Tue, 10 Dec 2024 at 15:00, Peter Maydell > > wrote: > >> > >> On Tue, 10 Dec 2024 at 14:01, Philippe Mathieu-Daudé > >> wrote: > >>> > >>> cpu_physical_memory_rw() API is documented a

[PATCH 01/46] tcg/optimize: Split out finish_bb, finish_ebb

2024-12-10 Thread Richard Henderson
Call them directly from the opcode switch statement in tcg_optimize, rather than in finish_folding based on opcode flags. Adjust folding of conditional branches to match. Signed-off-by: Richard Henderson --- tcg/optimize.c | 47 +++ 1 file changed, 31

[PATCH 15/46] tcg/optimize: Use fold_masks_zsa in fold_extract

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 5f3a824a07..955151f4cf 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1716,7 +1716,7 @@ static bool fold_eqv(OptContext *ctx

[PATCH 02/46] tcg/optimize: Copy mask writeback to fold_masks

2024-12-10 Thread Richard Henderson
Use of fold_masks should be restricted to those opcodes that can reliably make use of it -- those with a single output, and from higher-level folders that set up the masks. Prepare for conversion of each folder in turn. Signed-off-by: Richard Henderson --- tcg/optimize.c | 14 +++--- 1 f

[PATCH 12/46] tcg/optimize: Use finish_folding in fold_divide

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 4d5fa04199..59f510b49a 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1671,7 +1671,7 @@ static bool fold_divide(OptContext *ctx, TCGO

[PATCH 00/46] tcg: Remove in-flight mask data from OptContext

2024-12-10 Thread Richard Henderson
The desire is to start re-using some of the fold_* functions while lowering or simplifying operations during tcg_optmize. Many of these fold_* functions set z_mask, s_mask, and a_mask, which hang around until the end of the tcg_optmize loop and are applied by finish_folding. This disconnect betwe

[PATCH 23/46] tcg/optimize: Use fold_masks_zs in fold_nor

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index cc3dc91d3f..aa5242a380 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2039,14 +2039,16 @@ static bool fold_neg(OptContext *ct

[PATCH 25/46] tcg/optimize: Use fold_masks_zs in fold_or

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index ae1386c681..3d852b44e4 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2061,17 +2061,19 @@ static bool fold_not(OptContex

[PATCH 17/46] tcg/optimize: Use fold_masks_zsa in fold_exts

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index a0ccf7f3f2..5d10e704a7 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1759,7 +1759,7 @@ static bool fold_extract2(OptContext

[PATCH 31/46] tcg/optimize: Use fold_masks_z in fold_setcond

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 7b1d437c27..cfd4c08f11 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2349,9 +2349,7 @@ static bool fold_setcond(OptContext *ctx,

[PATCH 37/46] tcg/optimize: Use fold_masks_zs in fold_shift

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 551f96dfaa..bec5a07288 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2530,12 +2530,12 @@ static bool fold_shift(OptC

[PATCH 29/46] tcg/optimize: Use finish_folding in fold_remainder

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index ee00620ce0..eac5ef5eec 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2134,7 +2134,7 @@ static bool fold_remainder(OptContext *ctx, T

[PATCH 35/46] tcg/optimize: Use finish_folding in fold_cmpsel_vec

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 30446baabd..c99e6f79d2 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2483,7 +2483,7 @@ static bool fold_cmpsel_vec(OptContext *ctx,

[PATCH 03/46] tcg/optimize: Add fold_masks_zsa, fold_masks_zs, fold_masks_z

2024-12-10 Thread Richard Henderson
Add additional routines to pass masks directly, rather than storing them into OptContext. To be used in upcoming patches. Signed-off-by: Richard Henderson --- tcg/optimize.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimi

[PATCH 10/46] tcg/optimize: Use fold_masks_z in fold_ctpop

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index c97ec10989..424ed7674d 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1598,22 +1598,23 @@ static bool fold_count_zeros(OptCo

[PATCH 11/46] tcg/optimize: Use fold_and and fold_masks_z in fold_deposit

2024-12-10 Thread Richard Henderson
When we fold to and, use fold_and, which sets s_mask and a_mask more intelligently than we do for the rest of deposit. Signed-off-by: Richard Henderson --- tcg/optimize.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 424e

[PATCH 34/46] tcg/optimize: Use finish_folding in fold_cmp_vec

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index dd6ef3d831..30446baabd 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2462,7 +2462,7 @@ static bool fold_cmp_vec(OptContext *ctx, TCG

[PATCH 33/46] tcg/optimize: Use fold_masks_z in fold_setcond2

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 0097502425..dd6ef3d831 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2450,9 +2450,7 @@ static bool fold_setcond2(OptContext *ctx,

[PATCH 18/46] tcg/optimize: Use fold_masks_zsa in fold_extu

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 5d10e704a7..260e3ea072 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1804,7 +1804,7 @@ static bool fold_exts(OptContext *

[PATCH 36/46] tcg/optimize: Use fold_masks_zsa in fold_sextract

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index c99e6f79d2..551f96dfaa 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2488,7 +2488,7 @@ static bool fold_cmpsel_vec(OptContex

[PATCH 19/46] tcg/optimize: Use fold_masks_zs in fold_movcond

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 260e3ea072..6d2d55f053 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1874,6 +1874,7 @@ static bool fold_mov(OptContext *

[PATCH 26/46] tcg/optimize: Use fold_masks_zs in fold_orc

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 3d852b44e4..76ad02d73b 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2078,6 +2078,8 @@ static bool fold_or(OptContext *ctx,

[PATCH 32/46] tcg/optimize: Use fold_masks_zs in fold_negsetcond

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index cfd4c08f11..0097502425 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2369,8 +2369,7 @@ static bool fold_negsetcond(OptContext *ctx

[PATCH 09/46] tcg/optimize: Use fold_masks_z in fold_count_zeros

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 3363ebd48c..c97ec10989 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1088,7 +1088,6 @@ static bool fold_masks_zs(OptContext *

[PATCH 20/46] tcg/optimize: Use finish_folding in fold_mul*

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 6d2d55f053..111969c2e3 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1952,7 +1952,7 @@ static bool fold_mul(OptContext *ctx, T

[PATCH 06/46] tcg/optimize: Use fold_masks_zsa in fold_and

2024-12-10 Thread Richard Henderson
Avoid the use of the OptContext slots. Signed-off-by: Richard Henderson --- tcg/optimize.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 135b14974f..000ac0f810 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1306,7 +13

[PATCH 30/46] tcg/optimize: Distinguish simplification in fold_setcond_zmask

2024-12-10 Thread Richard Henderson
Change return from bool to int; distinguish between complete folding, simplification, and no change. Signed-off-by: Richard Henderson --- tcg/optimize.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index eac5ef5eec..7

[PATCH 44/46] tcg/optimize: Remove [zsa]_mask from OptContext

2024-12-10 Thread Richard Henderson
All mask setting is now done with parameters via fold_masks_*. Signed-off-by: Richard Henderson --- tcg/optimize.c | 16 1 file changed, 16 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 94e942e1cf..eb6e93809e 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@

[PATCH 14/46] tcg/optimize: Use fold_masks_zs in fold_eqv

2024-12-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index e6dc9f2e28..5f3a824a07 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1701,15 +1701,17 @@ static bool fold_dup2(OptContext *c

Re: [PATCH 0/2] overcommit: introduce mem-lock-onfault

2024-12-10 Thread Daniil Tatianin
On 12/10/24 8:20 PM, Peter Xu wrote: On Tue, Dec 10, 2024 at 08:01:08PM +0300, Daniil Tatianin wrote: I mentioned my use case in the cover letter. Basically we want to protect QEMU's pages from being migrated and compacted by kcompactd, which it accomplishes by modifying live page tables and s

Re: [PATCH for-10.0 00/11] fpu: pickNaN follow ups

2024-12-10 Thread Peter Maydell
On Tue, 3 Dec 2024 at 20:39, Richard Henderson wrote: > > Based-on: 20241202131347.498124-55-peter.mayd...@linaro.org > ([PATCH v2 for-10.0 54/54] fpu: Remove default handling for dnan_pattern) > > The first patch needs to be inserted into Peter's patch set, > any place before 54/54 when dnan_patt

Re: [PATCH 0/2] overcommit: introduce mem-lock-onfault

2024-12-10 Thread Peter Xu
On Tue, Dec 10, 2024 at 08:01:08PM +0300, Daniil Tatianin wrote: > I mentioned my use case in the cover letter. Basically we want to protect > QEMU's pages from being migrated and compacted by kcompactd, which it > accomplishes by modifying live page tables and spamming the process with TLB > inval

Re: [PATCH] MAINTAINERS: update email address for Leif Lindholm

2024-12-10 Thread Peter Maydell
On Thu, 5 Dec 2024 at 11:40, Leif Lindholm wrote: > > From: Leif Lindholm > > I'm migrating to Qualcomm's new open source email infrastructure, so > update my email address, and update the mailmap to match. > > Signed-off-by: Leif Lindholm Applied to target-arm.next for 10.0, thanks. -- PMM

Re: [PATCH] MAINTAINERS: Add correct email address for Vikram Garhwal

2024-12-10 Thread Peter Maydell
On Sat, 7 Dec 2024 at 22:40, Francisco Iglesias wrote: > > On Wed, Dec 04, 2024 at 10:42:05AM -0800, Vikram Garhwal wrote: > > Previously, maintainer role was paused due to inactive email id. Commit id: > > c009d715721861984c4987bcc78b7ee183e86d75. > > > > Signed-off-by: Vikram Garhwal > > Review

Re: [PATCH v2] crypto: run qcrypto_pbkdf2_count_iters in a new thread

2024-12-10 Thread Thomas Huth
On 05/09/2024 01.52, Tiago Pasqualini wrote: CPU time accounting in the kernel has been demonstrated to have a sawtooth pattern[1][2]. This can cause the getrusage system call to not be as accurate as we are expecting, which can cause this calculation to stall. The kernel discussions shows that

Re: [PATCH 14/26] rust: qom: move bridge for TypeInfo functions out of pl011

2024-12-10 Thread Paolo Bonzini
On 12/10/24 16:50, Zhao Liu wrote: On Mon, Dec 09, 2024 at 01:37:05PM +0100, Paolo Bonzini wrote: Date: Mon, 9 Dec 2024 13:37:05 +0100 From: Paolo Bonzini Subject: [PATCH 14/26] rust: qom: move bridge for TypeInfo functions out of pl011 X-Mailer: git-send-email 2.47.1 Allow the ObjectImpl t

[PATCH 06/20] tests/functional: update the mips64 tuxrun tests

2024-12-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-27-alex.ben...@linaro.org> --- tests/functional/test_mips64_tuxrun.py | 8 1 file ch

[PATCH 00/20] testing/next: functional tests and qtest timers

2024-12-10 Thread Alex Bennée
There are two parts to this series. The first is the updated images for all the guests that didn't make it into 9.2. There are also some new functional tests for virtio-gpu along with some other clean-ups. The qtest patches focus on ensuring things calling clock_step and clock_set actually pay att

[PATCH 20/20] tests/functional: extend test_aarch64_virt with vulkan test

2024-12-10 Thread Alex Bennée
Now we have virtio-gpu Vulkan support lets add a test for it. Currently this is using images build by buildroot: https://lists.buildroot.org/pipermail/buildroot/2024-December/768196.html Signed-off-by: Alex Bennée --- tests/functional/test_aarch64_virt.py | 83 ++- 1 f

[PATCH 14/20] tests/functional: update the x86_64 tuxrun tests

2024-12-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-35-alex.ben...@linaro.org> --- tests/functional/test_x86_64_tuxrun.py | 8 1 file ch

[PATCH 10/20] tests/functional: update the riscv32 tuxrun tests

2024-12-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-31-alex.ben...@linaro.org> --- tests/functional/test_riscv32_tuxrun.py | 8 1 file c

[PATCH 16/20] util/qemu-timer: fix indentation

2024-12-10 Thread Alex Bennée
Purely cosmetic. Signed-off-by: Alex Bennée --- util/qemu-timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index ffe9a3c5c1..7b71655416 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -680,7 +680,7 @@ int64_t qemu_clock_a

[PATCH 13/20] tests/functional: update the sparc64 tuxrun tests

2024-12-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-34-alex.ben...@linaro.org> --- tests/functional/test_sparc64_tuxrun.py | 8 1 file c

[PATCH 05/20] tests/functional: update the mips32el tuxrun tests

2024-12-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-26-alex.ben...@linaro.org> --- tests/functional/test_mipsel_tuxrun.py | 8 1 file ch

[PATCH 08/20] tests/functional: update the ppc32 tuxrun tests

2024-12-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-29-alex.ben...@linaro.org> --- tests/functional/test_ppc_tuxrun.py | 8 1 file chang

[PATCH 15/20] tests/functional/aarch64: add tests for FEAT_RME

2024-12-10 Thread Alex Bennée
From: Pierrick Bouvier This boot an OP-TEE environment, and launch a nested guest VM inside it using the Realms feature. We do it for virt and sbsa-ref platforms. Signed-off-by: Pierrick Bouvier - v2: - move test to its own file - add sbsa test - check output of `cca-workload-attestation

[PATCH 07/20] tests/functional: update the mips64el tuxrun tests

2024-12-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-28-alex.ben...@linaro.org> --- tests/functional/test_mips64el_tuxrun.py | 8 1 file

[PATCH 02/20] tests/functional: update the i386 tuxrun tests

2024-12-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-23-alex.ben...@linaro.org> --- tests/functional/test_i386_tuxrun.py | 8 1 file chan

Re: [RFC PATCH 4/5] hw/arm/virt-acpi-build: Build IORT with multiple SMMU nodes

2024-12-10 Thread Nicolin Chen
On Thu, Nov 21, 2024 at 09:46:16AM +, Shameerali Kolothum Thodi wrote: > Hi Eric, > > > -Original Message- > > From: Shameerali Kolothum Thodi > > Sent: Wednesday, November 20, 2024 4:26 PM > > To: 'eric.au...@redhat.com' ; qemu- > > a...@nongnu.org; qemu-devel@nongnu.org > > Cc: peter

[PATCH 01/20] tests/functional: update the arm tuxrun tests

2024-12-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-21-alex.ben...@linaro.org> --- tests/functional/test_arm_tuxrun.py | 28 ++---

[PATCH 11/20] tests/functional: update the riscv64 tuxrun tests

2024-12-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Note we re-use the riscv32 kernel and rootfs for test_riscv64_rv32. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-32-alex.ben...@linaro.org>

[PATCH 09/20] tests/functional: update the ppc64 tuxrun tests

2024-12-10 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-30-alex.ben...@linaro.org> --- tests/functional/test_ppc64_tuxrun.py | 16 1

Re: [PATCH 20/20] tests/functional: extend test_aarch64_virt with vulkan test

2024-12-10 Thread Richard Henderson
On 12/10/24 14:43, Alex Bennée wrote: Now we have virtio-gpu Vulkan support lets add a test for it. Currently this is using images build by buildroot: https://lists.buildroot.org/pipermail/buildroot/2024-December/768196.html Signed-off-by: Alex Bennée --- tests/functional/test_aarch64_vir

Re: [RFC PATCH 5/5] hw/arm/virt-acpi-build: Add IORT RMR regions to handle MSI nested binding

2024-12-10 Thread Jason Gunthorpe
On Tue, Dec 10, 2024 at 03:01:48PM -0800, Nicolin Chen wrote: > Yet, here we seem to be missing a pathway between VMM and kernel > to agree on the MSI window decided by the kernel, as this patch > does the hard coding for a [0x800, 0x810) range. I would ideally turn it around and provide

[PATCH 17/20] tests/qtest: move clock_steps to after checks

2024-12-10 Thread Alex Bennée
In the qtest environment time will not step forward if the system is paused (timers disabled) or we have no timer events to fire. As a result VirtIO events are responded to directly and we don't need to step time forward. Potentially the clock_step calls could be removed all together but as we may

[PATCH 03/20] tests/functional: add a m68k tuxrun tests

2024-12-10 Thread Alex Bennée
We didn't have this before and as it exercises the m68k virt platform it seems worth adding. We don't wait for the shutdown because QEMU will auto-exit on the shutdown. Cc: Laurent Vivier Cc: Anders Roxell Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-2

[PATCH 19/20] tests/functional: remove hacky sleep from the tests

2024-12-10 Thread Alex Bennée
We have proper detection of prompts now so we don't need to guess with sleep() sprinkled through the test. The extra step of calling halt is just to flush the final bits of the log (although the last line is still missed). Signed-off-by: Alex Bennée --- tests/functional/test_aarch64_virt.py | 22

[PATCH 18/20] system/qtest: properly feedback results of clock_[step|set]

2024-12-10 Thread Alex Bennée
Time will not advance if the system is paused or there are no timer events set for the future. In absence of pending timer events advancing time would make no difference the system state. Attempting to do so would be a bug and the test or device under test would need fixing. Tighten up the result

Re: [PATCH 15/20] tests/functional/aarch64: add tests for FEAT_RME

2024-12-10 Thread Richard Henderson
On 12/10/24 14:43, Alex Bennée wrote: From: Pierrick Bouvier This boot an OP-TEE environment, and launch a nested guest VM inside it using the Realms feature. We do it for virt and sbsa-ref platforms. Signed-off-by: Pierrick Bouvier - v2: - move test to its own file - add sbsa test - chec

Re: [PATCH 16/20] util/qemu-timer: fix indentation

2024-12-10 Thread Richard Henderson
On 12/10/24 14:43, Alex Bennée wrote: Purely cosmetic. Signed-off-by: Alex Bennée --- util/qemu-timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index ffe9a3c5c1..7b71655416 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.

Re: [PATCH 19/20] tests/functional: remove hacky sleep from the tests

2024-12-10 Thread Richard Henderson
On 12/10/24 14:43, Alex Bennée wrote: We have proper detection of prompts now so we don't need to guess with sleep() sprinkled through the test. The extra step of calling halt is just to flush the final bits of the log (although the last line is still missed). Signed-off-by: Alex Bennée Revie

Re: [PATCH v5 18/20] intel_iommu: Introduce a property x-flts for scalable modern mode

2024-12-10 Thread Jason Wang
On Wed, Dec 11, 2024 at 10:50 AM Duan, Zhenzhong wrote: > > Hi Jason, Clement, > > Sorry for late reply, just back from vacation. > > >-Original Message- > >From: CLEMENT MATHIEU--DRIF > >Subject: Re: [PATCH v5 18/20] intel_iommu: Introduce a property x-flts for > >scalable modern mode >

Re: [RFC PATCH 5/5] hw/arm/virt-acpi-build: Add IORT RMR regions to handle MSI nested binding

2024-12-10 Thread Nicolin Chen
Hi Eric/Don/Shameer, On Fri, Nov 08, 2024 at 12:52:42PM +, Shameer Kolothum wrote: > Those IOVAs belong to [0x800, 0x810] matching > MSI_IOVA_BASE and MSI_IOVA_LENGTH definitions in kernel > arm-smmu-v3 driver. This is the window used to allocate > IOVAs matching physical MSI doorbells

Re: [PATCH v3 22/24] vfio/migration: Multifd device state transfer support - receive side

2024-12-10 Thread Maciej S. Szmigiero
Hi Cédric, On 2.12.2024 18:56, Cédric Le Goater wrote: Hello Maciej, On 11/17/24 20:20, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" The multifd received data needs to be reassembled since device state packets sent via different multifd channels can arrive out-of-order. Therefore,

Re: [PATCH v3 08/24] migration: Add thread pool of optional load threads

2024-12-10 Thread Maciej S. Szmigiero
On 5.12.2024 17:15, Peter Xu wrote: On Wed, Dec 04, 2024 at 05:48:52PM -0500, Peter Xu wrote: @@ -71,6 +72,10 @@   const unsigned int postcopy_ram_discard_version; +static ThreadPool *load_threads; +static int load_threads_ret; +static bool load_threads_abort; One thing I forgot to mention in

Re: [PATCH v3 08/24] migration: Add thread pool of optional load threads

2024-12-10 Thread Maciej S. Szmigiero
On 4.12.2024 23:43, Peter Xu wrote: On Thu, Nov 28, 2024 at 01:11:53PM +0100, Maciej S. Szmigiero wrote: +static int qemu_loadvm_load_thread(void *thread_opaque) +{ +    struct LoadThreadData *data = thread_opaque; +    int ret; + +    ret = data->function(&load_threads_abort, data->opaque); +  

  1   2   3   4   >